October 2006 - Wine-Commits

Saulius Krasuckas : lz32/tests: Non-op cosmetics for LZOpenFile[AW] operations.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: 98bfe9c6a95323da8df485972cae32da0207fc18 URL: http://source.winehq.org/git/wine.git/?a=commit;h=98bfe9c6a95323da8df485972… Author: Saulius Krasuckas <saulius.krasuckas(a)ieee.org> Date: Tue Oct 10 18:57:16 2006 +0300 lz32/tests: Non-op cosmetics for LZOpenFile[AW] operations. --- dlls/lz32/tests/lzexpand_main.c | 25 +++++++++++++++++++------ 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/dlls/lz32/tests/lzexpand_main.c b/dlls/lz32/tests/lzexpand_main.c index 7e653ee..8287634 100644 --- a/dlls/lz32/tests/lzexpand_main.c +++ b/dlls/lz32/tests/lzexpand_main.c @@ -363,16 +363,23 @@ static void test_LZOpenFileA(void) ok(retval != INVALID_FILE_ATTRIBUTES, "GetFileAttributesA: error %ld\n", GetLastError()); - /* Check various opening options. */ + /* Check various opening options: */ + /* a, for reading. */ file = LZOpenFileA(filename_, &test, OF_READ); ok(file >= 0, "LZOpenFileA failed on read\n"); LZClose(file); + + /* b, for writing. */ file = LZOpenFileA(filename_, &test, OF_WRITE); ok(file >= 0, "LZOpenFileA failed on write\n"); LZClose(file); + + /* c, for reading and writing. */ file = LZOpenFileA(filename_, &test, OF_READWRITE); ok(file >= 0, "LZOpenFileA failed on read/write\n"); LZClose(file); + + /* d, for checking file existance. */ file = LZOpenFileA(filename_, &test, OF_EXIST); ok(file >= 0, "LZOpenFileA failed on read/write\n"); LZClose(file); @@ -456,8 +463,7 @@ static void test_LZCopy(void) LZClose(source); LZClose(dest); - file = CreateFileA(filename2, GENERIC_READ, 0, NULL, OPEN_EXISTING, - 0, 0); + file = CreateFileA(filename2, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, 0); ok(file != INVALID_HANDLE_VALUE, "CreateFileA: error %ld\n", GetLastError()); @@ -695,28 +701,35 @@ static void test_LZOpenFileW(void) trace("LZOpenFileW call not implemented, skipping rest of the test\n"); return; } - ok(file == LZERROR_BADINHANDLE, - "LZOpenFileW succeeded on nonexistent file\n"); + ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); LZClose(file); /* Create an empty file. */ file = LZOpenFileW(filenameW_, &test, OF_CREATE); ok(file >= 0, "LZOpenFile failed on creation\n"); + LZClose(file); retval = GetFileAttributesW(filenameW_); ok(retval != INVALID_FILE_ATTRIBUTES, "GetFileAttributes: error %ld\n", GetLastError()); - /* Check various opening options. */ + /* Check various opening options: */ + /* a, for reading. */ file = LZOpenFileW(filenameW_, &test, OF_READ); ok(file >= 0, "LZOpenFileW failed on read\n"); LZClose(file); + + /* b, for writing. */ file = LZOpenFileW(filenameW_, &test, OF_WRITE); ok(file >= 0, "LZOpenFileW failed on write\n"); LZClose(file); + + /* c, for reading and writing. */ file = LZOpenFileW(filenameW_, &test, OF_READWRITE); ok(file >= 0, "LZOpenFileW failed on read/write\n"); LZClose(file); + + /* d, for checking file existance. */ file = LZOpenFileW(filenameW_, &test, OF_EXIST); ok(file >= 0, "LZOpenFileW failed on read/write\n"); LZClose(file);

1 0

Saulius Krasuckas : lz32/tests: Test more last errors set by LZOpenFile[AW] .
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: dbe8adf29c486b004fbae9cf464d446e7b046f5a URL: http://source.winehq.org/git/wine.git/?a=commit;h=dbe8adf29c486b004fbae9cf4… Author: Saulius Krasuckas <saulius.krasuckas(a)ieee.org> Date: Tue Oct 10 18:44:31 2006 +0300 lz32/tests: Test more last errors set by LZOpenFile[AW]. --- dlls/lz32/tests/lzexpand_main.c | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/dlls/lz32/tests/lzexpand_main.c b/dlls/lz32/tests/lzexpand_main.c index ff55a33..7e653ee 100644 --- a/dlls/lz32/tests/lzexpand_main.c +++ b/dlls/lz32/tests/lzexpand_main.c @@ -131,6 +131,7 @@ static void test_LZOpenFileA_existing_co memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee); /* a, using 8.3-conformant file name. */ file = LZOpenFileA(filename, &test, OF_EXIST); @@ -148,6 +149,8 @@ static void test_LZOpenFileA_existing_co test.szPathName, expected); LZClose(file); } else { /* Win9x */ + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); ok(test.nErrCode == ERROR_FILE_NOT_FOUND, @@ -160,6 +163,7 @@ static void test_LZOpenFileA_existing_co memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(dotless_, expected, FALSE); + SetLastError(0xfaceabee); /* b, using dotless file name. */ file = LZOpenFileA(dotless, &test, OF_EXIST); @@ -173,6 +177,8 @@ static void test_LZOpenFileA_existing_co test.szPathName, expected); LZClose(file); } else { /* Win9x */ + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); @@ -187,6 +193,7 @@ static void test_LZOpenFileA_existing_co memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(extless_, expected, FALSE); + SetLastError(0xfaceabee); /* c, using extensionless file name. */ file = LZOpenFileA(extless, &test, OF_EXIST); @@ -200,6 +207,8 @@ static void test_LZOpenFileA_existing_co test.szPathName, expected); LZClose(file); } else { /* Win9x */ + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); ok(test.nErrCode == ERROR_FILE_NOT_FOUND, @@ -244,6 +253,7 @@ static void test_LZOpenFileA_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee); /* a, using 8.3-conformant file name. */ file = LZOpenFileA(filename, &test, OF_EXIST); @@ -253,6 +263,8 @@ static void test_LZOpenFileA_nonexisting */ ok(file == LZERROR_BADINHANDLE, "LZOpenFileA succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); @@ -266,11 +278,14 @@ static void test_LZOpenFileA_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(dotless_, expected, FALSE); + SetLastError(0xfaceabee); /* b, using dotless file name. */ file = LZOpenFileA(dotless, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileA succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); @@ -284,11 +299,14 @@ static void test_LZOpenFileA_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(extless_, expected, FALSE); + SetLastError(0xfaceabee); /* c, using extensionless file name. */ file = LZOpenFileA(extless, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileA succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); @@ -302,11 +320,14 @@ static void test_LZOpenFileA_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(_terminated_, expected, FALSE); + SetLastError(0xfaceabee); /* d, using underscore-terminated file name. */ file = LZOpenFileA(_terminated, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileA succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileA set test.cBytes to %d\n", test.cBytes); @@ -575,6 +596,7 @@ static void test_LZOpenFileW_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee); /* a, using 8.3-conformant file name. */ file = LZOpenFileW(filenameW, &test, OF_EXIST); @@ -584,6 +606,8 @@ static void test_LZOpenFileW_nonexisting */ ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileW set test.cBytes to %d\n", test.cBytes); @@ -596,11 +620,14 @@ static void test_LZOpenFileW_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(dotless_, expected, FALSE); + SetLastError(0xfaceabee); /* b, using dotless file name. */ file = LZOpenFileW(dotlessW, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileW set test.cBytes to %d\n", test.cBytes); @@ -613,11 +640,14 @@ static void test_LZOpenFileW_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(extless_, expected, FALSE); + SetLastError(0xfaceabee); /* c, using extensionless file name. */ file = LZOpenFileW(extlessW, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileW set test.cBytes to %d\n", test.cBytes); @@ -630,11 +660,14 @@ static void test_LZOpenFileW_nonexisting memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(_terminated_, expected, FALSE); + SetLastError(0xfaceabee); /* d, using underscore-terminated file name. */ file = LZOpenFileW(_terminatedW, &test, OF_EXIST); ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); + ok(GetLastError() == ERROR_FILE_NOT_FOUND, + "GetLastError() returns %ld\n", GetLastError()); todo_wine ok(test.cBytes == 0xA5, "LZOpenFileW set test.cBytes to %d\n", test.cBytes); @@ -655,6 +688,8 @@ static void test_LZOpenFileW(void) SetLastError(0xfaceabee); /* Check for nonexistent file. */ file = LZOpenFileW(badfilenameW, &test, OF_READ); + ok(GetLastError() == ERROR_FILE_NOT_FOUND || GetLastError() == ERROR_CALL_NOT_IMPLEMENTED, + "GetLastError() returns %ld\n", GetLastError()); if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) { trace("LZOpenFileW call not implemented, skipping rest of the test\n");

1 0

Saulius Krasuckas : lz32/tests: More checks for various LZOpenFile[AW] operations on existing files.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: 346d02edbae207783fde8dd5943003c5955985ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=346d02edbae207783fde8dd59… Author: Saulius Krasuckas <saulius.krasuckas(a)ieee.org> Date: Tue Oct 10 19:34:40 2006 +0300 lz32/tests: More checks for various LZOpenFile[AW] operations on existing files. --- dlls/lz32/tests/lzexpand_main.c | 118 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 117 insertions(+), 1 deletions(-) diff --git a/dlls/lz32/tests/lzexpand_main.c b/dlls/lz32/tests/lzexpand_main.c index 8287634..593d98b 100644 --- a/dlls/lz32/tests/lzexpand_main.c +++ b/dlls/lz32/tests/lzexpand_main.c @@ -140,6 +140,7 @@ static void test_LZOpenFileA_existing_co operating systems. Doesn't seem to on my copy of Win98. */ if(file != LZERROR_BADINHANDLE) { + ok(file >= 0, "LZOpenFileA returns negative file descriptor for '%s'\n", filename); ok(test.cBytes == sizeof(OFSTRUCT), "LZOpenFileA set test.cBytes to %d\n", test.cBytes); ok(test.nErrCode == 0, "LZOpenFileA set test.nErrCode to %d\n", @@ -168,6 +169,7 @@ static void test_LZOpenFileA_existing_co /* b, using dotless file name. */ file = LZOpenFileA(dotless, &test, OF_EXIST); if(file != LZERROR_BADINHANDLE) { + ok(file >= 0, "LZOpenFileA returns negative file descriptor for '%s'\n", dotless); ok(test.cBytes == sizeof(OFSTRUCT), "LZOpenFileA set test.cBytes to %d\n", test.cBytes); ok(test.nErrCode == 0, "LZOpenFileA set test.nErrCode to %d\n", @@ -198,6 +200,7 @@ static void test_LZOpenFileA_existing_co /* c, using extensionless file name. */ file = LZOpenFileA(extless, &test, OF_EXIST); if(file != LZERROR_BADINHANDLE) { + ok(file >= 0, "LZOpenFileA returns negative file descriptor for '%s'\n", extless); ok(test.cBytes == sizeof(OFSTRUCT), "LZOpenFileA set test.cBytes to %d\n", test.cBytes); ok(test.nErrCode == 0, "LZOpenFileA set test.nErrCode to %d\n", @@ -345,6 +348,7 @@ static void test_LZOpenFileA(void) DWORD retval; INT file; static char badfilename_[] = "badfilename_"; + char expected[MAX_PATH]; SetLastError(0xfaceabee); /* Check for nonexistent file. */ @@ -355,38 +359,94 @@ static void test_LZOpenFileA(void) "GetLastError() returns %ld\n", GetLastError()); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + full_file_path_name_in_a_CWD(filename_, expected, FALSE); + /* Create an empty file. */ file = LZOpenFileA(filename_, &test, OF_CREATE); ok(file >= 0, "LZOpenFileA failed on creation\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + retval = GetFileAttributesA(filename_); ok(retval != INVALID_FILE_ATTRIBUTES, "GetFileAttributesA: error %ld\n", GetLastError()); /* Check various opening options: */ + memset(&test, 0xA5, sizeof(test)); + /* a, for reading. */ file = LZOpenFileA(filename_, &test, OF_READ); ok(file >= 0, "LZOpenFileA failed on read\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* b, for writing. */ file = LZOpenFileA(filename_, &test, OF_WRITE); ok(file >= 0, "LZOpenFileA failed on write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* c, for reading and writing. */ file = LZOpenFileA(filename_, &test, OF_READWRITE); ok(file >= 0, "LZOpenFileA failed on read/write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* d, for checking file existance. */ file = LZOpenFileA(filename_, &test, OF_EXIST); ok(file >= 0, "LZOpenFileA failed on read/write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* Delete the file then make sure it doesn't exist anymore. */ file = LZOpenFileA(filename_, &test, OF_DELETE); ok(file >= 0, "LZOpenFileA failed on delete\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileA set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileA set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileA returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); retval = GetFileAttributesA(filename_); @@ -690,6 +750,7 @@ static void test_LZOpenFileW(void) DWORD retval; INT file; static WCHAR badfilenameW[] = {'b','a','d','f','i','l','e','n','a','m','e','.','x','t','n',0}; + char expected[MAX_PATH]; SetLastError(0xfaceabee); /* Check for nonexistent file. */ @@ -704,39 +765,94 @@ static void test_LZOpenFileW(void) ok(file == LZERROR_BADINHANDLE, "LZOpenFileW succeeded on nonexistent file\n"); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + full_file_path_name_in_a_CWD(filename_, expected, FALSE); + /* Create an empty file. */ file = LZOpenFileW(filenameW_, &test, OF_CREATE); ok(file >= 0, "LZOpenFile failed on creation\n"); - + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + retval = GetFileAttributesW(filenameW_); ok(retval != INVALID_FILE_ATTRIBUTES, "GetFileAttributes: error %ld\n", GetLastError()); /* Check various opening options: */ + memset(&test, 0xA5, sizeof(test)); + /* a, for reading. */ file = LZOpenFileW(filenameW_, &test, OF_READ); ok(file >= 0, "LZOpenFileW failed on read\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* b, for writing. */ file = LZOpenFileW(filenameW_, &test, OF_WRITE); ok(file >= 0, "LZOpenFileW failed on write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* c, for reading and writing. */ file = LZOpenFileW(filenameW_, &test, OF_READWRITE); ok(file >= 0, "LZOpenFileW failed on read/write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* d, for checking file existance. */ file = LZOpenFileW(filenameW_, &test, OF_EXIST); ok(file >= 0, "LZOpenFileW failed on read/write\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); + memset(&test, 0xA5, sizeof(test)); + /* Delete the file then make sure it doesn't exist anymore. */ file = LZOpenFileW(filenameW_, &test, OF_DELETE); ok(file >= 0, "LZOpenFileW failed on delete\n"); + ok(test.cBytes == sizeof(OFSTRUCT), + "LZOpenFileW set test.cBytes to %d\n", test.cBytes); + ok(test.nErrCode == ERROR_SUCCESS, + "LZOpenFileW set test.nErrCode to %d\n", test.nErrCode); + ok(lstrcmpA(test.szPathName, expected) == 0, + "LZOpenFileW returned '%s', but was expected to return '%s'\n", + test.szPathName, expected); LZClose(file); retval = GetFileAttributesW(filenameW_);

1 0

H. Verbeet : ddraw/tests: Win64 printf format warning fixes.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: 37cb9de85174ea7e347aa4e7d127480a3d399bbd URL: http://source.winehq.org/git/wine.git/?a=commit;h=37cb9de85174ea7e347aa4e7d… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Tue Oct 10 19:23:33 2006 +0200 ddraw/tests: Win64 printf format warning fixes. --- dlls/ddraw/tests/Makefile.in | 1 dlls/ddraw/tests/d3d.c | 88 +++++++++++++++++++++-------------------- dlls/ddraw/tests/ddrawmodes.c | 64 +++++++++++++++--------------- dlls/ddraw/tests/dsurface.c | 50 ++++++++++++----------- dlls/ddraw/tests/refcount.c | 86 ++++++++++++++++++++-------------------- 5 files changed, 144 insertions(+), 145 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=37cb9de85174ea7e347aa…

1 0

H. Verbeet : d3d9: Win64 printf format warning fixes.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: cb4ad6e52cfe5f293f5b97f7c3c1e131317d44fb URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb4ad6e52cfe5f293f5b97f7c… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Tue Oct 10 19:23:22 2006 +0200 d3d9: Win64 printf format warning fixes. --- dlls/d3d9/Makefile.in | 1 - dlls/d3d9/basetexture.c | 4 ++-- dlls/d3d9/cubetexture.c | 6 +++--- dlls/d3d9/d3d9_main.c | 10 +++++----- dlls/d3d9/device.c | 12 ++++++------ dlls/d3d9/directx.c | 4 ++-- dlls/d3d9/indexbuffer.c | 4 ++-- dlls/d3d9/pixelshader.c | 4 ++-- dlls/d3d9/query.c | 6 +++--- dlls/d3d9/resource.c | 4 ++-- dlls/d3d9/stateblock.c | 4 ++-- dlls/d3d9/surface.c | 6 +++--- dlls/d3d9/swapchain.c | 4 ++-- dlls/d3d9/texture.c | 6 +++--- dlls/d3d9/vertexbuffer.c | 4 ++-- dlls/d3d9/vertexdeclaration.c | 4 ++-- dlls/d3d9/vertexshader.c | 8 ++++---- dlls/d3d9/volume.c | 6 +++--- dlls/d3d9/volumetexture.c | 6 +++--- 19 files changed, 51 insertions(+), 52 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cb4ad6e52cfe5f293f5b9…

1 0

H. Verbeet : d3d8: Win64 printf format warning fixes.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: c6e0ca28d549c795f8820088c2e66b06c72da0be URL: http://source.winehq.org/git/wine.git/?a=commit;h=c6e0ca28d549c795f8820088c… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Tue Oct 10 19:23:08 2006 +0200 d3d8: Win64 printf format warning fixes. --- dlls/d3d8/Makefile.in | 1 - dlls/d3d8/basetexture.c | 4 ++-- dlls/d3d8/cubetexture.c | 4 ++-- dlls/d3d8/d3d8_main.c | 2 +- dlls/d3d8/device.c | 38 +++++++++++++++++++------------------- dlls/d3d8/directx.c | 4 ++-- dlls/d3d8/indexbuffer.c | 4 ++-- dlls/d3d8/pixelshader.c | 4 ++-- dlls/d3d8/resource.c | 4 ++-- dlls/d3d8/stateblock.c | 4 ++-- dlls/d3d8/surface.c | 6 +++--- dlls/d3d8/swapchain.c | 4 ++-- dlls/d3d8/texture.c | 4 ++-- dlls/d3d8/vertexbuffer.c | 4 ++-- dlls/d3d8/vertexshader.c | 4 ++-- dlls/d3d8/volume.c | 6 +++--- dlls/d3d8/volumetexture.c | 6 +++--- 17 files changed, 51 insertions(+), 52 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c6e0ca28d549c795f8820…

1 0

H. Verbeet : d3d8/tests: Win64 printf format warning fixes.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: a5d034201078e384e9e192025fa47d97712328c7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a5d034201078e384e9e192025… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Tue Oct 10 19:23:14 2006 +0200 d3d8/tests: Win64 printf format warning fixes. --- dlls/d3d8/tests/Makefile.in | 1 - dlls/d3d8/tests/d3d8_main.c | 36 ++++++++++++++++++------------------ dlls/d3d8/tests/device.c | 8 ++++---- 3 files changed, 22 insertions(+), 23 deletions(-) diff --git a/dlls/d3d8/tests/Makefile.in b/dlls/d3d8/tests/Makefile.in index 5a2f52d..4af5df3 100644 --- a/dlls/d3d8/tests/Makefile.in +++ b/dlls/d3d8/tests/Makefile.in @@ -5,7 +5,6 @@ VPATH = @srcdir@ TESTDLL = d3d8.dll IMPORTS = user32 kernel32 EXTRALIBS = -ldxerr8 -EXTRADEFS = -DWINE_NO_LONG_AS_INT CTESTS = \ d3d8_main.c \ diff --git a/dlls/d3d8/tests/d3d8_main.c b/dlls/d3d8/tests/d3d8_main.c index f70b6d8..a001f31 100644 --- a/dlls/d3d8/tests/d3d8_main.c +++ b/dlls/d3d8/tests/d3d8_main.c @@ -32,37 +32,37 @@ static void test_ValidateVertexShader(vo 0x0000FFFF}; ret=ValidateVertexShader(0,0,0,0,0); - ok(ret==E_FAIL,"ValidateVertexShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidateVertexShader returned %x but expected E_FAIL\n",ret); ret=ValidateVertexShader(0,0,0,1,0); - ok(ret==E_FAIL,"ValidateVertexShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidateVertexShader returned %x but expected E_FAIL\n",ret); ret=ValidateVertexShader(simple_vs,0,0,0,0); - ok(ret==S_OK,"ValidateVertexShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidateVertexShader returned %x but expected S_OK\n",ret); ret=ValidateVertexShader(simple_vs,0,0,1,0); - ok(ret==S_OK,"ValidateVertexShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidateVertexShader returned %x but expected S_OK\n",ret); /* seems to do some version checking */ *simple_vs=0xFFFE0100; /* vs_1_0 */ ret=ValidateVertexShader(simple_vs,0,0,0,0); - ok(ret==S_OK,"ValidateVertexShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidateVertexShader returned %x but expected S_OK\n",ret); *simple_vs=0xFFFE0102; /* bogus version */ ret=ValidateVertexShader(simple_vs,0,0,1,0); - ok(ret==E_FAIL,"ValidateVertexShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidateVertexShader returned %x but expected E_FAIL\n",ret); /* I've seen that applications pass 2nd and 3rd parameter always as 0;simple test with non-zero parameters */ *simple_vs=0xFFFE0101; /* vs_1_1 */ ret=ValidateVertexShader(simple_vs,simple_vs,0,1,0); - ok(ret==E_FAIL,"ValidateVertexShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidateVertexShader returned %x but expected E_FAIL\n",ret); ret=ValidateVertexShader(simple_vs,0,simple_vs,1,0); - ok(ret==E_FAIL,"ValidateVertexShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidateVertexShader returned %x but expected E_FAIL\n",ret); /* I've seen 4th parameter is always passed as either 0 or 1, but passing other values doesn't seem to hurt*/ ret=ValidateVertexShader(simple_vs,0,0,12345,0); - ok(ret==S_OK,"ValidateVertexShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidateVertexShader returned %x but expected S_OK\n",ret); /* What is 5th parameter ???? Following works ok */ ret=ValidateVertexShader(simple_vs,0,0,1,simple_vs); - ok(ret==S_OK,"ValidateVertexShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidateVertexShader returned %x but expected S_OK\n",ret); } static void test_ValidatePixelShader(void) @@ -77,30 +77,30 @@ static void test_ValidatePixelShader(voi 0x0000FFFF}; /* END */ ret=ValidatePixelShader(0,0,0,0); - ok(ret==E_FAIL,"ValidatePixelShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidatePixelShader returned %x but expected E_FAIL\n",ret); ret=ValidatePixelShader(0,0,1,0); - ok(ret==E_FAIL,"ValidatePixelShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidatePixelShader returned %x but expected E_FAIL\n",ret); ret=ValidatePixelShader(simple_ps,0,0,0); - ok(ret==S_OK,"ValidatePixelShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidatePixelShader returned %x but expected S_OK\n",ret); ret=ValidatePixelShader(simple_ps,0,1,0); - ok(ret==S_OK,"ValidatePixelShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidatePixelShader returned %x but expected S_OK\n",ret); /* seems to do some version checking */ *simple_ps=0xFFFF0105; /* bogus version */ ret=ValidatePixelShader(simple_ps,0,1,0); - ok(ret==E_FAIL,"ValidatePixelShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidatePixelShader returned %x but expected E_FAIL\n",ret); /* I've seen that applications pass 2nd parameter always as 0;simple test with non-zero parameter */ *simple_ps=0xFFFF0101; /* ps_1_1 */ ret=ValidatePixelShader(simple_ps,simple_ps,1,0); - ok(ret==E_FAIL,"ValidatePixelShader returned %lx but expected E_FAIL\n",ret); + ok(ret==E_FAIL,"ValidatePixelShader returned %x but expected E_FAIL\n",ret); /* I've seen 3rd parameter is always passed as either 0 or 1, but passing other values doesn't seem to hurt*/ ret=ValidatePixelShader(simple_ps,0,12345,0); - ok(ret==S_OK,"ValidatePixelShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidatePixelShader returned %x but expected S_OK\n",ret); /* What is 4th parameter ???? Following works ok */ ret=ValidatePixelShader(simple_ps,0,1,simple_ps); - ok(ret==S_OK,"ValidatePixelShader returned %lx but expected S_OK\n",ret); + ok(ret==S_OK,"ValidatePixelShader returned %x but expected S_OK\n",ret); } START_TEST(d3d8_main) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 901b4ba..e735502 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -270,13 +270,13 @@ static void test_refcount(void) BYTE *data; /* Vertex buffers can be locked multiple times */ hr = IDirect3DVertexBuffer8_Lock(pVertexBuffer, 0, 0, &data, 0); - ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08lx\n", hr); + ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08x\n", hr); hr = IDirect3DVertexBuffer8_Lock(pVertexBuffer, 0, 0, &data, 0); - ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08lx\n", hr); + ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Lock failed with %08x\n", hr); hr = IDirect3DVertexBuffer8_Unlock(pVertexBuffer); - ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08lx\n", hr); + ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08x\n", hr); hr = IDirect3DVertexBuffer8_Unlock(pVertexBuffer); - ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08lx\n", hr); + ok(hr == D3D_OK, "IDirect3DVertexBuffer8::Unlock failed with %08x\n", hr); } cleanup:

1 0

H. Verbeet : wined3d: Improve shader_dump_decl_usage() TRACEs.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: 94a86c12245a7cd5b85533f600b85659c775c05e URL: http://source.winehq.org/git/wine.git/?a=commit;h=94a86c12245a7cd5b85533f60… Author: H. Verbeet <hverbeet(a)gmail.com> Date: Tue Oct 10 19:23:01 2006 +0200 wined3d: Improve shader_dump_decl_usage() TRACEs. --- dlls/wined3d/baseshader.c | 30 +++++++++++++++--------------- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/wined3d/baseshader.c b/dlls/wined3d/baseshader.c index 3903fe5..d53f2c8 100644 --- a/dlls/wined3d/baseshader.c +++ b/dlls/wined3d/baseshader.c @@ -421,50 +421,50 @@ static void shader_dump_decl_usage( switch(usage) { case D3DDECLUSAGE_POSITION: - TRACE("%s%d", "position", idx); + TRACE("position%d", idx); break; case D3DDECLUSAGE_BLENDINDICES: - TRACE("%s", "blend"); + TRACE("blend"); break; case D3DDECLUSAGE_BLENDWEIGHT: - TRACE("%s", "weight"); + TRACE("weight"); break; case D3DDECLUSAGE_NORMAL: - TRACE("%s%d", "normal", idx); + TRACE("normal%d", idx); break; case D3DDECLUSAGE_PSIZE: - TRACE("%s", "psize"); + TRACE("psize"); break; case D3DDECLUSAGE_COLOR: if(idx == 0) { - TRACE("%s", "color"); + TRACE("color"); } else { - TRACE("%s%d", "specular", (idx - 1)); + TRACE("specular%d", (idx - 1)); } break; case D3DDECLUSAGE_TEXCOORD: - TRACE("%s%d", "texture", idx); + TRACE("texture%d", idx); break; case D3DDECLUSAGE_TANGENT: - TRACE("%s", "tangent"); + TRACE("tangent"); break; case D3DDECLUSAGE_BINORMAL: - TRACE("%s", "binormal"); + TRACE("binormal"); break; case D3DDECLUSAGE_TESSFACTOR: - TRACE("%s", "tessfactor"); + TRACE("tessfactor"); break; case D3DDECLUSAGE_POSITIONT: - TRACE("%s%d", "positionT", idx); + TRACE("positionT%d", idx); break; case D3DDECLUSAGE_FOG: - TRACE("%s", "fog"); + TRACE("fog"); break; case D3DDECLUSAGE_DEPTH: - TRACE("%s", "depth"); + TRACE("depth"); break; case D3DDECLUSAGE_SAMPLE: - TRACE("%s", "sample"); + TRACE("sample"); break; default: FIXME("unknown_semantics(%08x)", usage);

1 0

Karsten Elfenbein : wined3d: Corrected names in checkGLcall text.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: f2d77d103f4bce44c05d759aae848f1584fa8bd0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f2d77d103f4bce44c05d759aa… Author: Karsten Elfenbein <kelfe(a)gmx.de> Date: Tue Oct 10 18:58:39 2006 +0200 wined3d: Corrected names in checkGLcall text. --- dlls/wined3d/query.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/query.c b/dlls/wined3d/query.c index b7c87c3..b0c1482 100644 --- a/dlls/wined3d/query.c +++ b/dlls/wined3d/query.c @@ -163,12 +163,12 @@ static HRESULT WINAPI IWineD3DQueryImpl GLuint queryId = ((WineQueryOcclusionData *)This->extendedData)->queryId; GL_EXTCALL(glGetQueryObjectuivARB(queryId, GL_QUERY_RESULT_AVAILABLE_ARB, &available)); - checkGLcall("glGetQueryObjectiv(GL_QUERY_RESULT_AVAILABLE)\n"); + checkGLcall("glGetQueryObjectuivARB(GL_QUERY_RESULT_AVAILABLE)\n"); TRACE("(%p) : available %d.\n", This, available); if (available || dwGetDataFlags & WINED3DGETDATA_FLUSH) { GL_EXTCALL(glGetQueryObjectuivARB(queryId, GL_QUERY_RESULT_ARB, &samples)); - checkGLcall("glGetQueryObjectuiv(GL_QUERY_RESULT)\n"); + checkGLcall("glGetQueryObjectuivARB(GL_QUERY_RESULT)\n"); TRACE("(%p) : Returning %d samples.\n", This, samples); *data = samples; res = S_OK;

1 0

Jesse Allen : ddraw: Fix for DDSURFACEDESC param in CreateSurface.
by Alexandre Julliard Oct. 10, 2006

Oct. 10, 2006

Module: wine Branch: master Commit: 52296dbdbf5b2137f19ae0582bab6bcba2317bdb URL: http://source.winehq.org/git/wine.git/?a=commit;h=52296dbdbf5b2137f19ae0582… Author: Jesse Allen <the3dfxdude(a)gmail.com> Date: Tue Oct 10 09:06:28 2006 -0700 ddraw: Fix for DDSURFACEDESC param in CreateSurface. --- dlls/ddraw/ddraw.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 341d936..5b72aa5 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -2136,7 +2136,8 @@ IDirectDrawImpl_CreateSurface(IDirectDra } /* According to the msdn this flag is ignored by CreateSurface */ - DDSD->ddsCaps.dwCaps2 &= ~DDSCAPS2_MIPMAPSUBLEVEL; + if (DDSD->dwSize >= sizeof(DDSURFACEDESC2)) + DDSD->ddsCaps.dwCaps2 &= ~DDSCAPS2_MIPMAPSUBLEVEL; /* Modify some flags */ memset(&desc2, 0, sizeof(desc2)); @@ -2314,7 +2315,7 @@ IDirectDrawImpl_CreateSurface(IDirectDra desc2.ddsCaps.dwCaps |= DDSCAPS_BACKBUFFER; } /* Set the DDSCAPS2_MIPMAPSUBLEVEL flag on mipmap sublevels according to the msdn */ - if(DDSD->ddsCaps.dwCaps & DDSCAPS_MIPMAP) + if((DDSD->ddsCaps.dwCaps & DDSCAPS_MIPMAP)&&(DDSD->dwSize >= sizeof(DDSURFACEDESC2))) { desc2.ddsCaps.dwCaps2 |= DDSCAPS2_MIPMAPSUBLEVEL; }

1 0