December 2006 - Wine-Commits

James Hawkins : cabinet: Close the opened file handle even in error cases.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: a79765ff02ad5c4a8bbe070b8b82430027fe2261 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a79765ff02ad5c4a8bbe070b8… Author: James Hawkins <truiken(a)gmail.com> Date: Fri Dec 15 03:47:15 2006 -0600 cabinet: Close the opened file handle even in error cases. --- dlls/cabinet/fdi.c | 33 +++++++++++---------------------- 1 files changed, 11 insertions(+), 22 deletions(-) diff --git a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c index 0cb319c..70db803 100644 --- a/dlls/cabinet/fdi.c +++ b/dlls/cabinet/fdi.c @@ -2809,6 +2809,17 @@ BOOL __cdecl FDICopy( err = fdi_decomp(file, 1, decomp_state, pszCabPath, pfnfdin, pvUser); if (err) CAB(current) = NULL; else CAB(offset) += file->length; + /* fdintCLOSE_FILE_INFO notification */ + ZeroMemory(&fdin, sizeof(FDINOTIFICATION)); + fdin.pv = pvUser; + fdin.psz1 = (char *)file->filename; + fdin.hf = filehf; + fdin.cb = (file->attribs & cffile_A_EXEC) ? TRUE : FALSE; /* FIXME: is that right? */ + fdin.date = file->date; + fdin.time = file->time; + fdin.attribs = file->attribs; /* FIXME: filter _A_EXEC? */ + ((*pfnfdin)(fdintCLOSE_FILE_INFO, &fdin)); + switch (err) { case DECR_OK: break; @@ -2829,28 +2840,6 @@ BOOL __cdecl FDICopy( PFDI_INT(hfdi)->perf->fError = TRUE; goto bail_and_fail; } - - /* fdintCLOSE_FILE_INFO notification */ - ZeroMemory(&fdin, sizeof(FDINOTIFICATION)); - fdin.pv = pvUser; - fdin.psz1 = (char *)file->filename; - fdin.hf = filehf; - fdin.cb = (file->attribs & cffile_A_EXEC) ? TRUE : FALSE; /* FIXME: is that right? */ - fdin.date = file->date; - fdin.time = file->time; - fdin.attribs = file->attribs; /* FIXME: filter _A_EXEC? */ - err = ((*pfnfdin)(fdintCLOSE_FILE_INFO, &fdin)); - if (err == FALSE || err == -1) { - /* - * SDK states that even though they indicated failure, - * we are not supposed to try and close the file, so we - * just treat this like all the others - */ - PFDI_INT(hfdi)->perf->erfOper = FDIERROR_USER_ABORT; - PFDI_INT(hfdi)->perf->erfType = 0; - PFDI_INT(hfdi)->perf->fError = TRUE; - goto bail_and_fail; - } } }

1 0

Alexandre Julliard : msvcrt: Make pointers to read-only exception descriptors const.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 8592c4b876c95d86e3b8a608cfd6daea9ef514b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8592c4b876c95d86e3b8a608c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 15 13:41:31 2006 +0100 msvcrt: Make pointers to read-only exception descriptors const. --- dlls/msvcrt/cppexcept.c | 28 +++++++++++++++------------- dlls/msvcrt/cppexcept.h | 32 ++++++++++++++++---------------- 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/dlls/msvcrt/cppexcept.c b/dlls/msvcrt/cppexcept.c index 52b17a4..c4679c3 100644 --- a/dlls/msvcrt/cppexcept.c +++ b/dlls/msvcrt/cppexcept.c @@ -45,8 +45,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(seh); DWORD CDECL cxx_frame_handler( PEXCEPTION_RECORD rec, cxx_exception_frame* frame, PCONTEXT context, EXCEPTION_REGISTRATION_RECORD** dispatch, - cxx_function_descr *descr, EXCEPTION_REGISTRATION_RECORD* nested_frame, - int nested_trylevel ); + const cxx_function_descr *descr, + EXCEPTION_REGISTRATION_RECORD* nested_frame, int nested_trylevel ); /* call a function with a given ebp */ inline static void *call_ebp_func( void *func, void *ebp ) @@ -112,7 +112,7 @@ static void dump_exception_type( const c } } -static void dump_function_descr( const cxx_function_descr *descr, const cxx_exception_type *info ) +static void dump_function_descr( const cxx_function_descr *descr ) { UINT i; int j; @@ -133,7 +133,7 @@ static void dump_function_descr( const c descr->tryblock[i].catchblock_count ); for (j = 0; j < descr->tryblock[i].catchblock_count; j++) { - catchblock_info *ptr = &descr->tryblock[i].catchblock[j]; + const catchblock_info *ptr = &descr->tryblock[i].catchblock[j]; TRACE( " %d: flags %x offset %d handler %p type %p %s\n", j, ptr->flags, ptr->offset, ptr->handler, ptr->type_info, dbgstr_type_info( ptr->type_info ) ); @@ -142,7 +142,8 @@ static void dump_function_descr( const c } /* check if the exception type is caught by a given catch block, and return the type that matched */ -static const cxx_type_info *find_caught_type( cxx_exception_type *exc_type, catchblock_info *catchblock ) +static const cxx_type_info *find_caught_type( cxx_exception_type *exc_type, + const catchblock_info *catchblock ) { UINT i; @@ -168,7 +169,7 @@ static const cxx_type_info *find_caught_ /* copy the exception object where the catch block wants it */ static void copy_exception( void *object, cxx_exception_frame *frame, - catchblock_info *catchblock, const cxx_type_info *type ) + const catchblock_info *catchblock, const cxx_type_info *type ) { void **dest_ptr; @@ -197,7 +198,7 @@ static void copy_exception( void *object } /* unwind the local function up to a given trylevel */ -static void cxx_local_unwind( cxx_exception_frame* frame, cxx_function_descr *descr, int last_level) +static void cxx_local_unwind( cxx_exception_frame* frame, const cxx_function_descr *descr, int last_level) { void (*handler)(); int trylevel = frame->trylevel; @@ -227,7 +228,7 @@ struct catch_func_nested_frame EXCEPTION_REGISTRATION_RECORD frame; /* standard exception frame */ EXCEPTION_RECORD *prev_rec; /* previous record to restore in thread data */ cxx_exception_frame *cxx_frame; /* frame of parent exception */ - cxx_function_descr *descr; /* descriptor of parent exception */ + const cxx_function_descr *descr; /* descriptor of parent exception */ int trylevel; /* current try level */ EXCEPTION_RECORD *rec; /* rec associated with frame */ }; @@ -276,7 +277,7 @@ static DWORD catch_function_nested_handl /* find and call the appropriate catch block for an exception */ /* returns the address to continue execution to after the catch block was called */ inline static void call_catch_block( PEXCEPTION_RECORD rec, cxx_exception_frame *frame, - cxx_function_descr *descr, int nested_trylevel, + const cxx_function_descr *descr, int nested_trylevel, cxx_exception_type *info ) { UINT i; @@ -289,7 +290,7 @@ inline static void call_catch_block( PEX for (i = 0; i < descr->tryblock_count; i++) { - tryblock_info *tryblock = &descr->tryblock[i]; + const tryblock_info *tryblock = &descr->tryblock[i]; if (trylevel < tryblock->start_level) continue; if (trylevel > tryblock->end_level) continue; @@ -297,7 +298,7 @@ inline static void call_catch_block( PEX /* got a try block */ for (j = 0; j < tryblock->catchblock_count; j++) { - catchblock_info *catchblock = &tryblock->catchblock[j]; + const catchblock_info *catchblock = &tryblock->catchblock[j]; if(info) { const cxx_type_info *type = find_caught_type( info, catchblock ); @@ -357,7 +358,8 @@ inline static void call_catch_block( PEX */ DWORD CDECL cxx_frame_handler( PEXCEPTION_RECORD rec, cxx_exception_frame* frame, PCONTEXT context, EXCEPTION_REGISTRATION_RECORD** dispatch, - cxx_function_descr *descr, EXCEPTION_REGISTRATION_RECORD* nested_frame, + const cxx_function_descr *descr, + EXCEPTION_REGISTRATION_RECORD* nested_frame, int nested_trylevel ) { cxx_exception_type *exc_type; @@ -390,7 +392,7 @@ DWORD CDECL cxx_frame_handler( PEXCEPTIO TRACE("handling C++ exception rec %p frame %p trylevel %d descr %p nested_frame %p\n", rec, frame, frame->trylevel, descr, nested_frame ); dump_exception_type( exc_type ); - dump_function_descr( descr, exc_type ); + dump_function_descr( descr ); } } else diff --git a/dlls/msvcrt/cppexcept.h b/dlls/msvcrt/cppexcept.h index 8482cc7..d4c8068 100644 --- a/dlls/msvcrt/cppexcept.h +++ b/dlls/msvcrt/cppexcept.h @@ -53,10 +53,10 @@ typedef struct __cxx_exception_frame /* info about a single catch {} block */ typedef struct __catchblock_info { - UINT flags; /* flags (see below) */ - type_info *type_info; /* C++ type caught by this block */ - int offset; /* stack offset to copy exception object to */ - void (*handler)(); /* catch block handler code */ + UINT flags; /* flags (see below) */ + const type_info *type_info; /* C++ type caught by this block */ + int offset; /* stack offset to copy exception object to */ + void (*handler)(); /* catch block handler code */ } catchblock_info; #define TYPE_FLAG_CONST 1 #define TYPE_FLAG_VOLATILE 2 @@ -65,11 +65,11 @@ typedef struct __catchblock_info /* info about a single try {} block */ typedef struct __tryblock_info { - int start_level; /* start trylevel of that block */ - int end_level; /* end trylevel of that block */ - int catch_level; /* initial trylevel of the catch block */ - int catchblock_count; /* count of catch blocks in array */ - catchblock_info *catchblock; /* array of catch blocks */ + int start_level; /* start trylevel of that block */ + int end_level; /* end trylevel of that block */ + int catch_level; /* initial trylevel of the catch block */ + int catchblock_count; /* count of catch blocks in array */ + const catchblock_info *catchblock; /* array of catch blocks */ } tryblock_info; /* info about the unwind handler for a given trylevel */ @@ -82,12 +82,12 @@ typedef struct __unwind_info /* descriptor of all try blocks of a given function */ typedef struct __cxx_function_descr { - UINT magic; /* must be CXX_FRAME_MAGIC */ - UINT unwind_count; /* number of unwind handlers */ - unwind_info *unwind_table; /* array of unwind handlers */ - UINT tryblock_count; /* number of try blocks */ - tryblock_info *tryblock; /* array of try blocks */ - UINT unknown[3]; + UINT magic; /* must be CXX_FRAME_MAGIC */ + UINT unwind_count; /* number of unwind handlers */ + const unwind_info *unwind_table; /* array of unwind handlers */ + UINT tryblock_count; /* number of try blocks */ + const tryblock_info *tryblock; /* array of try blocks */ + UINT unknown[3]; } cxx_function_descr; typedef void (*cxx_copy_ctor)(void); @@ -121,7 +121,7 @@ typedef struct __cxx_type_info_table typedef DWORD (*cxx_exc_custom_handler)( PEXCEPTION_RECORD, cxx_exception_frame*, PCONTEXT, EXCEPTION_REGISTRATION_RECORD**, - cxx_function_descr*, int nested_trylevel, + const cxx_function_descr*, int nested_trylevel, EXCEPTION_REGISTRATION_RECORD *nested_frame, DWORD unknown3 ); /* type information for an exception object */

1 0

Hans Leidekker : setupapi: Add a stub implementation for SetupPromptReboot.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 7f31cc47561a9e903cdccd9b7de3a3faf645e154 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f31cc47561a9e903cdccd9b7… Author: Hans Leidekker <hans(a)it.vu.nl> Date: Fri Dec 15 10:02:00 2006 +0100 setupapi: Add a stub implementation for SetupPromptReboot. --- dlls/setupapi/setupapi.spec | 2 +- dlls/setupapi/stubs.c | 9 +++++++++ include/setupapi.h | 1 + 3 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec index 2c6672d..ed91774 100644 --- a/dlls/setupapi/setupapi.spec +++ b/dlls/setupapi/setupapi.spec @@ -454,7 +454,7 @@ @ stdcall SetupOpenMasterInf() @ stub SetupPromptForDiskA @ stub SetupPromptForDiskW -@ stub SetupPromptReboot +@ stdcall SetupPromptReboot(ptr ptr long) @ stub SetupQueryDrivesInDiskSpaceListA @ stub SetupQueryDrivesInDiskSpaceListW @ stub SetupQueryFileLogA diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c index faf6a1f..1ab79da 100644 --- a/dlls/setupapi/stubs.c +++ b/dlls/setupapi/stubs.c @@ -200,3 +200,12 @@ BOOL WINAPI SetupOpenLog(BOOL Reserved) FIXME("(%d) stub\n", Reserved); return TRUE; } + +/*********************************************************************** + * SetupPromptReboot(SETUPAPI.@) + */ +INT WINAPI SetupPromptReboot( HSPFILEQ file_queue, HWND owner, BOOL scan_only ) +{ + FIXME("%p, %p, %d\n", file_queue, owner, scan_only); + return 0; +} diff --git a/include/setupapi.h b/include/setupapi.h index d27cb9f..7fd1099 100644 --- a/include/setupapi.h +++ b/include/setupapi.h @@ -851,6 +851,7 @@ HINF WINAPI SetupOpenInfFileA( PCSTR HINF WINAPI SetupOpenInfFileW( PCWSTR name, PCWSTR pszclass, DWORD style, UINT *error ); #define SetupOpenInfFile WINELIB_NAME_AW(SetupOpenInfFile) HINF WINAPI SetupOpenMasterInf( VOID ); +INT WINAPI SetupPromptReboot( HSPFILEQ, HWND, BOOL); BOOL WINAPI SetupQueryInfFileInformationA(PSP_INF_INFORMATION, UINT, PSTR, DWORD, PDWORD); BOOL WINAPI SetupQueryInfFileInformationW(PSP_INF_INFORMATION, UINT, PWSTR, DWORD, PDWORD); #define SetupQueryInfFileInformation WINELIB_NAME_AW(SetupQueryInFileInformation)

1 0

Dmitry Timoshkov : user32: Center the context menu if it was activated via VK_APPS like Windows does.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: b37b72b0068a11045667e6700e146549ee191b65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b37b72b0068a11045667e6700… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Dec 15 15:04:01 2006 +0800 user32: Center the context menu if it was activated via VK_APPS like Windows does. --- dlls/user32/edit.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c index f93c9aa..44c6f95 100644 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -4102,6 +4102,16 @@ static void EDIT_WM_ContextMenu(EDITSTAT /* select all */ EnableMenuItem(popup, 7, MF_BYPOSITION | (start || (end != strlenW(es->text)) ? MF_ENABLED : MF_GRAYED)); + if (x == -1 && y == -1) /* passed via VK_APPS press/release */ + { + RECT rc; + /* Windows places the menu at the edit's center in this case */ + GetClientRect(es->hwndSelf, &rc); + MapWindowPoints(es->hwndSelf, 0, (POINT *)&rc, 2); + x = rc.left + (rc.right - rc.left) / 2; + y = rc.top + (rc.bottom - rc.top) / 2; + } + TrackPopupMenu(popup, TPM_LEFTALIGN | TPM_RIGHTBUTTON, x, y, 0, es->hwndSelf, NULL); DestroyMenu(menu); }

1 0

Dmitry Timoshkov : user32: Add support for the VK_APPS (Menu) key.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 6c73f7395ba610c3ce7549f9ebdccaf24829b8ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c73f7395ba610c3ce7549f9e… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Dec 15 15:03:43 2006 +0800 user32: Add support for the VK_APPS (Menu) key. --- dlls/user32/message.c | 6 ++++++ dlls/user32/tests/msg.c | 18 ++++++++++++++++++ dlls/winex11.drv/keyboard.c | 2 +- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index 94d29d8..89f7495 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -1660,6 +1660,12 @@ static BOOL process_keyboard_message( MS SendMessageW(msg->hwnd, WM_APPCOMMAND, (WPARAM)msg->hwnd, MAKELPARAM(0, (FAPPCOMMAND_KEY | (msg->wParam - VK_BROWSER_BACK + 1)))); } } + else if (msg->message == WM_KEYUP) + { + /* Handle VK_APPS key by posting a WM_CONTEXTMENU message */ + if (msg->wParam == VK_APPS && !MENU_IsMenuActive()) + PostMessageW(msg->hwnd, WM_CONTEXTMENU, (WPARAM)msg->hwnd, (LPARAM)-1); + } } if (HOOK_CallHooks( WH_KEYBOARD, remove ? HC_ACTION : HC_NOREMOVE, diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 5b74cc4..98a1229 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -5288,6 +5288,17 @@ static const struct message WmF1Seq[] = { WM_KEYUP, sent|wparam|lparam, VK_F1, 0xc0000001 }, { 0 } }; +static const struct message WmVkAppsSeq[] = { + { HCBT_KEYSKIPPED, hook|wparam|lparam|optional, VK_APPS, 1 }, /* XP */ + { WM_KEYDOWN, wparam|lparam, VK_APPS, 1 }, + { WM_KEYDOWN, sent|wparam|lparam, VK_APPS, 0x00000001 }, + { HCBT_KEYSKIPPED, hook|wparam|lparam|optional, VK_APPS, 0xc0000001 }, /* XP */ + { WM_KEYUP, wparam|lparam, VK_APPS, 0xc0000001 }, + { WM_KEYUP, sent|wparam|lparam, VK_APPS, 0xc0000001 }, + { WM_CONTEXTMENU, lparam, /*hwnd*/0, (LPARAM)-1 }, + { WM_CONTEXTMENU, sent|lparam, /*hwnd*/0, (LPARAM)-1 }, + { 0 } +}; static void pump_msg_loop(HWND hwnd, HACCEL hAccel) { @@ -5495,11 +5506,18 @@ static void test_accelerators(void) pump_msg_loop(hwnd, 0); ok_sequence(WmAltMouseButton, "Alt+MouseButton press/release", FALSE); + trace("testing VK_F1 press/release\n"); keybd_event(VK_F1, 0, 0, 0); keybd_event(VK_F1, 0, KEYEVENTF_KEYUP, 0); pump_msg_loop(hwnd, 0); ok_sequence(WmF1Seq, "F1 press/release", TRUE); + trace("testing VK_APPS press/release\n"); + keybd_event(VK_APPS, 0, 0, 0); + keybd_event(VK_APPS, 0, KEYEVENTF_KEYUP, 0); + pump_msg_loop(hwnd, 0); + ok_sequence(WmVkAppsSeq, "VK_APPS press/release", FALSE); + DestroyWindow(hwnd); } diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c index 19d3684..c5947cf 100644 --- a/dlls/winex11.drv/keyboard.c +++ b/dlls/winex11.drv/keyboard.c @@ -1001,7 +1001,7 @@ static const WORD nonchar_key_vkey[256] VK_DOWN, VK_PRIOR, VK_NEXT, VK_END, 0, 0, 0, 0, 0, 0, 0, 0, /* FF58 */ /* misc keys */ - VK_SELECT, VK_SNAPSHOT, VK_EXECUTE, VK_INSERT, 0, 0, 0, 0, /* FF60 */ + VK_SELECT, VK_SNAPSHOT, VK_EXECUTE, VK_INSERT, 0,0,0, VK_APPS, /* FF60 */ 0, VK_CANCEL, VK_HELP, VK_CANCEL, 0, 0, 0, 0, /* FF68 */ 0, 0, 0, 0, 0, 0, 0, 0, /* FF70 */ /* keypad keys */

1 0

Dmitry Timoshkov : ddrawex: Avoid not necessary casts.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 95f263240b1ef8de07b8cdb76a4d37255ebdcc17 URL: http://source.winehq.org/git/wine.git/?a=commit;h=95f263240b1ef8de07b8cdb76… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Dec 15 15:03:32 2006 +0800 ddrawex: Avoid not necessary casts. --- dlls/ddrawex/ddrawex_private.h | 4 ++-- dlls/ddrawex/main.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ddrawex/ddrawex_private.h b/dlls/ddrawex/ddrawex_private.h index 2153921..117ddba 100644 --- a/dlls/ddrawex/ddrawex_private.h +++ b/dlls/ddrawex/ddrawex_private.h @@ -48,7 +48,7 @@ DECLARE_INTERFACE_(IDirectDrawFactory, I ******************************************************************************/ typedef struct { - IClassFactory *lpVtbl; + const IClassFactoryVtbl *lpVtbl; LONG ref; HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, REFIID iid, LPVOID *ppObj); } IClassFactoryImpl; @@ -59,7 +59,7 @@ typedef struct ******************************************************************************/ typedef struct { - IDirectDrawFactory *lpVtbl; + const IDirectDrawFactoryVtbl *lpVtbl; LONG ref; } IDirectDrawFactoryImpl; diff --git a/dlls/ddrawex/main.c b/dlls/ddrawex/main.c index e3cd664..40ec7cb 100644 --- a/dlls/ddrawex/main.c +++ b/dlls/ddrawex/main.c @@ -272,9 +272,9 @@ CreateDirectDrawFactory(IUnknown* UnkOut return E_OUTOFMEMORY; } - This->lpVtbl = (IDirectDrawFactory*) &IDirectDrawFactory_Vtbl; + This->lpVtbl = &IDirectDrawFactory_Vtbl; - hr = IDirectDrawFactory_QueryInterface(This->lpVtbl, iid, obj); + hr = IDirectDrawFactory_QueryInterface((IDirectDrawFactory *)This, iid, obj); if (FAILED(hr)) HeapFree(GetProcessHeap(), 0, This); @@ -315,7 +315,7 @@ HRESULT WINAPI DllGetClassObject(REFCLSI factory = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*factory)); if (factory == NULL) return E_OUTOFMEMORY; - factory->lpVtbl = (IClassFactory*) &IClassFactory_Vtbl; + factory->lpVtbl = &IClassFactory_Vtbl; factory->ref = 1; factory->pfnCreateInstance = CreateDirectDrawFactory;

1 0

Dmitry Timoshkov : ddraw: Fix warnings.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 8836dea139e13f89a5b53ef464a564559e03e93d URL: http://source.winehq.org/git/wine.git/?a=commit;h=8836dea139e13f89a5b53ef46… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Dec 15 15:02:33 2006 +0800 ddraw: Fix warnings. --- dlls/ddraw/ddraw_thunks.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c index ef8af6b..99518f0 100644 --- a/dlls/ddraw/ddraw_thunks.c +++ b/dlls/ddraw/ddraw_thunks.c @@ -112,7 +112,7 @@ IDirectDraw3Impl_AddRef(LPDIRECTDRAW3 if ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw3, iface); ULONG ref = InterlockedIncrement(&This->ref4); - TRACE("(%p) : incrementing IDirectDraw4 refcount from %lu.\n", This, ref -1); + TRACE("(%p) : incrementing IDirectDraw4 refcount from %u.\n", This, ref -1); if(ref == 1) InterlockedIncrement(&This->numIfaces); @@ -172,7 +172,7 @@ IDirectDraw3Impl_Release(LPDIRECTDRAW3 i ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw3, iface); ULONG ref = InterlockedDecrement(&This->ref4); - TRACE_(ddraw)("(%p)->() decrementing IDirectDraw4 refcount from %lu.\n", This, ref +1); + TRACE_(ddraw)("(%p)->() decrementing IDirectDraw4 refcount from %u.\n", This, ref +1); if(ref == 0) {

1 0

Andrew Talbot : secur32/tests: Cast-qual warnings fix.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 2ec6c1bf965ffc40db3d1bd2ff922d67310e37fe URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ec6c1bf965ffc40db3d1bd2f… Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Thu Dec 14 22:22:20 2006 +0000 secur32/tests: Cast-qual warnings fix. --- dlls/secur32/tests/ntlm.c | 31 +++++++++++++++++++++---------- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git a/dlls/secur32/tests/ntlm.c b/dlls/secur32/tests/ntlm.c index f616491..b90d065 100644 --- a/dlls/secur32/tests/ntlm.c +++ b/dlls/secur32/tests/ntlm.c @@ -558,7 +558,10 @@ static void testInitializeSecurityContex PSecPkgInfo pkg_info = NULL; SspiData client; SEC_WINNT_AUTH_IDENTITY id; - static char sec_pkg_name[] = "NTLM"; + static char sec_pkg_name[] = "NTLM", + test_user[] = "testuser", + workgroup[] = "WORKGROUP", + test_pass[] = "testpass"; ULONG req_attr, ctxt_attr; TimeStamp ttl; PBYTE packet; @@ -570,11 +573,11 @@ static void testInitializeSecurityContex } pFreeContextBuffer(pkg_info); - id.User = (unsigned char*) "testuser"; + id.User = (unsigned char*) test_user; id.UserLength = strlen((char *) id.User); - id.Domain = (unsigned char *) "WORKGROUP"; + id.Domain = (unsigned char *) workgroup; id.DomainLength = strlen((char *) id.Domain); - id.Password = (unsigned char*) "testpass"; + id.Password = (unsigned char*) test_pass; id.PasswordLength = strlen((char *) id.Password); id.Flags = SEC_WINNT_AUTH_IDENTITY_ANSI; @@ -775,12 +778,16 @@ static void testAuth(ULONG data_rep, BOO if(pQuerySecurityPackageInfoA( sec_pkg_name, &pkg_info)== SEC_E_OK) { + static char test_user[] = "testuser", + workgroup[] = "WORKGROUP", + test_pass[] = "testpass"; + pFreeContextBuffer(pkg_info); - id.User = (unsigned char*) "testuser"; + id.User = (unsigned char*) test_user; id.UserLength = strlen((char *) id.User); - id.Domain = (unsigned char *) "WORKGROUP"; + id.Domain = (unsigned char *) workgroup; id.DomainLength = strlen((char *) id.Domain); - id.Password = (unsigned char*) "testpass"; + id.Password = (unsigned char*) test_pass; id.PasswordLength = strlen((char *) id.Password); id.Flags = SEC_WINNT_AUTH_IDENTITY_ANSI; @@ -912,12 +919,16 @@ static void testSignSeal() */ if(pQuerySecurityPackageInfoA( sec_pkg_name, &pkg_info)== SEC_E_OK) { + static char test_user[] = "testuser", + workgroup[] = "WORKGROUP", + test_pass[] = "testpass"; + pFreeContextBuffer(pkg_info); - id.User = (unsigned char*) "testuser"; + id.User = (unsigned char*) test_user; id.UserLength = strlen((char *) id.User); - id.Domain = (unsigned char *) "WORKGROUP"; + id.Domain = (unsigned char *) workgroup; id.DomainLength = strlen((char *) id.Domain); - id.Password = (unsigned char*) "testpass"; + id.Password = (unsigned char*) test_pass; id.PasswordLength = strlen((char *) id.Password); id.Flags = SEC_WINNT_AUTH_IDENTITY_ANSI;

1 0

Stefan Dösinger : wined3d: Clean up SetRenderState.
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 17eabc42b3707d36ad39b47a03c924d91bda81cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=17eabc42b3707d36ad39b47a0… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Dec 14 20:48:49 2006 +0100 wined3d: Clean up SetRenderState. --- dlls/wined3d/device.c | 124 +------------------------------------------------ 1 files changed, 2 insertions(+), 122 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 939af52..a78b005 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -3328,128 +3328,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl } ENTER_GL(); - - switch (State) { - case WINED3DRS_FILLMODE : - case WINED3DRS_LIGHTING : - case WINED3DRS_ZENABLE : - case WINED3DRS_CULLMODE : - case WINED3DRS_SHADEMODE : - case WINED3DRS_DITHERENABLE : - case WINED3DRS_ZWRITEENABLE : - case WINED3DRS_ZFUNC : - case WINED3DRS_AMBIENT : - case WINED3DRS_ALPHABLENDENABLE : - case WINED3DRS_SRCBLEND : - case WINED3DRS_DESTBLEND : - case WINED3DRS_ANTIALIASEDLINEENABLE : - case WINED3DRS_BLENDFACTOR : - case WINED3DRS_ALPHATESTENABLE : - case WINED3DRS_ALPHAFUNC : - case WINED3DRS_ALPHAREF : - case WINED3DRS_COLORKEYENABLE : - case WINED3DRS_CLIPPLANEENABLE : - case WINED3DRS_CLIPPING : - case WINED3DRS_BLENDOP : - case WINED3DRS_TEXTUREFACTOR : - case WINED3DRS_SPECULARENABLE : - case WINED3DRS_STENCILENABLE : - case WINED3DRS_TWOSIDEDSTENCILMODE : - case WINED3DRS_STENCILFUNC : - case WINED3DRS_CCW_STENCILFUNC : - case WINED3DRS_STENCILREF : - case WINED3DRS_STENCILMASK : - case WINED3DRS_STENCILFAIL : - case WINED3DRS_STENCILZFAIL : - case WINED3DRS_STENCILPASS : - case WINED3DRS_CCW_STENCILFAIL : - case WINED3DRS_CCW_STENCILZFAIL : - case WINED3DRS_CCW_STENCILPASS : - case WINED3DRS_EDGEANTIALIAS : - case WINED3DRS_STENCILWRITEMASK : - case WINED3DRS_FOGENABLE : - case WINED3DRS_FOGTABLEMODE : - case WINED3DRS_FOGVERTEXMODE : - case WINED3DRS_FOGSTART : - case WINED3DRS_FOGEND : - case WINED3DRS_RANGEFOGENABLE : - case WINED3DRS_FOGCOLOR : - case WINED3DRS_FOGDENSITY : - case WINED3DRS_VERTEXBLEND : - case WINED3DRS_TWEENFACTOR : - case WINED3DRS_INDEXEDVERTEXBLENDENABLE : - case WINED3DRS_COLORVERTEX : - case WINED3DRS_DIFFUSEMATERIALSOURCE : - case WINED3DRS_SPECULARMATERIALSOURCE : - case WINED3DRS_AMBIENTMATERIALSOURCE : - case WINED3DRS_EMISSIVEMATERIALSOURCE : - case WINED3DRS_LINEPATTERN : - case WINED3DRS_ZBIAS : /* D3D8 only */ - case WINED3DRS_NORMALIZENORMALS : - case WINED3DRS_POINTSIZE : - case WINED3DRS_POINTSIZE_MIN : - case WINED3DRS_POINTSIZE_MAX : - case WINED3DRS_POINTSCALE_A : - case WINED3DRS_POINTSCALE_B : - case WINED3DRS_POINTSCALE_C : - case WINED3DRS_POINTSCALEENABLE : - case WINED3DRS_COLORWRITEENABLE : - case WINED3DRS_COLORWRITEENABLE1 : - case WINED3DRS_COLORWRITEENABLE2 : - case WINED3DRS_COLORWRITEENABLE3 : - case WINED3DRS_LOCALVIEWER : - case WINED3DRS_LASTPIXEL : - case WINED3DRS_SOFTWAREVERTEXPROCESSING : - case WINED3DRS_POINTSPRITEENABLE : - case WINED3DRS_WRAP0 : - case WINED3DRS_WRAP1 : - case WINED3DRS_WRAP2 : - case WINED3DRS_WRAP3 : - case WINED3DRS_WRAP4 : - case WINED3DRS_WRAP5 : - case WINED3DRS_WRAP6 : - case WINED3DRS_WRAP7 : - case WINED3DRS_WRAP8 : - case WINED3DRS_WRAP9 : - case WINED3DRS_WRAP10 : - case WINED3DRS_WRAP11 : - case WINED3DRS_WRAP12 : - case WINED3DRS_WRAP13 : - case WINED3DRS_WRAP14 : - case WINED3DRS_WRAP15 : - case WINED3DRS_MULTISAMPLEANTIALIAS : - case WINED3DRS_SCISSORTESTENABLE : - case WINED3DRS_SLOPESCALEDEPTHBIAS : - case WINED3DRS_DEPTHBIAS : - case WINED3DRS_TEXTUREPERSPECTIVE : - case WINED3DRS_STIPPLEDALPHA : - case WINED3DRS_ANTIALIAS : - case WINED3DRS_MULTISAMPLEMASK : - case WINED3DRS_PATCHEDGESTYLE : - case WINED3DRS_PATCHSEGMENTS : - case WINED3DRS_DEBUGMONITORTOKEN : - case WINED3DRS_POSITIONDEGREE : - case WINED3DRS_NORMALDEGREE : - case WINED3DRS_MINTESSELLATIONLEVEL : - case WINED3DRS_MAXTESSELLATIONLEVEL : - case WINED3DRS_ADAPTIVETESS_X : - case WINED3DRS_ADAPTIVETESS_Y : - case WINED3DRS_ADAPTIVETESS_Z : - case WINED3DRS_ADAPTIVETESS_W : - case WINED3DRS_ENABLEADAPTIVETESSELLATION: - case WINED3DRS_SRGBWRITEENABLE : - case WINED3DRS_SEPARATEALPHABLENDENABLE : - case WINED3DRS_SRCBLENDALPHA : - case WINED3DRS_DESTBLENDALPHA : - case WINED3DRS_BLENDOPALPHA : - case WINED3DRS_ZVISIBLE : - StateTable[STATE_RENDER(State)].apply(STATE_RENDER(State), This->stateBlock); - break; - - default: - FIXME("(%p)->(%s,%d) unknown state\n", This, debug_d3drenderstate(State), Value); - } - + /* TODO: Mark the state dirty instead of immediate applying */ + StateTable[STATE_RENDER(State)].apply(STATE_RENDER(State), This->stateBlock); LEAVE_GL(); return WINED3D_OK;

1 0

Stefan Dösinger : ddraw: Add a TRACE to GetPixelFormat .
by Alexandre Julliard Dec. 15, 2006

Dec. 15, 2006

Module: wine Branch: master Commit: 2fe8a41cb833157ac2a811567129cd329f9c4b7d URL: http://source.winehq.org/git/wine.git/?a=commit;h=2fe8a41cb833157ac2a811567… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Thu Dec 14 20:49:26 2006 +0100 ddraw: Add a TRACE to GetPixelFormat. --- dlls/ddraw/surface.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 03ea974..b005579 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -1291,8 +1291,8 @@ IDirectDrawSurfaceImpl_GetColorKey(IDire /* There is a DDERR_NOCOLORKEY error, but how do we know if a color key * isn't there? That's like saying that an int isn't there. (Which MS * has done in other docs.) */ - ICOM_THIS_FROM(IDirectDrawSurfaceImpl, IDirectDrawSurface7, iface); + TRACE("(%p)->(%08x,%p)\n", This, Flags, CKey); if(!CKey) return DDERR_INVALIDPARAMS;

1 0