December 2006 - Wine-Commits

Francois Gouget : ole32: Convert dump_user_flags() into debugstr_user_flags (), a proper debug trace function.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: dd6e948d8421137a150ef48cbfb96d7561043b77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd6e948d8421137a150ef48cb… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 6 12:06:03 2006 +0100 ole32: Convert dump_user_flags() into debugstr_user_flags(), a proper debug trace function. --- dlls/ole32/usrmarshal.c | 72 ++++++++++++++++++++++++++++------------------- 1 files changed, 43 insertions(+), 29 deletions(-) diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c index a92dfa0..2ffc2a1 100644 --- a/dlls/ole32/usrmarshal.c +++ b/dlls/ole32/usrmarshal.c @@ -18,6 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <stdio.h> #include <stdarg.h> #include <string.h> @@ -43,20 +44,33 @@ WINE_DEFAULT_DEBUG_CHANNEL(ole); #define ALIGN_LENGTH(_Len, _Align) _Len = ALIGNED_LENGTH(_Len, _Align) #define ALIGN_POINTER(_Ptr, _Align) _Ptr = ALIGNED_POINTER(_Ptr, _Align) -static void dump_user_flags(ULONG *pFlags) +static const char* debugstr_user_flags(ULONG *pFlags) { - if (HIWORD(*pFlags) == NDR_LOCAL_DATA_REPRESENTATION) - TRACE("MAKELONG(NDR_LOCAL_REPRESENTATION, "); - else - TRACE("MAKELONG(0x%04x, ", HIWORD(*pFlags)); + char buf[12]; + const char* loword; switch (LOWORD(*pFlags)) { - case MSHCTX_LOCAL: TRACE("MSHCTX_LOCAL)"); break; - case MSHCTX_NOSHAREDMEM: TRACE("MSHCTX_NOSHAREDMEM)"); break; - case MSHCTX_DIFFERENTMACHINE: TRACE("MSHCTX_DIFFERENTMACHINE)"); break; - case MSHCTX_INPROC: TRACE("MSHCTX_INPROC)"); break; - default: TRACE("%d)", LOWORD(*pFlags)); + case MSHCTX_LOCAL: + loword="MSHCTX_LOCAL"; + break; + case MSHCTX_NOSHAREDMEM: + loword="MSHCTX_NOSHAREDMEM"; + break; + case MSHCTX_DIFFERENTMACHINE: + loword="MSHCTX_DIFFERENTMACHINE"; + break; + case MSHCTX_INPROC: + loword="MSHCTX_INPROC"; + break; + default: + sprintf(buf, "%d", LOWORD(*pFlags)); + loword=buf; } + + if (HIWORD(*pFlags) == NDR_LOCAL_DATA_REPRESENTATION) + return wine_dbg_sprintf("MAKELONG(NDR_LOCAL_REPRESENTATION, %s)", loword); + else + return wine_dbg_sprintf("MAKELONG(0x%04x, %s)", HIWORD(*pFlags), loword); } /****************************************************************************** @@ -83,7 +97,7 @@ ULONG __RPC_USER CLIPFORMAT_UserSize(ULO { ULONG size = StartingSize; - TRACE("("); dump_user_flags(pFlags); TRACE(", %d, %p\n", StartingSize, pCF); + TRACE("(%s, %d, %p\n", debugstr_user_flags(pFlags), StartingSize, pCF); size += sizeof(userCLIPFORMAT); @@ -128,7 +142,7 @@ unsigned char * __RPC_USER CLIPFORMAT_Us { wireCLIPFORMAT wirecf = (wireCLIPFORMAT)pBuffer; - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, &0x%04x\n", pBuffer, *pCF); + TRACE("(%s, %p, &0x%04x\n", debugstr_user_flags(pFlags), pBuffer, *pCF); wirecf->u.dwValue = *pCF; pBuffer += sizeof(*wirecf); @@ -185,7 +199,7 @@ unsigned char * __RPC_USER CLIPFORMAT_Us { wireCLIPFORMAT wirecf = (wireCLIPFORMAT)pBuffer; - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, %p\n", pBuffer, pCF); + TRACE("(%s, %p, %p\n", debugstr_user_flags(pFlags), pBuffer, pCF); pBuffer += sizeof(*wirecf); if (wirecf->fContext == WDT_INPROC_CALL) @@ -282,25 +296,25 @@ static void __RPC_USER handle_UserFree(U #define IMPL_WIREM_HANDLE(type) \ ULONG __RPC_USER type##_UserSize(ULONG *pFlags, ULONG StartingSize, type *handle) \ { \ - TRACE("("); dump_user_flags(pFlags); TRACE(", %d, %p\n", StartingSize, handle); \ + TRACE("(%s, %d, %p\n", debugstr_user_flags(pFlags), StartingSize, handle); \ return handle_UserSize(pFlags, StartingSize, (HANDLE *)handle); \ } \ \ unsigned char * __RPC_USER type##_UserMarshal(ULONG *pFlags, unsigned char *pBuffer, type *handle) \ { \ - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, &%p\n", pBuffer, *handle); \ + TRACE("(%s, %p, &%p\n", debugstr_user_flags(pFlags), pBuffer, *handle); \ return handle_UserMarshal(pFlags, pBuffer, (HANDLE *)handle); \ } \ \ unsigned char * __RPC_USER type##_UserUnmarshal(ULONG *pFlags, unsigned char *pBuffer, type *handle) \ { \ - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, %p\n", pBuffer, handle); \ + TRACE("(%s, %p, %p\n", debugstr_user_flags(pFlags), pBuffer, handle); \ return handle_UserUnmarshal(pFlags, pBuffer, (HANDLE *)handle); \ } \ \ void __RPC_USER type##_UserFree(ULONG *pFlags, type *handle) \ { \ - TRACE("("); dump_user_flags(pFlags); TRACE(", &%p\n", *handle); \ + TRACE("(%s, &%p\n", debugstr_user_flags(pFlags), *handle); \ return handle_UserFree(pFlags, (HANDLE *)handle); \ } @@ -315,7 +329,7 @@ ULONG __RPC_USER HGLOBAL_UserSize(ULONG { ULONG size = StartingSize; - TRACE("("); dump_user_flags(pFlags); TRACE(", %d, %p\n", StartingSize, phGlobal); + TRACE("(%s, %d, %p\n", debugstr_user_flags(pFlags), StartingSize, phGlobal); ALIGN_LENGTH(size, 3); @@ -340,7 +354,7 @@ ULONG __RPC_USER HGLOBAL_UserSize(ULONG unsigned char * __RPC_USER HGLOBAL_UserMarshal(ULONG *pFlags, unsigned char *pBuffer, HGLOBAL *phGlobal) { - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, &%p\n", pBuffer, *phGlobal); + TRACE("(%s, %p, &%p\n", debugstr_user_flags(pFlags), pBuffer, *phGlobal); ALIGN_POINTER(pBuffer, 3); @@ -385,7 +399,7 @@ unsigned char * __RPC_USER HGLOBAL_UserU { ULONG fContext; - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, &%p\n", pBuffer, *phGlobal); + TRACE("(%s, %p, &%p\n", debugstr_user_flags(pFlags), pBuffer, *phGlobal); ALIGN_POINTER(pBuffer, 3); @@ -451,7 +465,7 @@ unsigned char * __RPC_USER HGLOBAL_UserU */ void __RPC_USER HGLOBAL_UserFree(ULONG *pFlags, HGLOBAL *phGlobal) { - TRACE("("); dump_user_flags(pFlags); TRACE(", &%p\n", *phGlobal); + TRACE("(%s, &%p\n", debugstr_user_flags(pFlags), *phGlobal); if (LOWORD(*pFlags != MSHCTX_INPROC) && *phGlobal) GlobalFree(*phGlobal); @@ -531,7 +545,7 @@ ULONG __RPC_USER HENHMETAFILE_UserSize(U { ULONG size = StartingSize; - TRACE("("); dump_user_flags(pFlags); TRACE(", %d, %p\n", StartingSize, *phEmf); + TRACE("(%s, %d, %p\n", debugstr_user_flags(pFlags), StartingSize, *phEmf); size += sizeof(ULONG); if (LOWORD(*pFlags) == MSHCTX_INPROC) @@ -555,7 +569,7 @@ ULONG __RPC_USER HENHMETAFILE_UserSize(U unsigned char * __RPC_USER HENHMETAFILE_UserMarshal(ULONG *pFlags, unsigned char *pBuffer, HENHMETAFILE *phEmf) { - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, &%p\n", pBuffer, *phEmf); + TRACE("(%s, %p, &%p\n", debugstr_user_flags(pFlags), pBuffer, *phEmf); if (LOWORD(*pFlags) == MSHCTX_INPROC) { @@ -594,7 +608,7 @@ unsigned char * __RPC_USER HENHMETAFILE_ { ULONG fContext; - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, %p\n", pBuffer, phEmf); + TRACE("(%s, %p, %p\n", debugstr_user_flags(pFlags), pBuffer, phEmf); fContext = *(ULONG *)pBuffer; pBuffer += sizeof(ULONG); @@ -637,7 +651,7 @@ unsigned char * __RPC_USER HENHMETAFILE_ void __RPC_USER HENHMETAFILE_UserFree(ULONG *pFlags, HENHMETAFILE *phEmf) { - TRACE("("); dump_user_flags(pFlags); TRACE(", &%p\n", *phEmf); + TRACE("(%s, &%p\n", debugstr_user_flags(pFlags), *phEmf); if (LOWORD(*pFlags) != MSHCTX_INPROC) DeleteEnhMetaFile(*phEmf); @@ -647,7 +661,7 @@ ULONG __RPC_USER STGMEDIUM_UserSize(ULON { ULONG size = StartingSize; - TRACE("("); dump_user_flags(pFlags); TRACE(", %d, %p\n", StartingSize, pStgMedium); + TRACE("(%s, %d, %p\n", debugstr_user_flags(pFlags), StartingSize, pStgMedium); ALIGN_LENGTH(size, 3); @@ -695,7 +709,7 @@ ULONG __RPC_USER STGMEDIUM_UserSize(ULON unsigned char * __RPC_USER STGMEDIUM_UserMarshal(ULONG *pFlags, unsigned char *pBuffer, STGMEDIUM *pStgMedium) { - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, %p\n", pBuffer, pStgMedium); + TRACE("(%s, %p, %p\n", debugstr_user_flags(pFlags), pBuffer, pStgMedium); ALIGN_POINTER(pBuffer, 3); @@ -754,7 +768,7 @@ unsigned char * __RPC_USER STGMEDIUM_Use ALIGN_POINTER(pBuffer, 3); - TRACE("("); dump_user_flags(pFlags); TRACE(", %p, %p\n", pBuffer, pStgMedium); + TRACE("(%s, %p, %p\n", debugstr_user_flags(pFlags), pBuffer, pStgMedium); pStgMedium->tymed = *(DWORD *)pBuffer; pBuffer += sizeof(DWORD); @@ -807,7 +821,7 @@ unsigned char * __RPC_USER STGMEDIUM_Use void __RPC_USER STGMEDIUM_UserFree(ULONG *pFlags, STGMEDIUM *pStgMedium) { - TRACE("("); dump_user_flags(pFlags); TRACE(", %p\n", pStgMedium); + TRACE("(%s, %p\n", debugstr_user_flags(pFlags), pStgMedium); ReleaseStgMedium(pStgMedium); }

1 0

Francois Gouget : msvcmaker: Tweak the . dsp formatting to better match Visual Studio.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: f1698c4b0cc8e491b88e7fc1db1bde28bf51313d URL: http://source.winehq.org/git/wine.git/?a=commit;h=f1698c4b0cc8e491b88e7fc1d… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 6 12:00:14 2006 +0100 msvcmaker: Tweak the .dsp formatting to better match Visual Studio. --- tools/winapi/msvcmaker | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index 87c6430..25824f3 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -519,6 +519,7 @@ sub _generate_dsp($$) { print OUT "CPP=cl.exe\r\n"; print OUT "MTL=midl.exe\r\n" if !$lib && !$exe; print OUT "RSC=rc.exe\r\n"; + print OUT "\r\n"; my $n = 0; @@ -591,12 +592,15 @@ sub _generate_dsp($$) { } foreach my $define (@defines) { - print OUT " /D \"$define\""; + if ($define !~ /=/) { + print OUT " /D \"$define\""; + } else { + print OUT " /D $define"; + } } print OUT " /YX" if $lib || $exe; print OUT " /FD"; print OUT " /GZ" if $debug; - print OUT " " if $debug && ($lib || $exe); print OUT " /c"; print OUT "\r\n"; @@ -647,7 +651,7 @@ sub _generate_dsp($$) { } foreach my $define (@defines2) { - if ($define !~ /[\\\"]/) { + if ($define !~ /=/) { print OUT " /D \"$define\""; } else { print OUT " /D $define"; @@ -660,7 +664,6 @@ sub _generate_dsp($$) { print OUT " /FR" if !$lib; print OUT " /FD"; print OUT " /GZ" if $debug; - print OUT " " if $debug && $lib; print OUT " /c"; print OUT " /TP" if !$no_cpp; print OUT "\r\n"; @@ -696,12 +699,12 @@ sub _generate_dsp($$) { if($exe || $dll) { print OUT "LINK32=link.exe\r\n"; - print OUT "# ADD BASE LINK32 "; + print OUT "# ADD BASE LINK32"; my @libraries = qw(kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib); foreach my $library (@libraries) { - print OUT "$library "; + print OUT " $library"; } print OUT " /nologo"; print OUT " /dll" if $dll; @@ -712,11 +715,11 @@ sub _generate_dsp($$) { print OUT "\r\n"; print OUT "# ADD LINK32"; - print OUT " /nologo"; print OUT " libcmt.lib" if $project =~ /^ntdll$/; # FIXME: Kludge foreach my $import (@imports) { print OUT " $import.lib" if ($import ne "msvcrt"); } + print OUT " /nologo"; print OUT " /dll" if $dll; print OUT " /subsystem:console" if $console; print OUT " /debug" if $debug;

1 0

Francois Gouget : msvcmaker: Link with msvcrt(d). dll rather than with the static C library.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: baf85ad931e4bd45cb2d670fab85d1eeb2c66684 URL: http://source.winehq.org/git/wine.git/?a=commit;h=baf85ad931e4bd45cb2d670fa… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 6 12:04:55 2006 +0100 msvcmaker: Link with msvcrt(d).dll rather than with the static C library. --- tools/winapi/msvcmaker | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index 25824f3..6ee5483 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -578,7 +578,7 @@ sub _generate_dsp($$) { print OUT "# ADD BASE CPP /nologo /W3 /Gm /GX /Zi /Od"; @defines = (qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 _DEBUG _MBCS _LIB)); } else { - print OUT "# ADD BASE CPP /nologo /MTd /W3 /Gm /GX /Zi /Od"; + print OUT "# ADD BASE CPP /nologo /MDd /W3 /Gm /GX /Zi /Od"; @defines = (qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 _DEBUG _WINDOWS _MBCS _USRDLL), ("\U${project}\E_EXPORTS")); } } else { @@ -586,7 +586,7 @@ sub _generate_dsp($$) { print OUT "# ADD BASE CPP /nologo /W3 /GX /O2"; @defines = (qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 NDEBUG _MBCS _LIB)); } else { - print OUT "# ADD BASE CPP /nologo /MT /W3 /GX /O2"; + print OUT "# ADD BASE CPP /nologo /MD /W3 /GX /O2"; @defines = (qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 NDEBUG _WINDOWS _MBCS _USRDLL), ("\U${project}\E_EXPORTS")); } } @@ -607,18 +607,18 @@ sub _generate_dsp($$) { my @defines2; if($debug) { if($lib) { - print OUT "# ADD CPP /nologo /MTd /W3 /Gm /GX /Zi /Od"; + print OUT "# ADD CPP /nologo /MDd /W3 /Gm /GX /Zi /Od"; @defines2 = qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 _DEBUG _WINDOWS _MBCS _LIB); } else { - print OUT "# ADD CPP /nologo /MTd /W3 /Gm /GX /Zi /Od"; + print OUT "# ADD CPP /nologo /MDd /W3 /Gm /GX /Zi /Od"; @defines2 = qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 _DEBUG WIN32 _WINDOWS _MBCS _USRDLL); } } else { if($lib) { - print OUT "# ADD CPP /nologo /MT /W3 /GX /O2"; + print OUT "# ADD CPP /nologo /MD /W3 /GX /O2"; @defines2 = qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 WIN32 NDEBUG _WINDOWS _MBCS _LIB); } else { - print OUT "# ADD CPP /nologo /MT /W3 /GX /O2"; + print OUT "# ADD CPP /nologo /MD /W3 /GX /O2"; @defines2 = qw(WINVER=0x0501 _WIN32_WINNT=0x0501 _WIN32_IE=0x0600 NDEBUG WIN32 _WINDOWS _MBCS _USRDLL); } }

1 0

Francois Gouget : msvcmaker: Remove unneeded -I.. for the msvcrt tests.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 72d5c0ddca0841f140ec59bf66ee24e43697aaac URL: http://source.winehq.org/git/wine.git/?a=commit;h=72d5c0ddca0841f140ec59bf6… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 6 11:58:30 2006 +0100 msvcmaker: Remove unneeded -I.. for the msvcrt tests. --- tools/winapi/msvcmaker | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index 6fac11d..87c6430 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -631,10 +631,6 @@ sub _generate_dsp($$) { push @defines2, "__WINETEST_OUTPUT_DIR=\\\"$output_dir2\\\""; push @defines2, qw(__i386__ _X86_); - if($project eq "msvcrt_test") { - push @includes, ".."; - } - if ($project =~ /_test$/) { push @includes, "$msvc_wine_dir\\$output_dir"; }

1 0

Chris Robinson : wgl: Fix for missing NV GLX extension.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 28c2ebb937c46bbdb2d2c15c32913ddba32a93f2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=28c2ebb937c46bbdb2d2c15c3… Author: Chris Robinson <chris.kcat(a)gmail.com> Date: Tue Dec 5 21:30:36 2006 -0800 wgl: Fix for missing NV GLX extension. --- dlls/winex11.drv/opengl.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index 3eb98b9..9178152 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -374,10 +374,6 @@ LOAD_FUNCPTR(glXMakeContextCurrent) LOAD_FUNCPTR(glXGetCurrentReadDrawable) LOAD_FUNCPTR(glXGetFBConfigs) -/* NV GLX Extension */ -LOAD_FUNCPTR(glXAllocateMemoryNV) -LOAD_FUNCPTR(glXFreeMemoryNV) - /* Standard OpenGL calls */ LOAD_FUNCPTR(glBindTexture) LOAD_FUNCPTR(glBitmap) @@ -392,6 +388,15 @@ LOAD_FUNCPTR(glNewList) LOAD_FUNCPTR(glPixelStorei) #undef LOAD_FUNCPTR +/* It doesn't matter if these fail. They'll only be used if the driver reports + the associated extension is available (and if a driver reports the extension + is available but fails to provide the functions, it's quite broken) */ +#define LOAD_FUNCPTR(f) p##f = (void*)pglXGetProcAddressARB((const unsigned char*)#f); +/* NV GLX Extension */ +LOAD_FUNCPTR(glXAllocateMemoryNV) +LOAD_FUNCPTR(glXFreeMemoryNV) +#undef LOAD_FUNCPTR + if(!X11DRV_WineGL_InitOpenglInfo()) { ERR("Intialization of OpenGL info failed, disabling OpenGL!\n"); wine_dlclose(opengl_handle, NULL, 0);

1 0

Mike McCormack : msi: More tests for the SourceDir property.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 01cc2c32340f6b07ac3e44183137f99ae763052f URL: http://source.winehq.org/git/wine.git/?a=commit;h=01cc2c32340f6b07ac3e44183… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Dec 6 15:00:13 2006 +0900 msi: More tests for the SourceDir property. --- dlls/msi/tests/package.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 29608f2..5a6a7a8 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -2901,6 +2901,11 @@ static void test_sourcedirprop(void) ok( r == ERROR_SUCCESS, "failed to get property: %d\n", r); ok( !lstrcmpA(source_dir, path), "Expected %s, got %s\n", path, source_dir); + size = MAX_PATH; + r = MsiGetProperty( hpkg, "SoUrCeDiR", source_dir, &size ); + ok( r == ERROR_SUCCESS, "failed to get property: %d\n", r); + ok( !lstrlenA(source_dir), "Expected emtpy source dir, got %s\n", source_dir); + MsiCloseHandle(hpkg); DeleteFileA(msifile); } @@ -2975,6 +2980,27 @@ static void test_prop_path(void) ok( !lstrcmpi(cwd, buffer), "SourceDir (%s) should be current dir (%s)\n", buffer, cwd); } + r = MsiSetProperty(hpkg, "SourceDir", "goo"); + ok( r == ERROR_SUCCESS, "property not set\n"); + + sz = sizeof buffer; + buffer[0] = 0; + r = MsiGetProperty(hpkg, "SourceDir", buffer, &sz); + ok( r == ERROR_SUCCESS, "property not set\n"); + ok( !lstrcmpi(buffer, "goo"), "SourceDir (%s) should be goo\n", buffer); + + sz = sizeof buffer; + buffer[0] = 0; + r = MsiGetSourcePath(hpkg, "SourceDir", buffer, &sz ); + ok( r == ERROR_SUCCESS, "failed to get source path\n"); + ok( !lstrcmpi(buffer, cwd), "SourceDir (%s) should be goo\n", buffer); + + sz = sizeof buffer; + buffer[0] = 0; + r = MsiGetProperty(hpkg, "SourceDir", buffer, &sz); + ok( r == ERROR_SUCCESS, "property not set\n"); + ok( !lstrcmpi(buffer, "goo"), "SourceDir (%s) should be goo\n", buffer); + MsiCloseHandle( hpkg ); DeleteFile(msifile); }

1 0

Francois Gouget : msvcmaker: Fix the code that sets __WINETEST_OUTPUT_DIR so it does not pollute $output_dir .
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: bcf4a22a5e491d5e851076c2152c401360f3a680 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bcf4a22a5e491d5e851076c21… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Dec 6 11:57:29 2006 +0100 msvcmaker: Fix the code that sets __WINETEST_OUTPUT_DIR so it does not pollute $output_dir. --- tools/winapi/msvcmaker | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/winapi/msvcmaker b/tools/winapi/msvcmaker index 4774f79..6fac11d 100755 --- a/tools/winapi/msvcmaker +++ b/tools/winapi/msvcmaker @@ -627,8 +627,8 @@ sub _generate_dsp($$) { push @defines2, qw(__WINE_USE_NATIVE_HEADERS); } my $output_dir2 = $output_dir; - $output_dir =~ s/\\/\\\\/g; - push @defines2, "__WINETEST_OUTPUT_DIR=\\\"$output_dir\\\""; + $output_dir2 =~ s/\\/\\\\/g; + push @defines2, "__WINETEST_OUTPUT_DIR=\\\"$output_dir2\\\""; push @defines2, qw(__i386__ _X86_); if($project eq "msvcrt_test") {

1 0

Mike McCormack : msi: Add some tests for the ALTER query.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 3578bf64d6525dfc1773791570a024dece8edf6a URL: http://source.winehq.org/git/wine.git/?a=commit;h=3578bf64d6525dfc177379157… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Dec 6 15:00:02 2006 +0900 msi: Add some tests for the ALTER query. --- dlls/msi/tests/package.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index f82a210..29608f2 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -1374,6 +1374,18 @@ static void test_properties_table(void) r = run_query(hdb, query); ok(r == ERROR_SUCCESS, "failed to create table\n"); + query = "ALTER `_Properties` ADD `foo` INTEGER"; + r = run_query(hdb, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, "failed to add column\n"); + + query = "ALTER TABLE `_Properties` ADD `foo` INTEGER"; + r = run_query(hdb, query); + ok(r == ERROR_BAD_QUERY_SYNTAX, "failed to add column\n"); + + query = "ALTER TABLE `_Properties` ADD `extra` INTEGER"; + r = run_query(hdb, query); + todo_wine ok(r == ERROR_SUCCESS, "failed to add column\n"); + hpkg = package_from_db(hdb); ok( hpkg, "failed to create package\n");

1 0

Eric Pouech : dbghelp: Added ability to internal store / reload a symbol with a constant value.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 75033503e8aa668abe342f5d0542dc8322ba64b1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=75033503e8aa668abe342f5d0… Author: Eric Pouech <eric.pouech(a)wanadoo.fr> Date: Tue Dec 5 22:13:30 2006 +0100 dbghelp: Added ability to internal store / reload a symbol with a constant value. Let dwarf and msc use this new feature. As we also add global symbol without addresses, don't take those constant symbols into account for searches by address. --- dlls/dbghelp/dbghelp_private.h | 6 ++++ dlls/dbghelp/dwarf.c | 46 ++++++++++++++++++++++++++++++- dlls/dbghelp/msc.c | 54 +++++++++++++++++-------------------- dlls/dbghelp/symbol.c | 58 +++++++++++++++++++++++++++++++++------- 4 files changed, 123 insertions(+), 41 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=75033503e8aa668abe342…

1 0

Eric Pouech : winedbg: Added support for constant values passed by dbghelp.
by Alexandre Julliard Dec. 6, 2006

Dec. 6, 2006

Module: wine Branch: master Commit: 32a8b2fa59cd4b4514d36f26134027cb0841ff4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=32a8b2fa59cd4b4514d36f261… Author: Eric Pouech <eric.pouech(a)wanadoo.fr> Date: Tue Dec 5 22:13:33 2006 +0100 winedbg: Added support for constant values passed by dbghelp. --- programs/winedbg/symbol.c | 25 ++++++++++++++++++++++++- 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/programs/winedbg/symbol.c b/programs/winedbg/symbol.c index 55e35ee..f714409 100644 --- a/programs/winedbg/symbol.c +++ b/programs/winedbg/symbol.c @@ -87,6 +87,29 @@ static BOOL fill_sym_lvalue(const SYMBOL lvalue->cookie = DLV_TARGET; lvalue->addr.Offset = (ULONG)((ULONG64)*pval + sym->Address); } + else if (sym->Flags & SYMFLAG_VALUEPRESENT) + { + struct dbg_type type; + VARIANT v; + DWORD* pdw; + + type.module = sym->ModBase; + type.id = sym->info; + + /* FIXME: this won't work for pointers, as we always for the + * dereference to be in debuggee address space while here + * it's in debugger address space + */ + if (!types_get_info(&type, TI_GET_VALUE, &v) || (v.n1.n2.vt & VT_BYREF)) + { + snprintf(buffer, sz, "Couldn't dereference pointer for const value"); + return FALSE; + } + pdw = (DWORD*)lexeme_alloc_size(sizeof(*pdw)); + lvalue->cookie = DLV_HOST; + lvalue->addr.Offset = (ULONG)(DWORD_PTR)pdw; + *pdw = sym->Value; + } else if (sym->Flags & SYMFLAG_LOCAL) { lvalue->cookie = DLV_TARGET; @@ -125,7 +148,7 @@ static BOOL CALLBACK sgv_cb(SYMBOL_INFO* { struct sgv_data* sgv = (struct sgv_data*)ctx; unsigned insp; - char tmp[32]; + char tmp[64]; if (sym->Flags & SYMFLAG_THUNK) {

1 0