February 2006 - Wine-Commits

Jacek Caban : shdocvw: Includes clean up.
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: 5d854158b8c9d67968802a3b27bd8407dce2b28c URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=5d854158b8c9d67968802a3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Feb 8 12:36:25 2006 +0100 shdocvw: Includes clean up. --- dlls/shdocvw/shdocvw_main.c | 19 ++++--------------- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/dlls/shdocvw/shdocvw_main.c b/dlls/shdocvw/shdocvw_main.c index f01a36f..179d34a 100644 --- a/dlls/shdocvw/shdocvw_main.c +++ b/dlls/shdocvw/shdocvw_main.c @@ -23,25 +23,14 @@ #include <stdarg.h> #include <stdio.h> -#include <string.h> -#define COBJMACROS -#define COM_NO_WINDOWS_H - -#include "windef.h" -#include "winbase.h" -#include "winreg.h" -#include "winuser.h" -#include "winnls.h" -#include "ole2.h" -#include "shlwapi.h" +#include "wine/unicode.h" +#include "wine/debug.h" #include "shdocvw.h" -#include "uuids.h" -#include "urlmon.h" -#include "wine/unicode.h" -#include "wine/debug.h" +#include "winreg.h" +#include "shlwapi.h" #include "initguid.h"

1 0

Jacek Caban : shdocvw: Remove IQuickActivate interface implementation that is not
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: fa31cfb0b31c19839bd13b05a9d2d2e7a6b9b3b7 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=fa31cfb0b31c19839bd13b0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Feb 8 12:36:03 2006 +0100 shdocvw: Remove IQuickActivate interface implementation that is not implemented in Windows as well. --- dlls/shdocvw/Makefile.in | 1 dlls/shdocvw/misc.c | 98 ------------------------------------------- dlls/shdocvw/shdocvw.h | 3 - dlls/shdocvw/shdocvw_main.c | 8 ++++ dlls/shdocvw/webbrowser.c | 4 -- 5 files changed, 8 insertions(+), 106 deletions(-) delete mode 100644 dlls/shdocvw/misc.c diff --git a/dlls/shdocvw/Makefile.in b/dlls/shdocvw/Makefile.in index 46b358b..40c50a6 100644 --- a/dlls/shdocvw/Makefile.in +++ b/dlls/shdocvw/Makefile.in @@ -16,7 +16,6 @@ C_SRCS = \ events.c \ factory.c \ frame.c \ - misc.c \ oleobject.c \ persist.c \ regsvr.c \ diff --git a/dlls/shdocvw/misc.c b/dlls/shdocvw/misc.c deleted file mode 100644 index 2be6270..0000000 --- a/dlls/shdocvw/misc.c +++ /dev/null @@ -1,98 +0,0 @@ -/* - * Implementation of miscellaneous interfaces for WebBrowser control: - * - * - IQuickActivate - * - * Copyright 2001 John R. Sheets (for CodeWeavers) - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - */ - -#include "wine/debug.h" -#include "shdocvw.h" - -WINE_DEFAULT_DEBUG_CHANNEL(shdocvw); - -/********************************************************************** - * Implement the IQuickActivate interface - */ - -#define QUICKACT_THIS(iface) DEFINE_THIS(WebBrowser, QuickActivate, iface) - -static HRESULT WINAPI QuickActivate_QueryInterface(IQuickActivate *iface, - REFIID riid, LPVOID *ppobj) -{ - WebBrowser *This = QUICKACT_THIS(iface); - return IWebBrowser_QueryInterface(WEBBROWSER(This), riid, ppobj); -} - -static ULONG WINAPI QuickActivate_AddRef(IQuickActivate *iface) -{ - WebBrowser *This = QUICKACT_THIS(iface); - return IWebBrowser_AddRef(WEBBROWSER(This)); -} - -static ULONG WINAPI QuickActivate_Release(IQuickActivate *iface) -{ - WebBrowser *This = QUICKACT_THIS(iface); - return IWebBrowser_Release(WEBBROWSER(This)); -} - -static HRESULT WINAPI QuickActivate_QuickActivate(IQuickActivate *iface, - QACONTAINER *pQaContainer, QACONTROL *pQaControl) -{ - WebBrowser *This = QUICKACT_THIS(iface); - FIXME("(%p)->(%p %p)\n", This, pQaContainer, pQaControl); - return E_NOTIMPL; -} - -static HRESULT WINAPI QuickActivate_SetContentExtent(IQuickActivate *iface, LPSIZEL pSizel) -{ - WebBrowser *This = QUICKACT_THIS(iface); - FIXME("(%p)->(%p)\n", This, pSizel); - return E_NOTIMPL; -} - -static HRESULT WINAPI QuickActivate_GetContentExtent(IQuickActivate *iface, LPSIZEL pSizel) -{ - WebBrowser *This = QUICKACT_THIS(iface); - FIXME("(%p)->(%p)\n", This, pSizel); - return E_NOTIMPL; -} - -#undef QUICKACT_THIS - -static const IQuickActivateVtbl QuickActivateVtbl = -{ - QuickActivate_QueryInterface, - QuickActivate_AddRef, - QuickActivate_Release, - QuickActivate_QuickActivate, - QuickActivate_SetContentExtent, - QuickActivate_GetContentExtent -}; - -void WebBrowser_Misc_Init(WebBrowser *This) -{ - This->lpQuickActivateVtbl = &QuickActivateVtbl; -} - -/********************************************************************** - * OpenURL (SHDOCVW.@) - */ -void WINAPI OpenURL(HWND hWnd, HINSTANCE hInst, LPCSTR lpcstrUrl, int nShowCmd) -{ - FIXME("%p %p %s %d\n", hWnd, hInst, debugstr_a(lpcstrUrl), nShowCmd); -} diff --git a/dlls/shdocvw/shdocvw.h b/dlls/shdocvw/shdocvw.h index ba10279..a103615 100644 --- a/dlls/shdocvw/shdocvw.h +++ b/dlls/shdocvw/shdocvw.h @@ -72,7 +72,6 @@ typedef struct { const IPersistStorageVtbl *lpPersistStorageVtbl; const IPersistStreamInitVtbl *lpPersistStreamInitVtbl; const IProvideClassInfo2Vtbl *lpProvideClassInfoVtbl; - const IQuickActivateVtbl *lpQuickActivateVtbl; const IConnectionPointContainerVtbl *lpConnectionPointContainerVtbl; const IViewObject2Vtbl *lpViewObjectVtbl; const IOleInPlaceActiveObjectVtbl *lpOleInPlaceActiveObjectVtbl; @@ -130,7 +129,6 @@ typedef struct { #define PERSTORAGE(x) ((IPersistStorage*) &(x)->lpPersistStorageVtbl) #define PERSTRINIT(x) ((IPersistStreamInit*) &(x)->lpPersistStreamInitVtbl) #define CLASSINFO(x) ((IProvideClassInfo2*) &(x)->lpProvideClassInfoVtbl) -#define QUICKACT(x) ((IQuickActivate*) &(x)->lpQuickActivateVtbl) #define CONPTCONT(x) ((IConnectionPointContainer*) &(x)->lpConnectionPointContainerVtbl) #define VIEWOBJ(x) ((IViewObject*) &(x)->lpViewObjectVtbl); #define VIEWOBJ2(x) ((IViewObject2*) &(x)->lpViewObjectVtbl); @@ -151,7 +149,6 @@ void WebBrowser_OleObject_Init(WebBrowse void WebBrowser_ViewObject_Init(WebBrowser*); void WebBrowser_Persist_Init(WebBrowser*); void WebBrowser_ClassInfo_Init(WebBrowser*); -void WebBrowser_Misc_Init(WebBrowser*); void WebBrowser_Events_Init(WebBrowser*); void WebBrowser_ClientSite_Init(WebBrowser*); diff --git a/dlls/shdocvw/shdocvw_main.c b/dlls/shdocvw/shdocvw_main.c index 4df0ead..f01a36f 100644 --- a/dlls/shdocvw/shdocvw_main.c +++ b/dlls/shdocvw/shdocvw_main.c @@ -589,3 +589,11 @@ DWORD WINAPI SetQueryNetSessionCount(DWO FIXME("(%lu), stub!\n", arg); return 0; } + +/********************************************************************** + * OpenURL (SHDOCVW.@) + */ +void WINAPI OpenURL(HWND hWnd, HINSTANCE hInst, LPCSTR lpcstrUrl, int nShowCmd) +{ + FIXME("%p %p %s %d\n", hWnd, hInst, debugstr_a(lpcstrUrl), nShowCmd); +} diff --git a/dlls/shdocvw/webbrowser.c b/dlls/shdocvw/webbrowser.c index 1c435bd..836a164 100644 --- a/dlls/shdocvw/webbrowser.c +++ b/dlls/shdocvw/webbrowser.c @@ -82,9 +82,6 @@ static HRESULT WINAPI WebBrowser_QueryIn }else if(IsEqualGUID(&IID_IProvideClassInfo2, riid)) { TRACE("(%p)->(IID_IProvideClassInfo2 %p)\n", This, ppv); *ppv = CLASSINFO(This); - }else if(IsEqualGUID(&IID_IQuickActivate, riid)) { - TRACE("(%p)->(IID_IQuickActivate %p)\n", This, ppv); - *ppv = QUICKACT(This); }else if(IsEqualGUID(&IID_IConnectionPointContainer, riid)) { TRACE("(%p)->(IID_IConnectionPointContainer %p)\n", This, ppv); *ppv = CONPTCONT(This); @@ -806,7 +803,6 @@ HRESULT WebBrowser_Create(IUnknown *pOut WebBrowser_ViewObject_Init(ret); WebBrowser_Persist_Init(ret); WebBrowser_ClassInfo_Init(ret); - WebBrowser_Misc_Init(ret); WebBrowser_Events_Init(ret); WebBrowser_ClientSite_Init(ret); WebBrowser_DocHost_Init(ret);

1 0

Jacek Caban : urlmon.idl: Added BINDINFOF declaration.
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: 0e3be46855c44fe4d2dbde42c0cca53be9b2d8c4 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=0e3be46855c44fe4d2dbde4… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Feb 8 12:35:41 2006 +0100 urlmon.idl: Added BINDINFOF declaration. --- include/urlmon.idl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/include/urlmon.idl b/include/urlmon.idl index 85a9277..96f665b 100644 --- a/include/urlmon.idl +++ b/include/urlmon.idl @@ -84,6 +84,12 @@ interface IBindStatusCallback : IUnknown typedef enum { + BINDINFOF_URLENCODESTGMEDDATA = 0x00000001, + BINDINFOF_URLENCODEDEXTRAINFO = 0x00000002 + } BINDINFOF; + + typedef enum + { BINDF_ASYNCHRONOUS = 0x00000001, BINDF_ASYNCSTORAGE = 0x00000002, BINDF_NOPROGRESSIVERENDERING = 0x00000004,

1 0

Dmitry Timoshkov : Pens created without PS_GEOMETRIC style but with width > 1 unit are
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: 75e8166d7487461ead74e856106cfca79ae792a5 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=75e8166d7487461ead74e85… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Feb 8 12:35:29 2006 +0100 Pens created without PS_GEOMETRIC style but with width > 1 unit are scalable. --- dlls/wineps/pen.c | 2 +- dlls/x11drv/pen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wineps/pen.c b/dlls/wineps/pen.c index 9f92cbe..6944635 100644 --- a/dlls/wineps/pen.c +++ b/dlls/wineps/pen.c @@ -59,7 +59,7 @@ HPEN PSDRV_SelectPen( PSDRV_PDEVICE *phy TRACE("hpen = %p colour = %08lx\n", hpen, logpen.lopnColor); physDev->pen.width = logpen.lopnWidth.x; - if (logpen.lopnStyle & PS_GEOMETRIC) + if ((logpen.lopnStyle & PS_GEOMETRIC) || (physDev->pen.width > 1)) { physDev->pen.width = PSDRV_XWStoDS( physDev, physDev->pen.width ); if(physDev->pen.width < 0) physDev->pen.width = -physDev->pen.width; diff --git a/dlls/x11drv/pen.c b/dlls/x11drv/pen.c index 8fb1fa3..26cffce 100644 --- a/dlls/x11drv/pen.c +++ b/dlls/x11drv/pen.c @@ -59,7 +59,7 @@ HPEN X11DRV_SelectPen( X11DRV_PDEVICE *p physDev->pen.linejoin = logpen.lopnStyle & PS_JOIN_MASK; physDev->pen.width = logpen.lopnWidth.x; - if (logpen.lopnStyle & PS_GEOMETRIC) + if ((logpen.lopnStyle & PS_GEOMETRIC) || (physDev->pen.width > 1)) { physDev->pen.width = X11DRV_XWStoDS( physDev, physDev->pen.width ); if (physDev->pen.width < 0) physDev->pen.width = -physDev->pen.width;

1 0

Dmitry Timoshkov : gdi: Remove StrokePath workaround for a DC transformation change bug.
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: 1ecef1c97e8e538b265745aded65d41d50d4c6cd URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=1ecef1c97e8e538b265745a… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Feb 8 12:35:18 2006 +0100 gdi: Remove StrokePath workaround for a DC transformation change bug. --- dlls/gdi/path.c | 36 ------------------------------------ 1 files changed, 0 insertions(+), 36 deletions(-) diff --git a/dlls/gdi/path.c b/dlls/gdi/path.c index 1e98fe5..aceee7e 100644 --- a/dlls/gdi/path.c +++ b/dlls/gdi/path.c @@ -1653,8 +1653,6 @@ static BOOL PATH_StrokePath(DC *dc, GdiP SIZE szViewportExt, szWindowExt; DWORD mapMode, graphicsMode; XFORM xform; - HGDIOBJ hOldPen; - HPEN hNewPen; BOOL ret = TRUE; if(dc->funcs->pStrokePath) @@ -1662,36 +1660,6 @@ static BOOL PATH_StrokePath(DC *dc, GdiP if(pPath->state != PATH_Closed) return FALSE; - - /* Convert pen properties from logical to device units for MWT_IDENTITY */ - hOldPen = GetCurrentObject(dc->hSelf, OBJ_PEN); - if(GetObjectType(hOldPen) == OBJ_EXTPEN) { - EXTLOGPEN elp; - LOGBRUSH lb; - GetObjectW(hOldPen, sizeof(EXTLOGPEN), &elp); - if(elp.elpPenStyle & PS_GEOMETRIC) { - INTERNAL_WSTODS(dc, &elp.elpWidth); - if(elp.elpPenStyle & PS_USERSTYLE) - for(i = 0; i < elp.elpNumEntries; i++) - INTERNAL_WSTODS(dc, &elp.elpStyleEntry[i]); - } - lb.lbStyle = elp.elpBrushStyle; - lb.lbColor = elp.elpColor; - lb.lbHatch = elp.elpHatch; - if(elp.elpPenStyle & PS_USERSTYLE) - hNewPen = ExtCreatePen(elp.elpPenStyle, elp.elpWidth, &lb, - elp.elpNumEntries, elp.elpStyleEntry); - else - hNewPen = ExtCreatePen(elp.elpPenStyle, elp.elpWidth, &lb, - 0, NULL); - } else /* OBJ_PEN */ { - LOGPEN lp; - GetObjectW(hOldPen, sizeof(LOGPEN), &lp); - if(lp.lopnWidth.x > 0) - INTERNAL_WSTODS(dc, (DWORD*)&lp.lopnWidth.x); - hNewPen = CreatePenIndirect(&lp); - } - SelectObject(dc->hSelf, hNewPen); /* Save the mapping mode info */ mapMode=GetMapMode(dc->hSelf); @@ -1808,10 +1776,6 @@ static BOOL PATH_StrokePath(DC *dc, GdiP MoveToEx(dc->hSelf, pt.x, pt.y, NULL); } - /* Restore old pen */ - DeleteObject(hNewPen); - SelectObject(dc->hSelf, hOldPen); - return ret; }

1 0

Huw Davies : wineps: Don't display the MFCOMMENT escape.
by Alexandre Julliard Feb. 8, 2006

Feb. 8, 2006

Module: wine Branch: refs/heads/master Commit: 06a293cabe845a583594333b8cd900de4ed2fd46 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=06a293cabe845a583594333… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Feb 8 12:35:05 2006 +0100 wineps: Don't display the MFCOMMENT escape. --- dlls/wineps/escape.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/wineps/escape.c b/dlls/wineps/escape.c index 88445d5..d7627c3 100644 --- a/dlls/wineps/escape.c +++ b/dlls/wineps/escape.c @@ -82,10 +82,7 @@ INT PSDRV_ExtEscape( PSDRV_PDEVICE *phys case MFCOMMENT: { - int i; FIXME("MFCOMMENT(%p, %d)\n", in_data, cbInput); - for (i=0;i<cbInput;i++) MESSAGE("%02x ", ((LPBYTE)in_data)[i]); - MESSAGE("\n"); return 1; } case DRAWPATTERNRECT:

1 0

appdb/ ./apidb.css ./application.css ./index.p ...
by WineHQ Feb. 8, 2006

Feb. 8, 2006

ChangeSet ID: 22872 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/02/07 21:19:40 Modified files: . : apidb.css application.css index.php help : maintainer_ratings.help include : util.php Log message: Tony Lambregts <tony.lambregts(a)gmail.com> Add Platinum to ratings Patch: http://cvs.winehq.org/patch.py?id=22872 Old revision New revision Changes Path 1.13 1.14 +1 -0 appdb/apidb.css 1.5 1.6 +10 -8 appdb/application.css 1.31 1.32 +14 -1 appdb/index.php 1.3 1.4 +15 -10 appdb/help/maintainer_ratings.help 1.51 1.52 +3 -3 appdb/include/util.php Index: appdb/apidb.css diff -u -p appdb/apidb.css:1.13 appdb/apidb.css:1.14 --- appdb/apidb.css:1.13 8 Feb 2006 3:19:40 -0000 +++ appdb/apidb.css 8 Feb 2006 3:19:40 -0000 @@ -133,6 +133,7 @@ p.indent { padding-left: 1em; .committed { font-style: italic; color: gray; } /* App Support status */ +.platinum { background-color: #EFEFEF; } .gold { background-color: #fff600; } .silver { background-color: silver; } .bronze { background-color: #fcba0a; } Index: appdb/application.css diff -u -p appdb/application.css:1.5 appdb/application.css:1.6 --- appdb/application.css:1.5 8 Feb 2006 3:19:40 -0000 +++ appdb/application.css 8 Feb 2006 3:19:40 -0000 @@ -18,12 +18,14 @@ table.historyTable { border: 1px; font-family: "bitstream vera sans", "verdana", "arial", "helvetica", sans-serif; font-size: 12px; } -td.gold { background-color: #fff600; } -td.silver { background-color: silver; } -td.bronze { background-color: #fcba0a; } -td.garbage { background-color: #999966; } +td.platinum { background-color: #EFEFEF; } +td.gold { background-color: #fff600; } +td.silver { background-color: silver; } +td.bronze { background-color: #fcba0a; } +td.garbage { background-color: #999966; } -tr.gold { background-color: #fff600; } -tr.silver { background-color: silver; } -tr.bronze { background-color: #fcba0a; } -tr.garbage { background-color: #999966; } +td.platinum { background-color: #EFEFEF; } +tr.gold { background-color: #fff600; } +tr.silver { background-color: silver; } +tr.bronze { background-color: #fcba0a; } +tr.garbage { background-color: #999966; } Index: appdb/index.php diff -u -p appdb/index.php:1.31 appdb/index.php:1.32 --- appdb/index.php:1.31 8 Feb 2006 3:19:40 -0000 +++ appdb/index.php 8 Feb 2006 3:19:40 -0000 @@ -88,8 +88,20 @@ If you have screenshots or links to cont <p>This is a list of applications that are known to be working well and for which many AppDB users voted.</p> +<h3>The top-10 Platinum List</h3> +<p>Only Applications which install and run flawless on a out-of-the-box Wine installation make it to the Platinum list: </p> +<table class="platinum"> + <tr class="rowtitle"> + <th>Application</th><th>Description</th><th>Screenshot</th> + </tr> +<?php + outputTopXRowAppsFromRating('Platinum', 10); +?> +</table> +<br /> + <h3>The top-10 Gold List</h3> -<p>Applications which install and run virtually flawless on a out-of-the-box Wine installation make it to the Gold list: </p> +<p>Applications that work flawlessly with some DLL overrides or other settings, crack etc make it to the Gold list: </p> <table class="gold"> <tr class="rowtitle"> <th>Application</th><th>Description</th><th>Screenshot</th> @@ -99,6 +111,7 @@ If you have screenshots or links to cont ?> </table> <br /> + <h3>The top-10 Silver List</h3> <p>The Silver list contains apps which we hope we can easily fix so they make it to Gold status:</p> <table class=silver> Index: appdb/help/maintainer_ratings.help diff -u -p appdb/help/maintainer_ratings.help:1.3 appdb/help/maintainer_ratings.help:1.4 --- appdb/help/maintainer_ratings.help:1.3 8 Feb 2006 3:19:40 -0000 +++ appdb/help/maintainer_ratings.help 8 Feb 2006 3:19:40 -0000 @@ -10,32 +10,37 @@ users by giving a rating based on an "ex <ul> -<li>Gold</li> +<li class="platinum">Platinum</li> <p> -An application can be rated as Gold if it installs and runs "out of the box". +An application can be rated as Platinum if it installs and runs "out of the box" No changes required to winecfg. </p> -<li>Silver</li> +<li class="gold">Gold</li> <p> -If an application needs DLL overrides (native DLL's from a Windows installation) to install and -run but runs flawlessly otherwise, then it can be rated as silver. There should be an accompanying "How-To" -written to allow users to get this application to run. +Application works flawlessly with some DLL overrides or other settings, crack etc. </p> -<li>Bronze</li> +<li class="silver">Silver</li> <p> -Bronze Applications may have bugs in them and require DLL overrides. If the program can be used -as it was intended but is missing features then the can be rated as Bronze. +Application works excellently for 'normal' use; a game works fine in single-player but not +in multi-player, Windows Media Player works fine as a plug-in and stand-alone player, but can't handle DRM etc. </p> -<li>Garbage</li> +<li class="Bronze">Bronze</li> + +<p> +Application works, but it has some issues, even for normal use; a game may not redraw properly or display fonts in wrong colours, be a much slower than it should etc. +</p> + +<li class="Garbage">Garbage</li> <p> An app gets this rating if it can not be used for the purpose it was designed. There should be at least one bug report in bugzilla if an app gets this rating. +Application doesn't start, or starts but has so many errors that it is nearly impossible to use it </p> </ul> Index: appdb/include/util.php diff -u -p appdb/include/util.php:1.51 appdb/include/util.php:1.52 --- appdb/include/util.php:1.51 8 Feb 2006 3:19:40 -0000 +++ appdb/include/util.php 8 Feb 2006 3:19:40 -0000 @@ -139,15 +139,15 @@ function make_maintainer_rating_list($va echo "<select name='$varname'>\n"; echo "<option value=\"\">Choose ...</option>\n"; - $aRating = array("Gold", "Silver", "Bronze", "Garbage"); + $aRating = array("Platinum", "Gold", "Silver", "Bronze", "Garbage"); $iMax = count($aRating); for($i=0; $i < $iMax; $i++) { if($aRating[$i] == $cvalue) - echo "<option value=$aRating[$i] selected>$aRating[$i]\n"; + echo "<option class=$aRating[$i] value=$aRating[$i] selected>$aRating[$i]\n"; else - echo "<option value=$aRating[$i]>$aRating[$i]\n"; + echo "<option class=$aRating[$i] value=$aRating[$i]>$aRating[$i]\n"; } echo "</select>\n"; }

1 0

appdb/ include/testResults.php tables/testResu ...
by WineHQ Feb. 8, 2006

Feb. 8, 2006

ChangeSet ID: 22871 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/02/07 19:44:11 Modified files: include : testResults.php tables : testResults.sql Log message: Tony Lambregts <tony.lambregts(a)gmail.com> Modify 'installs' and 'runs' fields Patch: http://cvs.winehq.org/patch.py?id=22871 Old revision New revision Changes Path 1.9 1.10 +6 -6 appdb/include/testResults.php 1.1 1.2 +2 -3 appdb/tables/testResults.sql Index: appdb/include/testResults.php diff -u -p appdb/include/testResults.php:1.9 appdb/include/testResults.php:1.10 --- appdb/include/testResults.php:1.9 8 Feb 2006 1:44:11 -0000 +++ appdb/include/testResults.php 8 Feb 2006 1:44:11 -0000 @@ -657,15 +657,15 @@ function make_Installs_list($varname, $c echo "<select name='$varname'>\n"; echo "<option value=\"\">Choose ...</option>\n"; - $aRating = array("Yes", "No"); + $aRating = array("Yes", "No", "N/A"); $iMax = count($aRating); for($i=0; $i < $iMax; $i++) { if($aRating[$i] == $cvalue) - echo "<option value=$aRating[$i] selected>$aRating[$i]\n"; + echo "<option value='".$aRating[$i]."' selected>".$aRating[$i]."\n"; else - echo "<option value=$aRating[$i]>$aRating[$i]\n"; + echo "<option value='".$aRating[$i]."'>".$aRating[$i]."\n"; } echo "</select>\n"; } @@ -675,15 +675,15 @@ function make_Runs_list($varname, $cvalu echo "<select name='$varname'>\n"; echo "<option value=\"\">Choose ...</option>\n"; - $aRating = array("Yes", "No", "???"); + $aRating = array("Yes", "No", "Not Installable"); $iMax = count($aRating); for($i=0; $i < $iMax; $i++) { if($aRating[$i] == $cvalue) - echo "<option value=$aRating[$i] selected>$aRating[$i]\n"; + echo "<option value='".$aRating[$i]."' selected>".$aRating[$i]."\n"; else - echo "<option value=$aRating[$i]>$aRating[$i]\n"; + echo "<option value='".$aRating[$i]."'>".$aRating[$i]."\n"; } echo "</select>\n"; } Index: appdb/tables/testResults.sql diff -u -p appdb/tables/testResults.sql:1.1 appdb/tables/testResults.sql:1.2 --- appdb/tables/testResults.sql:1.1 8 Feb 2006 1:44:11 -0000 +++ appdb/tables/testResults.sql 8 Feb 2006 1:44:11 -0000 @@ -1,7 +1,6 @@ use apidb; drop table if exists testResults; -drop table if exists TestResults; /* * Version Testing results @@ -15,8 +14,8 @@ create table testResults ( testedDate datetime not null, distributionId int not null, testedRelease tinytext, - installs enum('Yes','No') NOT NULL default 'Yes', - runs enum('Yes','No','???') NOT NULL default 'Yes', + installs enum('Yes','No','N/A') NOT NULL default 'Yes', + runs enum('Yes','No','Not Installable') NOT NULL default 'Yes', testedRating tinytext, comments text, submitTime timestamp(14) NOT NULL,

1 0

Francois Gouget : ntdll: Fix typo in HAVE_STRUCT_MTGET_MT_GSTAT ifdef.
by Alexandre Julliard Feb. 7, 2006

Feb. 7, 2006

Module: wine Branch: refs/heads/master Commit: 6fcc7b5bb066549320f41c7381e05935804e21e6 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=6fcc7b5bb066549320f41c7… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Feb 7 21:18:19 2006 +0100 ntdll: Fix typo in HAVE_STRUCT_MTGET_MT_GSTAT ifdef. --- dlls/ntdll/tape.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/tape.c b/dlls/ntdll/tape.c index b8403b8..b9ca48d 100644 --- a/dlls/ntdll/tape.c +++ b/dlls/ntdll/tape.c @@ -218,7 +218,7 @@ static NTSTATUS TAPE_GetMediaParams( int data->BlockSize = get.mt_dsreg & MT_ST_BLKSIZE_MASK; #endif data->PartitionCount = 1; -#ifdef HAVE_STRUCT_MTGET_GSTAT +#ifdef HAVE_STRUCT_MTGET_MT_GSTAT data->WriteProtected = GMT_WR_PROT(get.mt_gstat); #else data->WriteProtected = 0;

1 0

Francois Gouget : shell32: Update DllGetClassObject documentation.
by Alexandre Julliard Feb. 7, 2006

Feb. 7, 2006

Module: wine Branch: refs/heads/master Commit: d3aa2313b8cb0aa60901f89892d7585a12109269 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=d3aa2313b8cb0aa60901f89… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue Feb 7 21:18:12 2006 +0100 shell32: Update DllGetClassObject documentation. --- dlls/shell32/shellole.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shellole.c b/dlls/shell32/shellole.c index 9b92c26..691824c 100644 --- a/dlls/shell32/shellole.c +++ b/dlls/shell32/shellole.c @@ -216,7 +216,8 @@ end: } /************************************************************************* - * DllGetClassObject [SHELL32.@] + * DllGetClassObject [SHELL32.@] + * SHDllGetClassObject [SHELL32.128] */ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv) {

1 0