March 2006 - Wine-Commits - list.winehq.org

Robert Shearman : oleaut: Use IsEqualIID in connpt. c instead of memcmp for comparing IIDs.
by Alexandre Julliard March 2, 2006

March 2, 2006

Module: wine Branch: refs/heads/master Commit: 269909f53e902014a6c1a5b92689269ec684d424 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=269909f53e902014a6c1a5b… Author: Robert Shearman <rob(a)codeweavers.com> Date: Wed Mar 1 12:17:00 2006 +0000 oleaut: Use IsEqualIID in connpt.c instead of memcmp for comparing IIDs. --- dlls/oleaut32/connpt.c | 16 ++++------------ 1 files changed, 4 insertions(+), 12 deletions(-) diff --git a/dlls/oleaut32/connpt.c b/dlls/oleaut32/connpt.c index da0ffcc..78f4117 100644 --- a/dlls/oleaut32/connpt.c +++ b/dlls/oleaut32/connpt.c @@ -160,14 +160,10 @@ static HRESULT WINAPI ConnectionPointImp /* * Compare the riid with the interface IDs implemented by this object. */ - if (memcmp(&IID_IUnknown, riid, sizeof(IID_IUnknown)) == 0) - { + if (IsEqualIID(&IID_IUnknown, riid)) *ppvObject = (IConnectionPoint*)This; - } - else if (memcmp(&IID_IConnectionPoint, riid, sizeof(IID_IConnectionPoint)) == 0) - { + else if (IsEqualIID(&IID_IConnectionPoint, riid)) *ppvObject = (IConnectionPoint*)This; - } /* * Check that we obtained an interface. @@ -433,14 +429,10 @@ static HRESULT WINAPI EnumConnectionsImp /* * Compare the riid with the interface IDs implemented by this object. */ - if (memcmp(&IID_IUnknown, riid, sizeof(IID_IUnknown)) == 0) - { + if (IsEqualIID(&IID_IUnknown, riid)) *ppvObject = (IEnumConnections*)This; - } - else if (memcmp(&IID_IEnumConnections, riid, sizeof(IID_IEnumConnections)) == 0) - { + else if (IsEqualIID(&IID_IEnumConnections, riid)) *ppvObject = (IEnumConnections*)This; - } /* * Check that we obtained an interface.

1 0

Robert Shearman : rpcrt4: Change the stubless parameter attributes to using a bitfield
by Alexandre Julliard March 2, 2006

March 2, 2006

Module: wine Branch: refs/heads/master Commit: 4253b0123932102a6be3d8397f02feea41ef83a5 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=4253b0123932102a6be3d83… Author: Robert Shearman <rob(a)codeweavers.com> Date: Wed Mar 1 12:22:26 2006 +0000 rpcrt4: Change the stubless parameter attributes to using a bitfield (as defined by the PSDK) so the ServerAllocSize part is easier to calculate. --- dlls/rpcrt4/ndr_stubless.c | 133 +++++++++++++++++--------------------------- include/Makefile.in | 1 include/ndrtypes.h | 57 +++++++++++++++++++ 3 files changed, 110 insertions(+), 81 deletions(-) create mode 100644 include/ndrtypes.h Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=4253b0123932102a6be…

1 0

Juan Lang : crypt32: Use CertFindCertificateInStore to simplify adding certificates.
by Alexandre Julliard March 2, 2006

March 2, 2006

Module: wine Branch: refs/heads/master Commit: 661d80708b5c57308c22684ba8372e33c991cd8e URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=661d80708b5c57308c22684… Author: Juan Lang <juan_lang(a)yahoo.com> Date: Wed Mar 1 08:38:32 2006 -0800 crypt32: Use CertFindCertificateInStore to simplify adding certificates. --- dlls/crypt32/store.c | 78 ++++++++++++++++++-------------------------------- 1 files changed, 28 insertions(+), 50 deletions(-) diff --git a/dlls/crypt32/store.c b/dlls/crypt32/store.c index 840d168..47e595c 100644 --- a/dlls/crypt32/store.c +++ b/dlls/crypt32/store.c @@ -373,74 +373,50 @@ static BOOL CRYPT_MemAddCert(PWINECRYPT_ { WINE_MEMSTORE *ms = (WINE_MEMSTORE *)store; BOOL add = FALSE, ret; + PCCERT_CONTEXT existing = NULL; TRACE("(%p, %p, %ld, %p)\n", store, cert, dwAddDisposition, ppStoreContext); - switch (dwAddDisposition) - { - case CERT_STORE_ADD_ALWAYS: - add = TRUE; - break; - case CERT_STORE_ADD_NEW: + if (dwAddDisposition != CERT_STORE_ADD_ALWAYS) { - BYTE hashToAdd[20], hash[20]; + BYTE hashToAdd[20]; DWORD size = sizeof(hashToAdd); ret = CRYPT_GetCertificateContextProperty(cert, CERT_HASH_PROP_ID, hashToAdd, &size); if (ret) { - PWINE_CERT_LIST_ENTRY cursor; + CRYPT_HASH_BLOB blob = { sizeof(hashToAdd), hashToAdd }; - /* Add if no cert with the same hash is found. */ - add = TRUE; - EnterCriticalSection(&ms->cs); - LIST_FOR_EACH_ENTRY(cursor, &ms->certs, WINE_CERT_LIST_ENTRY, entry) - { - size = sizeof(hash); - ret = CertGetCertificateContextProperty(&cursor->cert.cert, - CERT_HASH_PROP_ID, hash, &size); - if (ret && !memcmp(hashToAdd, hash, size)) - { - TRACE("found matching certificate, not adding\n"); - SetLastError(CRYPT_E_EXISTS); - add = FALSE; - break; - } - } - LeaveCriticalSection(&ms->cs); + existing = CertFindCertificateInStore(store, + cert->cert.dwCertEncodingType, 0, CERT_FIND_SHA1_HASH, &blob, + NULL); + } + } + switch (dwAddDisposition) + { + case CERT_STORE_ADD_ALWAYS: + add = TRUE; + break; + case CERT_STORE_ADD_NEW: + { + if (existing) + { + TRACE("found matching certificate, not adding\n"); + SetLastError(CRYPT_E_EXISTS); + add = FALSE; } + else + add = TRUE; break; } case CERT_STORE_ADD_REPLACE_EXISTING: { - BYTE hashToAdd[20], hash[20]; - DWORD size = sizeof(hashToAdd); - add = TRUE; - ret = CRYPT_GetCertificateContextProperty(cert, CERT_HASH_PROP_ID, - hashToAdd, &size); - if (ret) + if (existing) { - PWINE_CERT_LIST_ENTRY cursor, next; - - /* Look for existing cert to delete */ - EnterCriticalSection(&ms->cs); - LIST_FOR_EACH_ENTRY_SAFE(cursor, next, &ms->certs, - WINE_CERT_LIST_ENTRY, entry) - { - size = sizeof(hash); - ret = CertGetCertificateContextProperty(&cursor->cert.cert, - CERT_HASH_PROP_ID, hash, &size); - if (ret && !memcmp(hashToAdd, hash, size)) - { - TRACE("found matching certificate, replacing\n"); - list_remove(&cursor->entry); - CertFreeCertificateContext((PCCERT_CONTEXT)cursor); - break; - } - } - LeaveCriticalSection(&ms->cs); + TRACE("found matching certificate, replacing\n"); + CertDeleteCertificateFromStore(existing); } break; } @@ -448,6 +424,8 @@ static BOOL CRYPT_MemAddCert(PWINECRYPT_ FIXME("Unimplemented add disposition %ld\n", dwAddDisposition); add = FALSE; } + if (existing) + CertFreeCertificateContext(existing); if (add) { PWINE_CERT_LIST_ENTRY entry = CryptMemAlloc(

1 0

Robert Shearman : rpcrt4: Implement marshaling and unmarshaling for enum types.
by Alexandre Julliard March 2, 2006

March 2, 2006

Module: wine Branch: refs/heads/master Commit: e8877ede800d3fc7b7f79a89bd32c879842ccb84 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=e8877ede800d3fc7b7f79a8… Author: Robert Shearman <rob(a)codeweavers.com> Date: Wed Mar 1 12:21:56 2006 +0000 rpcrt4: Implement marshaling and unmarshaling for enum types. --- dlls/rpcrt4/ndr_marshall.c | 24 ++++++++++++++++++++---- 1 files changed, 20 insertions(+), 4 deletions(-) diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c index 3045b42..b77c281 100644 --- a/dlls/rpcrt4/ndr_marshall.c +++ b/dlls/rpcrt4/ndr_marshall.c @@ -26,6 +26,7 @@ #include <stdio.h> #include <string.h> #include <assert.h> +#include <limits.h> #include "windef.h" #include "winbase.h" @@ -2985,6 +2986,7 @@ static unsigned char *WINAPI NdrBaseType case RPC_FC_LONG: case RPC_FC_ULONG: case RPC_FC_ERROR_STATUS_T: + case RPC_FC_ENUM32: ALIGN_POINTER(pStubMsg->Buffer, sizeof(ULONG) - 1); *(ULONG *)pStubMsg->Buffer = *(ULONG *)pMemory; pStubMsg->Buffer += sizeof(ULONG); @@ -3007,7 +3009,14 @@ static unsigned char *WINAPI NdrBaseType TRACE("value: %s\n", wine_dbgstr_longlong(*(ULONGLONG*)pMemory)); break; case RPC_FC_ENUM16: - case RPC_FC_ENUM32: + /* only 16-bits on the wire, so do a sanity check */ + if (*(UINT *)pMemory > USHRT_MAX) + RpcRaiseException(RPC_X_ENUM_VALUE_OUT_OF_RANGE); + ALIGN_POINTER(pStubMsg->Buffer, sizeof(USHORT) - 1); + *(USHORT *)pStubMsg->Buffer = *(UINT *)pMemory; + pStubMsg->Buffer += sizeof(USHORT); + TRACE("value: 0x%04x\n", *(UINT *)pMemory); + break; default: FIXME("Unhandled base type: 0x%02x\n", *pFormat); } @@ -3055,6 +3064,7 @@ static unsigned char *WINAPI NdrBaseType case RPC_FC_LONG: case RPC_FC_ULONG: case RPC_FC_ERROR_STATUS_T: + case RPC_FC_ENUM32: ALIGN_POINTER(pStubMsg->Buffer, sizeof(ULONG) - 1); **(ULONG **)ppMemory = *(ULONG *)pStubMsg->Buffer; pStubMsg->Buffer += sizeof(ULONG); @@ -3079,7 +3089,12 @@ static unsigned char *WINAPI NdrBaseType TRACE("value: %s\n", wine_dbgstr_longlong(**(ULONGLONG **)ppMemory)); break; case RPC_FC_ENUM16: - case RPC_FC_ENUM32: + ALIGN_POINTER(pStubMsg->Buffer, sizeof(USHORT) - 1); + /* 16-bits on the wire, but int in memory */ + **(UINT **)ppMemory = *(USHORT *)pStubMsg->Buffer; + pStubMsg->Buffer += sizeof(USHORT); + TRACE("value: 0x%08x\n", **(UINT **)ppMemory); + break; default: FIXME("Unhandled base type: 0x%02x\n", *pFormat); } @@ -3110,11 +3125,13 @@ static void WINAPI NdrBaseTypeBufferSize case RPC_FC_WCHAR: case RPC_FC_SHORT: case RPC_FC_USHORT: + case RPC_FC_ENUM16: ALIGN_LENGTH(pStubMsg->BufferLength, sizeof(USHORT) - 1); pStubMsg->BufferLength += sizeof(USHORT); break; case RPC_FC_LONG: case RPC_FC_ULONG: + case RPC_FC_ENUM32: ALIGN_LENGTH(pStubMsg->BufferLength, sizeof(ULONG) - 1); pStubMsg->BufferLength += sizeof(ULONG); break; @@ -3134,8 +3151,6 @@ static void WINAPI NdrBaseTypeBufferSize ALIGN_LENGTH(pStubMsg->BufferLength, sizeof(error_status_t) - 1); pStubMsg->BufferLength += sizeof(error_status_t); break; - case RPC_FC_ENUM16: - case RPC_FC_ENUM32: default: FIXME("Unhandled base type: 0x%02x\n", *pFormat); } @@ -3172,6 +3187,7 @@ static unsigned long WINAPI NdrBaseTypeM return sizeof(error_status_t); case RPC_FC_ENUM16: case RPC_FC_ENUM32: + return sizeof(INT); default: FIXME("Unhandled base type: 0x%02x\n", *pFormat); return 0;

1 0

Jason Edmeades : user32: Ensure VK_UP displays the popup menu for the selected item if
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: 24dc3de4c952b1205c637d0a165a04ae389ed0f2 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=24dc3de4c952b1205c637d0… Author: Jason Edmeades <us(a)edmeades.me.uk> Date: Wed Mar 1 12:39:09 2006 +0100 user32: Ensure VK_UP displays the popup menu for the selected item if the popup menu is not visible --- dlls/user/menu.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/user/menu.c b/dlls/user/menu.c index a72e922..e2c6318 100644 --- a/dlls/user/menu.c +++ b/dlls/user/menu.c @@ -3053,19 +3053,19 @@ static BOOL MENU_TrackMenu( HMENU hmenu, case VK_END: MENU_SelectItem( mt.hOwnerWnd, mt.hCurrentMenu, NO_SELECTED_ITEM, FALSE, 0 ); - /* fall through */ - case VK_UP: MENU_MoveSelection( mt.hOwnerWnd, mt.hCurrentMenu, (msg.wParam == VK_HOME)? ITEM_NEXT : ITEM_PREV ); break; + case VK_UP: case VK_DOWN: /* If on menu bar, pull-down the menu */ menu = MENU_GetMenu( mt.hCurrentMenu ); if (!(menu->wFlags & MF_POPUP)) mt.hCurrentMenu = MENU_ShowSubPopup(mt.hOwnerWnd, mt.hTopMenu, TRUE, wFlags); else /* otherwise try to move selection */ - MENU_MoveSelection( mt.hOwnerWnd, mt.hCurrentMenu, ITEM_NEXT ); + MENU_MoveSelection( mt.hOwnerWnd, mt.hCurrentMenu, + (msg.wParam == VK_UP)? ITEM_PREV : ITEM_NEXT ); break; case VK_LEFT:

1 0

Jon Parshall : shell32: New icons for Desktop and My Computer.
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: b84c9d41e4a16d5f3bb4c466e80c5011f82cc95d URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=b84c9d41e4a16d5f3bb4c46… Author: Jon Parshall <jparshall(a)codeweavers.com> Date: Wed Mar 1 14:08:45 2006 +0800 shell32: New icons for Desktop and My Computer. --- dlls/shell32/shres.rc | 482 +++++++++++++++++++++++++++++++++++++------------ 1 files changed, 361 insertions(+), 121 deletions(-) Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=b84c9d41e4a16d5f3bb…

1 0

Marcus Meissner : PACKAGING: Mention more libraries / tools in the needed dependencies section.
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: ec2cb1871cdf15ba13515eeef31480a0fbcf81c3 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ec2cb1871cdf15ba13515ee… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed Mar 1 07:10:34 2006 +0100 PACKAGING: Mention more libraries / tools in the needed dependencies section. --- documentation/PACKAGING | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/documentation/PACKAGING b/documentation/PACKAGING index 9a34630..dd04422 100644 --- a/documentation/PACKAGING +++ b/documentation/PACKAGING @@ -64,6 +64,9 @@ they should appear as "Suggests" or "Rec better support of fonts than using the X11 fonts engine. It is only needed for the X11 back end engine. Used from GDI. + * fontforge: http://sourceforge.net/projects/fontforge/ + Used by WINE to create our own set of TrueType fonts during build. + * fontconfig Used to find TrueType fonts for rendering with freetype. Used by GDI. @@ -119,6 +122,15 @@ they should appear as "Suggests" or "Rec Xi - X Input handling (for asian input methods mostly) Xext - X extensions + * libxml2, libxslt + These two libraries are used for our msxml3.dll implementation. + + * prelink + Used during build to locate WINE at a specific virtual address. + + * capi4linux + Used to implement our capi2032.dll. + GOALS ~~~~~

1 0

Gerald Pfeifer : README: Fix spelling Red Hat. Remove unneeded references to Debian
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: 2d979b6a893e0d3a918d801b25bcf010e4fcbe35 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=2d979b6a893e0d3a918d801… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Tue Feb 28 23:19:19 2006 +0100 README: Fix spelling Red Hat. Remove unneeded references to Debian and Red Hat. Document the use of libxml2 as a weak prerequisite. --- README | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 3468646..029f592 100644 --- a/README +++ b/README @@ -70,7 +70,7 @@ Supported file systems: Basic requirements: You need to have the X11 development include files installed - (called xlib6g-dev in Debian and XFree86-devel in RedHat). + (called xlib6g-dev in Debian and XFree86-devel in Red Hat). Build tool requirements: On x86 Systems gcc >= 2.7.2 is required. @@ -81,12 +81,12 @@ Build tool requirements: Of course you also need "make" (most likely GNU make). - You also need flex version 2.5 or later and bison. If you are - using RedHat or Debian, install the flex and bison packages. + You also need flex version 2.5 or later and bison. Optional support libraries: If you want CUPS printing support, please install both cups and cups-devel packages. + Install the libxml2 package to get a functional msxml implementation. 4. COMPILATION

1 0

Mike McCormack : server: Print a message if wineserver crashes and we don' t dump cores.
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: 0cd0626de019c8ca288ed8a61a053c0f485c5c5c URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=0cd0626de019c8ca288ed8a… Author: Mike McCormack <mike(a)codeweavers.com> Date: Wed Mar 1 01:07:04 2006 +0900 server: Print a message if wineserver crashes and we don't dump cores. --- configure | 2 ++ configure.ac | 1 + include/config.h.in | 3 +++ server/signal.c | 26 ++++++++++++++++++++++++++ 4 files changed, 32 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 392808f..9e163c8 100755 --- a/configure +++ b/configure @@ -7038,6 +7038,7 @@ done + for ac_header in \ IOKit/IOKitLib.h \ alsa/asoundlib.h \ @@ -7119,6 +7120,7 @@ for ac_header in \ sys/poll.h \ sys/ptrace.h \ sys/reg.h \ + sys/resource.h \ sys/scsiio.h \ sys/shm.h \ sys/signal.h \ diff --git a/configure.ac b/configure.ac index e88d337..f2f910d 100644 --- a/configure.ac +++ b/configure.ac @@ -252,6 +252,7 @@ AC_CHECK_HEADERS(\ sys/poll.h \ sys/ptrace.h \ sys/reg.h \ + sys/resource.h \ sys/scsiio.h \ sys/shm.h \ sys/signal.h \ diff --git a/include/config.h.in b/include/config.h.in index 18f1127..d2c9f3b 100644 --- a/include/config.h.in +++ b/include/config.h.in @@ -734,6 +734,9 @@ /* Define to 1 if you have the <sys/reg.h> header file. */ #undef HAVE_SYS_REG_H +/* Define to 1 if you have the <sys/resource.h> header file. */ +#undef HAVE_SYS_RESOURCE_H + /* Define to 1 if you have the <sys/scsiio.h> header file. */ #undef HAVE_SYS_SCSIIO_H diff --git a/server/signal.c b/server/signal.c index 0c2a579..e12532e 100644 --- a/server/signal.c +++ b/server/signal.c @@ -28,6 +28,9 @@ #ifdef HAVE_SYS_POLL_H #include <sys/poll.h> #endif +#ifdef HAVE_SYS_RESOURCE_H +#include <sys/resource.h> +#endif #include <unistd.h> #include "file.h" @@ -215,6 +218,13 @@ static void do_sigchld( int signum ) do_signal( handler_sigchld ); } +/* SIGSEGV handler */ +static void do_sigsegv( int signum ) +{ + fprintf( stderr, "wineserver crashed, please report this.\n"); + abort(); +} + /* SIGIO handler */ #ifdef HAVE_SIGINFO_T_SI_FD static void do_sigio( int signum, siginfo_t *si, void *x ) @@ -241,6 +251,17 @@ int watchdog_triggered(void) return watchdog != 0; } +static int core_dump_disabled( void ) +{ + int r = 0; +#ifdef RLIMIT_CORE + struct rlimit lim; + + r = !getrlimit(RLIMIT_CORE, &lim) && (lim.rlim_cur == 0); +#endif + return r; +} + void init_signals(void) { struct sigaction action; @@ -279,6 +300,11 @@ void init_signals(void) action.sa_handler = do_sigterm; sigaction( SIGQUIT, &action, NULL ); sigaction( SIGTERM, &action, NULL ); + if (core_dump_disabled()) + { + action.sa_handler = do_sigsegv; + sigaction( SIGSEGV, &action, NULL ); + } action.sa_handler = SIG_IGN; sigaction( SIGXFSZ, &action, NULL ); #ifdef HAVE_SIGINFO_T_SI_FD

1 0

Vitaliy Margolen : x11drv: Convert 24-bit into 32-bit color before looking for an
by Alexandre Julliard March 1, 2006

March 1, 2006

Module: wine Branch: refs/heads/master Commit: 20a886164f8368af6c47d8891703ff83b6049b29 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=20a886164f8368af6c47d88… Author: Vitaliy Margolen <wine-patch(a)kievinfo.com> Date: Sat Feb 25 23:15:44 2006 -0700 x11drv: Convert 24-bit into 32-bit color before looking for an available screen resolution. We do this during enumeration, so there would be no 24-bit modes available. --- dlls/x11drv/settings.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/x11drv/settings.c b/dlls/x11drv/settings.c index 5e3665f..5187b8b 100644 --- a/dlls/x11drv/settings.c +++ b/dlls/x11drv/settings.c @@ -237,7 +237,7 @@ static const char * _DM_fields(DWORD fie LONG X11DRV_ChangeDisplaySettingsEx( LPCWSTR devname, LPDEVMODEW devmode, HWND hwnd, DWORD flags, LPVOID lpvoid ) { - DWORD i; + DWORD i, dwBpp; DEVMODEW dm; TRACE("(%s,%p,%p,0x%08lx,%p)\n",debugstr_w(devname),devmode,hwnd,flags,lpvoid); @@ -259,12 +259,13 @@ LONG X11DRV_ChangeDisplaySettingsEx( LPC } devmode = &dm; } + dwBpp = (devmode->dmBitsPerPel == 24) ? 32 : devmode->dmBitsPerPel; for (i = 0; i < dd_mode_count; i++) { if (devmode->dmFields & DM_BITSPERPEL) { - if (devmode->dmBitsPerPel != dd_modes[i].dwBPP) + if (dwBpp != dd_modes[i].dwBPP) continue; } if (devmode->dmFields & DM_PELSWIDTH)

1 0