June 2006 - Wine-Commits - list.winehq.org

Juan Lang : crypt32: Add name value tests.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: 9879a47f9dc00ba74486b1d6935aed5034d36288 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=9879a47f9dc00ba74486b1d… Author: Juan Lang <juan_lang(a)yahoo.com> Date: Fri Jun 2 07:02:27 2006 -0700 crypt32: Add name value tests. Add tests for name values, and move tests for different string encodings to there. --- dlls/crypt32/tests/encode.c | 212 ++++++++++++++++++++++--------------------- 1 files changed, 109 insertions(+), 103 deletions(-) Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=9879a47f9dc00ba7448…

1 0

Juan Lang : crypt32: Remove exception handling from internal decoding functions.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: a7f6a0128c141eb2c4970be531160e6b8acdcb47 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=a7f6a0128c141eb2c4970be… Author: Juan Lang <juan_lang(a)yahoo.com> Date: Thu Jun 1 21:23:26 2006 -0700 crypt32: Remove exception handling from internal decoding functions. --- dlls/crypt32/decode.c | 176 ++++++++++++++++++++----------------------------- 1 files changed, 73 insertions(+), 103 deletions(-) diff --git a/dlls/crypt32/decode.c b/dlls/crypt32/decode.c index e6e2423..d2be521 100644 --- a/dlls/crypt32/decode.c +++ b/dlls/crypt32/decode.c @@ -1187,98 +1187,88 @@ static BOOL WINAPI CRYPT_AsnDecodeNameVa PCRYPT_DECODE_PARA pDecodePara, void *pvStructInfo, DWORD *pcbStructInfo) { BOOL ret = TRUE; + DWORD dataLen; + CERT_NAME_VALUE *value = (CERT_NAME_VALUE *)pvStructInfo; - __TRY + if ((ret = CRYPT_GetLen(pbEncoded, cbEncoded, &dataLen))) { - DWORD dataLen; - CERT_NAME_VALUE *value = (CERT_NAME_VALUE *)pvStructInfo; + BYTE lenBytes = GET_LEN_BYTES(pbEncoded[1]); - if ((ret = CRYPT_GetLen(pbEncoded, cbEncoded, &dataLen))) + switch (pbEncoded[0]) { - BYTE lenBytes = GET_LEN_BYTES(pbEncoded[1]); + case ASN_NUMERICSTRING: + case ASN_PRINTABLESTRING: + case ASN_IA5STRING: + break; + default: + FIXME("Unimplemented string type %02x\n", pbEncoded[0]); + SetLastError(OSS_UNIMPLEMENTED); + ret = FALSE; + } + if (ret) + { + DWORD bytesNeeded = sizeof(CERT_NAME_VALUE); switch (pbEncoded[0]) { case ASN_NUMERICSTRING: case ASN_PRINTABLESTRING: case ASN_IA5STRING: + if (!(dwFlags & CRYPT_DECODE_NOCOPY_FLAG)) + bytesNeeded += dataLen; break; - default: - FIXME("Unimplemented string type %02x\n", pbEncoded[0]); - SetLastError(OSS_UNIMPLEMENTED); + } + if (!value) + *pcbStructInfo = bytesNeeded; + else if (*pcbStructInfo < bytesNeeded) + { + *pcbStructInfo = bytesNeeded; + SetLastError(ERROR_MORE_DATA); ret = FALSE; } - if (ret) + else { - DWORD bytesNeeded = sizeof(CERT_NAME_VALUE); - + *pcbStructInfo = bytesNeeded; switch (pbEncoded[0]) { case ASN_NUMERICSTRING: + value->dwValueType = CERT_RDN_NUMERIC_STRING; + break; case ASN_PRINTABLESTRING: + value->dwValueType = CERT_RDN_PRINTABLE_STRING; + break; case ASN_IA5STRING: - if (!(dwFlags & CRYPT_DECODE_NOCOPY_FLAG)) - bytesNeeded += dataLen; + value->dwValueType = CERT_RDN_IA5_STRING; break; } - if (!value) - *pcbStructInfo = bytesNeeded; - else if (*pcbStructInfo < bytesNeeded) - { - *pcbStructInfo = bytesNeeded; - SetLastError(ERROR_MORE_DATA); - ret = FALSE; - } - else + if (dataLen) { - *pcbStructInfo = bytesNeeded; switch (pbEncoded[0]) { case ASN_NUMERICSTRING: - value->dwValueType = CERT_RDN_NUMERIC_STRING; - break; case ASN_PRINTABLESTRING: - value->dwValueType = CERT_RDN_PRINTABLE_STRING; - break; case ASN_IA5STRING: - value->dwValueType = CERT_RDN_IA5_STRING; - break; - } - if (dataLen) - { - switch (pbEncoded[0]) + value->Value.cbData = dataLen; + if (dwFlags & CRYPT_DECODE_NOCOPY_FLAG) + value->Value.pbData = (BYTE *)pbEncoded + 1 + + lenBytes; + else { - case ASN_NUMERICSTRING: - case ASN_PRINTABLESTRING: - case ASN_IA5STRING: - value->Value.cbData = dataLen; - if (dwFlags & CRYPT_DECODE_NOCOPY_FLAG) - value->Value.pbData = (BYTE *)pbEncoded + 1 + - lenBytes; - else - { - assert(value->Value.pbData); - memcpy(value->Value.pbData, - pbEncoded + 1 + lenBytes, dataLen); - } - break; + assert(value->Value.pbData); + memcpy(value->Value.pbData, + pbEncoded + 1 + lenBytes, dataLen); } + break; } - else - { - value->Value.cbData = 0; - value->Value.pbData = NULL; - } + } + else + { + value->Value.cbData = 0; + value->Value.pbData = NULL; } } } } - __EXCEPT_PAGE_FAULT - { - SetLastError(STATUS_ACCESS_VIOLATION); - ret = FALSE; - } - __ENDTRY return ret; } @@ -1287,41 +1277,31 @@ static BOOL WINAPI CRYPT_AsnDecodeRdnAtt PCRYPT_DECODE_PARA pDecodePara, void *pvStructInfo, DWORD *pcbStructInfo) { BOOL ret; + struct AsnDecodeSequenceItem items[] = { + { ASN_OBJECTIDENTIFIER, offsetof(CERT_RDN_ATTR, pszObjId), + CRYPT_AsnDecodeOidInternal, sizeof(LPSTR), FALSE, TRUE, + offsetof(CERT_RDN_ATTR, pszObjId), 0 }, + { 0, offsetof(CERT_RDN_ATTR, dwValueType), + CRYPT_AsnDecodeNameValue, sizeof(CERT_NAME_VALUE), + FALSE, TRUE, offsetof(CERT_RDN_ATTR, Value.pbData), 0 }, + }; + CERT_RDN_ATTR *attr = (CERT_RDN_ATTR *)pvStructInfo; TRACE("%p, %ld, %08lx, %p, %ld\n", pbEncoded, cbEncoded, dwFlags, pvStructInfo, *pcbStructInfo); - __TRY - { - struct AsnDecodeSequenceItem items[] = { - { ASN_OBJECTIDENTIFIER, offsetof(CERT_RDN_ATTR, pszObjId), - CRYPT_AsnDecodeOidInternal, sizeof(LPSTR), FALSE, TRUE, - offsetof(CERT_RDN_ATTR, pszObjId), 0 }, - { 0, offsetof(CERT_RDN_ATTR, dwValueType), CRYPT_AsnDecodeNameValue, - sizeof(CERT_NAME_VALUE), FALSE, TRUE, offsetof(CERT_RDN_ATTR, - Value.pbData), 0 }, - }; - CERT_RDN_ATTR *attr = (CERT_RDN_ATTR *)pvStructInfo; - - if (attr) - TRACE("attr->pszObjId is %p\n", attr->pszObjId); - ret = CRYPT_AsnDecodeSequence(X509_ASN_ENCODING, items, - sizeof(items) / sizeof(items[0]), pbEncoded, cbEncoded, dwFlags, NULL, - attr, pcbStructInfo, attr ? attr->pszObjId : NULL); - if (attr) - { - TRACE("attr->pszObjId is %p (%s)\n", attr->pszObjId, - debugstr_a(attr->pszObjId)); - TRACE("attr->dwValueType is %ld\n", attr->dwValueType); - } - TRACE("returning %d (%08lx)\n", ret, GetLastError()); - } - __EXCEPT_PAGE_FAULT + if (attr) + TRACE("attr->pszObjId is %p\n", attr->pszObjId); + ret = CRYPT_AsnDecodeSequence(X509_ASN_ENCODING, items, + sizeof(items) / sizeof(items[0]), pbEncoded, cbEncoded, dwFlags, NULL, + attr, pcbStructInfo, attr ? attr->pszObjId : NULL); + if (attr) { - SetLastError(STATUS_ACCESS_VIOLATION); - ret = FALSE; + TRACE("attr->pszObjId is %p (%s)\n", attr->pszObjId, + debugstr_a(attr->pszObjId)); + TRACE("attr->dwValueType is %ld\n", attr->dwValueType); } - __ENDTRY + TRACE("returning %d (%08lx)\n", ret, GetLastError()); return ret; } @@ -1330,23 +1310,13 @@ static BOOL WINAPI CRYPT_AsnDecodeRdn(DW PCRYPT_DECODE_PARA pDecodePara, void *pvStructInfo, DWORD *pcbStructInfo) { BOOL ret = TRUE; + struct AsnArrayDescriptor arrayDesc = { ASN_CONSTRUCTOR | ASN_SETOF, + CRYPT_AsnDecodeRdnAttr, sizeof(CERT_RDN_ATTR), TRUE, + offsetof(CERT_RDN_ATTR, pszObjId) }; + PCERT_RDN rdn = (PCERT_RDN)pvStructInfo; - __TRY - { - struct AsnArrayDescriptor arrayDesc = { ASN_CONSTRUCTOR | ASN_SETOF, - CRYPT_AsnDecodeRdnAttr, sizeof(CERT_RDN_ATTR), TRUE, - offsetof(CERT_RDN_ATTR, pszObjId) }; - PCERT_RDN rdn = (PCERT_RDN)pvStructInfo; - - ret = CRYPT_AsnDecodeArray(&arrayDesc, pbEncoded, cbEncoded, dwFlags, - pDecodePara, pvStructInfo, pcbStructInfo, rdn ? rdn->rgRDNAttr : NULL); - } - __EXCEPT_PAGE_FAULT - { - SetLastError(STATUS_ACCESS_VIOLATION); - ret = FALSE; - } - __ENDTRY + ret = CRYPT_AsnDecodeArray(&arrayDesc, pbEncoded, cbEncoded, dwFlags, + pDecodePara, pvStructInfo, pcbStructInfo, rdn ? rdn->rgRDNAttr : NULL); return ret; }

1 0

Juan Lang : crypt32: Add a couple CRL encoding tests, one that shows a problem.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: 6d668d9d382c80c85c079abfef221528adda11c3 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=6d668d9d382c80c85c079ab… Author: Juan Lang <juan_lang(a)yahoo.com> Date: Thu Jun 1 20:07:52 2006 -0700 crypt32: Add a couple CRL encoding tests, one that shows a problem. --- dlls/crypt32/tests/encode.c | 111 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 110 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c index 78d9052..3be938a 100644 --- a/dlls/crypt32/tests/encode.c +++ b/dlls/crypt32/tests/encode.c @@ -2641,6 +2641,15 @@ static const BYTE v1CRLWithExt[] = { 0x3 0x30, 0x31, 0x30, 0x31, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, 0x5a, 0x30, 0x14, 0x30, 0x12, 0x06, 0x03, 0x55, 0x1d, 0x13, 0x01, 0x01, 0xff, 0x04, 0x08, 0x30, 0x06, 0x01, 0x01, 0xff, 0x02, 0x01, 0x01 }; +static const BYTE v2CRLWithExt[] = { 0x30, 0x5a, 0x02, 0x01, 0x01, 0x30, 0x02, + 0x06, 0x00, 0x30, 0x15, 0x31, 0x13, 0x30, 0x11, 0x06, 0x03, 0x55, 0x04, 0x03, + 0x13, 0x0a, 0x4a, 0x75, 0x61, 0x6e, 0x20, 0x4c, 0x61, 0x6e, 0x67, 0x00, 0x18, + 0x0f, 0x31, 0x36, 0x30, 0x31, 0x30, 0x31, 0x30, 0x31, 0x30, 0x30, 0x30, 0x30, + 0x30, 0x30, 0x5a, 0x30, 0x29, 0x30, 0x27, 0x02, 0x01, 0x01, 0x18, 0x0f, 0x31, + 0x36, 0x30, 0x31, 0x30, 0x31, 0x30, 0x31, 0x30, 0x30, 0x30, 0x30, 0x30, 0x30, + 0x5a, 0x30, 0x11, 0x30, 0x0f, 0x06, 0x03, 0x55, 0x1d, 0x13, 0x04, 0x08, 0x30, + 0x06, 0x01, 0x01, 0xff, 0x02, 0x01, 0x01 }; + static void test_encodeCRLToBeSigned(DWORD dwEncoding) { @@ -2719,7 +2728,7 @@ static void test_encodeCRLToBeSigned(DWO "Got unexpected value\n"); LocalFree(buf); } - /* and finally, an entry with an extension */ + /* an entry with an extension */ entry.cExtension = 1; entry.rgExtension = &criticalExt; ret = CryptEncodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, &info, @@ -2732,8 +2741,57 @@ static void test_encodeCRLToBeSigned(DWO ok(!memcmp(buf, v1CRLWithExt, size), "Got unexpected value\n"); LocalFree(buf); } + /* a v2 CRL with an extension, this time non-critical */ + info.dwVersion = CRL_V2; + entry.rgExtension = &nonCriticalExt; + ret = CryptEncodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, &info, + CRYPT_ENCODE_ALLOC_FLAG, NULL, (BYTE *)&buf, &size); + ok(ret, "CryptEncodeObjectEx failed: %08lx\n", GetLastError()); + if (buf) + { + ok(size == sizeof(v2CRLWithExt), "Expected size %d, got %ld\n", + sizeof(v2CRLWithExt), size); + ok(!memcmp(buf, v2CRLWithExt, size), "Got unexpected value\n"); + LocalFree(buf); + } } +static const BYTE verisignCRL[] = { 0x30, 0x82, 0x01, 0xb1, 0x30, 0x82, 0x01, + 0x1a, 0x02, 0x01, 0x01, 0x30, 0x0d, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7, + 0x0d, 0x01, 0x01, 0x02, 0x05, 0x00, 0x30, 0x61, 0x31, 0x11, 0x30, 0x0f, 0x06, + 0x03, 0x55, 0x04, 0x07, 0x13, 0x08, 0x49, 0x6e, 0x74, 0x65, 0x72, 0x6e, 0x65, + 0x74, 0x31, 0x17, 0x30, 0x15, 0x06, 0x03, 0x55, 0x04, 0x0a, 0x13, 0x0e, 0x56, + 0x65, 0x72, 0x69, 0x53, 0x69, 0x67, 0x6e, 0x2c, 0x20, 0x49, 0x6e, 0x63, 0x2e, + 0x31, 0x33, 0x30, 0x31, 0x06, 0x03, 0x55, 0x04, 0x0b, 0x13, 0x2a, 0x56, 0x65, + 0x72, 0x69, 0x53, 0x69, 0x67, 0x6e, 0x20, 0x43, 0x6f, 0x6d, 0x6d, 0x65, 0x72, + 0x63, 0x69, 0x61, 0x6c, 0x20, 0x53, 0x6f, 0x66, 0x74, 0x77, 0x61, 0x72, 0x65, + 0x20, 0x50, 0x75, 0x62, 0x6c, 0x69, 0x73, 0x68, 0x65, 0x72, 0x73, 0x20, 0x43, + 0x41, 0x17, 0x0d, 0x30, 0x31, 0x30, 0x33, 0x32, 0x34, 0x30, 0x30, 0x30, 0x30, + 0x30, 0x30, 0x5a, 0x17, 0x0d, 0x30, 0x34, 0x30, 0x31, 0x30, 0x37, 0x32, 0x33, + 0x35, 0x39, 0x35, 0x39, 0x5a, 0x30, 0x69, 0x30, 0x21, 0x02, 0x10, 0x1b, 0x51, + 0x90, 0xf7, 0x37, 0x24, 0x39, 0x9c, 0x92, 0x54, 0xcd, 0x42, 0x46, 0x37, 0x99, + 0x6a, 0x17, 0x0d, 0x30, 0x31, 0x30, 0x31, 0x33, 0x30, 0x30, 0x30, 0x30, 0x31, + 0x32, 0x34, 0x5a, 0x30, 0x21, 0x02, 0x10, 0x75, 0x0e, 0x40, 0xff, 0x97, 0xf0, + 0x47, 0xed, 0xf5, 0x56, 0xc7, 0x08, 0x4e, 0xb1, 0xab, 0xfd, 0x17, 0x0d, 0x30, + 0x31, 0x30, 0x31, 0x33, 0x31, 0x30, 0x30, 0x30, 0x30, 0x34, 0x39, 0x5a, 0x30, + 0x21, 0x02, 0x10, 0x77, 0xe6, 0x5a, 0x43, 0x59, 0x93, 0x5d, 0x5f, 0x7a, 0x75, + 0x80, 0x1a, 0xcd, 0xad, 0xc2, 0x22, 0x17, 0x0d, 0x30, 0x30, 0x30, 0x38, 0x33, + 0x31, 0x30, 0x30, 0x30, 0x30, 0x35, 0x36, 0x5a, 0xa0, 0x1a, 0x30, 0x18, 0x30, + 0x09, 0x06, 0x03, 0x55, 0x1d, 0x13, 0x04, 0x02, 0x30, 0x00, 0x30, 0x0b, 0x06, + 0x03, 0x55, 0x1d, 0x0f, 0x04, 0x04, 0x03, 0x02, 0x05, 0xa0, 0x30, 0x0d, 0x06, + 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d, 0x01, 0x01, 0x02, 0x05, 0x00, 0x03, + 0x81, 0x81, 0x00, 0x18, 0x2c, 0xe8, 0xfc, 0x16, 0x6d, 0x91, 0x4a, 0x3d, 0x88, + 0x54, 0x48, 0x5d, 0xb8, 0x11, 0xbf, 0x64, 0xbb, 0xf9, 0xda, 0x59, 0x19, 0xdd, + 0x0e, 0x65, 0xab, 0xc0, 0x0c, 0xfa, 0x67, 0x7e, 0x21, 0x1e, 0x83, 0x0e, 0xcf, + 0x9b, 0x89, 0x8a, 0xcf, 0x0c, 0x4b, 0xc1, 0x39, 0x9d, 0xe7, 0x6a, 0xac, 0x46, + 0x74, 0x6a, 0x91, 0x62, 0x22, 0x0d, 0xc4, 0x08, 0xbd, 0xf5, 0x0a, 0x90, 0x7f, + 0x06, 0x21, 0x3d, 0x7e, 0xa7, 0xaa, 0x5e, 0xcd, 0x22, 0x15, 0xe6, 0x0c, 0x75, + 0x8e, 0x6e, 0xad, 0xf1, 0x84, 0xe4, 0x22, 0xb4, 0x30, 0x6f, 0xfb, 0x64, 0x8f, + 0xd7, 0x80, 0x43, 0xf5, 0x19, 0x18, 0x66, 0x1d, 0x72, 0xa3, 0xe3, 0x94, 0x82, + 0x28, 0x52, 0xa0, 0x06, 0x4e, 0xb1, 0xc8, 0x92, 0x0c, 0x97, 0xbe, 0x15, 0x07, + 0xab, 0x7a, 0xc9, 0xea, 0x08, 0x67, 0x43, 0x4d, 0x51, 0x63, 0x3b, 0x9c, 0x9c, + 0xcd }; + static void test_decodeCRLToBeSigned(DWORD dwEncoding) { static const BYTE *corruptCRLs[] = { v1CRL, v2CRL }; @@ -2803,6 +2861,25 @@ static void test_decodeCRLToBeSigned(DWO ok(!memcmp(info->Issuer.pbData, encodedCommonName, info->Issuer.cbData), "Unexpected issuer\n"); } + /* a real CRL from verisign that has extensions */ + ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, + verisignCRL, sizeof(verisignCRL), CRYPT_DECODE_ALLOC_FLAG, + NULL, (BYTE *)&buf, &size); + todo_wine ok(ret, "CryptDecodeObjectEx failed: %08lx\n", GetLastError()); + if (buf) + { + CRL_INFO *info = (CRL_INFO *)buf; + CRL_ENTRY *entry; + + ok(size >= sizeof(CRL_INFO), "Expected size at least %d, got %ld\n", + sizeof(CRL_INFO), size); + ok(info->cCRLEntry == 3, "Expected 3 CRL entries, got %ld\n", + info->cCRLEntry); + ok(info->rgCRLEntry != NULL, "Expected a valid CRL entry array\n"); + entry = info->rgCRLEntry; + ok(info->cExtension == 2, "Expected 2 extensions, got %ld\n", + info->cExtension); + } /* and finally, with an extension */ ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, v1CRLWithExt, sizeof(v1CRLWithExt), CRYPT_DECODE_ALLOC_FLAG, @@ -2836,6 +2913,38 @@ static void test_decodeCRLToBeSigned(DWO ok(info->cExtension == 0, "Expected 0 extensions, got %ld\n", info->cExtension); } + ret = CryptDecodeObjectEx(dwEncoding, X509_CERT_CRL_TO_BE_SIGNED, + v2CRLWithExt, sizeof(v2CRLWithExt), CRYPT_DECODE_ALLOC_FLAG, + NULL, (BYTE *)&buf, &size); + if (buf) + { + CRL_INFO *info = (CRL_INFO *)buf; + CRL_ENTRY *entry; + + ok(size >= sizeof(CRL_INFO), "Expected size at least %d, got %ld\n", + sizeof(CRL_INFO), size); + ok(info->cCRLEntry == 1, "Expected 1 CRL entries, got %ld\n", + info->cCRLEntry); + ok(info->rgCRLEntry != NULL, "Expected a valid CRL entry array\n"); + entry = info->rgCRLEntry; + ok(entry->SerialNumber.cbData == 1, + "Expected serial number size 1, got %ld\n", + entry->SerialNumber.cbData); + ok(*entry->SerialNumber.pbData == *serialNum, + "Expected serial number %d, got %d\n", *serialNum, + *entry->SerialNumber.pbData); + ok(info->Issuer.cbData == sizeof(encodedCommonName), + "Expected issuer of %d bytes, got %ld\n", sizeof(encodedCommonName), + info->Issuer.cbData); + ok(!memcmp(info->Issuer.pbData, encodedCommonName, info->Issuer.cbData), + "Unexpected issuer\n"); + /* Oddly, the extensions don't seem to be decoded. Is this just an MS + * bug, or am I missing something? + */ + ok(info->cExtension == 0, "Expected 0 extensions, got %ld\n", + info->cExtension); + LocalFree(buf); + } } static const LPCSTR keyUsages[] = { szOID_PKIX_KP_CODE_SIGNING,

1 0

qingdoa daoo : user32: Fix selection handling for listboxes with LBS_EXTENDEDSEL style.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: 7c34bfab20443a2cc6a0f12e7f618bd1816dbb69 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=7c34bfab20443a2cc6a0f12… Author: qingdoa daoo <qingdao33122(a)yahoo.com> Date: Fri Jun 2 09:02:42 2006 +0800 user32: Fix selection handling for listboxes with LBS_EXTENDEDSEL style. --- dlls/user/listbox.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/user/listbox.c b/dlls/user/listbox.c index cc87010..0b21a39 100644 --- a/dlls/user/listbox.c +++ b/dlls/user/listbox.c @@ -1387,7 +1387,7 @@ static LRESULT LISTBOX_SelectItemRange( if (!descr->nb_items) return LB_OKAY; - if (last >= descr->nb_items) last = descr->nb_items - 1; + if (last == -1 || last >= descr->nb_items) last = descr->nb_items - 1; if (first < 0) first = 0; if (last < first) return LB_OKAY;

1 0

Juris Smotrovs : user32: Send WM_SIZE when window changes state between restored/min/maximized.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: b8d9f3955a2104e629575b41f674ce625f771e60 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=b8d9f3955a2104e629575b4… Author: Juris Smotrovs <juris.smotrovs(a)sets.lv> Date: Thu May 25 15:26:04 2006 +0300 user32: Send WM_SIZE when window changes state between restored/min/maximized. --- dlls/user/defwnd.c | 2 +- dlls/user/tests/msg.c | 16 +++++++++++++--- dlls/x11drv/winpos.c | 3 +-- include/winpos.h | 1 + 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/dlls/user/defwnd.c b/dlls/user/defwnd.c index be71e75..da38c63 100644 --- a/dlls/user/defwnd.c +++ b/dlls/user/defwnd.c @@ -65,7 +65,7 @@ static void DEFWND_HandleWindowPosChange if (!(winpos->flags & SWP_NOCLIENTMOVE)) SendMessageW( hwnd, WM_MOVE, 0, MAKELONG(rect.left, rect.top)); - if (!(winpos->flags & SWP_NOCLIENTSIZE)) + if (!(winpos->flags & SWP_NOCLIENTSIZE) || (winpos->flags & SWP_STATECHANGED)) { WPARAM wp = SIZE_RESTORED; if (IsZoomed(hwnd)) wp = SIZE_MAXIMIZED; diff --git a/dlls/user/tests/msg.c b/dlls/user/tests/msg.c index c718a37..848e7d9 100644 --- a/dlls/user/tests/msg.c +++ b/dlls/user/tests/msg.c @@ -1435,9 +1435,19 @@ static void ok_sequence_(const struct me "%s: in msg 0x%04x expecting lParam 0x%lx got 0x%lx\n", context, expected->message, expected->lParam, actual->lParam); } - ok_( file, line) ((expected->flags & defwinproc) == (actual->flags & defwinproc), - "%s: the msg 0x%04x should %shave been sent by DefWindowProc\n", - context, expected->message, (expected->flags & defwinproc) ? "" : "NOT "); + if ((expected->flags & defwinproc) != (actual->flags & defwinproc) && todo) + { + todo_wine { + failcount ++; + ok_( file, line) (FALSE, + "%s: in msg 0x%04x expecting lParam 0x%lx got 0x%lx\n", + context, expected->message, expected->lParam, actual->lParam); + } + } + else + ok_( file, line) ((expected->flags & defwinproc) == (actual->flags & defwinproc), + "%s: the msg 0x%04x should %shave been sent by DefWindowProc\n", + context, expected->message, (expected->flags & defwinproc) ? "" : "NOT "); ok_( file, line) ((expected->flags & beginpaint) == (actual->flags & beginpaint), "%s: the msg 0x%04x should %shave been sent by BeginPaint\n", context, expected->message, (expected->flags & beginpaint) ? "" : "NOT "); diff --git a/dlls/x11drv/winpos.c b/dlls/x11drv/winpos.c index 64ffa8b..1da69d3 100644 --- a/dlls/x11drv/winpos.c +++ b/dlls/x11drv/winpos.c @@ -1031,9 +1031,8 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT c { /* it appears that Windows always adds an undocumented 0x8000 * flag if the state of a window changes. - * FIXME: real SWP_xxxx name? */ - swp |= 0x8000; + swp |= SWP_STATECHANGED; } } diff --git a/include/winpos.h b/include/winpos.h index 61b8b53..ea3008f 100644 --- a/include/winpos.h +++ b/include/winpos.h @@ -30,6 +30,7 @@ #include <winuser.h> /* undocumented SWP flags - from SDK 3.1 */ #define SWP_NOCLIENTSIZE 0x0800 #define SWP_NOCLIENTMOVE 0x1000 +#define SWP_STATECHANGED 0x8000 extern BOOL WINPOS_RedrawIconTitle( HWND hWnd ); extern BOOL WINPOS_ShowIconTitle( HWND hwnd, BOOL bShow );

1 0

Wino Rojo : x11drv: Fix for a BadMatch error.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: 7b6fbd28986c717e72d6a1a80939b3a82c50704a URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=7b6fbd28986c717e72d6a1a… Author: Wino Rojo <winorojo(a)hotmail.com> Date: Thu Jun 1 12:40:16 2006 -0400 x11drv: Fix for a BadMatch error. --- dlls/x11drv/opengl.c | 23 ++++++++++++++++------- 1 files changed, 16 insertions(+), 7 deletions(-) diff --git a/dlls/x11drv/opengl.c b/dlls/x11drv/opengl.c index 161bb79..bfd023e 100644 --- a/dlls/x11drv/opengl.c +++ b/dlls/x11drv/opengl.c @@ -554,24 +554,33 @@ XVisualInfo *X11DRV_setup_opengl_visual( { XVisualInfo *visual = NULL; /* In order to support OpenGL or D3D, we require a double-buffered visual and stencil buffer support, */ - int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; + int dblBuf[] = {GLX_RGBA,GLX_DEPTH_SIZE, 24, GLX_STENCIL_SIZE, 8, GLX_ALPHA_SIZE, 8, GLX_DOUBLEBUFFER, None}; if (!has_opengl()) return NULL; wine_tsx11_lock(); visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf); wine_tsx11_unlock(); if (visual == NULL) { - /* fallback to no stencil */ - int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; - WARN("Failed to get a visual with at least 8 bits of stencil\n"); + /* fallback to 16 bits depth, no alpha */ + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_STENCIL_SIZE, 8, GLX_DOUBLEBUFFER, None}; + WARN("Failed to get a visual with at least 24 bits depth\n"); wine_tsx11_lock(); visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf2); wine_tsx11_unlock(); if (visual == NULL) { - /* This should only happen if we cannot find a match with a depth size 16 */ - FIXME("Failed to find a suitable visual\n"); - return visual; + /* fallback to no stencil */ + int dblBuf2[] = {GLX_RGBA,GLX_DEPTH_SIZE, 16, GLX_DOUBLEBUFFER, None}; + WARN("Failed to get a visual with at least 8 bits of stencil\n"); + + wine_tsx11_lock(); + visual = pglXChooseVisual(display, DefaultScreen(display), dblBuf2); + wine_tsx11_unlock(); + if (visual == NULL) { + /* This should only happen if we cannot find a match with a depth size 16 */ + FIXME("Failed to find a suitable visual\n"); + return visual; + } } } TRACE("Visual ID %lx Chosen\n",visual->visualid);

1 0

Detlef Riekenberg : winspool/tests: Remove the check for unimplemented functions.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: 38eb9a71aed44b46804b56389bc7ab5b914449da URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=38eb9a71aed44b46804b563… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Fri Jun 2 00:35:47 2006 +0200 winspool/tests: Remove the check for unimplemented functions. --- dlls/winspool.drv/tests/info.c | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c index 09a1a16..57d301a 100644 --- a/dlls/winspool.drv/tests/info.c +++ b/dlls/winspool.drv/tests/info.c @@ -119,7 +119,6 @@ static struct monitor_entry * find_insta { MONITOR_INFO_2A mi2a; static struct monitor_entry * entry = NULL; - DWORD res; DWORD num_tests; DWORD i = 0; @@ -145,20 +144,6 @@ static struct monitor_entry * find_insta num_tests = (sizeof(monitor_table)/sizeof(struct monitor_entry)); - SetLastError(MAGIC_DEAD); - res = DeleteMonitorA(NULL, NULL, NULL); - if (!res && (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED)) { - trace("DeleteMonitorA() not implemented yet\n"); - return NULL; - } - - SetLastError(MAGIC_DEAD); - res = AddMonitorA(NULL, 0, NULL); - if (!res && (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED)) { - trace("AddMonitorA() not implemented yet\n"); - return NULL; - } - /* cleanup */ DeleteMonitorA(NULL, env_x86, winetest_monitor); DeleteMonitorA(NULL, env_win9x_case, winetest_monitor);

1 0

Detlef Riekenberg : winspool.drv: Add GetPrintProcessorDirectoryW.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: f0a62dd6337ff357d9a679153cc03a9ea6c4274f URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=f0a62dd6337ff357d9a6791… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Sun May 28 21:56:52 2006 +0200 winspool.drv: Add GetPrintProcessorDirectoryW. --- dlls/winspool.drv/info.c | 68 ++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 59 insertions(+), 9 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 12bc975..3214ca1 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -162,6 +162,7 @@ static const WCHAR Version3_RegPathW[] = static const WCHAR Version3_SubdirW[] = {'\\','3',0}; static const WCHAR spooldriversW[] = {'\\','s','p','o','o','l','\\','d','r','i','v','e','r','s','\\',0}; +static const WCHAR spoolprtprocsW[] = {'\\','s','p','o','o','l','\\','p','r','t','p','r','o','c','s','\\',0}; static const WCHAR Configuration_FileW[] = {'C','o','n','f','i','g','u','r','a','t', 'i','o','n',' ','F','i','l','e',0}; @@ -1854,15 +1855,15 @@ BOOL WINAPI GetPrintProcessorDirectoryA( * level [I] Structure-Level (must be 1) * Info [O] PTR to Buffer that receives the Result * cbBuf [I] Size of Buffer at "Info" - * needed [O] PTR to DWORD that receives the size in Bytes used / + * pcbNeeded [O] PTR to DWORD that receives the size in Bytes used / * required for the Buffer at "Info" * * RETURNS - * Success: TRUE and in pcbNeeded the Bytes used in pPrintProcessorInfo - * Failure: FALSE and in pcbNeeded the Bytes required for pPrintProcessorInfo, + * Success: TRUE and in pcbNeeded the Bytes used in Info + * Failure: FALSE and in pcbNeeded the Bytes required for Info, * if cbBuf is too small * - * Native Values returned in pPrintProcessorInfo on Success: + * Native Values returned in Info on Success: *| NT(Windows NT x86): "%winsysdir%\\spool\\PRTPROCS\\w32x86" *| NT(Windows 4.0): "%winsysdir%\\spool\\PRTPROCS\\win40" *| win9x(Windows 4.0): "%winsysdir%" @@ -1870,16 +1871,65 @@ BOOL WINAPI GetPrintProcessorDirectoryA( * "%winsysdir%" is the Value from GetSystemDirectoryW() * * BUGS - *- Only NULL or "" is supported for pName + * Only NULL or "" is supported for server * */ BOOL WINAPI GetPrintProcessorDirectoryW(LPWSTR server, LPWSTR env, DWORD level, LPBYTE Info, - DWORD cbBuf, LPDWORD needed) + DWORD cbBuf, LPDWORD pcbNeeded) { - FIXME("(%s,%s,%ld,%p,0x%08lx): stub\n", debugstr_w(server), debugstr_w(env), - level, Info, cbBuf); - return 0; + DWORD needed; + const printenv_t * env_t; + + TRACE("(%s, %s, %ld, %p, %ld, %p)\n", debugstr_w(server), + debugstr_w(env), level, Info, cbBuf, pcbNeeded); + + if(server != NULL && server[0]) { + FIXME("server not supported: %s\n", debugstr_w(server)); + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + env_t = validate_envW(env); + if(!env_t) return FALSE; /* environment invalid or unsupported */ + + if(level != 1) { + WARN("(Level: %ld) is ignored in win9x\n", level); + SetLastError(ERROR_INVALID_LEVEL); + return FALSE; + } + + /* GetSystemDirectoryW returns number of WCHAR including the '\0' */ + needed = GetSystemDirectoryW(NULL, 0); + /* add the Size for the Subdirectories */ + needed += lstrlenW(spoolprtprocsW); + needed += lstrlenW(env_t->subdir); + needed *= sizeof(WCHAR); /* return-value is size in Bytes */ + + if(pcbNeeded) *pcbNeeded = needed; + TRACE ("required: 0x%lx/%ld\n", needed, needed); + if (needed > cbBuf) { + SetLastError(ERROR_INSUFFICIENT_BUFFER); + return FALSE; + } + if(pcbNeeded == NULL) { + /* NT: RPC_X_NULL_REF_POINTER, 9x: ignored */ + WARN("(pcbNeeded == NULL) is ignored in win9x\n"); + SetLastError(RPC_X_NULL_REF_POINTER); + return FALSE; + } + if(Info == NULL) { + /* NT: RPC_X_NULL_REF_POINTER, 9x: ERROR_INVALID_PARAMETER */ + SetLastError(RPC_X_NULL_REF_POINTER); + return FALSE; + } + + GetSystemDirectoryW((LPWSTR) Info, cbBuf/sizeof(WCHAR)); + /* add the Subdirectories */ + lstrcatW((LPWSTR) Info, spoolprtprocsW); + lstrcatW((LPWSTR) Info, env_t->subdir); + TRACE(" => %s\n", debugstr_w((LPWSTR) Info)); + return TRUE; } /*****************************************************************************

1 0

Robert Shearman : rpcrt4: All of the parameters to TowerExplode are optional.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: efc974d1f57fe1da5fab3f55ac9eb80e233ff8ed URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=efc974d1f57fe1da5fab3f5… Author: Robert Shearman <rob(a)codeweavers.com> Date: Thu Jun 1 20:25:26 2006 +0100 rpcrt4: All of the parameters to TowerExplode are optional. --- dlls/rpcrt4/rpc_epmap.c | 11 +++-- dlls/rpcrt4/rpc_transport.c | 104 ++++++++++++++++++++++++------------------- dlls/rpcrt4/tests/rpc.c | 4 ++ 3 files changed, 70 insertions(+), 49 deletions(-) diff --git a/dlls/rpcrt4/rpc_epmap.c b/dlls/rpcrt4/rpc_epmap.c index ffd3907..b3c3237 100644 --- a/dlls/rpcrt4/rpc_epmap.c +++ b/dlls/rpcrt4/rpc_epmap.c @@ -265,9 +265,12 @@ RPC_STATUS WINAPI TowerExplode( const twr_uuid_floor_t *object_floor; const twr_uuid_floor_t *syntax_floor; - *protseq = NULL; - *endpoint = NULL; - *address = NULL; + if (protseq) + *protseq = NULL; + if (endpoint) + *endpoint = NULL; + if (address) + *address = NULL; tower_size = tower->tower_length; @@ -305,7 +308,7 @@ RPC_STATUS WINAPI TowerExplode( return EPT_S_NOT_REGISTERED; status = RpcTransport_ParseTopOfTower(p, tower_size, protseq, address, endpoint); - if (status == RPC_S_OK) + if ((status == RPC_S_OK) && syntax && object) { syntax->SyntaxGUID = syntax_floor->uuid; syntax->SyntaxVersion.MajorVersion = syntax_floor->major_version; diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index bcf7112..915f59a 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -308,9 +308,6 @@ static RPC_STATUS rpcrt4_ncacn_np_parse_ TRACE("(%p, %d, %p, %p)\n", tower_data, tower_size, networkaddr, endpoint); - *networkaddr = NULL; - *endpoint = NULL; - if (tower_size < sizeof(*smb_floor)) return EPT_S_NOT_REGISTERED; @@ -321,11 +318,14 @@ static RPC_STATUS rpcrt4_ncacn_np_parse_ (smb_floor->protid != EPM_PROTOCOL_SMB) || (smb_floor->count_rhs > tower_size)) return EPT_S_NOT_REGISTERED; - - *endpoint = HeapAlloc(GetProcessHeap(), 0, smb_floor->count_rhs); - if (!*endpoint) - return RPC_S_OUT_OF_RESOURCES; - memcpy(*endpoint, tower_data, smb_floor->count_rhs); + + if (endpoint) + { + *endpoint = HeapAlloc(GetProcessHeap(), 0, smb_floor->count_rhs); + if (!*endpoint) + return RPC_S_OUT_OF_RESOURCES; + memcpy(*endpoint, tower_data, smb_floor->count_rhs); + } tower_data += smb_floor->count_rhs; tower_size -= smb_floor->count_rhs; @@ -342,14 +342,20 @@ static RPC_STATUS rpcrt4_ncacn_np_parse_ (nb_floor->count_rhs > tower_size)) return EPT_S_NOT_REGISTERED; - *networkaddr = HeapAlloc(GetProcessHeap(), 0, nb_floor->count_rhs); - if (!*networkaddr) + if (networkaddr) { - HeapFree(GetProcessHeap(), 0, *endpoint); - *endpoint = NULL; - return RPC_S_OUT_OF_RESOURCES; + *networkaddr = HeapAlloc(GetProcessHeap(), 0, nb_floor->count_rhs); + if (!*networkaddr) + { + if (endpoint) + { + HeapFree(GetProcessHeap(), 0, *endpoint); + *endpoint = NULL; + } + return RPC_S_OUT_OF_RESOURCES; + } + memcpy(*networkaddr, tower_data, nb_floor->count_rhs); } - memcpy(*networkaddr, tower_data, nb_floor->count_rhs); return RPC_S_OK; } @@ -406,11 +412,14 @@ static RPC_STATUS rpcrt4_ncalrpc_parse_t (pipe_floor->protid != EPM_PROTOCOL_SMB) || (pipe_floor->count_rhs > tower_size)) return EPT_S_NOT_REGISTERED; - - *endpoint = HeapAlloc(GetProcessHeap(), 0, pipe_floor->count_rhs); - if (!*endpoint) - return RPC_S_OUT_OF_RESOURCES; - memcpy(*endpoint, tower_data, pipe_floor->count_rhs); + + if (endpoint) + { + *endpoint = HeapAlloc(GetProcessHeap(), 0, pipe_floor->count_rhs); + if (!*endpoint) + return RPC_S_OUT_OF_RESOURCES; + memcpy(*endpoint, tower_data, pipe_floor->count_rhs); + } return RPC_S_OK; } @@ -620,9 +629,6 @@ static RPC_STATUS rpcrt4_ncacn_ip_tcp_pa TRACE("(%p, %d, %p, %p)\n", tower_data, tower_size, networkaddr, endpoint); - *networkaddr = NULL; - *endpoint = NULL; - if (tower_size < sizeof(*tcp_floor)) return EPT_S_NOT_REGISTERED; @@ -642,27 +648,39 @@ static RPC_STATUS rpcrt4_ncacn_ip_tcp_pa (ipv4_floor->count_rhs != sizeof(ipv4_floor->ipv4addr))) return EPT_S_NOT_REGISTERED; - *endpoint = HeapAlloc(GetProcessHeap(), 0, 6); - if (!*endpoint) - return RPC_S_OUT_OF_RESOURCES; - sprintf(*endpoint, "%u", ntohs(tcp_floor->port)); - - *networkaddr = HeapAlloc(GetProcessHeap(), 0, INET_ADDRSTRLEN); - if (!*networkaddr) + if (endpoint) { - HeapFree(GetProcessHeap(), 0, *endpoint); - *endpoint = NULL; - return RPC_S_OUT_OF_RESOURCES; + *endpoint = HeapAlloc(GetProcessHeap(), 0, 6); + if (!*endpoint) + return RPC_S_OUT_OF_RESOURCES; + sprintf(*endpoint, "%u", ntohs(tcp_floor->port)); } - in_addr.s_addr = ipv4_floor->ipv4addr; - if (!inet_ntop(AF_INET, &in_addr, *networkaddr, INET_ADDRSTRLEN)) + + if (networkaddr) { - ERR("inet_ntop: %s\n", strerror(errno)); - HeapFree(GetProcessHeap(), 0, *endpoint); - HeapFree(GetProcessHeap(), 0, *networkaddr); - *networkaddr = NULL; - *endpoint = NULL; - return EPT_S_NOT_REGISTERED; + *networkaddr = HeapAlloc(GetProcessHeap(), 0, INET_ADDRSTRLEN); + if (!*networkaddr) + { + if (endpoint) + { + HeapFree(GetProcessHeap(), 0, *endpoint); + *endpoint = NULL; + } + return RPC_S_OUT_OF_RESOURCES; + } + in_addr.s_addr = ipv4_floor->ipv4addr; + if (!inet_ntop(AF_INET, &in_addr, *networkaddr, INET_ADDRSTRLEN)) + { + ERR("inet_ntop: %s\n", strerror(errno)); + HeapFree(GetProcessHeap(), 0, *networkaddr); + *networkaddr = NULL; + if (endpoint) + { + HeapFree(GetProcessHeap(), 0, *endpoint); + *endpoint = NULL; + } + return EPT_S_NOT_REGISTERED; + } } return RPC_S_OK; @@ -837,10 +855,6 @@ RPC_STATUS RpcTransport_ParseTopOfTower( RPC_STATUS status; int i; - *protseq = NULL; - *networkaddr = NULL; - *endpoint = NULL; - if (tower_size < sizeof(*protocol_floor)) return EPT_S_NOT_REGISTERED; @@ -869,7 +883,7 @@ RPC_STATUS RpcTransport_ParseTopOfTower( status = protseq_ops->parse_top_of_tower(tower_data, tower_size, networkaddr, endpoint); - if (status == RPC_S_OK) + if ((status == RPC_S_OK) && protseq) { *protseq = HeapAlloc(GetProcessHeap(), 0, strlen(protseq_ops->name) + 1); strcpy(*protseq, protseq_ops->name); diff --git a/dlls/rpcrt4/tests/rpc.c b/dlls/rpcrt4/tests/rpc.c index 7f678bd..03dc792 100644 --- a/dlls/rpcrt4/tests/rpc.c +++ b/dlls/rpcrt4/tests/rpc.c @@ -265,6 +265,10 @@ static void test_towers(void) I_RpcFree(protseq); I_RpcFree(endpoint); I_RpcFree(address); + + ret = TowerExplode(tower, NULL, NULL, NULL, NULL, NULL); + ok(ret == RPC_S_OK, "TowerExplode failed with error %ld\n", ret); + I_RpcFree(tower); }

1 0

Robert Shearman : rpcrt4: Implement TowerConstruct and TowerExplode.
by Alexandre Julliard June 2, 2006

June 2, 2006

Module: wine Branch: refs/heads/master Commit: e15e60b9f9d9263185bbf5fad67195a6c7a4ef29 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=e15e60b9f9d9263185bbf5f… Author: Robert Shearman <rob(a)codeweavers.com> Date: Thu Jun 1 20:25:15 2006 +0100 rpcrt4: Implement TowerConstruct and TowerExplode. Add some tests for these undocumented functions. --- dlls/rpcrt4/rpc_epmap.c | 129 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/rpcrt4/rpcrt4.spec | 4 + dlls/rpcrt4/tests/rpc.c | 94 ++++++++++++++++++++++++++++++++++ 3 files changed, 225 insertions(+), 2 deletions(-) Diff: http://source.winehq.org/git/?p=wine.git;a=commitdiff;h=e15e60b9f9d9263185b…

1 0