August 2006 - Wine-Commits - list.winehq.org

lostwages/news 2006083102.xml
by Jeremy Newman Aug. 31, 2006

Aug. 31, 2006

ChangeSet ID: 27745 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/08/31 14:06:36 Added files: news : 2006083102.xml Log message: Tom Wickline <twickline(a)gmail.com> News : CrossOver Mac 6.0 Beta 1 Released Patch: http://cvs.winehq.org/patch.py?id=27745 Old revision New revision Changes Path Added 1.1 +0 -0 lostwages/news/2006083102.xml Index: lostwages/news/2006083102.xml diff -u -p /dev/null lostwages/news/2006083102.xml:1.1 --- /dev/null 31 Aug 2006 19: 6:36 -0000 +++ lostwages/news/2006083102.xml 31 Aug 2006 19: 6:36 -0000 @@ -0,0 +1,13 @@ +<news> + <date>August 31, 2006</date> + <title>CrossOver Mac 6.0 Beta 1</title> + <body> + <p>CodeWeavers + <a href="http://crossover.codeweavers.com/pipermail/announce/2006-August/000033.html">announced</a> + CrossOver Mac 6.0 Beta 1 today. The final release will add support for many + of today's popular Office applications as well as limited gaming support in + the way of official support for Half-Life 2. For more details, + see their <a href="http://www.codeweavers.com/products/cxmac/">CrossOver Mac</a> product page. + </p> + </body> +</news>

1 0

lostwages/news 2006083101.xml
by Jeremy Newman Aug. 31, 2006

Aug. 31, 2006

ChangeSet ID: 27744 CVSROOT: /opt/cvs-commit Module name: lostwages Changes by: jnewman(a)winehq.org 2006/08/31 12:22:52 Added files: news : 2006083101.xml Log message: Tom Wickline <twickline(a)gmail.com> News : 9.20 release Patch: http://cvs.winehq.org/patch.py?id=27744 Old revision New revision Changes Path Added 1.1 +0 -0 lostwages/news/2006083101.xml Index: lostwages/news/2006083101.xml diff -u -p /dev/null lostwages/news/2006083101.xml:1.1 --- /dev/null 31 Aug 2006 17:22:52 -0000 +++ lostwages/news/2006083101.xml 31 Aug 2006 17:22:52 -0000 @@ -0,0 +1,28 @@ +<news> + <date>August 31, 2006</date> + <title>Wine 0.9.20 Released</title> + <body> +<p> +A new beta version of Wine was released today. Besides the usual bugfixes, +you might notice the following changes:</p> + +<ul> +<li> XEmbed system tray support.</li> +<li> Many improvements to NTLM support.</li> +<li> Many messages made localizable instead of hardcoded to English.</li> +<li> Improved support for various OpenGL platforms.</li> +<li> More improvements to the IDL compiler.</li> +</ul> + +<p> + Binary packages are in the process of being built and it may take a few days + for them to appear, but the source is + <a href="http://prdownloads.sourceforge.net/wine/wine-0.9.20.tar.bz2">available + now</a>. You can find out more about this release in the + <a href="?announce=1.124">announcement</a>. Check out our + <a href="/site/download">download page</a> for packages for your favorite + distribution. +</p> + + </body> +</news>

1 0

appdb/ ./distributionView.php ./testResults.ph ...
by WineHQ Aug. 30, 2006

Aug. 30, 2006

ChangeSet ID: 27743 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/08/30 21:39:10 Modified files: . : distributionView.php testResults.php admin : adminScreenshots.php include : testData.php Log message: "EA Durbin" <ead1234(a)hotmail.com> Make the case of 'Version' match the case used in the constructor Patch: http://cvs.winehq.org/patch.py?id=27743 Old revision New revision Changes Path 1.21 1.22 +1 -1 appdb/distributionView.php 1.19 1.20 +2 -2 appdb/testResults.php 1.15 1.16 +1 -1 appdb/admin/adminScreenshots.php 1.8 1.9 +2 -2 appdb/include/testData.php Index: appdb/distributionView.php diff -u -p appdb/distributionView.php:1.21 appdb/distributionView.php:1.22 --- appdb/distributionView.php:1.21 31 Aug 2006 2:39:10 -0000 +++ appdb/distributionView.php 31 Aug 2006 2:39:10 -0000 @@ -112,7 +112,7 @@ else foreach($oDistribution->aTestingIds as $iTestingId) { $oTest = new testData($iTestingId); - $oVersion = new version($oTest->iVersionId); + $oVersion = new Version($oTest->iVersionId); $oApp = new Application($oVersion->iAppId); $oSubmitter = new User($oTest->iSubmitterId); $bgcolor = $oTest->sTestedRating; Index: appdb/testResults.php diff -u -p appdb/testResults.php:1.19 appdb/testResults.php:1.20 --- appdb/testResults.php:1.19 31 Aug 2006 2:39:10 -0000 +++ appdb/testResults.php 31 Aug 2006 2:39:10 -0000 @@ -85,11 +85,11 @@ if ($aClean['sSub']) { util_show_error_page_and_exit("Insufficient privileges."); } else - $oVersion = new version($oTest->iVersionId); + $oVersion = new Version($oTest->iVersionId); } else { $oTest->iVersionId = $aClean['iVersionId']; - $oVersion = new version($aClean['iVersionId']); + $oVersion = new Version($aClean['iVersionId']); $oTest->sQueued = "new"; } if ($aClean['sSub'] == 'view') Index: appdb/admin/adminScreenshots.php diff -u -p appdb/admin/adminScreenshots.php:1.15 appdb/admin/adminScreenshots.php:1.16 --- appdb/admin/adminScreenshots.php:1.15 31 Aug 2006 2:39:10 -0000 +++ appdb/admin/adminScreenshots.php 31 Aug 2006 2:39:10 -0000 @@ -116,7 +116,7 @@ echo "<div align=center><table><tr>\n"; while ($oRow = mysql_fetch_object($Ids)) { // display thumbnail - $oVersion = new version($oRow->versionId); + $oVersion = new Version($oRow->versionId); $oApp = new Application($oVersion->iAppId); $oScreenshot = new Screenshot($oRow->id); $img = $oScreenshot->get_thumbnail_img(); Index: appdb/include/testData.php diff -u -p appdb/include/testData.php:1.8 appdb/include/testData.php:1.9 --- appdb/include/testData.php:1.8 31 Aug 2006 2:39:10 -0000 +++ appdb/include/testData.php 31 Aug 2006 2:39:10 -0000 @@ -404,7 +404,7 @@ class testData{ while($oRow = mysql_fetch_object($hResult)) { $oTest = new testData($oRow->testingId); - $oVersion = new version($oTest->iVersionId); + $oVersion = new Version($oTest->iVersionId); $oApp = new Application($oVersion->iAppId); $oSubmitter = new User($oTest->iSubmitterId); $oDistribution = new distribution($oTest->iDistributionId); @@ -643,7 +643,7 @@ class testData{ while($oRow = mysql_fetch_object($hResult)) { $oTest = new testData($oRow->testingId); - $oVersion = new version($oTest->iVersionId); + $oVersion = new Version($oTest->iVersionId); // dont show testing results of versions that are still queued. if ($oVersion->sQueued == 'false') {

1 0

appdb/ include/image.php unit_test/test_image.php
by WineHQ Aug. 30, 2006

Aug. 30, 2006

ChangeSet ID: 27742 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/08/30 21:23:01 Modified files: include : image.php unit_test : test_image.php Log message: "EA Durbin" <ead1234(a)hotmail.com> Fix a misnamed variable in image::resize_image_border() and add a unit test to make sure we call this function to test it Patch: http://cvs.winehq.org/patch.py?id=27742 Old revision New revision Changes Path 1.6 1.7 +1 -1 appdb/include/image.php 1.1 1.2 +21 -1 appdb/unit_test/test_image.php Index: appdb/include/image.php diff -u -p appdb/include/image.php:1.6 appdb/include/image.php:1.7 --- appdb/include/image.php:1.6 31 Aug 2006 2:23: 1 -0000 +++ appdb/include/image.php 31 Aug 2006 2:23: 1 -0000 @@ -270,7 +270,7 @@ class Image { ." in $sBorderColor"); imagedestroy($this->oImage); $this->oImage = $new; - $this->iWidth = $new_witdh; + $this->iWidth = $iNewWidth; $this->iHeight= $iNewHeight; } Index: appdb/unit_test/test_image.php diff -u -p appdb/unit_test/test_image.php:1.1 appdb/unit_test/test_image.php:1.2 --- appdb/unit_test/test_image.php:1.1 31 Aug 2006 2:23: 1 -0000 +++ appdb/unit_test/test_image.php 31 Aug 2006 2:23: 1 -0000 @@ -217,7 +217,23 @@ function test_image_add_watermark() return true; } +function test_resize_image_border() +{ + test_start(__FUNCTION__); + $sBorderColor = '#00EEFF'; + $iBorderWidth = 1; + $iNewWidth = 3; + $iNewHeight = 3; + $sImageFilename = TEST_IMAGE_FILENAME; + /* create a new image from a known image file */ + $oImage = new Image($sImageFilename); + + /* resize the image with a border */ + $oImage->resize_image_border($sBorderColor, $iBorderWidth, $iNewWidth, $iNewHeight); + + return true; +} if(!test_image_constructor()) @@ -245,4 +261,8 @@ if(!test_image_add_watermark()) else echo "test_image_add_watermark() passed\n"; -?> \ No newline at end of file +if(!test_resize_image_border()) + echo "test_resize_image_border() failed!\n"; +else + echo "test_resize_image_border() passed\n"; +?>

1 0

appdb/ ./distributionView.php ./testResults.ph ...
by WineHQ Aug. 30, 2006

Aug. 30, 2006

ChangeSet ID: 27741 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/08/30 17:27:07 Modified files: . : distributionView.php testResults.php vendorview.php admin : adminTestResults.php include : testData.php Log message: "EA Durbin" <ead1234(a)hotmail.com> Make the case of 'Application' class match the case used to define the class. Php doesn't care but its a nice touch. Patch: http://cvs.winehq.org/patch.py?id=27741 Old revision New revision Changes Path 1.20 1.21 +1 -1 appdb/distributionView.php 1.18 1.19 +1 -1 appdb/testResults.php 1.22 1.23 +1 -1 appdb/vendorview.php 1.15 1.16 +1 -1 appdb/admin/adminTestResults.php 1.7 1.8 +2 -2 appdb/include/testData.php Index: appdb/distributionView.php diff -u -p appdb/distributionView.php:1.20 appdb/distributionView.php:1.21 --- appdb/distributionView.php:1.20 30 Aug 2006 22:27: 7 -0000 +++ appdb/distributionView.php 30 Aug 2006 22:27: 7 -0000 @@ -113,7 +113,7 @@ else { $oTest = new testData($iTestingId); $oVersion = new version($oTest->iVersionId); - $oApp = new application($oVersion->iAppId); + $oApp = new Application($oVersion->iAppId); $oSubmitter = new User($oTest->iSubmitterId); $bgcolor = $oTest->sTestedRating; Index: appdb/testResults.php diff -u -p appdb/testResults.php:1.18 appdb/testResults.php:1.19 --- appdb/testResults.php:1.18 30 Aug 2006 22:27: 7 -0000 +++ appdb/testResults.php 30 Aug 2006 22:27: 7 -0000 @@ -94,7 +94,7 @@ if ($aClean['sSub']) } if ($aClean['sSub'] == 'view') { - $oApp = new application($oVersion->iAppId); + $oApp = new Application($oVersion->iAppId); $sVersionInfo = $oApp->sName." ".$oVersion->sName; switch($oTest->sQueued) Index: appdb/vendorview.php diff -u -p appdb/vendorview.php:1.22 appdb/vendorview.php:1.23 --- appdb/vendorview.php:1.22 30 Aug 2006 22:27: 7 -0000 +++ appdb/vendorview.php 30 Aug 2006 22:27: 7 -0000 @@ -50,7 +50,7 @@ if($oVendor->iVendorId) echo '<br />Applications by '.$oVendor->sName.'<br /><ol>',"\n"; foreach($oVendor->aApplicationsIds as $iAppId) { - $oApp = new application($iAppId); + $oApp = new Application($iAppId); echo '<li> <a href="appview.php?iAppId='.$oApp->iAppId.'">'.$oApp->sName.'</a> </li>',"\n"; } echo '</ol>',"\n"; Index: appdb/admin/adminTestResults.php diff -u -p appdb/admin/adminTestResults.php:1.15 appdb/admin/adminTestResults.php:1.16 --- appdb/admin/adminTestResults.php:1.15 30 Aug 2006 22:27: 7 -0000 +++ appdb/admin/adminTestResults.php 30 Aug 2006 22:27: 7 -0000 @@ -56,7 +56,7 @@ if ($aClean['sSub']) $oTest = new testData($aClean['iTestingId']); } $oVersion = new Version($oTest->iVersionId); - $oApp = new application($oVersion->iAppId); + $oApp = new Application($oVersion->iAppId); $sVersionInfo = $oApp->sName." ".$oVersion->sName; if ($aClean['sSub'] == 'view') Index: appdb/include/testData.php diff -u -p appdb/include/testData.php:1.7 appdb/include/testData.php:1.8 --- appdb/include/testData.php:1.7 30 Aug 2006 22:27: 7 -0000 +++ appdb/include/testData.php 30 Aug 2006 22:27: 7 -0000 @@ -405,7 +405,7 @@ class testData{ { $oTest = new testData($oRow->testingId); $oVersion = new version($oTest->iVersionId); - $oApp = new application($oVersion->iAppId); + $oApp = new Application($oVersion->iAppId); $oSubmitter = new User($oTest->iSubmitterId); $oDistribution = new distribution($oTest->iDistributionId); $bgcolor = $oTest->sTestedRating; @@ -647,7 +647,7 @@ class testData{ // dont show testing results of versions that are still queued. if ($oVersion->sQueued == 'false') { - $oApp = new application($oVersion->iAppId); + $oApp = new Application($oVersion->iAppId); $oSubmitter = new User($oTest->iSubmitterId); $bgcolor = $oTest->sTestedRating; echo '<tr class='.$bgcolor.'>',"\n";

1 0

appdb/include application.php
by WineHQ Aug. 30, 2006

Aug. 30, 2006

ChangeSet ID: 27740 CVSROOT: /opt/cvs-commit Module name: appdb Changes by: wineowner(a)winehq.org 2006/08/30 17:24:05 Modified files: include : application.php Log message: "EA Durbin" <ead1234(a)hotmail.com> Add missing include of category.php into application.php Patch: http://cvs.winehq.org/patch.py?id=27740 Old revision New revision Changes Path 1.70 1.71 +1 -0 appdb/include/application.php Index: appdb/include/application.php diff -u -p appdb/include/application.php:1.70 appdb/include/application.php:1.71 --- appdb/include/application.php:1.70 30 Aug 2006 22:24: 5 -0000 +++ appdb/include/application.php 30 Aug 2006 22:24: 5 -0000 @@ -5,6 +5,7 @@ require_once(BASE."include/version.php"); require_once(BASE."include/vendor.php"); +require_once(BASE."include/category.php"); require_once(BASE."include/url.php"); require_once(BASE."include/util.php"); require_once(BASE."include/mail.php");

1 0

Mike McCormack : msi: Fix a memory leak.
by Alexandre Julliard Aug. 29, 2006

Aug. 29, 2006

Module: wine Branch: master Commit: 6eea50394e2168d2784d90391ad4169e1cf19ecf URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=6eea50394e2168d2784d903… Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Aug 29 17:07:45 2006 +0900 msi: Fix a memory leak. --- dlls/msi/join.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msi/join.c b/dlls/msi/join.c index 7ce408e..17f04c0 100644 --- a/dlls/msi/join.c +++ b/dlls/msi/join.c @@ -326,6 +326,8 @@ static UINT JOIN_delete( struct tagMSIVI msi_free( jv->pairs ); jv->pairs = NULL; + msi_free( jv ); + return ERROR_SUCCESS; }

1 0

Mike McCormack : msi: Free the handle table on PROCESS_DETACH.
by Alexandre Julliard Aug. 29, 2006

Aug. 29, 2006

Module: wine Branch: master Commit: 155a325f967d2d222baec5bab7eaad95ad5f3967 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=155a325f967d2d222baec5b… Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Aug 29 17:08:01 2006 +0900 msi: Free the handle table on PROCESS_DETACH. --- dlls/msi/handle.c | 13 ++++++++++--- dlls/msi/msi_main.c | 1 + dlls/msi/msipriv.h | 1 + 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/msi/handle.c b/dlls/msi/handle.c index 3bcdb46..0193277 100644 --- a/dlls/msi/handle.c +++ b/dlls/msi/handle.c @@ -60,6 +60,13 @@ typedef struct msi_handle_info_t static msi_handle_info *msihandletable = NULL; static int msihandletable_size = 0; +void msi_free_handle_table(void) +{ + msi_free( msihandletable ); + msihandletable = NULL; + msihandletable_size = 0; +} + MSIHANDLE alloc_msihandle( MSIOBJECTHDR *obj ) { MSIHANDLE ret = 0; @@ -80,12 +87,12 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR newsize = 256; p = msi_alloc_zero(newsize*sizeof(msi_handle_info)); } - else - { + else + { newsize = msihandletable_size * 2; p = msi_realloc_zero(msihandletable, newsize*sizeof(msi_handle_info)); - } + } if (!p) goto out; msihandletable = p; diff --git a/dlls/msi/msi_main.c b/dlls/msi/msi_main.c index fcb6f5d..294de71 100644 --- a/dlls/msi/msi_main.c +++ b/dlls/msi/msi_main.c @@ -72,6 +72,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, break; case DLL_PROCESS_DETACH: msi_dialog_unregister_class(); + msi_free_handle_table(); break; } return TRUE; diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 6f771da..991c11c 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -306,6 +306,7 @@ extern void msiobj_addref(MSIOBJECTHDR * extern int msiobj_release(MSIOBJECTHDR *); extern void msiobj_lock(MSIOBJECTHDR *); extern void msiobj_unlock(MSIOBJECTHDR *); +extern void msi_free_handle_table(void); extern void free_cached_tables( MSIDATABASE *db ); extern void msi_free_transforms( MSIDATABASE *db );

1 0

Mike McCormack : msi: Properties are case sensitive.
by Alexandre Julliard Aug. 29, 2006

Aug. 29, 2006

Module: wine Branch: master Commit: b1839561930f04c4161bbe19d0b74c445de5bb73 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=b1839561930f04c4161bbe1… Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Aug 29 17:08:40 2006 +0900 msi: Properties are case sensitive. --- dlls/msi/package.c | 4 ++-- dlls/msi/tests/package.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 871ccbf..c700bbf 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -852,7 +852,7 @@ static UINT msi_prop_makehash( const WCH while( *str ) { - hash ^= tolowerW( *str++ ); + hash ^= *str++; hash *= 53; hash = (hash<<5) | (hash>>27); } @@ -865,7 +865,7 @@ static msi_property *msi_prop_find( MSIP msi_property *prop; LIST_FOR_EACH_ENTRY( prop, &package->props[hash], msi_property, entry ) - if (!lstrcmpiW( prop->key, key )) + if (!lstrcmpW( prop->key, key )) return prop; return NULL; } diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 7856a62..bee2901 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -1354,6 +1354,27 @@ static void test_props(void) ok( !strcmp(buffer,"xy"), "buffer was not changed\n"); ok( sz == 3, "wrong size returned\n"); + r = MsiSetProperty(hpkg, "SourceDir", "foo"); + ok( r == ERROR_SUCCESS, "wrong return val\n"); + + sz = 4; + r = MsiGetProperty(hpkg, "SOURCEDIR", buffer, &sz); + ok( r == ERROR_SUCCESS, "wrong return val\n"); + ok( !strcmp(buffer,""), "buffer wrong\n"); + ok( sz == 0, "wrong size returned\n"); + + sz = 4; + r = MsiGetProperty(hpkg, "SOMERANDOMNAME", buffer, &sz); + ok( r == ERROR_SUCCESS, "wrong return val\n"); + ok( !strcmp(buffer,""), "buffer wrong\n"); + ok( sz == 0, "wrong size returned\n"); + + sz = 4; + r = MsiGetProperty(hpkg, "SourceDir", buffer, &sz); + ok( r == ERROR_SUCCESS, "wrong return val\n"); + ok( !strcmp(buffer,"foo"), "buffer wrong\n"); + ok( sz == 3, "wrong size returned\n"); + MsiCloseHandle( hpkg ); DeleteFile(msifile); }

1 0

Mike McCormack : msi: Fix test compilation with MSVC6.
by Alexandre Julliard Aug. 29, 2006

Aug. 29, 2006

Module: wine Branch: master Commit: ada5daa76ababd5e1ffc9a2ede3f3cbb50ea4553 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ada5daa76ababd5e1ffc9a2… Author: Mike McCormack <mike(a)codeweavers.com> Date: Tue Aug 29 17:08:09 2006 +0900 msi: Fix test compilation with MSVC6. --- dlls/msi/tests/package.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index bee2901..d223f9e 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -30,6 +30,10 @@ #include "wine/test.h" static const char msifile[] = "winetest.msi"; +#ifndef INVALID_FILE_ATTRIBUTES +#define INVALID_FILE_ATTRIBUTES 0xffffffff +#endif + static UINT run_query( MSIHANDLE hdb, const char *query ) { MSIHANDLE hview = 0;

1 0