October 2007 - Wine-Commits

Marcus Meissner : crypt32/tests: Fixed buffer overflow in encode test.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: 7689953404fe6ab0152d93d75df6038564ca20f9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7689953404fe6ab0152d93d75… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Oct 7 14:24:41 2007 +0200 crypt32/tests: Fixed buffer overflow in encode test. --- dlls/crypt32/tests/encode.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/crypt32/tests/encode.c b/dlls/crypt32/tests/encode.c index a459dde..65b6a0f 100644 --- a/dlls/crypt32/tests/encode.c +++ b/dlls/crypt32/tests/encode.c @@ -464,7 +464,7 @@ static void testTimeEncoding(DWORD dwEncoding, LPCSTR structType, static const char *printSystemTime(const SYSTEMTIME *st) { - static char buf[22]; + static char buf[25]; sprintf(buf, "%02d-%02d-%04d %02d:%02d:%02d.%03d", st->wMonth, st->wDay, st->wYear, st->wHour, st->wMinute, st->wSecond, st->wMilliseconds); @@ -473,7 +473,7 @@ static const char *printSystemTime(const SYSTEMTIME *st) static const char *printFileTime(const FILETIME *ft) { - static char buf[22]; + static char buf[25]; SYSTEMTIME st; FileTimeToSystemTime(ft, &st);

1 0

Lei Zhang : comctl32: Fix monthcal hit tests.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: 4b8ca91d036f3e0098023abce4c992466ce4517d URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b8ca91d036f3e0098023abce… Author: Lei Zhang <thestig(a)google.com> Date: Sun Oct 7 05:36:19 2007 -0700 comctl32: Fix monthcal hit tests. --- dlls/comctl32/tests/monthcal.c | 152 +++++++++++++++++++++++---------------- 1 files changed, 90 insertions(+), 62 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4b8ca91d036f3e0098023…

1 0

Dan Hipschman : widl: Implement pointer_default functionality.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: 24ce74e96a49db7007a2e86399e9481d9a81e95f URL: http://source.winehq.org/git/wine.git/?a=commit;h=24ce74e96a49db7007a2e8639… Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Mon Oct 8 16:46:23 2007 -0700 widl: Implement pointer_default functionality. --- tools/widl/parser.h | 6 ++++++ tools/widl/parser.y | 23 +++++++++++++++-------- tools/widl/typelib.c | 4 ++++ tools/widl/widltypes.h | 2 ++ 4 files changed, 27 insertions(+), 8 deletions(-) diff --git a/tools/widl/parser.h b/tools/widl/parser.h index 5baf655..c46364a 100644 --- a/tools/widl/parser.h +++ b/tools/widl/parser.h @@ -21,6 +21,12 @@ #ifndef __WIDL_PARSER_H #define __WIDL_PARSER_H +typedef struct +{ + type_t *interface; + unsigned char old_pointer_default; +} interface_info_t; + int parser_parse(void); extern FILE *parser_in; diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 8399b40..68ef0cb 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -155,6 +155,7 @@ static void check_all_user_types(ifref_list_t *ifaces); UUID *uuid; unsigned int num; double dbl; + interface_info_t ifinfo; } %token <str> aIDENTIFIER @@ -247,7 +248,8 @@ static void check_all_user_types(ifref_list_t *ifaces); %type <expr> m_expr expr expr_const %type <expr_list> m_exprs /* exprs expr_list */ expr_list_const %type <array_dims> array array_list -%type <type> inherit interface interfacehdr interfacedef interfacedec +%type <ifinfo> interfacehdr +%type <type> inherit interface interfacedef interfacedec %type <type> dispinterface dispinterfacehdr dispinterfacedef %type <type> module modulehdr moduledef %type <type> base_type int_std @@ -795,32 +797,37 @@ interface: tINTERFACE aIDENTIFIER { $$ = get_type(RPC_FC_IP, $2, 0); $$->kind = | tINTERFACE aKNOWNTYPE { $$ = get_type(RPC_FC_IP, $2, 0); $$->kind = TKIND_INTERFACE; } ; -interfacehdr: attributes interface { $$ = $2; - if ($$->defined) yyerror("multiple definition error"); - $$->attrs = $1; - $$->defined = TRUE; - if (!parse_only && do_header) write_forward($$); +interfacehdr: attributes interface { $$.interface = $2; + $$.old_pointer_default = pointer_default; + if (is_attr($1, ATTR_POINTERDEFAULT)) + pointer_default = get_attrv($1, ATTR_POINTERDEFAULT); + if ($2->defined) yyerror("multiple definition error"); + $2->attrs = $1; + $2->defined = TRUE; + if (!parse_only && do_header) write_forward($2); } ; interfacedef: interfacehdr inherit - '{' int_statements '}' { $$ = $1; + '{' int_statements '}' { $$ = $1.interface; $$->ref = $2; $$->funcs = $4; compute_method_indexes($$); if (!parse_only && do_header) write_interface($$); if (!parse_only && do_idfile) write_iid($$); + pointer_default = $1.old_pointer_default; } /* MIDL is able to import the definition of a base class from inside the * definition of a derived class, I'll try to support it with this rule */ | interfacehdr ':' aIDENTIFIER - '{' import int_statements '}' { $$ = $1; + '{' import int_statements '}' { $$ = $1.interface; $$->ref = find_type2($3, 0); if (!$$->ref) yyerror("base class '%s' not found in import", $3); $$->funcs = $6; compute_method_indexes($$); if (!parse_only && do_header) write_interface($$); if (!parse_only && do_idfile) write_iid($$); + pointer_default = $1.old_pointer_default; } | dispinterfacedef { $$ = $1; } ; diff --git a/tools/widl/typelib.c b/tools/widl/typelib.c index 7afeef6..5341720 100644 --- a/tools/widl/typelib.c +++ b/tools/widl/typelib.c @@ -252,6 +252,9 @@ void start_typelib(char *name, attr_list_t *attrs) typelib->attrs = attrs; list_init( &typelib->entries ); list_init( &typelib->importlibs ); + + if (is_attr(attrs, ATTR_POINTERDEFAULT)) + pointer_default = get_attrv(attrs, ATTR_POINTERDEFAULT); } void end_typelib(void) @@ -260,6 +263,7 @@ void end_typelib(void) if (!typelib) return; create_msft_typelib(typelib); + pointer_default = RPC_FC_UP; return; } diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h index 5dc634c..a7e8d59 100644 --- a/tools/widl/widltypes.h +++ b/tools/widl/widltypes.h @@ -307,6 +307,8 @@ struct _user_type_t { const char *name; }; +extern unsigned char pointer_default; + extern user_type_list_t user_type_list; void check_for_user_types_and_context_handles(const var_list_t *list);

1 0

Dan Hipschman : widl: Keep track of every allocated type_t to simplify set_all_tfswrite.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: 2226ddcadfeaf2029f67838bc5dc73094c8df366 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2226ddcadfeaf2029f67838bc… Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Mon Oct 8 16:47:28 2007 -0700 widl: Keep track of every allocated type_t to simplify set_all_tfswrite. --- tools/widl/parser.y | 23 +++++++++++++++++++++- tools/widl/typegen.c | 49 +---------------------------------------------- tools/widl/typelib.c | 2 +- tools/widl/widltypes.h | 2 + 4 files changed, 27 insertions(+), 49 deletions(-) diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 68ef0cb..06f1f77 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -1249,9 +1249,30 @@ static array_dims_t *append_array(array_dims_t *list, expr_t *expr) return list; } +static struct list type_pool = LIST_INIT(type_pool); +typedef struct +{ + type_t data; + struct list link; +} type_pool_node_t; + +type_t *alloc_type(void) +{ + type_pool_node_t *node = xmalloc(sizeof *node); + list_add_tail(&type_pool, &node->link); + return &node->data; +} + +void set_all_tfswrite(int val) +{ + type_pool_node_t *node; + LIST_FOR_EACH_ENTRY(node, &type_pool, type_pool_node_t, link) + node->data.tfswrite = val; +} + static type_t *make_type(unsigned char type, type_t *ref) { - type_t *t = xmalloc(sizeof(type_t)); + type_t *t = alloc_type(); t->name = NULL; t->kind = TKIND_PRIMITIVE; t->type = type; diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index ba2c983..f3ca74f 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -2095,36 +2095,6 @@ static size_t write_typeformatstring_var(FILE *file, int indent, const func_t *f offset, typeformat_offset); } -static void set_tfswrite(type_t *type, int val) -{ - while (type->tfswrite != val) - { - type_t *utype = get_user_type(type, NULL); - - type->tfswrite = val; - - if (utype) - set_tfswrite(utype, val); - - if (type->kind == TKIND_ALIAS) - type = type->orig; - else if (is_ptr(type) || is_array(type)) - type = type->ref; - else - { - if (type->fields) - { - var_t *v; - LIST_FOR_EACH_ENTRY( v, type->fields, var_t, entry ) - if (v->type) - set_tfswrite(v->type, val); - } - - return; - } - } -} - static int write_embedded_types(FILE *file, const attr_list_t *attrs, type_t *type, const char *name, int write_ptr, unsigned int *tfsoff) { @@ -2180,21 +2150,6 @@ static int write_embedded_types(FILE *file, const attr_list_t *attrs, type_t *ty return retmask; } -static void set_all_tfswrite(const ifref_list_t *ifaces, int val) -{ - const ifref_t * iface; - const func_t *func; - const var_t *var; - - if (ifaces) - LIST_FOR_EACH_ENTRY( iface, ifaces, const ifref_t, entry ) - if (iface->iface->funcs) - LIST_FOR_EACH_ENTRY( func, iface->iface->funcs, const func_t, entry ) - if (func->args) - LIST_FOR_EACH_ENTRY( var, func->args, const var_t, entry ) - set_tfswrite(var->type, val); -} - static size_t process_tfs(FILE *file, const ifref_list_t *ifaces, int for_objects) { const var_t *var; @@ -2242,7 +2197,7 @@ void write_typeformatstring(FILE *file, const ifref_list_t *ifaces, int for_obje indent++; print_file(file, indent, "NdrFcShort(0x0),\n"); - set_all_tfswrite(ifaces, TRUE); + set_all_tfswrite(TRUE); process_tfs(file, ifaces, for_objects); print_file(file, indent, "0x0\n"); @@ -2859,7 +2814,7 @@ size_t get_size_procformatstring(const ifref_list_t *ifaces, int for_objects) size_t get_size_typeformatstring(const ifref_list_t *ifaces, int for_objects) { - set_all_tfswrite(ifaces, FALSE); + set_all_tfswrite(FALSE); return process_tfs(NULL, ifaces, for_objects); } diff --git a/tools/widl/typelib.c b/tools/widl/typelib.c index 5341720..7130e50 100644 --- a/tools/widl/typelib.c +++ b/tools/widl/typelib.c @@ -52,7 +52,7 @@ static typelib_t *typelib; type_t *duptype(type_t *t, int dupname) { - type_t *d = xmalloc(sizeof *d); + type_t *d = alloc_type(); *d = *t; if (dupname && t->name) diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h index a7e8d59..4145be2 100644 --- a/tools/widl/widltypes.h +++ b/tools/widl/widltypes.h @@ -313,6 +313,8 @@ extern user_type_list_t user_type_list; void check_for_user_types_and_context_handles(const var_list_t *list); void init_types(void); +type_t *alloc_type(void); +void set_all_tfswrite(int val); type_t *duptype(type_t *t, int dupname); type_t *alias(type_t *t, const char *name);

1 0

Dan Hipschman : widl: Allow quoted UUIDs.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: cfa54572707404bfabe89ccd522ed8e6f00fb0db URL: http://source.winehq.org/git/wine.git/?a=commit;h=cfa54572707404bfabe89ccd5… Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Mon Oct 8 16:45:09 2007 -0700 widl: Allow quoted UUIDs. --- tools/widl/parser.l | 2 +- tools/widl/parser.y | 26 +++++++++++++++++++++++++- tools/widl/utils.h | 3 +++ 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/tools/widl/parser.l b/tools/widl/parser.l index 4cd98bb..e9bfb1f 100644 --- a/tools/widl/parser.l +++ b/tools/widl/parser.l @@ -78,7 +78,7 @@ int import_stack_ptr = 0; static void pop_import(void); -static UUID* parse_uuid(const char*u) +UUID *parse_uuid(const char *u) { UUID* uuid = xmalloc(sizeof(UUID)); char b[3]; diff --git a/tools/widl/parser.y b/tools/widl/parser.y index ae7f8f1..8399b40 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -265,6 +265,7 @@ static void check_all_user_types(ifref_list_t *ifaces); %type <type> coclass coclasshdr coclassdef %type <num> pointer_type version %type <str> libraryhdr +%type <uuid> uuid_string %left ',' %right '?' ':' @@ -498,7 +499,7 @@ attribute: { $$ = NULL; } | tSWITCHIS '(' expr ')' { $$ = make_attrp(ATTR_SWITCHIS, $3); } | tSWITCHTYPE '(' type ')' { $$ = make_attrp(ATTR_SWITCHTYPE, $3); } | tTRANSMITAS '(' type ')' { $$ = make_attrp(ATTR_TRANSMITAS, $3); } - | tUUID '(' aUUID ')' { $$ = make_attrp(ATTR_UUID, $3); } + | tUUID '(' uuid_string ')' { $$ = make_attrp(ATTR_UUID, $3); } | tV1ENUM { $$ = make_attr(ATTR_V1ENUM); } | tVARARG { $$ = make_attr(ATTR_VARARG); } | tVERSION '(' version ')' { $$ = make_attrv(ATTR_VERSION, $3); } @@ -506,6 +507,12 @@ attribute: { $$ = NULL; } | pointer_type { $$ = make_attrv(ATTR_POINTERTYPE, $1); } ; +uuid_string: + aUUID + | aSTRING { if (!is_valid_uuid($1)) + yyerror("invalid UUID: %s", $1); + $$ = parse_uuid($1); } + callconv: | tSTDCALL ; @@ -2037,3 +2044,20 @@ static void check_all_user_types(ifref_list_t *ifrefs) check_for_user_types_and_context_handles(f->args); } } + +int is_valid_uuid(const char *s) +{ + int i; + + for (i = 0; i < 36; ++i) + if (i == 8 || i == 13 || i == 18 || i == 23) + { + if (s[i] != '-') + return FALSE; + } + else + if (!isxdigit(s[i])) + return FALSE; + + return s[i] == '\0'; +} diff --git a/tools/widl/utils.h b/tools/widl/utils.h index 3641aae..aa1d6b4 100644 --- a/tools/widl/utils.h +++ b/tools/widl/utils.h @@ -42,4 +42,7 @@ void chat(const char *s, ...) __attribute__((format (printf, 1, 2))); char *dup_basename(const char *name, const char *ext); +UUID *parse_uuid(const char *u); +int is_valid_uuid(const char *s); + #endif

1 0

Rob Shearman : oleaut32: Add a check for a test that depends on the decimal separator being a dot.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: ce2cba7a09ea9aff97eda844a55469a37e22fc16 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ce2cba7a09ea9aff97eda844a… Author: Rob Shearman <rob(a)codeweavers.com> Date: Sun Oct 7 16:30:12 2007 +0200 oleaut32: Add a check for a test that depends on the decimal separator being a dot. --- dlls/oleaut32/tests/vartest.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/oleaut32/tests/vartest.c b/dlls/oleaut32/tests/vartest.c index 5ec765b..511fe47 100644 --- a/dlls/oleaut32/tests/vartest.c +++ b/dlls/oleaut32/tests/vartest.c @@ -3107,6 +3107,7 @@ static void test_VarRound(void) HRESULT hres; VARIANT v, exp, vDst; CY *pcy = &V_CY(&v); + char buff[8]; CHECKPTR(VarRound); @@ -3138,8 +3139,14 @@ static void test_VarRound(void) * compare the first few digits. */ VARROUND(DATE,1.451,1,DATE,1.5); VARROUND(DATE,-1.45,1,DATE,-1.4); - VARROUND(BSTR,(BSTR)szNumMin,1,R8,-1.40); - if (0) { VARROUND(BSTR,(BSTR)szNum,1,R8,1.50); } + GetLocaleInfoA(LOCALE_USER_DEFAULT, LOCALE_SDECIMAL, buff, sizeof(buff)/sizeof(char)); + if (buff[0] != '.' || buff[1]) + skip("Skipping VarRound(BSTR) as decimal separator is '%s'\n", buff); + else + { + VARROUND(BSTR,(BSTR)szNumMin,1,R8,-1.40); + if (0) { VARROUND(BSTR,(BSTR)szNum,1,R8,1.50); } + } VARROUND(R4,1.23456f,0,R4,1.0f); VARROUND(R4,1.23456f,1,R4,1.2f);

1 0

Huw Davies : comctl32/tests: Don' t assume that the default font height is 16 pixels.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: e31d8d8f5bc4a1000096d6041473edf4a48d4f40 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e31d8d8f5bc4a1000096d6041… Author: Huw Davies <huw(a)codeweavers.com> Date: Sun Oct 7 15:31:43 2007 +0100 comctl32/tests: Don't assume that the default font height is 16 pixels. --- dlls/comctl32/tests/treeview.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c index 4f99e0d..17d33a5 100644 --- a/dlls/comctl32/tests/treeview.c +++ b/dlls/comctl32/tests/treeview.c @@ -141,7 +141,7 @@ static const struct message TestGetSetItemHeightSeq[] = { { TVM_GETITEMHEIGHT, sent|wparam|lparam, 0x00000000, 0x00000000 }, { TVM_SETITEMHEIGHT, sent|wparam|lparam, 0xffffffff, 0x00000000 }, { TVM_GETITEMHEIGHT, sent|wparam|lparam, 0x00000000, 0x00000000 }, - { TVM_SETITEMHEIGHT, sent|wparam|lparam, 0x00000020, 0x00000000 }, + { TVM_SETITEMHEIGHT, sent|lparam, 0xcccccccc, 0x00000000 }, { TVM_GETITEMHEIGHT, sent|wparam|lparam, 0x00000000, 0x00000000 }, { TVM_SETITEMHEIGHT, sent|wparam|lparam, 0x00000009, 0x00000000 }, { WM_WINDOWPOSCHANGING, sent|defwinproc },

1 0

Chris Robinson : wined3d: Prevent some console spamming.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: c4cc337d7a3ba08ea2d6c8cbce8db7e824e92a64 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4cc337d7a3ba08ea2d6c8cbc… Author: Chris Robinson <chris.kcat(a)gmail.com> Date: Sun Oct 7 01:57:46 2007 -0700 wined3d: Prevent some console spamming. --- dlls/wined3d/state.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index d9a2684..6476e6f 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -203,13 +203,17 @@ static void state_zfunc(DWORD state, IWineD3DStateBlockImpl *stateblock, WineD3D if(glParm) { if(glParm == GL_EQUAL || glParm == GL_NOTEQUAL) { + static BOOL once = FALSE; /* There are a few issues with this: First, our inability to * select a proper Z depth, most of the time we're stuck with * D24S8, even if the app selects D32 or D16. There seem to be * some other precision problems which have to be debugged to * make NOTEQUAL and EQUAL work properly */ - FIXME("D3DCMP_NOTEQUAL and D3DCMP_EQUAL do not work correctly yet\n"); + if(!once) { + once = TRUE; + FIXME("D3DCMP_NOTEQUAL and D3DCMP_EQUAL do not work correctly yet\n"); + } } glDepthFunc(glParm); @@ -2553,8 +2557,12 @@ static void state_vertexblend(DWORD state, IWineD3DStateBlockImpl *stateblock, W stateblock->wineD3DDevice->vertexBlendUsed = TRUE; } } else { - /* TODO: Implement vertex blending in drawStridedSlow */ - FIXME("Vertex blending enabled, but not supported by hardware\n"); + static BOOL once = FALSE; + if(!once) { + once = TRUE; + /* TODO: Implement vertex blending in drawStridedSlow */ + FIXME("Vertex blending enabled, but not supported by hardware\n"); + } } break;

1 0

Huw Davies : comctl32/tests: Skip some font dependent tests if we don' t have System or Tahoma installed.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: 75c2fb668d7e2a0729bf5ed5cbebea0133d0cec6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=75c2fb668d7e2a0729bf5ed5c… Author: Huw Davies <huw(a)codeweavers.com> Date: Sun Oct 7 12:16:46 2007 +0100 comctl32/tests: Skip some font dependent tests if we don't have System or Tahoma installed. --- dlls/comctl32/tests/rebar.c | 27 +++++++++++++++++++++++++-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/tests/rebar.c b/dlls/comctl32/tests/rebar.c index d715d33..2b318d2 100644 --- a/dlls/comctl32/tests/rebar.c +++ b/dlls/comctl32/tests/rebar.c @@ -45,6 +45,23 @@ static HWND hRebar; #define expect_eq(expr, value, type, format) { type ret = expr; ok((value) == ret, #expr " expected " format " got " format "\n", (value), (ret)); } +static INT CALLBACK is_font_installed_proc(const LOGFONT *elf, const TEXTMETRIC *ntm, DWORD type, LPARAM lParam) +{ + return 0; +} + +static BOOL is_font_installed(const char *name) +{ + HDC hdc = GetDC(0); + BOOL ret = FALSE; + + if(!EnumFontFamiliesA(hdc, name, is_font_installed_proc, 0)) + ret = TRUE; + + ReleaseDC(0, hdc); + return ret; +} + static void rebuild_rebar(HWND *hRebar) { if (*hRebar) @@ -797,8 +814,14 @@ START_TEST(rebar) ShowWindow(hMainWnd, SW_SHOW); bandinfo_test(); - layout_test(); - resize_test(); + + if(is_font_installed("System") && is_font_installed("Tahoma")) + { + layout_test(); + resize_test(); + } else + skip("Missing System or Tahoma font\n"); + PostQuitMessage(0); while(GetMessageA(&msg,0,0,0)) { TranslateMessage(&msg);

1 0

Jacek Caban : mshtml: Skip tests if we can' t get body object - it means that there is no Gecko available.
by Alexandre Julliard Oct. 9, 2007

Oct. 9, 2007

Module: wine Branch: master Commit: df4bdad94d049444d29cbec95f4a4fd6bc2e6a07 URL: http://source.winehq.org/git/wine.git/?a=commit;h=df4bdad94d049444d29cbec95… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Oct 7 10:49:04 2007 +0200 mshtml: Skip tests if we can't get body object - it means that there is no Gecko available. --- dlls/mshtml/tests/dom.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index fefe054..966831e 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -597,8 +597,10 @@ typedef void (*domtest_t)(IHTMLDocument2*); static void run_domtest(const char *str, domtest_t test) { IHTMLDocument2 *doc; + IHTMLElement *body = NULL; ULONG ref; MSG msg; + HRESULT hres; doc = create_doc_with_string(str); do_advise((IUnknown*)doc, &IID_IPropertyNotifySink, (IUnknown*)&PropertyNotifySink); @@ -608,7 +610,15 @@ static void run_domtest(const char *str, domtest_t test) DispatchMessage(&msg); } - test(doc); + hres = IHTMLDocument2_get_body(doc, &body); + ok(hres == S_OK, "get_body failed: %08x\n", hres); + + if(body) { + IHTMLElement_Release(body); + test(doc); + }else { + skip("Could not get document body. Assuming no Gecko installed.\n"); + } ref = IHTMLDocument2_Release(doc); ok(!ref, "ref = %d\n", ref);

1 0