April 2007 - Wine-Commits - list.winehq.org

Rob Shearman : msi: Don' t add info to the _Columns table for non-persistent tables.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: a33cc3d859992aa783dcfca92e3fb31b054df1f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a33cc3d859992aa783dcfca92… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:25:17 2007 +0100 msi: Don't add info to the _Columns table for non-persistent tables. --- dlls/msi/table.c | 71 ++++++++++++++++++++++++++------------------------ dlls/msi/tests/db.c | 2 - 2 files changed, 37 insertions(+), 36 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index ddf0ee4..09abe1a 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -670,7 +670,7 @@ UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, if( r ) goto err; - r = tv->ops->insert_row( tv, rec, FALSE ); + r = tv->ops->insert_row( tv, rec, !persistent ); TRACE("insert_row returned %x\n", r); if( r ) goto err; @@ -680,51 +680,54 @@ UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, msiobj_release( &rec->hdr ); - /* add each column to the _Columns table */ - r = TABLE_CreateView( db, szColumns, &tv ); - if( r ) - return r; - - r = tv->ops->execute( tv, 0 ); - TRACE("tv execute returned %x\n", r); - if( r ) - goto err; - - rec = MSI_CreateRecord( 4 ); - if( !rec ) - goto err; - - r = MSI_RecordSetStringW( rec, 1, name ); - if( r ) - goto err; - - /* - * need to set the table, column number, col name and type - * for each column we enter in the table - */ - nField = 1; - for( col = col_info; col; col = col->next ) + if( persistent ) { - r = MSI_RecordSetInteger( rec, 2, nField ); + /* add each column to the _Columns table */ + r = TABLE_CreateView( db, szColumns, &tv ); if( r ) - goto err; + return r; - r = MSI_RecordSetStringW( rec, 3, col->column ); + r = tv->ops->execute( tv, 0 ); + TRACE("tv execute returned %x\n", r); if( r ) goto err; - r = MSI_RecordSetInteger( rec, 4, col->type ); - if( r ) + rec = MSI_CreateRecord( 4 ); + if( !rec ) goto err; - r = tv->ops->insert_row( tv, rec, !persistent ); + r = MSI_RecordSetStringW( rec, 1, name ); if( r ) goto err; - nField++; + /* + * need to set the table, column number, col name and type + * for each column we enter in the table + */ + nField = 1; + for( col = col_info; col; col = col->next ) + { + r = MSI_RecordSetInteger( rec, 2, nField ); + if( r ) + goto err; + + r = MSI_RecordSetStringW( rec, 3, col->column ); + if( r ) + goto err; + + r = MSI_RecordSetInteger( rec, 4, col->type ); + if( r ) + goto err; + + r = tv->ops->insert_row( tv, rec, FALSE ); + if( r ) + goto err; + + nField++; + } + if( !col ) + r = ERROR_SUCCESS; } - if( !col ) - r = ERROR_SUCCESS; err: if (rec) diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index 53599ed..422bba3 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -2730,7 +2730,6 @@ static void test_temporary_table(void) ok( r == ERROR_SUCCESS, "temporary table exists in _Tables\n"); MsiCloseHandle( rec ); - todo_wine { /* query the column data */ rec = 0; r = do_query(hdb, "select * from `_Columns` where `Table` = 'T' AND `Name` = 'B'", &rec); @@ -2740,7 +2739,6 @@ static void test_temporary_table(void) r = do_query(hdb, "select * from `_Columns` where `Table` = 'T' AND `Name` = 'C'", &rec); ok( r == ERROR_NO_MORE_ITEMS, "temporary table exists in _Columns\n"); if (rec) MsiCloseHandle( rec ); - } MsiCloseHandle( hdb );

1 0

Rob Shearman : msi: Add support for adding temporary/ non-persistent data to tables.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 23379b3b5c5b2e008ad147a45a43221db2d94385 URL: http://source.winehq.org/git/wine.git/?a=commit;h=23379b3b5c5b2e008ad147a45… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:24:41 2007 +0100 msi: Add support for adding temporary/non-persistent data to tables. --- dlls/msi/insert.c | 2 +- dlls/msi/msipriv.h | 2 +- dlls/msi/select.c | 4 +- dlls/msi/table.c | 129 ++++++++++++++++++++++++++++++++++++++-------------- 4 files changed, 99 insertions(+), 38 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=23379b3b5c5b2e008ad14…

1 0

Rob Shearman : msi: The HOLD keyword implies a temporary table, whereas database importing should lead to permanent tables, so remove the HOLD keyword.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: d8cd46ac47c71f96c67c1a25e2c29875c82ab420 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d8cd46ac47c71f96c67c1a25e… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:23:13 2007 +0100 msi: The HOLD keyword implies a temporary table, whereas database importing should lead to permanent tables, so remove the HOLD keyword. --- dlls/msi/database.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/database.c b/dlls/msi/database.c index ea3e964..875f440 100644 --- a/dlls/msi/database.c +++ b/dlls/msi/database.c @@ -423,7 +423,7 @@ static LPWSTR msi_build_createsql_postlude(LPWSTR *primary_keys, DWORD num_keys) DWORD size, key_size, i; static const WCHAR key_fmt[] = {'`','%','s','`',',',' ',0}; - static const WCHAR postlude_fmt[] = {'P','R','I','M','A','R','Y',' ','K','E','Y',' ','%','s',')',' ','H','O','L','D',0}; + static const WCHAR postlude_fmt[] = {'P','R','I','M','A','R','Y',' ','K','E','Y',' ','%','s',')',0}; for (i = 0, size = 1; i < num_keys; i++) size += lstrlenW(key_fmt) + lstrlenW(primary_keys[i]) - 2;

1 0

Rob Shearman : msi: Create the table directly in create_table instead of requiring it to be loaded after saving .
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 338568886c1611d4a68ee920539381a303701fa1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=338568886c1611d4a68ee9205… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:22:27 2007 +0100 msi: Create the table directly in create_table instead of requiring it to be loaded after saving. --- dlls/msi/table.c | 47 ++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 44 insertions(+), 3 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index dbc292d..712a4af 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -102,6 +102,7 @@ static const MSICOLUMNINFO _Tables_cols[1] = { static UINT table_get_column_info( MSIDATABASE *db, LPCWSTR name, MSICOLUMNINFO **pcols, UINT *pcount ); +static void table_calc_column_offsets( MSICOLUMNINFO *colinfo, DWORD count ); static UINT get_tablecolumns( MSIDATABASE *db, LPCWSTR szTableName, MSICOLUMNINFO *colinfo, UINT *sz); static void msi_free_colinfo( MSICOLUMNINFO *colinfo, UINT count ); @@ -593,8 +594,6 @@ static UINT table_get_column_info( MSIDATABASE *db, LPCWSTR name, MSICOLUMNINFO return r; } -static UINT get_table( MSIDATABASE *db, LPCWSTR name, MSITABLE **table_ret ); - UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, BOOL persistent, MSITABLE **table_ret) { @@ -602,15 +601,51 @@ UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, MSIVIEW *tv = NULL; MSIRECORD *rec = NULL; column_info *col; + MSITABLE *table; + UINT i; /* only add tables that don't exist already */ if( TABLE_Exists(db, name ) ) return ERROR_BAD_QUERY_SYNTAX; + table = msi_alloc( sizeof (MSITABLE) + lstrlenW(name)*sizeof (WCHAR) ); + if( !table ) + return ERROR_FUNCTION_FAILED; + + table->row_count = 0; + table->data = NULL; + table->colinfo = NULL; + table->col_count = 0; + lstrcpyW( table->name, name ); + + for( col = col_info; col; col = col->next ) + table->col_count++; + + table->colinfo = msi_alloc( table->col_count * sizeof(MSICOLUMNINFO) ); + if (!table->colinfo) + { + free_table( table ); + return ERROR_FUNCTION_FAILED; + } + + for( i = 0, col = col_info; col; i++, col = col->next ) + { + table->colinfo[ i ].tablename = strdupW( col->table ); + table->colinfo[ i ].number = i + 1; + table->colinfo[ i ].colname = strdupW( col->column ); + table->colinfo[ i ].type = col->type; + table->colinfo[ i ].offset = 0; + table->colinfo[ i ].hash_table = NULL; + } + table_calc_column_offsets( table->colinfo, table->col_count); + r = TABLE_CreateView( db, szTables, &tv ); TRACE("CreateView returned %x\n", r); if( r ) + { + free_table( table ); return r; + } r = tv->ops->execute( tv, 0 ); TRACE("tv execute returned %x\n", r); @@ -689,7 +724,13 @@ err: tv->ops->delete( tv ); if (r == ERROR_SUCCESS) - r = get_table( db, name, table_ret ); + { + list_add_head( &db->tables, &table->entry ); + *table_ret = table; + } + else + free_table( table ); + return r; }

1 0

Rob Shearman : msi: Move table creation to table.c.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: ba0507a178b223e7d21ea29e19c54e23e2db5107 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ba0507a178b223e7d21ea29e1… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:21:32 2007 +0100 msi: Move table creation to table.c. --- dlls/msi/create.c | 93 +------------------------------------------------ dlls/msi/query.h | 3 ++ dlls/msi/table.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 105 insertions(+), 91 deletions(-) diff --git a/dlls/msi/create.c b/dlls/msi/create.c index 740f563..ef71684 100644 --- a/dlls/msi/create.c +++ b/dlls/msi/create.c @@ -59,101 +59,12 @@ static UINT CREATE_fetch_int( struct tagMSIVIEW *view, UINT row, UINT col, UINT static UINT CREATE_execute( struct tagMSIVIEW *view, MSIRECORD *record ) { MSICREATEVIEW *cv = (MSICREATEVIEW*)view; - column_info *col; - UINT r, nField; - static const WCHAR szTables[] = { '_','T','a','b','l','e','s',0 }; - static const WCHAR szColumns[] = { '_','C','o','l','u','m','n','s',0 }; - MSIVIEW *tv = NULL; - MSIRECORD *rec = NULL; + MSITABLE *table; TRACE("%p Table %s (%s)\n", cv, debugstr_w(cv->name), cv->bIsTemp?"temporary":"permanent"); - /* only add tables that don't exist already */ - if( TABLE_Exists(cv->db, cv->name ) ) - return ERROR_BAD_QUERY_SYNTAX; - - r = TABLE_CreateView( cv->db, szTables, &tv ); - TRACE("CreateView returned %x\n", r); - if( r ) - return r; - - r = tv->ops->execute( tv, 0 ); - TRACE("tv execute returned %x\n", r); - if( r ) - goto err; - - rec = MSI_CreateRecord( 1 ); - if( !rec ) - goto err; - - r = MSI_RecordSetStringW( rec, 1, cv->name ); - if( r ) - goto err; - - r = tv->ops->insert_row( tv, rec ); - TRACE("insert_row returned %x\n", r); - if( r ) - goto err; - - tv->ops->delete( tv ); - tv = NULL; - - msiobj_release( &rec->hdr ); - - /* add each column to the _Columns table */ - r = TABLE_CreateView( cv->db, szColumns, &tv ); - if( r ) - return r; - - r = tv->ops->execute( tv, 0 ); - TRACE("tv execute returned %x\n", r); - if( r ) - goto err; - - rec = MSI_CreateRecord( 4 ); - if( !rec ) - goto err; - - r = MSI_RecordSetStringW( rec, 1, cv->name ); - if( r ) - goto err; - - /* - * need to set the table, column number, col name and type - * for each column we enter in the table - */ - nField = 1; - for( col = cv->col_info; col; col = col->next ) - { - r = MSI_RecordSetInteger( rec, 2, nField ); - if( r ) - goto err; - - r = MSI_RecordSetStringW( rec, 3, col->column ); - if( r ) - goto err; - - r = MSI_RecordSetInteger( rec, 4, col->type ); - if( r ) - goto err; - - r = tv->ops->insert_row( tv, rec ); - if( r ) - goto err; - - nField++; - } - if( !col ) - r = ERROR_SUCCESS; - -err: - if (rec) - msiobj_release( &rec->hdr ); - /* FIXME: remove values from the string table on error */ - if( tv ) - tv->ops->delete( tv ); - return r; + return msi_create_table( cv->db, cv->name, cv->col_info, !cv->bIsTemp, &table); } static UINT CREATE_close( struct tagMSIVIEW *view ) diff --git a/dlls/msi/query.h b/dlls/msi/query.h index 86773ad..a8a633f 100644 --- a/dlls/msi/query.h +++ b/dlls/msi/query.h @@ -127,4 +127,7 @@ int sqliteGetToken(const WCHAR *z, int *tokenType); MSIRECORD *msi_query_merge_record( UINT fields, column_info *vl, MSIRECORD *rec ); +UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, + BOOL persistent, MSITABLE **table_ret); + #endif /* __WINE_MSI_QUERY_H */ diff --git a/dlls/msi/table.c b/dlls/msi/table.c index e414517..dbc292d 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -593,6 +593,106 @@ static UINT table_get_column_info( MSIDATABASE *db, LPCWSTR name, MSICOLUMNINFO return r; } +static UINT get_table( MSIDATABASE *db, LPCWSTR name, MSITABLE **table_ret ); + +UINT msi_create_table( MSIDATABASE *db, LPCWSTR name, column_info *col_info, + BOOL persistent, MSITABLE **table_ret) +{ + UINT r, nField; + MSIVIEW *tv = NULL; + MSIRECORD *rec = NULL; + column_info *col; + + /* only add tables that don't exist already */ + if( TABLE_Exists(db, name ) ) + return ERROR_BAD_QUERY_SYNTAX; + + r = TABLE_CreateView( db, szTables, &tv ); + TRACE("CreateView returned %x\n", r); + if( r ) + return r; + + r = tv->ops->execute( tv, 0 ); + TRACE("tv execute returned %x\n", r); + if( r ) + goto err; + + rec = MSI_CreateRecord( 1 ); + if( !rec ) + goto err; + + r = MSI_RecordSetStringW( rec, 1, name ); + if( r ) + goto err; + + r = tv->ops->insert_row( tv, rec ); + TRACE("insert_row returned %x\n", r); + if( r ) + goto err; + + tv->ops->delete( tv ); + tv = NULL; + + msiobj_release( &rec->hdr ); + + /* add each column to the _Columns table */ + r = TABLE_CreateView( db, szColumns, &tv ); + if( r ) + return r; + + r = tv->ops->execute( tv, 0 ); + TRACE("tv execute returned %x\n", r); + if( r ) + goto err; + + rec = MSI_CreateRecord( 4 ); + if( !rec ) + goto err; + + r = MSI_RecordSetStringW( rec, 1, name ); + if( r ) + goto err; + + /* + * need to set the table, column number, col name and type + * for each column we enter in the table + */ + nField = 1; + for( col = col_info; col; col = col->next ) + { + r = MSI_RecordSetInteger( rec, 2, nField ); + if( r ) + goto err; + + r = MSI_RecordSetStringW( rec, 3, col->column ); + if( r ) + goto err; + + r = MSI_RecordSetInteger( rec, 4, col->type ); + if( r ) + goto err; + + r = tv->ops->insert_row( tv, rec ); + if( r ) + goto err; + + nField++; + } + if( !col ) + r = ERROR_SUCCESS; + +err: + if (rec) + msiobj_release( &rec->hdr ); + /* FIXME: remove values from the string table on error */ + if( tv ) + tv->ops->delete( tv ); + + if (r == ERROR_SUCCESS) + r = get_table( db, name, table_ret ); + return r; +} + static UINT get_table( MSIDATABASE *db, LPCWSTR name, MSITABLE **table_ret ) { MSITABLE *table;

1 0

Rob Shearman : msi: Store the column info in the MSITABLE structure.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 3aa9a25cb3302f12d331827f5d9b7146c01fb81c URL: http://source.winehq.org/git/wine.git/?a=commit;h=3aa9a25cb3302f12d331827f5… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:20:21 2007 +0100 msi: Store the column info in the MSITABLE structure. Load the data on view creation for simplicity instead of view execution. --- dlls/msi/table.c | 216 +++++++++++++++++++++++++----------------------------- 1 files changed, 101 insertions(+), 115 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3aa9a25cb3302f12d3318…

1 0

Rob Shearman : msi: Remove the hash table for a column when one of its values is modified since it will now be invalid .
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 94d48238ffe8edc3778f71b3467100c9beff0a33 URL: http://source.winehq.org/git/wine.git/?a=commit;h=94d48238ffe8edc3778f71b34… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:19:07 2007 +0100 msi: Remove the hash table for a column when one of its values is modified since it will now be invalid. --- dlls/msi/table.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/msi/table.c b/dlls/msi/table.c index 1f8e118..2e83477 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -996,6 +996,9 @@ static UINT TABLE_set_int( MSITABLEVIEW *tv, UINT row, UINT col, UINT val ) return ERROR_FUNCTION_FAILED; } + msi_free( tv->columns[col-1].hash_table ); + tv->columns[col-1].hash_table = NULL; + n = bytes_per_column( &tv->columns[col-1] ); switch( n ) {

1 0

Rob Shearman : msi: Move string loading and saving to string.c.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 37b11baaa3448df1662ca6a970f56dc4f0ce3523 URL: http://source.winehq.org/git/wine.git/?a=commit;h=37b11baaa3448df1662ca6a97… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:17:40 2007 +0100 msi: Move string loading and saving to string.c. --- dlls/msi/database.c | 4 +- dlls/msi/msipriv.h | 9 ++- dlls/msi/string.c | 200 ++++++++++++++++++++++++++++++++++++++++++ dlls/msi/table.c | 242 +++------------------------------------------------ 4 files changed, 222 insertions(+), 233 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=37b11baaa3448df1662ca…

1 0

Rob Shearman : msi: Cleanup unneeded string table functions.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: e261d602fb2db22f0532e45252298f3b23b8c070 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e261d602fb2db22f0532e4525… Author: Rob Shearman <rob(a)codeweavers.com> Date: Mon Apr 23 08:18:27 2007 +0100 msi: Cleanup unneeded string table functions. Make string table functions that aren't used outside of string.c static. --- dlls/msi/msipriv.h | 6 ------ dlls/msi/string.c | 44 +++++++++++++------------------------------- 2 files changed, 13 insertions(+), 37 deletions(-) diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 670719c..713ae7f 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -546,21 +546,15 @@ enum StringPersistence StringNonPersistent = 1 }; -extern BOOL msi_addstring( string_table *st, UINT string_no, const CHAR *data, int len, UINT refcount, enum StringPersistence persistence ); extern BOOL msi_addstringW( string_table *st, UINT string_no, const WCHAR *data, int len, UINT refcount, enum StringPersistence persistence ); extern UINT msi_id2stringW( string_table *st, UINT string_no, LPWSTR buffer, UINT *sz ); extern UINT msi_id2stringA( string_table *st, UINT string_no, LPSTR buffer, UINT *sz ); extern UINT msi_string2idW( string_table *st, LPCWSTR buffer, UINT *id ); extern UINT msi_string2idA( string_table *st, LPCSTR str, UINT *id ); -extern string_table *msi_init_stringtable( int entries, UINT codepage ); extern VOID msi_destroy_stringtable( string_table *st ); -extern UINT msi_string_count( string_table *st ); -extern UINT msi_id_persistent_refcount( string_table *st, UINT i ); -extern UINT msi_string_totalsize( string_table *st, UINT *datasize, UINT *poolsize ); extern UINT msi_strcmp( string_table *st, UINT lval, UINT rval, UINT *res ); extern const WCHAR *msi_string_lookup_id( string_table *st, UINT id ); -extern UINT msi_string_get_codepage( string_table *st ); extern HRESULT msi_init_string_table( IStorage *stg ); extern string_table *msi_load_string_table( IStorage *stg ); extern UINT msi_save_string_table( string_table *st, IStorage *storage ); diff --git a/dlls/msi/string.c b/dlls/msi/string.c index 21b10ee..ef6d7c7 100644 --- a/dlls/msi/string.c +++ b/dlls/msi/string.c @@ -1,7 +1,8 @@ /* - * Implementation of the Microsoft Installer (msi.dll) + * String Table Functions * * Copyright 2002-2004, Mike McCormack for CodeWeavers + * Copyright 2007 Robert Shearman for CodeWeavers * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -74,7 +75,7 @@ static UINT msistring_makehash( const WCHAR *str ) return hash % HASH_SIZE; } -string_table *msi_init_stringtable( int entries, UINT codepage ) +static string_table *init_stringtable( int entries, UINT codepage ) { string_table *st; int i; @@ -171,7 +172,7 @@ static void set_st_entry( string_table *st, UINT n, LPWSTR str, UINT refcount, e st->freeslot = n + 1; } -int msi_addstring( string_table *st, UINT n, const CHAR *data, int len, UINT refcount, enum StringPersistence persistence ) +static int msi_addstring( string_table *st, UINT n, const CHAR *data, int len, UINT refcount, enum StringPersistence persistence ) { LPWSTR str; int sz; @@ -448,19 +449,7 @@ UINT msi_strcmp( string_table *st, UINT lval, UINT rval, UINT *res ) return ERROR_SUCCESS; } -UINT msi_string_count( string_table *st ) -{ - return st->maxcount; -} - -UINT msi_id_persistent_refcount( string_table *st, UINT i ) -{ - if( i >= st->maxcount ) - return 0; - return st->strings[i].persistent_refcount; -} - -UINT msi_string_totalsize( string_table *st, UINT *datasize, UINT *poolsize ) +static void string_totalsize( string_table *st, UINT *datasize, UINT *poolsize ) { UINT i, len, max, holesize; @@ -493,12 +482,6 @@ UINT msi_string_totalsize( string_table *st, UINT *datasize, UINT *poolsize ) holesize += 4; } TRACE("data %u pool %u codepage %x\n", *datasize, *poolsize, st->codepage ); - return max; -} - -UINT msi_string_get_codepage( string_table *st ) -{ - return st->codepage; } static const WCHAR szStringData[] = { @@ -544,7 +527,7 @@ string_table *msi_load_string_table( IStorage *stg ) codepage = pool[0] | ( pool[1] << 16 ); else codepage = CP_ACP; - st = msi_init_stringtable( count, codepage ); + st = init_stringtable( count, codepage ); offset = 0; n = 1; @@ -605,7 +588,7 @@ end: UINT msi_save_string_table( string_table *st, IStorage *storage ) { - UINT i, count, datasize = 0, poolsize = 0, sz, used, r, codepage, n; + UINT i, datasize = 0, poolsize = 0, sz, used, r, codepage, n; UINT ret = ERROR_FUNCTION_FAILED; CHAR *data = NULL; USHORT *pool = NULL; @@ -613,9 +596,9 @@ UINT msi_save_string_table( string_table *st, IStorage *storage ) TRACE("\n"); /* construct the new table in memory first */ - count = msi_string_totalsize( st, &datasize, &poolsize ); + string_totalsize( st, &datasize, &poolsize ); - TRACE("%u %u %u\n", count, datasize, poolsize ); + TRACE("%u %u %u\n", st->maxcount, datasize, poolsize ); pool = msi_alloc( poolsize ); if( ! pool ) @@ -631,14 +614,13 @@ UINT msi_save_string_table( string_table *st, IStorage *storage ) } used = 0; - codepage = msi_string_get_codepage( st ); + codepage = st->codepage; pool[0]=codepage&0xffff; pool[1]=(codepage>>16); n = 1; - for( i=1; i<count; i++ ) + for( i=1; i<st->maxcount; i++ ) { - UINT refcount = msi_id_persistent_refcount( st, i ); - if( !refcount ) + if( !st->strings[i].persistent_refcount ) continue; sz = datasize - used; r = msi_id2stringA( st, i, data+used, &sz ); @@ -651,7 +633,7 @@ UINT msi_save_string_table( string_table *st, IStorage *storage ) sz--; if (sz) - pool[ n*2 + 1 ] = refcount; + pool[ n*2 + 1 ] = st->strings[i].persistent_refcount; else pool[ n*2 + 1 ] = 0; if (sz < 0x10000)

1 0

Dmitry Timoshkov : comctl32: Add more image list tests, fix one problem found.
by Alexandre Julliard April 24, 2007

April 24, 2007

Module: wine Branch: master Commit: 83f51d08df8a642e58a55950f758bd5011c4f60e URL: http://source.winehq.org/git/wine.git/?a=commit;h=83f51d08df8a642e58a55950f… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Tue Apr 24 18:33:59 2007 +0900 comctl32: Add more image list tests, fix one problem found. --- dlls/comctl32/imagelist.c | 2 +- dlls/comctl32/tests/imagelist.c | 22 +++++++++++++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index a49ac45..0c23d19 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -2070,7 +2070,7 @@ ImageList_Remove (HIMAGELIST himl, INT i) return TRUE; } - himl->cMaxImage = himl->cInitial + 1; + himl->cMaxImage = himl->cInitial + himl->cGrow - 1; himl->cCurImage = 0; for (nCount = 0; nCount < MAX_OVERLAYIMAGE; nCount++) himl->nOvlIdx[nCount] = -1; diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c index 7a3d7ec..8b7cd6a 100644 --- a/dlls/comctl32/tests/imagelist.c +++ b/dlls/comctl32/tests/imagelist.c @@ -897,7 +897,15 @@ static void image_list_init(HIMAGELIST himl) static void check_iml_data(HIMAGELIST himl, INT cx, INT cy, INT cur, INT max, INT width, INT height, INT bpp, const char *comment) { - BOOL ret; + INT ret, cxx, cyy; + + ret = ImageList_GetImageCount(himl); + ok(ret == cur, "expected cur %d got %d\n", cur, ret); + + ret = ImageList_GetIconSize(himl, &cxx, &cyy); + ok(ret, "ImageList_GetIconSize failed\n"); + ok(cxx == cx, "wrong cx %d (expected %d)\n", cxx, cx); + ok(cyy == cy, "wrong cy %d (expected %d)\n", cyy, cy); iml_clear_stream_data(); ret = ImageList_Write(himl, &Test_Stream.is); @@ -941,6 +949,18 @@ static void test_imagelist_storage(void) ok(ret, "ImageList_Remove failed\n"); check_iml_data(himl, BMP_CX, BMP_CX, 20, 27, BMP_CX * 4, BMP_CX * 7, 24, "4"); + ret = ImageList_Remove(himl, -2); + ok(!ret, "ImageList_Remove(-2) should fail\n"); + check_iml_data(himl, BMP_CX, BMP_CX, 20, 27, BMP_CX * 4, BMP_CX * 7, 24, "5"); + + ret = ImageList_Remove(himl, 20); + ok(!ret, "ImageList_Remove(20) should fail\n"); + check_iml_data(himl, BMP_CX, BMP_CX, 20, 27, BMP_CX * 4, BMP_CX * 7, 24, "6"); + + ret = ImageList_Remove(himl, -1); + ok(ret, "ImageList_Remove(-1) failed\n"); + check_iml_data(himl, BMP_CX, BMP_CX, 0, 4, BMP_CX * 4, BMP_CX * 1, 24, "7"); + ret = ImageList_Destroy(himl); ok(ret, "ImageList_Destroy failed\n");

1 0