January 2008 - Wine-Commits

Alexander Nicolaysen Sørnes : Fix version_queue::reject()
by Chris Morgan Jan. 27, 2008

Jan. 27, 2008

Module: appdb Branch: master Commit: d0b39672e028e04d49fa00449304da60d010c174 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=d0b39672e028e04d49fa0044… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jan 27 19:15:55 2008 +0100 Fix version_queue::reject() --- include/version_queue.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/version_queue.php b/include/version_queue.php index 08e9a69..280207e 100644 --- a/include/version_queue.php +++ b/include/version_queue.php @@ -59,7 +59,7 @@ class version_queue { $oApp = new application($this->oVersion->iAppId); - if($oApp->sQueued == "false") + if($oApp->objectGetState() == 'accepted') $this->oVersion->reject(); if($this->oDownloadUrl->iId)

1 0

Alexander Nicolaysen Sørnes : Improve edit/delete links for a version's test results list
by Chris Morgan Jan. 27, 2008

Jan. 27, 2008

Module: appdb Branch: master Commit: cd7aa0fdb58242dadc66a0d7529b87e6ff314f4f URL: http://source.winehq.org/git/appdb.git/?a=commit;h=cd7aa0fdb58242dadc66a0d7… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jan 27 18:39:16 2008 +0100 Improve edit/delete links for a version's test results list --- include/testData.php | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/testData.php b/include/testData.php index cfa06fd..d75ee93 100644 --- a/include/testData.php +++ b/include/testData.php @@ -613,13 +613,12 @@ class testData{ $oTableRow->AddTextCell($oSubmitter->objectMakeLink().'&nbsp'); if ($this->iTestingId && $_SESSION['current']->hasAppVersionModifyPermission($oVersion)) { - $oObject = new objectManager("testData"); - $oTableRow->AddTextCell('<a href="'.$oObject->makeUrl("edit", $this->iTestingId, - "Edit Test Results").'">'. - 'Edit</a>   ',"\n". - '<a href="objectManager.php?sClass=testData&bIsQueue=false&sAction='. - 'delete&iId='.$this->iTestingId.'&sTitle=Delete+Test+Results'. - '">Delete</a></td>',"\n"); + $oObject = new objectManager('testData'); + $oTableRow->AddTextCell('<a href="'.$oObject->makeUrl('edit', $this->iTestingId, + 'Edit Test Results').'&sReturnTo='.urlencode($_SERVER['REQUEST_URI']).'">'. + 'Edit</a>   '."\n". + '<a href="'.$oObject->makeUrl('delete', $this->iTestingId, 'Delete+Test+Results'). + '&sReturnTo='.urlencode($_SERVER['REQUEST_URI']).'">Delete</a></td>'."\n"); } // if this is a clickable row, set the appropriate property

1 0

Alexander Nicolaysen Sørnes : Fix updating of rating info when updating test results
by Chris Morgan Jan. 27, 2008

Jan. 27, 2008

Module: appdb Branch: master Commit: 6d5c979f1567aabb0e62cc9502aad49e7e48813d URL: http://source.winehq.org/git/appdb.git/?a=commit;h=6d5c979f1567aabb0e62cc95… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jan 27 18:27:24 2008 +0100 Fix updating of rating info when updating test results --- include/testData.php | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/testData.php b/include/testData.php index 19cf8ae..cfa06fd 100644 --- a/include/testData.php +++ b/include/testData.php @@ -183,9 +183,6 @@ class testData{ $oOldTest->sTestedRelease." to $this->sTestedRelease.\n"; } - if($bUpdateRatingInfo && $this->sState == 'accepted') - $oVersion->updateRatingInfo(); - if($this->iVersionId != $oOldTest->iVersionId) { $sWhatChanged .= 'Moved from '.version::fullName($oOldTest->iVersionId).' to '.version::fullName($this->iVersionId)."\n"; @@ -228,6 +225,9 @@ class testData{ $this->sState, $this->iTestingId)) { + if($bUpdateRatingInfo && $this->sState == 'accepted') + $oVersion->updateRatingInfo(); + if(!$bSilent) $this->SendNotificationMail("edit", $sWhatChanged); return true;

1 0

Alexander Nicolaysen Sørnes : Fix app count on front page
by Chris Morgan Jan. 27, 2008

Jan. 27, 2008

Module: appdb Branch: master Commit: 29f1c4a0ded1d3ec066558ba586b062f855d1990 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=29f1c4a0ded1d3ec066558ba… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jan 27 18:01:11 2008 +0100 Fix app count on front page --- index.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/index.php b/index.php index 58161aa..2fabed0 100644 --- a/index.php +++ b/index.php @@ -58,7 +58,7 @@ if(!$_SESSION['current']->isLoggedIn()) ?> <?php - $iNumApps = version::objectGetEntriesCount(false, false); + $iNumApps = version::objectGetEntriesCount('accepted'); $voteQuery = "SELECT appVotes.versionId, count(userId) as count ". "FROM appVotes ".

1 0

Alexander Nicolaysen Sørnes : Die if failing to establish a MySQL connection
by Chris Morgan Jan. 27, 2008

Jan. 27, 2008

Module: appdb Branch: master Commit: 3a228f94198c57bb388293da5ea07e1b7505147e URL: http://source.winehq.org/git/appdb.git/?a=commit;h=3a228f94198c57bb388293da… Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> Date: Sun Jan 27 17:36:26 2008 +0100 Die if failing to establish a MySQL connection --- include/query.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/query.php b/include/query.php index a5e7c71..4643621 100644 --- a/include/query.php +++ b/include/query.php @@ -79,7 +79,7 @@ function query_parameters() if(!is_resource($hAppdbLink)) { // The last argument makes sure we are really opening a new connection - $hAppdbLink = mysql_connect(APPS_DBHOST, APPS_DBUSER, APPS_DBPASS, true); + $hAppdbLink = mysql_connect(APPS_DBHOST, APPS_DBUSER, APPS_DBPASS, true) or die('Database error, please try again soon: '.mysql_error()); mysql_select_db(APPS_DB, $hAppdbLink); }

1 0

Alexandre Julliard : Wine release 0.9.54
by Alexandre Julliard Jan. 25, 2008

Jan. 25, 2008

Module: website Branch: master Commit: 991f575ef5a101cf38a41c3b1797dfee7317dd2c URL: http://source.winehq.org/git/website.git/?a=commit;h=991f575ef5a101cf38a41c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 25 17:16:40 2008 +0100 Wine release 0.9.54 --- news/2008012501.xml | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/news/2008012501.xml b/news/2008012501.xml new file mode 100644 index 0000000..5650e93 --- /dev/null +++ b/news/2008012501.xml @@ -0,0 +1,24 @@ +<news> +<date>January 25, 2008</date> +<title>Wine 0.9.54 Released</title> +<body> +<p>Wine 0.9.54 was released today, with the following main changes:</p> + +<ul> +<li>Photoshop CS/CS2 should now work, please help us testing it.</li> +<li>A number of RPC fixes.</li> +<li>Various improvements to the debugger support.</li> +<li>Lots of bug fixes.</li> +</ul> + +<p> +Binary packages are in the process of being built and it may take a +few days for them to appear, but the source is +<a href="http://prdownloads.sourceforge.net/wine/wine-0.9.54.tar.bz2">available now</a>. +You can find out more about this release in the +<a href="?announce=0.9.54">announcement</a>. Check out our +<a href="/site/download">download page</a> for packages for your +distribution. +</p> +</body> +</news>

1 0

Alexandre Julliard : Release 0.9.54.
by Alexandre Julliard Jan. 25, 2008

Jan. 25, 2008

Module: wine Branch: master Commit: 8f954ccc0f5284d86eed5552bf62fe2710f74fc5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f954ccc0f5284d86eed5552b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 25 17:05:38 2008 +0100 Release 0.9.54. --- ANNOUNCE | 867 ++++++++++++++++-------------------- ChangeLog | 1473 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ VERSION | 2 +- configure | 18 +- 4 files changed, 1873 insertions(+), 487 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8f954ccc0f5284d86eed5…

1 0

Tag wine-0.9.54 : Alexandre Julliard : Release 0.9.54
by Alexandre Julliard Jan. 25, 2008

Jan. 25, 2008

Module: wine Branch: refs/tags/wine-0.9.54 Tag: cb3c0f8238f3dc52b32e021a15833a576941540a URL: http://source.winehq.org/git/wine.git/?a=tag;h=cb3c0f8238f3dc52b32e021a1583… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 25 17:05:39 2008 +0100 Release 0.9.54

1 0

Dmitry Timoshkov : winex11.drv: Remove an incorrect FIXME.
by Alexandre Julliard Jan. 25, 2008

Jan. 25, 2008

Module: wine Branch: master Commit: 27d3c09a39a6a2a19fac28537b9c8f213075b284 URL: http://source.winehq.org/git/wine.git/?a=commit;h=27d3c09a39a6a2a19fac28537… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Jan 25 20:25:10 2008 +0800 winex11.drv: Remove an incorrect FIXME. --- dlls/winex11.drv/x11drv_main.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c index f2bf12c..8d822ef 100644 --- a/dlls/winex11.drv/x11drv_main.c +++ b/dlls/winex11.drv/x11drv_main.c @@ -498,13 +498,10 @@ static BOOL process_attach(void) break; case 15: - /* Out tests suggest that windows does not support 15 bpp color depth. - * X11 does, what should we do with these situations? + /* In GetDeviceCaps MSDN description explicitly states that + * in 15 bpp mode 16 is returned. */ - FIXME("The X server is running at 15 bpp color depth\n"); - screen_bpp = 15; - break; - + /* fall through */ case 16: screen_bpp = 16; break;

1 0

Ken Thomases : winex11.drv: Accomodate XGetWindowProperty returning an actual format of something other than 32 for the TARGETS property .
by Alexandre Julliard Jan. 25, 2008

Jan. 25, 2008

Module: wine Branch: master Commit: a30327afef7b08d1aac1943ded64ee363a61c537 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a30327afef7b08d1aac1943de… Author: Ken Thomases <ken(a)codeweavers.com> Date: Fri Jan 25 12:20:39 2008 +0000 winex11.drv: Accomodate XGetWindowProperty returning an actual format of something other than 32 for the TARGETS property. We shouldn't care what format the property was set with, as long as we trust that the property is an atom type. --- dlls/winex11.drv/clipboard.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/clipboard.c index 7731ae0..453746f 100644 --- a/dlls/winex11.drv/clipboard.c +++ b/dlls/winex11.drv/clipboard.c @@ -1903,8 +1903,8 @@ static int X11DRV_CLIPBOARD_QueryAvailableData(LPCLIPBOARDINFO lpcbinfo) * The TARGETS property should have returned us a list of atoms * corresponding to each selection target format supported. */ - if ((atype == XA_ATOM || atype == x11drv_atom(TARGETS)) && aformat == 32) - X11DRV_CLIPBOARD_InsertSelectionProperties(display, targetList, cSelectionTargets); + if (atype == XA_ATOM || atype == x11drv_atom(TARGETS)) + X11DRV_CLIPBOARD_InsertSelectionProperties(display, targetList, (cSelectionTargets * aformat / (8 * sizeof(Atom)))); /* Free the list of targets */ wine_tsx11_lock();

1 0