May 2008 - Wine-Commits - list.winehq.org

Francois Gouget : winex11: Standardize a stub trace and add a trailing '\n' .
by Alexandre Julliard May 7, 2008

May 7, 2008

Module: wine Branch: master Commit: 8824bc1ea406767d0ab0fbfc9af4d12e6a6c62fa URL: http://source.winehq.org/git/wine.git/?a=commit;h=8824bc1ea406767d0ab0fbfc9… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue May 6 19:58:59 2008 +0200 winex11: Standardize a stub trace and add a trailing '\n'. --- dlls/winex11.drv/ime.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c index b9c76f4..f478a86 100644 --- a/dlls/winex11.drv/ime.c +++ b/dlls/winex11.drv/ime.c @@ -651,7 +651,7 @@ BOOL WINAPI ImeSelect(HIMC hIMC, BOOL fSelect) BOOL WINAPI ImeSetActiveContext(HIMC hIMC,BOOL fFlag) { - FIXME("Stub"); + FIXME("(%p, %x): stub\n", hIMC, fFlag); return TRUE; }

1 0

Francois Gouget : Assorted spelling fixes.
by Alexandre Julliard May 7, 2008

May 7, 2008

Module: wine Branch: master Commit: 633ee950a1862478119e3ea4b27a4994ed4c1ee8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=633ee950a1862478119e3ea4b… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue May 6 20:01:59 2008 +0200 Assorted spelling fixes. --- dlls/comctl32/comboex.c | 2 +- dlls/comctl32/listview.c | 2 +- dlls/dmime/segment.c | 4 ++-- dlls/dmstyle/styletrack.c | 2 +- dlls/kernel32/module.c | 2 +- dlls/msi/action.c | 2 +- dlls/quartz/mpegsplit.c | 2 +- dlls/quartz/pin.h | 2 +- dlls/quartz/waveparser.c | 2 +- dlls/rsaenh/mpi.c | 2 +- dlls/shell32/tests/shelllink.c | 2 +- dlls/shell32/tests/shellpath.c | 2 +- dlls/twain_32/dsm_ctrl.c | 2 +- dlls/wined3d/state.c | 2 +- dlls/wined3d/swapchain.c | 2 +- dlls/winmm/lolvldrv.c | 2 +- dlls/winmm/mmsystem.c | 2 +- dlls/winmm/playsound.c | 2 +- tools/widl/parser.y | 2 +- 19 files changed, 20 insertions(+), 20 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=633ee950a1862478119e3…

1 0

Paul Vriens : advapi32/tests: Add another test.
by Alexandre Julliard May 7, 2008

May 7, 2008

Module: wine Branch: master Commit: deee97d9eaa7dfe28a9e39f288c3c7ed39f6e7c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=deee97d9eaa7dfe28a9e39f28… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue May 6 18:08:09 2008 +0200 advapi32/tests: Add another test. --- dlls/advapi32/tests/service.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index d299d2d..8ffe2e8 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -94,6 +94,8 @@ static void test_open_scm(void) static void test_open_svc(void) { SC_HANDLE scm_handle, svc_handle; + CHAR displayname[4096]; + DWORD displaysize; /* All NULL (invalid access rights) */ SetLastError(0xdeadbeef); @@ -135,6 +137,21 @@ static void test_open_svc(void) "Expected ERROR_SUCCESS or 0xdeadbeef, got %d\n", GetLastError()); CloseServiceHandle(svc_handle); } + + /* Test to show we can't open a service with the displayname */ + + /* Retrieve the needed size for the buffer */ + displaysize = 0; + GetServiceDisplayNameA(scm_handle, spooler, NULL, &displaysize); + /* Get the displayname */ + GetServiceDisplayNameA(scm_handle, spooler, displayname, &displaysize); + /* Try to open the service with this displayname */ + svc_handle = OpenServiceA(scm_handle, displayname, GENERIC_READ); + ok(!svc_handle, "Expected failure\n"); + ok(GetLastError() == ERROR_SERVICE_DOES_NOT_EXIST, "Expected ERROR_SERVICE_DOES_NOT_EXIST, got %d\n", GetLastError()); + /* Just in case */ + CloseServiceHandle(svc_handle); + CloseServiceHandle(scm_handle); }

1 0

Alexandre Julliard : wine_release: Enable glimpse searches again.
by Alexandre Julliard May 7, 2008

May 7, 2008

Module: tools Branch: master Commit: 5cb8a7f70053e123724fc96e46193f186c94382a URL: http://source.winehq.org/git/tools.git/?a=commit;h=5cb8a7f70053e123724fc96e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 7 11:39:39 2008 +0200 wine_release: Enable glimpse searches again. --- wine_release | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/wine_release b/wine_release index 27043aa..e4afefe 100755 --- a/wine_release +++ b/wine_release @@ -48,8 +48,8 @@ cd wine-$version chmod +r fileidx xref # make Glimpse index -##glimpseindex -n -H . ../../wine-$version -##chmod +r .glimpse* +glimpseindex -n -H . ../../wine-$version +chmod +r .glimpse* cd ../.. (echo "wine-$version"; cat wine-versions) | uniq > wine-versions.new && mv -f wine-versions.new wine-versions

1 0

Jeff Zaroyko : remove message about CVS being "recently removed" - I think it' s unnecessary to mention this since there are more important statements that the user should be reading
by Chris Morgan May 6, 2008

May 6, 2008

Module: appdb Branch: master Commit: b9b20ff4c107a24946b174015bc2d3f4db1adc85 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=b9b20ff4c107a24946b17401… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Tue May 6 18:51:20 2008 +1000 remove message about CVS being "recently removed" - I think it's unnecessary to mention this since there are more important statements that the user should be reading --- include/testData.php | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include/testData.php b/include/testData.php index e415b64..45458d7 100644 --- a/include/testData.php +++ b/include/testData.php @@ -911,8 +911,7 @@ class testData{ echo " check back tomorrow, sometimes it takes us a day to update the list.</li>\n"; echo "<li>If you are testing with an older release than listed please"; echo " upgrade and test with a newer release.</li>\n"; - echo "<li><b>NOTE: 'CVS' was recently removed as a version because we simply can't track"; - echo " exactly which CVS version was used.<br> If you haven't tested with one of the"; + echo "<li>If you haven't tested with one of the"; echo " listed versions please retest with a recent release and resubmit.</li>\n"; echo "</ul>\n"; echo '</td></tr>',"\n";

1 0

Jeff Zaroyko : fix typos in the Voting help and make it valid HTML
by Chris Morgan May 6, 2008

May 6, 2008

Module: appdb Branch: master Commit: 3b65ac5345065d7e845066909f0c2ae15a80fbf1 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=3b65ac5345065d7e84506690… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Tue May 6 18:48:16 2008 +1000 fix typos in the Voting help and make it valid HTML --- help/voting.help | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/help/voting.help b/help/voting.help index c574065..78775e6 100644 --- a/help/voting.help +++ b/help/voting.help @@ -3,20 +3,20 @@ <h3>Application Voting System Help</h3> <p> -The Application Database features a voting system that allows you to pick which <b>3</b> application verions +The Application Database features a voting system that allows you to pick which <b>3</b> application versions you would MOST like to see running in Wine. </p> <p><b>Step by Step Help on Voting</b></p> <ol> -<li>Log into the Application Database.</li><p> +<li>Log into the Application Database.</li> -<li>Browse to the application version you wish to add to your vote list.</li><p> +<li><p>Browse to the application version you wish to add to your vote list.</li> -<li>In the sidebar, click one of the 3 available slots, and click Vote.</li><p> +<li><p>In the sidebar, click one of the 3 available slots, and click Vote.</li> -<li>Done!</li></p> +<li><p>Done!</li> </ol> @@ -25,11 +25,11 @@ you would MOST like to see running in Wine. <ul> - <li><i>Please</i> seriously only vote for applications which will benefit the - community. Don’t vote for applications that are known to be working well. + <li><i>Please</i> vote for applications which will benefit the + community. Don't vote for applications that are known to be working well. We know Solitaire works. Voting for it would not make much sense.</li> - <li>You can clear your vote at anytime. Simply browse to any application + <li>You can clear your vote at any time. Simply browse to any application version in the database, select the slot you want to clear, and click the Clear button.</li>

1 0

Jeff Zaroyko : fix a typo in generic. help and make Maintainer Rating Definitions valid HTML
by Chris Morgan May 6, 2008

May 6, 2008

Module: appdb Branch: master Commit: 5392dc3be8c3ff7ab9fb3701193a059e1957baee URL: http://source.winehq.org/git/appdb.git/?a=commit;h=5392dc3be8c3ff7ab9fb3701… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Tue May 6 18:42:10 2008 +1000 fix a typo in generic.help and make Maintainer Rating Definitions valid HTML --- help/generic.help | 2 +- help/maintainer_ratings.help | 19 ++++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/help/generic.help b/help/generic.help index eb8e04b..4101de3 100644 --- a/help/generic.help +++ b/help/generic.help @@ -1,4 +1,4 @@ - + <center>This is meant as a general guide in case an AppDB entry for a certain program hasn't been created.</center> diff --git a/help/maintainer_ratings.help b/help/maintainer_ratings.help index e2bdfdc..11ab754 100644 --- a/help/maintainer_ratings.help +++ b/help/maintainer_ratings.help @@ -10,37 +10,38 @@ users by giving a rating based on an ‘expert’s’ experience. <ul> -<li class="platinum">Platinum</li> +<li class="platinum">Platinum <p> An application can be rated as Platinum if it installs and runs flawlessly ‘out of the box’. No changes required in winecfg. </p> - -<li class="gold">Gold</li> +</li> +<li class="gold">Gold <p> Application works flawlessly with some DLL overrides, other settings or third party software. </p> - -<li class="silver">Silver</li> +</li> +<li class="silver">Silver <p> Application works excellently for ‘normal’ use; a game works fine in single-player but not in multi-player, Windows Media Player works fine as a plug-in and stand-alone player, but cannot handle DRM etc. </p> +</li> -<li class="Bronze">Bronze</li> +<li class="Bronze">Bronze <p> Application works, but it has some issues, even for normal use; a game may not redraw properly or display fonts in wrong colours, be much slower than it should etc. </p> - -<li class="Garbage">Garbage</li> +</li> +<li class="Garbage">Garbage <p> An application gets this rating if it cannot be used for the purpose it was designed for. There should be at least one bug report in Bugzilla if it gets this rating. Application cannot be installed, does not start, or starts but has so many errors that it is nearly impossible to use it. </p> - +</li> </ul>

1 0

Jeff Zaroyko : revise 'Maintainers Guidelines' to include missing information on HTML editor, various spelling fixes and make a small change so that it produces valid HTML .
by Chris Morgan May 6, 2008

May 6, 2008

Module: appdb Branch: master Commit: 3393853bf479c1297df373c875d81bf097e068f4 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=3393853bf479c1297df373c8… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Tue May 6 18:11:22 2008 +1000 revise 'Maintainers Guidelines' to include missing information on HTML editor, various spelling fixes and make a small change so that it produces valid HTML. --- help/maintainer_guidelines.help | 37 +++++++++++++++++++------------------ 1 files changed, 19 insertions(+), 18 deletions(-) diff --git a/help/maintainer_guidelines.help b/help/maintainer_guidelines.help index e9839e7..6293057 100644 --- a/help/maintainer_guidelines.help +++ b/help/maintainer_guidelines.help @@ -16,18 +16,18 @@ You are expected to: <ul> <li>Keep the application comments clean, all stale data should be removed</li> <li>Be an active user of that application and version</li> -<li>Keep up-to-date with all Wine releases, if there are regressions they should be reported to <a href="mailto:wine-devel(a)winehq.org">wine-devel(a)winehq.org</a> and <a href="http://bugs.winehq.org">Bugzilla</a></li> +<li>Keep up-to-date with all Wine releases, if there are regressions they should filed as bugs in <a href="http://bugs.winehq.org">Bugzilla</a> if there are not bugs already filed.</li> </ul> You will: <ul> -<li>Receive an email anytime a comment is posted or deleted for the application or the application information is modified</li> -<li>Be able to modify all aspects of your application(s) and version(s), including the description, screenshots, how-tos, notes, comments, etc.</li> +<li>Receive an email when a comment is posted or deleted for the application or the application information is modified</li> +<li>Be able to modify all aspects of your application(s) and version(s), including the description, screenshots, HOWTOs, notes, comments, etc.</li> </ul> <br> -<h4>Application overview page guidlines</h4> +<h4>Application overview page guidelines</h4> <p><i>N.B. Only super maintainers can change the general description of an application.</i><br> You can edit an application overview page by clicking on the "Edit Application" button in the application overview page. You will be then presented with a form whose fields are explained thereafter. <ul> @@ -41,15 +41,15 @@ Application vendor should be set correctly. If the vendor is missing, please con Keywords are used by the search engine. You don't need to repeat the application's name but you are encouraged to provide some keywords in this field. </li> <li> -Description should describe the application in a general manner (what it does). The Wine and version specific considerations go in version-specific pages (described below). If you want to add more than a short sentence, please add a cariage return after the first sentence as it will be used when showing the application summary in the search engine, top-25 page and so on. +Description should describe the application in a general manner (what it does). The Wine and version specific considerations go in version-specific pages (described below). If you want to add more than a short sentence, please add a carriage return after the first sentence as it will be used when showing the application summary in the search engine, top-25 page and so on. </li> <li> Webpage should contain the home page for this application. Please remember that a URL starts with http://. </li> </ul> -</p> -<h4>Version page guidlines</h4> + +<h4>Version page guidelines</h4> <p> You can edit a version page by clicking on the "Edit Version" button in any version page for which you are a (super) maintainer. You will then be presented with a form whose fields are explained thereafter. <ul> @@ -67,42 +67,43 @@ Release is the latest release of Wine you tested this version with. </li> </ul> -<h4>Additional URLs guidlines</h4> +<h4>Additional URLs guidelines</h4> <p> In both application and version editing pages you can add additional URLs. These URLs can, for example, help the user find native alternatives for this application (in application overview page) or find specific dlls (in version page). </p> -<h4>Screenshots guidlines</h4> +<h4>Screenshots guidelines</h4> <p> As a maintainer you are encouraged to provide screenshots for the versions you tested under Wine. To add a screenshot, simply click on the screenshot thumbnail in the version page. </p> -<h4>Notes guidlines</h4> +<h4>Notes guidelines</h4> <p> In the version page you can add, edit and delete notes for the versions you maintain. Just click on the "Add note" button. </p> -<h4>How-to guidlines</h4> +<h4>HOWTO guidelines</h4> <p> -How-tos are just a special kind of notes. You can provide step-by-step explanations on how to install or run a specific version of the current application here. Please try to keep How-to's up to date (for example some steps might not be needed anymore using a more recent version of Wine). +HOWTOs are just a special kind of notes. You can provide step-by-step explanations on how to install or run a specific version of the current application here. Please try to keep HOWTOs up to date (for example some steps might no longer be needed if using a more recent version of Wine). </p> -<h4>Warnings guidlines</h4> +<h4>Warnings guidelines</h4> <p> -Warnings are just a special kind of note. Warnings appear in red to catch the attention of the reader. They can be used to warning users against potential data corruption for instance. Please keep the warning up-to-date, especially if it is not true anymore using a recent Wine version (in this case you might choose to keep the warning and tell users that since Wine X.Y, this has been fixed). +Warnings are just a special kind of note. Warnings appear in red to catch the attention of the reader. They can be used to warning users against potential data corruption for instance. Please keep the warning up-to-date, especially if it is not true when using a recent Wine version (in this case you might choose to keep the warning and tell users that since Wine X.Y, this has been fixed). </p> -<h4>Comments guidlines</h4> +<h4>Comments guidelines</h4> <p> As a maintainer you are entitled to delete comments. Use this feature wisely and always explain why you deleted a comment. If a comment is useless or is not true anymore, you can safely delete it. Whenever you can, extract how-tos, other peoples tests (for your test history table for example) from the comments and put it in your versions page and how-to notes. +<p> +If users paste large amounts of debug/crash output from wine, it might be a good idea to delete their comment and depending on whether or not a bug report as been filed for the problem, ask them to file a report and attach the information. </p> <h4>Using the HTML editor</h4> <p> -Here you'll find informations and hints about the HTML editor used when editing informations in the Application Database.<br> -At this time detailed informations are not available. Please check back later. +The HTML editor allows users of the AppDB to write richer descriptions, guides or warnings by providing a WYSIWYG HTML editor. The HTML editor can be disabled in your Preferences which will allow you to edit the html source of various fields. </p> <br> -<p>If you have additionnal questions, please do not hesitate to contact us on <a href="mailto:appdb(a)winehq.org">appdb(a)winehq.org</a>.</p> +<p>If you have additional questions, please do not hesitate to contact us on <a href="mailto:appdb(a)winehq.org">appdb(a)winehq.org</a>.</p>

1 0

Francois Gouget : Add a comment warning when a table must be kept sorted for later use with bsearch ().
by Alexandre Julliard May 6, 2008

May 6, 2008

Module: wine Branch: master Commit: d2364d5d27d91ac723fdec86120fa95d3d4536a4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d2364d5d27d91ac723fdec861… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue May 6 16:05:40 2008 +0200 Add a comment warning when a table must be kept sorted for later use with bsearch(). --- dlls/msi/tokenize.c | 1 + dlls/opengl32/opengl_ext.c | 4 +++- tools/widl/parser.l | 5 ++++- tools/widl/typelib.c | 5 +++-- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/dlls/msi/tokenize.c b/dlls/msi/tokenize.c index d05d244..92a1067 100644 --- a/dlls/msi/tokenize.c +++ b/dlls/msi/tokenize.c @@ -77,6 +77,7 @@ static const WCHAR WHERE_W[] = { 'W','H','E','R','E',0 }; /* ** These are the keywords +** They MUST be in alphabetical order */ static const Keyword aKeywordTable[] = { { ADD_W, TK_ADD }, diff --git a/dlls/opengl32/opengl_ext.c b/dlls/opengl32/opengl_ext.c index 5a37ed9..25674f7 100644 --- a/dlls/opengl32/opengl_ext.c +++ b/dlls/opengl32/opengl_ext.c @@ -9706,7 +9706,9 @@ static void WINAPI wine_glWriteMaskEXT( GLuint res, GLuint in, GLenum outX, GLen } -/* The table giving the correspondence between names and functions */ +/* The table giving the correspondence between names and functions + * This table MUST be alphabetically sorted on the name field + */ const OpenGL_extension extension_registry[1197] = { { "glActiveStencilFaceEXT", "GL_EXT_stencil_two_side", (void *) wine_glActiveStencilFaceEXT }, { "glActiveTexture", "GL_VERSION_1_3", (void *) wine_glActiveTexture }, diff --git a/tools/widl/parser.l b/tools/widl/parser.l index 1c88684..799f94f 100644 --- a/tools/widl/parser.l +++ b/tools/widl/parser.l @@ -198,6 +198,7 @@ struct keyword { int token; }; +/* This table MUST be alphabetically sorted on the kw field */ static const struct keyword keywords[] = { {"FALSE", tFALSE}, {"NULL", tNULL}, @@ -256,7 +257,9 @@ static const struct keyword keywords[] = { }; #define NKEYWORDS (sizeof(keywords)/sizeof(keywords[0])) -/* keywords only recognized in attribute lists */ +/* keywords only recognized in attribute lists + * This table MUST be alphabetically sorted on the kw field + */ static const struct keyword attr_keywords[] = { {"aggregatable", tAGGREGATABLE}, diff --git a/tools/widl/typelib.c b/tools/widl/typelib.c index 7000788..4102fad 100644 --- a/tools/widl/typelib.c +++ b/tools/widl/typelib.c @@ -101,8 +101,9 @@ int is_array(const type_t *t) } /* List of oleauto types that should be recognized by name. - * (most of) these seem to be intrinsic types in mktyplib. */ - + * (most of) these seem to be intrinsic types in mktyplib. + * This table MUST be alphabetically sorted on the kw field. + */ static const struct oatype { const char *kw; unsigned short vt;

1 0

Francois Gouget : Assorted spelling fixes.
by Alexandre Julliard May 6, 2008

May 6, 2008

Module: wine Branch: master Commit: 42a61d7ed74275bace889b3596908c5e28fd8deb URL: http://source.winehq.org/git/wine.git/?a=commit;h=42a61d7ed74275bace889b359… Author: Francois Gouget <fgouget(a)free.fr> Date: Tue May 6 15:54:52 2008 +0200 Assorted spelling fixes. --- dlls/comctl32/tests/header.c | 2 +- dlls/ctapi32/ctapi32.c | 2 +- dlls/ddraw/ddraw.c | 2 +- dlls/ddraw/device.c | 2 +- dlls/ddraw/surface.c | 2 +- dlls/dinput/device.c | 2 +- dlls/dmime/tempotrack.c | 2 +- dlls/mshtml/nsiface.idl | 6 +++--- dlls/msi/msi.c | 2 +- dlls/ole32/moniker.c | 2 +- dlls/quartz/avisplit.c | 2 +- dlls/riched20/tests/editor.c | 8 ++++---- dlls/rpcrt4/tests/ndr_marshall.c | 2 +- dlls/wined3d/device.c | 2 +- dlls/wined3d/wined3d_private.h | 4 ++-- dlls/ws2_32/async.c | 2 +- programs/rpcss/np_server.c | 2 +- tools/winemaker | 2 +- tools/wrc/parser.y | 2 +- 19 files changed, 25 insertions(+), 25 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=42a61d7ed74275bace889…

1 0