June 2008 - Wine-Commits - list.winehq.org

Chris Morgan : Fix parsing errors by escapting apostophes added inside of strings
by Chris Morgan May 31, 2008

May 31, 2008

Module: appdb Branch: master Commit: 017703632a83c1869beed4d495d2e0a0c3cf0cc6 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=017703632a83c1869beed4d4… Author: Chris Morgan <cmorgan(a)alum.wpi.edu> Date: Sat May 31 23:07:18 2008 -0400 Fix parsing errors by escapting apostophes added inside of strings --- include/testData.php | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/testData.php b/include/testData.php index c2180a9..1de6749 100644 --- a/include/testData.php +++ b/include/testData.php @@ -944,7 +944,7 @@ class testData{ if(getInput('bConfirmTestedVersionChange', $aClean) != 'true') { echo '<tr><td class="color1"> </td><td class="color0">'; - echo 'You have changed the Wine version of the report. Are you sure you want to do this? Please submit a new test report for every Wine version you test; this is useful for tracking Wine's progress.<br>'; + echo 'You have changed the Wine version of the report. Are you sure you want to do this? Please submit a new test report for every Wine version you test; this is useful for tracking Wine\'s progress.<br>'; echo '<input type="checkbox" name="bConfirmTestedVersionChange" value="true"> '; echo 'Yes, I want to change the Wine version'; echo '</td></tr>'; @@ -988,7 +988,7 @@ class testData{ getInput('bConfirmTestedVersionChange', $aValues) != 'true') { $errors .= '<li>Are you sure you want to change the Wine version of the report? Please submit a new '. - 'test report for every Wine version you test; this is useful for tracking Wine's progress. '. + 'test report for every Wine version you test; this is useful for tracking Wine\'s progress. '. 'Tick the box above the submit button if you want to proceed</li>'; }

1 0

Jeff Zaroyko : don't use quotes as apostrophes - http://en.wikipedia.org/ wiki/ List_of_XML_and_HTML_character_entity_references lists html entity 8217 as a quote not an apostrophe
by Chris Morgan May 31, 2008

May 31, 2008

Module: appdb Branch: master Commit: df5b9e2b52986b9aa4954f8b945c72b0c5533066 URL: http://source.winehq.org/git/appdb.git/?a=commit;h=df5b9e2b52986b9aa4954f8b… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Sun Jun 1 12:42:00 2008 +1000 don't use quotes as apostrophes - http://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_referenc… lists html entity 8217 as a quote not an apostrophe --- help/maintainer_ratings.help | 2 +- include/application.php | 2 +- include/objectManager.php | 4 ++-- include/testData.php | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/help/maintainer_ratings.help b/help/maintainer_ratings.help index 11ab754..8eabe94 100644 --- a/help/maintainer_ratings.help +++ b/help/maintainer_ratings.help @@ -5,7 +5,7 @@ <p> The Application Database features a maintainer rating system that allows you to see which applications work best in Wine. This rating system is designed to assist -users by giving a rating based on an ‘expert’s’ experience. +users by giving a rating based on an ‘expert's’ experience. </p> <ul> diff --git a/include/application.php b/include/application.php index 2c36f24..d9ee999 100644 --- a/include/application.php +++ b/include/application.php @@ -1096,7 +1096,7 @@ class Application { echo " as possible test results in the version template provided below</li>\n"; echo "</ul></p>"; echo "<p>Having app descriptions just sponsoring the app\n"; - echo "(yes, some vendors want to use the appdb for this) or saying ‘I haven’t tried this app with Wine’ "; + echo "(yes, some vendors want to use the appdb for this) or saying ‘I haven't tried this app with Wine’ "; echo "will not help Wine development or Wine users. Application descriptions should be exactly that and only that, \n"; echo "they should not contain any information about how well the app works, just what the app is. The same applies to the \n"; echo "version information, it should be only information on what is unique or different about that version of the application, \n"; diff --git a/include/objectManager.php b/include/objectManager.php index f050160..32c48fb 100644 --- a/include/objectManager.php +++ b/include/objectManager.php @@ -501,7 +501,7 @@ class ObjectManager /* Why the user should write an explanation for the deletion */ if($oObject->objectGetSubmitterId() != $_SESSION['current']->iUserId) { - $shWhyComment = "Please enter a reason why so that you don’t hurt the submitter’s". + $shWhyComment = "Please enter a reason why so that you don't hurt the submitter's". " feelings."; $oUser = new user($oObject->objectGetSubmitterId()); @@ -597,7 +597,7 @@ class ObjectManager if(!$oOriginalObject->canEdit()) { - addmsg("You don’t have permission to delete this entry", "red"); + addmsg("You don't have permission to delete this entry", "red"); return FALSE; } diff --git a/include/testData.php b/include/testData.php index 3e171cf..c2180a9 100644 --- a/include/testData.php +++ b/include/testData.php @@ -944,7 +944,7 @@ class testData{ if(getInput('bConfirmTestedVersionChange', $aClean) != 'true') { echo '<tr><td class="color1"> </td><td class="color0">'; - echo 'You have changed the Wine version of the report. Are you sure you want to do this? Please submit a new test report for every Wine version you test; this is useful for tracking Wine’s progress.<br>'; + echo 'You have changed the Wine version of the report. Are you sure you want to do this? Please submit a new test report for every Wine version you test; this is useful for tracking Wine's progress.<br>'; echo '<input type="checkbox" name="bConfirmTestedVersionChange" value="true"> '; echo 'Yes, I want to change the Wine version'; echo '</td></tr>'; @@ -988,7 +988,7 @@ class testData{ getInput('bConfirmTestedVersionChange', $aValues) != 'true') { $errors .= '<li>Are you sure you want to change the Wine version of the report? Please submit a new '. - 'test report for every Wine version you test; this is useful for tracking Wine’s progress. '. + 'test report for every Wine version you test; this is useful for tracking Wine's progress. '. 'Tick the box above the submit button if you want to proceed</li>'; }

1 0

Jeff Zaroyko : Fix a typo that caused some input validation to be skipped and added another statement to make ensure that part of the form is validated correctly
by Chris Morgan May 31, 2008

May 31, 2008

Module: appdb Branch: master Commit: f2d44f7120386e0f39279616991e1f10aae98a9e URL: http://source.winehq.org/git/appdb.git/?a=commit;h=f2d44f7120386e0f39279616… Author: Jeff Zaroyko <jeffzaroyko(a)gmail.com> Date: Sun Jun 1 12:06:47 2008 +1000 Fix a typo that caused some input validation to be skipped and added another statement to make ensure that part of the form is validated correctly --- include/testData.php | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/testData.php b/include/testData.php index 45458d7..3e171cf 100644 --- a/include/testData.php +++ b/include/testData.php @@ -1015,8 +1015,11 @@ class testData{ // Basic checking of logic. Runs? can obviously only be 'Not Installable' // if the application does not install - if (($aValues['sInstalls'] != "No") && ($aValues['sRuns'] == "Not Installable")) - $errors .= "<li>You can only set Runs? to ‘Not Installable’ if the applicatino’s installer does not work</li>\n"; + if (($aValues['sInstalls'] != "No") && ($aValues['sRuns'] == "Not installable")) + $errors .= "<li>You can only set Runs? to ‘Not installable’ if the application's installer does not work</li>\n"; + + if (($aValues['sInstalls'] == "No") && ($aValues['sRuns'] != "Not installable")) + $errors .= "<li>You can only set Runs? to ‘Not installable’' if the application's installer does not work</li>\n"; return $errors;

1 0

Adam Lewis : Support for showing a threaded comment reply inline using ajax . Falls back to default if javascript is disabled.
by Chris Morgan May 31, 2008

May 31, 2008

Module: appdb Branch: master Commit: be6a19f95ef5d6d7403e2b74485670cd5c5ddc0e URL: http://source.winehq.org/git/appdb.git/?a=commit;h=be6a19f95ef5d6d7403e2b74… Author: Adam Lewis <adam.j.lewis(a)gmail.com> Date: Thu May 29 08:23:25 2008 -0400 Support for showing a threaded comment reply inline using ajax. Falls back to default if javascript is disabled. --- comment_body.php | 9 + include/comment.php | 64 +- include/header.php | 1 + prototype-1.6.0.2.js | 4221 ++++++++++++++++++++++++++++++++++++++++++++++++++ scripts.js | 27 + 5 files changed, 4316 insertions(+), 6 deletions(-) Diff: http://source.winehq.org/git/appdb.git/?a=commitdiff;h=be6a19f95ef5d6d7403e…

1 0