October 2009 - Wine-Commits

Jacek Caban : mshtml: Added IHTMLDOMNode::cloneNode implementation.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: d0e9681969b4d565af59e583b7efdfac2e5a1471 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d0e9681969b4d565af59e583b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:54:22 2009 +0200 mshtml: Added IHTMLDOMNode::cloneNode implementation. --- dlls/mshtml/htmlnode.c | 18 +++++++++++++- dlls/mshtml/tests/dom.c | 55 +++++++++++++++++++++++++++++++++++++++------- 2 files changed, 62 insertions(+), 11 deletions(-) diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c index 8c83e56..1c7b7cb 100644 --- a/dlls/mshtml/htmlnode.c +++ b/dlls/mshtml/htmlnode.c @@ -536,8 +536,22 @@ static HRESULT WINAPI HTMLDOMNode_cloneNode(IHTMLDOMNode *iface, VARIANT_BOOL fD IHTMLDOMNode **clonedNode) { HTMLDOMNode *This = HTMLDOMNODE_THIS(iface); - FIXME("(%p)->(%x %p)\n", This, fDeep, clonedNode); - return E_NOTIMPL; + nsIDOMNode *nsnode; + HTMLDOMNode *node; + nsresult nsres; + + TRACE("(%p)->(%x %p)\n", This, fDeep, clonedNode); + + nsres = nsIDOMNode_CloneNode(This->nsnode, fDeep != VARIANT_FALSE, &nsnode); + if(NS_FAILED(nsres) || !nsnode) { + ERR("CloneNode failed: %08x\n", nsres); + return E_FAIL; + } + + node = get_node(This->doc, nsnode, TRUE); + IHTMLDOMNode_AddRef(HTMLDOMNODE(node)); + *clonedNode = HTMLDOMNODE(node); + return S_OK; } static HRESULT WINAPI HTMLDOMNode_removeNode(IHTMLDOMNode *iface, VARIANT_BOOL fDeep, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 862d281..dba424b 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -656,6 +656,22 @@ static IHTMLDocument2 *_get_owner_doc(unsigned line, IUnknown *unk) return doc; } +#define clone_node(n,d) _clone_node(__LINE__,n,d) +static IHTMLDOMNode *_clone_node(unsigned line, IUnknown *unk, VARIANT_BOOL deep) +{ + IHTMLDOMNode *node = _get_node_iface(line, unk); + IHTMLDOMNode *ret = NULL; + HRESULT hres; + + hres = IHTMLDOMNode_cloneNode(node, deep, &ret); + IHTMLDOMNode_Release(node); + ok_(__FILE__,line)(hres == S_OK, "cloneNode failed: %08x\n", hres); + ok_(__FILE__,line)(ret != NULL, "ret == NULL\n"); + + return ret; + +} + #define test_elem_tag(u,n) _test_elem_tag(__LINE__,u,n) static void _test_elem_tag(unsigned line, IUnknown *unk, const char *extag) { @@ -1287,6 +1303,21 @@ static void _test_elem_collection(unsigned line, IUnknown *unk, IHTMLElementCollection_Release(col); } +#define test_elem_all(c,t,l) _test_elem_all(__LINE__,c,t,l) +static void _test_elem_all(unsigned line, IUnknown *unk, const elem_type_t *elem_types, LONG exlen) +{ + IHTMLElement *elem = _get_elem_iface(line, unk); + IDispatch *disp; + HRESULT hres; + + hres = IHTMLElement_get_all(elem, &disp); + IHTMLElement_Release(elem); + ok_(__FILE__,line)(hres == S_OK, "get_all failed: %08x\n", hres); + + _test_elem_collection(line, (IUnknown*)disp, elem_types, exlen); + IDispatch_Release(disp); +} + #define test_elem_getelembytag(u,t,l) _test_elem_getelembytag(__LINE__,u,t,l) static void _test_elem_getelembytag(unsigned line, IUnknown *unk, elem_type_t type, LONG exlen) { @@ -4462,9 +4493,11 @@ static void test_table_elem(IHTMLElement *elem) { IHTMLElementCollection *col; IHTMLTable *table; + IHTMLDOMNode *node; HRESULT hres; static const elem_type_t row_types[] = {ET_TR,ET_TR}; + static const elem_type_t all_types[] = {ET_TBODY,ET_TR,ET_TR,ET_TD,ET_TD}; hres = IHTMLElement_QueryInterface(elem, &IID_IHTMLTable, (void**)&table); ok(hres == S_OK, "Could not get IHTMLTable iface: %08x\n", hres); @@ -4479,6 +4512,18 @@ static void test_table_elem(IHTMLElement *elem) test_elem_collection((IUnknown*)col, row_types, sizeof(row_types)/sizeof(*row_types)); IHTMLElementCollection_Release(col); + test_elem_all((IUnknown*)table, all_types, sizeof(all_types)/sizeof(*all_types)); + + node = clone_node((IUnknown*)table, VARIANT_TRUE); + test_elem_tag((IUnknown*)node, "TABLE"); + test_elem_all((IUnknown*)node, all_types, sizeof(all_types)/sizeof(*all_types)); + IHTMLDOMNode_Release(node); + + node = clone_node((IUnknown*)table, VARIANT_FALSE); + test_elem_tag((IUnknown*)node, "TABLE"); + test_elem_all((IUnknown*)node, NULL, 0); + IHTMLDOMNode_Release(node); + IHTMLTable_Release(table); } @@ -4748,16 +4793,8 @@ static void test_elems(IHTMLDocument2 *doc) } elem = get_doc_elem(doc); - ok(hres == S_OK, "get_documentElement failed: %08x\n", hres); - hres = IHTMLElement_get_all(elem, &disp); + test_elem_all((IUnknown*)elem, all_types+1, sizeof(all_types)/sizeof(all_types[0])-1); IHTMLElement_Release(elem); - ok(hres == S_OK, "get_all failed: %08x\n", hres); - - hres = IDispatch_QueryInterface(disp, &IID_IHTMLElementCollection, (void**)&col); - IDispatch_Release(disp); - ok(hres == S_OK, "Could not get IHTMLElementCollection: %08x\n", hres); - test_elem_collection((IUnknown*)col, all_types+1, sizeof(all_types)/sizeof(all_types[0])-1); - IHTMLElementCollection_Release(col); get_elem_by_id(doc, "xxx", FALSE); elem = get_doc_elem_by_id(doc, "xxx");

1 0

Jacek Caban : mshtml: Added IHTMLAnchorElement::get_href tests.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: d3a3af755b59e14e188776f899073ec00aac1ba7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d3a3af755b59e14e188776f89… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:53:17 2009 +0200 mshtml: Added IHTMLAnchorElement::get_href tests. --- dlls/mshtml/tests/dom.c | 34 +++++++++++++++++++++++++++++++++- 1 files changed, 33 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index b8a7e8a..862d281 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -42,7 +42,7 @@ static const char range_test2_str[] = static const char elem_test_str[] = "<html><head><title>test</title><style>.body { margin-right: 0px; }</style>" "<body onload=\"Testing()\">text test" - "<a href=\"http://test\" name=\"x\">link</a>" + "<a id=\"a\" href=\"http://test\" name=\"x\">link</a>" "<input id=\"in\" class=\"testclass\" tabIndex=\"2\" title=\"test title\" />" "<select id=\"s\"><option id=\"x\" value=\"val1\">opt1</option><option id=\"y\">opt2</option></select>" "<textarea id=\"X\">text text</textarea>" @@ -610,6 +610,17 @@ static IHTMLImgElement *_get_img_iface(unsigned line, IUnknown *unk) return img; } +#define get_anchor_iface(u) _get_anchor_iface(__LINE__,u) +static IHTMLAnchorElement *_get_anchor_iface(unsigned line, IUnknown *unk) +{ + IHTMLAnchorElement *anchor; + HRESULT hres; + + hres = IUnknown_QueryInterface(unk, &IID_IHTMLAnchorElement, (void**)&anchor); + ok_(__FILE__,line) (hres == S_OK, "Could not get IHTMLAnchorElement: %08x\n", hres); + return anchor; +} + #define test_node_name(u,n) _test_node_name(__LINE__,u,n) static void _test_node_name(unsigned line, IUnknown *unk, const char *exname) { @@ -898,6 +909,21 @@ static IHTMLElement *_get_doc_elem(unsigned line, IHTMLDocument2 *doc) return elem; } +#define test_anchor_href(a,h) _test_anchor_href(__LINE__,a,h) +static void _test_anchor_href(unsigned line, IUnknown *unk, const char *exhref) +{ + IHTMLAnchorElement *anchor = _get_anchor_iface(line, unk); + BSTR str; + HRESULT hres; + + hres = IHTMLAnchorElement_get_href(anchor, &str); + ok_(__FILE__,line)(hres == S_OK, "get_href failed: %08x\n", hres); + ok_(__FILE__,line)(!strcmp_wa(str, exhref), "href = %s, expected %s\n", wine_dbgstr_w(str), exhref); + SysFreeString(str); + + _test_disp_value(line, unk, exhref); +} + #define test_option_text(o,t) _test_option_text(__LINE__,o,t) static void _test_option_text(unsigned line, IHTMLOptionElement *option, const char *text) { @@ -4932,6 +4958,12 @@ static void test_elems(IHTMLDocument2 *doc) IHTMLElement_Release(elem); } + elem = get_elem_by_id(doc, "a", TRUE); + if(elem) { + test_anchor_href((IUnknown*)elem, "http://test/"); + IHTMLElement_Release(elem); + } + hres = IHTMLDocument2_get_body(doc, &elem); ok(hres == S_OK, "get_body failed: %08x\n", hres);

1 0

Jacek Caban : mshtml.idl: Moved IHTMLElement dispinterface declaration to macro.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 328b1d9ddb77bceab273e979bbb5a572159af783 URL: http://source.winehq.org/git/wine.git/?a=commit;h=328b1d9ddb77bceab273e979b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:56:12 2009 +0200 mshtml.idl: Moved IHTMLElement dispinterface declaration to macro. --- include/mshtml.idl | 3535 +++++----------------------------------------------- 1 files changed, 284 insertions(+), 3251 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=328b1d9ddb77bceab273e…

1 0

Jacek Caban : mshtml: Get rid of no longer needed HTMLLocation_value.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 8085b7085c700e09f483f851a846795f287b0042 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8085b7085c700e09f483f851a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:52:05 2009 +0200 mshtml: Get rid of no longer needed HTMLLocation_value. --- dlls/mshtml/htmllocation.c | 36 +----------------------------------- 1 files changed, 1 insertions(+), 35 deletions(-) diff --git a/dlls/mshtml/htmllocation.c b/dlls/mshtml/htmllocation.c index 67ebf99..45899b4 100644 --- a/dlls/mshtml/htmllocation.c +++ b/dlls/mshtml/htmllocation.c @@ -343,34 +343,6 @@ static HRESULT WINAPI HTMLLocation_toString(IHTMLLocation *iface, BSTR *String) return E_NOTIMPL; } -static HRESULT HTMLLocation_value(IUnknown *iface, LCID lcid, WORD flags, DISPPARAMS *params, - VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) -{ - HTMLLocation *This = HTMLLOCATION_THIS(iface); - HRESULT hres; - - TRACE("(%p)\n", This); - - switch(flags) { - case DISPATCH_PROPERTYGET: { - BSTR str; - - hres = IHTMLLocation_get_href(HTMLLOCATION(This), &str); - if(FAILED(hres)) - return hres; - - V_VT(res) = VT_BSTR; - V_BSTR(res) = str; - break; - } - default: - FIXME("unimplemented flags %x\n", flags); - return E_NOTIMPL; - } - - return S_OK; -} - #undef HTMLLOCATION_THIS static const IHTMLLocationVtbl HTMLLocationVtbl = { @@ -403,18 +375,12 @@ static const IHTMLLocationVtbl HTMLLocationVtbl = { HTMLLocation_toString }; -static const dispex_static_data_vtbl_t HTMLLocation_dispex_vtbl = { - HTMLLocation_value, - NULL, - NULL -}; - static const tid_t HTMLLocation_iface_tids[] = { IHTMLLocation_tid, 0 }; static dispex_static_data_t HTMLLocation_dispex = { - &HTMLLocation_dispex_vtbl, + NULL, DispHTMLLocation_tid, NULL, HTMLLocation_iface_tids

1 0

Jacek Caban : mshtml: Use dispinterface DISPID_VALUE implementation if available.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 1c60a21a53a00b6b395d9d61efd15100f9ebe689 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c60a21a53a00b6b395d9d61e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:51:48 2009 +0200 mshtml: Use dispinterface DISPID_VALUE implementation if available. --- dlls/mshtml/dispex.c | 52 ++++++++++++++++++++++++++++++------------------- 1 files changed, 32 insertions(+), 20 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 3cfae67..4092374 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -31,6 +31,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); +static const WCHAR objectW[] = {'[','o','b','j','e','c','t',']',0}; + typedef struct { DISPID id; BSTR name; @@ -244,10 +246,12 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) TRACE("(%p)\n", This); - hres = get_typeinfo(This->data->disp_tid, &dti); - if(FAILED(hres)) { - ERR("Could not get disp type info: %08x\n", hres); - return NULL; + if(This->data->disp_tid) { + hres = get_typeinfo(This->data->disp_tid, &dti); + if(FAILED(hres)) { + ERR("Could not get disp type info: %08x\n", hres); + return NULL; + } } data = heap_alloc(sizeof(dispex_data_t)); @@ -421,8 +425,6 @@ HRESULT dispex_get_dprop_ref(DispatchEx *This, const WCHAR *name, BOOL alloc, VA static HRESULT dispex_value(DispatchEx *This, LCID lcid, WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) { - static const WCHAR objectW[] = {'[','o','b','j','e','c','t',']',0}; - if(This->data->vtbl && This->data->vtbl->value) return This->data->vtbl->value(This->outer, lcid, flags, params, res, ei, caller); @@ -537,11 +539,13 @@ static const dispex_static_data_vtbl_t function_dispex_vtbl = { NULL }; +static const tid_t function_iface_tids[] = {0}; + static dispex_static_data_t function_dispex = { &function_dispex_vtbl, - LAST_tid, + NULL_tid, NULL, - NULL + function_iface_tids }; static func_disp_t *create_func_disp(DispatchEx *obj, func_info_t *info) @@ -572,6 +576,18 @@ static HRESULT function_invoke(DispatchEx *This, func_info_t *func, WORD flags, case DISPATCH_PROPERTYGET: { dispex_dynamic_data_t *dynamic_data; + if(func->id == DISPID_VALUE) { + BSTR ret; + + ret = SysAllocString(objectW); + if(!ret) + return E_OUTOFMEMORY; + + V_VT(res) = VT_BSTR; + V_BSTR(res) = ret; + return S_OK; + } + dynamic_data = get_dynamic_data(This, TRUE); if(!dynamic_data) return E_OUTOFMEMORY; @@ -613,8 +629,10 @@ static HRESULT get_builtin_func(dispex_data_t *data, DISPID id, func_info_t **re while(min <= max) { n = (min+max)/2; - if(data->funcs[n].id == id) - break; + if(data->funcs[n].id == id) { + *ret = data->funcs+n; + return S_OK; + } if(data->funcs[n].id < id) min = n+1; @@ -622,13 +640,8 @@ static HRESULT get_builtin_func(dispex_data_t *data, DISPID id, func_info_t **re max = n-1; } - if(min > max) { - WARN("invalid id %x\n", id); - return DISP_E_UNKNOWNNAME; - } - - *ret = data->funcs+n; - return S_OK; + WARN("invalid id %x\n", id); + return DISP_E_UNKNOWNNAME; } #define DISPATCHEX_THIS(iface) DEFINE_THIS(DispatchEx, IDispatchEx, iface) @@ -777,9 +790,6 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc TRACE("(%p)->(%x %x %x %p %p %p %p)\n", This, id, lcid, wFlags, pdp, pvarRes, pei, pspCaller); - if(id == DISPID_VALUE) - return dispex_value(This, lcid, wFlags, pdp, pvarRes, pei, pspCaller); - if(is_custom_dispid(id) && This->data->vtbl && This->data->vtbl->invoke) return This->data->vtbl->invoke(This->outer, id, lcid, wFlags, pdp, pvarRes, pei, pspCaller); @@ -853,6 +863,8 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc return E_FAIL; hres = get_builtin_func(data, id, &func); + if(id == DISPID_VALUE && hres == DISP_E_UNKNOWNNAME) + return dispex_value(This, lcid, wFlags, pdp, pvarRes, pei, pspCaller); if(FAILED(hres)) return hres;

1 0

Jacek Caban : mshtml: Added IHTMLAnchorElement::get_href implementation.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 407e54be8957733feccae5ae609d86a6ecf0ec01 URL: http://source.winehq.org/git/wine.git/?a=commit;h=407e54be8957733feccae5ae6… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:52:36 2009 +0200 mshtml: Added IHTMLAnchorElement::get_href implementation. --- dlls/mshtml/htmlanchor.c | 33 +++++++++++++++++++++++++++++++-- dlls/mshtml/nsiface.idl | 36 ++++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlanchor.c b/dlls/mshtml/htmlanchor.c index 7797e7e..09c7eda 100644 --- a/dlls/mshtml/htmlanchor.c +++ b/dlls/mshtml/htmlanchor.c @@ -36,6 +36,8 @@ typedef struct { HTMLElement element; const IHTMLAnchorElementVtbl *lpHTMLAnchorElementVtbl; + + nsIDOMHTMLAnchorElement *nsanchor; } HTMLAnchorElement; #define HTMLANCHOR(x) (&(x)->lpHTMLAnchorElementVtbl) @@ -104,8 +106,26 @@ static HRESULT WINAPI HTMLAnchorElement_put_href(IHTMLAnchorElement *iface, BSTR static HRESULT WINAPI HTMLAnchorElement_get_href(IHTMLAnchorElement *iface, BSTR *p) { HTMLAnchorElement *This = HTMLANCHOR_THIS(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + nsAString href_str; + nsresult nsres; + HRESULT hres; + + TRACE("(%p)->(%p)\n", This, p); + + nsAString_Init(&href_str, NULL); + nsres = nsIDOMHTMLAnchorElement_GetHref(This->nsanchor, &href_str); + if(NS_SUCCEEDED(nsres)) { + const PRUnichar *href; + + nsAString_GetData(&href_str, &href); + hres = nsuri_to_url(href, TRUE, p); + }else { + ERR("GetHref failed: %08x\n", nsres); + hres = E_FAIL; + } + + nsAString_Finish(&href_str); + return hres; } static HRESULT WINAPI HTMLAnchorElement_put_target(IHTMLAnchorElement *iface, BSTR v) @@ -464,6 +484,10 @@ static HRESULT HTMLAnchorElement_QI(HTMLDOMNode *iface, REFIID riid, void **ppv) static void HTMLAnchorElement_destructor(HTMLDOMNode *iface) { HTMLAnchorElement *This = HTMLANCHOR_NODE_THIS(iface); + + if(This->nsanchor) + nsIDOMHTMLAnchorElement_Release(This->nsanchor); + HTMLElement_destructor(&This->element.node); } @@ -497,11 +521,16 @@ static dispex_static_data_t HTMLAnchorElement_dispex = { HTMLElement *HTMLAnchorElement_Create(nsIDOMHTMLElement *nselem) { HTMLAnchorElement *ret = heap_alloc_zero(sizeof(HTMLAnchorElement)); + nsresult nsres; ret->lpHTMLAnchorElementVtbl = &HTMLAnchorElementVtbl; ret->element.node.vtbl = &HTMLAnchorElementImplVtbl; HTMLElement_Init(&ret->element, &HTMLAnchorElement_dispex); + nsres = nsIDOMHTMLElement_QueryInterface(nselem, &IID_nsIDOMHTMLAnchorElement, (void**)&ret->nsanchor); + if(NS_FAILED(nsres)) + ERR("Could not get nsIDOMHTMLAnchorElement iface: %08x\n", nsres); + return &ret->element; } diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index cb8f768..571c023 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -1353,6 +1353,42 @@ interface nsIDOMHTMLImageElement : nsIDOMHTMLElement [ object, + uuid(a6cf90aa-15b3-11d2-932e-00805f8add32), + local + /* FROZEN */ +] +interface nsIDOMHTMLAnchorElement : nsIDOMHTMLElement +{ + nsresult GetAccessKey(nsAString *aAccessKey); + nsresult SetAccessKey(const nsAString *aAccessKey); + nsresult GetCharset(nsAString *aCharset); + nsresult SetCharset(const nsAString *aCharset); + nsresult GetCoords(nsAString *aCoords); + nsresult SetCoords(const nsAString *aCoords); + nsresult GetHref(nsAString *aHref); + nsresult SetHref(const nsAString *aHref); + nsresult GetHreflang(nsAString *aHreflang); + nsresult SetHreflang(const nsAString *aHreflang); + nsresult GetName(nsAString *aName); + nsresult SetName(const nsAString *aName); + nsresult GetRel(nsAString *aRel); + nsresult SetRel(const nsAString *aRel); + nsresult GetRev(nsAString *aRev); + nsresult SetRev(const nsAString *aRev); + nsresult GetShape(nsAString *aShape); + nsresult SetShape(const nsAString *aShape); + nsresult GetTabIndex(PRInt32 *aTabIndex); + nsresult SetTabIndex(PRInt32 aTabIndex); + nsresult GetTarget(nsAString *aTarget); + nsresult SetTarget(const nsAString *aTarget); + nsresult GetType(nsAString *aType); + nsresult SetType(const nsAString *aType); + nsresult Blur(); + nsresult Focus(); +} + +[ + object, uuid(a6cf90b2-15b3-11d2-932e-00805f8add32), local /* FROZEN */

1 0

Paul Vriens : fltlib: Add a stub for FilterConnectCommunicationPort.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 30004df784c7edd922e931860360dd7bfb0ad2d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=30004df784c7edd922e931860… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Fri Oct 2 13:41:50 2009 +0200 fltlib: Add a stub for FilterConnectCommunicationPort. --- dlls/fltlib/fltlib.c | 15 +++++++++++++++ dlls/fltlib/fltlib.spec | 2 +- 2 files changed, 16 insertions(+), 1 deletions(-) diff --git a/dlls/fltlib/fltlib.c b/dlls/fltlib/fltlib.c index 08baf8f..acd202f 100644 --- a/dlls/fltlib/fltlib.c +++ b/dlls/fltlib/fltlib.c @@ -43,3 +43,18 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) } return TRUE; } + +/********************************************************************** + * FilterConnectCommunicationPort (FLTLIB.@) + */ +HRESULT WINAPI FilterConnectCommunicationPort(LPCWSTR lpPortName, DWORD dwOptions, + LPVOID lpContext, DWORD dwSizeOfContext, + LPSECURITY_ATTRIBUTES lpSecurityAttributes, + HANDLE *hPort) +{ + FIXME("(%s, %d, %p, %d, %p, %p) stub\n", debugstr_w(lpPortName), dwOptions, + lpContext, dwSizeOfContext, lpSecurityAttributes, hPort); + + *hPort = INVALID_HANDLE_VALUE; + return E_NOTIMPL; +} diff --git a/dlls/fltlib/fltlib.spec b/dlls/fltlib/fltlib.spec index ac1d7ec..9c84601 100644 --- a/dlls/fltlib/fltlib.spec +++ b/dlls/fltlib/fltlib.spec @@ -1,7 +1,7 @@ @ stub FilterAttach @ stub FilterAttachAtAltitude @ stub FilterClose -@ stub FilterConnectCommunicationPort +@ stdcall FilterConnectCommunicationPort(wstr long ptr long ptr ptr) @ stub FilterCreate @ stub FilterDetach @ stub FilterFindClose

1 0

Michael Stefaniuc : oleaut32/tests: Use LONG instead of long.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 8b2723d48d922cb4fc0a2ae5192505978d606ab4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b2723d48d922cb4fc0a2ae51… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Oct 2 12:18:50 2009 +0200 oleaut32/tests: Use LONG instead of long. --- dlls/oleaut32/tests/olefont.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/oleaut32/tests/olefont.c b/dlls/oleaut32/tests/olefont.c index 8e26a0f..b457f36 100644 --- a/dlls/oleaut32/tests/olefont.c +++ b/dlls/oleaut32/tests/olefont.c @@ -57,9 +57,9 @@ static HRESULT (WINAPI *pOleCreateFontIndirect)(LPFONTDESC,REFIID,LPVOID*); /* check that resulting hfont has height hfont_height. */ /* Various checks along the way. */ -static void test_ifont_sizes(long lo_size, long hi_size, - long ratio_logical, long ratio_himetric, - long hfont_height, const char * test_name) +static void test_ifont_sizes(LONG lo_size, LONG hi_size, + LONG ratio_logical, LONG ratio_himetric, + LONG hfont_height, const char * test_name) { FONTDESC fd; LPVOID pvObj = NULL; @@ -91,8 +91,8 @@ static void test_ifont_sizes(long lo_size, long hi_size, ok(hres == S_OK,"%s: IFont_get_size returns 0x%08x instead of S_OK.\n", test_name, hres); ok(S(psize).Lo == lo_size && S(psize).Hi == 0, - "%s: get_Size: Lo=%d, Hi=%d; expected Lo=%ld, Hi=%ld.\n", - test_name, S(psize).Lo, S(psize).Hi, lo_size, 0L); + "%s: get_Size: Lo=%d, Hi=%d; expected Lo=%d, Hi=0.\n", + test_name, S(psize).Lo, S(psize).Hi, lo_size); /* Change ratio, check size unchanged. Standard is 72, 2540. */ hres = IFont_SetRatio(ifnt, ratio_logical, ratio_himetric); @@ -102,8 +102,8 @@ static void test_ifont_sizes(long lo_size, long hi_size, ok(hres == S_OK,"%s: IFont_get_size returns 0x%08x instead of S_OK.\n", test_name, hres); ok(S(psize).Lo == lo_size && S(psize).Hi == 0, - "%s: gS after SR: Lo=%d, Hi=%d; expected Lo=%ld, Hi=%ld.\n", - test_name, S(psize).Lo, S(psize).Hi, lo_size, 0L); + "%s: gS after SR: Lo=%d, Hi=%d; expected Lo=%d, Hi=0.\n", + test_name, S(psize).Lo, S(psize).Hi, lo_size); /* Check hFont size with this ratio. This tests an important */ /* conversion for which MSDN is very wrong. */ @@ -112,7 +112,7 @@ static void test_ifont_sizes(long lo_size, long hi_size, test_name, hres); hres = GetObject (hfont, sizeof(LOGFONT), &lf); ok(lf.lfHeight == hfont_height, - "%s: hFont has lf.lfHeight=%d, expected %ld.\n", + "%s: hFont has lf.lfHeight=%d, expected %d.\n", test_name, lf.lfHeight, hfont_height); /* Free IFont. */

1 0

Alexandre Julliard : configure: Add -Werror flag in maintainer mode.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: 12753c572071e2acccf6886442bcb7b978d9943e URL: http://source.winehq.org/git/wine.git/?a=commit;h=12753c572071e2acccf688644… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 2 14:39:49 2009 +0200 configure: Add -Werror flag in maintainer mode. --- configure | 36 ++++++++++++++++++++++++++++++++++++ configure.ac | 6 ++++++ 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/configure b/configure index c16637c..5a7516d 100755 --- a/configure +++ b/configure @@ -11753,6 +11753,42 @@ $as_echo "$ac_cv_c_string_h_warnings" >&6; } then EXTRACFLAGS="$EXTRACFLAGS -Wpointer-arith" fi + + if test "${enable_maintainer_mode+set}" = set + then + { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the compiler supports -Werror" >&5 +$as_echo_n "checking whether the compiler supports -Werror... " >&6; } +if test "${ac_cv_cflags__Werror+set}" = set; then : + $as_echo_n "(cached) " >&6 +else + ac_wine_try_cflags_saved=$CFLAGS +CFLAGS="$CFLAGS -Werror" +cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ + +int +main () +{ + + ; + return 0; +} +_ACEOF +if ac_fn_c_try_link "$LINENO"; then : + ac_cv_cflags__Werror=yes +else + ac_cv_cflags__Werror=no +fi +rm -f core conftest.err conftest.$ac_objext \ + conftest$ac_exeext conftest.$ac_ext +CFLAGS=$ac_wine_try_cflags_saved +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_cflags__Werror" >&5 +$as_echo "$ac_cv_cflags__Werror" >&6; } +if test $ac_cv_cflags__Werror = yes; then : + EXTRACFLAGS="$EXTRACFLAGS -Werror" +fi + fi fi diff --git a/configure.ac b/configure.ac index 6210c2f..0cc339b 100644 --- a/configure.ac +++ b/configure.ac @@ -1498,6 +1498,12 @@ then then EXTRACFLAGS="$EXTRACFLAGS -Wpointer-arith" fi + + dnl Enable -Werror for maintainer mode + if test "${enable_maintainer_mode+set}" = set + then + WINE_TRY_CFLAGS([-Werror]) + fi fi dnl **** Check for underscore on external symbols ****

1 0

Jacek Caban : mshtml: Moved init_dispex call to HTMLElement_Init.
by Alexandre Julliard Oct. 2, 2009

Oct. 2, 2009

Module: wine Branch: master Commit: a70bbf82856963a90057f805fcb0a800b0e6c555 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a70bbf82856963a90057f805f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 2 13:50:48 2009 +0200 mshtml: Moved init_dispex call to HTMLElement_Init. --- dlls/mshtml/htmlanchor.c | 2 +- dlls/mshtml/htmlbody.c | 6 ++---- dlls/mshtml/htmlcomment.c | 3 +-- dlls/mshtml/htmlelem.c | 7 +++---- dlls/mshtml/htmlgeneric.c | 3 +-- dlls/mshtml/htmliframe.c | 3 +-- dlls/mshtml/htmlimg.c | 3 +-- dlls/mshtml/htmlinput.c | 3 +-- dlls/mshtml/htmloption.c | 3 +-- dlls/mshtml/htmlscript.c | 4 ++-- dlls/mshtml/htmlselect.c | 3 +-- dlls/mshtml/htmltable.c | 3 +-- dlls/mshtml/htmltablerow.c | 3 +-- dlls/mshtml/htmltextarea.c | 4 ++-- dlls/mshtml/htmltextcont.c | 6 +++--- dlls/mshtml/mshtml_private.h | 4 ++-- 16 files changed, 24 insertions(+), 36 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a70bbf82856963a90057f…

1 0