October 2009 - Wine-Commits

Owen Rudge : comctl32: Ensure listview control has focus when marquee dragging.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: 36e9153f38af09abe4e527fb9b62d5aa4c1201c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=36e9153f38af09abe4e527fb9… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Mon Oct 19 10:57:14 2009 -0500 comctl32: Ensure listview control has focus when marquee dragging. --- dlls/comctl32/listview.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index 4de9149..3744e10 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -9539,6 +9539,9 @@ static LRESULT LISTVIEW_LButtonDown(LISTVIEW_INFO *infoPtr, WORD wKey, INT x, IN } else { + if (!infoPtr->bFocus) + SetFocus(infoPtr->hwndSelf); + /* remove all selections */ if (!(wKey & MK_CONTROL) && !(wKey & MK_SHIFT)) LISTVIEW_DeselectAll(infoPtr);

1 0

Hans Leidekker : msi: Always create a temporary copy of the package.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: 33d9f37f4a34533a543446a54f69d4d212db89d7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=33d9f37f4a34533a543446a54… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Oct 20 14:09:08 2009 +0200 msi: Always create a temporary copy of the package. --- dlls/msi/package.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index fa0cd6f..1d34770 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -908,6 +908,8 @@ UINT MSI_OpenPackageW(LPCWSTR szPackage, MSIPACKAGE **pPackage) if ( UrlIsW( szPackage, URLIS_URL ) ) { file = msi_download_file( szPackage, temppath ); + if ( file != szPackage ) + file = copy_package_to_temp( file, temppath ); base_url = strdupW( szPackage ); if ( !base_url )

1 0

Jacek Caban : mshtml: Use create_nsdoc in exec_indent.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: f1bb67222e6cf094ed4e7775375247e3972da3b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f1bb67222e6cf094ed4e77753… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 19 23:05:20 2009 +0200 mshtml: Use create_nsdoc in exec_indent. --- dlls/mshtml/txtrange.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/txtrange.c b/dlls/mshtml/txtrange.c index 56aa33f..3309bbe 100644 --- a/dlls/mshtml/txtrange.c +++ b/dlls/mshtml/txtrange.c @@ -1778,10 +1778,9 @@ static HRESULT WINAPI RangeCommandTarget_QueryStatus(IOleCommandTarget *iface, c static HRESULT exec_indent(HTMLTxtRange *This, VARIANT *in, VARIANT *out) { + nsIDOMHTMLElement *blockquote_elem, *p_elem; nsIDOMDocumentFragment *fragment; - nsIDOMElement *blockquote_elem, *p_elem; nsIDOMNode *tmp; - nsAString tag_str; static const PRUnichar blockquoteW[] = {'B','L','O','C','K','Q','U','O','T','E',0}; static const PRUnichar pW[] = {'P',0}; @@ -1793,13 +1792,8 @@ static HRESULT exec_indent(HTMLTxtRange *This, VARIANT *in, VARIANT *out) return E_NOTIMPL; } - nsAString_Init(&tag_str, blockquoteW); - nsIDOMHTMLDocument_CreateElement(This->doc->basedoc.nsdoc, &tag_str, &blockquote_elem); - nsAString_Finish(&tag_str); - - nsAString_Init(&tag_str, pW); - nsIDOMDocument_CreateElement(This->doc->basedoc.nsdoc, &tag_str, &p_elem); - nsAString_Finish(&tag_str); + create_nselem(This->doc, blockquoteW, &blockquote_elem); + create_nselem(This->doc, pW, &p_elem); nsIDOMRange_ExtractContents(This->nsrange, &fragment); nsIDOMElement_AppendChild(p_elem, (nsIDOMNode*)fragment, &tmp);

1 0

Henri Verbeet : wined3d: Use context->valid in context_destroy_gl_resources ().
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: e3ca576576c46131330353f45990f55045cf7541 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e3ca576576c46131330353f45… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Oct 20 11:05:05 2009 +0200 wined3d: Use context->valid in context_destroy_gl_resources(). Instead of relying on wglMakeCurrent() to do what we want. --- dlls/wined3d/context.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 16304ee..a96dea4 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -633,22 +633,19 @@ static void context_destroy_gl_resources(struct wined3d_context *context) struct wined3d_occlusion_query *occlusion_query; struct wined3d_event_query *event_query; struct fbo_entry *entry, *entry2; - BOOL has_glctx; - - has_glctx = pwglMakeCurrent(context->hdc, context->glCtx); - if (!has_glctx) WARN("Failed to activate context. Window already destroyed?\n"); ENTER_GL(); LIST_FOR_EACH_ENTRY(occlusion_query, &context->occlusion_queries, struct wined3d_occlusion_query, entry) { - if (has_glctx && GL_SUPPORT(ARB_OCCLUSION_QUERY)) GL_EXTCALL(glDeleteQueriesARB(1, &occlusion_query->id)); + if (context->valid && GL_SUPPORT(ARB_OCCLUSION_QUERY)) + GL_EXTCALL(glDeleteQueriesARB(1, &occlusion_query->id)); occlusion_query->context = NULL; } LIST_FOR_EACH_ENTRY(event_query, &context->event_queries, struct wined3d_event_query, entry) { - if (has_glctx) + if (context->valid) { if (GL_SUPPORT(APPLE_FENCE)) GL_EXTCALL(glDeleteFencesAPPLE(1, &event_query->id)); else if (GL_SUPPORT(NV_FENCE)) GL_EXTCALL(glDeleteFencesNV(1, &event_query->id)); @@ -656,11 +653,13 @@ static void context_destroy_gl_resources(struct wined3d_context *context) event_query->context = NULL; } - LIST_FOR_EACH_ENTRY_SAFE(entry, entry2, &context->fbo_list, struct fbo_entry, entry) { - if (!has_glctx) entry->id = 0; + LIST_FOR_EACH_ENTRY_SAFE(entry, entry2, &context->fbo_list, struct fbo_entry, entry) + { + if (!context->valid) entry->id = 0; context_destroy_fbo_entry(context, entry); } - if (has_glctx) + + if (context->valid) { if (context->src_fbo) {

1 0

Michael Stefaniuc : mshtml: Remove redundant NULL check before HeapFree ( Smatch).
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: 975a93de6813706d71bdde017092dc7522afd8e9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=975a93de6813706d71bdde017… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Oct 19 22:55:03 2009 +0200 mshtml: Remove redundant NULL check before HeapFree (Smatch). --- dlls/mshtml/htmllocation.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmllocation.c b/dlls/mshtml/htmllocation.c index 5db5267..e7b6649 100644 --- a/dlls/mshtml/htmllocation.c +++ b/dlls/mshtml/htmllocation.c @@ -256,10 +256,8 @@ static HRESULT WINAPI HTMLLocation_get_href(IHTMLLocation *iface, BSTR *p) ret = S_OK; cleanup: - if(buf) - HeapFree(GetProcessHeap(), 0, buf); - if(url_path) - HeapFree(GetProcessHeap(), 0, url_path); + HeapFree(GetProcessHeap(), 0, buf); + HeapFree(GetProcessHeap(), 0, url_path); return ret; }

1 0

Jacek Caban : mshtml: Moved creating new element to separated function.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: 9ce3e6b7c2bd952a360018b862e27b314de9ee4c URL: http://source.winehq.org/git/wine.git/?a=commit;h=9ce3e6b7c2bd952a360018b86… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 19 23:04:19 2009 +0200 mshtml: Moved creating new element to separated function. --- dlls/mshtml/htmldoc.c | 22 ++++++---------------- dlls/mshtml/htmlelem.c | 29 +++++++++++++++++++++++++++++ dlls/mshtml/mshtml_private.h | 2 ++ 3 files changed, 37 insertions(+), 16 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index ef3085e..f0c6360 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -911,28 +911,18 @@ static HRESULT WINAPI HTMLDocument_createElement(IHTMLDocument2 *iface, BSTR eTa IHTMLElement **newElem) { HTMLDocument *This = HTMLDOC_THIS(iface); - nsIDOMElement *nselem; + nsIDOMHTMLElement *nselem; HTMLElement *elem; - nsAString tag_str; - nsresult nsres; + HRESULT hres; TRACE("(%p)->(%s %p)\n", This, debugstr_w(eTag), newElem); - if(!This->nsdoc) { - WARN("NULL nsdoc\n"); - return E_UNEXPECTED; - } - - nsAString_Init(&tag_str, eTag); - nsres = nsIDOMDocument_CreateElement(This->nsdoc, &tag_str, &nselem); - nsAString_Finish(&tag_str); - if(NS_FAILED(nsres)) { - ERR("CreateElement failed: %08x\n", nsres); - return E_FAIL; - } + hres = create_nselem(This->doc_node, eTag, &nselem); + if(FAILED(hres)) + return hres; elem = HTMLElement_Create(This->doc_node, (nsIDOMNode*)nselem, TRUE); - nsIDOMElement_Release(nselem); + nsIDOMHTMLElement_Release(nselem); *newElem = HTMLELEM(elem); IHTMLElement_AddRef(HTMLELEM(elem)); diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index d019634..24e8e15 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -38,6 +38,35 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); #define HTMLELEM_THIS(iface) DEFINE_THIS(HTMLElement, HTMLElement, iface) +HRESULT create_nselem(HTMLDocumentNode *doc, const WCHAR *tag, nsIDOMHTMLElement **ret) +{ + nsIDOMElement *nselem; + nsAString tag_str; + nsresult nsres; + + if(!doc->basedoc.nsdoc) { + WARN("NULL nsdoc\n"); + return E_UNEXPECTED; + } + + nsAString_Init(&tag_str, tag); + nsres = nsIDOMDocument_CreateElement(doc->basedoc.nsdoc, &tag_str, &nselem); + nsAString_Finish(&tag_str); + if(NS_FAILED(nsres)) { + ERR("CreateElement failed: %08x\n", nsres); + return E_FAIL; + } + + nsres = nsIDOMElement_QueryInterface(nselem, &IID_nsIDOMHTMLElement, (void**)ret); + nsIDOMElement_Release(nselem); + if(NS_FAILED(nsres)) { + ERR("Could not get nsIDOMHTMLElement iface: %08x\n", nsres); + return E_FAIL; + } + + return S_OK; +} + #define HTMLELEM_NODE_THIS(iface) DEFINE_THIS2(HTMLElement, node, iface) static HRESULT WINAPI HTMLElement_QueryInterface(IHTMLElement *iface, diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 4106500..6fa6ec4 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -659,6 +659,8 @@ void detach_selection(HTMLDocumentNode*); void detach_ranges(HTMLDocumentNode*); HRESULT get_node_text(HTMLDOMNode*,BSTR*); +HRESULT create_nselem(HTMLDocumentNode*,const WCHAR*,nsIDOMHTMLElement**); + HTMLDOMNode *HTMLDOMTextNode_Create(HTMLDocumentNode*,nsIDOMNode*); HTMLElement *HTMLElement_Create(HTMLDocumentNode*,nsIDOMNode*,BOOL);

1 0

Jacek Caban : mshtml: Use create_nselem in set_font_size.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: 6f48c43581d35ccf4c35fb07103c80870c518643 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6f48c43581d35ccf4c35fb071… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 19 23:04:50 2009 +0200 mshtml: Use create_nselem in set_font_size. --- dlls/mshtml/editor.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c index d1d9aad..feda624 100644 --- a/dlls/mshtml/editor.c +++ b/dlls/mshtml/editor.c @@ -93,8 +93,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); #define DOM_VK_HOME VK_HOME #define DOM_VK_END VK_END -static const WCHAR wszFont[] = {'f','o','n','t',0}; -static const WCHAR wszSize[] = {'s','i','z','e',0}; +static const WCHAR fontW[] = {'f','o','n','t',0}; +static const WCHAR sizeW[] = {'s','i','z','e',0}; void set_dirty(HTMLDocument *This, VARIANT_BOOL dirty) { @@ -292,13 +292,13 @@ static void get_font_size(HTMLDocument *This, WCHAR *ret) nsIDOMElement_GetTagName(elem, &tag_str); nsAString_GetData(&tag_str, &tag); - if(!strcmpiW(tag, wszFont)) { + if(!strcmpiW(tag, fontW)) { nsAString size_str, val_str; LPCWSTR val; TRACE("found font tag %p\n", elem); - nsAString_Init(&size_str, wszSize); + nsAString_Init(&size_str, sizeW); nsAString_Init(&val_str, NULL); nsIDOMElement_GetAttribute(elem, &size_str, &val_str); @@ -334,10 +334,9 @@ static void set_font_size(HTMLDocument *This, LPCWSTR size) { nsISelection *nsselection; PRBool collapsed; - nsIDOMElement *elem; + nsIDOMHTMLElement *elem; nsIDOMRange *range; PRInt32 range_cnt = 0; - nsAString font_str; nsAString size_str; nsAString val_str; @@ -359,11 +358,11 @@ static void set_font_size(HTMLDocument *This, LPCWSTR size) } } - nsAString_Init(&font_str, wszFont); - nsAString_Init(&size_str, wszSize); + create_nselem(This->doc_node, fontW, &elem); + + nsAString_Init(&size_str, sizeW); nsAString_Init(&val_str, size); - nsIDOMDocument_CreateElement(This->nsdoc, &font_str, &elem); nsIDOMElement_SetAttribute(elem, &size_str, &val_str); nsISelection_GetRangeAt(nsselection, 0, &range); @@ -376,7 +375,7 @@ static void set_font_size(HTMLDocument *This, LPCWSTR size) nsISelection_Collapse(nsselection, (nsIDOMNode*)elem, 0); }else { /* Remove all size attributes from the range */ - remove_child_attr(elem, wszFont, &size_str); + remove_child_attr((nsIDOMElement*)elem, fontW, &size_str); nsISelection_SelectAllChildren(nsselection, (nsIDOMNode*)elem); } @@ -384,7 +383,6 @@ static void set_font_size(HTMLDocument *This, LPCWSTR size) nsIDOMRange_Release(range); nsIDOMElement_Release(elem); - nsAString_Finish(&font_str); nsAString_Finish(&size_str); nsAString_Finish(&val_str);

1 0

Jacek Caban : mshtml: Use create_nselem in exec_hyperlink.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: fa1388355f6eb51528b129485ea00d85f118199b URL: http://source.winehq.org/git/wine.git/?a=commit;h=fa1388355f6eb51528b129485… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 19 23:05:05 2009 +0200 mshtml: Use create_nselem in exec_hyperlink. --- dlls/mshtml/editor.c | 23 ++++++++++------------- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c index feda624..a1d7b38 100644 --- a/dlls/mshtml/editor.c +++ b/dlls/mshtml/editor.c @@ -1125,17 +1125,17 @@ static INT_PTR CALLBACK hyperlink_dlgproc(HWND hwnd, UINT msg, WPARAM wparam, LP static HRESULT exec_hyperlink(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, VARIANT *out) { - nsAString a_str, href_str, ns_url; + nsAString href_str, ns_url; nsIHTMLEditor *html_editor; - nsIDOMElement *anchor_elem; + nsIDOMHTMLElement *anchor_elem; PRBool insert_link_at_caret; nsISelection *nsselection; BSTR url = NULL; INT ret; HRESULT hres = E_FAIL; - static const WCHAR wszA[] = {'a',0}; - static const WCHAR wszHref[] = {'h','r','e','f',0}; + static const WCHAR aW[] = {'a',0}; + static const WCHAR hrefW[] = {'h','r','e','f',0}; TRACE("%p, 0x%x, %p, %p\n", This, cmdexecopt, in, out); @@ -1164,16 +1164,13 @@ static HRESULT exec_hyperlink(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, if (!nsselection) return E_FAIL; - nsAString_Init(&a_str, wszA); - nsAString_Init(&href_str, wszHref); - nsAString_Init(&ns_url, url); - /* create an element for the link */ - nsIDOMDocument_CreateElement(This->nsdoc, &a_str, &anchor_elem); - nsIDOMElement_SetAttribute(anchor_elem, &href_str, &ns_url); + create_nselem(This->doc_node, aW, &anchor_elem); + nsAString_Init(&href_str, hrefW); + nsAString_Init(&ns_url, url); + nsIDOMElement_SetAttribute(anchor_elem, &href_str, &ns_url); nsAString_Finish(&href_str); - nsAString_Finish(&a_str); nsISelection_GetIsCollapsed(nsselection, &insert_link_at_caret); @@ -1197,10 +1194,10 @@ static HRESULT exec_hyperlink(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, if (insert_link_at_caret) { /* add them to the document at the caret position */ - nsres = nsIHTMLEditor_InsertElementAtSelection(html_editor, anchor_elem, FALSE); + nsres = nsIHTMLEditor_InsertElementAtSelection(html_editor, (nsIDOMElement*)anchor_elem, FALSE); nsISelection_SelectAllChildren(nsselection, (nsIDOMNode*)anchor_elem); }else /* add them around the selection using the magic provided to us by nsIHTMLEditor */ - nsres = nsIHTMLEditor_InsertLinkAroundSelection(html_editor, anchor_elem); + nsres = nsIHTMLEditor_InsertLinkAroundSelection(html_editor, (nsIDOMElement*)anchor_elem); nsIHTMLEditor_Release(html_editor); hres = NS_SUCCEEDED(nsres) ? S_OK : E_FAIL;

1 0

Nikolay Sivov : gdi32: Prevent possible buffer overrun.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: dd0a7078e0acd55f9cc5ac0afbf6342af8a53ae4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd0a7078e0acd55f9cc5ac0af… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Mon Oct 19 23:40:28 2009 +0400 gdi32: Prevent possible buffer overrun. --- dlls/gdi32/font.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index c81a9c8..ed64166 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -2596,13 +2596,13 @@ BOOL WINAPI TranslateCharsetInfo( int index = 0; switch (flags) { case TCI_SRCFONTSIG: - while (!(*lpSrc>>index & 0x0001) && index<MAXTCIINDEX) index++; + while (index < MAXTCIINDEX && !(*lpSrc>>index & 0x0001)) index++; break; case TCI_SRCCODEPAGE: - while (PtrToUlong(lpSrc) != FONT_tci[index].ciACP && index < MAXTCIINDEX) index++; + while (index < MAXTCIINDEX && PtrToUlong(lpSrc) != FONT_tci[index].ciACP) index++; break; case TCI_SRCCHARSET: - while (PtrToUlong(lpSrc) != FONT_tci[index].ciCharset && index < MAXTCIINDEX) index++; + while (index < MAXTCIINDEX && PtrToUlong(lpSrc) != FONT_tci[index].ciCharset) index++; break; default: return FALSE;

1 0

Jacek Caban : mshtml: Use create_nselem in IHTMLOptionFactory::create.
by Alexandre Julliard Oct. 20, 2009

Oct. 20, 2009

Module: wine Branch: master Commit: dd04cbc53cc4b73ff12f901e73ccc309059e4191 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd04cbc53cc4b73ff12f901e7… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 19 23:04:36 2009 +0200 mshtml: Use create_nselem in IHTMLOptionFactory::create. --- dlls/mshtml/htmloption.c | 20 +++++++------------- 1 files changed, 7 insertions(+), 13 deletions(-) diff --git a/dlls/mshtml/htmloption.c b/dlls/mshtml/htmloption.c index 877eef2..e034d9d 100644 --- a/dlls/mshtml/htmloption.c +++ b/dlls/mshtml/htmloption.c @@ -448,9 +448,7 @@ static HRESULT WINAPI HTMLOptionElementFactory_create(IHTMLOptionElementFactory IHTMLOptionElement **optelem) { HTMLOptionElementFactory *This = HTMLOPTFACTORY_THIS(iface); - nsIDOMElement *nselem; - nsAString option_str; - nsresult nsres; + nsIDOMHTMLElement *nselem; HRESULT hres; static const PRUnichar optionW[] = {'O','P','T','I','O','N',0}; @@ -458,24 +456,20 @@ static HRESULT WINAPI HTMLOptionElementFactory_create(IHTMLOptionElementFactory TRACE("(%p)->(%s %s %s %s %p)\n", This, debugstr_variant(&text), debugstr_variant(&value), debugstr_variant(&defaultselected), debugstr_variant(&selected), optelem); - if(!This->window || !This->window->doc || !This->window->doc->basedoc.nsdoc) { - WARN("NULL nsdoc\n"); + if(!This->window || !This->window->doc) { + WARN("NULL doc\n"); return E_UNEXPECTED; } *optelem = NULL; - nsAString_Init(&option_str, optionW); - nsres = nsIDOMHTMLDocument_CreateElement(This->window->doc->basedoc.nsdoc, &option_str, &nselem); - nsAString_Finish(&option_str); - if(NS_FAILED(nsres)) { - ERR("CreateElement failed: %08x\n", nsres); - return E_FAIL; - } + hres = create_nselem(This->window->doc, optionW, &nselem); + if(FAILED(hres)) + return hres; hres = IHTMLDOMNode_QueryInterface(HTMLDOMNODE(get_node(This->window->doc, (nsIDOMNode*)nselem, TRUE)), &IID_IHTMLOptionElement, (void**)optelem); - nsIDOMElement_Release(nselem); + nsIDOMHTMLElement_Release(nselem); if(V_VT(&text) == VT_BSTR) IHTMLOptionElement_put_text(*optelem, V_BSTR(&text));

1 0