November 2009 - Wine-Commits

Detlef Riekenberg : advapi32: Dump the guid in a FIXME.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 84d24e5de5dc7dbfbc99290f13c3eb20db74f1dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=84d24e5de5dc7dbfbc99290f1… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Sun Nov 15 17:35:45 2009 +0100 advapi32: Dump the guid in a FIXME. --- dlls/advapi32/eventlog.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/advapi32/eventlog.c b/dlls/advapi32/eventlog.c index d336f74..a5d1837 100644 --- a/dlls/advapi32/eventlog.c +++ b/dlls/advapi32/eventlog.c @@ -717,8 +717,8 @@ ULONG WINAPI RegisterTraceGuidsW( WMIDPREQUEST RequestAddress, PTRACE_GUID_REGISTRATION TraceGuidReg, LPCWSTR MofImagePath, LPCWSTR MofResourceName, PTRACEHANDLE RegistrationHandle ) { - FIXME("%p %p %p %u %p %s %s %p\n", RequestAddress, RequestContext, - ControlGuid, GuidCount, TraceGuidReg, debugstr_w(MofImagePath), + FIXME("(%p, %p, %s, %u, %p, %s, %s, %p,)\n", RequestAddress, RequestContext, + debugstr_guid(ControlGuid), GuidCount, TraceGuidReg, debugstr_w(MofImagePath), debugstr_w(MofResourceName), RegistrationHandle); return ERROR_CALL_NOT_IMPLEMENTED; } @@ -736,8 +736,8 @@ ULONG WINAPI RegisterTraceGuidsA( WMIDPREQUEST RequestAddress, PTRACE_GUID_REGISTRATION TraceGuidReg, LPCSTR MofImagePath, LPCSTR MofResourceName, PTRACEHANDLE RegistrationHandle ) { - FIXME("%p %p %p %u %p %s %s %p\n", RequestAddress, RequestContext, - ControlGuid, GuidCount, TraceGuidReg, debugstr_a(MofImagePath), + FIXME("(%p, %p, %s, %u, %p, %s, %s, %p,)\n", RequestAddress, RequestContext, + debugstr_guid(ControlGuid), GuidCount, TraceGuidReg, debugstr_a(MofImagePath), debugstr_a(MofResourceName), RegistrationHandle); return ERROR_CALL_NOT_IMPLEMENTED; }

1 0

Marcus Meissner : comctl32: Removed useless NULL check (Coverity).
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: c2e0226d2f294fa3b925e21a07014f1d63782193 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c2e0226d2f294fa3b925e21a0… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Nov 15 16:57:11 2009 +0100 comctl32: Removed useless NULL check (Coverity). --- dlls/comctl32/imagelist.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index 82d2664..a8101e6 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -673,7 +673,7 @@ ImageList_Create (INT cx, INT cy, UINT flags, return himl; cleanup: - if (himl) ImageList_Destroy(himl); + ImageList_Destroy(himl); return NULL; }

1 0

Francois Gouget : rsaenh/tests: Add a trailing '\n' to an ok() call.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 6e407cccb846c9d113bd2e47a7008ecfb6796fa6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6e407cccb846c9d113bd2e47a… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Nov 14 15:55:59 2009 +0100 rsaenh/tests: Add a trailing '\n' to an ok() call. --- dlls/rsaenh/tests/rsaenh.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/rsaenh/tests/rsaenh.c b/dlls/rsaenh/tests/rsaenh.c index e59ad95..4d57b25 100644 --- a/dlls/rsaenh/tests/rsaenh.c +++ b/dlls/rsaenh/tests/rsaenh.c @@ -2085,7 +2085,7 @@ static void test_rsa_round_trip(void) if (result) { ok(dataLen == sizeof(test_string), "unexpected size %d\n", dataLen); - ok(!memcmp(data, test_string, sizeof(test_string)), "unexpected value"); + ok(!memcmp(data, test_string, sizeof(test_string)), "unexpected value\n"); } CryptReleaseContext(prov, 0);

1 0

Francois Gouget : shell32: Make GetFileNameFromBrowse{A,W}() static.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 8a00aaaa50e1571556fa3e9bc30073ff16abad5f URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a00aaaa50e1571556fa3e9bc… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Nov 14 15:52:55 2009 +0100 shell32: Make GetFileNameFromBrowse{A,W}() static. --- dlls/shell32/shellord.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/shellord.c b/dlls/shell32/shellord.c index fd942f7..29b77df 100644 --- a/dlls/shell32/shellord.c +++ b/dlls/shell32/shellord.c @@ -169,7 +169,7 @@ DWORD WINAPI ParseFieldAW(LPCVOID src, DWORD nField, LPVOID dst, DWORD len) /************************************************************************* * GetFileNameFromBrowseA [internal] */ -BOOL WINAPI GetFileNameFromBrowseA( +static BOOL GetFileNameFromBrowseA( HWND hwndOwner, LPSTR lpstrFile, DWORD nMaxFile, @@ -216,7 +216,7 @@ BOOL WINAPI GetFileNameFromBrowseA( /************************************************************************* * GetFileNameFromBrowseW [internal] */ -BOOL WINAPI GetFileNameFromBrowseW( +static BOOL GetFileNameFromBrowseW( HWND hwndOwner, LPWSTR lpstrFile, DWORD nMaxFile,

1 0

Stefan Leichter : kernel32: Added stub for CreateMemoryResourceNotification .
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 7f1fe90e7f45433fc2f2f6fc130687262040e9ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f1fe90e7f45433fc2f2f6fc1… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Sat Nov 14 09:58:47 2009 +0100 kernel32: Added stub for CreateMemoryResourceNotification. --- dlls/kernel32/kernel32.spec | 2 +- dlls/kernel32/sync.c | 12 ++++++++++++ include/winbase.h | 5 +++++ 3 files changed, 18 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 7e278b5..aad5e79 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -236,7 +236,7 @@ @ stub CreateKernelThread @ stdcall CreateMailslotA(ptr long long ptr) @ stdcall CreateMailslotW(ptr long long ptr) -# @ stub CreateMemoryResourceNotification +@ stdcall CreateMemoryResourceNotification(long) @ stdcall CreateMutexA(ptr long str) @ stdcall CreateMutexExA(ptr str long long) @ stdcall CreateMutexExW(ptr wstr long long) diff --git a/dlls/kernel32/sync.c b/dlls/kernel32/sync.c index 8330d4a..8918f3d 100644 --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -2171,6 +2171,18 @@ BOOL WINAPI BindIoCompletionCallback( HANDLE FileHandle, LPOVERLAPPED_COMPLETION return FALSE; } + +/*********************************************************************** + * CreateMemoryResourceNotification (KERNEL32.@) + */ +HANDLE WINAPI CreateMemoryResourceNotification(MEMORY_RESOURCE_NOTIFICATION_TYPE nt) +{ + FIXME("(%d) stub\n", nt); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return NULL; +} + + #ifdef __i386__ /*********************************************************************** diff --git a/include/winbase.h b/include/winbase.h index 0b4ee17..8298cbd 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -501,6 +501,10 @@ typedef struct tagMEMORYSTATUSEX { } MEMORYSTATUSEX, *LPMEMORYSTATUSEX; #include <poppack.h> +typedef enum _MEMORY_RESOURCE_NOTIFICATION_TYPE { + LowMemoryResourceNotification, + HighMemoryResourceNotification +} MEMORY_RESOURCE_NOTIFICATION_TYPE; #ifndef _SYSTEMTIME_ #define _SYSTEMTIME_ @@ -1391,6 +1395,7 @@ WINBASEAPI HANDLE WINAPI CreateJobObjectW(LPSECURITY_ATTRIBUTES,LPCWSTR); WINBASEAPI HANDLE WINAPI CreateMailslotA(LPCSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES); WINBASEAPI HANDLE WINAPI CreateMailslotW(LPCWSTR,DWORD,DWORD,LPSECURITY_ATTRIBUTES); #define CreateMailslot WINELIB_NAME_AW(CreateMailslot) +WINBASEAPI HANDLE WINAPI CreateMemoryResourceNotification(MEMORY_RESOURCE_NOTIFICATION_TYPE); WINBASEAPI HANDLE WINAPI CreateMutexA(LPSECURITY_ATTRIBUTES,BOOL,LPCSTR); WINBASEAPI HANDLE WINAPI CreateMutexW(LPSECURITY_ATTRIBUTES,BOOL,LPCWSTR); #define CreateMutex WINELIB_NAME_AW(CreateMutex)

1 0

Andrew Eikum : mshtml: Implement IHTMLWindow2::get_parent.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 75b58fb537a0ead31bd0bb9309161da0fc72e105 URL: http://source.winehq.org/git/wine.git/?a=commit;h=75b58fb537a0ead31bd0bb930… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Nov 13 14:13:12 2009 -0600 mshtml: Implement IHTMLWindow2::get_parent. --- dlls/mshtml/htmlwindow.c | 11 +++++++++-- dlls/mshtml/tests/dom.c | 25 +++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 41c5cbe..073a5ae 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -696,8 +696,15 @@ static HRESULT WINAPI HTMLWindow2_get_name(IHTMLWindow2 *iface, BSTR *p) static HRESULT WINAPI HTMLWindow2_get_parent(IHTMLWindow2 *iface, IHTMLWindow2 **p) { HTMLWindow *This = HTMLWINDOW2_THIS(iface); - FIXME("(%p)->(%p)\n", This, p); - return E_NOTIMPL; + TRACE("(%p)->(%p)\n", This, p); + + if(This->parent) { + *p = HTMLWINDOW2(This->parent); + IHTMLWindow2_AddRef(*p); + }else + *p = NULL; + + return S_OK; } static HRESULT WINAPI HTMLWindow2_open(IHTMLWindow2 *iface, BSTR url, BSTR name, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index a75f9e1..cf69c63 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -5554,6 +5554,8 @@ static void test_cond_comment(IHTMLDocument2 *doc) static void test_frame(IDispatch *disp, const char *exp_id) { + IHTMLWindow2 *frame2, *parent; + IHTMLDocument2 *parent_doc; IHTMLWindow4 *frame; IHTMLFrameBase *frame_elem; IHTMLElement *html_elem; @@ -5582,6 +5584,29 @@ static void test_frame(IDispatch *disp, const char *exp_id) ok(!strcmp_wa(bstr, exp_id), "Expected ID: \"%s\", found ID: %s\n", exp_id, wine_dbgstr_w(bstr)); IHTMLElement_Release(html_elem); SysFreeString(bstr); + + hres = IDispatch_QueryInterface(disp, &IID_IHTMLWindow2, (void**)&frame2); + ok(hres == S_OK, "Could not get IHTMLWindow2 interface: 0x%08x\n", hres); + if(FAILED(hres)) + return; + + hres = IHTMLWindow2_get_parent(frame2, &parent); + ok(hres == S_OK, "IHTMLWindow2_get_parent failed: 0x%08x\n", hres); + IHTMLWindow2_Release(frame2); + if(FAILED(hres)) + return; + + hres = IHTMLWindow2_get_document(parent, &parent_doc); + ok(hres == S_OK, "IHTMLWindow2_get_document failed: 0x%08x\n", hres); + IHTMLWindow2_Release(parent); + if(FAILED(hres)) + return; + + hres = IHTMLDocument2_get_title(parent_doc, &bstr); + ok(hres == S_OK, "IHTMLDocument2_get_title failed: 0x%08x\n", hres); + ok(!strcmp_wa(bstr, "frameset test"), "Did not get the right parent. Expected \"frameset test\", found %s\n", wine_dbgstr_w(bstr)); + IHTMLDocument2_Release(parent_doc); + SysFreeString(bstr); } static void test_frameset(IHTMLDocument2 *doc)

1 0

Stefan Leichter : setupapi/tests: Check the buffer content returned from SetupGetInfFileListW test.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 7f2943e712f42932a5e4a76c1c10671c5f49f667 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f2943e712f42932a5e4a76c1… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Fri Nov 13 23:56:57 2009 +0100 setupapi/tests: Check the buffer content returned from SetupGetInfFileListW test. --- dlls/setupapi/tests/install.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/setupapi/tests/install.c b/dlls/setupapi/tests/install.c index 35514d5..9aa5a91 100644 --- a/dlls/setupapi/tests/install.c +++ b/dlls/setupapi/tests/install.c @@ -35,6 +35,7 @@ #include "wine/test.h" static const char inffile[] = "test.inf"; +static const WCHAR inffileW[] = {'t','e','s','t','.','i','n','f',0}; static char CURR_DIR[MAX_PATH]; /* Notes on InstallHinfSectionA/W: @@ -470,12 +471,13 @@ cleanup: static void test_inffilelist(void) { static const char inffile2[] = "test2.inf"; + static const WCHAR inffile2W[] = {'t','e','s','t','2','.','i','n','f',0}; static const char invalid_inf[] = "invalid.inf"; static const char *inf = "[Version]\n" "Signature=\"$Chicago$\""; - WCHAR *ptr; + WCHAR *p, *ptr; WCHAR dir[MAX_PATH] = { 0 }; WCHAR buffer[MAX_PATH] = { 0 }; DWORD expected, outsize; @@ -560,7 +562,9 @@ static void test_inffilelist(void) todo_wine ok(expected == outsize, "expected required buffersize to be %d, got %d\n", expected, outsize); - + for(p = buffer; lstrlenW(p) && (outsize > (p - buffer)); p+=lstrlenW(p) + 1) + ok(!lstrcmpW(p,inffile2W) || !lstrcmpW(p,inffileW), + "unexpected filename %s\n",wine_dbgstr_w(p)); DeleteFile(inffile); DeleteFile(inffile2);

1 0

Francois Gouget : oledb32/tests: Add a trailing '\n' to an ok() call.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 9b329b2ed2fe4a16aea8358ada719484eaf280bd URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b329b2ed2fe4a16aea8358ad… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Nov 14 15:56:02 2009 +0100 oledb32/tests: Add a trailing '\n' to an ok() call. --- dlls/oledb32/tests/marshal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/oledb32/tests/marshal.c b/dlls/oledb32/tests/marshal.c index 67fc7fd..587b8b6 100644 --- a/dlls/oledb32/tests/marshal.c +++ b/dlls/oledb32/tests/marshal.c @@ -243,7 +243,7 @@ static void test_IDBProperties(void) propset_count = 1; hr = IDBProperties_GetProperties(pProxy, 0, NULL, &propset_count, &propsets); - ok(hr == S_OK, "IDBProperties_GetProperties failed with error 0x%08x", hr); + ok(hr == S_OK, "IDBProperties_GetProperties failed with error 0x%08x\n", hr); ok(propset_count == 1, "Expected propset_count of 1 but got %d\n", propset_count); ok(propsets->rgProperties[0].dwPropertyID == TEST_PROPID, "Expected property ID of 0x%x, but got 0x%x\n", TEST_PROPID, propsets->rgProperties[0].dwPropertyID);

1 0

Francois Gouget : mshtml: parse_complete() is unused so remove it.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 67c8e896a9e524bbf89d2eda8115470134531775 URL: http://source.winehq.org/git/wine.git/?a=commit;h=67c8e896a9e524bbf89d2eda8… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Nov 14 15:53:02 2009 +0100 mshtml: parse_complete() is unused so remove it. --- dlls/mshtml/task.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/task.c b/dlls/mshtml/task.c index e6b94a2..eae51ca 100644 --- a/dlls/mshtml/task.c +++ b/dlls/mshtml/task.c @@ -199,12 +199,6 @@ HRESULT clear_task_timer(HTMLDocument *doc, BOOL interval, DWORD id) return S_OK; } -void parse_complete(HTMLDocumentObj *doc) -{ - TRACE("(%p)\n", doc); - -} - static void call_timer_disp(IDispatch *disp) { DISPPARAMS dp = {NULL, NULL, 0, 0};

1 0

Francois Gouget : jscript: We don't need throw_eval_error() so remove it.
by Alexandre Julliard Nov. 16, 2009

Nov. 16, 2009

Module: wine Branch: master Commit: 5d06095dfb3b57d9c72bbf7f09326522585890ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d06095dfb3b57d9c72bbf7f0… Author: Francois Gouget <fgouget(a)free.fr> Date: Sat Nov 14 15:54:32 2009 +0100 jscript: We don't need throw_eval_error() so remove it. --- dlls/jscript/error.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/error.c b/dlls/jscript/error.c index 6c89d70..d8503f1 100644 --- a/dlls/jscript/error.c +++ b/dlls/jscript/error.c @@ -489,11 +489,6 @@ static HRESULT throw_error(script_ctx_t *ctx, jsexcept_t *ei, UINT id, const WCH return id; } -HRESULT throw_eval_error(script_ctx_t *ctx, jsexcept_t *ei, UINT id, const WCHAR *str) -{ - return throw_error(ctx, ei, id, str, ctx->eval_error_constr); -} - HRESULT throw_generic_error(script_ctx_t *ctx, jsexcept_t *ei, UINT id, const WCHAR *str) { return throw_error(ctx, ei, id, str, ctx->error_constr);

1 0