December 2009 - Wine-Commits

Henri Verbeet : wined3d: Fix WINED3DRS_DEPTHBIAS handling.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 2c0edb94e3da37a736b73f1a647bd3c9863f2608 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2c0edb94e3da37a736b73f1a6… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 30 19:33:43 2009 +0100 wined3d: Fix WINED3DRS_DEPTHBIAS handling. --- dlls/wined3d/state.c | 30 ++++++++++++++++++++++-------- 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 1c29dbf..8078118 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -1666,19 +1666,33 @@ static void state_scissor(DWORD state, IWineD3DStateBlockImpl *stateblock, struc } } +/* The Direct3D depth bias is specified in normalized depth coordinates. In + * OpenGL the bias is specified in units of "the smallest value that is + * guaranteed to produce a resolvable offset for a given implementation". To + * convert from D3D to GL we need to divide the D3D depth bias by that value. + * There's no practical way to retrieve that value from a given GL + * implementation, but the D3D application has essentially the same problem, + * which makes a guess of 1e-6f seem reasonable here. Note that + * SLOPESCALEDEPTHBIAS is a scaling factor for the depth slope, and doesn't + * need to be scaled. */ static void state_depthbias(DWORD state, IWineD3DStateBlockImpl *stateblock, struct wined3d_context *context) { - union { - DWORD d; - float f; - } tmpvalue; + if (stateblock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS] + || stateblock->renderState[WINED3DRS_DEPTHBIAS]) + { + union + { + DWORD d; + float f; + } scale_bias, const_bias; + + scale_bias.d = stateblock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]; + const_bias.d = stateblock->renderState[WINED3DRS_DEPTHBIAS]; - if(stateblock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS] || - stateblock->renderState[WINED3DRS_DEPTHBIAS]) { - tmpvalue.d = stateblock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]; glEnable(GL_POLYGON_OFFSET_FILL); checkGLcall("glEnable(GL_POLYGON_OFFSET_FILL)"); - glPolygonOffset(tmpvalue.f, *((float*)&stateblock->renderState[WINED3DRS_DEPTHBIAS])); + + glPolygonOffset(scale_bias.f, const_bias.f * 1e6f); checkGLcall("glPolygonOffset(...)"); } else { glDisable(GL_POLYGON_OFFSET_FILL);

1 0

Christian Costa : d3dxof: Enable referencing objects defined in current top-level object.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 39772f9749e8b73b0eff879099453d41b085d0cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=39772f9749e8b73b0eff87909… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Wed Dec 30 22:06:18 2009 +0100 d3dxof: Enable referencing objects defined in current top-level object. --- dlls/d3dxof/parsing.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index ec962b0..f4fb3d2 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1198,7 +1198,7 @@ static BOOL parse_object_parts(parse_buffer * buf, BOOL allow_optional) if (get_TOKEN(buf) != TOKEN_CBRACE) return FALSE; TRACE("Found optional reference %s\n", (char*)buf->value); - for (i = 0; i < buf->nb_pxo_globals; i++) + for (i = 0; i < (buf->nb_pxo_globals+1); i++) { for (j = 0; j < (buf->pxo_globals[i])[0].nb_subobjects; j++) { @@ -1207,7 +1207,7 @@ static BOOL parse_object_parts(parse_buffer * buf, BOOL allow_optional) } } _exit: - if (i == buf->nb_pxo_globals) + if (i == (buf->nb_pxo_globals+1)) { ERR("Reference to unknown object %s\n", (char*)buf->value); return FALSE;

1 0

Jacek Caban : jscript: Added a test using script dispatch after closing engine.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: b5290bde98100447c9b3e0b5d48b4fd9765b85f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5290bde98100447c9b3e0b5d… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Dec 30 19:49:45 2009 +0100 jscript: Added a test using script dispatch after closing engine. --- dlls/jscript/tests/jscript.c | 83 ++++++++++++++++++++++++++++++------------ 1 files changed, 60 insertions(+), 23 deletions(-) diff --git a/dlls/jscript/tests/jscript.c b/dlls/jscript/tests/jscript.c index ed94a89..006e055 100644 --- a/dlls/jscript/tests/jscript.c +++ b/dlls/jscript/tests/jscript.c @@ -203,37 +203,70 @@ static const IActiveScriptSiteVtbl ActiveScriptSiteVtbl = { static IActiveScriptSite ActiveScriptSite = { &ActiveScriptSiteVtbl }; -static void test_script_dispatch(IActiveScript *script, BOOL initialized) +static void test_script_dispatch(IDispatchEx *dispex) { - IDispatchEx *dispex; - IDispatch *disp; + DISPPARAMS dp = {NULL,NULL,0,0}; + EXCEPINFO ei; BSTR str; DISPID id; + VARIANT v; HRESULT hres; - disp = (void*)0xdeadbeef; - hres = IActiveScript_GetScriptDispatch(script, NULL, &disp); - if(!initialized) { - ok(hres == E_UNEXPECTED, "hres = %08x, expected E_UNEXPECTED\n", hres); - ok(!disp, "disp != NULL\n"); - return; - } + str = a2bstr("ActiveXObject"); + hres = IDispatchEx_GetDispID(dispex, str, fdexNameCaseSensitive, &id); + SysFreeString(str); + ok(hres == S_OK, "GetDispID failed: %08x\n", hres); - ok(hres == S_OK, "GetScriptDispatch failed: %08x\n", hres); - if(FAILED(hres)) - return; + str = a2bstr("Math"); + hres = IDispatchEx_GetDispID(dispex, str, fdexNameCaseSensitive, &id); + SysFreeString(str); + ok(hres == S_OK, "GetDispID failed: %08x\n", hres); - ok(disp != NULL, "disp == NULL\n"); - hres = IDispatch_QueryInterface(disp, &IID_IDispatchEx, (void**)&dispex); - IDispatch_Release(disp); - ok(hres == S_OK, "Could not get IDispatchEx interface: %08x\n", hres); + memset(&ei, 0, sizeof(ei)); + hres = IDispatchEx_InvokeEx(dispex, id, 0, DISPATCH_PROPERTYGET, &dp, &v, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + ok(V_VT(&v) == VT_DISPATCH, "V_VT(v) = %d\n", V_VT(&v)); + ok(V_DISPATCH(&v) != NULL, "V_DISPATCH(v) = NULL\n"); + VariantClear(&v); - str = a2bstr("ActiveXObject"); + str = a2bstr("String"); hres = IDispatchEx_GetDispID(dispex, str, fdexNameCaseSensitive, &id); SysFreeString(str); ok(hres == S_OK, "GetDispID failed: %08x\n", hres); - IDispatchEx_Release(dispex); + memset(&ei, 0, sizeof(ei)); + hres = IDispatchEx_InvokeEx(dispex, id, 0, DISPATCH_PROPERTYGET, &dp, &v, &ei, NULL); + ok(hres == S_OK, "InvokeEx failed: %08x\n", hres); + ok(V_VT(&v) == VT_DISPATCH, "V_VT(v) = %d\n", V_VT(&v)); + ok(V_DISPATCH(&v) != NULL, "V_DISPATCH(v) = NULL\n"); + VariantClear(&v); +} + +static IDispatchEx *get_script_dispatch(IActiveScript *script) +{ + IDispatchEx *dispex; + IDispatch *disp; + HRESULT hres; + + disp = (void*)0xdeadbeef; + hres = IActiveScript_GetScriptDispatch(script, NULL, &disp); + ok(hres == S_OK, "GetScriptDispatch failed: %08x\n", hres); + + IDispatch_QueryInterface(disp, &IID_IDispatchEx, (void**)&dispex); + IDispatch_Release(disp); + ok(hres == S_OK, "Could not get IDispatch iface: %08x\n", hres); + return dispex; +} + +static void test_no_script_dispatch(IActiveScript *script) +{ + IDispatch *disp; + HRESULT hres; + + disp = (void*)0xdeadbeef; + hres = IActiveScript_GetScriptDispatch(script, NULL, &disp); + ok(hres == E_UNEXPECTED, "hres = %08x, expected E_UNEXPECTED\n", hres); + ok(!disp, "disp != NULL\n"); } static void test_safety(IUnknown *unk) @@ -342,6 +375,7 @@ static void test_jscript(void) { IActiveScriptParse *parse; IActiveScript *script; + IDispatchEx *dispex; IUnknown *unk; ULONG ref; HRESULT hres; @@ -377,7 +411,7 @@ static void test_jscript(void) ok(hres == E_POINTER, "SetScriptSite failed: %08x, expected E_POINTER\n", hres); test_state(script, SCRIPTSTATE_UNINITIALIZED); - test_script_dispatch(script, FALSE); + test_no_script_dispatch(script); SET_EXPECT(GetLCID); SET_EXPECT(OnStateChange_INITIALIZED); @@ -391,7 +425,8 @@ static void test_jscript(void) hres = IActiveScript_SetScriptSite(script, &ActiveScriptSite); ok(hres == E_UNEXPECTED, "SetScriptSite failed: %08x, expected E_UNEXPECTED\n", hres); - test_script_dispatch(script, TRUE); + dispex = get_script_dispatch(script); + test_script_dispatch(dispex); SET_EXPECT(OnStateChange_STARTED); hres = IActiveScript_SetScriptState(script, SCRIPTSTATE_STARTED); @@ -406,7 +441,9 @@ static void test_jscript(void) CHECK_CALLED(OnStateChange_CLOSED); test_state(script, SCRIPTSTATE_CLOSED); - test_script_dispatch(script, FALSE); + test_no_script_dispatch(script); + test_script_dispatch(dispex); + IDispatchEx_Release(dispex); IUnknown_Release(parse); IActiveScript_Release(script); @@ -474,7 +511,7 @@ static void test_jscript2(void) CHECK_CALLED(OnStateChange_CLOSED); test_state(script, SCRIPTSTATE_CLOSED); - test_script_dispatch(script, FALSE); + test_no_script_dispatch(script); IUnknown_Release(parse); IActiveScript_Release(script);

1 0

Henri Verbeet : wined3d: Merge vertexshader_set_function() and pixelshader_set_function().
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 14da44aa364539d2c2d392c042921cc430b21c47 URL: http://source.winehq.org/git/wine.git/?a=commit;h=14da44aa364539d2c2d392c04… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 30 19:33:42 2009 +0100 wined3d: Merge vertexshader_set_function() and pixelshader_set_function(). --- dlls/wined3d/shader.c | 188 +++++++++++++++++++------------------------------ 1 files changed, 72 insertions(+), 116 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=14da44aa364539d2c2d39…

1 0

Henri Verbeet : wined3d: Always handle WINED3DSPR_INPUT registers as input registers in shader_get_registers_used ().
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 736aaf7d09de36223f156b864fccef9093b57dba URL: http://source.winehq.org/git/wine.git/?a=commit;h=736aaf7d09de36223f156b864… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 30 19:33:40 2009 +0100 wined3d: Always handle WINED3DSPR_INPUT registers as input registers in shader_get_registers_used(). The "attributes" vertexshader field is now derived from the input signature, and only used to speed up matching D3D9 vertex declaration elements to shader inputs. D3D8 and D3D10 both explicitly specify input registers. --- dlls/wined3d/baseshader.c | 64 ++++++++++++++++++++------------------- dlls/wined3d/shader.c | 15 ++++++++- dlls/wined3d/wined3d_private.h | 5 ++- 3 files changed, 49 insertions(+), 35 deletions(-) diff --git a/dlls/wined3d/baseshader.c b/dlls/wined3d/baseshader.c index bb94a5a..14416c4 100644 --- a/dlls/wined3d/baseshader.c +++ b/dlls/wined3d/baseshader.c @@ -363,26 +363,26 @@ static unsigned int get_instr_extra_regcount(enum WINED3D_SHADER_INSTRUCTION_HAN } } -static const char *shader_semantic_name_from_usage(WINED3DDECLUSAGE usage) +static const char *semantic_names[] = { - static const char *semantic_names[] = - { - /* WINED3DDECLUSAGE_POSITION */ "SV_POSITION", - /* WINED3DDECLUSAGE_BLENDWEIGHT */ "BLENDWEIGHT", - /* WINED3DDECLUSAGE_BLENDINDICES */ "BLENDINDICES", - /* WINED3DDECLUSAGE_NORMAL */ "NORMAL", - /* WINED3DDECLUSAGE_PSIZE */ "PSIZE", - /* WINED3DDECLUSAGE_TEXCOORD */ "TEXCOORD", - /* WINED3DDECLUSAGE_TANGENT */ "TANGENT", - /* WINED3DDECLUSAGE_BINORMAL */ "BINORMAL", - /* WINED3DDECLUSAGE_TESSFACTOR */ "TESSFACTOR", - /* WINED3DDECLUSAGE_POSITIONT */ "POSITIONT", - /* WINED3DDECLUSAGE_COLOR */ "COLOR", - /* WINED3DDECLUSAGE_FOG */ "FOG", - /* WINED3DDECLUSAGE_DEPTH */ "DEPTH", - /* WINED3DDECLUSAGE_SAMPLE */ "SAMPLE", - }; + /* WINED3DDECLUSAGE_POSITION */ "SV_POSITION", + /* WINED3DDECLUSAGE_BLENDWEIGHT */ "BLENDWEIGHT", + /* WINED3DDECLUSAGE_BLENDINDICES */ "BLENDINDICES", + /* WINED3DDECLUSAGE_NORMAL */ "NORMAL", + /* WINED3DDECLUSAGE_PSIZE */ "PSIZE", + /* WINED3DDECLUSAGE_TEXCOORD */ "TEXCOORD", + /* WINED3DDECLUSAGE_TANGENT */ "TANGENT", + /* WINED3DDECLUSAGE_BINORMAL */ "BINORMAL", + /* WINED3DDECLUSAGE_TESSFACTOR */ "TESSFACTOR", + /* WINED3DDECLUSAGE_POSITIONT */ "POSITIONT", + /* WINED3DDECLUSAGE_COLOR */ "COLOR", + /* WINED3DDECLUSAGE_FOG */ "FOG", + /* WINED3DDECLUSAGE_DEPTH */ "DEPTH", + /* WINED3DDECLUSAGE_SAMPLE */ "SAMPLE", +}; +static const char *shader_semantic_name_from_usage(WINED3DDECLUSAGE usage) +{ if (usage >= sizeof(semantic_names) / sizeof(*semantic_names)) { FIXME("Unrecognized usage %#x\n", usage); @@ -392,6 +392,18 @@ static const char *shader_semantic_name_from_usage(WINED3DDECLUSAGE usage) return semantic_names[usage]; } +WINED3DDECLUSAGE shader_usage_from_semantic_name(const char *name) +{ + unsigned int i; + + for (i = 0; i < sizeof(semantic_names) / sizeof(*semantic_names); ++i) + { + if (!strcmp(name, semantic_names[i])) return i; + } + + return ~0U; +} + BOOL shader_match_semantic(const char *semantic_name, WINED3DDECLUSAGE usage) { return !strcmp(semantic_name, shader_semantic_name_from_usage(usage)); @@ -412,8 +424,7 @@ static void shader_signature_from_semantic(struct wined3d_shader_signature_eleme * as an address register. */ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3d_shader_frontend *fe, - struct shader_reg_maps *reg_maps, struct wined3d_shader_attribute *attributes, - struct wined3d_shader_signature_element *input_signature, + struct shader_reg_maps *reg_maps, struct wined3d_shader_signature_element *input_signature, struct wined3d_shader_signature_element *output_signature, const DWORD *byte_code, DWORD constf_size) { IWineD3DBaseShaderImpl* This = (IWineD3DBaseShaderImpl*) iface; @@ -473,19 +484,10 @@ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3 switch (semantic.reg.reg.type) { - /* Vshader: mark attributes used - * Pshader: mark 3.0 input registers used, save token */ + /* Mark input registers used. */ case WINED3DSPR_INPUT: reg_maps->input_registers |= 1 << semantic.reg.reg.idx; - if (shader_version.type == WINED3D_SHADER_TYPE_VERTEX) - { - attributes[semantic.reg.reg.idx].usage = semantic.usage; - attributes[semantic.reg.reg.idx].usage_idx = semantic.usage_idx; - } - else - { - shader_signature_from_semantic(&input_signature[semantic.reg.reg.idx], &semantic); - } + shader_signature_from_semantic(&input_signature[semantic.reg.reg.idx], &semantic); break; /* Vshader: mark 3.0 output registers used, save token */ diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 2e758ff..93e1a0e 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -288,6 +288,7 @@ static HRESULT vertexshader_set_function(IWineD3DVertexShaderImpl *shader, const struct wined3d_shader_frontend *fe; unsigned int i; HRESULT hr; + WORD map; TRACE("shader %p, byte_code %p, output_signature %p.\n", shader, byte_code, output_signature); @@ -317,10 +318,20 @@ static HRESULT vertexshader_set_function(IWineD3DVertexShaderImpl *shader, shader->min_rel_offset = device->d3d_vshader_constantF; shader->max_rel_offset = 0; hr = shader_get_registers_used((IWineD3DBaseShader *)shader, fe, - reg_maps, shader->attributes, NULL, shader->output_signature, + reg_maps, shader->input_signature, shader->output_signature, byte_code, device->d3d_vshader_constantF); if (FAILED(hr)) return hr; + + map = shader->baseShader.reg_maps.input_registers; + for (i = 0; map; map >>= 1, ++i) + { + if (!(map & 1) || !shader->baseShader.input_signature[i].semantic_name) continue; + + shader->attributes[i].usage = shader_usage_from_semantic_name(shader->input_signature[i].semantic_name); + shader->attributes[i].usage_idx = shader->input_signature[i].semantic_idx; + } + if (output_signature) { for (i = 0; i < output_signature->element_count; ++i) @@ -666,7 +677,7 @@ static HRESULT pixelshader_set_function(IWineD3DPixelShaderImpl *shader, /* Second pass: figure out which registers are used, what the semantics are, etc.. */ hr = shader_get_registers_used((IWineD3DBaseShader *)shader, fe, - reg_maps, NULL, shader->input_signature, NULL, + reg_maps, shader->input_signature, NULL, byte_code, device->d3d_pshader_constantF); if (FAILED(hr)) return hr; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index b22a7b2..64e1f05 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2647,8 +2647,7 @@ unsigned int shader_find_free_input_register(const struct shader_reg_maps *reg_m void shader_generate_main(IWineD3DBaseShader *iface, struct wined3d_shader_buffer *buffer, const shader_reg_maps *reg_maps, const DWORD *pFunction, void *backend_ctx) DECLSPEC_HIDDEN; HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3d_shader_frontend *fe, - struct shader_reg_maps *reg_maps, struct wined3d_shader_attribute *attributes, - struct wined3d_shader_signature_element *input_signature, + struct shader_reg_maps *reg_maps, struct wined3d_shader_signature_element *input_signature, struct wined3d_shader_signature_element *output_signature, const DWORD *byte_code, DWORD constf_size) DECLSPEC_HIDDEN; void shader_init(struct IWineD3DBaseShaderClass *shader, IWineD3DDeviceImpl *device, @@ -2656,6 +2655,7 @@ void shader_init(struct IWineD3DBaseShaderClass *shader, IWineD3DDeviceImpl *dev BOOL shader_match_semantic(const char *semantic_name, WINED3DDECLUSAGE usage) DECLSPEC_HIDDEN; const struct wined3d_shader_frontend *shader_select_frontend(DWORD version_token) DECLSPEC_HIDDEN; void shader_trace_init(const struct wined3d_shader_frontend *fe, void *fe_data, const DWORD *pFunction) DECLSPEC_HIDDEN; +WINED3DDECLUSAGE shader_usage_from_semantic_name(const char *semantic_name) DECLSPEC_HIDDEN; static inline BOOL shader_is_pshader_version(enum wined3d_shader_type type) { @@ -2731,6 +2731,7 @@ typedef struct IWineD3DVertexShaderImpl { /* Vertex shader input and output semantics */ struct wined3d_shader_attribute attributes[MAX_ATTRIBS]; + struct wined3d_shader_signature_element input_signature[max(MAX_ATTRIBS, MAX_REG_INPUT)]; struct wined3d_shader_signature_element output_signature[MAX_REG_OUTPUT]; UINT min_rel_offset, max_rel_offset;

1 0

Henri Verbeet : wined3d: Merge pixelshader.c and vertexshader.c.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 2b1ee87328cb5ac4b18360fd83e85cb221efa43e URL: http://source.winehq.org/git/wine.git/?a=commit;h=2b1ee87328cb5ac4b18360fd8… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 30 19:33:39 2009 +0100 wined3d: Merge pixelshader.c and vertexshader.c. --- dlls/wined3d/Makefile.in | 3 +- dlls/wined3d/pixelshader.c | 435 ------------------------ dlls/wined3d/shader.c | 788 +++++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/vertexshader.c | 374 -------------------- 4 files changed, 789 insertions(+), 811 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2b1ee87328cb5ac4b1836…

1 0

Henri Verbeet : wined3d: Move shader input/ output signatures to IWineD3DBaseShaderClass.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: b548e387aef1dcf71e88f784082b326faf63cbc0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b548e387aef1dcf71e88f7840… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 30 19:33:41 2009 +0100 wined3d: Move shader input/output signatures to IWineD3DBaseShaderClass. --- dlls/wined3d/arb_program_shader.c | 47 +++++++++++++++++++----------------- dlls/wined3d/glsl_shader.c | 11 ++++---- dlls/wined3d/shader.c | 11 ++++---- dlls/wined3d/wined3d_private.h | 8 +++--- 4 files changed, 41 insertions(+), 36 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=b548e387aef1dcf71e88f…

1 0

Rob Shearman : jscript: Make sure retv pointer is initialised in exec_source even if no value needs to be returned .
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 7db81aeb67ce1bba1ea8fcf9167ca0147e2cfe32 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7db81aeb67ce1bba1ea8fcf91… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Wed Dec 30 17:33:48 2009 +0000 jscript: Make sure retv pointer is initialised in exec_source even if no value needs to be returned. --- dlls/jscript/engine.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index b9c40ae..653aca3 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -493,8 +493,12 @@ HRESULT exec_source(exec_ctx_t *ctx, parser_ctx_t *parser, source_elements_t *so if(retv && (exec_type == EXECT_EVAL || rt.type == RT_RETURN)) *retv = val; - else + else { + if (retv) { + VariantInit(retv); + } VariantClear(&val); + } return S_OK; }

1 0

Rob Shearman : jscript: Make sure to initialise the string output parameter in run_exec.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 07183b28eb9a501c8da77a4295235b0690f9f0a2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07183b28eb9a501c8da77a429… Author: Rob Shearman <robertshearman(a)gmail.com> Date: Wed Dec 30 17:33:52 2009 +0000 jscript: Make sure to initialise the string output parameter in run_exec. --- dlls/jscript/regexp.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index ff9807b..05b6062 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -3642,6 +3642,9 @@ static HRESULT run_exec(script_ctx_t *ctx, vdisp_t *jsthis, VARIANT *arg, jsexce SysFreeString(string); set_last_index(regexp, 0); *ret = VARIANT_FALSE; + if(input) { + *input = NULL; + } return S_OK; }

1 0

Andrew Eikum : hlink: String target reference is actually moniker target' s display name.
by Alexandre Julliard Dec. 31, 2009

Dec. 31, 2009

Module: wine Branch: master Commit: 57a47b0833f7be226be8ed8d0407a250e6a02cc7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=57a47b0833f7be226be8ed8d0… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Dec 30 11:43:05 2009 -0600 hlink: String target reference is actually moniker target's display name. The original implementation treated the string target in IHlink as a separate entity from the moniker target. In reality, the string target is just the moniker target's display name and setting one reference also sets the other. --- dlls/hlink/hlink_main.c | 43 ++--------------- dlls/hlink/link.c | 65 +++++++++++++++++++------- dlls/hlink/tests/hlink.c | 114 +++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 165 insertions(+), 57 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=57a47b0833f7be226be8e…

1 0