December 2009 - Wine-Commits

Paul Chitescu : quartz: Only wait in IMediaEvent:: WaitForCompletion if the filter is running.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: e03b98ec68806a69e17c57e6cbe2aefee4910adc URL: http://source.winehq.org/git/wine.git/?a=commit;h=e03b98ec68806a69e17c57e6c… Author: Paul Chitescu <paulc(a)voip.null.ro> Date: Wed Dec 23 19:55:13 2009 +0200 quartz: Only wait in IMediaEvent::WaitForCompletion if the filter is running. --- dlls/quartz/filtergraph.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index 5377281..3e9a1da 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -4899,6 +4899,9 @@ static HRESULT WINAPI MediaEvent_WaitForCompletion(IMediaEventEx *iface, TRACE("(%p/%p)->(%d, %p)\n", This, iface, msTimeout, pEvCode); + if (This->state != State_Running) + return VFW_E_WRONG_STATE; + if (WaitForSingleObject(This->hEventCompletion, msTimeout) == WAIT_OBJECT_0) { *pEvCode = This->CompletionStatus;

1 0

Jeremy White : winspool: Test for failure using correct size.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 09401dd4b14cd7164e767d025f4d52c85a8dcaad URL: http://source.winehq.org/git/wine.git/?a=commit;h=09401dd4b14cd7164e767d025… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Wed Dec 23 11:21:17 2009 -0600 winspool: Test for failure using correct size. --- dlls/winspool.drv/info.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 8e4d714..a2dd798 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -4447,7 +4447,7 @@ BOOL WINAPI GetPrinterDriverW(HANDLE hPrinter, LPWSTR pEnvironment, if(pcbNeeded) *pcbNeeded = size + needed; TRACE("buffer space %d required %d\n", cbBuf, size + needed); - if(cbBuf >= needed) return TRUE; + if(cbBuf >= size + needed) return TRUE; SetLastError(ERROR_INSUFFICIENT_BUFFER); return FALSE; }

1 0

Jeremy White : winspool: Correctly zero printer driver buffer on failure, with tests.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: b806e13001b6908e3aa1180a8a32c55431e79f7f URL: http://source.winehq.org/git/wine.git/?a=commit;h=b806e13001b6908e3aa1180a8… Author: Jeremy White <jwhite(a)codeweavers.com> Date: Wed Dec 23 11:21:32 2009 -0600 winspool: Correctly zero printer driver buffer on failure, with tests. --- dlls/winspool.drv/info.c | 7 ++++++- dlls/winspool.drv/tests/info.c | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index a2dd798..4993a78 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -4388,6 +4388,8 @@ BOOL WINAPI GetPrinterDriverW(HANDLE hPrinter, LPWSTR pEnvironment, TRACE("(%p,%s,%d,%p,%d,%p)\n",hPrinter,debugstr_w(pEnvironment), Level,pDriverInfo,cbBuf, pcbNeeded); + if (cbBuf > 0) + ZeroMemory(pDriverInfo, cbBuf); if (!(name = get_opened_printer_name(hPrinter))) { SetLastError(ERROR_INVALID_HANDLE); @@ -4465,8 +4467,11 @@ BOOL WINAPI GetPrinterDriverA(HANDLE hPrinter, LPSTR pEnvironment, LPBYTE buf = NULL; if (cbBuf) + { + ZeroMemory(pDriverInfo, cbBuf); buf = HeapAlloc(GetProcessHeap(), 0, cbBuf); - + } + pwstrEnvW = asciitounicode(&pEnvW, pEnvironment); ret = GetPrinterDriverW(hPrinter, pwstrEnvW, Level, buf, cbBuf, pcbNeeded); diff --git a/dlls/winspool.drv/tests/info.c b/dlls/winspool.drv/tests/info.c index 5ab0ccd..f3b2d78 100644 --- a/dlls/winspool.drv/tests/info.c +++ b/dlls/winspool.drv/tests/info.c @@ -2414,6 +2414,14 @@ static void test_GetPrinterDriver(void) /* XP allocates memory for both ANSI and unicode names */ ok(filled >= calculated,"calculated %d != filled %d\n", calculated, filled); + + /* Obscure test - demonstrate that Windows zero fills the buffer, even on failure */ + if (di_2->pDataFile) + { + ret = GetPrinterDriver(hprn, NULL, level, buf, needed - 2, &filled); + ok(!ret, "level %d: GetPrinterDriver succeeded with less buffer than it should\n", level); + ok(di_2->pDataFile == NULL, "Even on failure, GetPrinterDriver clears the buffer to zeros\n"); + } } HeapFree(GetProcessHeap(), 0, buf);

1 0

Nikolay Sivov : comctl32/comboex: Use subclass chain for internally used controls.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: ecc89bf6eff47d21a54b208fc2e7a646e06db2cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=ecc89bf6eff47d21a54b208fc… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Wed Dec 23 22:50:26 2009 +0300 comctl32/comboex: Use subclass chain for internally used controls. --- dlls/comctl32/comboex.c | 94 ++++++++++++++++------------------------- dlls/comctl32/tests/comboex.c | 25 +++++++++++ 2 files changed, 61 insertions(+), 58 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ecc89bf6eff47d21a54b2…

1 0

Paul Chitescu : quartz: Implement NullRenderer's IBaseFilter::FindPin.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 7251e91d4da20617badd27c6b87163bfb0f749a8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7251e91d4da20617badd27c6b… Author: Paul Chitescu <paulc(a)voip.null.ro> Date: Wed Dec 23 18:17:38 2009 +0200 quartz: Implement NullRenderer's IBaseFilter::FindPin. --- dlls/quartz/nullrenderer.c | 15 +++++++++++---- 1 files changed, 11 insertions(+), 4 deletions(-) diff --git a/dlls/quartz/nullrenderer.c b/dlls/quartz/nullrenderer.c index f774012..d2aedfa 100644 --- a/dlls/quartz/nullrenderer.c +++ b/dlls/quartz/nullrenderer.c @@ -43,6 +43,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(quartz); static const WCHAR wcsInputPinName[] = {'i','n','p','u','t',' ','p','i','n',0}; +static const WCHAR wcsAltInputPinName[] = {'I','n',0}; static const IBaseFilterVtbl NullRenderer_Vtbl; static const IUnknownVtbl IInner_VTable; @@ -472,11 +473,17 @@ static HRESULT WINAPI NullRenderer_FindPin(IBaseFilter * iface, LPCWSTR Id, IPin TRACE("(%p/%p)->(%p,%p)\n", This, iface, debugstr_w(Id), ppPin); - FIXME("NullRenderer::FindPin(...)\n"); + if (!Id || !ppPin) + return E_POINTER; - /* FIXME: critical section */ - - return E_NOTIMPL; + if (!lstrcmpiW(Id,wcsInputPinName) || !lstrcmpiW(Id,wcsAltInputPinName)) + { + *ppPin = (IPin *)This->pInputPin; + IPin_AddRef(*ppPin); + return S_OK; + } + *ppPin = NULL; + return VFW_E_NOT_FOUND; } static HRESULT WINAPI NullRenderer_QueryFilterInfo(IBaseFilter * iface, FILTER_INFO *pInfo)

1 0

Alexandre Julliard : winhttp: Fix pointer cast warnings on 64-bit.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 07062b03405dc6621dbf32b3f6c4e8ee306f5975 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07062b03405dc6621dbf32b3f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 23 21:25:42 2009 +0100 winhttp: Fix pointer cast warnings on 64-bit. --- dlls/winhttp/net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c index 3faa41c..dd8b56c 100644 --- a/dlls/winhttp/net.c +++ b/dlls/winhttp/net.c @@ -361,7 +361,7 @@ static int netconn_secure_verify( int preverify_ok, X509_STORE_CTX *ctx ) if (!endCert) ret = FALSE; if (ret) { - DWORD err = netconn_verify_cert( endCert, store, server ); + DWORD_PTR err = netconn_verify_cert( endCert, store, server ); if (err) { @@ -641,7 +641,7 @@ BOOL netconn_secure_connect( netconn_t *conn, WCHAR *hostname ) { DWORD err; - err = (DWORD)pSSL_get_ex_data( conn->ssl_conn, error_idx ); + err = (DWORD_PTR)pSSL_get_ex_data( conn->ssl_conn, error_idx ); if (!err) err = ERROR_WINHTTP_SECURE_CHANNEL_ERROR; ERR("couldn't verify server certificate (%d)\n", err); set_last_error( err );

1 0

Alexandre Julliard : user32: Add a WoW wrapper for message waiting to allow releasing the Win16 lock in the 16-bit code .
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: b33c5f163aa3d3d86502eac769600e3c98fb57ce URL: http://source.winehq.org/git/wine.git/?a=commit;h=b33c5f163aa3d3d86502eac76… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 24 12:02:10 2009 +0100 user32: Add a WoW wrapper for message waiting to allow releasing the Win16 lock in the 16-bit code. --- dlls/user32/controls.h | 2 ++ dlls/user32/message.c | 21 ++++----------------- dlls/user32/msg16.c | 15 +++++++++++++++ dlls/user32/winproc.c | 7 +++++++ 4 files changed, 28 insertions(+), 17 deletions(-) diff --git a/dlls/user32/controls.h b/dlls/user32/controls.h index e8c7bdb..f4d814b 100644 --- a/dlls/user32/controls.h +++ b/dlls/user32/controls.h @@ -96,6 +96,7 @@ struct wow_handlers16 LRESULT (*mdiclient_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*scrollbar_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*static_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); + DWORD (*wait_message)(DWORD,const HANDLE*,DWORD,DWORD,DWORD); HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,BOOL); LRESULT (*call_window_proc)(HWND,UINT,WPARAM,LPARAM,LRESULT*,void*); LRESULT (*call_dialog_proc)(HWND,UINT,WPARAM,LPARAM,LRESULT*,void*); @@ -114,6 +115,7 @@ struct wow_handlers32 LRESULT (*mdiclient_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*scrollbar_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*static_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); + DWORD (*wait_message)(DWORD,const HANDLE*,DWORD,DWORD,DWORD); HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,BOOL); HWND (*get_win_handle)(HWND); WNDPROC (*alloc_winproc)(WNDPROC,BOOL); diff --git a/dlls/user32/message.c b/dlls/user32/message.c index d6fd5af..48c8068 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -2266,7 +2266,6 @@ static void wait_message_reply( UINT flags ) for (;;) { unsigned int wake_bits = 0; - DWORD dwlc, res; SERVER_START_REQ( set_queue_mask ) { @@ -2286,12 +2285,7 @@ static void wait_message_reply( UINT flags ) continue; } - /* now wait for it */ - - ReleaseThunkLock( &dwlc ); - res = USER_Driver->pMsgWaitForMultipleObjectsEx( 1, &server_queue, - INFINITE, QS_SENDMESSAGE, 0 ); - if (dwlc) RestoreThunkLock( dwlc ); + wow_handlers.wait_message( 1, &server_queue, INFINITE, QS_SENDMESSAGE, 0 ); } } @@ -2955,11 +2949,7 @@ BOOL WINAPI GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT last ) while (!peek_message( msg, hwnd, first, last, PM_REMOVE | (mask << 16), mask )) { - DWORD dwlc; - - ReleaseThunkLock( &dwlc ); - USER_Driver->pMsgWaitForMultipleObjectsEx( 1, &server_queue, INFINITE, mask, 0 ); - if (dwlc) RestoreThunkLock( dwlc ); + wow_handlers.wait_message( 1, &server_queue, INFINITE, mask, 0 ); } return (msg->message != WM_QUIT); @@ -3269,7 +3259,7 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, CONST HANDLE *pHandles, DWORD timeout, DWORD mask, DWORD flags ) { HANDLE handles[MAXIMUM_WAIT_OBJECTS]; - DWORD i, ret, lock; + DWORD i; if (count > MAXIMUM_WAIT_OBJECTS-1) { @@ -3291,10 +3281,7 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, CONST HANDLE *pHandles, for (i = 0; i < count; i++) handles[i] = pHandles[i]; handles[count] = get_server_queue_handle(); - ReleaseThunkLock( &lock ); - ret = USER_Driver->pMsgWaitForMultipleObjectsEx( count+1, handles, timeout, mask, flags ); - if (lock) RestoreThunkLock( lock ); - return ret; + return wow_handlers.wait_message( count+1, handles, timeout, mask, flags ); } diff --git a/dlls/user32/msg16.c b/dlls/user32/msg16.c index cbaab4b..27a94c5 100644 --- a/dlls/user32/msg16.c +++ b/dlls/user32/msg16.c @@ -2569,6 +2569,20 @@ static LRESULT static_proc16( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, /*********************************************************************** + * wait_message16 + */ +static DWORD wait_message16( DWORD count, CONST HANDLE *handles, DWORD timeout, DWORD mask, DWORD flags ) +{ + DWORD lock, ret; + + ReleaseThunkLock( &lock ); + ret = wow_handlers32.wait_message( count, handles, timeout, mask, flags ); + RestoreThunkLock( lock ); + return ret; +} + + +/*********************************************************************** * create_window16 */ HWND create_window16( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE instance, BOOL unicode ) @@ -2619,6 +2633,7 @@ void register_wow_handlers(void) mdiclient_proc16, scrollbar_proc16, static_proc16, + wait_message16, create_window16, call_window_proc_Ato16, call_dialog_proc_Ato16, diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index b84abb5..c73a40e 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -1121,6 +1121,11 @@ static LRESULT WINAPI StaticWndProcW( HWND hwnd, UINT msg, WPARAM wParam, LPARAM return wow_handlers.static_proc( hwnd, msg, wParam, lParam, TRUE ); } +static DWORD wait_message( DWORD count, CONST HANDLE *handles, DWORD timeout, DWORD mask, DWORD flags ) +{ + return USER_Driver->pMsgWaitForMultipleObjectsEx( count, handles, timeout, mask, flags ); +} + static HICON alloc_icon_handle( unsigned int size ) { struct user_object *obj = HeapAlloc( GetProcessHeap(), 0, sizeof(*obj) + size ); @@ -1167,6 +1172,7 @@ void WINAPI UserRegisterWowHandlers( const struct wow_handlers16 *new, struct wo orig->mdiclient_proc = MDIClientWndProc_common; orig->scrollbar_proc = ScrollBarWndProc_common; orig->static_proc = StaticWndProc_common; + orig->wait_message = wait_message; orig->create_window = WIN_CreateWindowEx; orig->get_win_handle = WIN_GetFullHandle; orig->alloc_winproc = WINPROC_AllocProc; @@ -1185,6 +1191,7 @@ struct wow_handlers16 wow_handlers = MDIClientWndProc_common, ScrollBarWndProc_common, StaticWndProc_common, + wait_message, WIN_CreateWindowEx, NULL, /* call_window_proc */ NULL, /* call_dialog_proc */

1 0

Alexandre Julliard : user32: Remove the no longer needed WIN_ISDIALOG flag.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 2ea73fd7092a87d818a51baa8b58d52879fe64b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ea73fd7092a87d818a51baa8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 23 20:25:04 2009 +0100 user32: Remove the no longer needed WIN_ISDIALOG flag. --- dlls/user32/defdlg.c | 1 - dlls/user32/dialog.c | 4 ++-- dlls/user32/win.c | 4 ++-- dlls/user32/win.h | 5 ++--- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/dlls/user32/defdlg.c b/dlls/user32/defdlg.c index faf5026..373260a 100644 --- a/dlls/user32/defdlg.c +++ b/dlls/user32/defdlg.c @@ -342,7 +342,6 @@ DIALOGINFO *DIALOG_get_info( HWND hwnd, BOOL create ) dlgInfo->idResult = 0; dlgInfo->flags = 0; wndPtr->dlgInfo = dlgInfo; - wndPtr->flags |= WIN_ISDIALOG; } out: diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c index bce2684..2df58a7 100644 --- a/dlls/user32/dialog.c +++ b/dlls/user32/dialog.c @@ -1027,7 +1027,7 @@ static HWND DIALOG_FindMsgDestination( HWND hwndDlg ) pParent = WIN_GetPtr(hParent); if (!pParent || pParent == WND_OTHER_PROCESS || pParent == WND_DESKTOP) break; - if (!(pParent->flags & WIN_ISDIALOG)) + if (!pParent->dlgInfo) { WIN_ReleasePtr(pParent); break; @@ -1135,7 +1135,7 @@ BOOL WINAPI IsDialogMessageW( HWND hwndDlg, LPMSG msg ) if (pWnd && pWnd != WND_OTHER_PROCESS) { - fIsDialog = (pWnd->flags & WIN_ISDIALOG) != 0; + fIsDialog = (pWnd->dlgInfo != NULL); WIN_ReleasePtr(pWnd); } diff --git a/dlls/user32/win.c b/dlls/user32/win.c index f37f8f4..acf70a3 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -1986,7 +1986,7 @@ static LONG_PTR WIN_GetWindowLong( HWND hwnd, INT offset, UINT size, BOOL unicod retvalue = get_win_data( (char *)wndPtr->wExtra + offset, size ); /* Special case for dialog window procedure */ - if ((offset == DWLP_DLGPROC) && (size == sizeof(LONG_PTR)) && (wndPtr->flags & WIN_ISDIALOG)) + if ((offset == DWLP_DLGPROC) && (size == sizeof(LONG_PTR)) && wndPtr->dlgInfo) retvalue = (LONG_PTR)WINPROC_GetProc( (WNDPROC)retvalue, unicode ); WIN_ReleasePtr( wndPtr ); return retvalue; @@ -2115,7 +2115,7 @@ LONG_PTR WIN_SetWindowLong( HWND hwnd, INT offset, UINT size, LONG_PTR newval, B break; case DWLP_DLGPROC: if ((wndPtr->cbWndExtra - sizeof(LONG_PTR) >= DWLP_DLGPROC) && - (size == sizeof(LONG_PTR)) && (wndPtr->flags & WIN_ISDIALOG)) + (size == sizeof(LONG_PTR)) && wndPtr->dlgInfo) { WNDPROC *ptr = (WNDPROC *)((char *)wndPtr->wExtra + DWLP_DLGPROC); retval = (ULONG_PTR)WINPROC_GetProc( *ptr, unicode ); diff --git a/dlls/user32/win.h b/dlls/user32/win.h index bd8381e..58d5972 100644 --- a/dlls/user32/win.h +++ b/dlls/user32/win.h @@ -70,9 +70,8 @@ typedef struct tagWND #define WIN_NEED_SIZE 0x0002 /* Internal WM_SIZE is needed */ #define WIN_NCACTIVATED 0x0004 /* last WM_NCACTIVATE was positive */ #define WIN_ISMDICLIENT 0x0008 /* Window is an MDIClient */ -#define WIN_ISDIALOG 0x0010 /* Window is a dialog */ -#define WIN_ISUNICODE 0x0040 /* Window is Unicode */ -#define WIN_NEEDS_SHOW_OWNEDPOPUP 0x0080 /* WM_SHOWWINDOW:SC_SHOW must be sent in the next ShowOwnedPopup call */ +#define WIN_ISUNICODE 0x0010 /* Window is Unicode */ +#define WIN_NEEDS_SHOW_OWNEDPOPUP 0x0020 /* WM_SHOWWINDOW:SC_SHOW must be sent in the next ShowOwnedPopup call */ /* Window functions */ extern HWND get_hwnd_message_parent(void) DECLSPEC_HIDDEN;

1 0

Alexandre Julliard : user32: Remove the no longer used WIN_ISWIN32 flag.
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 5e640271f2d36a19912a164673d6774ccccc8c8c URL: http://source.winehq.org/git/wine.git/?a=commit;h=5e640271f2d36a19912a16467… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 23 20:19:43 2009 +0100 user32: Remove the no longer used WIN_ISWIN32 flag. --- dlls/user32/controls.h | 6 +++--- dlls/user32/msg16.c | 4 ++-- dlls/user32/win.c | 10 ++++------ dlls/user32/win.h | 3 +-- dlls/user32/wnd16.c | 4 ++-- 5 files changed, 12 insertions(+), 15 deletions(-) diff --git a/dlls/user32/controls.h b/dlls/user32/controls.h index ae964b8..e8c7bdb 100644 --- a/dlls/user32/controls.h +++ b/dlls/user32/controls.h @@ -96,7 +96,7 @@ struct wow_handlers16 LRESULT (*mdiclient_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*scrollbar_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*static_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); - HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,UINT); + HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,BOOL); LRESULT (*call_window_proc)(HWND,UINT,WPARAM,LPARAM,LRESULT*,void*); LRESULT (*call_dialog_proc)(HWND,UINT,WPARAM,LPARAM,LRESULT*,void*); HICON (*alloc_icon_handle)(UINT); @@ -114,7 +114,7 @@ struct wow_handlers32 LRESULT (*mdiclient_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*scrollbar_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); LRESULT (*static_proc)(HWND,UINT,WPARAM,LPARAM,BOOL); - HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,UINT); + HWND (*create_window)(CREATESTRUCTW*,LPCWSTR,HINSTANCE,BOOL); HWND (*get_win_handle)(HWND); WNDPROC (*alloc_winproc)(WNDPROC,BOOL); struct tagDIALOGINFO *(*get_dialog_info)(HWND,BOOL); @@ -133,7 +133,7 @@ extern LRESULT StaticWndProc_common(HWND,UINT,WPARAM,LPARAM,BOOL) DECLSPEC_HIDDE /* 16-bit support */ extern struct wow_handlers32 wow_handlers32 DECLSPEC_HIDDEN; -extern HWND create_window16(CREATESTRUCTW*,LPCWSTR,HINSTANCE,UINT) DECLSPEC_HIDDEN; +extern HWND create_window16(CREATESTRUCTW*,LPCWSTR,HINSTANCE,BOOL) DECLSPEC_HIDDEN; extern void free_module_classes(HINSTANCE16) DECLSPEC_HIDDEN; extern void register_wow_handlers(void) DECLSPEC_HIDDEN; extern void WINAPI UserRegisterWowHandlers( const struct wow_handlers16 *new, diff --git a/dlls/user32/msg16.c b/dlls/user32/msg16.c index 698fb61..cbaab4b 100644 --- a/dlls/user32/msg16.c +++ b/dlls/user32/msg16.c @@ -2571,13 +2571,13 @@ static LRESULT static_proc16( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, /*********************************************************************** * create_window16 */ -HWND create_window16( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE instance, UINT flags ) +HWND create_window16( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE instance, BOOL unicode ) { /* map to module handle */ if (instance && !((ULONG_PTR)instance >> 16)) instance = HINSTANCE_32( GetExePtr( HINSTANCE_16(instance) )); - return wow_handlers32.create_window( cs, className, instance, flags ); + return wow_handlers32.create_window( cs, className, instance, unicode ); } diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 6ce524c..f37f8f4 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -1069,14 +1069,13 @@ static void dump_window_styles( DWORD style, DWORD exstyle ) * * Implementation of CreateWindowEx(). */ -HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, UINT flags ) +HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, BOOL unicode ) { INT cx, cy, style, sw = SW_SHOW; LRESULT result; RECT rect; WND *wndPtr; HWND hwnd, parent, owner, top_child = 0; - BOOL unicode = (flags & WIN_ISUNICODE) != 0; MDICREATESTRUCTW mdi_cs; CBT_CREATEWNDW cbtc; CREATESTRUCTW cbcs; @@ -1217,7 +1216,6 @@ HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, wndPtr->hIcon = 0; wndPtr->hIconSmall = 0; wndPtr->hSysMenu = 0; - wndPtr->flags |= (flags & WIN_ISWIN32); wndPtr->min_pos.x = wndPtr->min_pos.y = -1; wndPtr->max_pos.x = wndPtr->max_pos.y = -1; @@ -1465,11 +1463,11 @@ HWND WINAPI CreateWindowExA( DWORD exStyle, LPCSTR className, WCHAR bufferW[256]; if (!MultiByteToWideChar( CP_ACP, 0, className, -1, bufferW, sizeof(bufferW)/sizeof(WCHAR) )) return 0; - return wow_handlers.create_window( (CREATESTRUCTW *)&cs, bufferW, instance, WIN_ISWIN32 ); + return wow_handlers.create_window( (CREATESTRUCTW *)&cs, bufferW, instance, FALSE ); } /* Note: we rely on the fact that CREATESTRUCTA and */ /* CREATESTRUCTW have the same layout. */ - return wow_handlers.create_window( (CREATESTRUCTW *)&cs, (LPCWSTR)className, instance, WIN_ISWIN32 ); + return wow_handlers.create_window( (CREATESTRUCTW *)&cs, (LPCWSTR)className, instance, FALSE ); } @@ -1497,7 +1495,7 @@ HWND WINAPI CreateWindowExW( DWORD exStyle, LPCWSTR className, cs.lpszClass = className; cs.dwExStyle = exStyle; - return wow_handlers.create_window( &cs, className, instance, WIN_ISWIN32 | WIN_ISUNICODE ); + return wow_handlers.create_window( &cs, className, instance, TRUE ); } diff --git a/dlls/user32/win.h b/dlls/user32/win.h index f764d89..bd8381e 100644 --- a/dlls/user32/win.h +++ b/dlls/user32/win.h @@ -71,7 +71,6 @@ typedef struct tagWND #define WIN_NCACTIVATED 0x0004 /* last WM_NCACTIVATE was positive */ #define WIN_ISMDICLIENT 0x0008 /* Window is an MDIClient */ #define WIN_ISDIALOG 0x0010 /* Window is a dialog */ -#define WIN_ISWIN32 0x0020 /* Understands Win32 messages */ #define WIN_ISUNICODE 0x0040 /* Window is Unicode */ #define WIN_NEEDS_SHOW_OWNEDPOPUP 0x0080 /* WM_SHOWWINDOW:SC_SHOW must be sent in the next ShowOwnedPopup call */ @@ -87,7 +86,7 @@ extern ULONG WIN_SetStyle( HWND hwnd, ULONG set_bits, ULONG clear_bits ) DECLSPE extern BOOL WIN_GetRectangles( HWND hwnd, RECT *rectWindow, RECT *rectClient ) DECLSPEC_HIDDEN; extern LRESULT WIN_DestroyWindow( HWND hwnd ) DECLSPEC_HIDDEN; extern void WIN_DestroyThreadWindows( HWND hwnd ) DECLSPEC_HIDDEN; -extern HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, UINT flags ) DECLSPEC_HIDDEN; +extern HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, BOOL unicode ) DECLSPEC_HIDDEN; extern BOOL WIN_IsWindowDrawable( HWND hwnd, BOOL ) DECLSPEC_HIDDEN; extern HWND *WIN_ListChildren( HWND hwnd ) DECLSPEC_HIDDEN; extern LONG_PTR WIN_SetWindowLong( HWND hwnd, INT offset, UINT size, LONG_PTR newval, BOOL unicode ) DECLSPEC_HIDDEN; diff --git a/dlls/user32/wnd16.c b/dlls/user32/wnd16.c index 9509bd0..7cca331 100644 --- a/dlls/user32/wnd16.c +++ b/dlls/user32/wnd16.c @@ -1892,13 +1892,13 @@ HWND16 WINAPI CreateWindowEx16( DWORD exStyle, LPCSTR className, if (!MultiByteToWideChar( CP_ACP, 0, className, -1, bufferW, sizeof(bufferW)/sizeof(WCHAR) )) return 0; - hwnd = create_window16( (CREATESTRUCTW *)&cs, bufferW, HINSTANCE_32(instance), 0 ); + hwnd = create_window16( (CREATESTRUCTW *)&cs, bufferW, HINSTANCE_32(instance), FALSE ); } else { if (!GlobalGetAtomNameA( LOWORD(className), buffer, sizeof(buffer) )) return 0; cs.lpszClass = buffer; - hwnd = create_window16( (CREATESTRUCTW *)&cs, (LPCWSTR)className, HINSTANCE_32(instance), 0 ); + hwnd = create_window16( (CREATESTRUCTW *)&cs, (LPCWSTR)className, HINSTANCE_32(instance), FALSE ); } return HWND_16( hwnd ); }

1 0

Alexandre Julliard : user32: Make user.exe into a stand-alone 16-bit module .
by Alexandre Julliard Dec. 24, 2009

Dec. 24, 2009

Module: wine Branch: master Commit: 8aa83d326abd7822a47fcbf3045f5179abd49b53 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8aa83d326abd7822a47fcbf30… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 23 20:01:37 2009 +0100 user32: Make user.exe into a stand-alone 16-bit module. --- .gitignore | 1 - configure | 9 ++ configure.ac | 1 + dlls/Makefile.in | 4 - dlls/user.exe16/Makefile.in | 24 ++++ dlls/{user32/bidi16.c => user.exe16/bidi.c} | 0 dlls/{user32/comm16.c => user.exe16/comm.c} | 33 +++--- dlls/{user32/dialog16.c => user.exe16/dialog.c} | 3 +- dlls/{user32/hook16.c => user.exe16/hook.c} | 1 - dlls/{user32/msg16.c => user.exe16/message.c} | 2 - dlls/{user32 => user.exe16}/network.c | 0 dlls/{user32/user16.c => user.exe16/user.c} | 6 - .../user.exe.spec => user.exe16/user.exe16.spec} | 0 dlls/user.exe16/user_private.h | 132 ++++++++++++++++++++ .../version16.rc => user.exe16/version.rc} | 0 dlls/{user32/wnd16.c => user.exe16/window.c} | 4 +- dlls/user32/Makefile.in | 24 ---- dlls/user32/controls.h | 17 +--- dlls/user32/desktop.c | 1 + dlls/user32/edit.c | 4 +- dlls/user32/listbox.c | 1 + dlls/user32/nonclient.c | 1 + dlls/user32/user_main.c | 1 + dlls/user32/user_private.h | 22 ---- dlls/user32/win.h | 1 - 25 files changed, 193 insertions(+), 99 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8aa83d326abd7822a47fc…

1 0