March 2009 - Wine-Commits - list.winehq.org

Michael Stefaniuc : mcicda: Compare a file handle with INVALID_HANDLE_VALUE instead of NULL.
by Alexandre Julliard March 2, 2009

March 2, 2009

Module: wine Branch: master Commit: 4362e840d0a2df85ce08d97f024e5a6ce159a48d URL: http://source.winehq.org/git/wine.git/?a=commit;h=4362e840d0a2df85ce08d97f0… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Feb 27 23:55:31 2009 +0100 mcicda: Compare a file handle with INVALID_HANDLE_VALUE instead of NULL. Found by Smatch. --- dlls/mcicda/mcicda.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mcicda/mcicda.c b/dlls/mcicda/mcicda.c index 79f3bae..81dc18f 100644 --- a/dlls/mcicda/mcicda.c +++ b/dlls/mcicda/mcicda.c @@ -463,7 +463,7 @@ static DWORD MCICDA_Open(UINT wDevID, DWORD dwFlags, LPMCI_OPEN_PARMSW lpOpenPar /* now, open the handle */ root[0] = root[1] = '\\'; root[2] = '.'; root[3] = '\\'; root[4] = drive; root[5] = ':'; root[6] = '\0'; wmcda->handle = CreateFileW(root, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); - if (wmcda->handle != 0) + if (wmcda->handle != INVALID_HANDLE_VALUE) return 0; the_error:

1 0

Rico Schüller : mshtml/tests: Fix SysFreeString call with wrong variable.
by Alexandre Julliard March 2, 2009

March 2, 2009

Module: wine Branch: master Commit: 0215c75260e3c1a22ac3134550550748f5431fb4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0215c75260e3c1a22ac313455… Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Mar 1 14:11:40 2009 +0100 mshtml/tests: Fix SysFreeString call with wrong variable. --- dlls/mshtml/tests/dom.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index c39f79f..1e7acae 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -3225,7 +3225,7 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_put_backgroundRepeat(style, sDefault); ok(hres == S_OK, "put_backgroundRepeat failed: %08x\n", hres); - SysFreeString(str); + SysFreeString(sDefault); hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, (void**)&style2); ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres);

1 0

Rico Schüller : mshtml/tests: Add SysFreeString( sDefault) after the variable isn't used any more.
by Alexandre Julliard March 2, 2009

March 2, 2009

Module: wine Branch: master Commit: 9f60f4e30d376ed70c99fe131676f0001ea5c5d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9f60f4e30d376ed70c99fe131… Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Mar 1 14:14:43 2009 +0100 mshtml/tests: Add SysFreeString(sDefault) after the variable isn't used any more. --- dlls/mshtml/tests/dom.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 1e7acae..37cc549 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2668,6 +2668,7 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_put_fontWeight(style, sDefault); ok(hres == S_OK, "put_fontWeight failed: %08x\n", hres); + SysFreeString(sDefault); /* font Variant */ hres = IHTMLStyle_get_fontVariant(style, NULL); @@ -3071,6 +3072,7 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_put_fontStyle(style, sDefault); ok(hres == S_OK, "put_fontStyle failed: %08x\n", hres); + SysFreeString(sDefault); /* overflow */ hres = IHTMLStyle_get_overflow(style, NULL);

1 0

Paul Vriens : fusion/tests: Fix the last test failure on .NET 1.x.
by Alexandre Julliard March 2, 2009

March 2, 2009

Module: wine Branch: master Commit: d929ea739a9f2c70dd1329c0e461e03623ec87d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d929ea739a9f2c70dd1329c0e… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sat Feb 28 21:57:39 2009 +0100 fusion/tests: Fix the last test failure on .NET 1.x. --- dlls/fusion/tests/asmname.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/fusion/tests/asmname.c b/dlls/fusion/tests/asmname.c index b989c37..442f00f 100644 --- a/dlls/fusion/tests/asmname.c +++ b/dlls/fusion/tests/asmname.c @@ -610,7 +610,9 @@ static void test_CreateAssemblyNameObject(void) ok(hr == FUSION_E_INVALID_NAME || broken(hr == S_OK), /* .NET 1.x */ "Expected FUSION_E_INVALID_NAME, got %08x\n", hr); - ok(hi == 0, "Expected 0, got %08x\n", hi); + ok(hi == 0 || + broken(hi == 0x10005), /* .NET 1.x */ + "Expected 0, got %08x\n", hi); ok(lo == 0, "Expected 0, got %08x\n", lo); test_assembly_name_props(name, badvername);

1 0