July 2009 - Wine-Commits - list.winehq.org

Jörg Höhle : kernel32: Avoid unprotected sprintf on registry/user-supplied format string.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: c3b80267894059fec3f703d20efb61c5bc6ae58c URL: http://source.winehq.org/git/wine.git/?a=commit;h=c3b80267894059fec3f703d20… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Wed Jul 1 09:53:15 2009 +0200 kernel32: Avoid unprotected sprintf on registry/user-supplied format string. --- dlls/kernel32/except.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/kernel32/except.c b/dlls/kernel32/except.c index 53a4515..ca39ec6 100644 --- a/dlls/kernel32/except.c +++ b/dlls/kernel32/except.c @@ -265,15 +265,16 @@ static BOOL start_debugger(PEXCEPTION_POINTERS epointers, HANDLE hEvent) if (format) { - cmdline = HeapAlloc(GetProcessHeap(), 0, strlen(format) + 2*20); - sprintf(cmdline, format, GetCurrentProcessId(), hEvent); + size_t format_size = strlen(format) + 2*20; + cmdline = HeapAlloc(GetProcessHeap(), 0, format_size); + snprintf(cmdline, format_size, format, (long)GetCurrentProcessId(), (long)HandleToLong(hEvent)); HeapFree(GetProcessHeap(), 0, format); } else { cmdline = HeapAlloc(GetProcessHeap(), 0, 80); - sprintf(cmdline, "winedbg --auto %d %ld", - GetCurrentProcessId(), (ULONG_PTR)hEvent); + snprintf(cmdline, 80, "winedbg --auto %ld %ld", /* as in tools/wine.inf */ + (long)GetCurrentProcessId(), (long)HandleToLong(hEvent)); } if (!bAuto)

1 0

Michael Stefaniuc : gphoto2.ds: Build language resource files separately.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: f894164d9fafc065479fb0f28c821c5c4fc2e0db URL: http://source.winehq.org/git/wine.git/?a=commit;h=f894164d9fafc065479fb0f28… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jul 1 10:16:08 2009 +0200 gphoto2.ds: Build language resource files separately. Do not include them from an other rc file. --- dlls/gphoto2.ds/Makefile.in | 16 ++++++++++++++- dlls/gphoto2.ds/gphoto2_Da.rc | 2 + dlls/gphoto2.ds/gphoto2_De.rc | 2 + dlls/gphoto2.ds/gphoto2_En.rc | 2 + dlls/gphoto2.ds/gphoto2_Es.rc | 5 ++- dlls/gphoto2.ds/gphoto2_Fr.rc | 2 + dlls/gphoto2.ds/gphoto2_Ko.rc | 2 + dlls/gphoto2.ds/gphoto2_Lt.rc | 4 +- dlls/gphoto2.ds/gphoto2_Nl.rc | 2 + dlls/gphoto2.ds/gphoto2_No.rc | 2 + dlls/gphoto2.ds/gphoto2_Pl.rc | 2 + dlls/gphoto2.ds/gphoto2_Pt.rc | 2 + dlls/gphoto2.ds/gphoto2_Ru.rc | 2 + dlls/gphoto2.ds/gphoto2_Si.rc | 4 +- dlls/gphoto2.ds/gphoto2_Sv.rc | 2 + dlls/gphoto2.ds/gphoto2_Zh.rc | 4 +- dlls/gphoto2.ds/resource.h | 5 ++++ dlls/gphoto2.ds/rsrc.rc | 43 ----------------------------------------- 18 files changed, 51 insertions(+), 52 deletions(-) diff --git a/dlls/gphoto2.ds/Makefile.in b/dlls/gphoto2.ds/Makefile.in index 5e45e8e..3c1b3be 100644 --- a/dlls/gphoto2.ds/Makefile.in +++ b/dlls/gphoto2.ds/Makefile.in @@ -14,7 +14,21 @@ C_SRCS = \ ui.c RC_SRCS = \ - rsrc.rc + gphoto2_Da.rc \ + gphoto2_De.rc \ + gphoto2_En.rc \ + gphoto2_Es.rc \ + gphoto2_Fr.rc \ + gphoto2_Ko.rc \ + gphoto2_Lt.rc \ + gphoto2_Nl.rc \ + gphoto2_No.rc \ + gphoto2_Pl.rc \ + gphoto2_Pt.rc \ + gphoto2_Ru.rc \ + gphoto2_Si.rc \ + gphoto2_Sv.rc \ + gphoto2_Zh.rc @MAKE_DLL_RULES@ diff --git a/dlls/gphoto2.ds/gphoto2_Da.rc b/dlls/gphoto2.ds/gphoto2_Da.rc index e8ef872..8859398 100644 --- a/dlls/gphoto2.ds/gphoto2_Da.rc +++ b/dlls/gphoto2.ds/gphoto2_Da.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_DANISH, SUBLANG_DEFAULT IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_De.rc b/dlls/gphoto2.ds/gphoto2_De.rc index ee17d6f..94ad6e2 100644 --- a/dlls/gphoto2.ds/gphoto2_De.rc +++ b/dlls/gphoto2.ds/gphoto2_De.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_En.rc b/dlls/gphoto2.ds/gphoto2_En.rc index 5b48650..37577e8 100644 --- a/dlls/gphoto2.ds/gphoto2_En.rc +++ b/dlls/gphoto2.ds/gphoto2_En.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Es.rc b/dlls/gphoto2.ds/gphoto2_Es.rc index 99fc7d8..3f377fd 100644 --- a/dlls/gphoto2.ds/gphoto2_Es.rc +++ b/dlls/gphoto2.ds/gphoto2_Es.rc @@ -18,6 +18,9 @@ * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ + +#include "resource.h" + #pragma code_page(65001) LANGUAGE LANG_SPANISH, SUBLANG_NEUTRAL @@ -55,5 +58,3 @@ BEGIN LTEXT "Conectando a la cámara... Por favor espere",IDC_STATIC,128,58, 116,8 END - -#pragma code_page(default) diff --git a/dlls/gphoto2.ds/gphoto2_Fr.rc b/dlls/gphoto2.ds/gphoto2_Fr.rc index bd52e23..3d5d6d5 100644 --- a/dlls/gphoto2.ds/gphoto2_Fr.rc +++ b/dlls/gphoto2.ds/gphoto2_Fr.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Ko.rc b/dlls/gphoto2.ds/gphoto2_Ko.rc index 2a61cff..8ea0a19 100644 --- a/dlls/gphoto2.ds/gphoto2_Ko.rc +++ b/dlls/gphoto2.ds/gphoto2_Ko.rc @@ -19,6 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Lt.rc b/dlls/gphoto2.ds/gphoto2_Lt.rc index de2a525..c87dd77 100644 --- a/dlls/gphoto2.ds/gphoto2_Lt.rc +++ b/dlls/gphoto2.ds/gphoto2_Lt.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + /* UTF-8 */ #pragma code_page(65001) @@ -56,5 +58,3 @@ BEGIN LTEXT "Jungiamasi prie kameros... Prašome palaukti",IDC_STATIC,124,58, 140,8 END - -#pragma code_page(default) diff --git a/dlls/gphoto2.ds/gphoto2_Nl.rc b/dlls/gphoto2.ds/gphoto2_Nl.rc index 9527467..83acb70 100644 --- a/dlls/gphoto2.ds/gphoto2_Nl.rc +++ b/dlls/gphoto2.ds/gphoto2_Nl.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_DUTCH, SUBLANG_NEUTRAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_No.rc b/dlls/gphoto2.ds/gphoto2_No.rc index b3cb0d8..7cc0176 100644 --- a/dlls/gphoto2.ds/gphoto2_No.rc +++ b/dlls/gphoto2.ds/gphoto2_No.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_NORWEGIAN, SUBLANG_NORWEGIAN_BOKMAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Pl.rc b/dlls/gphoto2.ds/gphoto2_Pl.rc index 3c98599..4177328 100644 --- a/dlls/gphoto2.ds/gphoto2_Pl.rc +++ b/dlls/gphoto2.ds/gphoto2_Pl.rc @@ -19,6 +19,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_POLISH, SUBLANG_DEFAULT IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Pt.rc b/dlls/gphoto2.ds/gphoto2_Pt.rc index fc4194e..c89d6ba 100644 --- a/dlls/gphoto2.ds/gphoto2_Pt.rc +++ b/dlls/gphoto2.ds/gphoto2_Pt.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_PORTUGUESE, SUBLANG_NEUTRAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Ru.rc b/dlls/gphoto2.ds/gphoto2_Ru.rc index 891e116..ad03a35 100644 --- a/dlls/gphoto2.ds/gphoto2_Ru.rc +++ b/dlls/gphoto2.ds/gphoto2_Ru.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_RUSSIAN, SUBLANG_DEFAULT IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Si.rc b/dlls/gphoto2.ds/gphoto2_Si.rc index 87d969f..2f1179d 100644 --- a/dlls/gphoto2.ds/gphoto2_Si.rc +++ b/dlls/gphoto2.ds/gphoto2_Si.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + #pragma code_page(65001) LANGUAGE LANG_SLOVENIAN, SUBLANG_DEFAULT @@ -54,5 +56,3 @@ BEGIN LTEXT "Povezujem se s kamero ... Prosim, počakajte",IDC_STATIC,128,58, 116,8 END - -#pragma code_page(default) diff --git a/dlls/gphoto2.ds/gphoto2_Sv.rc b/dlls/gphoto2.ds/gphoto2_Sv.rc index 6ba9827..c7a3772 100644 --- a/dlls/gphoto2.ds/gphoto2_Sv.rc +++ b/dlls/gphoto2.ds/gphoto2_Sv.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + LANGUAGE LANG_SWEDISH, SUBLANG_NEUTRAL IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 diff --git a/dlls/gphoto2.ds/gphoto2_Zh.rc b/dlls/gphoto2.ds/gphoto2_Zh.rc index abd0f38..dfc758a 100644 --- a/dlls/gphoto2.ds/gphoto2_Zh.rc +++ b/dlls/gphoto2.ds/gphoto2_Zh.rc @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include "resource.h" + /* Chinese text is encoded in UTF-8 */ #pragma code_page(65001) @@ -92,5 +94,3 @@ BEGIN LTEXT "正在連接照相機... 請稍候",IDC_STATIC,128,58, 116,8 END - -#pragma code_page(default) diff --git a/dlls/gphoto2.ds/resource.h b/dlls/gphoto2.ds/resource.h index a13915a..8f2fe63 100644 --- a/dlls/gphoto2.ds/resource.h +++ b/dlls/gphoto2.ds/resource.h @@ -18,6 +18,11 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <windef.h> +#include <winbase.h> +#include <winuser.h> +#include <commctrl.h> + #define IDD_DIALOG1 0x400 #define IDD_CAMERAUI 0x401 #define IDD_CONNECTING 0x402 diff --git a/dlls/gphoto2.ds/rsrc.rc b/dlls/gphoto2.ds/rsrc.rc deleted file mode 100644 index 7746785..0000000 --- a/dlls/gphoto2.ds/rsrc.rc +++ /dev/null @@ -1,43 +0,0 @@ -/* - * Top level resource file for Twain - * - * Copyright 2006 CodeWeavers, Aric Stewart - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include "windef.h" -#include "winbase.h" -#include "winuser.h" -#include "winnls.h" -#include "commctrl.h" - -#include "resource.h" - -#include "gphoto2_Da.rc" -#include "gphoto2_De.rc" -#include "gphoto2_En.rc" -#include "gphoto2_Es.rc" -#include "gphoto2_Fr.rc" -#include "gphoto2_Ko.rc" -#include "gphoto2_Lt.rc" -#include "gphoto2_Nl.rc" -#include "gphoto2_No.rc" -#include "gphoto2_Pl.rc" -#include "gphoto2_Pt.rc" -#include "gphoto2_Ru.rc" -#include "gphoto2_Si.rc" -#include "gphoto2_Sv.rc" -#include "gphoto2_Zh.rc"

1 0

Andrew Nguyen : reg: Support the /h flag as a synonymous help flag.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 7ec4ba32b25531f438c061f4d5a0b7b8f28792a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ec4ba32b25531f438c061f4d… Author: Andrew Nguyen <arethusa26(a)gmail.com> Date: Wed Jul 1 00:41:45 2009 -0500 reg: Support the /h flag as a synonymous help flag. --- programs/reg/reg.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index 9ebfd32..a538d81 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -352,6 +352,7 @@ int wmain(int argc, WCHAR *argvW[]) static const WCHAR queryW[] = {'q','u','e','r','y',0}; static const WCHAR slashDW[] = {'/','d',0}; static const WCHAR slashFW[] = {'/','f',0}; + static const WCHAR slashHW[] = {'/','h',0}; static const WCHAR slashSW[] = {'/','s',0}; static const WCHAR slashTW[] = {'/','t',0}; static const WCHAR slashVW[] = {'/','v',0}; @@ -359,7 +360,8 @@ int wmain(int argc, WCHAR *argvW[]) static const WCHAR slashVEW[] = {'/','v','e',0}; static const WCHAR slashHelpW[] = {'/','?',0}; - if (argc < 2 || !lstrcmpW(argvW[1], slashHelpW)) + if (argc < 2 || !lstrcmpW(argvW[1], slashHelpW) + || !lstrcmpiW(argvW[1], slashHW)) { reg_message(STRING_USAGE); return 0; @@ -375,7 +377,8 @@ int wmain(int argc, WCHAR *argvW[]) reg_message(STRING_INVALID_CMDLINE); return 1; } - else if (argc == 3 && !lstrcmpW(argvW[2], slashHelpW)) + else if (argc == 3 && (!lstrcmpW(argvW[2], slashHelpW) || + !lstrcmpiW(argvW[2], slashHW))) { reg_message(STRING_ADD_USAGE); return 0; @@ -410,7 +413,8 @@ int wmain(int argc, WCHAR *argvW[]) reg_message(STRING_INVALID_CMDLINE); return 1; } - else if (argc == 3 && !lstrcmpW(argvW[2], slashHelpW)) + else if (argc == 3 && (!lstrcmpW(argvW[2], slashHelpW) || + !lstrcmpiW(argvW[2], slashHW))) { reg_message(STRING_DELETE_USAGE); return 0; @@ -440,7 +444,8 @@ int wmain(int argc, WCHAR *argvW[]) reg_message(STRING_INVALID_CMDLINE); return 1; } - else if (argc == 3 && !lstrcmpW(argvW[2], slashHelpW)) + else if (argc == 3 && (!lstrcmpW(argvW[2], slashHelpW) || + !lstrcmpiW(argvW[2], slashHW))) { reg_message(STRING_QUERY_USAGE); return 0;

1 0

Detlef Riekenberg : advapi32/tests: Remove unneeded SetLastError.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 04b9f0251c83977893be66a1514c7eab1611bffe URL: http://source.winehq.org/git/wine.git/?a=commit;h=04b9f0251c83977893be66a15… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Tue Jun 30 21:24:46 2009 +0200 advapi32/tests: Remove unneeded SetLastError. --- dlls/advapi32/tests/registry.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index ca82fa1..71317c4 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -956,15 +956,12 @@ static void test_reg_open_key(void) RegCloseKey(hkResult); /* send in NULL hkResult */ - SetLastError(0xdeadbeef); ret = RegOpenKeyA(HKEY_CURRENT_USER, "Software\\Wine\\Test", NULL); ok(ret == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", ret); - SetLastError(0xdeadbeef); ret = RegOpenKeyA(HKEY_CURRENT_USER, NULL, NULL); ok(ret == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", ret); - SetLastError(0xdeadbeef); ret = RegOpenKeyA(NULL, NULL, NULL); ok(ret == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", ret);

1 0

Aurimas Fišeras : wineconsole: Add Lithuanian translation.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 726891ad8a3b14c9939f68e4a0cb46eb247f2a52 URL: http://source.winehq.org/git/wine.git/?a=commit;h=726891ad8a3b14c9939f68e4a… Author: Aurimas Fišeras <aurimas(a)gmail.com> Date: Tue Jun 30 23:23:25 2009 +0300 wineconsole: Add Lithuanian translation. --- programs/wineconsole/Makefile.in | 1 + programs/wineconsole/wineconsole_Lt.rc | 139 ++++++++++++++++++++++++++++++++ 2 files changed, 140 insertions(+), 0 deletions(-) diff --git a/programs/wineconsole/Makefile.in b/programs/wineconsole/Makefile.in index e7aba97..6ef22f7 100644 --- a/programs/wineconsole/Makefile.in +++ b/programs/wineconsole/Makefile.in @@ -25,6 +25,7 @@ RC_SRCS = \ wineconsole_Hu.rc \ wineconsole_It.rc \ wineconsole_Ko.rc \ + wineconsole_Lt.rc \ wineconsole_Nl.rc \ wineconsole_No.rc \ wineconsole_Pl.rc \ diff --git a/programs/wineconsole/wineconsole_Lt.rc b/programs/wineconsole/wineconsole_Lt.rc new file mode 100644 index 0000000..2e05466 --- /dev/null +++ b/programs/wineconsole/wineconsole_Lt.rc @@ -0,0 +1,139 @@ +/* + * Copyright 2009 Aurimas Fišeras <aurimas(a)gmail.com> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "wineconsole_res.h" + +/* UTF-8 */ +#pragma code_page(65001) + +LANGUAGE LANG_LITHUANIAN, SUBLANG_NEUTRAL + +STRINGTABLE +BEGIN +IDS_EDIT, "&Taisa" +IDS_DEFAULT, "Nustatyti &numatytasias" +IDS_PROPERTIES, "&Savybės" +IDS_MARK, "&Žymėti" +IDS_COPY, "&Kopijuoti" +IDS_PASTE, "Į&dėti" +IDS_SELECTALL, "&Pažymėti viską" +IDS_SCROLL, "&Slinkti" +IDS_SEARCH, "&Ieškoti" +IDS_FNT_DISPLAY, "Kiekvienas simbolis yra %ld pikselių pločio ir %ld pikselių aukščio" +IDS_FNT_PREVIEW_1, "Čia yra testas" +IDS_FNT_PREVIEW_2, "" +IDS_DLG_TIT_DEFAULT, "Konfigūracija - numatytosios nuostatos" +IDS_DLG_TIT_CURRENT, "Konfigūracija - dabartinės nuostatos" +IDS_DLG_TIT_ERROR, "Konfigūracijos klaida" +IDS_DLG_ERR_SBWINSIZE, "Ekrano buferio dydis turi būti didesnis arba lygus lango buferiui" + +IDS_CMD_INVALID_EVENT_ID "wineconsole: nepavyko išnagrinėti įvykio identifikatoriaus\n" +IDS_CMD_INVALID_BACKEND "wineconsole: neteisinga posistemė\n" +IDS_CMD_INVALID_OPTION "wineconsole: neatpažintas komandinės eilutės parametras\n" +IDS_CMD_ABOUT "Paleidžia programą Wine pulte\n" +IDS_CMD_LAUNCH_FAILED "wineconsole: nepavyko paleisti programos %s.\n"\ + "Neteisinga komanda.\n" + +IDS_USAGE_HEADER "\nNaudojimas:\n wineconsole [parametrai] <komanda>\n\nParametrai:\n" +IDS_USAGE_BACKEND " --backend={user|curses} „User“ sukurs naują langą, „curses“ mėgins\n"\ + " sukonfigūruoti dabartinį terminalą kaip Wine pultą\n" +IDS_USAGE_COMMAND " <komanda> Wine programa paleidimui pulte\n" +IDS_USAGE_FOOTER "\nPavyzdys:\n wineconsole cmd\nPaleidžia Wine komandų interpretatorių Wine pulte\n\n" + +END + +IDD_OPTION DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 140, 105 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION " Parinktys " +FONT 8, "MS Shell Dlg" +{ + GROUPBOX "Žymeklio dydis", -1, 10, 11, 60, 44, BS_GROUPBOX + AUTORADIOBUTTON "&Mažas", IDC_OPT_CURSOR_SMALL, 14, 23, 44, 10, WS_TABSTOP + AUTORADIOBUTTON "&Vidutinis", IDC_OPT_CURSOR_MEDIUM, 14, 33, 44, 10, WS_TABSTOP + AUTORADIOBUTTON "&Didelis", IDC_OPT_CURSOR_LARGE, 14, 43, 44, 10, WS_TABSTOP + + GROUPBOX "Valdymas", -1, 75, 11, 125, 44, BS_GROUPBOX + LTEXT "Iškylantis meniu", -1, 79, 23, 60, 20 + AUTOCHECKBOX "&Control", IDC_OPT_CONF_CTRL, 149, 23, 50, 10, WS_TABSTOP + AUTOCHECKBOX "S&hift", IDC_OPT_CONF_SHIFT, 149, 33, 50, 10, WS_TABSTOP + LTEXT "Greitas redagavimas", -1, 79, 43, 70, 10 + AUTOCHECKBOX "įjun&gti", IDC_OPT_QUICK_EDIT, 149, 43, 50, 10, WS_TABSTOP + + GROUPBOX "Komandų istorija", -1, 10, 57, 190, 35, BS_GROUPBOX + LTEXT "Prisimintų &komandų skaičius:", -1, 14, 67, 78, 18 + EDITTEXT IDC_OPT_HIST_SIZE, 92, 69, 31, 12, WS_TABSTOP|WS_BORDER|ES_NUMBER + CONTROL "", IDC_OPT_HIST_SIZE_UD, "msctls_updown32", UDS_SETBUDDYINT|UDS_ALIGNRIGHT|UDS_AUTOBUDDY|UDS_ARROWKEYS|UDS_NOTHOUSANDS, 0, 0, 0, 0 + AUTOCHECKBOX "&Šalinti vienodas", IDC_OPT_HIST_NODOUBLE, 130, 67, 60, 18, WS_TABSTOP|BS_MULTILINE +} + +IDD_FONT DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 140, 105 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION " Šriftas " +FONT 8, "MS Shell Dlg" +{ + LTEXT "&Šriftas", -1, 5, 5, 24, 8 + LISTBOX IDC_FNT_LIST_FONT, 5, 18, 90, 42, LBS_SORT|WS_VSCROLL + LTEXT "&Spalva", -1, 100, 5, 50, 8 + CONTROL "", IDC_FNT_COLOR_FG, "WineConColorPreview", 0L, 100, 18, 48, 16 + CONTROL "", IDC_FNT_COLOR_BK, "WineConColorPreview", 0L, 100, 40, 48, 16 + LTEXT "&Dydis", -1, 158, 5, 40, 8 + LISTBOX IDC_FNT_LIST_SIZE, 158, 18, 40, 60, WS_VSCROLL + CONTROL "", IDC_FNT_PREVIEW, "WineConFontPreview", 0L, 5, 60, 109, 40 + LTEXT "", IDC_FNT_FONT_INFO, 124, 76, 80, 27 +} + +IDD_CONFIG DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 140, 105 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION " Konfigūracija " +FONT 8, "MS Shell Dlg" +{ + GROUPBOX "Buferio dydis", -1, 10, 11, 100, 42, BS_GROUPBOX + LTEXT "&Plotis:", -1, 14, 25, 54, 9 + EDITTEXT IDC_CNF_SB_WIDTH, 68, 23, 36, 12, WS_TABSTOP|WS_BORDER|ES_NUMBER + CONTROL "", IDC_CNF_SB_WIDTH_UD, "msctls_updown32", UDS_SETBUDDYINT|UDS_ALIGNRIGHT|UDS_AUTOBUDDY|UDS_ARROWKEYS|UDS_NOTHOUSANDS, 0, 0, 0, 0 + LTEXT "&Aukštis:", -1, 14, 39, 54, 9 + EDITTEXT IDC_CNF_SB_HEIGHT, 68, 37, 36, 12, WS_TABSTOP|WS_BORDER|ES_NUMBER + CONTROL "", IDC_CNF_SB_HEIGHT_UD, "msctls_updown32", UDS_SETBUDDYINT|UDS_ALIGNRIGHT|UDS_AUTOBUDDY|UDS_ARROWKEYS|UDS_NOTHOUSANDS, 0, 0, 0, 0 + + GROUPBOX "Lango dydis", -1, 10, 55, 100, 42 + LTEXT "P&lotis:", -1, 14, 69, 54, 9 + EDITTEXT IDC_CNF_WIN_WIDTH, 68, 67, 36, 12, WS_TABSTOP|WS_BORDER|ES_NUMBER + CONTROL "", IDC_CNF_WIN_WIDTH_UD, "msctls_updown32", UDS_SETBUDDYINT|UDS_ALIGNRIGHT|UDS_AUTOBUDDY|UDS_ARROWKEYS|UDS_NOTHOUSANDS, 0, 0, 0, 0 + LTEXT "A&ukštis:", -1, 14, 83, 54, 9 + EDITTEXT IDC_CNF_WIN_HEIGHT, 68, 81, 36, 12, WS_TABSTOP|WS_BORDER|ES_NUMBER + CONTROL "", IDC_CNF_WIN_HEIGHT_UD, "msctls_updown32", UDS_SETBUDDYINT|UDS_ALIGNRIGHT|UDS_AUTOBUDDY|UDS_ARROWKEYS|UDS_NOTHOUSANDS, 0, 0, 0, 0 + + GROUPBOX "Programos pabaiga", -1, 115, 11, 80, 42, BS_GROUPBOX + AUTOCHECKBOX "Už&daryti pultą", IDC_CNF_CLOSE_EXIT, 119, 25, 72, 20, WS_TABSTOP + + GROUPBOX "Laida", -1, 115, 55, 80, 42 + COMBOBOX IDC_CNF_EDITION_MODE, 119, 69, 72, 20, CBS_DROPDOWNLIST|WS_VSCROLL|WS_TABSTOP +} + +IDD_SAVE_SETTINGS DIALOG LOADONCALL MOVEABLE DISCARDABLE 20, 20, 170, 60 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION +CAPTION "Pulto parametrai" +FONT 8, "MS Shell Dlg" +{ + GROUPBOX "", -1, 10, 10, 150, 31, BS_GROUPBOX + AUTORADIOBUTTON "Išsaugoti vėlesniems seansams", IDC_SAV_SAVE, 14, 15, 140, 10, WS_TABSTOP + AUTORADIOBUTTON "Keisti tik dabartinį seansą", IDC_SAV_SESSION, 14, 27, 140, 10, WS_TABSTOP + + PUSHBUTTON "Gerai", IDOK, 35, 45, 35, 12 + PUSHBUTTON "Atsisakyti", IDCANCEL, 80, 45, 35, 12 +}

1 0

Aric Stewart : msctf: Implement ITfDocumentMgr::EnumContexts.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 7de0b8299db9ebe839919cb90885a89ff46eeadd URL: http://source.winehq.org/git/wine.git/?a=commit;h=7de0b8299db9ebe839919cb90… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Jun 30 14:47:12 2009 -0500 msctf: Implement ITfDocumentMgr::EnumContexts. --- dlls/msctf/documentmgr.c | 153 ++++++++++++++++++++++++++++++++++++- dlls/msctf/tests/inputprocessor.c | 33 ++++++++ include/msctf.idl | 21 +++++ 3 files changed, 205 insertions(+), 2 deletions(-) diff --git a/dlls/msctf/documentmgr.c b/dlls/msctf/documentmgr.c index f5ea71f..66f0f50 100644 --- a/dlls/msctf/documentmgr.c +++ b/dlls/msctf/documentmgr.c @@ -52,6 +52,16 @@ typedef struct tagDocumentMgr { ITfThreadMgrEventSink* ThreadMgrSink; } DocumentMgr; +typedef struct tagEnumTfContext { + const IEnumTfContextsVtbl *Vtbl; + LONG refCount; + + DWORD index; + DocumentMgr *docmgr; +} EnumTfContext; + +static HRESULT EnumTfContext_Constructor(DocumentMgr* mgr, IEnumTfContexts **ppOut); + static inline DocumentMgr *impl_from_ITfSourceVtbl(ITfSource *iface) { return (DocumentMgr *)((char *)iface - FIELD_OFFSET(DocumentMgr,SourceVtbl)); @@ -233,8 +243,8 @@ static HRESULT WINAPI DocumentMgr_GetBase(ITfDocumentMgr *iface, ITfContext **pp static HRESULT WINAPI DocumentMgr_EnumContexts(ITfDocumentMgr *iface, IEnumTfContexts **ppEnum) { DocumentMgr *This = (DocumentMgr *)iface; - FIXME("STUB:(%p)\n",This); - return E_NOTIMPL; + TRACE("(%p) %p\n",This,ppEnum); + return EnumTfContext_Constructor(This, ppEnum); } static const ITfDocumentMgrVtbl DocumentMgr_DocumentMgrVtbl = @@ -317,3 +327,142 @@ HRESULT DocumentMgr_Constructor(ITfThreadMgrEventSink *ThreadMgrSink, ITfDocumen *ppOut = (ITfDocumentMgr*)This; return S_OK; } + +/************************************************** + * IEnumTfContexts implementaion + **************************************************/ +static void EnumTfContext_Destructor(EnumTfContext *This) +{ + TRACE("destroying %p\n", This); + HeapFree(GetProcessHeap(),0,This); +} + +static HRESULT WINAPI EnumTfContext_QueryInterface(IEnumTfContexts *iface, REFIID iid, LPVOID *ppvOut) +{ + EnumTfContext *This = (EnumTfContext *)iface; + *ppvOut = NULL; + + if (IsEqualIID(iid, &IID_IUnknown) || IsEqualIID(iid, &IID_IEnumTfContexts)) + { + *ppvOut = This; + } + + if (*ppvOut) + { + IUnknown_AddRef(iface); + return S_OK; + } + + WARN("unsupported interface: %s\n", debugstr_guid(iid)); + return E_NOINTERFACE; +} + +static ULONG WINAPI EnumTfContext_AddRef(IEnumTfContexts *iface) +{ + EnumTfContext *This = (EnumTfContext*)iface; + return InterlockedIncrement(&This->refCount); +} + +static ULONG WINAPI EnumTfContext_Release(IEnumTfContexts *iface) +{ + EnumTfContext *This = (EnumTfContext *)iface; + ULONG ret; + + ret = InterlockedDecrement(&This->refCount); + if (ret == 0) + EnumTfContext_Destructor(This); + return ret; +} + +static HRESULT WINAPI EnumTfContext_Next(IEnumTfContexts *iface, + ULONG ulCount, ITfContext **rgContext, ULONG *pcFetched) +{ + EnumTfContext *This = (EnumTfContext *)iface; + ULONG fetched = 0; + + TRACE("(%p)\n",This); + + if (rgContext == NULL) return E_POINTER; + + while (fetched < ulCount) + { + if (This->index > 1) + break; + + if (!This->docmgr->contextStack[This->index]) + break; + + *rgContext = This->docmgr->contextStack[This->index]; + ITfContext_AddRef(*rgContext); + + ++This->index; + ++fetched; + ++rgContext; + } + + if (pcFetched) *pcFetched = fetched; + return fetched == ulCount ? S_OK : S_FALSE; +} + +static HRESULT WINAPI EnumTfContext_Skip( IEnumTfContexts* iface, ULONG celt) +{ + EnumTfContext *This = (EnumTfContext *)iface; + TRACE("(%p)\n",This); + This->index += celt; + return S_OK; +} + +static HRESULT WINAPI EnumTfContext_Reset( IEnumTfContexts* iface) +{ + EnumTfContext *This = (EnumTfContext *)iface; + TRACE("(%p)\n",This); + This->index = 0; + return S_OK; +} + +static HRESULT WINAPI EnumTfContext_Clone( IEnumTfContexts *iface, + IEnumTfContexts **ppenum) +{ + EnumTfContext *This = (EnumTfContext *)iface; + HRESULT res; + + TRACE("(%p)\n",This); + + if (ppenum == NULL) return E_POINTER; + + res = EnumTfContext_Constructor(This->docmgr, ppenum); + if (SUCCEEDED(res)) + { + EnumTfContext *new_This = (EnumTfContext *)*ppenum; + new_This->index = This->index; + } + return res; +} + +static const IEnumTfContextsVtbl IEnumTfContexts_Vtbl ={ + EnumTfContext_QueryInterface, + EnumTfContext_AddRef, + EnumTfContext_Release, + + EnumTfContext_Clone, + EnumTfContext_Next, + EnumTfContext_Reset, + EnumTfContext_Skip +}; + +static HRESULT EnumTfContext_Constructor(DocumentMgr *mgr, IEnumTfContexts **ppOut) +{ + EnumTfContext *This; + + This = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(EnumTfContext)); + if (This == NULL) + return E_OUTOFMEMORY; + + This->Vtbl= &IEnumTfContexts_Vtbl; + This->refCount = 1; + This->docmgr = mgr; + + TRACE("returning %p\n", This); + *ppOut = (IEnumTfContexts*)This; + return S_OK; +} diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c index ba43570..9b266ba 100644 --- a/dlls/msctf/tests/inputprocessor.c +++ b/dlls/msctf/tests/inputprocessor.c @@ -1113,6 +1113,35 @@ static void test_Activate(void) ok(SUCCEEDED(hr),"Failed to Activate text service\n"); } + +static void test_EnumContexts(ITfDocumentMgr *dm, ITfContext *search) +{ + HRESULT hr; + IEnumTfContexts* pEnum; + BOOL found = FALSE; + + hr = ITfDocumentMgr_EnumContexts(dm,&pEnum); + ok(SUCCEEDED(hr),"EnumContexts failed\n"); + if (SUCCEEDED(hr)) + { + ULONG fetched; + ITfContext *cxt; + while (IEnumTfContexts_Next(pEnum, 1, &cxt, &fetched) == S_OK) + { + if (!search) + found = TRUE; + else if (search == cxt) + found = TRUE; + ITfContext_Release(cxt); + } + IEnumTfContexts_Release(pEnum); + } + if (search) + ok(found,"Did not find proper ITfContext\n"); + else + ok(!found,"Found an ITfContext we should should not have\n"); +} + static inline int check_context_refcount(ITfContext *iface) { IUnknown_AddRef(iface); @@ -1183,6 +1212,8 @@ static void test_startSession(void) hr = ITfDocumentMgr_CreateContext(g_dm, cid, 0, NULL, &cxt3, &editCookie); ok(SUCCEEDED(hr),"CreateContext Failed\n"); + test_EnumContexts(g_dm, NULL); + hr = ITfContext_GetDocumentMgr(cxt,&dmtest); ok(hr == S_OK, "ITfContext_GetDocumentMgr failed with %x\n",hr); ok(dmtest == g_dm, "Wrong documentmgr\n"); @@ -1199,6 +1230,8 @@ static void test_startSession(void) ok(test_OnInitDocumentMgr == SINK_FIRED, "OnInitDocumentMgr sink not fired\n"); ok(test_ACP_AdviseSink == SINK_FIRED,"TextStoreACP_AdviseSink not fired\n"); + test_EnumContexts(g_dm, cxt); + hr = ITfDocumentMgr_GetTop(g_dm, &cxtTest); ok(SUCCEEDED(hr),"GetTop Failed\n"); ok(cxtTest == cxt, "Wrong context on top\n"); diff --git a/include/msctf.idl b/include/msctf.idl index ef362e0..6b341d2 100644 --- a/include/msctf.idl +++ b/include/msctf.idl @@ -953,3 +953,24 @@ interface ITfCompartmentEventSink : IUnknown HRESULT OnChange( [in] REFGUID rguid); } + +[ + object, + uuid(8f1a7ea6-1654-4502-a86e-b2902344d507), + pointer_default(unique) +] +interface IEnumTfContexts : IUnknown +{ + HRESULT Clone( + [out] IEnumTfContexts **ppEnum); + + HRESULT Next( + [in] ULONG ulCount, + [out, size_is(ulCount), length_is(*pcFetched)] ITfContext **rgContext, + [out] ULONG *pcFetched); + + HRESULT Reset(); + + HRESULT Skip( + [in] ULONG ulCount); +};

1 0

Aurimas Fišeras : progman: Add Lithuanian translation.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 16e97ae4b3bcaafeae68d66f1992a8c61410cd65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=16e97ae4b3bcaafeae68d66f1… Author: Aurimas Fišeras <aurimas(a)gmail.com> Date: Tue Jun 30 22:17:22 2009 +0300 progman: Add Lithuanian translation. --- programs/progman/Lt.rc | 244 ++++++++++++++++++++++++++++++++++++++++++++++ programs/progman/rsrc.rc | 1 + 2 files changed, 245 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=16e97ae4b3bcaafeae68d…

1 0

Aric Stewart : msctf: Implement TF_CreateInputProcessorProfiles.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: fac0d945e4fa850f2f0a84b7c26beb2caa513549 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fac0d945e4fa850f2f0a84b7c… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Jun 30 14:46:42 2009 -0500 msctf: Implement TF_CreateInputProcessorProfiles. --- dlls/msctf/msctf.c | 9 +++++++++ dlls/msctf/msctf.spec | 2 +- include/msctf.idl | 1 + 3 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index b0a1c54..7f0349f 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -600,3 +600,12 @@ HRESULT WINAPI SetInputScopes(HWND hwnd, const INT *pInputScopes, return S_OK; } + +/*********************************************************************** + * TF_CreateInputProcessorProfiles(MSCTF.@) + */ +HRESULT WINAPI TF_CreateInputProcessorProfiles( + ITfInputProcessorProfiles **ppipr) +{ + return InputProcessorProfiles_Constructor(NULL,(IUnknown**)ppipr); +} diff --git a/dlls/msctf/msctf.spec b/dlls/msctf/msctf.spec index 1c8bb37..f7c35a3 100644 --- a/dlls/msctf/msctf.spec +++ b/dlls/msctf/msctf.spec @@ -11,7 +11,7 @@ @ stub TF_CreateCategoryMgr @ stub TF_CreateCicLoadMutex @ stub TF_CreateDisplayAttributeMgr -@ stub TF_CreateInputProcessorProfiles +@ stdcall TF_CreateInputProcessorProfiles(ptr) @ stub TF_CreateLangBarItemMgr @ stub TF_CreateLangBarMgr @ stdcall TF_CreateThreadMgr(ptr) diff --git a/include/msctf.idl b/include/msctf.idl index fc2a8da..ef362e0 100644 --- a/include/msctf.idl +++ b/include/msctf.idl @@ -31,6 +31,7 @@ cpp_quote("#define TF_E_NOLOCK MAKE_HRESULT(SEVERITY_ERROR, FACILITY_IT cpp_quote("HRESULT WINAPI TF_CreateThreadMgr(ITfThreadMgr **pptim);") cpp_quote("HRESULT WINAPI TF_GetThreadMgr(ITfThreadMgr **pptim);") +cpp_quote("HRESULT WINAPI TF_CreateInputProcessorProfiles(ITfInputProcessorProfiles **ppipr);") cpp_quote("EXTERN_C const CLSID CLSID_TF_ThreadMgr;") cpp_quote("EXTERN_C const CLSID CLSID_TF_InputProcessorProfiles;")

1 0

Andrew Nguyen : reg: Correct the sense of return values for registry operations.
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 070d9f91ab1f938c3303b29c68397478656be119 URL: http://source.winehq.org/git/wine.git/?a=commit;h=070d9f91ab1f938c3303b29c6… Author: Andrew Nguyen <arethusa26(a)gmail.com> Date: Wed Jul 1 00:41:41 2009 -0500 reg: Correct the sense of return values for registry operations. --- programs/reg/reg.c | 36 ++++++++++++++++++------------------ 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index aa9d440..9ebfd32 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -147,14 +147,14 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, if (key_name[0]=='\\' && key_name[1]=='\\') { reg_message(STRING_NO_REMOTE); - return 0; + return 1; } p = strchrW(key_name,'\\'); if (!p) { reg_message(STRING_INVALID_KEY); - return 0; + return 1; } p++; @@ -162,13 +162,13 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, if (!root) { reg_message(STRING_INVALID_KEY); - return 0; + return 1; } if(RegCreateKeyW(root,p,&subkey)!=ERROR_SUCCESS) { reg_message(STRING_INVALID_KEY); - return 0; + return 1; } if (value_name || data) @@ -190,7 +190,7 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, { RegCloseKey(subkey); reg_message(STRING_INVALID_CMDLINE); - return 0; + return 1; } if (data) @@ -203,7 +203,7 @@ static int reg_add(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, RegCloseKey(subkey); reg_message(STRING_SUCCESS); - return 1; + return 0; } static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, @@ -220,14 +220,14 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, if (key_name[0]=='\\' && key_name[1]=='\\') { reg_message(STRING_NO_REMOTE); - return 0; + return 1; } p = strchrW(key_name,'\\'); if (!p) { reg_message(STRING_INVALID_KEY); - return 0; + return 1; } p++; @@ -235,19 +235,19 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, if (!root) { reg_message(STRING_INVALID_KEY); - return 0; + return 1; } if (value_name && value_empty) { reg_message(STRING_INVALID_CMDLINE); - return 0; + return 1; } if (value_empty && value_all) { reg_message(STRING_INVALID_CMDLINE); - return 0; + return 1; } if (!force) @@ -260,16 +260,16 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, if (RegDeleteTreeW(root,p)!=ERROR_SUCCESS) { reg_message(STRING_CANNOT_FIND); - return 0; + return 1; } reg_message(STRING_SUCCESS); - return 1; + return 0; } if(RegOpenKeyW(root,p,&subkey)!=ERROR_SUCCESS) { reg_message(STRING_CANNOT_FIND); - return 0; + return 1; } if (value_all) @@ -283,7 +283,7 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, { RegCloseKey(subkey); reg_message(STRING_INVALID_CMDLINE); - return 0; + return 1; } rc = RegQueryInfoKeyW(subkey, NULL, NULL, NULL, NULL, NULL, NULL, NULL, @@ -292,7 +292,7 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, { /* FIXME: failure */ RegCloseKey(subkey); - return 0; + return 1; } maxValue++; szValue = HeapAlloc(GetProcessHeap(),0,maxValue*sizeof(WCHAR)); @@ -320,7 +320,7 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, { RegCloseKey(subkey); reg_message(STRING_CANNOT_FIND); - return 0; + return 1; } } else if (value_empty) @@ -330,7 +330,7 @@ static int reg_delete(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, RegCloseKey(subkey); reg_message(STRING_SUCCESS); - return 1; + return 0; } static int reg_query(WCHAR *key_name, WCHAR *value_name, BOOL value_empty,

1 0

Henri Verbeet : wined3d: Replace "pshader" checks with explicit type checks in shader_get_registers_used().
by Alexandre Julliard July 1, 2009

July 1, 2009

Module: wine Branch: master Commit: 5df58b7f89a9cfbe7920024ed90b1dcdd39b7f6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=5df58b7f89a9cfbe7920024ed… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jul 1 09:46:15 2009 +0200 wined3d: Replace "pshader" checks with explicit type checks in shader_get_registers_used(). --- dlls/wined3d/baseshader.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/baseshader.c b/dlls/wined3d/baseshader.c index 52e0813..45463f0 100644 --- a/dlls/wined3d/baseshader.c +++ b/dlls/wined3d/baseshader.c @@ -402,7 +402,6 @@ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3 struct wined3d_shader_version shader_version; unsigned int cur_loop_depth = 0, max_loop_depth = 0; const DWORD* pToken = byte_code; - char pshader; /* There are some minor differences between pixel and vertex shaders */ @@ -417,7 +416,6 @@ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3 fe->shader_read_header(fe_data, &pToken, &shader_version); reg_maps->shader_version = shader_version; - pshader = shader_is_pshader_version(shader_version.type); reg_maps->constf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*reg_maps->constf) * ((constf_size + 31) / 32)); @@ -503,7 +501,7 @@ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3 pToken += 4; /* In pixel shader 1.X shaders, the constants are clamped between [-1;1] */ - if (shader_version.major == 1 && pshader) + if (shader_version.major == 1 && shader_version.type == WINED3D_SHADER_TYPE_PIXEL) { float *value = (float *) lconst->value; if(value[0] < -1.0) value[0] = -1.0; @@ -613,12 +611,14 @@ HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct wined3 /* WINED3DSPR_TEXCRDOUT is the same as WINED3DSPR_OUTPUT. _OUTPUT can be > MAX_REG_TEXCRD and * is used in >= 3.0 shaders. Filter 3.0 shaders to prevent overflows, and also filter pixel * shaders because TECRDOUT isn't used in them, but future register types might cause issues */ - if (!pshader && shader_version.major < 3 && dst_param.reg.type == WINED3DSPR_TEXCRDOUT) + if (shader_version.type == WINED3D_SHADER_TYPE_VERTEX && shader_version.major < 3 + && dst_param.reg.type == WINED3DSPR_TEXCRDOUT) { reg_maps->texcoord_mask[dst_param.reg.idx] |= dst_param.write_mask; } - if (pshader && dst_param.reg.type == WINED3DSPR_COLOROUT && dst_param.reg.idx == 0) + if (shader_version.type == WINED3D_SHADER_TYPE_PIXEL + && dst_param.reg.type == WINED3DSPR_COLOROUT && dst_param.reg.idx == 0) { /* Many 2.0 and 3.0 pixel shaders end with a MOV from a temp register to * COLOROUT 0. If we know this in advance, the ARB shader backend can skip

1 0