January 2010 - Wine-Commits

Marcin Baczyński : comctl32: Remove superfluous void* cast.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 9e951e8d14df8d1415eb8c64e5310668deb4e84d URL: http://source.winehq.org/git/wine.git/?a=commit;h=9e951e8d14df8d1415eb8c64e… Author: Marcin Baczyński <marbacz(a)gmail.com> Date: Wed Jan 6 23:38:28 2010 +0100 comctl32: Remove superfluous void* cast. --- dlls/comctl32/listview.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index d98b108..d21935f 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -7464,7 +7464,7 @@ static INT LISTVIEW_InsertItemT(LISTVIEW_INFO *infoPtr, const LVITEMW *lpLVItem, while (i < infoPtr->nItemCount) { hItem = DPA_GetPtr( infoPtr->hdpaItems, i); - item_s = (ITEM_INFO*)DPA_GetPtr(hItem, 0); + item_s = DPA_GetPtr(hItem, 0); cmpv = textcmpWT(item_s->hdr.pszText, lpLVItem->pszText, isW); if (infoPtr->dwStyle & LVS_SORTDESCENDING) cmpv *= -1;

1 0

James Hawkins : advapi32: Fix a few memory leaks. Use the correct API to free SIDs (FreeSid).
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 621a772d48e944e33520639729c02865ffdde9e5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=621a772d48e944e3352063972… Author: James Hawkins <truiken(a)gmail.com> Date: Wed Jan 6 18:26:39 2010 -0800 advapi32: Fix a few memory leaks. Use the correct API to free SIDs (FreeSid). --- dlls/advapi32/tests/security.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 8c986e5..029568c 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1490,7 +1490,7 @@ static void test_CreateWellKnownSid(void) } } - LocalFree(domainsid); + FreeSid(domainsid); } static void test_LookupAccountSid(void) @@ -1812,7 +1812,7 @@ static BOOL get_sid_info(PSID psid, LPSTR *user, LPSTR *dom) static void check_wellknown_name(const char* name, WELL_KNOWN_SID_TYPE result) { SID_IDENTIFIER_AUTHORITY ident = { SECURITY_NT_AUTHORITY }; - PSID domainsid; + PSID domainsid = NULL; char wk_sid[SECURITY_MAX_SID_SIZE]; DWORD cb; @@ -1862,6 +1862,7 @@ static void check_wellknown_name(const char* name, WELL_KNOWN_SID_TYPE result) ok(sid_use == SidTypeWellKnownGroup , "Expected Use (5), got %d\n", sid_use); cleanup: + FreeSid(domainsid); HeapFree(GetProcessHeap(),0,psid); HeapFree(GetProcessHeap(),0,domain); } @@ -2615,8 +2616,8 @@ static void test_SetEntriesInAcl(void) ok(NewAcl != NULL, "returned acl was NULL\n"); LocalFree(NewAcl); - LocalFree(UsersSid); - LocalFree(EveryoneSid); + FreeSid(UsersSid); + FreeSid(EveryoneSid); HeapFree(GetProcessHeap(), 0, OldAcl); }

1 0

James Hawkins : advpack: Free the file list on any error.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: ced5081eb98c3b3fe6a9a724532309d23f9ef62c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ced5081eb98c3b3fe6a9a7245… Author: James Hawkins <truiken(a)gmail.com> Date: Wed Jan 6 18:26:45 2010 -0800 advpack: Free the file list on any error. --- dlls/advpack/files.c | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c index 679d236..f6056f2 100644 --- a/dlls/advpack/files.c +++ b/dlls/advpack/files.c @@ -648,6 +648,18 @@ static DWORD fill_file_list(SESSION *session, LPCSTR szCabName, LPCSTR szFileLis return dwNumFound; } +static void free_file_list(SESSION* session) +{ + struct FILELIST *next, *curr = session->FileList; + + while (curr) + { + next = curr->next; + free_file_node(curr); + curr = next; + } +} + /*********************************************************************** * ExtractFilesA (ADVPACK.@) * @@ -728,20 +740,8 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags, session.Operation |= EXTRACT_EXTRACTFILES; res = pExtract(&session, CabName); - if (session.FileList) - { - struct FILELIST *curr = session.FileList; - struct FILELIST *next; - - while (curr) - { - next = curr->next; - free_file_node(curr); - curr = next; - } - } - done: + free_file_list(&session); FreeLibrary(hCabinet); HeapFree(GetProcessHeap(), 0, szConvertedList);

1 0

Detlef Riekenberg : mlang: Print a FIXME only for unused parameter.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 69b0b5e09677203b348e2059ae05161abdbd22c7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=69b0b5e09677203b348e2059a… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Thu Jan 7 00:47:07 2010 +0100 mlang: Print a FIXME only for unused parameter. --- dlls/mlang/mlang.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c index 49f0605..47b1745 100644 --- a/dlls/mlang/mlang.c +++ b/dlls/mlang/mlang.c @@ -3007,9 +3007,6 @@ exit: return hr; } -/* - * TODO: handle dwFlag and lpFallBack -*/ static HRESULT WINAPI fnIMultiLanguage2_ConvertStringToUnicodeEx( IMultiLanguage3* iface, DWORD* pdwMode, @@ -3021,7 +3018,10 @@ static HRESULT WINAPI fnIMultiLanguage2_ConvertStringToUnicodeEx( DWORD dwFlag, WCHAR* lpFallBack) { - FIXME("\n"); + if (dwFlag || lpFallBack) + FIXME("Ignoring dwFlag (0x%x/%d) and lpFallBack (%p)\n", + dwFlag, dwFlag, lpFallBack); + return ConvertINetMultiByteToUnicode(pdwMode, dwEncoding, pSrcStr, (LPINT)pcSrcSize, pDstStr, (LPINT)pcDstSize); }

1 0

Marcin Baczyński : fnt2bdf: Remove superfluous void* casts.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: c7183e831b6fc3f42ace23266cddb6f090bf4d61 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c7183e831b6fc3f42ace23266… Author: Marcin Baczyński <marbacz(a)gmail.com> Date: Wed Jan 6 23:38:35 2010 +0100 fnt2bdf: Remove superfluous void* casts. --- tools/fnt2bdf.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/fnt2bdf.c b/tools/fnt2bdf.c index 5534ff9..89e24c8 100644 --- a/tools/fnt2bdf.c +++ b/tools/fnt2bdf.c @@ -290,7 +290,7 @@ static int parse_fnt_data(unsigned char* file_buffer, int length) /* malloc size = (# chars) * sizeof(WinCharS) */ - if((cpe_font_struct.dfCharTable = (WinCharS *) calloc(sizeof(WinCharS), l_len)) == NULL) + if((cpe_font_struct.dfCharTable = calloc(sizeof(WinCharS), l_len)) == NULL) return ERROR_MEMORY; /* NOW, convert them all to UNIX (lton) notation... */ @@ -649,7 +649,7 @@ static int get_resource_table(int fd, unsigned char** lpdata, int fsize) } else return FILE_ERROR; - *lpdata = (unsigned char*)malloc(size); + *lpdata = malloc(size); if( *lpdata ) { @@ -711,7 +711,7 @@ int main(int argc, char **argv) length = return_data_value(dfShort, &pFontStorage->length) << size_shift; offset = return_data_value(dfShort, &pFontStorage->offset) << size_shift; - if( !(lpfont = (unsigned char*) realloc( lpfont, length )) ) + if( !(lpfont = realloc( lpfont, length )) ) { fprintf(stderr, "Memory allocation error.\n" ); exit(1);

1 0

Henri Verbeet : wined3d: Recognize the SM4 if opcode.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: dbeeb07713d2acffbd2b58ce0972f5428c8bcc51 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dbeeb07713d2acffbd2b58ce0… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 6 23:22:13 2010 +0100 wined3d: Recognize the SM4 if opcode. --- dlls/wined3d/shader_sm4.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index b935eef..59ac6bf 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -55,6 +55,7 @@ enum wined3d_sm4_opcode WINED3D_SM4_OP_EMIT = 0x13, WINED3D_SM4_OP_EXP = 0x19, WINED3D_SM4_OP_IADD = 0x1e, + WINED3D_SM4_OP_IF = 0x1f, WINED3D_SM4_OP_IGE = 0x21, WINED3D_SM4_OP_LOG = 0x2f, WINED3D_SM4_OP_LT = 0x31, @@ -113,6 +114,7 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = {WINED3D_SM4_OP_EMIT, WINED3DSIH_EMIT, 0, 0}, {WINED3D_SM4_OP_EXP, WINED3DSIH_EXP, 1, 1}, {WINED3D_SM4_OP_IADD, WINED3DSIH_IADD, 1, 2}, + {WINED3D_SM4_OP_IF, WINED3DSIH_IF, 0, 1}, {WINED3D_SM4_OP_IGE, WINED3DSIH_IGE, 1, 2}, {WINED3D_SM4_OP_LOG, WINED3DSIH_LOG, 1, 1}, {WINED3D_SM4_OP_LT, WINED3DSIH_LT, 1, 2},

1 0

Marcin Baczyński : rasapi32/tests: Remove superfluous void* cast.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 0666c8e4ec94f4c9d4f9522b56d57b9b6c3f44e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0666c8e4ec94f4c9d4f9522b5… Author: Marcin Baczyński <marbacz(a)gmail.com> Date: Wed Jan 6 23:38:31 2010 +0100 rasapi32/tests: Remove superfluous void* cast. --- dlls/rasapi32/tests/rasapi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/rasapi32/tests/rasapi.c b/dlls/rasapi32/tests/rasapi.c index 11fca0e..1bc684c 100644 --- a/dlls/rasapi32/tests/rasapi.c +++ b/dlls/rasapi32/tests/rasapi.c @@ -67,7 +67,7 @@ static void test_rasenum(void) ok(result == ERROR_BUFFER_TOO_SMALL, "Expected ERROR_BUFFER_TOO_SMALL, got %08d\n", result); - rasDevInfo = (LPRASDEVINFO) HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, + rasDevInfo = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, max(bufsize,sizeof(RASDEVINFOA))); if(!rasDevInfo) { win_skip("failed to allocate buffer for RasEnumDevicesA tests\n");

1 0

Henri Verbeet : wined3d: Recognize the SM4 endif opcode.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 0296aaa6a6a0bb2178bea38caf5814d4b32dd302 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0296aaa6a6a0bb2178bea38ca… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 6 23:22:15 2010 +0100 wined3d: Recognize the SM4 endif opcode. --- dlls/wined3d/shader_sm4.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index b473844..782289e 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -54,6 +54,7 @@ enum wined3d_sm4_opcode WINED3D_SM4_OP_DP3 = 0x10, WINED3D_SM4_OP_DP4 = 0x11, WINED3D_SM4_OP_EMIT = 0x13, + WINED3D_SM4_OP_ENDIF = 0x15, WINED3D_SM4_OP_EXP = 0x19, WINED3D_SM4_OP_IADD = 0x1e, WINED3D_SM4_OP_IF = 0x1f, @@ -114,6 +115,7 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = {WINED3D_SM4_OP_DP3, WINED3DSIH_DP3, 1, 2}, {WINED3D_SM4_OP_DP4, WINED3DSIH_DP4, 1, 2}, {WINED3D_SM4_OP_EMIT, WINED3DSIH_EMIT, 0, 0}, + {WINED3D_SM4_OP_ENDIF, WINED3DSIH_ENDIF, 0, 0}, {WINED3D_SM4_OP_EXP, WINED3DSIH_EXP, 1, 1}, {WINED3D_SM4_OP_IADD, WINED3DSIH_IADD, 1, 2}, {WINED3D_SM4_OP_IF, WINED3DSIH_IF, 0, 1},

1 0

Henri Verbeet : wined3d: Recognize the SM4 break opcode.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 58233befb788185b64a7e08e7323072986fa8ea6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=58233befb788185b64a7e08e7… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 6 23:22:14 2010 +0100 wined3d: Recognize the SM4 break opcode. --- dlls/wined3d/shader_sm4.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/shader_sm4.c b/dlls/wined3d/shader_sm4.c index 59ac6bf..b473844 100644 --- a/dlls/wined3d/shader_sm4.c +++ b/dlls/wined3d/shader_sm4.c @@ -49,6 +49,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d_shader); enum wined3d_sm4_opcode { WINED3D_SM4_OP_ADD = 0x00, + WINED3D_SM4_OP_BREAK = 0x02, WINED3D_SM4_OP_BREAKC = 0x03, WINED3D_SM4_OP_DP3 = 0x10, WINED3D_SM4_OP_DP4 = 0x11, @@ -108,6 +109,7 @@ struct sysval_map static const struct wined3d_sm4_opcode_info opcode_table[] = { {WINED3D_SM4_OP_ADD, WINED3DSIH_ADD, 1, 2}, + {WINED3D_SM4_OP_BREAK, WINED3DSIH_BREAK, 0, 0}, {WINED3D_SM4_OP_BREAKC, WINED3DSIH_BREAKP, 0, 1}, {WINED3D_SM4_OP_DP3, WINED3DSIH_DP3, 1, 2}, {WINED3D_SM4_OP_DP4, WINED3DSIH_DP4, 1, 2},

1 0

Marcin Baczyński : advapi32/tests: Remove superfluous void* cast.
by Alexandre Julliard Jan. 7, 2010

Jan. 7, 2010

Module: wine Branch: master Commit: 005b9066f43b5abde9803ae3fad5809eeea6152d URL: http://source.winehq.org/git/wine.git/?a=commit;h=005b9066f43b5abde9803ae3f… Author: Marcin Baczyński <marbacz(a)gmail.com> Date: Wed Jan 6 23:38:27 2010 +0100 advapi32/tests: Remove superfluous void* cast. --- dlls/advapi32/tests/security.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 001b909..8c986e5 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1673,7 +1673,7 @@ static void test_LookupAccountSid(void) This assumes this process is running under the account of the current user.*/ ret = OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY|TOKEN_DUPLICATE, &hToken); ret = GetTokenInformation(hToken, TokenUser, NULL, 0, &cbti); - ptiUser = (PTOKEN_USER) HeapAlloc(GetProcessHeap(), 0, cbti); + ptiUser = HeapAlloc(GetProcessHeap(), 0, cbti); if (GetTokenInformation(hToken, TokenUser, ptiUser, cbti, &cbti)) { acc_sizeA = dom_sizeA = MAX_PATH;

1 0