December 2010 - Wine-Commits

André Hentschel : Wine 1.3.9 freigegeben
by Jeremy Newman Dec. 13, 2010

Dec. 13, 2010

Module: website Branch: master Commit: c76dcfea550b771c41737a6998081ec82599a1cb URL: http://source.winehq.org/git/website.git/?a=commit;h=c76dcfea550b771c41737a… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Dec 12 20:34:56 2010 +0100 Wine 1.3.9 freigegeben --- news/de/2010121001.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/de/2010121001.xml b/news/de/2010121001.xml new file mode 100644 index 0000000..558efa3 --- /dev/null +++ b/news/de/2010121001.xml @@ -0,0 +1,18 @@ +<news> +<date>10. Dezember 2010</date> +<title>Wine 1.3.9 freigegeben</title> +<body> + Die Entwicklungsversion 1.3.9 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/1.3.9">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Anfängliche Unterstützung für ActiveX im eigenen Browser.</li> + <li>Icons für Internetverknüpfungen im Menü.</li> + <li>Standardisierung von COM Schnittstellencode.</li> + <li>DLL Registrierungen nach einem neuen Schema.</li> + <li>OpenCL Bibliotheks Wrapper.</li> + <li>Updates in den Übersetzungen.</li> + <li>Verschiedenste Fehlerbehebungen.</li> +</ul> +Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.3.9.tar.bz2">verfügbar</a>. +Binär-Downloads werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Download-Seiten</a> zur Verfügung. +</body></news>

1 0

Alexandre Julliard : Wine release 1.3.9
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: website Branch: master Commit: d18327a915585f4aec40158f5606f1d95a8d7700 URL: http://source.winehq.org/git/website.git/?a=commit;h=d18327a915585f4aec4015… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 10 20:43:34 2010 +0100 Wine release 1.3.9 --- news/en/2010121001.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/en/2010121001.xml b/news/en/2010121001.xml new file mode 100644 index 0000000..c4624b2 --- /dev/null +++ b/news/en/2010121001.xml @@ -0,0 +1,18 @@ +<news> +<date>December 10, 2010</date> +<title>Wine 1.3.9 Released</title> +<body> + The Wine development release 1.3.9 is now available. + <a href="{$root}/announce/1.3.9">What's new</a> in this release: +<ul> + <li>Beginnings of support for ActiveX in built-in browser.</li> + <li>Icons on Internet shortcut menu entries.</li> + <li>Standardization of code implementing COM interfaces.</li> + <li>New scheme for auto-generated DLL registrations.</li> + <li>OpenCL library wrapper.</li> + <li>Translation updates.</li> + <li>Various bug fixes.</li> +</ul> +The source is <a href="http://prdownloads.sourceforge.net/wine/wine-1.3.9.tar.bz2">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

Tag wine-1.3.9 : Alexandre Julliard : Release 1.3.9
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: refs/tags/wine-1.3.9 Tag: 77bdf75529d0527702a22bf6f484e1124789a668 URL: http://source.winehq.org/git/wine.git/?a=tag;h=77bdf75529d0527702a22bf6f484… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 10 20:33:13 2010 +0100 Release 1.3.9

1 0

Alexandre Julliard : Release 1.3.9.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: ab8959a0503efef032235acbabc0fcbe81fcd1a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab8959a0503efef032235acba… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 10 20:33:07 2010 +0100 Release 1.3.9. --- ANNOUNCE | 1077 +++++++++++++++++++++++++++++++++++-------------------------- VERSION | 2 +- configure | 18 +- 3 files changed, 628 insertions(+), 469 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ab8959a0503efef032235…

1 0

Hans Leidekker : msi/tests: Fix some test failures on Wow64.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: 1214dca41237dcf401f3548cf0538b0748df6426 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1214dca41237dcf401f3548cf… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Dec 10 16:46:43 2010 +0100 msi/tests: Fix some test failures on Wow64. --- dlls/msi/tests/action.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c index 504291a..0032222 100644 --- a/dlls/msi/tests/action.c +++ b/dlls/msi/tests/action.c @@ -2842,7 +2842,7 @@ currentuser: RegCloseKey(hkey); machprod: - res = RegOpenKeyA(HKEY_CLASSES_ROOT, machprod, &hkey); + res = RegOpenKeyExA(HKEY_CLASSES_ROOT, machprod, 0, access, &hkey); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); CHECK_DEL_REG_STR(hkey, "ProductName", "MSITEST"); @@ -2856,7 +2856,7 @@ machprod: CHECK_DEL_REG_DWORD(hkey, "InstanceType", 0); CHECK_DEL_REG_STR(hkey, "Clients", ":"); - res = RegOpenKeyA(hkey, "SourceList", &sourcelist); + res = RegOpenKeyExA(hkey, "SourceList", 0, access, &sourcelist); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); lstrcpyA(path, "n;1;"); @@ -2864,7 +2864,7 @@ machprod: CHECK_DEL_REG_STR(sourcelist, "LastUsedSource", path); CHECK_DEL_REG_STR(sourcelist, "PackageName", "msitest.msi"); - res = RegOpenKeyA(sourcelist, "Net", &net); + res = RegOpenKeyExA(sourcelist, "Net", 0, access, &net); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); CHECK_DEL_REG_STR(net, "1", temp); @@ -2872,7 +2872,7 @@ machprod: RegDeleteKeyA(net, ""); RegCloseKey(net); - res = RegOpenKeyA(sourcelist, "Media", &media); + res = RegOpenKeyExA(sourcelist, "Media", 0, access, &media); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); CHECK_DEL_REG_STR(media, "1", "DISK1;"); @@ -2884,7 +2884,7 @@ machprod: RegDeleteKeyA(hkey, ""); RegCloseKey(hkey); - res = RegOpenKeyA(HKEY_CLASSES_ROOT, machup, &hkey); + res = RegOpenKeyExA(HKEY_CLASSES_ROOT, machup, 0, access, &hkey); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); CHECK_DEL_REG_STR(hkey, "84A88FD7F6998CE40A22FB59F6B9C2BB", NULL); @@ -2989,7 +2989,7 @@ static void test_publish_features(void) res = RegOpenKeyA(HKEY_CURRENT_USER, cupath, &hkey); ok(res == ERROR_FILE_NOT_FOUND, "Expected ERROR_FILE_NOT_FOUND, got %d\n", res); - res = RegOpenKeyA(HKEY_LOCAL_MACHINE, classfeat, &hkey); + res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, classfeat, 0, access, &hkey); ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); CHECK_REG_STR(hkey, "feature", "");

1 0

Jacek Caban : mshtml: Added QueryService(SID_SBindHost) implementation.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: 3314bd8f8aeacbd88f33c1534bdbbec9d4bb0d25 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3314bd8f8aeacbd88f33c1534… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Dec 10 16:37:39 2010 +0100 mshtml: Added QueryService(SID_SBindHost) implementation. --- dlls/mshtml/pluginhost.c | 6 ++++++ dlls/mshtml/tests/activex.c | 17 +++++++++++++++++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/pluginhost.c b/dlls/mshtml/pluginhost.c index d7a83e7..7b7e210 100644 --- a/dlls/mshtml/pluginhost.c +++ b/dlls/mshtml/pluginhost.c @@ -838,6 +838,12 @@ static ULONG WINAPI PHServiceProvider_Release(IServiceProvider *iface) static HRESULT WINAPI PHServiceProvider_QueryService(IServiceProvider *iface, REFGUID guidService, REFIID riid, void **ppv) { PluginHost *This = impl_from_IServiceProvider(iface); + + if(IsEqualGUID(guidService, &SID_SBindHost)) { + TRACE("SID_SBindHost service\n"); + return IOleClientSite_QueryInterface(&This->IOleClientSite_iface, riid, ppv); + } + FIXME("(%p)->(%s %s %p)\n", This, debugstr_guid(guidService), debugstr_guid(riid), ppv); return E_NOINTERFACE; } diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 9d8e668..3e5f7b8 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -330,6 +330,8 @@ static HRESULT WINAPI PersistPropertyBag_InitNew(IPersistPropertyBag *face) static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IPropertyBag *pPropBag, IErrorLog *pErrorLog) { + IBindHost *bind_host, *bind_host2; + IServiceProvider *sp; VARIANT v; HRESULT hres; @@ -384,6 +386,21 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper ok(V_BSTR(&v) == (BSTR)0xdeadbeef, "V_BSTR(v) = %p\n", V_BSTR(&v)); set_plugin_readystate(READYSTATE_INTERACTIVE); + + hres = IOleClientSite_QueryInterface(client_site, &IID_IBindHost, (void**)&bind_host); + ok(hres == S_OK, "Could not get IBindHost iface: %08x\n", hres); + + hres = IOleClientSite_QueryInterface(client_site, &IID_IServiceProvider, (void**)&sp); + ok(hres == S_OK, "Could not get IServiceProvider iface: %08x\n", hres); + + hres = IServiceProvider_QueryService(sp, &IID_IBindHost, &SID_SBindHost, (void**)&bind_host2); + ok(hres == S_OK, "QueryService(SID_SBindHost) failed: %08x\n", hres); + IServiceProvider_Release(sp); + + ok(iface_cmp((IUnknown*)bind_host, (IUnknown*)bind_host2), "bind_host != bind_host2\n"); + IBindHost_Release(bind_host2); + IBindHost_Release(bind_host); + set_plugin_readystate(READYSTATE_COMPLETE); return S_OK;

1 0

Jacek Caban : mshtml: Added IBindHost::CreateMoniker implementation.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: b3f0f07d70d007886adaca89bf27665aa73f7350 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b3f0f07d70d007886adaca89b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Dec 10 16:38:03 2010 +0100 mshtml: Added IBindHost::CreateMoniker implementation. --- dlls/mshtml/pluginhost.c | 11 +++++++++-- dlls/mshtml/tests/activex.c | 12 ++++++++++-- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/pluginhost.c b/dlls/mshtml/pluginhost.c index 9f6f2d5..7d667a4 100644 --- a/dlls/mshtml/pluginhost.c +++ b/dlls/mshtml/pluginhost.c @@ -800,8 +800,15 @@ static ULONG WINAPI PHBindHost_Release(IBindHost *iface) static HRESULT WINAPI PHBindHost_CreateMoniker(IBindHost *iface, LPOLESTR szName, IBindCtx *pBC, IMoniker **ppmk, DWORD dwReserved) { PluginHost *This = impl_from_IBindHost(iface); - FIXME("(%p)->(%s %p %p %x)\n", This, debugstr_w(szName), pBC, ppmk, dwReserved); - return E_NOTIMPL; + + TRACE("(%p)->(%s %p %p %x)\n", This, debugstr_w(szName), pBC, ppmk, dwReserved); + + if(!This->doc || !This->doc->basedoc.window || !This->doc->basedoc.window->mon) { + FIXME("no moniker\n"); + return E_UNEXPECTED; + } + + return CreateURLMoniker(This->doc->basedoc.window->mon, szName, ppmk); } static HRESULT WINAPI PHBindHost_MonikerBindToStorage(IBindHost *iface, IMoniker *pMk, IBindCtx *pBC, diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 89b8af4..16c91ec 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -355,6 +355,7 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper static const WCHAR param_nameW[] = {'p','a','r','a','m','_','n','a','m','e',0}; static const WCHAR num_paramW[] = {'n','u','m','_','p','a','r','a','m',0}; static const WCHAR no_paramW[] = {'n','o','_','p','a','r','a','m',0}; + static WCHAR test_swfW[] = {'t','e','s','t','.','s','w','f',0}; static const IID *propbag_ifaces[] = { &IID_IPropertyBag, @@ -418,14 +419,21 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper IBindHost_Release(bind_host2); mon = NULL; + hres = IBindHost_CreateMoniker(bind_host, test_swfW, NULL, &mon, 0); + ok(hres == S_OK, "CreateMoniker failed: %08x\n", hres); + ok(mon != NULL, "mon == NULL\n"); + test_mon_displayname(mon, "about:test.swf"); + IMoniker_Release(mon); + + IBindHost_Release(bind_host); + + mon = NULL; hres = IOleClientSite_GetMoniker(client_site, OLEGETMONIKER_ONLYIFTHERE, OLEWHICHMK_CONTAINER, &mon); ok(hres == S_OK, "GetMoniker failed: %08x\n", hres); ok(mon != NULL, "mon == NULL\n"); test_mon_displayname(mon, "about:blank"); IMoniker_Release(mon); - IBindHost_Release(bind_host); - set_plugin_readystate(READYSTATE_COMPLETE); return S_OK;

1 0

Jacek Caban : mshtml: Added PluginHost::GetMoniker implementation.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: d43fb00eafe21eba34ae721125b5ba494909a867 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d43fb00eafe21eba34ae72112… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Dec 10 16:37:53 2010 +0100 mshtml: Added PluginHost::GetMoniker implementation. --- dlls/mshtml/pluginhost.c | 23 ++++++++++++++++++++--- dlls/mshtml/tests/activex.c | 25 +++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/pluginhost.c b/dlls/mshtml/pluginhost.c index 7b7e210..9f6f2d5 100644 --- a/dlls/mshtml/pluginhost.c +++ b/dlls/mshtml/pluginhost.c @@ -283,11 +283,28 @@ static HRESULT WINAPI PHClientSite_SaveObject(IOleClientSite *iface) } static HRESULT WINAPI PHClientSite_GetMoniker(IOleClientSite *iface, DWORD dwAssign, - DWORD dwWhichMoniker, IMoniker **ppmk) + DWORD dwWhichMoniker, IMoniker **ppmk) { PluginHost *This = impl_from_IOleClientSite(iface); - FIXME("(%p)->(%d %d %p)\n", This, dwAssign, dwWhichMoniker, ppmk); - return E_NOTIMPL; + + TRACE("(%p)->(%d %d %p)\n", This, dwAssign, dwWhichMoniker, ppmk); + + switch(dwWhichMoniker) { + case OLEWHICHMK_CONTAINER: + if(!This->doc || !This->doc->basedoc.window || !This->doc->basedoc.window->mon) { + FIXME("no moniker\n"); + return E_UNEXPECTED; + } + + *ppmk = This->doc->basedoc.window->mon; + IMoniker_AddRef(*ppmk); + break; + default: + FIXME("which %d\n", dwWhichMoniker); + return E_NOTIMPL; + } + + return S_OK; } static HRESULT WINAPI PHClientSite_GetContainer(IOleClientSite *iface, IOleContainer **ppContainer) diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 3e5f7b8..89b8af4 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -162,6 +162,22 @@ static void set_plugin_readystate(READYSTATE state) IPropertyNotifySink_Release(prop_notif); } +static void test_mon_displayname(IMoniker *mon, const char *exname) +{ + LPOLESTR display_name; + DWORD mksys; + HRESULT hres; + + hres = IMoniker_GetDisplayName(mon, NULL, NULL, &display_name); + ok(hres == S_OK, "GetDisplayName failed: %08x\n", hres); + ok(!strcmp_wa(display_name, exname), "display_name = %s\n", wine_dbgstr_w(display_name)); + CoTaskMemFree(display_name); + + hres = IMoniker_IsSystemMoniker(mon, &mksys); + ok(hres == S_OK, "IsSystemMoniker failed: %08x\n", hres); + ok(mksys == MKSYS_URLMONIKER, "mksys = %d\n", mksys); +} + static HRESULT ax_qi(REFIID,void**); static HRESULT WINAPI OleControl_QueryInterface(IOleControl *iface, REFIID riid, void **ppv) @@ -332,6 +348,7 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper { IBindHost *bind_host, *bind_host2; IServiceProvider *sp; + IMoniker *mon; VARIANT v; HRESULT hres; @@ -399,6 +416,14 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper ok(iface_cmp((IUnknown*)bind_host, (IUnknown*)bind_host2), "bind_host != bind_host2\n"); IBindHost_Release(bind_host2); + + mon = NULL; + hres = IOleClientSite_GetMoniker(client_site, OLEGETMONIKER_ONLYIFTHERE, OLEWHICHMK_CONTAINER, &mon); + ok(hres == S_OK, "GetMoniker failed: %08x\n", hres); + ok(mon != NULL, "mon == NULL\n"); + test_mon_displayname(mon, "about:blank"); + IMoniker_Release(mon); + IBindHost_Release(bind_host); set_plugin_readystate(READYSTATE_COMPLETE);

1 0

Jacek Caban : mshtml: Added IViewObjectEx iface to plugin test.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: 9f182396fb600c550e26d6b03d6d88d7d6ceb29b URL: http://source.winehq.org/git/wine.git/?a=commit;h=9f182396fb600c550e26d6b03… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Dec 10 16:38:19 2010 +0100 mshtml: Added IViewObjectEx iface to plugin test. --- dlls/mshtml/tests/activex.c | 122 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 122 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 16c91ec..a2a92c5 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -291,6 +291,11 @@ static HRESULT WINAPI QuickActivate_QuickActivate(IQuickActivate *iface, QACONTA IOleClientSite_AddRef(container->pClientSite); client_site = container->pClientSite; + control->dwMiscStatus = OLEMISC_SETCLIENTSITEFIRST|OLEMISC_ACTIVATEWHENVISIBLE|OLEMISC_INSIDEOUT + |OLEMISC_CANTLINKINSIDE|OLEMISC_RECOMPOSEONRESIZE; + control->dwViewStatus = 0x18; + control->dwPropNotifyCookie = 1; + return S_OK; } @@ -534,6 +539,118 @@ static const IDispatchVtbl DispatchVtbl = { static IDispatch Dispatch = { &DispatchVtbl }; +static HRESULT WINAPI ViewObjectEx_QueryInterface(IViewObjectEx *iface, REFIID riid, void **ppv) +{ + return ax_qi(riid, ppv); +} + +static ULONG WINAPI ViewObjectEx_AddRef(IViewObjectEx *iface) +{ + return 2; +} + +static ULONG WINAPI ViewObjectEx_Release(IViewObjectEx *iface) +{ + return 1; +} + +static HRESULT WINAPI ViewObjectEx_Draw(IViewObjectEx *iface, DWORD dwDrawAspect, LONG lindex, void *pvAspect, DVTARGETDEVICE *ptd, + HDC hdcTargetDev, HDC hdcDraw, LPCRECTL lprcBounds, LPCRECTL lprcWBoungs, BOOL (WINAPI*pfnContinue)(ULONG_PTR), ULONG_PTR dwContinue) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetColorSet(IViewObjectEx *iface, DWORD dwDrawAspect, LONG lindex, void *pvAspect, DVTARGETDEVICE *ptd, + HDC hicTargetDev, LOGPALETTE **ppColorSet) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_Freeze(IViewObjectEx *iface, DWORD dwDrawAspect, LONG lindex, void *pvAspect, DWORD *pdwFreeze) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_Unfreeze(IViewObjectEx *iface, DWORD dwFreeze) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_SetAdvise(IViewObjectEx *iface, DWORD aspects, DWORD advf, IAdviseSink *pAdvSink) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetAdvise(IViewObjectEx *iface, DWORD *pAspects, DWORD *pAdvf, IAdviseSink **ppAdvSink) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetExtent(IViewObjectEx *iface, DWORD dwDrawAspect, LONG lindex, DVTARGETDEVICE *ptd, LPSIZEL lpsizel) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetRect(IViewObjectEx *iface, DWORD dwAspect, LPRECTL pRect) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetViewStatus(IViewObjectEx *iface, DWORD *pdwStatus) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_QueryHitPoint(IViewObjectEx *iface, DWORD dwAspect, LPCRECT pRectBounds, POINT ptlLoc, + LONG lCloseHint, DWORD *pHitResult) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_QueryHitRect(IViewObjectEx *iface, DWORD dwAspect, LPCRECT pRectBounds, LPCRECT pRectLoc, + LONG lCloseHint, DWORD *pHitResult) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ViewObjectEx_GetNaturalExtent(IViewObjectEx *iface, DWORD dwAspect, LONG lindex, DVTARGETDEVICE *ptd, + HDC hicTargetDev, DVEXTENTINFO *pExtentIngo, LPSIZEL pSizel) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static const IViewObjectExVtbl ViewObjectExVtbl = { + ViewObjectEx_QueryInterface, + ViewObjectEx_AddRef, + ViewObjectEx_Release, + ViewObjectEx_Draw, + ViewObjectEx_GetColorSet, + ViewObjectEx_Freeze, + ViewObjectEx_Unfreeze, + ViewObjectEx_SetAdvise, + ViewObjectEx_GetAdvise, + ViewObjectEx_GetExtent, + ViewObjectEx_GetRect, + ViewObjectEx_GetViewStatus, + ViewObjectEx_QueryHitPoint, + ViewObjectEx_QueryHitRect, + ViewObjectEx_GetNaturalExtent +}; + +static IViewObjectEx ViewObjectEx = { &ViewObjectExVtbl }; + static HRESULT ax_qi(REFIID riid, void **ppv) { if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IOleControl)) { @@ -556,6 +673,11 @@ static HRESULT ax_qi(REFIID riid, void **ppv) return S_OK; } + if(IsEqualGUID(riid, &IID_IViewObject) || IsEqualGUID(riid, &IID_IViewObject2) || IsEqualGUID(riid, &IID_IViewObjectEx)) { + *ppv = &ViewObjectEx; + return S_OK; + } + *ppv = NULL; return E_NOINTERFACE; }

1 0

Jacek Caban : mshtml: Added OnChanged(DISPID_READYSTATE) semi-stub implementation.
by Alexandre Julliard Dec. 10, 2010

Dec. 10, 2010

Module: wine Branch: master Commit: 06f3b1a34380490636824eee2f62df3ca1307203 URL: http://source.winehq.org/git/wine.git/?a=commit;h=06f3b1a34380490636824eee2… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Dec 10 16:37:08 2010 +0100 mshtml: Added OnChanged(DISPID_READYSTATE) semi-stub implementation. --- dlls/mshtml/pluginhost.c | 43 +++++++++++++++- dlls/mshtml/tests/activex.c | 114 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 155 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/pluginhost.c b/dlls/mshtml/pluginhost.c index d1932de..d7a83e7 100644 --- a/dlls/mshtml/pluginhost.c +++ b/dlls/mshtml/pluginhost.c @@ -60,6 +60,34 @@ static BOOL check_load_safety(PluginHost *host) return policy == URLPOLICY_ALLOW; } +static void update_readystate(PluginHost *host) +{ + DISPPARAMS params = {NULL,NULL,0,0}; + IDispatchEx *dispex; + IDispatch *disp; + ULONG err = 0; + VARIANT v; + HRESULT hres; + + hres = IUnknown_QueryInterface(host->plugin_unk, &IID_IDispatchEx, (void**)&dispex); + if(SUCCEEDED(hres)) { + FIXME("Use IDispatchEx\n"); + IDispatchEx_Release(dispex); + } + + hres = IUnknown_QueryInterface(host->plugin_unk, &IID_IDispatch, (void**)&disp); + if(FAILED(hres)) + return; + + hres = IDispatch_Invoke(disp, DISPID_READYSTATE, &IID_NULL, 0, DISPATCH_PROPERTYGET, &params, &v, NULL, &err); + IDispatch_Release(disp); + if(SUCCEEDED(hres)) { + /* FIXME: make plugin readystate affect document readystate */ + TRACE("readystate = %s\n", debugstr_variant(&v)); + VariantClear(&v); + } +} + static void load_prop_bag(PluginHost *host, IPersistPropertyBag *persist_prop_bag) { IPropertyBag *prop_bag; @@ -399,8 +427,19 @@ static ULONG WINAPI PHPropertyNotifySink_Release(IPropertyNotifySink *iface) static HRESULT WINAPI PHPropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) { PluginHost *This = impl_from_IPropertyNotifySink(iface); - FIXME("(%p)->(%d)\n", This, dispID); - return E_NOTIMPL; + + TRACE("(%p)->(%d)\n", This, dispID); + + switch(dispID) { + case DISPID_READYSTATE: + update_readystate(This); + break; + default : + FIXME("Unimplemented dispID %d\n", dispID); + return E_NOTIMPL; + } + + return S_OK; } static HRESULT WINAPI PHPropertyNotifySink_OnRequestEdit(IPropertyNotifySink *iface, DISPID dispID) diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 2229d51..9d8e668 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -62,6 +62,7 @@ DEFINE_EXPECT(FreezeEvents_FALSE); DEFINE_EXPECT(QuickActivate); DEFINE_EXPECT(IPersistPropertyBag_InitNew); DEFINE_EXPECT(IPersistPropertyBag_Load); +DEFINE_EXPECT(Invoke_READYSTATE); static HWND container_hwnd; @@ -142,6 +143,25 @@ static int strcmp_wa(LPCWSTR strw, const char *stra) return lstrcmpA(stra, buf); } +static IOleClientSite *client_site; +static READYSTATE plugin_readystate = READYSTATE_UNINITIALIZED; + +static void set_plugin_readystate(READYSTATE state) +{ + IPropertyNotifySink *prop_notif; + HRESULT hres; + + plugin_readystate = state; + + hres = IOleClientSite_QueryInterface(client_site, &IID_IPropertyNotifySink, (void**)&prop_notif); + ok(hres == S_OK, "Could not get IPropertyNotifySink iface: %08x\n", hres); + + hres = IPropertyNotifySink_OnChanged(prop_notif, DISPID_READYSTATE); + ok(hres == S_OK, "OnChanged(DISPID_READYSTATE) failed: %08x\n", hres); + + IPropertyNotifySink_Release(prop_notif); +} + static HRESULT ax_qi(REFIID,void**); static HRESULT WINAPI OleControl_QueryInterface(IOleControl *iface, REFIID riid, void **ppv) @@ -252,6 +272,9 @@ static HRESULT WINAPI QuickActivate_QuickActivate(IQuickActivate *iface, QACONTA "container->pClientSite != container->pPropertyNotifySink\n"); test_ifaces((IUnknown*)container->pClientSite, pluginhost_iids); + IOleClientSite_AddRef(container->pClientSite); + client_site = container->pClientSite; + return S_OK; } @@ -360,6 +383,9 @@ static HRESULT WINAPI PersistPropertyBag_Load(IPersistPropertyBag *face, IProper ok(V_VT(&v) == VT_BSTR, "V_VT(&v) = %d\n", V_VT(&v)); ok(V_BSTR(&v) == (BSTR)0xdeadbeef, "V_BSTR(v) = %p\n", V_BSTR(&v)); + set_plugin_readystate(READYSTATE_INTERACTIVE); + set_plugin_readystate(READYSTATE_COMPLETE); + return S_OK; } @@ -382,6 +408,82 @@ static const IPersistPropertyBagVtbl PersistPropertyBagVtbl = { static IPersistPropertyBag PersistPropertyBag = { &PersistPropertyBagVtbl }; +static HRESULT WINAPI Dispatch_QueryInterface(IDispatch *iface, REFIID riid, void **ppv) +{ + return ax_qi(riid, ppv); +} + +static ULONG WINAPI Dispatch_AddRef(IDispatch *iface) +{ + return 2; +} + +static ULONG WINAPI Dispatch_Release(IDispatch *iface) +{ + return 1; +} + +static HRESULT WINAPI Dispatch_GetTypeInfoCount(IDispatch *iface, UINT *pctinfo) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI Dispatch_GetTypeInfo(IDispatch *iface, UINT iTInfo, LCID lcid, + ITypeInfo **ppTInfo) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI Dispatch_GetIDsOfNames(IDispatch *iface, REFIID riid, LPOLESTR *rgszNames, + UINT cNames, LCID lcid, DISPID *rgDispId) +{ + ok(0, "unexpected call\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI Dispatch_Invoke(IDispatch *iface, DISPID dispIdMember, REFIID riid, + LCID lcid, WORD wFlags, DISPPARAMS *pDispParams, VARIANT *pVarResult, + EXCEPINFO *pExcepInfo, UINT *puArgErr) +{ + ok(IsEqualGUID(riid, &IID_NULL), "riid = %s\n", debugstr_guid(riid)); + ok(pDispParams != NULL, "pDispParams == NULL\n"); + ok(!pDispParams->cNamedArgs, "pDispParams->cNamedArgs = %d\n", pDispParams->cNamedArgs); + ok(!pDispParams->rgdispidNamedArgs, "pDispParams->rgdispidNamedArgs != NULL\n"); + ok(pVarResult != NULL, "pVarResult == NULL\n"); + ok(!pExcepInfo, "pExcepInfo != NULL\n"); + ok(puArgErr != NULL, "puArgErr == NULL\n"); + + switch(dispIdMember) { + case DISPID_READYSTATE: + CHECK_EXPECT2(Invoke_READYSTATE); + ok(wFlags == DISPATCH_PROPERTYGET, "wFlags = %x\n", wFlags); + ok(!pDispParams->cArgs, "pDispParams->cArgs = %d\n", pDispParams->cArgs); + ok(!pDispParams->rgvarg, "pDispParams->rgvarg != NULL\n"); + + V_VT(pVarResult) = VT_I4; + V_I4(pVarResult) = plugin_readystate; + return S_OK; + default: + ok(0, "unexpected call %d\n", dispIdMember); + } + + return E_NOTIMPL; +} + +static const IDispatchVtbl DispatchVtbl = { + Dispatch_QueryInterface, + Dispatch_AddRef, + Dispatch_Release, + Dispatch_GetTypeInfoCount, + Dispatch_GetTypeInfo, + Dispatch_GetIDsOfNames, + Dispatch_Invoke +}; + +static IDispatch Dispatch = { &DispatchVtbl }; + static HRESULT ax_qi(REFIID riid, void **ppv) { if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IOleControl)) { @@ -399,6 +501,11 @@ static HRESULT ax_qi(REFIID riid, void **ppv) return S_OK; } + if(IsEqualGUID(riid, &IID_IDispatch)) { + *ppv = &Dispatch; + return S_OK; + } + *ppv = NULL; return E_NOINTERFACE; } @@ -1004,6 +1111,11 @@ static void release_doc(IHTMLDocument2 *doc) { ULONG ref; + if(client_site) { + IOleClientSite_Release(client_site); + client_site = NULL; + } + set_client_site(doc, FALSE); ref = IHTMLDocument2_Release(doc); ok(!ref, "ref = %d\n", ref); @@ -1023,6 +1135,7 @@ static void test_object_ax(void) SET_EXPECT(QuickActivate); SET_EXPECT(FreezeEvents_FALSE); SET_EXPECT(IPersistPropertyBag_Load); + SET_EXPECT(Invoke_READYSTATE); doc = create_doc(object_ax_str, &called_CreateInstance); @@ -1033,6 +1146,7 @@ static void test_object_ax(void) todo_wine CHECK_CALLED(FreezeEvents_FALSE); CHECK_CALLED(IPersistPropertyBag_Load); + CHECK_CALLED(Invoke_READYSTATE); release_doc(doc); }

1 0