February 2010 - Wine-Commits

Alexandre Julliard : winetest: Require an email address to submit a report.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: 6fae8e1df1bc604b491c75c4d227b66fc33b5f1d URL: http://source.winehq.org/git/wine.git/?a=commit;h=6fae8e1df1bc604b491c75c4d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Feb 6 10:21:22 2010 +0100 winetest: Require an email address to submit a report. --- programs/winetest/gui.c | 33 +++++++++++++++++++++++++++++++++ programs/winetest/main.c | 17 +++++++++++++++++ programs/winetest/resource.h | 2 ++ programs/winetest/winetest.h | 2 ++ programs/winetest/winetest.rc | 11 +++++++++++ 5 files changed, 65 insertions(+), 0 deletions(-) diff --git a/programs/winetest/gui.c b/programs/winetest/gui.c index cb59ac2..7a7b1e0 100644 --- a/programs/winetest/gui.c +++ b/programs/winetest/gui.c @@ -361,6 +361,39 @@ guiAskTag (void) dialog, AskTagProc); } +static INT_PTR CALLBACK +AskEmailProc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) +{ + int len; + + switch (msg) + { + case WM_COMMAND: + switch (LOWORD (wParam)) { + case IDOK: + len = GetWindowTextLengthA (GetDlgItem (hwnd, IDC_EMAIL)); + if(!len) { + report (R_WARNING, "You must enter an email address to continue"); + return FALSE; + } + email = heap_alloc (len+1); + GetDlgItemTextA (hwnd, IDC_EMAIL, email, len+1); + EndDialog (hwnd, IDOK); + return TRUE; + case IDABORT: + EndDialog (hwnd, IDABORT); + return TRUE; + } + } + return FALSE; +} + +int +guiAskEmail (void) +{ + return DialogBox (GetModuleHandle (NULL), MAKEINTRESOURCE (IDD_EMAIL), dialog, AskEmailProc); +} + /* Quiet functions */ static int qNoOp (va_list ap) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 69b7da6..a20fa06 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -48,6 +48,7 @@ struct wine_test }; char *tag = NULL; +char *email = NULL; static struct wine_test *wine_tests; static int nr_of_files, nr_of_tests; static int nr_native_dlls; @@ -221,6 +222,7 @@ static void print_version (void) xprintf (" Platform=%s%s\n", platform, wow64 ? " (WOW64)" : ""); xprintf (" bRunningUnderWine=%d\n", running_under_wine ()); xprintf (" bRunningOnVisibleDesktop=%d\n", running_on_visible_desktop ()); + xprintf (" Submitter=%s\n", email ); xprintf (" dwMajorVersion=%u\n dwMinorVersion=%u\n" " dwBuildNumber=%u\n PlatformId=%u\n szCSDVersion=%s\n", ver.dwMajorVersion, ver.dwMinorVersion, ver.dwBuildNumber, @@ -921,6 +923,7 @@ usage (void) " -d DIR Use DIR as temp directory (default: %%TEMP%%\\wct)\n" " -e preserve the environment\n" " -h print this message and exit\n" +" -m MAIL an email address to enable developers to contact you\n" " -p shutdown when the tests are done\n" " -q quiet mode, no output at all\n" " -o FILE put report into FILE, do not submit\n" @@ -971,6 +974,13 @@ int main( int argc, char *argv[] ) case '?': usage (); exit (0); + case 'm': + if (!(email = argv[++i])) + { + usage(); + exit( 2 ); + } + break; case 'p': poweroff = 1; break; @@ -1056,6 +1066,13 @@ int main( int argc, char *argv[] ) } report (R_TAG); + while (!email) { + if (!interactive) + report (R_FATAL, "Please specify an email address (-m option) to enable developers\n" + " to contact you about your report if necessary."); + if (guiAskEmail () == IDABORT) exit (1); + } + if (!build_id[0]) report( R_WARNING, "You won't be able to submit results without a valid build id.\n" "To submit results, winetest needs to be built from a git checkout." ); diff --git a/programs/winetest/resource.h b/programs/winetest/resource.h index b0f1646..be71274 100644 --- a/programs/winetest/resource.h +++ b/programs/winetest/resource.h @@ -23,6 +23,7 @@ #define IDD_STATUS 100 #define IDD_ABOUT 101 #define IDD_TAG 102 +#define IDD_EMAIL 103 #define IDC_STATIC -1 @@ -36,6 +37,7 @@ #define IDC_DIR 2000 #define IDC_OUT 2001 #define IDC_TAG 2002 +#define IDC_EMAIL 2002 #define IDC_SB 3000 diff --git a/programs/winetest/winetest.h b/programs/winetest/winetest.h index 945586c..a0d2fbd 100644 --- a/programs/winetest/winetest.h +++ b/programs/winetest/winetest.h @@ -68,7 +68,9 @@ enum report_type { #define MAXTAGLEN 20 extern char *tag; +extern char *email; int guiAskTag (void); +int guiAskEmail (void); int report (enum report_type t, ...); #endif /* __WINETESTS_H */ diff --git a/programs/winetest/winetest.rc b/programs/winetest/winetest.rc index 52c3430..5b5d6e0 100644 --- a/programs/winetest/winetest.rc +++ b/programs/winetest/winetest.rc @@ -35,6 +35,17 @@ BEGIN PUSHBUTTON "Abort", IDABORT, 85, 45, 40, 14 END +IDD_EMAIL DIALOG 0, 0, 150, 65 +STYLE WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "No email supplied" +BEGIN + CTEXT "Please supply an email address to enable developers to contact you about your report." + IDC_STATIC, 10, 5, 130, 30 + EDITTEXT IDC_EMAIL, 10, 30, 130, 10, ES_AUTOHSCROLL + DEFPUSHBUTTON "Start", IDOK, 25, 45, 40, 14 + PUSHBUTTON "Abort", IDABORT, 85, 45, 40, 14 +END + IDD_STATUS DIALOG 0, 0, 160, 150 STYLE WS_OVERLAPPED | WS_CAPTION | WS_SYSMENU | WS_MINIMIZEBOX CAPTION "Wine Test Shell"

1 0

Vincent Povirk : winemenubuilder: Use a custom error function.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: 7f8279e1277f4495c1ab8fd624c73581ec1da2ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f8279e1277f4495c1ab8fd62… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Feb 5 12:14:18 2010 -0600 winemenubuilder: Use a custom error function. --- programs/winemenubuilder/winemenubuilder.c | 26 ++++++++++++++++++++++++-- 1 files changed, 24 insertions(+), 2 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index e14fe81..62165f6 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -188,8 +188,10 @@ static void *libpng_handle; MAKE_FUNCPTR(png_create_info_struct); MAKE_FUNCPTR(png_create_write_struct); MAKE_FUNCPTR(png_destroy_write_struct); +MAKE_FUNCPTR(png_get_error_ptr); MAKE_FUNCPTR(png_init_io); MAKE_FUNCPTR(png_set_bgr); +MAKE_FUNCPTR(png_set_error_fn); MAKE_FUNCPTR(png_set_text); MAKE_FUNCPTR(png_set_IHDR); MAKE_FUNCPTR(png_write_end); @@ -209,8 +211,10 @@ static void *load_libpng(void) LOAD_FUNCPTR(png_create_info_struct); LOAD_FUNCPTR(png_create_write_struct); LOAD_FUNCPTR(png_destroy_write_struct); + LOAD_FUNCPTR(png_get_error_ptr); LOAD_FUNCPTR(png_init_io); LOAD_FUNCPTR(png_set_bgr); + LOAD_FUNCPTR(png_set_error_fn); LOAD_FUNCPTR(png_set_IHDR); LOAD_FUNCPTR(png_set_text); LOAD_FUNCPTR(png_write_end); @@ -221,6 +225,23 @@ static void *load_libpng(void) return libpng_handle; } +static void user_error_fn(png_structp png_ptr, png_const_charp error_message) +{ + jmp_buf *pjmpbuf; + + /* This uses setjmp/longjmp just like the default. We can't use the + * default because there's no way to access the jmp buffer in the png_struct + * that works in 1.2 and 1.4 and allows us to dynamically load libpng. */ + WINE_ERR("PNG error: %s\n", wine_dbgstr_an(error_message, -1)); + pjmpbuf = ppng_get_error_ptr(png_ptr); + longjmp(*pjmpbuf, 1); +} + +static void user_warning_fn(png_structp png_ptr, png_const_charp warning_message) +{ + WINE_WARN("PNG warning: %s\n", wine_dbgstr_an(warning_message, -1)); +} + static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, LPCWSTR commentW) { static const char comment_key[] = "Created from"; @@ -234,6 +255,7 @@ static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, int nWidth = pIcon->bmiHeader.biWidth; int nHeight = pIcon->bmiHeader.biHeight; int nBpp = pIcon->bmiHeader.biBitCount; + jmp_buf jmpbuf; switch (nBpp) { @@ -306,12 +328,12 @@ static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, !(info_ptr = ppng_create_info_struct(png_ptr))) goto error; - if (setjmp(png_jmpbuf(png_ptr))) + if (setjmp(jmpbuf)) { /* All future errors jump here */ - WINE_ERR("png error\n"); goto error; } + ppng_set_error_fn(png_ptr, &jmpbuf, user_error_fn, user_warning_fn); ppng_init_io(png_ptr, fp); ppng_set_IHDR(png_ptr, info_ptr, nWidth, nHeight, 8,

1 0

Alistair Leslie-Hughes : dbghelp: Add basic support for PVOID64.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: d02040d98a7e689dcaf26dc2c9fbc112e523f7c4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d02040d98a7e689dcaf26dc2c… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Wed Feb 3 12:41:51 2010 +1100 dbghelp: Add basic support for PVOID64. --- dlls/dbghelp/msc.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c index b7adabd..ee394cd 100644 --- a/dlls/dbghelp/msc.c +++ b/dlls/dbghelp/msc.c @@ -95,7 +95,7 @@ static void dump(const void* ptr, unsigned len) * Process CodeView type information. */ -#define MAX_BUILTIN_TYPES 0x0480 +#define MAX_BUILTIN_TYPES 0x0604 #define FIRST_DEFINABLE_TYPE 0x1000 static struct symt* cv_basic_types[MAX_BUILTIN_TYPES]; @@ -113,6 +113,7 @@ static struct cv_defined_module*cv_current_module; static void codeview_init_basic_types(struct module* module) { + struct symt_udt* udt; /* * These are the common builtin types that are used by VC++. */ @@ -169,6 +170,12 @@ static void codeview_init_basic_types(struct module* module) cv_basic_types[T_32PINT8] = &symt_new_pointer(module, cv_basic_types[T_INT8])->symt; cv_basic_types[T_32PUINT8] = &symt_new_pointer(module, cv_basic_types[T_UINT8])->symt; cv_basic_types[T_32PHRESULT]= &symt_new_pointer(module, cv_basic_types[T_HRESULT])->symt; + + /* The .pdb file can refer to 64 bit pointers values even on 32 bits applications. */ + udt = symt_new_udt(module, "PVOID64", 8, UdtStruct); + symt_add_udt_element(module, udt, "ptr64_low", cv_basic_types[T_LONG], 0, 32); + symt_add_udt_element(module, udt, "ptr64_high", cv_basic_types[T_LONG], 32, 32); + cv_basic_types[0x603]= &udt->symt; } static int leaf_as_variant(VARIANT* v, const unsigned short int* leaf)

1 0

Jacek Caban : jscript: Don't try to create property in jsdisp_call_name.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: bf17483a195493bb5016ef604b91be04c8a9d5da URL: http://source.winehq.org/git/wine.git/?a=commit;h=bf17483a195493bb5016ef604… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Feb 5 23:14:35 2010 +0100 jscript: Don't try to create property in jsdisp_call_name. --- dlls/jscript/dispex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 492623e..19fdd56 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -878,7 +878,7 @@ HRESULT jsdisp_call_name(DispatchEx *disp, const WCHAR *name, WORD flags, DISPPA dispex_prop_t *prop; HRESULT hres; - hres = find_prop_name_prot(disp, name, TRUE, &prop); + hres = find_prop_name_prot(disp, name, FALSE, &prop); if(FAILED(hres)) return hres;

1 0

Jacek Caban : jscript: Get value as VARIANT in prop_put.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: 10c9931051158c7506c73b2c0162230db6e327b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=10c9931051158c7506c73b2c0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Feb 5 23:15:46 2010 +0100 jscript: Get value as VARIANT in prop_put. --- dlls/jscript/dispex.c | 71 +++++++++++++++++++++++++------------------------ 1 files changed, 36 insertions(+), 35 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index f2c22a9..c67fc41 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -350,19 +350,19 @@ static HRESULT prop_get(DispatchEx *This, dispex_prop_t *prop, DISPPARAMS *dp, return hres; } -static HRESULT prop_put(DispatchEx *This, dispex_prop_t *prop, DISPPARAMS *dp, +static HRESULT prop_put(DispatchEx *This, dispex_prop_t *prop, VARIANT *val, jsexcept_t *ei, IServiceProvider *caller) { - DWORD i; HRESULT hres; switch(prop->type) { case PROP_BUILTIN: if(!(prop->flags & PROPF_METHOD)) { + DISPPARAMS dp = {val, NULL, 1, 0}; vdisp_t vthis; set_jsdisp(&vthis, This); - hres = prop->u.p->invoke(This->ctx, &vthis, DISPATCH_PROPERTYPUT, dp, NULL, ei, caller); + hres = prop->u.p->invoke(This->ctx, &vthis, DISPATCH_PROPERTYPUT, &dp, NULL, ei, caller); vdisp_release(&vthis); return hres; } @@ -379,24 +379,14 @@ static HRESULT prop_put(DispatchEx *This, dispex_prop_t *prop, DISPPARAMS *dp, return E_FAIL; } - for(i=0; i < dp->cNamedArgs; i++) { - if(dp->rgdispidNamedArgs[i] == DISPID_PROPERTYPUT) - break; - } - - if(i == dp->cNamedArgs) { - TRACE("no value to set\n"); - return DISP_E_PARAMNOTOPTIONAL; - } - - hres = VariantCopy(&prop->u.var, dp->rgvarg+i); + hres = VariantCopy(&prop->u.var, val); if(FAILED(hres)) return hres; if(This->builtin_info->on_put) This->builtin_info->on_put(This, prop->name); - TRACE("%s = %s\n", debugstr_w(prop->name), debugstr_variant(dp->rgvarg+i)); + TRACE("%s = %s\n", debugstr_w(prop->name), debugstr_variant(val)); return S_OK; } @@ -589,9 +579,22 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc case DISPATCH_PROPERTYGET: hres = prop_get(This, prop, pdp, pvarRes, &jsexcept, pspCaller); break; - case DISPATCH_PROPERTYPUT: - hres = prop_put(This, prop, pdp, &jsexcept, pspCaller); + case DISPATCH_PROPERTYPUT: { + DWORD i; + + for(i=0; i < pdp->cNamedArgs; i++) { + if(pdp->rgdispidNamedArgs[i] == DISPID_PROPERTYPUT) + break; + } + + if(i == pdp->cNamedArgs) { + TRACE("no value to set\n"); + return DISP_E_PARAMNOTOPTIONAL; + } + + hres = prop_put(This, prop, pdp->rgvarg+i, &jsexcept, pspCaller); break; + } default: FIXME("Unimplemented flags %x\n", wFlags); return E_INVALIDARG; @@ -941,8 +944,6 @@ HRESULT disp_call(script_ctx_t *ctx, IDispatch *disp, DISPID id, WORD flags, DIS HRESULT jsdisp_propput_name(DispatchEx *obj, const WCHAR *name, VARIANT *val, jsexcept_t *ei, IServiceProvider *caller) { - DISPID named_arg = DISPID_PROPERTYPUT; - DISPPARAMS dp = {val, &named_arg, 1, 1}; dispex_prop_t *prop; HRESULT hres; @@ -950,7 +951,7 @@ HRESULT jsdisp_propput_name(DispatchEx *obj, const WCHAR *name, VARIANT *val, js if(FAILED(hres)) return hres; - return prop_put(obj, prop, &dp, ei, caller); + return prop_put(obj, prop, val, ei, caller); } HRESULT jsdisp_propput_idx(DispatchEx *obj, DWORD idx, VARIANT *val, jsexcept_t *ei, IServiceProvider *caller) @@ -965,9 +966,6 @@ HRESULT jsdisp_propput_idx(DispatchEx *obj, DWORD idx, VARIANT *val, jsexcept_t HRESULT disp_propput(script_ctx_t *ctx, IDispatch *disp, DISPID id, VARIANT *val, jsexcept_t *ei, IServiceProvider *caller) { - DISPID dispid = DISPID_PROPERTYPUT; - DISPPARAMS dp = {val, &dispid, 1, 1}; - IDispatchEx *dispex; DispatchEx *jsdisp; HRESULT hres; @@ -977,25 +975,28 @@ HRESULT disp_propput(script_ctx_t *ctx, IDispatch *disp, DISPID id, VARIANT *val prop = get_prop(jsdisp, id); if(prop) - hres = prop_put(jsdisp, prop, &dp, ei, caller); + hres = prop_put(jsdisp, prop, val, ei, caller); else hres = DISP_E_MEMBERNOTFOUND; jsdisp_release(jsdisp); - return hres; - } - - hres = IDispatch_QueryInterface(disp, &IID_IDispatchEx, (void**)&dispex); - if(FAILED(hres)) { - ULONG err = 0; + }else { + DISPID dispid = DISPID_PROPERTYPUT; + DISPPARAMS dp = {val, &dispid, 1, 1}; + IDispatchEx *dispex; + + hres = IDispatch_QueryInterface(disp, &IID_IDispatchEx, (void**)&dispex); + if(SUCCEEDED(hres)) { + hres = IDispatchEx_InvokeEx(dispex, id, ctx->lcid, DISPATCH_PROPERTYPUT, &dp, NULL, &ei->ei, caller); + IDispatchEx_Release(dispex); + }else { + ULONG err = 0; - TRACE("using IDispatch\n"); - return IDispatch_Invoke(disp, id, &IID_NULL, ctx->lcid, DISPATCH_PROPERTYPUT, &dp, NULL, &ei->ei, &err); + TRACE("using IDispatch\n"); + hres = IDispatch_Invoke(disp, id, &IID_NULL, ctx->lcid, DISPATCH_PROPERTYPUT, &dp, NULL, &ei->ei, &err); + } } - hres = IDispatchEx_InvokeEx(dispex, id, ctx->lcid, DISPATCH_PROPERTYPUT, &dp, NULL, &ei->ei, caller); - - IDispatchEx_Release(dispex); return hres; }

1 0

Jacek Caban : jscript: Added support for constructor property.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: 9fd4f4a44a5704a839103bfed7e03b1206d31086 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9fd4f4a44a5704a839103bfed… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Feb 5 23:17:35 2010 +0100 jscript: Added support for constructor property. --- dlls/jscript/dispex.c | 17 +++++++++++++++++ dlls/jscript/tests/lang.js | 5 +++++ dlls/jscript/tests/regexp.js | 1 + 3 files changed, 23 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index c420f54..6894eae 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -803,6 +803,7 @@ HRESULT init_dispex_from_constr(DispatchEx *dispex, script_ctx_t *ctx, const bui dispex_prop_t *prop; HRESULT hres; + static const WCHAR constructorW[] = {'c','o','n','s','t','r','u','c','t','o','r'}; static const WCHAR prototypeW[] = {'p','r','o','t','o','t','y','p','e',0}; hres = find_prop_name_prot(constr, prototypeW, &prop); @@ -827,6 +828,22 @@ HRESULT init_dispex_from_constr(DispatchEx *dispex, script_ctx_t *ctx, const bui if(prot) jsdisp_release(prot); + if(FAILED(hres)) + return hres; + + hres = ensure_prop_name(dispex, constructorW, FALSE, 0, &prop); + if(SUCCEEDED(hres)) { + jsexcept_t jsexcept; + VARIANT var; + + V_VT(&var) = VT_DISPATCH; + V_DISPATCH(&var) = (IDispatch*)_IDispatchEx_(constr); + memset(&jsexcept, 0, sizeof(jsexcept)); + hres = prop_put(dispex, prop, &var, &jsexcept, NULL/*FIXME*/); + } + if(FAILED(hres)) + jsdisp_release(dispex); + return hres; } diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index d91b1f2..495762e 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -116,6 +116,7 @@ ok(tmp === 1, "tmp = " + tmp); var obj1 = new Object(); ok(typeof(obj1) === "object", "typeof(obj1) is not object"); +ok(obj1.constructor === Object, "unexpected obj1.constructor"); obj1.test = true; obj1.func = function () { ok(this === obj1, "this is not obj1"); @@ -144,6 +145,7 @@ testConstr1.prototype.pvar = 1; var obj2 = new testConstr1(true); ok(typeof(obj2) === "object", "typeof(obj2) is not object"); +ok(obj2.constructor === testConstr1, "unexpected obj2.constructor"); ok(obj2.pvar === 1, "obj2.pvar is not 1"); testConstr1.prototype.pvar = 2; @@ -209,6 +211,7 @@ if(false) { var obj3 = { prop1: 1, prop2: typeof(false) }; ok(obj3.prop1 === 1, "obj3.prop1 is not 1"); ok(obj3.prop2 === "boolean", "obj3.prop2 is not \"boolean\""); +ok(obj3.constructor === Object, "unexpected obj3.constructor"); { var blockVar = 1; @@ -422,8 +425,10 @@ ok(+"3e3" === 3000, "+'3e3' !== 3000"); tmp = new Number(1); ok(+tmp === 1, "+(new Number(1)) = " + (+tmp)); +ok(tmp.constructor === Number, "unexpected tmp.constructor"); tmp = new String("1"); ok(+tmp === 1, "+(new String('1')) = " + (+tmp)); +ok(tmp.constructor === String, "unexpected tmp.constructor"); ok("" + 0 === "0", "\"\" + 0 !== \"0\""); ok("" + 123 === "123", "\"\" + 123 !== \"123\""); diff --git a/dlls/jscript/tests/regexp.js b/dlls/jscript/tests/regexp.js index d09d787..fac1112 100644 --- a/dlls/jscript/tests/regexp.js +++ b/dlls/jscript/tests/regexp.js @@ -100,6 +100,7 @@ m = "abcabc".match(re = /ca/); ok(typeof(m) === "object", "typeof m is not object"); ok(m.length === 1, "m.length is not 1"); ok(m["0"] === "ca", "m[0] is not \"ca\""); +ok(m.constructor === Array, "unexpected m.constructor"); ok(re.lastIndex === 4, "re.lastIndex = " + re.lastIndex); m = "abcabc".match(/ab/);

1 0

Jacek Caban : jscript: Avoid unnecessary prototype lookup.
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: 75ab8e2027379f952ddd8ee67497942323fa6c59 URL: http://source.winehq.org/git/wine.git/?a=commit;h=75ab8e2027379f952ddd8ee67… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Feb 5 23:17:06 2010 +0100 jscript: Avoid unnecessary prototype lookup. --- dlls/jscript/dispex.c | 11 +++++++---- 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index c67fc41..c420f54 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -190,12 +190,15 @@ static HRESULT find_prop_name_prot(DispatchEx *This, const WCHAR *name, dispex_p return S_OK; } -static HRESULT ensure_prop_name(DispatchEx *This, const WCHAR *name, DWORD create_flags, dispex_prop_t **ret) +static HRESULT ensure_prop_name(DispatchEx *This, const WCHAR *name, BOOL search_prot, DWORD create_flags, dispex_prop_t **ret) { dispex_prop_t *prop; HRESULT hres; - hres = find_prop_name_prot(This, name, &prop); + if(search_prot) + hres = find_prop_name_prot(This, name, &prop); + else + hres = find_prop_name(This, name, &prop); if(SUCCEEDED(hres) && !prop) { TRACE("creating prop %s\n", debugstr_w(name)); @@ -845,7 +848,7 @@ HRESULT jsdisp_get_id(DispatchEx *jsdisp, const WCHAR *name, DWORD flags, DISPID HRESULT hres; if(flags & fdexNameEnsure) - hres = ensure_prop_name(jsdisp, name, PROPF_ENUM, &prop); + hres = ensure_prop_name(jsdisp, name, TRUE, PROPF_ENUM, &prop); else hres = find_prop_name_prot(jsdisp, name, &prop); if(FAILED(hres)) @@ -947,7 +950,7 @@ HRESULT jsdisp_propput_name(DispatchEx *obj, const WCHAR *name, VARIANT *val, js dispex_prop_t *prop; HRESULT hres; - hres = ensure_prop_name(obj, name, PROPF_ENUM, &prop); + hres = ensure_prop_name(obj, name, FALSE, PROPF_ENUM, &prop); if(FAILED(hres)) return hres;

1 0

Nikolay Sivov : msxml3: Use libxml2 functionality to skip top XML declaration node while writing to file .
by Alexandre Julliard Feb. 8, 2010

Feb. 8, 2010

Module: wine Branch: master Commit: afad45fffea6be29e7a989d610f3753247f01a79 URL: http://source.winehq.org/git/wine.git/?a=commit;h=afad45fffea6be29e7a989d61… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Fri Feb 5 16:25:02 2010 +0300 msxml3: Use libxml2 functionality to skip top XML declaration node while writing to file. --- dlls/msxml3/domdoc.c | 56 +++++++++++++++++++++++++++---------------------- 1 files changed, 31 insertions(+), 25 deletions(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 4914a7c..a7c1680 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -47,6 +47,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(msxml); #ifdef HAVE_LIBXML2 +#include <libxml/xmlsave.h> + static const WCHAR SZ_PROPERTY_SELECTION_LANGUAGE[] = {'S','e','l','e','c','t','i','o','n','L','a','n','g','u','a','g','e',0}; static const WCHAR SZ_VALUE_XPATH[] = {'X','P','a','t','h',0}; static const WCHAR SZ_VALUE_XSLPATTERN[] = {'X','S','L','P','a','t','t','e','r','n',0}; @@ -1651,6 +1653,24 @@ static HRESULT WINAPI domdoc_loadXML( return hr; } +static int XMLCALL domdoc_save_writecallback(void *ctx, const char *buffer, + int len) +{ + DWORD written = -1; + + if(!WriteFile(ctx, buffer, len, &written, NULL)) + { + WARN("write error\n"); + return -1; + } + else + return written; +} + +static int XMLCALL domdoc_save_closecallback(void *ctx) +{ + return CloseHandle(ctx) ? 0 : -1; +} static HRESULT WINAPI domdoc_save( IXMLDOMDocument2 *iface, @@ -1658,10 +1678,8 @@ static HRESULT WINAPI domdoc_save( { domdoc *This = impl_from_IXMLDOMDocument2( iface ); HANDLE handle; - xmlChar *mem, *p; - int size; + xmlSaveCtxtPtr ctx; HRESULT ret = S_OK; - DWORD written; TRACE("(%p)->(var(vt %d, %s))\n", This, V_VT(&destination), V_VT(&destination) == VT_BSTR ? debugstr_w(V_BSTR(&destination)) : NULL); @@ -1707,31 +1725,19 @@ static HRESULT WINAPI domdoc_save( return S_FALSE; } - xmlDocDumpMemory(get_doc(This), &mem, &size); - - /* - * libxml2 always adds XML declaration on top of the file and one for each processing instruction node in DOM tree. - * MSXML adds XML declaration only for processing instruction nodes. - * We skip the first XML declaration generated by libxml2 to get exactly what we need. - */ - p = mem; - if(size > 2 && p[0] == '<' && p[1] == '?') { - while(p < mem+size && (p[0] != '?' || p[1] != '>')) - p++; - p += 2; - while(p < mem+size && isspace(*p)) - p++; - size -= p-mem; - } - - if(!WriteFile(handle, p, (DWORD)size, &written, NULL) || written != (DWORD)size) + /* disable top XML declaration */ + ctx = xmlSaveToIO(domdoc_save_writecallback, domdoc_save_closecallback, + handle, NULL, XML_SAVE_NO_DECL); + if (!ctx) { - WARN("write error\n"); - ret = S_FALSE; + CloseHandle(handle); + return S_FALSE; } - xmlFree(mem); - CloseHandle(handle); + if (xmlSaveDoc(ctx, get_doc(This)) == -1) ret = S_FALSE; + /* will close file through close callback */ + xmlSaveClose(ctx); + return ret; }

1 0

Alexandre Julliard : Wine release 1.1.38
by Alexandre Julliard Feb. 5, 2010

Feb. 5, 2010

Module: website Branch: master Commit: a9ef6bd5e5b5d9399c37674922e00562c134f016 URL: http://source.winehq.org/git/website.git/?a=commit;h=a9ef6bd5e5b5d9399c3767… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 5 18:38:24 2010 +0100 Wine release 1.1.38 --- news/en/2010020501.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/en/2010020501.xml b/news/en/2010020501.xml new file mode 100644 index 0000000..4f6c19e --- /dev/null +++ b/news/en/2010020501.xml @@ -0,0 +1,18 @@ +<news> +<date>February 5, 2010</date> +<title>Wine 1.1.38 Released</title> +<body> + The Wine development release 1.1.38 is now available. + <a href="{$root}/announce/1.1.38">What's new</a> in this release: +<ul> + <li>Better support for memory allocations debugging.</li> + <li>Improved MIDI support.</li> + <li>A wide range of Direct3D fixes.</li> + <li>OLEDB fixes (should fix Clipart in Office).</li> + <li>Improved debugger support on x86-64.</li> + <li>Many MSI fixes.</li> + <li>Various bug fixes.</li> +</ul> +The source is <a href="http://prdownloads.sourceforge.net/wine/wine-1.1.38.tar.bz2">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

Alexandre Julliard : configure: Avoid incorrectly cleaning up symlink targets when running in the source dir .
by Alexandre Julliard Feb. 5, 2010

Feb. 5, 2010

Module: wine Branch: master Commit: 9acf1d18ce8904830f19c5987e4324b8dc81f6db URL: http://source.winehq.org/git/wine.git/?a=commit;h=9acf1d18ce8904830f19c5987… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Feb 5 17:24:12 2010 +0100 configure: Avoid incorrectly cleaning up symlink targets when running in the source dir. --- aclocal.m4 | 2 +- configure | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index 3240435..357edf8 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -147,7 +147,7 @@ dnl dnl Usage: WINE_CONFIG_SYMLINK(name,target) dnl AC_DEFUN([WINE_CONFIG_SYMLINK],[AC_CONFIG_LINKS([$1:]m4_default([$2],[$1]))dnl -ALL_SYMLINKS="$ALL_SYMLINKS \\ +m4_if([$2],,[test "$srcdir" = "." || ])ALL_SYMLINKS="$ALL_SYMLINKS \\ $1"]) dnl **** Create a make rules file from config.status **** diff --git a/configure b/configure index f60272d..ab9c17b 100755 --- a/configure +++ b/configure @@ -13686,19 +13686,19 @@ ac_config_commands="$ac_config_commands include/stamp-h" ac_config_links="$ac_config_links dlls/wineps.drv/generic.ppd:dlls/wineps.drv/generic.ppd" -ALL_SYMLINKS="$ALL_SYMLINKS \\ +test "$srcdir" = "." || ALL_SYMLINKS="$ALL_SYMLINKS \\ dlls/wineps.drv/generic.ppd" ac_config_links="$ac_config_links fonts/marlett.ttf:fonts/marlett.ttf" -ALL_SYMLINKS="$ALL_SYMLINKS \\ +test "$srcdir" = "." || ALL_SYMLINKS="$ALL_SYMLINKS \\ fonts/marlett.ttf" ac_config_links="$ac_config_links fonts/symbol.ttf:fonts/symbol.ttf" -ALL_SYMLINKS="$ALL_SYMLINKS \\ +test "$srcdir" = "." || ALL_SYMLINKS="$ALL_SYMLINKS \\ fonts/symbol.ttf" ac_config_links="$ac_config_links fonts/tahoma.ttf:fonts/tahoma.ttf" -ALL_SYMLINKS="$ALL_SYMLINKS \\ +test "$srcdir" = "." || ALL_SYMLINKS="$ALL_SYMLINKS \\ fonts/tahoma.ttf" ac_config_links="$ac_config_links fonts/tahomabd.ttf:fonts/tahomabd.ttf" -ALL_SYMLINKS="$ALL_SYMLINKS \\ +test "$srcdir" = "." || ALL_SYMLINKS="$ALL_SYMLINKS \\ fonts/tahomabd.ttf" ac_config_links="$ac_config_links wine:tools/winewrapper" ALL_SYMLINKS="$ALL_SYMLINKS \\

1 0