May 2010 - Wine-Commits - list.winehq.org

Henri Verbeet : d3d8: Set the FPU control word on device creation.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 7d5666e084da03fad7f97ab235039d1afd530377 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d5666e084da03fad7f97ab23… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 26 09:41:37 2010 +0200 d3d8: Set the FPU control word on device creation. --- dlls/d3d8/device.c | 15 ++++++++ dlls/d3d8/tests/device.c | 86 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 101 insertions(+), 0 deletions(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 2312a6a..12ed0fb 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -2764,6 +2764,19 @@ static const IWineD3DDeviceParentVtbl d3d8_wined3d_device_parent_vtbl = device_parent_CreateSwapChain, }; +static void setup_fpu(void) +{ + WORD cw; + +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnstcw %0" : "=m" (cw)); + cw = (cw & ~0xf3f) | 0x3f; + __asm__ volatile ("fldcw %0" : : "m" (cw)); +#else + FIXME("FPU setup not implemented for this platform.\n"); +#endif +} + HRESULT device_init(IDirect3DDevice8Impl *device, IWineD3D *wined3d, UINT adapter, D3DDEVTYPE device_type, HWND focus_window, DWORD flags, D3DPRESENT_PARAMETERS *parameters) { @@ -2782,6 +2795,8 @@ HRESULT device_init(IDirect3DDevice8Impl *device, IWineD3D *wined3d, UINT adapte } device->handle_table.table_size = D3D8_INITIAL_HANDLE_TABLE_SIZE; + if (!(flags & D3DCREATE_FPU_PRESERVE)) setup_fpu(); + wined3d_mutex_lock(); hr = IWineD3D_CreateDevice(wined3d, adapter, device_type, focus_window, flags, (IUnknown *)device, (IWineD3DDeviceParent *)&device->device_parent_vtbl, &device->WineD3DDevice); diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index cd2df9a..b46ec4e 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -1797,6 +1797,89 @@ done: UnregisterClassA("d3d8_test_wndproc_wc", GetModuleHandleA(NULL)); } +static inline void set_fpu_cw(WORD cw) +{ +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnclex"); + __asm__ volatile ("fldcw %0" : : "m" (cw)); +#endif +} + +static inline WORD get_fpu_cw(void) +{ + WORD cw = 0; +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnstcw %0" : "=m" (cw)); +#endif + return cw; +} + +static void test_fpu_setup(void) +{ + D3DPRESENT_PARAMETERS present_parameters; + IDirect3DDevice8 *device; + D3DDISPLAYMODE d3ddm; + HWND window = NULL; + IDirect3D8 *d3d8; + HRESULT hr; + WORD cw; + + d3d8 = pDirect3DCreate8(D3D_SDK_VERSION); + ok(!!d3d8, "Failed to create a d3d8 object.\n"); + if (!d3d8) return; + + window = CreateWindowA("static", "d3d8_test", WS_CAPTION, 0, 0, 640, 480, 0, 0, 0, 0); + ok(!!window, "Failed to create a window.\n"); + if (!window) goto done; + + hr = IDirect3D8_GetAdapterDisplayMode(d3d8, D3DADAPTER_DEFAULT, &d3ddm); + ok(SUCCEEDED(hr), "GetAdapterDisplayMode failed, hr %#x.\n", hr); + + memset(&present_parameters, 0, sizeof(present_parameters)); + present_parameters.Windowed = TRUE; + present_parameters.hDeviceWindow = window; + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + present_parameters.BackBufferFormat = d3ddm.Format; + + set_fpu_cw(0xf60); + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + + hr = IDirect3D8_CreateDevice(d3d8, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, window, + D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device); + if (FAILED(hr)) + { + skip("Failed to create a device, hr %#x.\n", hr); + set_fpu_cw(0x37f); + goto done; + } + + cw = get_fpu_cw(); + ok(cw == 0x7f, "cw is %#x, expected 0x7f.\n", cw); + + IDirect3DDevice8_Release(device); + + cw = get_fpu_cw(); + ok(cw == 0x7f, "cw is %#x, expected 0x7f.\n", cw); + set_fpu_cw(0xf60); + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + + hr = IDirect3D8_CreateDevice(d3d8, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, window, + D3DCREATE_HARDWARE_VERTEXPROCESSING | D3DCREATE_FPU_PRESERVE, &present_parameters, &device); + ok(SUCCEEDED(hr), "CreateDevice failed, hr %#x.\n", hr); + + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + set_fpu_cw(0x37f); + + IDirect3DDevice8_Release(device); + +done: + if (window) DestroyWindow(window); + if (d3d8) IDirect3D8_Release(d3d8); +} + START_TEST(device) { HMODULE d3d8_handle = LoadLibraryA( "d3d8.dll" ); @@ -1819,6 +1902,9 @@ START_TEST(device) } IDirect3D8_Release(d3d8); +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + test_fpu_setup(); +#endif test_display_modes(); test_shader_versions(); test_swapchain();

1 0

Henri Verbeet : d3d9: Set the FPU control word on device creation.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: e6611e22fb037a879205f1330d1a3485f9f18705 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e6611e22fb037a879205f1330… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 26 09:41:38 2010 +0200 d3d9: Set the FPU control word on device creation. --- dlls/d3d9/device.c | 15 ++++++++ dlls/d3d9/tests/device.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 96 insertions(+), 0 deletions(-) diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 68516cc..b9f539e 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -2822,6 +2822,19 @@ static const IWineD3DDeviceParentVtbl d3d9_wined3d_device_parent_vtbl = device_parent_CreateSwapChain, }; +static void setup_fpu(void) +{ + WORD cw; + +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnstcw %0" : "=m" (cw)); + cw = (cw & ~0xf3f) | 0x3f; + __asm__ volatile ("fldcw %0" : : "m" (cw)); +#else + FIXME("FPU setup not implemented for this platform.\n"); +#endif +} + HRESULT device_init(IDirect3DDevice9Impl *device, IWineD3D *wined3d, UINT adapter, D3DDEVTYPE device_type, HWND focus_window, DWORD flags, D3DPRESENT_PARAMETERS *parameters) { @@ -2833,6 +2846,8 @@ HRESULT device_init(IDirect3DDevice9Impl *device, IWineD3D *wined3d, UINT adapte device->device_parent_vtbl = &d3d9_wined3d_device_parent_vtbl; device->ref = 1; + if (!(flags & D3DCREATE_FPU_PRESERVE)) setup_fpu(); + wined3d_mutex_lock(); hr = IWineD3D_CreateDevice(wined3d, adapter, device_type, focus_window, flags, (IUnknown *)device, (IWineD3DDeviceParent *)&device->device_parent_vtbl, &device->WineD3DDevice); diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index e21f8ad..2119995 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -2641,6 +2641,84 @@ done: UnregisterClassA("d3d9_test_wndproc_wc", GetModuleHandleA(NULL)); } +static inline void set_fpu_cw(WORD cw) +{ +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnclex"); + __asm__ volatile ("fldcw %0" : : "m" (cw)); +#endif +} + +static inline WORD get_fpu_cw(void) +{ + WORD cw = 0; +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + __asm__ volatile ("fnstcw %0" : "=m" (cw)); +#endif + return cw; +} + +static void test_fpu_setup(void) +{ + D3DPRESENT_PARAMETERS present_parameters; + IDirect3DDevice9 *device; + HWND window = NULL; + IDirect3D9 *d3d9; + HRESULT hr; + WORD cw; + + d3d9 = pDirect3DCreate9(D3D_SDK_VERSION); + ok(!!d3d9, "Failed to create a d3d9 object.\n"); + if (!d3d9) return; + + window = CreateWindowA("static", "d3d9_test", WS_CAPTION, 0, 0, 640, 480, 0, 0, 0, 0); + ok(!!window, "Failed to create a window.\n"); + if (!window) goto done; + + memset(&present_parameters, 0, sizeof(present_parameters)); + present_parameters.Windowed = TRUE; + present_parameters.hDeviceWindow = window; + present_parameters.SwapEffect = D3DSWAPEFFECT_DISCARD; + + set_fpu_cw(0xf60); + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, window, + D3DCREATE_HARDWARE_VERTEXPROCESSING, &present_parameters, &device); + if (FAILED(hr)) + { + skip("Failed to create a device, hr %#x.\n", hr); + set_fpu_cw(0x37f); + goto done; + } + + cw = get_fpu_cw(); + ok(cw == 0x7f, "cw is %#x, expected 0x7f.\n", cw); + + IDirect3DDevice9_Release(device); + + cw = get_fpu_cw(); + ok(cw == 0x7f, "cw is %#x, expected 0x7f.\n", cw); + set_fpu_cw(0xf60); + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, window, + D3DCREATE_HARDWARE_VERTEXPROCESSING | D3DCREATE_FPU_PRESERVE, &present_parameters, &device); + ok(SUCCEEDED(hr), "CreateDevice failed, hr %#x.\n", hr); + + cw = get_fpu_cw(); + ok(cw == 0xf60, "cw is %#x, expected 0xf60.\n", cw); + set_fpu_cw(0x37f); + + IDirect3DDevice9_Release(device); + +done: + if (window) DestroyWindow(window); + if (d3d9) IDirect3D9_Release(d3d9); +} + START_TEST(device) { HMODULE d3d9_handle = LoadLibraryA( "d3d9.dll" ); @@ -2662,6 +2740,9 @@ START_TEST(device) } IDirect3D9_Release(d3d9); +#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) + test_fpu_setup(); +#endif test_multi_device(); test_display_formats(); test_display_modes();

1 0

Nikolay Sivov : comctl32/listview: Perform ranges validation only when tracing enabled.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 01fdf21717532e730543d34841a767c61c647d89 URL: http://source.winehq.org/git/wine.git/?a=commit;h=01fdf21717532e730543d3484… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed May 26 03:01:56 2010 +0400 comctl32/listview: Perform ranges validation only when tracing enabled. --- dlls/comctl32/listview.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index e2bd9a7..4e13577 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -168,9 +168,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(listview); -/* make sure you set this to 0 for production use! */ -#define DEBUG_RANGES 1 - typedef struct tagCOLUMN_INFO { RECT rcHeader; /* tracks the header's rectangle */ @@ -2968,11 +2965,7 @@ static INT CALLBACK ranges_cmp(LPVOID range1, LPVOID range2, LPARAM flags) return cmp; } -#if DEBUG_RANGES -#define ranges_check(ranges, desc) ranges_assert(ranges, desc, __FUNCTION__, __LINE__) -#else -#define ranges_check(ranges, desc) do { } while(0) -#endif +#define ranges_check(ranges, desc) if (TRACE_ON(listview)) ranges_assert(ranges, desc, __FUNCTION__, __LINE__) static void ranges_assert(RANGES ranges, LPCSTR desc, const char *func, int line) { @@ -6961,7 +6954,7 @@ static BOOL LISTVIEW_GetSubItemRect(const LISTVIEW_INFO *infoPtr, INT nItem, LPR nColumn = lprc->top; - TRACE("(nItem=%d, nSubItem=%d)\n", nItem, lprc->top); + TRACE("(nItem=%d, nSubItem=%d, type=%d)\n", nItem, lprc->top, lprc->left); /* On WinNT, a subitem of '0' calls LISTVIEW_GetItemRect */ if (lprc->top == 0) return LISTVIEW_GetItemRect(infoPtr, nItem, lprc);

1 0

Alexandre Julliard : comctl32/imagelist: Add support for 25% and 50% blending when using an alpha channel.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 5572fc57ef6e60c69bc885f6fd2110c14a4f13cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=5572fc57ef6e60c69bc885f6f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 26 15:39:17 2010 +0200 comctl32/imagelist: Add support for 25% and 50% blending when using an alpha channel. --- dlls/comctl32/imagelist.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index 11ff27f..7ca1fc9 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -1157,7 +1157,8 @@ ImageList_DrawEx (HIMAGELIST himl, INT i, HDC hdc, INT x, INT y, static BOOL alpha_blend_image( HIMAGELIST himl, HDC dest_dc, int dest_x, int dest_y, - int src_x, int src_y, int cx, int cy, BLENDFUNCTION func ) + int src_x, int src_y, int cx, int cy, BLENDFUNCTION func, + UINT style, COLORREF blend_col ) { BOOL ret = FALSE; HDC hdc; @@ -1184,6 +1185,30 @@ static BOOL alpha_blend_image( HIMAGELIST himl, HDC dest_dc, int dest_x, int des SelectObject( hdc, bmp ); BitBlt( hdc, 0, 0, cx, cy, himl->hdcImage, src_x, src_y, SRCCOPY ); + if (blend_col != CLR_NONE) + { + BYTE r = GetRValue( blend_col ); + BYTE g = GetGValue( blend_col ); + BYTE b = GetBValue( blend_col ); + + if (style & ILD_BLEND25) + { + for (i = 0, ptr = bits; i < cx * cy; i++, ptr++) + *ptr = ((*ptr & 0xff000000) | + ((((*ptr & 0x00ff0000) * 3 + (r << 16)) / 4) & 0x00ff0000) | + ((((*ptr & 0x0000ff00) * 3 + (g << 8)) / 4) & 0x0000ff00) | + ((((*ptr & 0x000000ff) * 3 + (b << 0)) / 4) & 0x000000ff)); + } + else if (style & ILD_BLEND50) + { + for (i = 0, ptr = bits; i < cx * cy; i++, ptr++) + *ptr = ((*ptr & 0xff000000) | + ((((*ptr & 0x00ff0000) + (r << 16)) / 2) & 0x00ff0000) | + ((((*ptr & 0x0000ff00) + (g << 8)) / 2) & 0x0000ff00) | + ((((*ptr & 0x000000ff) + (b << 0)) / 2) & 0x000000ff)); + } + } + if (himl->uBitsPixel == 32) /* we already have an alpha channel in this case */ { /* pre-multiply by the alpha channel */ @@ -1302,9 +1327,16 @@ ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) has_alpha = (himl->has_alpha && himl->has_alpha[pimldp->i]); if (!bMask && (has_alpha || (fState & ILS_ALPHA))) { - COLORREF colour; + COLORREF colour, blend_col = CLR_NONE; BLENDFUNCTION func; + if (bBlend) + { + blend_col = pimldp->rgbFg; + if (blend_col == CLR_DEFAULT) blend_col = GetSysColor( COLOR_HIGHLIGHT ); + else if (blend_col == CLR_NONE) blend_col = GetTextColor( pimldp->hdcDst ); + } + func.BlendOp = AC_SRC_OVER; func.BlendFlags = 0; func.SourceConstantAlpha = (fState & ILS_ALPHA) ? pimldp->Frame : 255; @@ -1313,7 +1345,7 @@ ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) if (bIsTransparent) { bResult = alpha_blend_image( himl, pimldp->hdcDst, pimldp->x, pimldp->y, - pt.x, pt.y, cx, cy, func ); + pt.x, pt.y, cx, cy, func, fStyle, blend_col ); goto end; } colour = pimldp->rgbBk; @@ -1322,7 +1354,7 @@ ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) hOldBrush = SelectObject (hImageDC, CreateSolidBrush (colour)); PatBlt( hImageDC, 0, 0, cx, cy, PATCOPY ); - alpha_blend_image( himl, hImageDC, 0, 0, pt.x, pt.y, cx, cy, func ); + alpha_blend_image( himl, hImageDC, 0, 0, pt.x, pt.y, cx, cy, func, fStyle, blend_col ); DeleteObject (SelectObject (hImageDC, hOldBrush)); bResult = BitBlt( pimldp->hdcDst, pimldp->x, pimldp->y, cx, cy, hImageDC, 0, 0, SRCCOPY ); goto end;

1 0

Alexandre Julliard : user32: Check the active window instead of the foreground to show/ hide owned popups.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 7ea98f680d051aeda02705d1520e4d636cc181b5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ea98f680d051aeda02705d15… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 26 10:39:01 2010 +0200 user32: Check the active window instead of the foreground to show/hide owned popups. --- dlls/user32/nonclient.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/user32/nonclient.c b/dlls/user32/nonclient.c index c8d19d9..a685370 100644 --- a/dlls/user32/nonclient.c +++ b/dlls/user32/nonclient.c @@ -1548,19 +1548,19 @@ LRESULT NC_HandleSysCommand( HWND hwnd, WPARAM wParam, LPARAM lParam ) break; case SC_MINIMIZE: - if (hwnd == GetForegroundWindow()) + if (hwnd == GetActiveWindow()) ShowOwnedPopups(hwnd,FALSE); ShowWindow( hwnd, SW_MINIMIZE ); break; case SC_MAXIMIZE: - if (IsIconic(hwnd) && hwnd == GetForegroundWindow()) + if (IsIconic(hwnd) && hwnd == GetActiveWindow()) ShowOwnedPopups(hwnd,TRUE); ShowWindow( hwnd, SW_MAXIMIZE ); break; case SC_RESTORE: - if (IsIconic(hwnd) && hwnd == GetForegroundWindow()) + if (IsIconic(hwnd) && hwnd == GetActiveWindow()) ShowOwnedPopups(hwnd,TRUE); ShowWindow( hwnd, SW_RESTORE ); break;

1 0

Gerald Pfeifer : wordpad: Remove variable bottom which is not really used from print.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: f26b4f68e74b20995521f5c805062b1d70026614 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f26b4f68e74b20995521f5c80… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Mon May 24 22:09:16 2010 +0200 wordpad: Remove variable bottom which is not really used from print. --- programs/wordpad/print.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/programs/wordpad/print.c b/programs/wordpad/print.c index 226052e..1d4e6e3 100644 --- a/programs/wordpad/print.c +++ b/programs/wordpad/print.c @@ -487,7 +487,6 @@ static void print(LPPRINTDLGW pd, LPWSTR wszFileName) StartDocW(fr.hdc, &di); do { - int bottom = fr.rc.bottom; if(StartPage(fr.hdc) <= 0) break; @@ -495,7 +494,6 @@ static void print(LPPRINTDLGW pd, LPWSTR wszFileName) if(EndPage(fr.hdc) <= 0) break; - bottom = fr.rc.bottom; printedPages++; if((pd->Flags & PD_PAGENUMS) && (printedPages > (pd->nToPage - pd->nFromPage)))

1 0

Gerald Pfeifer : dbghelp: Remove variable basic_block which is not really used from dwarf2_parse_line_numbers .
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 72216a604d46037906fe087e2d67face21acdc49 URL: http://source.winehq.org/git/wine.git/?a=commit;h=72216a604d46037906fe087e2… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Mon May 24 22:15:41 2010 +0200 dbghelp: Remove variable basic_block which is not really used from dwarf2_parse_line_numbers. --- dlls/dbghelp/dwarf.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 4be0f6a..35c01a6 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -2003,7 +2003,7 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, unsigned file = 1; unsigned line = 1; unsigned is_stmt = default_stmt; - BOOL basic_block = FALSE, end_sequence = FALSE; + BOOL end_sequence = FALSE; unsigned opcode, extopcode, i; while (!end_sequence) @@ -2017,7 +2017,6 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, address += (delta / line_range) * insn_size; line += line_base + (delta % line_range); - basic_block = TRUE; dwarf2_set_line_number(ctx->module, address, &files, file, line); } else @@ -2025,7 +2024,6 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, switch (opcode) { case DW_LNS_copy: - basic_block = FALSE; dwarf2_set_line_number(ctx->module, address, &files, file, line); break; case DW_LNS_advance_pc: @@ -2044,7 +2042,6 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, is_stmt = !is_stmt; break; case DW_LNS_set_basic_block: - basic_block = 1; break; case DW_LNS_const_add_pc: address += ((255 - opcode_base) / line_range) * insn_size;

1 0

Marcus Meissner : d3dx9_36: Fixed off by 1 in the usage_idx check (Coverity ).
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 41809d5833950d5664515cc182a07bb89e8cf99b URL: http://source.winehq.org/git/wine.git/?a=commit;h=41809d5833950d5664515cc18… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Tue May 25 23:40:59 2010 +0200 d3dx9_36: Fixed off by 1 in the usage_idx check (Coverity). --- dlls/d3dx9_36/bytecodewriter.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/bytecodewriter.c b/dlls/d3dx9_36/bytecodewriter.c index 384fed3..055b8ef 100644 --- a/dlls/d3dx9_36/bytecodewriter.c +++ b/dlls/d3dx9_36/bytecodewriter.c @@ -435,7 +435,7 @@ static HRESULT vs_find_builtin_varyings(struct bc_writer *This, const struct bwr break; case BWRITERDECLUSAGE_TEXCOORD: - if(usage_idx > 8) { + if(usage_idx >= 8) { WARN("dcl_color%u not supported in sm 1/2 shaders\n", usage_idx); return E_INVALIDARG; }

1 0

Michael Stefaniuc : ole32: Avoid potential NULL pointer dereferences in a TRACE.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: 162e420f0ef8c78d877113b72b74c580e2f750b5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=162e420f0ef8c78d877113b72… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed May 26 01:27:58 2010 +0200 ole32: Avoid potential NULL pointer dereferences in a TRACE. --- dlls/ole32/clipboard.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c index 2afc77e..3064bb0 100644 --- a/dlls/ole32/clipboard.c +++ b/dlls/ole32/clipboard.c @@ -1266,10 +1266,10 @@ static HRESULT WINAPI snapshot_GetDataHere(IDataObject *iface, FORMATETC *fmt, ole_priv_data_entry *entry; TYMED supported; - TRACE("(%p, %p {%s}, %p (tymed %x)\n", iface, fmt, dump_fmtetc(fmt), med, med->tymed); - if ( !fmt || !med ) return E_INVALIDARG; + TRACE("(%p, %p {%s}, %p (tymed %x)\n", iface, fmt, dump_fmtetc(fmt), med, med->tymed); + if ( !OpenClipboard(NULL)) return CLIPBRD_E_CANT_OPEN; if(!This->data)

1 0

Gerald Pfeifer : rsaenh: Simplify store_key_container_permissions.
by Alexandre Julliard May 26, 2010

May 26, 2010

Module: wine Branch: master Commit: c8748d73d16e511e70a0065be50e82f425d66d94 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c8748d73d16e511e70a0065be… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Mon May 24 21:43:15 2010 +0200 rsaenh: Simplify store_key_container_permissions. --- dlls/rsaenh/rsaenh.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/dlls/rsaenh/rsaenh.c b/dlls/rsaenh/rsaenh.c index 89bb786..d7d63b1 100644 --- a/dlls/rsaenh/rsaenh.c +++ b/dlls/rsaenh/rsaenh.c @@ -1167,16 +1167,6 @@ static void store_key_container_keys(KEYCONTAINER *pKeyContainer) static void store_key_container_permissions(KEYCONTAINER *pKeyContainer) { HKEY hKey; - DWORD dwFlags; - - /* On WinXP, persistent keys are stored in a file located at: - * $AppData$\\Microsoft\\Crypto\\RSA\\$SID$\\some_hex_string - */ - - if (pKeyContainer->dwFlags & CRYPT_MACHINE_KEYSET) - dwFlags = CRYPTPROTECT_LOCAL_MACHINE; - else - dwFlags = 0; if (create_container_key(pKeyContainer, KEY_WRITE, &hKey)) {

1 0