May 2010 - Wine-Commits - list.winehq.org

Matteo Bruni : d3dx9: Shader assembler vs_2_x support.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: 5050f7c8d2cbd965c15501f73d199ee989ef452e URL: http://source.winehq.org/git/wine.git/?a=commit;h=5050f7c8d2cbd965c15501f73… Author: Matteo Bruni <matteo.mystral(a)gmail.com> Date: Sun May 16 20:57:52 2010 +0200 d3dx9: Shader assembler vs_2_x support. --- dlls/d3dx9_36/asmparser.c | 259 +++++++++++++++++++++ dlls/d3dx9_36/asmshader.y | 6 +- dlls/d3dx9_36/bytecodewriter.c | 473 +++++++++++++++++++++++++++++++++++++- dlls/d3dx9_36/d3dx9_36_private.h | 11 + dlls/d3dx9_36/tests/asm.c | 12 +- 5 files changed, 753 insertions(+), 8 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=5050f7c8d2cbd965c1550…

1 0

Matteo Bruni : d3dx9: Use separate opcodes for TEXLDP and TEXLDB.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: a9118ba1715c3a4833d3e45f19a69d418e8417bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9118ba1715c3a4833d3e45f1… Author: Matteo Bruni <matteo.mystral(a)gmail.com> Date: Fri May 21 14:56:43 2010 +0200 d3dx9: Use separate opcodes for TEXLDP and TEXLDB. There is no reason we have to strictly follow D3D bytecode format in our intermediate representation. --- dlls/d3dx9_36/asmshader.y | 4 ++-- dlls/d3dx9_36/asmutils.c | 8 ++++---- dlls/d3dx9_36/bytecodewriter.c | 4 ++-- dlls/d3dx9_36/d3dx9_36_private.h | 5 ++--- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/dlls/d3dx9_36/asmshader.y b/dlls/d3dx9_36/asmshader.y index 0949ee3..8be8328 100644 --- a/dlls/d3dx9_36/asmshader.y +++ b/dlls/d3dx9_36/asmshader.y @@ -724,12 +724,12 @@ instruction: INSTR_ADD omods dreg ',' sregs | INSTR_TEXLDP omods dreg ',' sregs { TRACE("TEXLDP\n"); - asm_ctx.funcs->instr(&asm_ctx, BWRITERSIO_TEX | ( BWRITERSI_TEXLD_PROJECT << BWRITER_OPCODESPECIFICCONTROL_SHIFT ), $2.mod, $2.shift, 0, &$3, &$5, 2); + asm_ctx.funcs->instr(&asm_ctx, BWRITERSIO_TEXLDP, $2.mod, $2.shift, 0, &$3, &$5, 2); } | INSTR_TEXLDB omods dreg ',' sregs { TRACE("TEXLDB\n"); - asm_ctx.funcs->instr(&asm_ctx, BWRITERSIO_TEX | ( BWRITERSI_TEXLD_BIAS << BWRITER_OPCODESPECIFICCONTROL_SHIFT ), $2.mod, $2.shift, 0, &$3, &$5, 2); + asm_ctx.funcs->instr(&asm_ctx, BWRITERSIO_TEXLDB, $2.mod, $2.shift, 0, &$3, &$5, 2); } | INSTR_DSX omods dreg ',' sregs { diff --git a/dlls/d3dx9_36/asmutils.c b/dlls/d3dx9_36/asmutils.c index e000a5f..bd6bcea 100644 --- a/dlls/d3dx9_36/asmutils.c +++ b/dlls/d3dx9_36/asmutils.c @@ -209,8 +209,8 @@ DWORD d3d9_opcode(DWORD bwriter_opcode) { case BWRITERSIO_COMMENT: return D3DSIO_COMMENT; case BWRITERSIO_END: return D3DSIO_END; - case BWRITERSIO_TEX | ( BWRITERSI_TEXLD_PROJECT << BWRITER_OPCODESPECIFICCONTROL_SHIFT ): return D3DSIO_TEX | D3DSI_TEXLD_PROJECT; - case BWRITERSIO_TEX | ( BWRITERSI_TEXLD_BIAS << BWRITER_OPCODESPECIFICCONTROL_SHIFT ): return D3DSIO_TEX | D3DSI_TEXLD_BIAS; + case BWRITERSIO_TEXLDP: return D3DSIO_TEX | D3DSI_TEXLD_PROJECT; + case BWRITERSIO_TEXLDB: return D3DSIO_TEX | D3DSI_TEXLD_BIAS; default: FIXME("Unhandled BWRITERSIO token %u\n", bwriter_opcode); @@ -484,8 +484,8 @@ const char *debug_print_opcode(DWORD opcode) { case BWRITERSIO_TEXLDL: return "texldl"; case BWRITERSIO_BREAKP: return "breakp"; - case BWRITERSIO_TEX | ( BWRITERSI_TEXLD_PROJECT << BWRITER_OPCODESPECIFICCONTROL_SHIFT ): return "texldp"; - case BWRITERSIO_TEX | ( BWRITERSI_TEXLD_BIAS << BWRITER_OPCODESPECIFICCONTROL_SHIFT ): return "texldb"; + case BWRITERSIO_TEXLDP: return "texldp"; + case BWRITERSIO_TEXLDB: return "texldb"; default: return "unknown"; } diff --git a/dlls/d3dx9_36/bytecodewriter.c b/dlls/d3dx9_36/bytecodewriter.c index 464ec52..a579ae8 100644 --- a/dlls/d3dx9_36/bytecodewriter.c +++ b/dlls/d3dx9_36/bytecodewriter.c @@ -693,8 +693,8 @@ static const struct instr_handler_table ps_3_handlers[] = { {BWRITERSIO_TEXLDL, instr_handler}, {BWRITERSIO_TEX, instr_handler}, - {BWRITERSIO_TEX | ( BWRITERSI_TEXLD_PROJECT << BWRITER_OPCODESPECIFICCONTROL_SHIFT ), instr_handler}, - {BWRITERSIO_TEX | ( BWRITERSI_TEXLD_BIAS << BWRITER_OPCODESPECIFICCONTROL_SHIFT ), instr_handler}, + {BWRITERSIO_TEXLDP, instr_handler}, + {BWRITERSIO_TEXLDB, instr_handler}, {BWRITERSIO_TEXKILL, instr_handler}, {BWRITERSIO_DSX, instr_handler}, {BWRITERSIO_DSY, instr_handler}, diff --git a/dlls/d3dx9_36/d3dx9_36_private.h b/dlls/d3dx9_36/d3dx9_36_private.h index 923a0df..248503d 100644 --- a/dlls/d3dx9_36/d3dx9_36_private.h +++ b/dlls/d3dx9_36/d3dx9_36_private.h @@ -462,6 +462,8 @@ typedef enum _BWRITERSHADER_INSTRUCTION_OPCODE_TYPE { BWRITERSIO_SETP, BWRITERSIO_TEXLDL, BWRITERSIO_BREAKP, + BWRITERSIO_TEXLDP, + BWRITERSIO_TEXLDB, BWRITERSIO_COMMENT, BWRITERSIO_END, @@ -589,9 +591,6 @@ typedef enum _BWRITERDECLUSAGE { BWRITERDECLUSAGE_SAMPLE } BWRITERDECLUSAGE; -#define BWRITER_OPCODESPECIFICCONTROL_SHIFT 16 -#define BWRITER_OPCODESPECIFICCONTROL_MASK (0xff << BWRITER_OPCODESPECIFICCONTROL_SHIFT) - struct bwriter_shader *SlAssembleShader(const char *text, char **messages); DWORD SlWriteBytecode(const struct bwriter_shader *shader, int dxversion, DWORD **result); void SlDeleteShader(struct bwriter_shader *shader);

1 0

Austin English : include: Rename structs to fix compile with recent gcc.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: f403816081bcd4a5b77bc9e43dee6147f5fcd38c URL: http://source.winehq.org/git/wine.git/?a=commit;h=f403816081bcd4a5b77bc9e43… Author: Austin English <austinenglish(a)gmail.com> Date: Thu May 20 17:49:51 2010 -0500 include: Rename structs to fix compile with recent gcc. --- include/winnt.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/winnt.h b/include/winnt.h index d8fbbfd..eb3ab2c 100644 --- a/include/winnt.h +++ b/include/winnt.h @@ -1047,7 +1047,7 @@ typedef struct _KNONVOLATILE_CONTEXT_POINTERS PM128A Xmm13; PM128A Xmm14; PM128A Xmm15; - } DUMMYSTRUCTNAME; + } DUMMYSTRUCTNAME1; } DUMMYUNIONNAME1; union @@ -1071,7 +1071,7 @@ typedef struct _KNONVOLATILE_CONTEXT_POINTERS PULONG64 R13; PULONG64 R14; PULONG64 R15; - } DUMMYSTRUCTNAME; + } DUMMYSTRUCTNAME2; } DUMMYUNIONNAME2; } KNONVOLATILE_CONTEXT_POINTERS, *PKNONVOLATILE_CONTEXT_POINTERS;

1 0

Stefan Dösinger : wined3d: Catch RCP 0.0 in ARB.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: b5da1185311a3d772e75b6a8056d7d45bf20e42b URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5da1185311a3d772e75b6a80… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri May 21 14:05:46 2010 +0200 wined3d: Catch RCP 0.0 in ARB. --- dlls/wined3d/arb_program_shader.c | 51 ++++++++++++++++++++++++++++++++++--- dlls/wined3d/shader.c | 1 + dlls/wined3d/wined3d_private.h | 3 +- 3 files changed, 50 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 2920b43..3045f4a 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -104,8 +104,9 @@ static BOOL need_helper_const(IWineD3DBaseShaderImpl *shader, const struct wined if (!gl_info->supported[NV_VERTEX_PROGRAM]) return TRUE; /* Need to init colors. */ if (gl_info->quirks & WINED3D_QUIRK_ARB_VS_OFFSET_LIMIT) return TRUE; /* Load the immval offset. */ if (gl_info->quirks & WINED3D_QUIRK_SET_TEXCOORD_W) return TRUE; /* Have to init texcoords. */ - if (shader->baseShader.reg_maps.usesnrm) return TRUE; /* 0.0 */ if (!use_nv_clip(gl_info)) return TRUE; /* Init the clip texcoord */ + if (shader->baseShader.reg_maps.usesnrm) return TRUE; /* 0.0 */ + if (shader->baseShader.reg_maps.usesrcp) return TRUE; /* EPS */ return FALSE; } @@ -126,6 +127,7 @@ enum arb_helper_value ARB_ONE, ARB_TWO, ARB_0001, + ARB_EPS, ARB_VS_REL_OFFSET }; @@ -146,6 +148,7 @@ static const char *arb_get_helper_value(enum wined3d_shader_type shader, enum ar case ARB_ONE: return "ps_helper_const.y"; case ARB_TWO: return "coefmul.x"; case ARB_0001: return "helper_const.xxxy"; + case ARB_EPS: return "ps_helper_const.z"; default: break; } } @@ -156,6 +159,7 @@ static const char *arb_get_helper_value(enum wined3d_shader_type shader, enum ar case ARB_ZERO: return "helper_const.x"; case ARB_ONE: return "helper_const.y"; case ARB_TWO: return "helper_const.z"; + case ARB_EPS: return "helper_const.w"; case ARB_0001: return "helper_const.xxxy"; case ARB_VS_REL_OFFSET: return "rel_addr_const.y"; } @@ -168,6 +172,7 @@ static const char *arb_get_helper_value(enum wined3d_shader_type shader, enum ar case ARB_ONE: return "1.0"; case ARB_TWO: return "2.0"; case ARB_0001: return "{0.0, 0.0, 0.0, 1.0}"; + case ARB_EPS: return "1e-8"; default: return "bad"; } } @@ -2403,6 +2408,44 @@ static void shader_hw_mnxn(const struct wined3d_shader_instruction *ins) } } +static void shader_hw_rcp(const struct wined3d_shader_instruction *ins) +{ + struct wined3d_shader_buffer *buffer = ins->ctx->buffer; + struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; + const char *flt_eps = arb_get_helper_value(ins->ctx->reg_maps->shader_version.type, ARB_EPS); + + char dst[50]; + char src[50]; + + shader_arb_get_dst_param(ins, &ins->dst[0], dst); /* Destination */ + shader_arb_get_src_param(ins, &ins->src[0], 0, src); + if (ins->src[0].swizzle == WINED3DSP_NOSWIZZLE) + { + /* Dx sdk says .x is used if no swizzle is given, but our test shows that + * .w is used + */ + strcat(src, ".w"); + } + + /* TODO: If the destination is readable, and not the same as the source, the destination + * can be used instead of TA + */ + if (priv->target_version >= NV2) + { + shader_addline(buffer, "MOVC TA.x, %s;\n", src); + shader_addline(buffer, "MOV TA.x (EQ.x), %s;\n", flt_eps); + shader_addline(buffer, "RCP%s %s, TA.x;\n", shader_arb_get_modifier(ins), dst); + } + else + { + const char *zero = arb_get_helper_value(ins->ctx->reg_maps->shader_version.type, ARB_ZERO); + shader_addline(buffer, "ABS TA.x, %s;\n", src); + shader_addline(buffer, "SGE TA.y, -TA.x, %s;\n", zero); + shader_addline(buffer, "MAD TA.x, TA.y, %s, %s;\n", flt_eps, src); + shader_addline(buffer, "RCP%s %s, TA.x;\n", shader_arb_get_modifier(ins), dst); + } +} + static void shader_hw_scalar_op(const struct wined3d_shader_instruction *ins) { struct wined3d_shader_buffer *buffer = ins->ctx->buffer; @@ -3578,7 +3621,7 @@ static GLuint shader_arb_generate_pshader(IWineD3DPixelShaderImpl *This, struct if(dcl_td) shader_addline(buffer, "TEMP TD;\n"); /* Used for sRGB writing */ shader_addline(buffer, "PARAM coefdiv = { 0.5, 0.25, 0.125, 0.0625 };\n"); shader_addline(buffer, "PARAM coefmul = { 2, 4, 8, 16 };\n"); - shader_addline(buffer, "PARAM ps_helper_const = { 0.0, 1.0, 0.0, 0.0 };\n"); + shader_addline(buffer, "PARAM ps_helper_const = { 0.0, 1.0, %1.10f, 0.0 };\n", eps); if (reg_maps->shader_version.major < 2) { @@ -4074,7 +4117,7 @@ static GLuint shader_arb_generate_vshader(IWineD3DVertexShaderImpl *This, struct shader_addline(buffer, "TEMP TMP_OUT;\n"); if(need_helper_const((IWineD3DBaseShaderImpl *) This, gl_info)) { - shader_addline(buffer, "PARAM helper_const = { 0.0, 1.0, 2.0, 0.0 };\n"); + shader_addline(buffer, "PARAM helper_const = { 0.0, 1.0, 2.0, %1.10f};\n", eps); } if(need_rel_addr_const((IWineD3DBaseShaderImpl *) This, gl_info)) { shader_addline(buffer, "PARAM rel_addr_const = { 0.5, %d.0, 0.0, 0.0 };\n", This->rel_offset); @@ -4949,7 +4992,7 @@ static const SHADER_HANDLER shader_arb_instruction_handler_table[WINED3DSIH_TABL /* WINED3DSIH_NRM */ shader_hw_nrm, /* WINED3DSIH_PHASE */ NULL, /* WINED3DSIH_POW */ shader_hw_log_pow, - /* WINED3DSIH_RCP */ shader_hw_scalar_op, + /* WINED3DSIH_RCP */ shader_hw_rcp, /* WINED3DSIH_REP */ shader_hw_rep, /* WINED3DSIH_RET */ shader_hw_ret, /* WINED3DSIH_RSQ */ shader_hw_scalar_op, diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index a8340d3..f26122a 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -721,6 +721,7 @@ static HRESULT shader_get_registers_used(IWineD3DBaseShader *iface, const struct else if (ins.handler_idx == WINED3DSIH_MOVA) reg_maps->usesmova = 1; else if (ins.handler_idx == WINED3DSIH_IFC) reg_maps->usesifc = 1; else if (ins.handler_idx == WINED3DSIH_CALL) reg_maps->usescall = 1; + else if (ins.handler_idx == WINED3DSIH_RCP) reg_maps->usesrcp = 1; limit = ins.src_count + (ins.predicate ? 1 : 0); for (i = 0; i < limit; ++i) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 001312d..045d068 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -541,7 +541,8 @@ typedef struct shader_reg_maps WORD usestexldl : 1; WORD usesifc : 1; WORD usescall : 1; - WORD padding : 4; + WORD usesrcp : 1; + WORD padding : 3; /* Whether or not loops are used in this shader, and nesting depth */ unsigned loop_depth;

1 0

Stefan Dösinger : wined3d: Add a function for reading (ps_)helper_const.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: a1710a32f3dcba2fb3ec6d45d45cb76d16e6e6fc URL: http://source.winehq.org/git/wine.git/?a=commit;h=a1710a32f3dcba2fb3ec6d45d… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat May 15 21:04:06 2010 +0200 wined3d: Add a function for reading (ps_)helper_const. --- dlls/wined3d/arb_program_shader.c | 108 ++++++++++++++++++++++++++++++------- 1 files changed, 88 insertions(+), 20 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a1710a32f3dcba2fb3ec6…

1 0

Damjan Jovanovic : winemenubuilder: Generate .png even for paletted icons.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: a83a9c1da143ceec7a4189501431b35f178ec78a URL: http://source.winehq.org/git/wine.git/?a=commit;h=a83a9c1da143ceec7a4189501… Author: Damjan Jovanovic <damjan.jov(a)gmail.com> Date: Fri May 21 07:44:22 2010 +0200 winemenubuilder: Generate .png even for paletted icons. --- programs/winemenubuilder/winemenubuilder.c | 146 +++++++++++++++++++++++++++- 1 files changed, 145 insertions(+), 1 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index 9f10fdb..eba21ef 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -242,7 +242,7 @@ static void user_warning_fn(png_structp png_ptr, png_const_charp warning_message WINE_WARN("PNG warning: %s\n", wine_dbgstr_an(warning_message, -1)); } -static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, LPCWSTR commentW) +static BOOL SaveTrueColorIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, LPCWSTR commentW) { static const char comment_key[] = "Created from"; FILE *fp; @@ -373,6 +373,150 @@ static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, HeapFree(GetProcessHeap(), 0, comment.text); return FALSE; } + +static BOOL SavePalettedIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, LPCWSTR commentW) +{ + static const char comment_key[] = "Created from"; + FILE *pngFile = NULL; + int i, j; + int nHeight; + int nXORWidthBytes; + int nANDWidthBytes; + BOOL b8BitColors; + int nColors; + const BYTE *pXOR; + const BYTE *pAND; + png_structp png_ptr; + png_infop info_ptr; + png_text comment; + jmp_buf jmpbuf; + unsigned char *row = NULL; + BOOL ret = FALSE; + + comment.text = NULL; + + if (!((pIcon->bmiHeader.biBitCount == 4) || (pIcon->bmiHeader.biBitCount == 8))) + { + WINE_FIXME("Unsupported color depth %d-bit\n", pIcon->bmiHeader.biBitCount); + goto done; + } + + if (!(pngFile = fopen(png_filename, "w"))) + { + WINE_TRACE("Unable to open '%s' for writing: %s\n", png_filename, strerror(errno)); + goto done; + } + + nHeight = pIcon->bmiHeader.biHeight / 2; + nXORWidthBytes = 4 * ((pIcon->bmiHeader.biWidth * pIcon->bmiHeader.biBitCount / 32) + + ((pIcon->bmiHeader.biWidth * pIcon->bmiHeader.biBitCount % 32) > 0)); + nANDWidthBytes = 4 * ((pIcon->bmiHeader.biWidth / 32) + + ((pIcon->bmiHeader.biWidth % 32) > 0)); + b8BitColors = pIcon->bmiHeader.biBitCount == 8; + nColors = pIcon->bmiHeader.biClrUsed ? pIcon->bmiHeader.biClrUsed + : 1 << pIcon->bmiHeader.biBitCount; + pXOR = (const BYTE*) pIcon + sizeof (BITMAPINFOHEADER) + (nColors * sizeof (RGBQUAD)); + pAND = pXOR + nHeight * nXORWidthBytes; + + row = HeapAlloc(GetProcessHeap(), 0, 4 * pIcon->bmiHeader.biWidth); + if (row == NULL) + { + WINE_ERR("out of memory\n"); + goto done; + } + + if (!libpng_handle && !load_libpng()) + { + WINE_WARN("Unable to load libpng\n"); + goto done; + } + + if (!(png_ptr = ppng_create_write_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL)) || + !(info_ptr = ppng_create_info_struct(png_ptr))) + goto done; + + if (setjmp(jmpbuf)) + { + /* All future errors jump here */ + goto done; + } + ppng_set_error_fn(png_ptr, &jmpbuf, user_error_fn, user_warning_fn); + + ppng_init_io(png_ptr, pngFile); + ppng_set_IHDR(png_ptr, info_ptr, pIcon->bmiHeader.biWidth, nHeight, 8, + PNG_COLOR_TYPE_RGB_ALPHA, + PNG_INTERLACE_NONE, + PNG_COMPRESSION_TYPE_DEFAULT, + PNG_FILTER_TYPE_DEFAULT); + + /* Set comment */ + comment.compression = PNG_TEXT_COMPRESSION_NONE; + comment.key = (png_charp)comment_key; + i = WideCharToMultiByte(CP_UNIXCP, 0, commentW, -1, NULL, 0, NULL, NULL); + comment.text = HeapAlloc(GetProcessHeap(), 0, i); + if (comment.text == NULL) + { + WINE_ERR("out of memory\n"); + goto done; + } + WideCharToMultiByte(CP_UNIXCP, 0, commentW, -1, comment.text, i, NULL, NULL); + comment.text_length = i - 1; + ppng_set_text(png_ptr, info_ptr, &comment, 1); + + ppng_write_info(png_ptr, info_ptr); + for (i = 0; i < nHeight; i++) + { + unsigned char *p = row; + for (j = 0; j < pIcon->bmiHeader.biWidth; j++) + { + if MASK(j,i) + { + *p++ = 0; + *p++ = 0; + *p++ = 0; + *p++ = 0; + } + else + { +#define COLOR(x,y) (b8BitColors ? pXOR[(x) + (nHeight - (y) - 1) * nXORWidthBytes] : (x) % 2 ? pXOR[(x) / 2 + (nHeight - (y) - 1) * nXORWidthBytes] & 0xF : (pXOR[(x) / 2 + (nHeight - (y) - 1) * nXORWidthBytes] & 0xF0) >> 4) + *p++ = pIcon->bmiColors[COLOR(j,i)].rgbRed; + *p++ = pIcon->bmiColors[COLOR(j,i)].rgbGreen; + *p++ = pIcon->bmiColors[COLOR(j,i)].rgbBlue; + *p++ = 0xFF; +#undef COLOR + } + } + ppng_write_row(png_ptr, (png_bytep)row); + } + ppng_write_end(png_ptr, info_ptr); + ret = TRUE; + +done: + ppng_destroy_write_struct(&png_ptr, &info_ptr); + if (pngFile != NULL) + fclose(pngFile); + HeapFree(GetProcessHeap(), 0, comment.text); + HeapFree(GetProcessHeap(), 0, row); + return ret; +} + +static BOOL SaveIconResAsPNG(const BITMAPINFO *pIcon, const char *png_filename, LPCWSTR commentW) +{ + switch (pIcon->bmiHeader.biBitCount) + { + case 4: + return SavePalettedIconResAsPNG(pIcon, png_filename, commentW); + case 8: + return SavePalettedIconResAsPNG(pIcon, png_filename, commentW); + case 24: + return SaveTrueColorIconResAsPNG(pIcon, png_filename, commentW); + case 32: + return SaveTrueColorIconResAsPNG(pIcon, png_filename, commentW); + default: + WINE_FIXME("unsupported bpp %d, please report", pIcon->bmiHeader.biBitCount); + return FALSE; + } +} #endif /* SONAME_LIBPNG */ static BOOL SaveIconResAsXPM(const BITMAPINFO *pIcon, const char *szXPMFileName, LPCWSTR commentW)

1 0

Stefan Dösinger : wined3d: Store a positive 1. 0 in the ARB's vertex shader helper constant.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: 6946de81253d860097dfc29576a86a226f87c730 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6946de81253d860097dfc2957… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat May 15 20:56:29 2010 +0200 wined3d: Store a positive 1.0 in the ARB's vertex shader helper constant. --- dlls/wined3d/arb_program_shader.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 57c5964..a6cafe7 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -3981,7 +3981,7 @@ static GLuint shader_arb_generate_vshader(IWineD3DVertexShaderImpl *This, struct shader_addline(buffer, "TEMP TMP_OUT;\n"); if(need_helper_const(gl_info)) { - shader_addline(buffer, "PARAM helper_const = { 2.0, -1.0, %d.0, 0.0 };\n", This->rel_offset); + shader_addline(buffer, "PARAM helper_const = { 2.0, 1.0, %d.0, 0.0 };\n", This->rel_offset); } if(need_mova_const((IWineD3DBaseShader *) This, gl_info)) { shader_addline(buffer, "PARAM mova_const = { 0.5, 0.0, 2.0, 1.0 };\n"); @@ -4032,7 +4032,7 @@ static GLuint shader_arb_generate_vshader(IWineD3DVertexShaderImpl *This, struct */ if (!gl_info->supported[NV_VERTEX_PROGRAM]) { - shader_addline(buffer, "MOV result.color.secondary, -helper_const.wwwy;\n"); + shader_addline(buffer, "MOV result.color.secondary, helper_const.wwwy;\n"); if (gl_info->quirks & WINED3D_QUIRK_SET_TEXCOORD_W && !device->frag_pipe->ffp_proj_control) { @@ -4040,7 +4040,7 @@ static GLuint shader_arb_generate_vshader(IWineD3DVertexShaderImpl *This, struct for(i = 0; i < min(8, MAX_REG_TEXCRD); i++) { if(This->baseShader.reg_maps.texcoord_mask[i] != 0 && This->baseShader.reg_maps.texcoord_mask[i] != WINED3DSP_WRITEMASK_ALL) { - shader_addline(buffer, "MOV result.texcoord[%u].w, -helper_const.y;\n", i); + shader_addline(buffer, "MOV result.texcoord[%u].w, helper_const.y;\n", i); } } }

1 0

Stefan Dösinger : wined3d: Split up the "one" pixel shader helper constant.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: 09d74b748e54955065cf5ea8adf63a0f6f1dd181 URL: http://source.winehq.org/git/wine.git/?a=commit;h=09d74b748e54955065cf5ea8a… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat May 15 20:51:19 2010 +0200 wined3d: Split up the "one" pixel shader helper constant. --- dlls/wined3d/arb_program_shader.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index b6285b2..57c5964 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -1366,7 +1366,7 @@ static void shader_hw_sample(const struct wined3d_shader_instruction *ins, DWORD if (pshader) { gen_color_correction(buffer, dst_str, ins->dst[0].write_mask, - "one", "coefmul.x", priv->cur_ps_args->super.color_fixup[sampler_idx]); + "ps_helper_const.x", "coefmul.x", priv->cur_ps_args->super.color_fixup[sampler_idx]); } } @@ -1405,13 +1405,13 @@ static void shader_arb_get_src_param(const struct wined3d_shader_instruction *in shader_addline(buffer, "ADD T%c, -%s, coefdiv.x;\n", 'A' + tmpreg, regstr); break; case WINED3DSPSM_SIGN: - shader_addline(buffer, "MAD T%c, %s, coefmul.x, -one.x;\n", 'A' + tmpreg, regstr); + shader_addline(buffer, "MAD T%c, %s, coefmul.x, -ps_helper_const.x;\n", 'A' + tmpreg, regstr); break; case WINED3DSPSM_SIGNNEG: - shader_addline(buffer, "MAD T%c, %s, -coefmul.x, one.x;\n", 'A' + tmpreg, regstr); + shader_addline(buffer, "MAD T%c, %s, -coefmul.x, ps_helper_const.x;\n", 'A' + tmpreg, regstr); break; case WINED3DSPSM_COMP: - shader_addline(buffer, "SUB T%c, one.x, %s;\n", 'A' + tmpreg, regstr); + shader_addline(buffer, "SUB T%c, ps_helper_const.x, %s;\n", 'A' + tmpreg, regstr); break; case WINED3DSPSM_X2: shader_addline(buffer, "ADD T%c, %s, %s;\n", 'A' + tmpreg, regstr, regstr); @@ -2192,7 +2192,7 @@ static void pshader_hw_texdepth(const struct wined3d_shader_instruction *ins) /* According to the msdn, the source register(must be r5) is unusable after * the texdepth instruction, so we're free to modify it */ - shader_addline(buffer, "MIN %s.y, %s.y, one.y;\n", dst_name, dst_name); + shader_addline(buffer, "MIN %s.y, %s.y, ps_helper_const.x;\n", dst_name, dst_name); /* How to deal with the special case dst_name.g == 0? if r != 0, then * the r * (1 / 0) will give infinity, which is clamped to 1.0, the correct @@ -2200,7 +2200,7 @@ static void pshader_hw_texdepth(const struct wined3d_shader_instruction *ins) */ shader_addline(buffer, "RCP %s.y, %s.y;\n", dst_name, dst_name); shader_addline(buffer, "MUL TA.x, %s.x, %s.y;\n", dst_name, dst_name); - shader_addline(buffer, "MIN TA.x, TA.x, one.x;\n"); + shader_addline(buffer, "MIN TA.x, TA.x, ps_helper_const.x;\n"); shader_addline(buffer, "MAX result.depth, TA.x, 0.0;\n"); } @@ -2276,7 +2276,7 @@ static void pshader_hw_texm3x2depth(const struct wined3d_shader_instruction *ins */ shader_addline(buffer, "RCP %s.y, %s.y;\n", dst_name, dst_name); shader_addline(buffer, "MUL %s.x, %s.x, %s.y;\n", dst_name, dst_name, dst_name); - shader_addline(buffer, "MIN %s.x, %s.x, one.x;\n", dst_name, dst_name); + shader_addline(buffer, "MIN %s.x, %s.x, ps_helper_const.x;\n", dst_name, dst_name); shader_addline(buffer, "MAX result.depth, %s.x, 0.0;\n", dst_name); } @@ -3485,7 +3485,7 @@ static GLuint shader_arb_generate_pshader(IWineD3DPixelShaderImpl *This, struct if(dcl_td) shader_addline(buffer, "TEMP TD;\n"); /* Used for sRGB writing */ shader_addline(buffer, "PARAM coefdiv = { 0.5, 0.25, 0.125, 0.0625 };\n"); shader_addline(buffer, "PARAM coefmul = { 2, 4, 8, 16 };\n"); - shader_addline(buffer, "PARAM one = { 1.0, 1.0, 1.0, 1.0 };\n"); + shader_addline(buffer, "PARAM ps_helper_const = { 1.0, 0.0, 0.0, 0.0 };\n"); if (reg_maps->shader_version.major < 2) {

1 0

Michael Stefaniuc : mcicda: Avoid using long.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: 309e92f449d8de5d70dc24ef912bb77c8ba5bf74 URL: http://source.winehq.org/git/wine.git/?a=commit;h=309e92f449d8de5d70dc24ef9… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri May 21 12:13:15 2010 +0200 mcicda: Avoid using long. --- dlls/mcicda/mcicda.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mcicda/mcicda.c b/dlls/mcicda/mcicda.c index 9f62594..cb8840e 100644 --- a/dlls/mcicda/mcicda.c +++ b/dlls/mcicda/mcicda.c @@ -564,7 +564,7 @@ static DWORD MCICDA_GetDevCaps(UINT wDevID, DWORD dwFlags, static DWORD CDROM_Audio_GetSerial(CDROM_TOC* toc) { - unsigned long serial = 0; + DWORD serial = 0; int i; WORD wMagic; DWORD dwStart, dwEnd;

1 0

Michael Stefaniuc : wined3d: Avoid using the long type.
by Alexandre Julliard May 21, 2010

May 21, 2010

Module: wine Branch: master Commit: 6d89364ad1c7b1ab87d24413561447f0ff971889 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d89364ad1c7b1ab87d244135… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri May 21 12:45:40 2010 +0200 wined3d: Avoid using the long type. --- dlls/wined3d/arb_program_shader.c | 4 ++-- dlls/wined3d/device.c | 2 +- dlls/wined3d/directx.c | 4 ++-- dlls/wined3d/drawprim.c | 18 +++++++++--------- dlls/wined3d/state.c | 2 +- dlls/wined3d/swapchain_gdi.c | 2 +- dlls/wined3d/utils.c | 8 ++++---- dlls/wined3d/wined3d_private.h | 4 ++-- 8 files changed, 22 insertions(+), 22 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6d89364ad1c7b1ab87d24…

1 0