May 2010 - Wine-Commits - list.winehq.org

Gerald Pfeifer : taskmgr: Remove unused variable PageSize which is not really used from PerfDataGetPhysicalMemorySystemCacheK .
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: 370cbe5e5be03bf721a2ac5aa148feeda61b551e URL: http://source.winehq.org/git/wine.git/?a=commit;h=370cbe5e5be03bf721a2ac5aa… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 16:45:36 2010 +0200 taskmgr: Remove unused variable PageSize which is not really used from PerfDataGetPhysicalMemorySystemCacheK. --- programs/taskmgr/perfdata.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/programs/taskmgr/perfdata.c b/programs/taskmgr/perfdata.c index 91400a5..0f3bf14 100644 --- a/programs/taskmgr/perfdata.c +++ b/programs/taskmgr/perfdata.c @@ -807,16 +807,13 @@ ULONG PerfDataGetPhysicalMemoryAvailableK(void) ULONG PerfDataGetPhysicalMemorySystemCacheK(void) { ULONG SystemCache; - ULONG PageSize; EnterCriticalSection(&PerfDataCriticalSection); SystemCache = SystemCacheInfo.CurrentSize; - PageSize = SystemBasicInfo.uPageSize; LeaveCriticalSection(&PerfDataCriticalSection); - /* SystemCache = SystemCache * (PageSize / 1024); */ SystemCache = SystemCache / 1024; return SystemCache;

1 0

Gerald Pfeifer : taskmgr: Remove variable CommitChargeLimit which is not really used from Graph_DrawMemUsageHistoryGraph .
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: e9c1750204645617c97de21a03d15b30d646f27e URL: http://source.winehq.org/git/wine.git/?a=commit;h=e9c1750204645617c97de21a0… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 16:42:24 2010 +0200 taskmgr: Remove variable CommitChargeLimit which is not really used from Graph_DrawMemUsageHistoryGraph. --- programs/taskmgr/graph.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/programs/taskmgr/graph.c b/programs/taskmgr/graph.c index 5e26ead..84a7307 100644 --- a/programs/taskmgr/graph.c +++ b/programs/taskmgr/graph.c @@ -320,7 +320,6 @@ static void Graph_DrawMemUsageGraph(HDC hDC, HWND hWnd) static void Graph_DrawMemUsageHistoryGraph(HDC hDC, HWND hWnd) { RECT rcClient; - ULONGLONG CommitChargeLimit; int i; static int offset = 0; @@ -338,11 +337,6 @@ static void Graph_DrawMemUsageHistoryGraph(HDC hDC, HWND hWnd) FillSolidRect(hDC, &rcClient, RGB(0, 0, 0)); /* - * Get the memory usage - */ - CommitChargeLimit = (ULONGLONG)PerfDataGetCommitChargeLimitK(); - - /* * Draw the graph background * * Draw the horizontal bars

1 0

Eric Pouech : winedbg: Properly fix the previous patch about gcc 2. 95 not supporting printf attribute on function pointers.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: c4efb23d2752e9283574caf660055fa14a87abfd URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4efb23d2752e9283574caf66… Author: Eric Pouech <eric.pouech(a)orange.fr> Date: Mon May 3 08:12:22 2010 +0200 winedbg: Properly fix the previous patch about gcc 2.95 not supporting printf attribute on function pointers. --- programs/winedbg/db_disasm64.c | 25 +++++++------------------ 1 files changed, 7 insertions(+), 18 deletions(-) diff --git a/programs/winedbg/db_disasm64.c b/programs/winedbg/db_disasm64.c index 98f7ef2..7cf1394 100644 --- a/programs/winedbg/db_disasm64.c +++ b/programs/winedbg/db_disasm64.c @@ -32,24 +32,13 @@ #include <stdio.h> #include "debugger.h" -#ifndef __GNUC__ -#define __attribute__(X) +#if defined(__GNUC__) && (GCC_VERSION >= 30000) +static int (*db_printf)(const char* format, ...) __attribute__((format (printf,1,2))); +#else +static int (*db_printf)(const char* format, ...); #endif -static int db_debug = 0; -static int db_printf(const char* format, ...) __attribute__((format (printf,1,2))); -int db_printf(const char* format, ...) -{ - va_list valist; - int len = 0; - if (db_debug) - { - va_start(valist, format); - len = dbg_printf(format, valist); - va_end(valist); - } - return len; -} +static int no_printf(const char* format, ...) {return 0;} typedef DWORD_PTR db_addr_t; typedef BOOL boolean_t; @@ -93,7 +82,7 @@ static ULONG64 db_get_value(db_addr_t addr, int size, int is_signed) static void db_printsym(db_addr_t addr, unsigned unused) { - if (db_debug) + if (db_printf != no_printf) { ADDRESS64 a; @@ -1656,6 +1645,6 @@ db_disasm(db_addr_t loc, boolean_t altfmt) void be_x86_64_disasm_one_insn(ADDRESS64 *addr, int display) { - db_debug = display; + db_printf = display ? dbg_printf : no_printf; addr->Offset = db_disasm(addr->Offset, TRUE); }

1 0

Maarten Lankhorst : include: Add float functions to msvcrt.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: f4fcd81167f36efaaf00ecc876d45cbfda510835 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f4fcd81167f36efaaf00ecc87… Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Sat May 1 16:32:45 2010 +0200 include: Add float functions to msvcrt. --- include/msvcrt/float.h | 4 +++ include/msvcrt/math.h | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+), 0 deletions(-) diff --git a/include/msvcrt/float.h b/include/msvcrt/float.h index a238d13..7d8f8ae 100644 --- a/include/msvcrt/float.h +++ b/include/msvcrt/float.h @@ -135,6 +135,10 @@ int __cdecl _finite(double); int __cdecl _isnan(double); int __cdecl _fpclass(double); +#ifdef __x86_64__ +float __cdecl _scalbf(float, __msvcrt_long); +#endif + #ifdef __cplusplus } #endif diff --git a/include/msvcrt/math.h b/include/msvcrt/math.h index a02378d..47c0f70 100644 --- a/include/msvcrt/math.h +++ b/include/msvcrt/math.h @@ -76,6 +76,61 @@ double __cdecl y0(double); double __cdecl y1(double); double __cdecl yn(int, double); +#ifdef __x86_64__ + +float __cdecl sinf(float); +float __cdecl cosf(float); +float __cdecl tanf(float); +float __cdecl sinhf(float); +float __cdecl coshf(float); +float __cdecl tanhf(float); +float __cdecl asinf(float); +float __cdecl acosf(float); +float __cdecl atanf(float); +float __cdecl atan2f(float, float); +float __cdecl expf(float); +float __cdecl logf(float); +float __cdecl log10f(float); +float __cdecl powf(float, float); +float __cdecl sqrtf(float); +float __cdecl ceilf(float); +float __cdecl floorf(float); +float __cdecl fabsf(float); +float __cdecl ldexpf(float, int); +float __cdecl frexpf(float, int*); +float __cdecl modff(float, float*); +float __cdecl fmodf(float, float); + +#else + +#define sinf(x) ((float)sin((double)(x))) +#define cosf(x) ((float)cos((double)(x))) +#define tanf(x) ((float)tan((double)(x))) +#define sinhf(x) ((float)sinh((double)(x))) +#define coshf(x) ((float)cosh((double)(x))) +#define tanhf(x) ((float)tanh((double)(x))) +#define asinf(x) ((float)asin((double)(x))) +#define acosf(x) ((float)acos((double)(x))) +#define atanf(x) ((float)atan((double)(x))) +#define atan2f(x,y) ((float)atan2((double)(x), (double)(y))) +#define expf(x) ((float)exp((double)(x))) +#define logf(x) ((float)log((double)(x))) +#define log10f(x) ((float)log10((double)(x))) +#define powf(x,y) ((float)pow((double)(x), (double)(y))) +#define sqrtf(x) ((float)sqrt((double)(x))) +#define ceilf(x) ((float)ceil((double)(x))) +#define floorf(x) ((float)floor((double)(x))) +#define frexpf(x) ((float)frexp((double)(x))) +#define modff(x,y) ((float)modf((double)(x), (double*)(y))) +#define fmodf(x,y) ((float)fmod((double)(x), (double)(y))) + +#endif + +#define fabsf(x) ((float)fabs((double)(x))) +#define ldexpf(x) ((float)ldexp((double)(x))) + +float __cdecl hypotf(float, float); + int __cdecl _matherr(struct _exception*); double __cdecl _cabs(struct _complex);

1 0

Austin English : msvcrt/tests: Add more tests for setlocale().
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: 3c09ca128d73e17078b90b8f4314eb5b813b3f4e URL: http://source.winehq.org/git/wine.git/?a=commit;h=3c09ca128d73e17078b90b8f4… Author: Austin English <austinenglish(a)gmail.com> Date: Sun May 2 16:40:24 2010 -0500 msvcrt/tests: Add more tests for setlocale(). --- dlls/msvcrt/tests/locale.c | 483 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 483 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3c09ca128d73e17078b90…

1 0

Hans Leidekker : programs: Add a stubbed sc.exe.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: 544da28e5396e6803f46ff1409330db009844c70 URL: http://source.winehq.org/git/wine.git/?a=commit;h=544da28e5396e6803f46ff140… Author: Hans Leidekker <hans(a)meelstraat.net> Date: Mon May 3 12:56:58 2010 +0200 programs: Add a stubbed sc.exe. This is a command line tool used to create and configure services. It's included in XP and used by the Akamai client installer. --- configure | 1 + configure.ac | 1 + programs/sc/Makefile.in | 12 ++++++++++++ programs/sc/sc.c | 27 +++++++++++++++++++++++++++ 4 files changed, 41 insertions(+), 0 deletions(-) diff --git a/configure b/configure index e1cdce7..52410fb 100755 --- a/configure +++ b/configure @@ -14768,6 +14768,7 @@ wine_fn_config_program regedit enable_regedit installbin wine_fn_config_program regsvr32 enable_regsvr32 installbin wine_fn_config_program rpcss enable_rpcss install wine_fn_config_program rundll32 enable_rundll32 install +wine_fn_config_program sc enable_sc install wine_fn_config_program secedit enable_secedit install wine_fn_config_program services enable_services install wine_fn_config_program spoolsv enable_spoolsv install diff --git a/configure.ac b/configure.ac index ac18264..227dee5 100644 --- a/configure.ac +++ b/configure.ac @@ -2696,6 +2696,7 @@ WINE_CONFIG_PROGRAM(regedit,installbin) WINE_CONFIG_PROGRAM(regsvr32,installbin) WINE_CONFIG_PROGRAM(rpcss,install) WINE_CONFIG_PROGRAM(rundll32,install) +WINE_CONFIG_PROGRAM(sc,install) WINE_CONFIG_PROGRAM(secedit,install) WINE_CONFIG_PROGRAM(services,install) WINE_CONFIG_PROGRAM(spoolsv,install) diff --git a/programs/sc/Makefile.in b/programs/sc/Makefile.in new file mode 100644 index 0000000..71a20cc --- /dev/null +++ b/programs/sc/Makefile.in @@ -0,0 +1,12 @@ +TOPSRCDIR = @top_srcdir@ +TOPOBJDIR = ../.. +SRCDIR = @srcdir@ +VPATH = @srcdir@ +MODULE = sc.exe +APPMODE = -mconsole -municode +IMPORTS = kernel32 +EXTRADEFS = -DWINE_NO_UNICODE_MACROS + +C_SRCS = sc.c + +(a)MAKE_PROG_RULES@ diff --git a/programs/sc/sc.c b/programs/sc/sc.c new file mode 100644 index 0000000..6eb9c9e --- /dev/null +++ b/programs/sc/sc.c @@ -0,0 +1,27 @@ +/* + * Copyright 2010 Hans Leidekker + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(sc); + +int wmain( int argc, WCHAR *argv[] ) +{ + WINE_FIXME("stub\n"); + return 1; +}

1 0

Hans Leidekker : sc: Implement the description and failure commands.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: 3e1f5ba3828f033817b8366fdcb3e9714bbb48a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3e1f5ba3828f033817b8366fd… Author: Hans Leidekker <hans(a)meelstraat.net> Date: Mon May 3 12:57:39 2010 +0200 sc: Implement the description and failure commands. --- programs/sc/sc.c | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 109 insertions(+), 0 deletions(-) diff --git a/programs/sc/sc.c b/programs/sc/sc.c index 1994fff..32ffb85 100644 --- a/programs/sc/sc.c +++ b/programs/sc/sc.c @@ -132,6 +132,81 @@ static BOOL parse_create_params( int argc, const WCHAR *argv[], struct create_pa return TRUE; } +static BOOL parse_failure_actions( const WCHAR *arg, SERVICE_FAILURE_ACTIONSW *fa ) +{ + static const WCHAR runW[] = {'r','u','n',0}; + static const WCHAR restartW[] = {'r','e','s','t','a','r','t',0}; + static const WCHAR rebootW[] = {'r','e','b','o','o','t',0}; + unsigned int i, count; + WCHAR *actions, *p; + + actions = HeapAlloc( GetProcessHeap(), 0, (strlenW( arg ) + 1) * sizeof(WCHAR) ); + if (!actions) return FALSE; + + strcpyW( actions, arg ); + for (p = actions, count = 0; *p; p++) + { + if (*p == '/') + { + count++; + *p = 0; + } + } + count = count / 2 + 1; + + fa->cActions = count; + fa->lpsaActions = HeapAlloc( GetProcessHeap(), 0, fa->cActions * sizeof(SC_ACTION) ); + if (!fa->lpsaActions) + { + HeapFree( GetProcessHeap(), 0, actions ); + return FALSE; + } + + p = actions; + for (i = 0; i < count; i++) + { + if (!strcmpiW( p, runW )) fa->lpsaActions[i].Type = SC_ACTION_RUN_COMMAND; + else if (!strcmpiW( p, restartW )) fa->lpsaActions[i].Type = SC_ACTION_RESTART; + else if (!strcmpiW( p, rebootW )) fa->lpsaActions[i].Type = SC_ACTION_REBOOT; + else fa->lpsaActions[i].Type = SC_ACTION_NONE; + + p += strlenW( p ) + 1; + fa->lpsaActions[i].Delay = atoiW( p ); + p += strlenW( p ) + 1; + } + + HeapFree( GetProcessHeap(), 0, actions ); + return TRUE; +} + +static BOOL parse_failure_params( int argc, const WCHAR *argv[], SERVICE_FAILURE_ACTIONSW *fa ) +{ + static const WCHAR resetW[] = {'r','e','s','e','t','=',0}; + static const WCHAR rebootW[] = {'r','e','b','o','o','t','=',0}; + static const WCHAR commandW[] = {'c','o','m','m','a','n','d','=',0}; + static const WCHAR actionsW[] = {'a','c','t','i','o','n','s','=',0}; + unsigned int i; + + fa->dwResetPeriod = 0; + fa->lpRebootMsg = NULL; + fa->lpCommand = NULL; + fa->cActions = 0; + fa->lpsaActions = NULL; + + for (i = 0; i < argc; i++) + { + if (!strcmpiW( argv[i], resetW ) && i < argc - 1) fa->dwResetPeriod = atoiW( argv[i + 1] ); + if (!strcmpiW( argv[i], rebootW ) && i < argc - 1) fa->lpRebootMsg = (WCHAR *)argv[i + 1]; + if (!strcmpiW( argv[i], commandW ) && i < argc - 1) fa->lpCommand = (WCHAR *)argv[i + 1]; + if (!strcmpiW( argv[i], actionsW )) + { + if (i == argc - 1) return FALSE; + if (!parse_failure_actions( argv[i + 1], fa )) return FALSE; + } + } + return TRUE; +} + static void usage( void ) { WINE_MESSAGE( "Usage: sc command servicename [parameter= value ...]\n" ); @@ -141,6 +216,8 @@ static void usage( void ) int wmain( int argc, const WCHAR *argv[] ) { static const WCHAR createW[] = {'c','r','e','a','t','e',0}; + static const WCHAR descriptionW[] = {'d','e','s','c','r','i','p','t','i','o','n',0}; + static const WCHAR failureW[] = {'f','a','i','l','u','r','e',0}; static const WCHAR deleteW[] = {'d','e','l','e','t','e',0}; SC_HANDLE manager, service; BOOL ret = FALSE; @@ -185,6 +262,38 @@ int wmain( int argc, const WCHAR *argv[] ) } else WINE_TRACE("failed to create service %u\n", GetLastError()); } + else if (!strcmpiW( argv[1], descriptionW )) + { + service = OpenServiceW( manager, argv[2], SERVICE_CHANGE_CONFIG ); + if (service) + { + SERVICE_DESCRIPTIONW sd; + sd.lpDescription = argc > 3 ? (WCHAR *)argv[3] : NULL; + ret = ChangeServiceConfig2W( service, SERVICE_CONFIG_DESCRIPTION, &sd ); + if (!ret) WINE_TRACE("failed to set service description %u\n", GetLastError()); + CloseServiceHandle( service ); + } + else WINE_TRACE("failed to open service %u\n", GetLastError()); + } + else if (!strcmpiW( argv[1], failureW )) + { + service = OpenServiceW( manager, argv[2], SERVICE_CHANGE_CONFIG ); + if (service) + { + SERVICE_FAILURE_ACTIONSW sfa; + if (!parse_failure_params( argc - 3, argv + 3, &sfa )) + { + WINE_WARN("failed to parse failure parameters\n"); + CloseServiceHandle( manager ); + return 1; + } + ret = ChangeServiceConfig2W( service, SERVICE_CONFIG_FAILURE_ACTIONS, &sfa ); + if (!ret) WINE_TRACE("failed to set service failure actions %u\n", GetLastError()); + HeapFree( GetProcessHeap(), 0, sfa.lpsaActions ); + CloseServiceHandle( service ); + } + else WINE_TRACE("failed to open service %u\n", GetLastError()); + } else if (!strcmpiW( argv[1], deleteW )) { service = OpenServiceW( manager, argv[2], DELETE );

1 0

Nikolay Sivov : rasdlg: Add RasEntryDlgW stub.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: dc04cee787b053d2436909d320d5f6e941fb03ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=dc04cee787b053d2436909d32… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 3 15:03:49 2010 +0400 rasdlg: Add RasEntryDlgW stub. --- dlls/rasdlg/rasdlg.spec | 2 +- dlls/rasdlg/rasdlg_main.c | 8 ++++++++ include/Makefile.in | 1 + include/rasdlg.h | 32 ++++++++++++++++++++++++++++++++ 4 files changed, 42 insertions(+), 1 deletions(-) diff --git a/dlls/rasdlg/rasdlg.spec b/dlls/rasdlg/rasdlg.spec index f6a36d6..0dbd7b0 100644 --- a/dlls/rasdlg/rasdlg.spec +++ b/dlls/rasdlg/rasdlg.spec @@ -7,7 +7,7 @@ @ stub RasDialDlgA @ stub RasDialDlgW @ stub RasEntryDlgA -@ stub RasEntryDlgW +@ stdcall RasEntryDlgW(wstr wstr ptr) @ stub RasMonitorDlgA @ stub RasMonitorDlgW @ stub RasPhonebookDlgA diff --git a/dlls/rasdlg/rasdlg_main.c b/dlls/rasdlg/rasdlg_main.c index 00ceb89..255e6e6 100644 --- a/dlls/rasdlg/rasdlg_main.c +++ b/dlls/rasdlg/rasdlg_main.c @@ -21,6 +21,8 @@ #include "windef.h" #include "winbase.h" +#include "rasdlg.h" + #include "wine/debug.h" WINE_DEFAULT_DEBUG_CHANNEL(rasdlg); @@ -42,3 +44,9 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) return TRUE; } + +BOOL WINAPI RasEntryDlgW(LPWSTR phonebook, LPWSTR entry, RASENTRYDLGW *lpInfo) +{ + FIXME("(%s %s %p) stub\n", debugstr_w(phonebook), debugstr_w(entry), lpInfo); + return FALSE; +} diff --git a/include/Makefile.in b/include/Makefile.in index 3f9b43b..a064076 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -414,6 +414,7 @@ SRCDIR_INCLUDES = \ pshpack4.h \ pshpack8.h \ ras.h \ + rasdlg.h \ raserror.h \ reason.h \ regstr.h \ diff --git a/include/rasdlg.h b/include/rasdlg.h new file mode 100644 index 0000000..7f2a6d8 --- /dev/null +++ b/include/rasdlg.h @@ -0,0 +1,32 @@ +/* + * Copyright (C) 2010 Nikolay Sivov for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <ras.h> + +typedef struct tagRASENTRYDLGW +{ + DWORD dwSize; + HWND hwndOwner; + DWORD dwFlags; + LONG xDlg; + LONG yDlg; + WCHAR szEntry[ RAS_MaxEntryName + 1 ]; + DWORD dwError; + ULONG_PTR reserved; + ULONG_PTR reserved2; +} RASENTRYDLGW;

1 0

Gerald Pfeifer : cmd: Remove variable doRecursive which is not really used from WCMD_for.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: 02a0bd3a00e741d1ff0379c884f513b7ed3aa7e3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=02a0bd3a00e741d1ff0379c88… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat May 1 16:24:45 2010 +0200 cmd: Remove variable doRecursive which is not really used from WCMD_for. --- programs/cmd/builtins.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index 8049ed8..b75c0c4 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -723,7 +723,6 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) { WCHAR *curPos = p; BOOL expandDirs = FALSE; BOOL useNumbers = FALSE; - BOOL doRecursive = FALSE; BOOL doFileset = FALSE; LONG numbers[3] = {0,0,0}; /* Defaults to 0 in native */ int itemNum; @@ -745,8 +744,8 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) { { BOOL isRecursive = (*curPos == 'R'); - if (isRecursive) doRecursive = TRUE; - else doFileset = TRUE; + if (!isRecursive) + doFileset = TRUE; /* Skip whitespace */ curPos++;

1 0

Hans Leidekker : sc: Implement the start and stop commands.
by Alexandre Julliard May 3, 2010

May 3, 2010

Module: wine Branch: master Commit: e86ed3bf91e980cb875f463f17ac8d045989ab83 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e86ed3bf91e980cb875f463f1… Author: Hans Leidekker <hans(a)meelstraat.net> Date: Mon May 3 12:57:57 2010 +0200 sc: Implement the start and stop commands. --- programs/sc/sc.c | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/programs/sc/sc.c b/programs/sc/sc.c index 32ffb85..e4df09a 100644 --- a/programs/sc/sc.c +++ b/programs/sc/sc.c @@ -219,7 +219,10 @@ int wmain( int argc, const WCHAR *argv[] ) static const WCHAR descriptionW[] = {'d','e','s','c','r','i','p','t','i','o','n',0}; static const WCHAR failureW[] = {'f','a','i','l','u','r','e',0}; static const WCHAR deleteW[] = {'d','e','l','e','t','e',0}; + static const WCHAR startW[] = {'s','t','a','r','t',0}; + static const WCHAR stopW[] = {'s','t','o','p',0}; SC_HANDLE manager, service; + SERVICE_STATUS status; BOOL ret = FALSE; if (argc < 3) usage(); @@ -305,6 +308,28 @@ int wmain( int argc, const WCHAR *argv[] ) } else WINE_TRACE("failed to open service %u\n", GetLastError()); } + else if (!strcmpiW( argv[1], startW )) + { + service = OpenServiceW( manager, argv[2], SERVICE_START ); + if (service) + { + ret = StartServiceW( service, argc - 3, argv + 3 ); + if (!ret) WINE_TRACE("failed to start service %u\n", GetLastError()); + CloseServiceHandle( service ); + } + else WINE_TRACE("failed to open service %u\n", GetLastError()); + } + else if (!strcmpiW( argv[1], stopW )) + { + service = OpenServiceW( manager, argv[2], SERVICE_STOP ); + if (service) + { + ret = ControlService( service, SERVICE_CONTROL_STOP, &status ); + if (!ret) WINE_TRACE("failed to stop service %u\n", GetLastError()); + CloseServiceHandle( service ); + } + else WINE_TRACE("failed to open service %u\n", GetLastError()); + } else WINE_FIXME("command not supported\n");

1 0