September 2010 - Wine-Commits

Mariusz Pluciński : gameux: IGameStatistics:: GetMaxValueLength implementation.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 448ac80fd4e917daf2151e38165a4fe0288358b3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=448ac80fd4e917daf2151e381… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:39:49 2010 +0200 gameux: IGameStatistics::GetMaxValueLength implementation. --- dlls/gameux/gamestatistics.c | 9 +++++++-- dlls/gameux/tests/gamestatistics.c | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index 905baf2..f0ee14c 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -33,6 +33,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(gameux); #define MAX_CATEGORY_LENGTH 60 #define MAX_NAME_LENGTH 30 +#define MAX_VALUE_LENGTH 30 /******************************************************************************* * IGameStatistics implementation */ @@ -134,8 +135,12 @@ static HRESULT WINAPI GameStatisticsImpl_GetMaxValueLength( IGameStatistics *iface, UINT *cch) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p, %p)\n", iface, cch); + if(!cch) + return E_INVALIDARG; + + *cch = MAX_VALUE_LENGTH; + return S_OK; } static HRESULT WINAPI GameStatisticsImpl_GetMaxCategories( diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index 3904bea..d494d22 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -252,8 +252,8 @@ static void test_gamestatisticsmgr( void ) ok(uMaxNameLength==30, "getting maximum name length returned invalid value: %d\n", uMaxNameLength); hr = IGameStatistics_GetMaxValueLength(gs, &uMaxValueLength); - todo_wine ok(hr==S_OK, "getting maximum value length failed\n"); - todo_wine ok(uMaxValueLength==30, "getting maximum value length returned invalid value: %d\n", uMaxValueLength); + ok(hr==S_OK, "getting maximum value length failed\n"); + ok(uMaxValueLength==30, "getting maximum value length returned invalid value: %d\n", uMaxValueLength); hr = IGameStatistics_GetMaxCategories(gs, &wMaxCategories); todo_wine ok(hr==S_OK, "getting maximum number of categories failed\n");

1 0

Mariusz Pluciński : gameux: IGameStatistics:: GetMaxNameLength implementation.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 301433b67034983313268022319d4ef4d36a0125 URL: http://source.winehq.org/git/wine.git/?a=commit;h=301433b670349833132680223… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:39:42 2010 +0200 gameux: IGameStatistics::GetMaxNameLength implementation. --- dlls/gameux/gamestatistics.c | 9 +++++++-- dlls/gameux/tests/gamestatistics.c | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index 063fbd5..905baf2 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -32,6 +32,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(gameux); #define MAX_CATEGORY_LENGTH 60 +#define MAX_NAME_LENGTH 30 /******************************************************************************* * IGameStatistics implementation */ @@ -121,8 +122,12 @@ static HRESULT WINAPI GameStatisticsImpl_GetMaxNameLength( IGameStatistics *iface, UINT *cch) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p, %p)\n", iface, cch); + if(!cch) + return E_INVALIDARG; + + *cch = MAX_NAME_LENGTH; + return S_OK; } static HRESULT WINAPI GameStatisticsImpl_GetMaxValueLength( diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index 80e4e91..3904bea 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -248,8 +248,8 @@ static void test_gamestatisticsmgr( void ) ok(uMaxCategoryLength==60, "getting maximum length of category returned invalid value: %d\n", uMaxCategoryLength); hr = IGameStatistics_GetMaxNameLength(gs, &uMaxNameLength); - todo_wine ok(hr==S_OK, "getting maximum name length failed\n"); - todo_wine ok(uMaxNameLength==30, "getting maximum name length returned invalid value: %d\n", uMaxNameLength); + ok(hr==S_OK, "getting maximum name length failed\n"); + ok(uMaxNameLength==30, "getting maximum name length returned invalid value: %d\n", uMaxNameLength); hr = IGameStatistics_GetMaxValueLength(gs, &uMaxValueLength); todo_wine ok(hr==S_OK, "getting maximum value length failed\n");

1 0

Mariusz Pluciński : gameux/tests: Add test of storing and reading game statistics.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 7c798a4a7d849baf44fa8ee5d2a6cc44762b58db URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c798a4a7d849baf44fa8ee5d… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:36:57 2010 +0200 gameux/tests: Add test of storing and reading game statistics. --- dlls/gameux/tests/gamestatistics.c | 314 ++++++++++++++++++++++++++++++++++-- 1 files changed, 302 insertions(+), 12 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7c798a4a7d849baf44fa8…

1 0

Mariusz Pluciński : gameux: Add partial implementation of IGameStatisticsMgr::GetGameStatistics.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 23efe79289a019fec68708425e66baf3baee84ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=23efe79289a019fec68708425… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:37:42 2010 +0200 gameux: Add partial implementation of IGameStatisticsMgr::GetGameStatistics. --- dlls/gameux/gameexplorer.c | 39 +++---------------------------- dlls/gameux/gamestatistics.c | 52 ++++++++++++++++++++++++++++++++++++++++- dlls/gameux/gameux_private.h | 49 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 103 insertions(+), 37 deletions(-) diff --git a/dlls/gameux/gameexplorer.c b/dlls/gameux/gameexplorer.c index 1816ebd..744ae8a 100644 --- a/dlls/gameux/gameexplorer.c +++ b/dlls/gameux/gameexplorer.c @@ -69,29 +69,9 @@ void GAMEUX_uninitGameData(struct GAMEUX_GAME_DATA *GameData) /******************************************************************************* * GAMEUX_buildGameRegistryPath * - * Helper function, builds registry path to key, where game's data are stored - * - * Parameters: - * installScope [I] the scope which was used in AddGame/InstallGame call - * gameInstanceId [I] game instance GUID. If NULL, then only - * path to scope will be returned - * lpRegistryPath [O] pointer which will receive address to string - * containing expected registry path. Path - * is relative to HKLM registry key. It - * must be freed by calling HeapFree(GetProcessHeap(), 0, ...) - * - * Name of game's registry key always follows patterns below: - * When game is installed for current user only (installScope is GIS_CURRENT_USER): - * HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\ - * GameUX\[user's security ID]\[game instance ID] - * - * When game is installed for all users (installScope is GIS_ALL_USERS): - * HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\ - * GameUX\Games\[game instance ID] - * - * + * Internal helper function. Description available in gameux_private.h file */ -static HRESULT GAMEUX_buildGameRegistryPath(GAME_INSTALL_SCOPE installScope, +HRESULT GAMEUX_buildGameRegistryPath(GAME_INSTALL_SCOPE installScope, LPCGUID gameInstanceId, LPWSTR* lpRegistryPath) { @@ -697,20 +677,9 @@ static HRESULT GAMEUX_UpdateGame(LPGUID InstanceID) { /******************************************************************************* * GAMEUX_FindGameInstanceId * - * Helper funtion. Searches for instance identifier of given game in given - * installation scope. - * - * Parameters: - * sGDFBinaryPath [I] path to binary containing GDF - * installScope [I] game install scope to search in - * pInstanceId [O] instance identifier of given game - * - * Returns: - * S_OK id was returned properly - * S_FALSE id was not found in the registry - * E_OUTOFMEMORY problem while memory allocation + * Internal helper function. Description available in gameux_private.h file */ -static HRESULT GAMEUX_FindGameInstanceId( +HRESULT GAMEUX_FindGameInstanceId( LPCWSTR sGDFBinaryPath, GAME_INSTALL_SCOPE installScope, GUID* pInstanceId) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index 098754e..0b872ac 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -22,6 +22,7 @@ #include "config.h" #include "ole2.h" +#include "winreg.h" #include "gameux.h" #include "gameux_private.h" @@ -107,8 +108,55 @@ static HRESULT STDMETHODCALLTYPE GameStatisticsMgrImpl_GetGameStatistics( GAMESTATS_OPEN_RESULT *pOpenResult, IGameStatistics **ppiStats) { - FIXME("stub (%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats); - return E_NOTIMPL; + static const WCHAR sApplicationId[] = + {'A','p','p','l','i','c','a','t','i','o','n','I','d',0}; + + HRESULT hr; + GUID instanceId; + LPWSTR lpRegistryPath = NULL; + WCHAR lpApplicationId[49]; + DWORD dwLength = sizeof(lpApplicationId); + GAME_INSTALL_SCOPE installScope; + + TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats); + + if(!GDFBinaryPath) + return E_INVALIDARG; + + installScope = GIS_CURRENT_USER; + hr = GAMEUX_FindGameInstanceId(GDFBinaryPath, installScope, &instanceId); + + if(hr == S_FALSE) + { + installScope = GIS_ALL_USERS; + hr = GAMEUX_FindGameInstanceId(GDFBinaryPath, installScope, &instanceId); + } + + if(hr == S_FALSE) + /* game not registered, so statistics cannot be used */ + hr = E_FAIL; + + if(SUCCEEDED(hr)) + /* game is registered, let's read it's application id from registry */ + hr = GAMEUX_buildGameRegistryPath(installScope, &instanceId, &lpRegistryPath); + + if(SUCCEEDED(hr)) + { + hr = HRESULT_FROM_WIN32(RegGetValueW(HKEY_LOCAL_MACHINE, + lpRegistryPath, sApplicationId, RRF_RT_REG_SZ, + NULL, lpApplicationId, &dwLength)); + } + + if(SUCCEEDED(hr)) + { + TRACE("found app id: %s\n", debugstr_w(lpApplicationId)); + FIXME("creating instance of IGameStatistics not yet implemented\n"); + hr = E_NOTIMPL; + } + + HeapFree(GetProcessHeap(), 0, lpRegistryPath); + + return hr; } static HRESULT STDMETHODCALLTYPE GameStatisticsMgrImpl_RemoveGameStatistics( diff --git a/dlls/gameux/gameux_private.h b/dlls/gameux/gameux_private.h index 97826f0..86532e2 100644 --- a/dlls/gameux/gameux_private.h +++ b/dlls/gameux/gameux_private.h @@ -86,3 +86,52 @@ HRESULT WINAPI GAMEUX_RegisterGame(LPCWSTR sGDFBinaryPath, LPCWSTR sGameInstallDirectory, GAME_INSTALL_SCOPE installScope, GUID *pInstanceID); +/******************************************************************************* + * GAMEUX_FindGameInstanceId + * + * Helper funtion. Searches for instance identifier of given game in given + * installation scope. Implemented in gameexplorer.c + * + * Parameters: + * sGDFBinaryPath [I] path to binary containing GDF + * installScope [I] game install scope to search in + * pInstanceId [O] instance identifier of given game + * + * Returns: + * S_OK id was returned properly + * S_FALSE id was not found in the registry + * E_OUTOFMEMORY problem while memory allocation + */ +HRESULT GAMEUX_FindGameInstanceId( + LPCWSTR sGDFBinaryPath, + GAME_INSTALL_SCOPE installScope, + GUID* pInstanceId); +/******************************************************************************* + * GAMEUX_buildGameRegistryPath + * + * Helper function, builds registry path to key, where game's data are stored. + * Implemented in gameexplorer.c + * + * Parameters: + * installScope [I] the scope which was used in AddGame/InstallGame call + * gameInstanceId [I] game instance GUID. If NULL, then only + * path to scope will be returned + * lpRegistryPath [O] pointer which will receive address to string + * containing expected registry path. Path + * is relative to HKLM registry key. It + * must be freed by calling HeapFree(GetProcessHeap(), 0, ...) + * + * Name of game's registry key always follows patterns below: + * When game is installed for current user only (installScope is GIS_CURRENT_USER): + * HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\ + * GameUX\[user's security ID]\[game instance ID] + * + * When game is installed for all users (installScope is GIS_ALL_USERS): + * HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\ + * GameUX\Games\[game instance ID] + * + * + */ +HRESULT GAMEUX_buildGameRegistryPath(GAME_INSTALL_SCOPE installScope, + LPCGUID gameInstanceId, + LPWSTR* lpRegistryPath);

1 0

Mariusz Pluciński : gameux: Add stub of IGameStatistics interface implementation.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 0ef59050c6c855907fc1a2b2f04fbe5ef2816e14 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ef59050c6c855907fc1a2b2f… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:37:54 2010 +0200 gameux: Add stub of IGameStatistics interface implementation. --- dlls/gameux/gamestatistics.c | 224 +++++++++++++++++++++++++++++++++++- dlls/gameux/tests/gamestatistics.c | 2 +- 2 files changed, 222 insertions(+), 4 deletions(-) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index 0b872ac..6978173 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -31,10 +31,221 @@ WINE_DEFAULT_DEBUG_CHANNEL(gameux); -/* - * IGameStatisticsMgr implementation +/******************************************************************************* + * IGameStatistics implementation */ +typedef struct _GameStatisticsImpl +{ + const struct IGameStatisticsVtbl *lpVtbl; + LONG ref; +} GameStatisticsImpl; + +static inline GameStatisticsImpl *impl_from_IGameStatistics( IGameStatistics *iface ) +{ + return (GameStatisticsImpl *)((char*)iface - FIELD_OFFSET(GameStatisticsImpl, lpVtbl)); +} +static inline IGameStatistics *IGameStatistics_from_impl( GameStatisticsImpl* This ) +{ + return (struct IGameStatistics*)&This->lpVtbl; +} + + +static HRESULT WINAPI GameStatisticsImpl_QueryInterface( + IGameStatistics *iface, + REFIID riid, + void **ppvObject) +{ + GameStatisticsImpl *This = impl_from_IGameStatistics( iface ); + + TRACE("%p %s %p\n", This, debugstr_guid( riid ), ppvObject ); + + *ppvObject = NULL; + + if ( IsEqualGUID( riid, &IID_IUnknown ) || + IsEqualGUID( riid, &IID_IGameStatistics ) ) + { + *ppvObject = iface; + } + else + { + FIXME("interface %s not implemented\n", debugstr_guid(riid)); + return E_NOINTERFACE; + } + + IGameStatistics_AddRef( iface ); + return S_OK; +} + +static ULONG WINAPI GameStatisticsImpl_AddRef(IGameStatistics *iface) +{ + GameStatisticsImpl *This = impl_from_IGameStatistics( iface ); + LONG ref; + + ref = InterlockedIncrement(&This->ref); + + TRACE("(%p): ref=%d\n", This, ref); + return ref; +} + +static ULONG WINAPI GameStatisticsImpl_Release(IGameStatistics *iface) +{ + GameStatisticsImpl *This = impl_from_IGameStatistics( iface ); + LONG ref; + + ref = InterlockedDecrement( &This->ref ); + TRACE("(%p): ref=%d\n", This, ref); + + if ( ref == 0 ) + { + TRACE("freeing IGameStatistics\n"); + HeapFree( GetProcessHeap(), 0, This ); + } + + return ref; +} + +static HRESULT WINAPI GameStatisticsImpl_GetMaxCategoryLength( + IGameStatistics *iface, + UINT *cch) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetMaxNameLength( + IGameStatistics *iface, + UINT *cch) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} +static HRESULT WINAPI GameStatisticsImpl_GetMaxValueLength( + IGameStatistics *iface, + UINT *cch) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetMaxCategories( + IGameStatistics *iface, + WORD *pMax) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetMaxStatsPerCategory( + IGameStatistics *iface, + WORD *pMax) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_SetCategoryTitle( + IGameStatistics *iface, + WORD categoryIndex, + LPCWSTR title) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetCategoryTitle( + IGameStatistics *iface, + WORD categoryIndex, + LPWSTR *pTitle) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetStatistic( + IGameStatistics *iface, + WORD categoryIndex, + WORD statIndex, + LPWSTR *pName, + LPWSTR *pValue) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_SetStatistic( + IGameStatistics *iface, + WORD categoryIndex, + WORD statIndex, + LPCWSTR name, + LPCWSTR value) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_Save( + IGameStatistics *iface, + BOOL trackChanges) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_SetLastPlayedCategory( + IGameStatistics *iface, + UINT categoryIndex) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI GameStatisticsImpl_GetLastPlayedCategory( + IGameStatistics *iface, + UINT *pCategoryIndex) +{ + FIXME("stub\n"); + return E_NOTIMPL; +} + +static const struct IGameStatisticsVtbl GameStatisticsImplVtbl = +{ + GameStatisticsImpl_QueryInterface, + GameStatisticsImpl_AddRef, + GameStatisticsImpl_Release, + GameStatisticsImpl_GetMaxCategoryLength, + GameStatisticsImpl_GetMaxNameLength, + GameStatisticsImpl_GetMaxValueLength, + GameStatisticsImpl_GetMaxCategories, + GameStatisticsImpl_GetMaxStatsPerCategory, + GameStatisticsImpl_SetCategoryTitle, + GameStatisticsImpl_GetCategoryTitle, + GameStatisticsImpl_GetStatistic, + GameStatisticsImpl_SetStatistic, + GameStatisticsImpl_Save, + GameStatisticsImpl_SetLastPlayedCategory, + GameStatisticsImpl_GetLastPlayedCategory +}; + + +HRESULT create_IGameStatistics(GameStatisticsImpl** ppStats) +{ + TRACE("(%p)\n", ppStats); + + *ppStats = HeapAlloc( GetProcessHeap(), 0, sizeof(**ppStats)); + if(!(*ppStats)) + return E_OUTOFMEMORY; + + (*ppStats)->lpVtbl = &GameStatisticsImplVtbl; + (*ppStats)->ref = 1; + + TRACE("returing coclass: %p\n", *ppStats); + return S_OK; +} + +/******************************************************************************* + * IGameStatisticsMgr implementation + */ typedef struct _GameStatisticsMgrImpl { const struct IGameStatisticsMgrVtbl *lpVtbl; @@ -117,6 +328,7 @@ static HRESULT STDMETHODCALLTYPE GameStatisticsMgrImpl_GetGameStatistics( WCHAR lpApplicationId[49]; DWORD dwLength = sizeof(lpApplicationId); GAME_INSTALL_SCOPE installScope; + GameStatisticsImpl *statisticsImpl; TRACE("(%p, %s, 0x%x, %p, %p)\n", iface, debugstr_w(GDFBinaryPath), openType, pOpenResult, ppiStats); @@ -150,7 +362,13 @@ static HRESULT STDMETHODCALLTYPE GameStatisticsMgrImpl_GetGameStatistics( if(SUCCEEDED(hr)) { TRACE("found app id: %s\n", debugstr_w(lpApplicationId)); - FIXME("creating instance of IGameStatistics not yet implemented\n"); + hr = create_IGameStatistics(&statisticsImpl); + } + + if(SUCCEEDED(hr)) + { + *ppiStats = IGameStatistics_from_impl(statisticsImpl); + FIXME("loading game statistics not yet implemented\n"); hr = E_NOTIMPL; } diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index 87b1066..7641157 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -239,7 +239,7 @@ static void test_gamestatisticsmgr( void ) /* now, allow to create */ hr = IGameStatisticsMgr_GetGameStatistics(gsm, sExeName, GAMESTATS_OPEN_OPENORCREATE, &dwOpenResult, &gs); todo_wine ok(SUCCEEDED(hr), "GetGameStatistics returned error: 0x%x\n", hr); - todo_wine ok(gs!=NULL, "GetGameStatistics did not return valid interface pointer\n"); + ok(gs!=NULL, "GetGameStatistics did not return valid interface pointer\n"); if(gs) { /* test of limit values returned from interface */

1 0

Mariusz Pluciński : gameux: IGameStatistics:: GetMaxCategoryLength implementation.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 26552958f898d24356842c21f1734582769db65b URL: http://source.winehq.org/git/wine.git/?a=commit;h=26552958f898d24356842c21f… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:39:30 2010 +0200 gameux: IGameStatistics::GetMaxCategoryLength implementation. --- dlls/gameux/gamestatistics.c | 9 +++++++-- dlls/gameux/tests/gamestatistics.c | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index 6978173..063fbd5 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -31,6 +31,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(gameux); +#define MAX_CATEGORY_LENGTH 60 /******************************************************************************* * IGameStatistics implementation */ @@ -108,8 +109,12 @@ static HRESULT WINAPI GameStatisticsImpl_GetMaxCategoryLength( IGameStatistics *iface, UINT *cch) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p, %p)\n", iface, cch); + if(!cch) + return E_INVALIDARG; + + *cch = MAX_CATEGORY_LENGTH; + return S_OK; } static HRESULT WINAPI GameStatisticsImpl_GetMaxNameLength( diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index 7641157..80e4e91 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -244,8 +244,8 @@ static void test_gamestatisticsmgr( void ) { /* test of limit values returned from interface */ hr = IGameStatistics_GetMaxCategoryLength(gs, &uMaxCategoryLength); - todo_wine ok(hr==S_OK, "getting maximum length of category failed\n"); - todo_wine ok(uMaxCategoryLength==60, "getting maximum length of category returned invalid value: %d\n", uMaxCategoryLength); + ok(hr==S_OK, "getting maximum length of category failed\n"); + ok(uMaxCategoryLength==60, "getting maximum length of category returned invalid value: %d\n", uMaxCategoryLength); hr = IGameStatistics_GetMaxNameLength(gs, &uMaxNameLength); todo_wine ok(hr==S_OK, "getting maximum name length failed\n");

1 0

Mariusz Pluciński : gameux: IGameStatistics:: GetMaxCategories implementation.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 6dfb5f6a33d6323394a75665cfd93082ed048ff0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6dfb5f6a33d6323394a75665c… Author: Mariusz Pluciński <vshader(a)gmail.com> Date: Thu Sep 23 15:39:57 2010 +0200 gameux: IGameStatistics::GetMaxCategories implementation. --- dlls/gameux/gamestatistics.c | 9 +++++++-- dlls/gameux/tests/gamestatistics.c | 4 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/gameux/gamestatistics.c b/dlls/gameux/gamestatistics.c index f0ee14c..c318eef 100644 --- a/dlls/gameux/gamestatistics.c +++ b/dlls/gameux/gamestatistics.c @@ -34,6 +34,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(gameux); #define MAX_CATEGORY_LENGTH 60 #define MAX_NAME_LENGTH 30 #define MAX_VALUE_LENGTH 30 +#define MAX_CATEGORIES 10 /******************************************************************************* * IGameStatistics implementation */ @@ -147,8 +148,12 @@ static HRESULT WINAPI GameStatisticsImpl_GetMaxCategories( IGameStatistics *iface, WORD *pMax) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p, %p)\n", iface, pMax); + if(!pMax) + return E_INVALIDARG; + + *pMax = MAX_CATEGORIES; + return S_OK; } static HRESULT WINAPI GameStatisticsImpl_GetMaxStatsPerCategory( diff --git a/dlls/gameux/tests/gamestatistics.c b/dlls/gameux/tests/gamestatistics.c index d494d22..e485f9f 100644 --- a/dlls/gameux/tests/gamestatistics.c +++ b/dlls/gameux/tests/gamestatistics.c @@ -256,8 +256,8 @@ static void test_gamestatisticsmgr( void ) ok(uMaxValueLength==30, "getting maximum value length returned invalid value: %d\n", uMaxValueLength); hr = IGameStatistics_GetMaxCategories(gs, &wMaxCategories); - todo_wine ok(hr==S_OK, "getting maximum number of categories failed\n"); - todo_wine ok(wMaxCategories==10, "getting maximum number of categories returned invalid value: %d\n", wMaxCategories); + ok(hr==S_OK, "getting maximum number of categories failed\n"); + ok(wMaxCategories==10, "getting maximum number of categories returned invalid value: %d\n", wMaxCategories); hr = IGameStatistics_GetMaxStatsPerCategory(gs, &wMaxStatsPerCategory); todo_wine ok(hr==S_OK, "getting maximum number of statistics per category failed\n");

1 0

Tijl Coosemans : configure: Detect resolver functionality on FreeBSD.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: e7ec164563d5657d3cfede16476496c31708bfea URL: http://source.winehq.org/git/wine.git/?a=commit;h=e7ec164563d5657d3cfede164… Author: Tijl Coosemans <tijl(a)coosemans.org> Date: Thu Sep 23 18:20:31 2010 +0200 configure: Detect resolver functionality on FreeBSD. On FreeBSD this is part of libc. --- configure | 17 +++++++++++------ configure.ac | 15 ++++++++++----- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 788a57a..4937577 100755 --- a/configure +++ b/configure @@ -9977,13 +9977,13 @@ esac fi -RESOLVLIBS="" - if test "$ac_cv_header_resolv_h" = "yes" then ac_save_LIBS="$LIBS" - LIBS="$LIBS -lresolv" - cat confdefs.h - <<_ACEOF >conftest.$ac_ext + for lib in '' -lresolv + do + LIBS="$lib $ac_save_LIBS" + cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #ifdef HAVE_NETINET_IN_H #include <netinet/in.h> @@ -9992,7 +9992,7 @@ then int main () { -res_init(); +res_query("foo",ns_c_in,0,0,0); ; return 0; } @@ -10001,10 +10001,15 @@ if ac_fn_c_try_link "$LINENO"; then : $as_echo "#define HAVE_RESOLV 1" >>confdefs.h - RESOLVLIBS="-lresolv" + RESOLVLIBS="$lib" + fi rm -f core conftest.err conftest.$ac_objext \ conftest$ac_exeext conftest.$ac_ext + if test "${RESOLVLIBS+set}" = set; then + break + fi + done LIBS="$ac_save_LIBS" fi diff --git a/configure.ac b/configure.ac index f279293..341ba18 100644 --- a/configure.ac +++ b/configure.ac @@ -1266,17 +1266,22 @@ WINE_NOTICE_WITH(gphoto,[test "$ac_cv_lib_gphoto2_gp_camera_new" != "yes"], dnl **** Check for resolver library *** -AC_SUBST(RESOLVLIBS,"") if test "$ac_cv_header_resolv_h" = "yes" then ac_save_LIBS="$LIBS" - LIBS="$LIBS -lresolv" - AC_LINK_IFELSE([AC_LANG_PROGRAM([[#ifdef HAVE_NETINET_IN_H + for lib in '' -lresolv + do + LIBS="$lib $ac_save_LIBS" + AC_LINK_IFELSE([AC_LANG_PROGRAM([[#ifdef HAVE_NETINET_IN_H #include <netinet/in.h> #endif -#include <resolv.h>]],[[res_init();]])], +#include <resolv.h>]],[[res_query("foo",ns_c_in,0,0,0);]])], [AC_DEFINE(HAVE_RESOLV, 1, [Define if you have the resolver library and header]) - RESOLVLIBS="-lresolv"]) + AC_SUBST(RESOLVLIBS,"$lib")]) + if test "${RESOLVLIBS+set}" = set; then + break + fi + done LIBS="$ac_save_LIBS" fi

1 0

Alexandre Julliard : winedbg: Make BreakOnFirstChance default to FALSE to avoid user confusion.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 07898fe2fdf5bd97c830d9147fcb8f6e74ac8c56 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07898fe2fdf5bd97c830d9147… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 24 11:34:11 2010 +0200 winedbg: Make BreakOnFirstChance default to FALSE to avoid user confusion. --- programs/winedbg/intvar.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/winedbg/intvar.h b/programs/winedbg/intvar.h index 2771f23..4d1a80d 100644 --- a/programs/winedbg/intvar.h +++ b/programs/winedbg/intvar.h @@ -23,7 +23,7 @@ INTERNAL_VAR(BreakAllThreadsStartup, FALSE, NULL, dbg_itype_unsigned_int) INTERNAL_VAR(BreakOnCritSectTimeOut, FALSE, NULL, dbg_itype_unsigned_int) INTERNAL_VAR(BreakOnAttach, FALSE, NULL, dbg_itype_unsigned_int) -INTERNAL_VAR(BreakOnFirstChance, TRUE, NULL, dbg_itype_unsigned_int) +INTERNAL_VAR(BreakOnFirstChance, FALSE, NULL, dbg_itype_unsigned_int) INTERNAL_VAR(BreakOnDllLoad, FALSE, NULL, dbg_itype_unsigned_int) INTERNAL_VAR(CanDeferOnBPByAddr, FALSE, NULL, dbg_itype_unsigned_int)

1 0

Juan Lang : include: Define more IF_TYPEs.
by Alexandre Julliard Sept. 24, 2010

Sept. 24, 2010

Module: wine Branch: master Commit: 4ec277d8f4731903cf4201d85e6501ca6d1f461b URL: http://source.winehq.org/git/wine.git/?a=commit;h=4ec277d8f4731903cf4201d85… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Sep 16 14:24:25 2010 -0700 include: Define more IF_TYPEs. --- include/ipifcons.h | 228 +++++++++++++++++++++++++++++++++++++++++++++------- 1 files changed, 200 insertions(+), 28 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=4ec277d8f4731903cf420…

1 0