October 2011 - Wine-Commits

Alexandre Julliard : gdi32: Implement GetFontUnicodeRanges as a standard driver entry point.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 90ecea9739c1ca8585a97c1a4c1f65f4e141bed6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=90ecea9739c1ca8585a97c1a4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 20 16:26:26 2011 +0200 gdi32: Implement GetFontUnicodeRanges as a standard driver entry point. --- dlls/gdi32/font.c | 6 ++++-- dlls/gdi32/freetype.c | 24 ++++++++++++++---------- dlls/gdi32/gdi_private.h | 1 - 3 files changed, 18 insertions(+), 13 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index f2f4c94..72490c9 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -3397,14 +3397,16 @@ BOOL WINAPI GetCharWidthI(HDC hdc, UINT first, UINT count, LPWORD glyphs, LPINT */ DWORD WINAPI GetFontUnicodeRanges(HDC hdc, LPGLYPHSET lpgs) { - DWORD ret = 0; + DWORD ret; + PHYSDEV dev; DC *dc = get_dc_ptr(hdc); TRACE("(%p, %p)\n", hdc, lpgs); if (!dc) return 0; - if (dc->gdiFont) ret = WineEngGetFontUnicodeRanges(dc->gdiFont, lpgs); + dev = GET_DC_PHYSDEV( dc, pGetFontUnicodeRanges ); + ret = dev->funcs->pGetFontUnicodeRanges( dev, lpgs ); release_dc_ptr(dc); return ret; } diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index 5b3543b..11245d6 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -6675,11 +6675,21 @@ static DWORD get_font_unicode_ranges(FT_Face face, GLYPHSET *gs) return num_ranges; } -DWORD WineEngGetFontUnicodeRanges(GdiFont *font, LPGLYPHSET glyphset) +/************************************************************* + * freetype_GetFontUnicodeRanges + */ +static DWORD freetype_GetFontUnicodeRanges( PHYSDEV dev, LPGLYPHSET glyphset ) { - DWORD size = 0; - DWORD num_ranges = get_font_unicode_ranges(font->ft_face, glyphset); + struct freetype_physdev *physdev = get_freetype_dev( dev ); + DWORD size, num_ranges; + if (!physdev->font) + { + dev = GET_NEXT_PHYSDEV( dev, pGetFontUnicodeRanges ); + return dev->funcs->pGetFontUnicodeRanges( dev, glyphset ); + } + + num_ranges = get_font_unicode_ranges(physdev->font->ft_face, glyphset); size = sizeof(GLYPHSET) + sizeof(WCRANGE) * (num_ranges - 1); if (glyphset) { @@ -7072,7 +7082,7 @@ static const struct gdi_dc_funcs freetype_funcs = NULL, /* pGetDeviceCaps */ NULL, /* pGetDeviceGammaRamp */ NULL, /* pGetFontData */ - NULL, /* pGetFontUnicodeRanges */ + freetype_GetFontUnicodeRanges, /* pGetFontUnicodeRanges */ NULL, /* pGetGlyphIndices */ NULL, /* pGetGlyphOutline */ NULL, /* pGetICMProfile */ @@ -7245,12 +7255,6 @@ BOOL WineEngGetLinkedHFont(DC *dc, WCHAR c, HFONT *new_hfont, UINT *glyph) return FALSE; } -DWORD WineEngGetFontUnicodeRanges(GdiFont *font, LPGLYPHSET glyphset) -{ - FIXME("(%p, %p): stub\n", font, glyphset); - return 0; -} - BOOL WineEngFontIsLinked(GdiFont *font) { return FALSE; diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index 23c1e78..316e6a9 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -293,7 +293,6 @@ extern INT WineEngAddFontResourceEx(LPCWSTR, DWORD, PVOID) DECLSPEC_HIDDEN; extern HANDLE WineEngAddFontMemResourceEx(PVOID, DWORD, PVOID, LPDWORD) DECLSPEC_HIDDEN; extern BOOL WineEngDestroyFontInstance(HFONT handle) DECLSPEC_HIDDEN; extern DWORD WineEngGetFontData(GdiFont*, DWORD, DWORD, LPVOID, DWORD) DECLSPEC_HIDDEN; -extern DWORD WineEngGetFontUnicodeRanges(GdiFont *, LPGLYPHSET) DECLSPEC_HIDDEN; extern DWORD WineEngGetGlyphIndices(GdiFont *font, LPCWSTR lpstr, INT count, LPWORD pgi, DWORD flags) DECLSPEC_HIDDEN; extern DWORD WineEngGetGlyphOutline(GdiFont*, UINT glyph, UINT format,

1 0

Aric Stewart : user32: When building linedefs prev can be less than 0 if the format width is less than the width of a single character .
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 94bd422f8918306203a7b4beaa45cb68ca71dffd URL: http://source.winehq.org/git/wine.git/?a=commit;h=94bd422f8918306203a7b4bea… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Oct 25 08:30:52 2011 -0500 user32: When building linedefs prev can be less than 0 if the format width is less than the width of a single character. --- dlls/user32/edit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c index e0e0bba..f8cf757 100644 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -638,7 +638,7 @@ static void EDIT_BuildLineDefs_ML(EDITSTATE *es, INT istart, INT iend, INT delta current_line->width -= piDx[prev]; prev--; } while ( prev > 0 && current_line->width > fw); - if (prev==0) + if (prev<=0) prev = 1; HeapFree(GetProcessHeap(),0,piDx); }

1 0

Alexandre Julliard : gdi32: Reimplement GetCharABCWidthsFloat using the integer version.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 23c7c0469c34b072c0e6fdf5bbcab547dcc4d912 URL: http://source.winehq.org/git/wine.git/?a=commit;h=23c7c0469c34b072c0e6fdf5b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Oct 19 22:07:32 2011 +0200 gdi32: Reimplement GetCharABCWidthsFloat using the integer version. --- dlls/gdi32/font.c | 24 +++++++++++------------- dlls/gdi32/freetype.c | 38 -------------------------------------- dlls/gdi32/gdi_private.h | 2 -- 3 files changed, 11 insertions(+), 53 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index e8d10f1..f2f4c94 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -3049,6 +3049,8 @@ BOOL WINAPI GetCharABCWidthsFloatA( HDC hdc, UINT first, UINT last, LPABCFLOAT a BOOL WINAPI GetCharABCWidthsFloatW( HDC hdc, UINT first, UINT last, LPABCFLOAT abcf ) { UINT i; + ABC *abc; + PHYSDEV dev; BOOL ret = FALSE; DC *dc = get_dc_ptr( hdc ); @@ -3056,28 +3058,24 @@ BOOL WINAPI GetCharABCWidthsFloatW( HDC hdc, UINT first, UINT last, LPABCFLOAT a if (!dc) return FALSE; - if (!abcf) - { - release_dc_ptr( dc ); - return FALSE; - } - - if (dc->gdiFont) - ret = WineEngGetCharABCWidthsFloat( dc->gdiFont, first, last, abcf ); - else - FIXME("stub\n"); + if (!abcf) goto done; + if (!(abc = HeapAlloc( GetProcessHeap(), 0, (last - first + 1) * sizeof(*abc) ))) goto done; + dev = GET_DC_PHYSDEV( dc, pGetCharABCWidths ); + ret = dev->funcs->pGetCharABCWidths( dev, first, last, abc ); if (ret) { /* convert device units to logical */ for (i = first; i <= last; i++, abcf++) { - abcf->abcfA = abcf->abcfA * dc->xformVport2World.eM11; - abcf->abcfB = abcf->abcfB * dc->xformVport2World.eM11; - abcf->abcfC = abcf->abcfC * dc->xformVport2World.eM11; + abcf->abcfA = abc->abcA * dc->xformVport2World.eM11; + abcf->abcfB = abc->abcB * dc->xformVport2World.eM11; + abcf->abcfC = abc->abcC * dc->xformVport2World.eM11; } } + HeapFree( GetProcessHeap(), 0, abc ); +done: release_dc_ptr( dc ); return ret; } diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index fa3f72b..5b3543b 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -6387,38 +6387,6 @@ static BOOL freetype_GetCharABCWidths( PHYSDEV dev, UINT firstChar, UINT lastCha } /************************************************************* - * WineEngGetCharABCWidthsFloat - * - */ -BOOL WineEngGetCharABCWidthsFloat(GdiFont *font, UINT first, UINT last, LPABCFLOAT buffer) -{ - static const MAT2 identity = {{0,1}, {0,0}, {0,0}, {0,1}}; - UINT c; - GLYPHMETRICS gm; - FT_UInt glyph_index; - GdiFont *linked_font; - - TRACE("%p, %d, %d, %p\n", font, first, last, buffer); - - GDI_CheckNotLock(); - EnterCriticalSection( &freetype_cs ); - - for (c = first; c <= last; c++) - { - get_glyph_index_linked(font, c, &linked_font, &glyph_index); - get_glyph_outline(linked_font, glyph_index, GGO_METRICS | GGO_GLYPH_INDEX, - &gm, 0, NULL, &identity); - buffer[c - first].abcfA = FONT_GM(linked_font, glyph_index)->lsb; - buffer[c - first].abcfB = FONT_GM(linked_font, glyph_index)->bbx; - buffer[c - first].abcfC = FONT_GM(linked_font, glyph_index)->adv - - FONT_GM(linked_font, glyph_index)->lsb - - FONT_GM(linked_font, glyph_index)->bbx; - } - LeaveCriticalSection( &freetype_cs ); - return TRUE; -} - -/************************************************************* * freetype_GetCharABCWidthsI */ static BOOL freetype_GetCharABCWidthsI( PHYSDEV dev, UINT firstChar, UINT count, LPWORD pgi, LPABC buffer ) @@ -7228,12 +7196,6 @@ UINT WineEngGetOutlineTextMetrics(GdiFont *font, UINT cbSize, return 0; } -BOOL WineEngGetCharABCWidthsFloat(GdiFont *font, UINT first, UINT last, LPABCFLOAT buffer) -{ - ERR("called but we don't have FreeType\n"); - return FALSE; -} - BOOL WineEngGetTextExtentExPointI(GdiFont *font, const WORD *indices, INT count, INT max_ext, LPINT nfit, LPINT dx, LPSIZE size) { diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index fff72b1..23c1e78 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -292,8 +292,6 @@ typedef struct extern INT WineEngAddFontResourceEx(LPCWSTR, DWORD, PVOID) DECLSPEC_HIDDEN; extern HANDLE WineEngAddFontMemResourceEx(PVOID, DWORD, PVOID, LPDWORD) DECLSPEC_HIDDEN; extern BOOL WineEngDestroyFontInstance(HFONT handle) DECLSPEC_HIDDEN; -extern BOOL WineEngGetCharABCWidthsFloat(GdiFont *font, UINT firstChar, - UINT lastChar, LPABCFLOAT buffer) DECLSPEC_HIDDEN; extern DWORD WineEngGetFontData(GdiFont*, DWORD, DWORD, LPVOID, DWORD) DECLSPEC_HIDDEN; extern DWORD WineEngGetFontUnicodeRanges(GdiFont *, LPGLYPHSET) DECLSPEC_HIDDEN; extern DWORD WineEngGetGlyphIndices(GdiFont *font, LPCWSTR lpstr, INT count,

1 0

Lucas Fialho Zawacki : dinput8/tests: Tests for DIPROP_USERNAME property.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 46e408d54c26d4e4b4cfcd536f9bc59fe78ef481 URL: http://source.winehq.org/git/wine.git/?a=commit;h=46e408d54c26d4e4b4cfcd536… Author: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> Date: Sat Oct 22 18:53:21 2011 -0200 dinput8/tests: Tests for DIPROP_USERNAME property. --- dlls/dinput8/tests/Makefile.in | 2 +- dlls/dinput8/tests/device.c | 33 +++++++++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/dlls/dinput8/tests/Makefile.in b/dlls/dinput8/tests/Makefile.in index 7584858..fe87118 100644 --- a/dlls/dinput8/tests/Makefile.in +++ b/dlls/dinput8/tests/Makefile.in @@ -1,5 +1,5 @@ TESTDLL = dinput8.dll -IMPORTS = dinput8 ole32 user32 +IMPORTS = dinput8 ole32 user32 advapi32 C_SRCS = \ device.c \ diff --git a/dlls/dinput8/tests/device.c b/dlls/dinput8/tests/device.c index 8a9b1df..7fbdfaa 100644 --- a/dlls/dinput8/tests/device.c +++ b/dlls/dinput8/tests/device.c @@ -31,6 +31,7 @@ struct enum_data { LPDIACTIONFORMAT lpdiaf; LPDIRECTINPUTDEVICE8 keyboard; LPDIRECTINPUTDEVICE8 mouse; + const char* username; int ndevices; }; @@ -156,6 +157,9 @@ static BOOL CALLBACK enumeration_callback( HRESULT hr; DIPROPDWORD dp; DIPROPRANGE dpr; + DIPROPSTRING dps; + WCHAR usernameW[MAX_PATH]; + DWORD username_size = MAX_PATH; struct enum_data *data = pvRef; DWORD cnt; DIDEVICEOBJECTDATA buffer[5]; @@ -164,6 +168,15 @@ static BOOL CALLBACK enumeration_callback( data->ndevices++; + /* Convert username to WCHAR */ + if (data->username != NULL) + { + username_size = MultiByteToWideChar(CP_ACP, 0, data->username, -1, usernameW, 0); + MultiByteToWideChar(CP_ACP, 0, data->username, -1, usernameW, username_size); + } + else + GetUserNameW(usernameW, &username_size); + /* collect the mouse and keyboard */ if (IsEqualGUID(&lpddi->guidInstance, &GUID_SysKeyboard)) { @@ -190,12 +203,23 @@ static BOOL CALLBACK enumeration_callback( hr = IDirectInputDevice8_Acquire(lpdid); ok (hr == DIERR_INVALIDPARAM, "Device was acquired before SetActionMap hr=%08x\n", hr); - hr = IDirectInputDevice8_SetActionMap(lpdid, data->lpdiaf, NULL, 0); + hr = IDirectInputDevice8_SetActionMap(lpdid, data->lpdiaf, data->username, 0); ok (SUCCEEDED(hr), "SetActionMap failed hr=%08x\n", hr); /* Some joysticks may have no suitable actions and thus should not be tested */ if (hr == DI_NOEFFECT) return DIENUM_CONTINUE; + /* Test username after SetActionMap */ + dps.diph.dwSize = sizeof(dps); + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); + dps.diph.dwObj = 0; + dps.diph.dwHow = DIPH_DEVICE; + dps.wsz[0] = '\0'; + + hr = IDirectInputDevice_GetProperty(lpdid, DIPROP_USERNAME, &dps.diph); + todo_wine ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); + todo_wine ok (!lstrcmpW(usernameW, dps.wsz), "Username not set correctly expected=%s, got=%s\n", wine_dbgstr_wn(usernameW, -1), wine_dbgstr_wn(dps.wsz, -1)); + /* Test buffer size */ memset(&dp, 0, sizeof(dp)); dp.diph.dwSize = sizeof(dp); @@ -245,7 +269,7 @@ static void test_action_mapping(void) HINSTANCE hinst = GetModuleHandle(NULL); LPDIRECTINPUT8 pDI = NULL; DIACTIONFORMAT af; - struct enum_data data = {pDI, &af, NULL, NULL, 0}; + struct enum_data data = {pDI, &af, NULL, NULL, NULL, 0}; hr = CoCreateInstance(&CLSID_DirectInput8, 0, 1, &IID_IDirectInput8A, (LPVOID*)&pDI); if (hr == DIERR_OLDDIRECTINPUTVERSION || @@ -281,6 +305,11 @@ static void test_action_mapping(void) hr = IDirectInput8_EnumDevicesBySemantics(pDI, 0, &af, enumeration_callback, &data, DIEDBSFL_ATTACHEDONLY); ok (SUCCEEDED(hr), "EnumDevicesBySemantics failed: hr=%08x\n", hr); + /* Repeat tests with a non NULL user */ + data.username = "Ninja Brian"; + hr = IDirectInput8_EnumDevicesBySemantics(pDI, NULL, &af, enumeration_callback, &data, DIEDBSFL_ATTACHEDONLY); + ok (SUCCEEDED(hr), "EnumDevicesBySemantics failed: hr=%08x\n", hr); + if (data.keyboard != NULL) { /* Test keyboard BuildActionMap */

1 0

Lucas Fialho Zawacki : dinput8/tests: Moved EnumDevicesBySemantics specific tests to dinput. c and added a couple more.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 32f79acc4951ac52d03772af76f780ab5144f071 URL: http://source.winehq.org/git/wine.git/?a=commit;h=32f79acc4951ac52d03772af7… Author: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> Date: Sat Oct 22 18:53:20 2011 -0200 dinput8/tests: Moved EnumDevicesBySemantics specific tests to dinput.c and added a couple more. --- dlls/dinput8/tests/device.c | 61 ----------------- dlls/dinput8/tests/dinput.c | 155 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 155 insertions(+), 61 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=32f79acc4951ac52d0377…

1 0

Vitaliy Margolen : dinput: Restore checks for DirectX 3 buffer size.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 67e0b356c08e122114ade9786352f097c0fd4521 URL: http://source.winehq.org/git/wine.git/?a=commit;h=67e0b356c08e122114ade9786… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Thu Oct 20 07:42:49 2011 -0600 dinput: Restore checks for DirectX 3 buffer size. --- dlls/dinput/device.c | 4 +- dlls/dinput/tests/device.c | 69 ++++++++++++++++++++++++++----------------- 2 files changed, 44 insertions(+), 29 deletions(-) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index b72b0d5..72670f7 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -1288,10 +1288,10 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetDeviceData(LPDIRECTINPUTDEVICE8W ifac TRACE("(%p) %p -> %p(%d) x%d, 0x%08x\n", This, dod, entries, entries ? *entries : 0, dodsize, flags); - if (This->dinput->dwVersion == 0x0800) + if (This->dinput->dwVersion == 0x0800 || dodsize == sizeof(DIDEVICEOBJECTDATA_DX3)) { - if (!This->acquired) return DIERR_NOTACQUIRED; if (!This->queue_len) return DIERR_NOTBUFFERED; + if (!This->acquired) return DIERR_NOTACQUIRED; } if (!This->queue_len) diff --git a/dlls/dinput/tests/device.c b/dlls/dinput/tests/device.c index 7171bb8..f03a3b6 100644 --- a/dlls/dinput/tests/device.c +++ b/dlls/dinput/tests/device.c @@ -78,7 +78,9 @@ static void test_object_info(LPDIRECTINPUTDEVICE device, HWND hwnd) DIDEVICEOBJECTINSTANCE obj_info; DWORD obj_types[] = {DIDFT_BUTTON, DIDFT_AXIS, DIDFT_POV}; int type_index; - int cnt = 0, cnt1 = 0; + int cnt1 = 0; + DWORD cnt = 0; + DIDEVICEOBJECTDATA buffer[5]; hr = IDirectInputDevice_EnumObjects(device, enum_callback, &cnt, DIDFT_ALL); ok(SUCCEEDED(hr), "EnumObjects() failed: %08x\n", hr); @@ -98,18 +100,51 @@ static void test_object_info(LPDIRECTINPUTDEVICE device, HWND hwnd) ok(SUCCEEDED(hr), "EnumObjects() failed: %08x\n", hr); } + /* Test buffered mode */ + memset(&dp, 0, sizeof(dp)); + dp.diph.dwSize = sizeof(DIPROPDWORD); + dp.diph.dwHeaderSize = sizeof(DIPROPHEADER); + dp.diph.dwHow = DIPH_DEVICE; + dp.diph.dwObj = 0; + dp.dwData = 0; + + hr = IDirectInputDevice_SetProperty(device, DIPROP_BUFFERSIZE, (LPCDIPROPHEADER)&dp.diph); + ok(hr == DI_OK, "SetProperty() failed: %08x\n", hr); + cnt = 5; + hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DI_OK && cnt == 5, "GetDeviceData() failed: %08x cnt: %d\n", hr, cnt); + hr = IDirectInputDevice_GetDeviceData(device, sizeof(DIDEVICEOBJECTDATA_DX3), buffer, &cnt, 0); + ok(hr == DIERR_NOTBUFFERED, "GetDeviceData() should have failed: %08x\n", hr); + IDirectInputDevice_Acquire(device); + hr = IDirectInputDevice_GetDeviceData(device, sizeof(DIDEVICEOBJECTDATA_DX3), buffer, &cnt, 0); + ok(hr == DIERR_NOTBUFFERED, "GetDeviceData() should have failed: %08x\n", hr); + IDirectInputDevice_Unacquire(device); + + dp.dwData = 20; + hr = IDirectInputDevice_SetProperty(device, DIPROP_BUFFERSIZE, (LPCDIPROPHEADER)&dp.diph); + ok(hr == DI_OK, "SetProperty() failed: %08x\n", hr); + cnt = 5; + hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DI_OK, "GetDeviceData() failed: %08x\n", hr); + hr = IDirectInputDevice_GetDeviceData(device, sizeof(DIDEVICEOBJECTDATA_DX3), buffer, &cnt, 0); + ok(hr == DIERR_NOTACQUIRED, "GetDeviceData() should have failed: %08x\n", hr); + hr = IDirectInputDevice_Acquire(device); + ok(hr == DI_OK, "Acquire() failed: %08x\n", hr); + cnt = 1; + hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DI_OK, "GetDeviceData() failed: %08x\n", hr); + hr = IDirectInputDevice_Unacquire(device); + ok(hr == DI_OK, "Unacquire() failed: %08x\n", hr); + cnt = 1; + hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DI_OK, "GetDeviceData() failed: %08x\n", hr); + /* No need to test devices without axis */ obj_info.dwSize = sizeof(obj_info); hr = IDirectInputDevice_GetObjectInfo(device, &obj_info, 16, DIPH_BYOFFSET); if (SUCCEEDED(hr)) { - DWORD cnt; - DIDEVICEOBJECTDATA buffer[5]; - /* No device supports per axis relative/absolute mode */ - memset(&dp, 0, sizeof(dp)); - dp.diph.dwSize = sizeof(DIPROPDWORD); - dp.diph.dwHeaderSize = sizeof(DIPROPHEADER); dp.diph.dwHow = DIPH_BYOFFSET; dp.diph.dwObj = 16; dp.dwData = DIPROPAXISMODE_ABS; @@ -122,29 +157,9 @@ static void test_object_info(LPDIRECTINPUTDEVICE device, HWND hwnd) hr = IDirectInputDevice_SetProperty(device, DIPROP_AXISMODE, &dp.diph); ok(hr == DI_OK, "SetProperty() failed: %08x\n", hr); - dp.dwData = 0; - hr = IDirectInputDevice_SetProperty(device, DIPROP_BUFFERSIZE, (LPCDIPROPHEADER)&dp.diph); - ok(hr == DI_OK, "SetProperty() failed: %08x\n", hr); - - cnt = 5; - hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); - ok(hr == DI_OK && cnt == 5, "GetDeviceData() failed: %08x cnt: %d\n", hr, cnt); - - dp.dwData = 20; - hr = IDirectInputDevice_SetProperty(device, DIPROP_BUFFERSIZE, (LPCDIPROPHEADER)&dp.diph); - ok(hr == DI_OK, "SetProperty() failed: %08x\n", hr); - - cnt = 1; - hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); - ok(hr == DI_OK, "GetDeviceData() failed: %08x\n", hr); - /* Cannot change mode while acquired */ hr = IDirectInputDevice_Acquire(device); ok(hr == DI_OK, "Acquire() failed: %08x\n", hr); - cnt = 1; - hr = IDirectInputDevice_GetDeviceData(device, sizeof(buffer[0]), buffer, &cnt, 0); - ok(hr == DI_OK, "GetDeviceData() failed: %08x\n", hr); - hr = IDirectInputDevice_SetProperty(device, DIPROP_AXISMODE, &dp.diph); ok(hr == DIERR_ACQUIRED, "SetProperty() returned: %08x\n", hr);

1 0

Alexandre Julliard : gdi32: Implement GetGlyphOutline as a standard driver entry point.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 6376b4cf6f7da4ba7f525ac4bbf967f086d81c99 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6376b4cf6f7da4ba7f525ac4b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 20 16:34:08 2011 +0200 gdi32: Implement GetGlyphOutline as a standard driver entry point. --- dlls/gdi32/font.c | 9 +++------ dlls/gdi32/freetype.c | 27 ++++++++++++--------------- dlls/gdi32/gdi_private.h | 3 --- 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 8fa9173..26eba55 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -2503,6 +2503,7 @@ DWORD WINAPI GetGlyphOutlineW( HDC hdc, UINT uChar, UINT fuFormat, { DC *dc; DWORD ret; + PHYSDEV dev; TRACE("(%p, %04x, %04x, %p, %d, %p, %p)\n", hdc, uChar, fuFormat, lpgm, cbBuffer, lpBuffer, lpmat2 ); @@ -2512,12 +2513,8 @@ DWORD WINAPI GetGlyphOutlineW( HDC hdc, UINT uChar, UINT fuFormat, dc = get_dc_ptr(hdc); if(!dc) return GDI_ERROR; - if(dc->gdiFont) - ret = WineEngGetGlyphOutline(dc->gdiFont, uChar, fuFormat, lpgm, - cbBuffer, lpBuffer, lpmat2); - else - ret = GDI_ERROR; - + dev = GET_DC_PHYSDEV( dc, pGetGlyphOutline ); + ret = dev->funcs->pGetGlyphOutline( dev, uChar, fuFormat, lpgm, cbBuffer, lpBuffer, lpmat2 ); release_dc_ptr( dc ); return ret; } diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index da9de0d..a98cf36 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -6196,18 +6196,23 @@ end: } /************************************************************* - * WineEngGetGlyphOutline - * + * freetype_GetGlyphOutline */ -DWORD WineEngGetGlyphOutline(GdiFont *font, UINT glyph, UINT format, - LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, - const MAT2* lpmat) +static DWORD freetype_GetGlyphOutline( PHYSDEV dev, UINT glyph, UINT format, + LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, const MAT2 *lpmat ) { + struct freetype_physdev *physdev = get_freetype_dev( dev ); DWORD ret; + if (!physdev->font) + { + dev = GET_NEXT_PHYSDEV( dev, pGetGlyphOutline ); + return dev->funcs->pGetGlyphOutline( dev, glyph, format, lpgm, buflen, buf, lpmat ); + } + GDI_CheckNotLock(); EnterCriticalSection( &freetype_cs ); - ret = get_glyph_outline( font, glyph, format, lpgm, buflen, buf, lpmat ); + ret = get_glyph_outline( physdev->font, glyph, format, lpgm, buflen, buf, lpmat ); LeaveCriticalSection( &freetype_cs ); return ret; } @@ -7089,7 +7094,7 @@ static const struct gdi_dc_funcs freetype_funcs = NULL, /* pGetFontData */ freetype_GetFontUnicodeRanges, /* pGetFontUnicodeRanges */ freetype_GetGlyphIndices, /* pGetGlyphIndices */ - NULL, /* pGetGlyphOutline */ + freetype_GetGlyphOutline, /* pGetGlyphOutline */ NULL, /* pGetICMProfile */ NULL, /* pGetImage */ NULL, /* pGetKerningPairs */ @@ -7190,14 +7195,6 @@ BOOL WineEngDestroyFontInstance(HFONT hfont) return FALSE; } -DWORD WineEngGetGlyphOutline(GdiFont *font, UINT glyph, UINT format, - LPGLYPHMETRICS lpgm, DWORD buflen, LPVOID buf, - const MAT2* lpmat) -{ - ERR("called but we don't have FreeType\n"); - return GDI_ERROR; -} - UINT WineEngGetOutlineTextMetrics(GdiFont *font, UINT cbSize, OUTLINETEXTMETRICW *potm) { diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index c09ecf1..d0727a2 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -293,9 +293,6 @@ extern INT WineEngAddFontResourceEx(LPCWSTR, DWORD, PVOID) DECLSPEC_HIDDEN; extern HANDLE WineEngAddFontMemResourceEx(PVOID, DWORD, PVOID, LPDWORD) DECLSPEC_HIDDEN; extern BOOL WineEngDestroyFontInstance(HFONT handle) DECLSPEC_HIDDEN; extern DWORD WineEngGetFontData(GdiFont*, DWORD, DWORD, LPVOID, DWORD) DECLSPEC_HIDDEN; -extern DWORD WineEngGetGlyphOutline(GdiFont*, UINT glyph, UINT format, - LPGLYPHMETRICS, DWORD buflen, LPVOID buf, - const MAT2*) DECLSPEC_HIDDEN; extern DWORD WineEngGetKerningPairs(GdiFont*, DWORD, KERNINGPAIR *) DECLSPEC_HIDDEN; extern BOOL WineEngGetLinkedHFont(DC *dc, WCHAR c, HFONT *new_hfont, UINT *glyph) DECLSPEC_HIDDEN; extern UINT WineEngGetOutlineTextMetrics(GdiFont*, UINT, LPOUTLINETEXTMETRICW) DECLSPEC_HIDDEN;

1 0

André Hentschel : cmdlgtst: Add OFN_EXPLORER to allow testing modern file dialogs with multiselection.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: 65092bbe94596c4e5984d712252611dd2a385e8b URL: http://source.winehq.org/git/wine.git/?a=commit;h=65092bbe94596c4e5984d7122… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Oct 24 21:56:39 2011 +0200 cmdlgtst: Add OFN_EXPLORER to allow testing modern file dialogs with multiselection. --- programs/cmdlgtst/Cs.rc | 27 +++++++++++---------- programs/cmdlgtst/Da.rc | 27 +++++++++++---------- programs/cmdlgtst/De.rc | 27 +++++++++++---------- programs/cmdlgtst/En.rc | 27 +++++++++++---------- programs/cmdlgtst/Es.rc | 27 +++++++++++---------- programs/cmdlgtst/Fr.rc | 27 +++++++++++---------- programs/cmdlgtst/He.rc | 27 +++++++++++---------- programs/cmdlgtst/It.rc | 27 +++++++++++---------- programs/cmdlgtst/Ja.rc | 27 +++++++++++---------- programs/cmdlgtst/Ko.rc | 27 +++++++++++---------- programs/cmdlgtst/Lt.rc | 27 +++++++++++---------- programs/cmdlgtst/Nl.rc | 27 +++++++++++---------- programs/cmdlgtst/No.rc | 27 +++++++++++---------- programs/cmdlgtst/Pl.rc | 27 +++++++++++---------- programs/cmdlgtst/Pt.rc | 54 +++++++++++++++++++++-------------------- programs/cmdlgtst/Ro.rc | 27 +++++++++++---------- programs/cmdlgtst/Ru.rc | 27 +++++++++++---------- programs/cmdlgtst/Si.rc | 27 +++++++++++---------- programs/cmdlgtst/Sv.rc | 27 +++++++++++---------- programs/cmdlgtst/Tr.rc | 27 +++++++++++---------- programs/cmdlgtst/Uk.rc | 27 +++++++++++---------- programs/cmdlgtst/cmdlgtst.c | 1 + programs/cmdlgtst/cmdlgtst.h | 5 ++- 23 files changed, 312 insertions(+), 288 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=65092bbe94596c4e5984d…

1 0

Rico Schüller : d3dx9: Improve argument check in D3DXFindShaderComment().
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: be68d56efc0e7dc1a6aab644ad3fabfa5650fc6e URL: http://source.winehq.org/git/wine.git/?a=commit;h=be68d56efc0e7dc1a6aab644a… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Oct 25 10:39:25 2011 +0200 d3dx9: Improve argument check in D3DXFindShaderComment(). --- dlls/d3dx9_36/shader.c | 3 +++ dlls/d3dx9_36/tests/shader.c | 12 ++++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index bc5e002..b538edd 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -153,6 +153,9 @@ HRESULT WINAPI D3DXFindShaderComment(CONST DWORD* byte_code, DWORD fourcc, LPCVO TRACE("(%p, %x, %p, %p)\n", byte_code, fourcc, data, size); + if (data) *data = NULL; + if (size) *size = 0; + if (!byte_code) return D3DERR_INVALIDCALL; diff --git a/dlls/d3dx9_36/tests/shader.c b/dlls/d3dx9_36/tests/shader.c index 9220e28..8d82a68 100644 --- a/dlls/d3dx9_36/tests/shader.c +++ b/dlls/d3dx9_36/tests/shader.c @@ -215,23 +215,31 @@ static void test_get_shader_version(void) static void test_find_shader_comment(void) { HRESULT hr; - LPCVOID data; - UINT size; + LPCVOID data = (LPVOID)0xdeadbeef; + UINT size = 100; hr = D3DXFindShaderComment(NULL, MAKEFOURCC('C','T','A','B'), &data, &size); ok(hr == D3DERR_INVALIDCALL, "Got result %x, expected %x (D3DERR_INVALIDCALL)\n", hr, D3DERR_INVALIDCALL); + ok(!data, "Got %p, expected NULL\n", data); + ok(!size, "Got %u, expected 0\n", size); hr = D3DXFindShaderComment(shader_with_ctab, MAKEFOURCC('C','T','A','B'), NULL, &size); ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr); + ok(size == 28, "Got %u, expected 28\n", size); hr = D3DXFindShaderComment(shader_with_ctab, MAKEFOURCC('C','T','A','B'), &data, NULL); ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr); + ok(data == (LPCVOID)(shader_with_ctab + 6), "Got result %p, expected %p\n", data, shader_with_ctab + 6); hr = D3DXFindShaderComment(shader_with_ctab, 0, &data, &size); ok(hr == S_FALSE, "Got result %x, expected 1 (S_FALSE)\n", hr); + ok(!data, "Got %p, expected NULL\n", data); + ok(!size, "Got %u, expected 0\n", size); hr = D3DXFindShaderComment(shader_with_ctab, MAKEFOURCC('X','X','X','X'), &data, &size); ok(hr == S_FALSE, "Got result %x, expected 1 (S_FALSE)\n", hr); + ok(!data, "Got %p, expected NULL\n", data); + ok(!size, "Got %u, expected 0\n", size); hr = D3DXFindShaderComment(shader_with_ctab, MAKEFOURCC('C','T','A','B'), &data, &size); ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK)\n", hr);

1 0

Michael Stefaniuc : include: Remove 'l' modifier from numeric constants in dinput.h.
by Alexandre Julliard Oct. 25, 2011

Oct. 25, 2011

Module: wine Branch: master Commit: f334333cb56a23143f447f7b893f8de928d7091d URL: http://source.winehq.org/git/wine.git/?a=commit;h=f334333cb56a23143f447f7b8… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Oct 24 23:25:12 2011 +0200 include: Remove 'l' modifier from numeric constants in dinput.h. --- include/dinput.h | 36 ++++++++++++++++++------------------ 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/include/dinput.h b/include/dinput.h index dc82622..bd9d898 100644 --- a/include/dinput.h +++ b/include/dinput.h @@ -130,11 +130,11 @@ DECL_WINELIB_TYPE_AW(LPDIRECTINPUTDEVICE8) #define DI_BUFFEROVERFLOW S_FALSE #define DI_PROPNOEFFECT S_FALSE #define DI_NOEFFECT S_FALSE -#define DI_POLLEDDEVICE ((HRESULT)0x00000002L) -#define DI_DOWNLOADSKIPPED ((HRESULT)0x00000003L) -#define DI_EFFECTRESTARTED ((HRESULT)0x00000004L) -#define DI_TRUNCATED ((HRESULT)0x00000008L) -#define DI_TRUNCATEDANDRESTARTED ((HRESULT)0x0000000CL) +#define DI_POLLEDDEVICE ((HRESULT)0x00000002) +#define DI_DOWNLOADSKIPPED ((HRESULT)0x00000003) +#define DI_EFFECTRESTARTED ((HRESULT)0x00000004) +#define DI_TRUNCATED ((HRESULT)0x00000008) +#define DI_TRUNCATEDANDRESTARTED ((HRESULT)0x0000000C) #define DIERR_OLDDIRECTINPUTVERSION \ MAKE_HRESULT(SEVERITY_ERROR, FACILITY_WIN32, ERROR_OLD_WIN_VERSION) @@ -167,20 +167,20 @@ DECL_WINELIB_TYPE_AW(LPDIRECTINPUTDEVICE8) #define DIERR_READONLY E_ACCESSDENIED #define DIERR_HANDLEEXISTS E_ACCESSDENIED #ifndef E_PENDING -#define E_PENDING 0x8000000AL +#define E_PENDING 0x8000000A #endif -#define DIERR_INSUFFICIENTPRIVS 0x80040200L -#define DIERR_DEVICEFULL 0x80040201L -#define DIERR_MOREDATA 0x80040202L -#define DIERR_NOTDOWNLOADED 0x80040203L -#define DIERR_HASEFFECTS 0x80040204L -#define DIERR_NOTEXCLUSIVEACQUIRED 0x80040205L -#define DIERR_INCOMPLETEEFFECT 0x80040206L -#define DIERR_NOTBUFFERED 0x80040207L -#define DIERR_EFFECTPLAYING 0x80040208L -#define DIERR_UNPLUGGED 0x80040209L -#define DIERR_REPORTFULL 0x8004020AL -#define DIERR_MAPFILEFAIL 0x8004020BL +#define DIERR_INSUFFICIENTPRIVS 0x80040200 +#define DIERR_DEVICEFULL 0x80040201 +#define DIERR_MOREDATA 0x80040202 +#define DIERR_NOTDOWNLOADED 0x80040203 +#define DIERR_HASEFFECTS 0x80040204 +#define DIERR_NOTEXCLUSIVEACQUIRED 0x80040205 +#define DIERR_INCOMPLETEEFFECT 0x80040206 +#define DIERR_NOTBUFFERED 0x80040207 +#define DIERR_EFFECTPLAYING 0x80040208 +#define DIERR_UNPLUGGED 0x80040209 +#define DIERR_REPORTFULL 0x8004020A +#define DIERR_MAPFILEFAIL 0x8004020B #define DIENUM_STOP 0 #define DIENUM_CONTINUE 1

1 0