October 2011 - Wine-Commits

Nikolay Sivov : comctl32/tests: Make state data accessible to caller ( Valgrind).
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: 482d80cf1632d2cbfb175fa83bc0dc733ac360ec URL: http://source.winehq.org/git/wine.git/?a=commit;h=482d80cf1632d2cbfb175fa83… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Oct 16 10:22:32 2011 -0500 comctl32/tests: Make state data accessible to caller (Valgrind). --- dlls/comctl32/tests/monthcal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/tests/monthcal.c b/dlls/comctl32/tests/monthcal.c index fd6b910..0585bb4 100644 --- a/dlls/comctl32/tests/monthcal.c +++ b/dlls/comctl32/tests/monthcal.c @@ -474,7 +474,7 @@ static LRESULT WINAPI parent_wnd_proc(HWND hwnd, UINT message, WPARAM wParam, LP case MCN_GETDAYSTATE: { NMDAYSTATE *nmstate = (NMDAYSTATE*)lParam; - MONTHDAYSTATE months[14] = { 0 }; + static MONTHDAYSTATE months[14] = { 0 }; ok(nmstate->cDayState > 0, "got %d\n", nmstate->cDayState); ok(nmstate->cDayState <= 14, "got %d\n", nmstate->cDayState);

1 0

Piotr Caban : msvcp90: Use debugstr_a to avoid overflow in traces.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: f73522698881696905e5b03c11535c11508ab220 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f73522698881696905e5b03c1… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:14:06 2011 +0200 msvcp90: Use debugstr_a to avoid overflow in traces. --- dlls/msvcp90/string.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/msvcp90/string.c b/dlls/msvcp90/string.c index c480af1..2dd9f52 100644 --- a/dlls/msvcp90/string.c +++ b/dlls/msvcp90/string.c @@ -943,7 +943,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_ctor_cstr_len, 12) basic_string_char* __thiscall MSVCP_basic_string_char_ctor_cstr_len( basic_string_char *this, const char *str, MSVCP_size_t len) { - TRACE("%p %s %ld\n", this, str, len); + TRACE("%p %s %ld\n", this, debugstr_a(str), len); basic_string_char_tidy(this, FALSE, 0); MSVCP_basic_string_char_assign_cstr_len(this, str, len); @@ -1152,7 +1152,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_append_cstr_len, 12) basic_string_char* __thiscall MSVCP_basic_string_char_append_cstr_len( basic_string_char *this, const char *append, MSVCP_size_t count) { - TRACE("%p %s %lu\n", this, append, count); + TRACE("%p %s %lu\n", this, debugstr_a(append), count); if(basic_string_char_inside(this, append)) return MSVCP_basic_string_char_append_substr(this, this, @@ -1235,7 +1235,7 @@ basic_string_char* __thiscall MSVCP_basic_string_char_append_ch( basic_string_char* __cdecl MSVCP_basic_string_char_concatenate_bstr_cstr(basic_string_char *ret, const basic_string_char *left, const char *right) { - TRACE("%p %s\n", left, right); + TRACE("%p %s\n", left, debugstr_a(right)); MSVCP_basic_string_char_copy_ctor(ret, left); MSVCP_basic_string_char_append_cstr(ret, right); @@ -1247,7 +1247,7 @@ basic_string_char* __cdecl MSVCP_basic_string_char_concatenate_bstr_cstr(basic_s basic_string_char* __cdecl MSVCP_basic_string_char_concatenate_cstr_bstr(basic_string_char *ret, const char *left, const basic_string_char *right) { - TRACE("%s %p\n", left, right); + TRACE("%s %p\n", debugstr_a(left), right); MSVCP_basic_string_char_ctor_cstr(ret, left); MSVCP_basic_string_char_append(ret, right); @@ -1299,7 +1299,7 @@ int __thiscall MSVCP_basic_string_char_compare_substr_cstr_len( { int ans; - TRACE("%p %lu %lu %s %lu\n", this, pos, num, str, count); + TRACE("%p %lu %lu %s %lu\n", this, pos, num, debugstr_a(str), count); if(this->size < pos) MSVCP__String_base_Xran(); @@ -1531,7 +1531,7 @@ MSVCP_size_t __thiscall MSVCP_basic_string_char_find_cstr_substr( { const char *p, *end; - TRACE("%p %s %lu %lu\n", this, find, pos, len); + TRACE("%p %s %lu %lu\n", this, debugstr_a(find), pos, len); if(len==0 && pos<=this->size) return pos; @@ -1586,7 +1586,7 @@ MSVCP_size_t __thiscall MSVCP_basic_string_char_rfind_cstr_substr( { const char *p, *end; - TRACE("%p %s %lu %lu\n", this, find, pos, len); + TRACE("%p %s %lu %lu\n", this, debugstr_a(find), pos, len); if(len==0) return pos<this->size ? pos : this->size;

1 0

Piotr Caban : msvcp90: Added basic_string::get_allocator implementation.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: b0211b5b18b55e256394cea01c4253d907f3328a URL: http://source.winehq.org/git/wine.git/?a=commit;h=b0211b5b18b55e256394cea01… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:13:42 2011 +0200 msvcp90: Added basic_string::get_allocator implementation. --- dlls/msvcp90/msvcp90.spec | 8 ++++---- dlls/msvcp90/string.c | 24 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/dlls/msvcp90/msvcp90.spec b/dlls/msvcp90/msvcp90.spec index 4a41fed..33d5619 100644 --- a/dlls/msvcp90/msvcp90.spec +++ b/dlls/msvcp90/msvcp90.spec @@ -4099,12 +4099,12 @@ @ stub -arch=win64 ?get@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@2(a)V32@0AEAVios_base(a)2@AEAHAEA_K(a)Z @ stub -arch=win32 ?get@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@QBE?AV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@2(a)V32@0AAVios_base(a)2@AAHAA_N(a)Z @ stub -arch=win64 ?get@?$num_get(a)_WV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)_WU?$char_traits(a)_W@std@@@2(a)V32@0AEAVios_base(a)2@AEAHAEA_N(a)Z -@ stub -arch=win32 ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBE?AV?$allocator(a)D@2(a)XZ -@ stub -arch=win64 ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBA?AV?$allocator(a)D@2(a)XZ +@ thiscall -arch=win32 ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBE?AV?$allocator(a)D@2(a)XZ(ptr) basic_string_char_get_allocator +@ cdecl -arch=win64 ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBA?AV?$allocator(a)D@2(a)XZ(ptr) basic_string_char_get_allocator @ stub -arch=win32 ?get_allocator@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QBE?AV?$allocator(a)G@2(a)XZ @ stub -arch=win64 ?get_allocator@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QEBA?AV?$allocator(a)G@2(a)XZ -@ stub -arch=win32 ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBE?AV?$allocator(a)_W@2(a)XZ -@ stub -arch=win64 ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBA?AV?$allocator(a)_W@2(a)XZ +@ thiscall -arch=win32 ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBE?AV?$allocator(a)_W@2(a)XZ(ptr) basic_string_wchar_get_allocator +@ cdecl -arch=win64 ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBA?AV?$allocator(a)_W@2(a)XZ(ptr) basic_string_wchar_get_allocator @ stub -arch=win32 ?get_date@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QBE?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AAVios_base(a)2@AAHPAUtm@@@Z @ stub -arch=win64 ?get_date@?$time_get(a)DV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@std@@@std@@QEBA?AV?$istreambuf_iterator(a)DU?$char_traits(a)D@std@@@2(a)V32@0AEAVios_base(a)2@AEAHPEAUtm@@@Z @ stub -arch=win32 ?get_date@?$time_get(a)GV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@std@@@std@@QBE?AV?$istreambuf_iterator(a)GU?$char_traits(a)G@std@@@2(a)V32@0AAVios_base(a)2@AAHPAUtm@@@Z diff --git a/dlls/msvcp90/string.c b/dlls/msvcp90/string.c index e2595a7..c2aa0da 100644 --- a/dlls/msvcp90/string.c +++ b/dlls/msvcp90/string.c @@ -47,6 +47,10 @@ typedef struct { MSVCP_size_t val; } size_t_noverify; +/* allocator class */ +typedef struct { +} allocator; + /* char_traits<char> */ /* ?assign@?$char_traits(a)D@std@@SAXAADABD(a)Z */ /* ?assign@?$char_traits(a)D@std@@SAXAEADAEBD(a)Z */ @@ -643,6 +647,16 @@ MSVCP_size_t __cdecl MSVCP_basic_string_char_Pdif(String_iterator_char i1, Strin return !i1.pos ? 0 : i1.pos-i2.pos; } +/* ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBE?AV?$allocator(a)D@2(a)XZ */ +/* ?get_allocator@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEBA?AV?$allocator(a)D@2(a)XZ */ +DEFINE_THISCALL_WRAPPER_RETPTR(basic_string_char_get_allocator, 4) +allocator __thiscall basic_string_char_get_allocator(const basic_string_char *this) +{ + allocator ret; + TRACE("%p\n", this); + return ret; +} + /* ?erase@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAEAAV12(a)II@Z */ /* ?erase@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QEAAAEAV12(a)_K0@Z */ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, 12) @@ -2297,6 +2311,16 @@ MSVCP_size_t __cdecl MSVCP_basic_string_wchar_Pdif(String_iterator_wchar i1, Str return !i1.pos ? 0 : i1.pos-i2.pos; } +/* ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QBE?AV?$allocator(a)_W@2(a)XZ */ +/* ?get_allocator@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEBA?AV?$allocator(a)_W@2(a)XZ */ +DEFINE_THISCALL_WRAPPER(basic_string_wchar_get_allocator, 4) +allocator __thiscall basic_string_wchar_get_allocator(const basic_string_wchar *this) +{ + allocator ret; + TRACE("%p\n", this); + return ret; +} + /* ?erase@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QAEAAV12(a)II@Z */ /* ?erase@?$basic_string(a)_WU?$char_traits(a)_W@std@@V?$allocator(a)_W@2@@std@@QEAAAEAV12(a)_K0@Z */ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_wchar_erase, 12)

1 0

Piotr Caban : msvcp90: Added basic_string::erase iterator based functions.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: 0b802bb7477e5ebc6ad672197c2152f949d0051f URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b802bb7477e5ebc6ad672197… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:13:26 2011 +0200 msvcp90: Added basic_string::erase iterator based functions. --- dlls/msvcp90/msvcp90.spec | 16 +++++----- dlls/msvcp90/string.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 72 insertions(+), 8 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=0b802bb7477e5ebc6ad67…

1 0

Piotr Caban : msvcp90: Added basic_string::replace iterator based functions .
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: bc2567f9744c88e01aef26ffdab9f9142290f71a URL: http://source.winehq.org/git/wine.git/?a=commit;h=bc2567f9744c88e01aef26ffd… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:13:10 2011 +0200 msvcp90: Added basic_string::replace iterator based functions. --- dlls/msvcp90/msvcp90.spec | 48 ++++++------ dlls/msvcp90/string.c | 194 ++++++++++++++++++++++++++++++++++++++------- 2 files changed, 190 insertions(+), 52 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=bc2567f9744c88e01aef2…

1 0

Piotr Caban : msvcp90: Added basic_string::rfind implementation.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: ed6c1ff8d5bb6ec1d54cb510e017abfdb0d5ed24 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ed6c1ff8d5bb6ec1d54cb510e… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:12:37 2011 +0200 msvcp90: Added basic_string::rfind implementation. --- dlls/msvcp90/msvcp90.spec | 32 ++++++------ dlls/msvcp90/string.c | 112 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+), 16 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ed6c1ff8d5bb6ec1d54cb…

1 0

Huw Davies : gdi32/tests: Remove unused legacy values.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: ffe5e20b78457ac8c0cc7efca2b5a77de8c4fa7f URL: http://source.winehq.org/git/wine.git/?a=commit;h=ffe5e20b78457ac8c0cc7efca… Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Oct 18 09:43:03 2011 +0100 gdi32/tests: Remove unused legacy values. --- dlls/gdi32/tests/bitmap.c | 26 +++++++++++--------------- 1 files changed, 11 insertions(+), 15 deletions(-) diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c index ed304aa..a412cc9 100644 --- a/dlls/gdi32/tests/bitmap.c +++ b/dlls/gdi32/tests/bitmap.c @@ -3054,7 +3054,7 @@ static void check_StretchDIBits_pixel(HDC hdcDst, UINT32 *dstBuffer, UINT32 *src static void check_StretchDIBits_stretch(HDC hdcDst, UINT32 *dstBuffer, UINT32 *srcBuffer, int nXOriginDest, int nYOriginDest, int nWidthDest, int nHeightDest, int nXOriginSrc, int nYOriginSrc, int nWidthSrc, int nHeightSrc, - UINT32 expected[4], UINT32 legacy_expected[4], int line) + UINT32 expected[4], int line) { BITMAPINFO bitmapInfo; @@ -3087,7 +3087,7 @@ static void test_StretchDIBits(void) UINT32 *dstBuffer, srcBuffer[4]; HBRUSH hBrush, hOldBrush; BITMAPINFO biDst; - UINT32 expected[4], legacy_expected[4]; + UINT32 expected[4]; memset(&biDst, 0, sizeof(BITMAPINFO)); biDst.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); @@ -3134,46 +3134,42 @@ static void test_StretchDIBits(void) expected[0] = 0xCAFED00D, expected[1] = 0xFEEDFACE; expected[2] = 0xFEDCBA98, expected[3] = 0x76543210; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 2, 2, 0, 0, 2, 2, expected, expected, __LINE__); + 0, 0, 2, 2, 0, 0, 2, 2, expected, __LINE__); expected[0] = 0xCAFED00D, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0x00000000; - legacy_expected[0] = 0xFEDCBA98, legacy_expected[1] = 0x00000000; - legacy_expected[2] = 0x00000000, legacy_expected[3] = 0x00000000; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 1, 1, 0, 0, 1, 1, expected, legacy_expected, __LINE__); + 0, 0, 1, 1, 0, 0, 1, 1, expected, __LINE__); expected[0] = 0xFEDCBA98, expected[1] = 0xFEDCBA98; expected[2] = 0xFEDCBA98, expected[3] = 0xFEDCBA98; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 2, 2, 0, 0, 1, 1, expected, expected, __LINE__); + 0, 0, 2, 2, 0, 0, 1, 1, expected, __LINE__); expected[0] = 0x42441000, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0x00000000; - legacy_expected[0] = 0x00543210, legacy_expected[1] = 0x00000000; - legacy_expected[2] = 0x00000000, legacy_expected[3] = 0x00000000; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 1, 1, 0, 0, 2, 2, expected, legacy_expected, __LINE__); + 0, 0, 1, 1, 0, 0, 2, 2, expected, __LINE__); expected[0] = 0x00000000, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0x00000000; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 2, 2, 1, 1, -2, -2, expected, expected, __LINE__); + 0, 0, 2, 2, 1, 1, -2, -2, expected, __LINE__); expected[0] = 0x00000000, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0x00000000; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 2, 2, 1, 1, -2, -2, expected, expected, __LINE__); + 0, 0, 2, 2, 1, 1, -2, -2, expected, __LINE__); expected[0] = 0x00000000, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0x00000000; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 1, 1, -2, -2, 1, 1, -2, -2, expected, expected, __LINE__); + 1, 1, -2, -2, 1, 1, -2, -2, expected, __LINE__); expected[0] = 0x00000000, expected[1] = 0x00000000; expected[2] = 0x00000000, expected[3] = 0xCAFED00D; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 1, 1, 2, 2, 0, 0, 2, 2, expected, expected, __LINE__); + 1, 1, 2, 2, 0, 0, 2, 2, expected, __LINE__); SelectObject(hdcDst, oldDst); DeleteObject(bmpDst); @@ -3187,7 +3183,7 @@ static void test_StretchDIBits(void) expected[0] = 0xFEDCBA98, expected[1] = 0x76543210; expected[2] = 0xCAFED00D, expected[3] = 0xFEEDFACE; check_StretchDIBits_stretch(hdcDst, dstBuffer, srcBuffer, - 0, 0, 2, 2, 0, 0, 2, 2, expected, expected, __LINE__); + 0, 0, 2, 2, 0, 0, 2, 2, expected, __LINE__); /* Tidy up */ SelectObject(hdcDst, oldDst);

1 0

Piotr Caban : msvcp: Sync spec files.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: 32b24db04116335bc7ff858a34f1070454eea386 URL: http://source.winehq.org/git/wine.git/?a=commit;h=32b24db04116335bc7ff858a3… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:14:21 2011 +0200 msvcp: Sync spec files. --- dlls/msvcp60/msvcp60.spec | 36 +++++++++++----------- dlls/msvcp70/msvcp70.spec | 72 ++++++++++++++++++++++---------------------- dlls/msvcp71/msvcp71.spec | 72 ++++++++++++++++++++++---------------------- dlls/msvcp80/msvcp80.spec | 72 ++++++++++++++++++++++---------------------- 4 files changed, 126 insertions(+), 126 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=32b24db04116335bc7ff8…

1 0

Piotr Caban : msvcp90: Added basic_string::find_last_not_of implementation.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: a6897e888ef67db9bdc9a9ac63739fc8d32506cf URL: http://source.winehq.org/git/wine.git/?a=commit;h=a6897e888ef67db9bdc9a9ac6… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Oct 18 11:12:53 2011 +0200 msvcp90: Added basic_string::find_last_not_of implementation. --- dlls/msvcp90/msvcp90.spec | 32 +++++++------- dlls/msvcp90/string.c | 105 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 120 insertions(+), 17 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a6897e888ef67db9bdc9a…

1 0

Andrew Talbot : winex11.drv: Mark some fall-throughs in switch statements.
by Alexandre Julliard Oct. 18, 2011

Oct. 18, 2011

Module: wine Branch: master Commit: 53a8746dcdc07d3eba42e40dcffdb531531fd5a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=53a8746dcdc07d3eba42e40dc… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Mon Oct 17 20:29:58 2011 +0100 winex11.drv: Mark some fall-throughs in switch statements. --- dlls/winex11.drv/dib.c | 6 ++++++ dlls/winex11.drv/keyboard.c | 1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c index 4593d9a..a1ce9bb 100644 --- a/dlls/winex11.drv/dib.c +++ b/dlls/winex11.drv/dib.c @@ -437,11 +437,17 @@ static void X11DRV_DIB_SetImageBits_1( int lines, const BYTE *srcbits, switch (width & 7) { case 7: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 6: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 5: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 4: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 3: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 2: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); srcval<<=1; + /* fall through */ case 1: XPutPixel(bmpImage, x++, h, colors[srcval >> 7]); } } diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c index 47317e6..e985694 100644 --- a/dlls/winex11.drv/keyboard.c +++ b/dlls/winex11.drv/keyboard.c @@ -2242,6 +2242,7 @@ INT CDECL X11DRV_GetKeyNameText(LONG lParam, LPWSTR lpBuffer, INT nSize) case VK_RSHIFT: /* R-Shift is "special" - it is an extended key with separate scan code */ scanCode |= 0x100; + /* fall through */ case VK_LSHIFT: vkey = VK_SHIFT; break;

1 0