October 2011 - Wine-Commits

André Hentschel : ntdll: Map ETIME to STATUS_IO_TIMEOUT.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: 905a819d7c06bc066925b59c6f18c81450c49657 URL: http://source.winehq.org/git/wine.git/?a=commit;h=905a819d7c06bc066925b59c6… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Oct 3 17:45:27 2011 +0200 ntdll: Map ETIME to STATUS_IO_TIMEOUT. --- dlls/ntdll/file.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 53984f9..85fc858 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -347,6 +347,7 @@ NTSTATUS FILE_GetNtStatus(void) case ECONNRESET:return STATUS_PIPE_DISCONNECTED; case EFAULT: return STATUS_ACCESS_VIOLATION; case ESPIPE: return STATUS_ILLEGAL_FUNCTION; + case ETIME: return STATUS_IO_TIMEOUT; case ENOEXEC: /* ?? */ case EEXIST: /* ?? */ default:

1 0

Andrew Talbot : msxml3: Add a break to a switch statement.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: 708f3a3fef3f4b06fb096549afeffe808cd2e37c URL: http://source.winehq.org/git/wine.git/?a=commit;h=708f3a3fef3f4b06fb096549a… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Oct 8 17:51:38 2011 +0100 msxml3: Add a break to a switch statement. --- dlls/msxml3/domdoc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 2eedc78..144648e 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -1958,6 +1958,7 @@ static HRESULT WINAPI domdoc_createNode( case NODE_ENTITY_REFERENCE: case NODE_PROCESSING_INSTRUCTION: if (!name || *name == 0) return E_FAIL; + break; default: break; }

1 0

Dmitry Timoshkov : user32: Add support for iPaddedBorderWidth in NONCLIENTMETRICS.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: 70caadbf34807e96ed8543abd7efddc302b7798c URL: http://source.winehq.org/git/wine.git/?a=commit;h=70caadbf34807e96ed8543abd… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Sat Oct 8 20:11:34 2011 +0900 user32: Add support for iPaddedBorderWidth in NONCLIENTMETRICS. --- dlls/user32/sysparams.c | 28 ++++++++++++++++++++++------ dlls/user32/tests/dialog.c | 2 +- dlls/user32/tests/generated.c | 36 ++++++++++++++++++++++++------------ dlls/user32/tests/sysparams.c | 37 +++++++++++++++++++++++++++++-------- include/winuser.h | 2 ++ 5 files changed, 78 insertions(+), 27 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=70caadbf34807e96ed854…

1 0

Bernhard Loos : ntdll: Implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformationFile .
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: 07b681e04a19d9e95c1039c0a791608ef5897617 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07b681e04a19d9e95c1039c0a… Author: Bernhard Loos <bernhardloos(a)googlemail.com> Date: Thu Sep 29 11:21:14 2011 +0200 ntdll: Implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformationFile. --- dlls/ntdll/file.c | 13 ++++++++++++- dlls/ntdll/tests/pipe.c | 7 ++++++- include/wine/server_protocol.h | 4 ++-- server/named_pipe.c | 1 + server/protocol.def | 1 + server/request.h | 9 +++++---- server/trace.c | 1 + 7 files changed, 28 insertions(+), 8 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 278da5d..53984f9 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -1960,7 +1960,18 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io, { pli->NamedPipeType = (reply->flags & NAMED_PIPE_MESSAGE_STREAM_WRITE) ? FILE_PIPE_TYPE_MESSAGE : FILE_PIPE_TYPE_BYTE; - pli->NamedPipeConfiguration = 0; /* FIXME */ + switch (reply->sharing) + { + case FILE_SHARE_READ: + pli->NamedPipeConfiguration = FILE_PIPE_OUTBOUND; + break; + case FILE_SHARE_WRITE: + pli->NamedPipeConfiguration = FILE_PIPE_INBOUND; + break; + case FILE_SHARE_READ | FILE_SHARE_WRITE: + pli->NamedPipeConfiguration = FILE_PIPE_FULL_DUPLEX; + break; + } pli->MaximumInstances = reply->maxinstances; pli->CurrentInstances = reply->instances; pli->InboundQuota = reply->insize; diff --git a/dlls/ntdll/tests/pipe.c b/dlls/ntdll/tests/pipe.c index e7c49b8..29bb6da 100644 --- a/dlls/ntdll/tests/pipe.c +++ b/dlls/ntdll/tests/pipe.c @@ -181,7 +181,8 @@ static void test_create(void) IO_STATUS_BLOCK iosb; static const DWORD access[] = { 0, GENERIC_READ, GENERIC_WRITE, GENERIC_READ | GENERIC_WRITE}; - static const DWORD sharing[] = { FILE_SHARE_READ, FILE_SHARE_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE }; + static const DWORD sharing[] = { FILE_SHARE_READ, FILE_SHARE_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE }; + static const DWORD pipe_config[]= { 1, 0, 2 }; for (j = 0; j < sizeof(sharing) / sizeof(DWORD); j++) { for (k = 0; k < sizeof(access) / sizeof(DWORD); k++) { @@ -196,12 +197,16 @@ static void test_create(void) res = pNtQueryInformationFile(hserver, &iosb, &info, sizeof(info), (FILE_INFORMATION_CLASS)24); ok(!res, "NtQueryInformationFile for server returned %x, sharing: %x\n", res, sharing[j]); + ok(info.NamedPipeConfiguration == pipe_config[j], "wrong duplex status for pipe: %d, expected %d\n", + info.NamedPipeConfiguration, pipe_config[j]); hclient = CreateFileW(testpipe, access[k], 0, 0, OPEN_EXISTING, 0, 0); if (hclient != INVALID_HANDLE_VALUE) { res = pNtQueryInformationFile(hclient, &iosb, &info, sizeof(info), (FILE_INFORMATION_CLASS)24); ok(!res, "NtQueryInformationFile for client returned %x, access: %x, sharing: %x\n", res, access[k], sharing[j]); + ok(info.NamedPipeConfiguration == pipe_config[j], "wrong duplex status for pipe: %d, expected %d\n", + info.NamedPipeConfiguration, pipe_config[j]); CloseHandle(hclient); } diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 9db7f78..e0b0ac8 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -3063,11 +3063,11 @@ struct get_named_pipe_info_reply { struct reply_header __header; unsigned int flags; + unsigned int sharing; unsigned int maxinstances; unsigned int instances; unsigned int outsize; unsigned int insize; - char __pad_28[4]; }; @@ -5637,6 +5637,6 @@ union generic_reply struct set_suspend_context_reply set_suspend_context_reply; }; -#define SERVER_PROTOCOL_VERSION 426 +#define SERVER_PROTOCOL_VERSION 427 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ diff --git a/server/named_pipe.c b/server/named_pipe.c index d6c1383..d720b17 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -1026,6 +1026,7 @@ DECL_HANDLER(get_named_pipe_info) } reply->flags = server->pipe->flags; + reply->sharing = server->pipe->sharing; reply->maxinstances = server->pipe->maxinstances; reply->instances = server->pipe->instances; reply->insize = server->pipe->insize; diff --git a/server/protocol.def b/server/protocol.def index 71524a4..bec2e3c 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -2208,6 +2208,7 @@ enum message_type obj_handle_t handle; @REPLY unsigned int flags; + unsigned int sharing; unsigned int maxinstances; unsigned int instances; unsigned int outsize; diff --git a/server/request.h b/server/request.h index 2d4528a..b875e30 100644 --- a/server/request.h +++ b/server/request.h @@ -1489,10 +1489,11 @@ C_ASSERT( sizeof(struct create_named_pipe_reply) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_request, handle) == 12 ); C_ASSERT( sizeof(struct get_named_pipe_info_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, flags) == 8 ); -C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, maxinstances) == 12 ); -C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, instances) == 16 ); -C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, outsize) == 20 ); -C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, insize) == 24 ); +C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, sharing) == 12 ); +C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, maxinstances) == 16 ); +C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, instances) == 20 ); +C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, outsize) == 24 ); +C_ASSERT( FIELD_OFFSET(struct get_named_pipe_info_reply, insize) == 28 ); C_ASSERT( sizeof(struct get_named_pipe_info_reply) == 32 ); C_ASSERT( FIELD_OFFSET(struct create_window_request, parent) == 12 ); C_ASSERT( FIELD_OFFSET(struct create_window_request, owner) == 16 ); diff --git a/server/trace.c b/server/trace.c index 670958a..188eee4 100644 --- a/server/trace.c +++ b/server/trace.c @@ -2629,6 +2629,7 @@ static void dump_get_named_pipe_info_request( const struct get_named_pipe_info_r static void dump_get_named_pipe_info_reply( const struct get_named_pipe_info_reply *req ) { fprintf( stderr, " flags=%08x", req->flags ); + fprintf( stderr, ", sharing=%08x", req->sharing ); fprintf( stderr, ", maxinstances=%08x", req->maxinstances ); fprintf( stderr, ", instances=%08x", req->instances ); fprintf( stderr, ", outsize=%08x", req->outsize );

1 0

Bernhard Loos : server: Correctly implement permission checking for named pipes.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: 9034e694a36df25fadd654c29a13bdd1444bbd6a URL: http://source.winehq.org/git/wine.git/?a=commit;h=9034e694a36df25fadd654c29… Author: Bernhard Loos <bernhardloos(a)googlemail.com> Date: Thu Sep 29 11:20:50 2011 +0200 server: Correctly implement permission checking for named pipes. --- dlls/ntdll/tests/pipe.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++ server/named_pipe.c | 10 +++++++++ 2 files changed, 62 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/tests/pipe.c b/dlls/ntdll/tests/pipe.c index 26c38b0..e7c49b8 100644 --- a/dlls/ntdll/tests/pipe.c +++ b/dlls/ntdll/tests/pipe.c @@ -172,6 +172,55 @@ static void test_create_invalid(void) CloseHandle(handle); } +static void test_create(void) +{ + HANDLE hserver; + NTSTATUS res; + int j, k; + FILE_PIPE_LOCAL_INFORMATION info; + IO_STATUS_BLOCK iosb; + + static const DWORD access[] = { 0, GENERIC_READ, GENERIC_WRITE, GENERIC_READ | GENERIC_WRITE}; + static const DWORD sharing[] = { FILE_SHARE_READ, FILE_SHARE_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE }; + + for (j = 0; j < sizeof(sharing) / sizeof(DWORD); j++) { + for (k = 0; k < sizeof(access) / sizeof(DWORD); k++) { + HANDLE hclient; + BOOL should_succeed = TRUE; + + res = create_pipe(&hserver, sharing[j], FILE_SYNCHRONOUS_IO_NONALERT); + if (res) { + ok(0, "NtCreateNamedPipeFile returned %x, sharing: %x\n", res, sharing[j]); + continue; + } + + res = pNtQueryInformationFile(hserver, &iosb, &info, sizeof(info), (FILE_INFORMATION_CLASS)24); + ok(!res, "NtQueryInformationFile for server returned %x, sharing: %x\n", res, sharing[j]); + + hclient = CreateFileW(testpipe, access[k], 0, 0, OPEN_EXISTING, 0, 0); + if (hclient != INVALID_HANDLE_VALUE) { + res = pNtQueryInformationFile(hclient, &iosb, &info, sizeof(info), (FILE_INFORMATION_CLASS)24); + ok(!res, "NtQueryInformationFile for client returned %x, access: %x, sharing: %x\n", + res, access[k], sharing[j]); + CloseHandle(hclient); + } + + if (access[k] & GENERIC_WRITE) + should_succeed &= !!(sharing[j] & FILE_SHARE_WRITE); + if (access[k] & GENERIC_READ) + should_succeed &= !!(sharing[j] & FILE_SHARE_READ); + + if (should_succeed) + ok(hclient != INVALID_HANDLE_VALUE, "CreateFile failed for sharing %x, access: %x, GetLastError: %d\n", + sharing[j], access[k], GetLastError()); + else + ok(hclient == INVALID_HANDLE_VALUE, "CreateFile succeded for sharing %x, access: %x\n", sharing[j], access[k]); + + CloseHandle(hserver); + } + } +} + static BOOL ioapc_called; static void CALLBACK ioapc(void *arg, PIO_STATUS_BLOCK io, ULONG reserved) { @@ -419,6 +468,9 @@ START_TEST(pipe) trace("starting invalid create tests\n"); test_create_invalid(); + trace("starting create tests\n"); + test_create(); + trace("starting overlapped tests\n"); test_overlapped(); diff --git a/server/named_pipe.c b/server/named_pipe.c index 750f3bc..d6c1383 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -804,6 +804,7 @@ static struct object *named_pipe_open_file( struct object *obj, unsigned int acc struct named_pipe *pipe = (struct named_pipe *)obj; struct pipe_server *server; struct pipe_client *client; + unsigned int pipe_sharing; int fds[2]; if (!(server = find_available_server( pipe ))) @@ -812,6 +813,15 @@ static struct object *named_pipe_open_file( struct object *obj, unsigned int acc return NULL; } + pipe_sharing = server->pipe->sharing; + if (((access & GENERIC_READ) && !(pipe_sharing & FILE_SHARE_READ)) || + ((access & GENERIC_WRITE) && !(pipe_sharing & FILE_SHARE_WRITE))) + { + set_error( STATUS_ACCESS_DENIED ); + release_object( server ); + return NULL; + } + if ((client = create_pipe_client( options ))) { if (!socketpair( PF_UNIX, SOCK_STREAM, 0, fds ))

1 0

Bernhard Loos : server: It' s possible to call NtQueryInformationFile on a pipe if it was opened with access 0 .
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: e4c2a6d1cdc5c56404414afb1dd0ecc51938a4b3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e4c2a6d1cdc5c56404414afb1… Author: Bernhard Loos <bernhardloos(a)googlemail.com> Date: Thu Sep 29 11:20:42 2011 +0200 server: It's possible to call NtQueryInformationFile on a pipe if it was opened with access 0. --- dlls/ntdll/tests/pipe.c | 2 +- server/named_pipe.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/tests/pipe.c b/dlls/ntdll/tests/pipe.c index 358e702..26c38b0 100644 --- a/dlls/ntdll/tests/pipe.c +++ b/dlls/ntdll/tests/pipe.c @@ -160,7 +160,7 @@ static void test_create_invalid(void) ok(!res, "NtCreateNamedPipeFile returned %x\n", res); res = pNtQueryInformationFile(handle, &iosb, &info, sizeof(info), (FILE_INFORMATION_CLASS)24); - todo_wine ok(res == STATUS_ACCESS_DENIED, "NtQueryInformationFile returned %x\n", res); + ok(res == STATUS_ACCESS_DENIED, "NtQueryInformationFile returned %x\n", res); /* test FILE_CREATE creation disposition */ res = pNtCreateNamedPipeFile(&handle2, SYNCHRONIZE, &attr, &iosb, FILE_SHARE_READ | FILE_SHARE_WRITE, 2 /*FILE_CREATE*/, diff --git a/server/named_pipe.c b/server/named_pipe.c index 66664bb..750f3bc 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -1005,9 +1005,12 @@ DECL_HANDLER(get_named_pipe_info) server = get_pipe_server_obj( current->process, req->handle, FILE_READ_ATTRIBUTES ); if (!server) { + if (get_error() != STATUS_OBJECT_TYPE_MISMATCH) + return; + clear_error(); client = (struct pipe_client *)get_handle_obj( current->process, req->handle, - FILE_READ_ATTRIBUTES, &pipe_client_ops ); + 0, &pipe_client_ops ); if (!client) return; server = client->server; }

1 0

Frédéric Delanoy : cmd: Make PAUSE accept any keypress instead of a full input line.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: e0ec3e400df12f682bf279e3588d7656a7298c52 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e0ec3e400df12f682bf279e35… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Fri Oct 7 01:02:08 2011 +0200 cmd: Make PAUSE accept any keypress instead of a full input line. --- po/ar.po | 83 +++++++++++++++++++++-------------------- po/bg.po | 83 +++++++++++++++++++++-------------------- po/ca.po | 83 +++++++++++++++++++++-------------------- po/cs.po | 83 +++++++++++++++++++++-------------------- po/da.po | 85 ++++++++++++++++++++++-------------------- po/de.po | 85 ++++++++++++++++++++++-------------------- po/el.po | 83 +++++++++++++++++++++-------------------- po/en.po | 94 ++++++++++++++++++++++++----------------------- po/en_US.po | 94 ++++++++++++++++++++++++----------------------- po/eo.po | 83 +++++++++++++++++++++-------------------- po/es.po | 85 ++++++++++++++++++++++-------------------- po/fa.po | 83 +++++++++++++++++++++-------------------- po/fi.po | 83 +++++++++++++++++++++-------------------- po/fr.po | 85 ++++++++++++++++++++++-------------------- po/he.po | 85 ++++++++++++++++++++++-------------------- po/hi.po | 83 +++++++++++++++++++++-------------------- po/hu.po | 83 +++++++++++++++++++++-------------------- po/it.po | 85 ++++++++++++++++++++++-------------------- po/ja.po | 85 ++++++++++++++++++++++-------------------- po/ko.po | 85 ++++++++++++++++++++++-------------------- po/lt.po | 85 ++++++++++++++++++++++-------------------- po/ml.po | 83 +++++++++++++++++++++-------------------- po/nb_NO.po | 84 +++++++++++++++++++++-------------------- po/nl.po | 85 ++++++++++++++++++++++-------------------- po/or.po | 83 +++++++++++++++++++++-------------------- po/pa.po | 83 +++++++++++++++++++++-------------------- po/pl.po | 85 ++++++++++++++++++++++-------------------- po/pt_BR.po | 85 ++++++++++++++++++++++-------------------- po/pt_PT.po | 84 +++++++++++++++++++++-------------------- po/rm.po | 83 +++++++++++++++++++++-------------------- po/ro.po | 85 ++++++++++++++++++++++-------------------- po/ru.po | 85 ++++++++++++++++++++++-------------------- po/sk.po | 83 +++++++++++++++++++++-------------------- po/sl.po | 85 ++++++++++++++++++++++-------------------- po/sr_RS(a)cyrillic.po | 83 +++++++++++++++++++++-------------------- po/sr_RS(a)latin.po | 83 +++++++++++++++++++++-------------------- po/sv.po | 85 ++++++++++++++++++++++-------------------- po/te.po | 83 +++++++++++++++++++++-------------------- po/th.po | 83 +++++++++++++++++++++-------------------- po/tr.po | 84 +++++++++++++++++++++-------------------- po/uk.po | 85 ++++++++++++++++++++++-------------------- po/wa.po | 83 +++++++++++++++++++++-------------------- po/wine.pot | 83 +++++++++++++++++++++-------------------- po/zh_CN.po | 83 +++++++++++++++++++++-------------------- po/zh_TW.po | 83 +++++++++++++++++++++-------------------- programs/cmd/builtins.c | 21 +++++++--- programs/cmd/cmd.rc | 11 +++-- 47 files changed, 1960 insertions(+), 1866 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e0ec3e400df12f682bf27…

1 0

Frédéric Delanoy : cmd: Consistently use infinitive forms in commands help summary.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

1 0

Charles Davis : loader: Fix constant address warning on Mac OS.
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: ec37157b06ac41b268799de1a48721eacd15dc94 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ec37157b06ac41b268799de1a… Author: Charles Davis <cdavis(a)mymail.mines.edu> Date: Fri Oct 7 16:05:25 2011 -0600 loader: Fix constant address warning on Mac OS. --- loader/main.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/loader/main.c b/loader/main.c index 8434d81..11f475b 100644 --- a/loader/main.c +++ b/loader/main.c @@ -219,7 +219,9 @@ int main( int argc, char *argv[] ) } } +#ifndef __APPLE__ if (wine_main_preload_info) +#endif { for (i = 0; wine_main_preload_info[i].size; i++) reserve_area( wine_main_preload_info[i].addr, wine_main_preload_info[i].size );

1 0

André Hentschel : ole32: Return if out of memory ( Coverity).
by Alexandre Julliard Oct. 8, 2011

Oct. 8, 2011

Module: wine Branch: master Commit: c2015d334121729dc01eb1e90c39eb561589ac32 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c2015d334121729dc01eb1e90… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Sep 28 19:58:57 2011 +0200 ole32: Return if out of memory (Coverity). --- dlls/ole32/rpc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c index 8ac5d2d..35971e0 100644 --- a/dlls/ole32/rpc.c +++ b/dlls/ole32/rpc.c @@ -539,7 +539,10 @@ static HRESULT WINAPI ServerRpcChannelBuffer_GetBuffer(LPRPCCHANNELBUFFER iface, if (msg->Buffer) status = RPC_S_OK; else - status = ERROR_OUTOFMEMORY; + { + HeapFree(GetProcessHeap(), 0, channel_hook_data); + return E_OUTOFMEMORY; + } } else status = I_RpcGetBuffer(msg);

1 0