November 2011 - Wine-Commits

Hans Leidekker : msi: Process messages while waiting for custom actions to complete.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 353016f92f14f97be8f971af2b9d58d8162e6b25 URL: http://source.winehq.org/git/wine.git/?a=commit;h=353016f92f14f97be8f971af2… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 10 11:38:28 2011 +0100 msi: Process messages while waiting for custom actions to complete. --- dlls/msi/dialog.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c index 8b10215..4e908ff 100644 --- a/dlls/msi/dialog.c +++ b/dlls/msi/dialog.c @@ -3786,8 +3786,16 @@ void msi_dialog_check_messages( HANDLE handle ) /* in threads other than the UI thread, block */ if( uiThreadId != GetCurrentThreadId() ) { - if( handle ) - MsgWaitForMultipleObjectsEx( 1, &handle, INFINITE, 0, 0 ); + if (!handle) return; + while (MsgWaitForMultipleObjectsEx( 1, &handle, INFINITE, QS_ALLINPUT, 0 ) == WAIT_OBJECT_0 + 1) + { + MSG msg; + while (PeekMessageW( &msg, NULL, 0, 0, PM_REMOVE )) + { + TranslateMessage( &msg ); + DispatchMessageW( &msg ); + } + } return; }

1 0

Hans Leidekker : winhttp: Convert string data to UTF-8 and add a corresponding content type header.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 3c9d356bc44c208264c07e7d123a62dfdc068255 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3c9d356bc44c208264c07e7d1… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 10 11:37:31 2011 +0100 winhttp: Convert string data to UTF-8 and add a corresponding content type header. --- dlls/winhttp/request.c | 62 ++++++++++++++++++++++++++++++++++------- dlls/winhttp/tests/winhttp.c | 21 +++++++++++++- 2 files changed, 71 insertions(+), 12 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 51c433e..e0c68e6 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -2217,6 +2217,7 @@ static void free_request( struct winhttp_request *request ) heap_free( (WCHAR *)request->proxy.lpszProxyBypass ); heap_free( request->buffer ); heap_free( request->verb ); + VariantClear( &request->data ); } static ULONG WINAPI winhttp_request_Release( @@ -2860,6 +2861,20 @@ static DWORD request_set_parameters( struct winhttp_request *request ) return ERROR_SUCCESS; } +static void request_set_utf8_content_type( struct winhttp_request *request ) +{ + static const WCHAR fmtW[] = {'%','s',':',' ','%','s',0}; + static const WCHAR text_plainW[] = {'t','e','x','t','/','p','l','a','i','n',0}; + static const WCHAR charset_utf8W[] = {'c','h','a','r','s','e','t','=','u','t','f','-','8',0}; + WCHAR headerW[64]; + int len; + + len = sprintfW( headerW, fmtW, attr_content_type, text_plainW ); + WinHttpAddRequestHeaders( request->hrequest, headerW, len, WINHTTP_ADDREQ_FLAG_ADD_IF_NEW ); + len = sprintfW( headerW, fmtW, attr_content_type, charset_utf8W ); + WinHttpAddRequestHeaders( request->hrequest, headerW, len, WINHTTP_ADDREQ_FLAG_COALESCE_WITH_SEMICOLON ); +} + static HRESULT request_send( struct winhttp_request *request ) { SAFEARRAY *sa = NULL; @@ -2871,24 +2886,47 @@ static HRESULT request_send( struct winhttp_request *request ) DWORD err; if ((err = request_set_parameters( request ))) return HRESULT_FROM_WIN32( err ); - VariantInit( &data ); - if (strcmpW( request->verb, getW ) && VariantChangeType( &data, &request->data, 0, VT_ARRAY|VT_UI1 ) == S_OK) + if (strcmpW( request->verb, getW )) { - SAFEARRAY *sa = V_ARRAY( &data ); - if ((hr = SafeArrayAccessData( sa, (void **)&ptr )) != S_OK) return hr; - if ((hr = SafeArrayGetUBound( sa, 1, &size ) != S_OK)) + VariantInit( &data ); + if (V_VT( &request->data ) == VT_BSTR) { - SafeArrayUnaccessData( sa ); - return hr; + UINT i, cp = CP_ACP; + const WCHAR *str = V_BSTR( &request->data ); + int len = strlenW( str ); + + for (i = 0; i < len; i++) + { + if (str[i] > 127) + { + cp = CP_UTF8; + break; + } + } + size = WideCharToMultiByte( cp, 0, str, len, NULL, 0, NULL, NULL ); + if (!(ptr = heap_alloc( size ))) return E_OUTOFMEMORY; + WideCharToMultiByte( cp, 0, str, len, ptr, size, NULL, NULL ); + if (cp == CP_UTF8) request_set_utf8_content_type( request ); + } + else if (VariantChangeType( &data, &request->data, 0, VT_ARRAY|VT_UI1 ) == S_OK) + { + sa = V_ARRAY( &data ); + if ((hr = SafeArrayAccessData( sa, (void **)&ptr )) != S_OK) return hr; + if ((hr = SafeArrayGetUBound( sa, 1, &size ) != S_OK)) + { + SafeArrayUnaccessData( sa ); + return hr; + } + size++; } - size++; } wait_set_status_callback( request, WINHTTP_CALLBACK_STATUS_REQUEST_SENT ); if (!(ret = WinHttpSendRequest( request->hrequest, NULL, 0, ptr, size, size, 0 ))) { err = get_last_error(); } - if (sa && (hr = SafeArrayUnaccessData( sa )) != S_OK) return hr; + if (!sa) heap_free( ptr ); + else if ((hr = SafeArrayUnaccessData( sa )) != S_OK) return hr; if (!ret) return HRESULT_FROM_WIN32( err ); if ((err = wait_for_completion( request ))) return HRESULT_FROM_WIN32( err ); @@ -2914,7 +2952,7 @@ static HRESULT WINAPI winhttp_request_Send( VARIANT body ) { struct winhttp_request *request = impl_from_IWinHttpRequest( iface ); - HRESULT hr = S_OK; + HRESULT hr; TRACE("%p, %s\n", request, debugstr_variant(&body)); @@ -2929,7 +2967,9 @@ static HRESULT WINAPI winhttp_request_Send( LeaveCriticalSection( &request->cs ); return S_OK; } - request->data = body; + VariantClear( &request->data ); + if ((hr = VariantCopyInd( &request->data, &body )) != S_OK) return hr; + if (request->wait) /* async request */ { if (!(request->thread = CreateThread( NULL, 0, send_and_receive_proc, request, 0, NULL ))) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 01b74e3..acf88dc 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -2111,17 +2111,22 @@ static void test_IWinHttpRequest(void) static const WCHAR passwordW[] = {'p','a','s','s','w','o','r','d',0}; static const WCHAR url1W[] = {'h','t','t','p',':','/','/','w','i','n','e','h','q','.','o','r','g',0}; static const WCHAR url2W[] = {'w','i','n','e','h','q','.','o','r','g',0}; + static const WCHAR url3W[] = {'h','t','t','p',':','/','/','c','r','o','s','s','o','v','e','r','.', + 'c','o','d','e','w','e','a','v','e','r','s','.','c','o','m','/', + 'p','o','s','t','t','e','s','t','.','p','h','p',0}; static const WCHAR method1W[] = {'G','E','T',0}; static const WCHAR method2W[] = {'I','N','V','A','L','I','D',0}; + static const WCHAR method3W[] = {'P','O','S','T',0}; static const WCHAR proxy_serverW[] = {'p','r','o','x','y','s','e','r','v','e','r',0}; static const WCHAR bypas_listW[] = {'b','y','p','a','s','s','l','i','s','t',0}; static const WCHAR connectionW[] = {'C','o','n','n','e','c','t','i','o','n',0}; static const WCHAR dateW[] = {'D','a','t','e',0}; + static const WCHAR test_dataW[] = {'t','e','s','t','d','a','t','a',128,0}; HRESULT hr; IWinHttpRequest *req; BSTR method, url, username, password, response = NULL, status_text = NULL, headers = NULL; BSTR date, today, connection, value = NULL; - VARIANT async, empty, timeout, body, proxy_server, bypass_list; + VARIANT async, empty, timeout, body, proxy_server, bypass_list, data; VARIANT_BOOL succeeded; LONG status; WCHAR todayW[WINHTTP_TIME_FORMAT_BUFSIZE]; @@ -2140,6 +2145,20 @@ static void test_IWinHttpRequest(void) V_VT( &async ) = VT_BOOL; V_BOOL( &async ) = VARIANT_FALSE; + method = SysAllocString( method3W ); + url = SysAllocString( url3W ); + hr = IWinHttpRequest_Open( req, method, url, async ); + ok( hr == S_OK, "got %08x\n", hr ); + SysFreeString( method ); + SysFreeString( url ); + + V_VT( &data ) = VT_BSTR; + V_BSTR( &data ) = SysAllocString( test_dataW ); + hr = IWinHttpRequest_Send( req, data ); + ok( hr == S_OK || broken(hr == HRESULT_FROM_WIN32(ERROR_WINHTTP_INVALID_SERVER_RESPONSE)), + "got %08x\n", hr ); + SysFreeString( V_BSTR( &data ) ); + hr = IWinHttpRequest_Open( req, NULL, NULL, empty ); ok( hr == E_INVALIDARG, "got %08x\n", hr );

1 0

Francois Gouget : kernel32: Declare more TimerQueue functions in winbase.h.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 1c108d1acbe71dacb9ad3a6ed39380a8cd12c2a8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c108d1acbe71dacb9ad3a6ed… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Nov 10 14:38:27 2011 +0100 kernel32: Declare more TimerQueue functions in winbase.h. --- include/winbase.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/winbase.h b/include/winbase.h index a37d073..c84c1f1 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -1360,6 +1360,7 @@ WINBASEAPI BOOL WINAPI CallNamedPipeW(LPCWSTR,LPVOID,DWORD,LPVOID,DWORD,L #define CallNamedPipe WINELIB_NAME_AW(CallNamedPipe) WINBASEAPI BOOL WINAPI CancelIo(HANDLE); WINBASEAPI BOOL WINAPI CancelIoEx(HANDLE,LPOVERLAPPED); +WINBASEAPI BOOL WINAPI CancelTimerQueueTimer(HANDLE,HANDLE); WINBASEAPI BOOL WINAPI CancelWaitableTimer(HANDLE); WINBASEAPI BOOL WINAPI ChangeTimerQueueTimer(HANDLE,HANDLE,ULONG,ULONG); WINADVAPI BOOL WINAPI CheckTokenMembership(HANDLE,PSID,PBOOL); @@ -1477,6 +1478,7 @@ WINBASEAPI void WINAPI DeleteFiber(LPVOID); WINBASEAPI BOOL WINAPI DeleteFileA(LPCSTR); WINBASEAPI BOOL WINAPI DeleteFileW(LPCWSTR); #define DeleteFile WINELIB_NAME_AW(DeleteFile) +WINBASEAPI BOOL WINAPI DeleteTimerQueue(HANDLE); WINBASEAPI BOOL WINAPI DeleteTimerQueueEx(HANDLE,HANDLE); WINBASEAPI BOOL WINAPI DeleteTimerQueueTimer(HANDLE,HANDLE,HANDLE); WINBASEAPI BOOL WINAPI DeleteVolumeMountPointA(LPCSTR); @@ -2133,6 +2135,7 @@ WINBASEAPI DWORD WINAPI SetThreadIdealProcessor(HANDLE,DWORD); WINBASEAPI BOOL WINAPI SetThreadPriority(HANDLE,INT); WINBASEAPI BOOL WINAPI SetThreadPriorityBoost(HANDLE,BOOL); WINADVAPI BOOL WINAPI SetThreadToken(PHANDLE,HANDLE); +WINBASEAPI HANDLE WINAPI SetTimerQueueTimer(HANDLE,WAITORTIMERCALLBACK,PVOID,DWORD,DWORD,BOOL); WINBASEAPI BOOL WINAPI SetTimeZoneInformation(const TIME_ZONE_INFORMATION *); WINADVAPI BOOL WINAPI SetTokenInformation(HANDLE,TOKEN_INFORMATION_CLASS,LPVOID,DWORD); WINBASEAPI LPTOP_LEVEL_EXCEPTION_FILTER WINAPI SetUnhandledExceptionFilter(LPTOP_LEVEL_EXCEPTION_FILTER);

1 0

Jacek Caban : mshtml: Store window URL as BSTR.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 535e2b23a3408ae072ff0092c89e11bd67cbf60f URL: http://source.winehq.org/git/wine.git/?a=commit;h=535e2b23a3408ae072ff0092c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 10 14:35:11 2011 +0100 mshtml: Store window URL as BSTR. --- dlls/mshtml/mshtml_private.h | 2 +- dlls/mshtml/navigate.c | 6 ++---- dlls/mshtml/persist.c | 11 ++++++++--- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 3a15c58..08da2d7 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -308,7 +308,7 @@ struct HTMLWindow { nsChannelBSC *bscallback; IMoniker *mon; - LPOLESTR url; + BSTR url; IHTMLEventObj *event; diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 0e0ea27..a2ecd8b 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -1261,7 +1261,7 @@ static void handle_navigation_error(nsChannelBSC *This, DWORD result) SAFEARRAYBOUND bound; VARIANT var, varOut; LONG ind; - BSTR url, unk; + BSTR unk; HRESULT hres; if(!This->window) @@ -1296,8 +1296,7 @@ static void handle_navigation_error(nsChannelBSC *This, DWORD result) ind = 1; V_VT(&var) = VT_BSTR; - url = SysAllocString(This->window->url); - V_BSTR(&var) = url; + V_BSTR(&var) = This->window->url; SafeArrayPutElement(sa, &ind, &var); ind = 3; @@ -1338,7 +1337,6 @@ static void handle_navigation_error(nsChannelBSC *This, DWORD result) V_BOOL(&varOut) = VARIANT_TRUE; IOleCommandTarget_Exec(olecmd, &CGID_DocHostCmdPriv, 1, 0, &var, FAILED(hres)?NULL:&varOut); - SysFreeString(url); SysFreeString(unk); SafeArrayDestroy(sa); IOleCommandTarget_Release(olecmd); diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 2e2643f..412dab7 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -68,6 +68,7 @@ static BOOL use_gecko_script(HTMLWindow *window) void set_current_mon(HTMLWindow *This, IMoniker *mon) { + WCHAR *url; HRESULT hres; if(This->mon) { @@ -76,7 +77,7 @@ void set_current_mon(HTMLWindow *This, IMoniker *mon) } if(This->url) { - CoTaskMemFree(This->url); + SysFreeString(This->url); This->url = NULL; } @@ -86,9 +87,13 @@ void set_current_mon(HTMLWindow *This, IMoniker *mon) IMoniker_AddRef(mon); This->mon = mon; - hres = IMoniker_GetDisplayName(mon, NULL, NULL, &This->url); - if(FAILED(hres)) + hres = IMoniker_GetDisplayName(mon, NULL, NULL, &url); + if(SUCCEEDED(hres)) { + This->url = SysAllocString(url); + CoTaskMemFree(url); + }else { WARN("GetDisplayName failed: %08x\n", hres); + } set_script_mode(This, use_gecko_script(This) ? SCRIPTMODE_GECKO : SCRIPTMODE_ACTIVESCRIPT); }

1 0

Hans Leidekker : scrrun: Add stub implementations of DllRegisterServer and DllUnregisterServer.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 655e16f1c9a1543190fd5b0f9aad38fb06396fa3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=655e16f1c9a1543190fd5b0f9… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 10 11:38:00 2011 +0100 scrrun: Add stub implementations of DllRegisterServer and DllUnregisterServer. --- dlls/scrrun/scrrun.c | 18 ++++++++++++++++++ dlls/scrrun/scrrun.spec | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/dlls/scrrun/scrrun.c b/dlls/scrrun/scrrun.c index 84a7bef..e825697 100644 --- a/dlls/scrrun/scrrun.c +++ b/dlls/scrrun/scrrun.c @@ -41,3 +41,21 @@ BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) } return TRUE; } + +/*********************************************************************** + * DllRegisterServer (scrrun.@) + */ +HRESULT WINAPI DllRegisterServer(void) +{ + FIXME("\n"); + return S_OK; +} + +/*********************************************************************** + * DllUnregisterServer (scrrun.@) + */ +HRESULT WINAPI DllUnregisterServer(void) +{ + FIXME("\n"); + return S_OK; +} diff --git a/dlls/scrrun/scrrun.spec b/dlls/scrrun/scrrun.spec index 5316d8f..838e9ea 100644 --- a/dlls/scrrun/scrrun.spec +++ b/dlls/scrrun/scrrun.spec @@ -1,6 +1,6 @@ @ stub DLLGetDocumentation @ stub DllCanUnloadNow @ stub DllGetClassObject -@ stub DllRegisterServer -@ stub DllUnregisterServer +@ stdcall -private DllRegisterServer() +@ stdcall -private DllUnregisterServer() @ stub DoOpenPipeStream

1 0

Jacek Caban : mshtml: Use IUri in set_current_mon if possible and store it in window object.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: d7f7f33e7dd12e70b5d901cd04722b300e39ff08 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7f7f33e7dd12e70b5d901cd0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 10 14:35:41 2011 +0100 mshtml: Use IUri in set_current_mon if possible and store it in window object. --- dlls/mshtml/mshtml_private.h | 1 + dlls/mshtml/persist.c | 41 +++++++++++++++++++++++++++++++++++------ 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 08da2d7..90ba6ad 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -308,6 +308,7 @@ struct HTMLWindow { nsChannelBSC *bscallback; IMoniker *mon; + IUri *uri; BSTR url; IHTMLEventObj *event; diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 412dab7..2ad108d 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -68,7 +68,7 @@ static BOOL use_gecko_script(HTMLWindow *window) void set_current_mon(HTMLWindow *This, IMoniker *mon) { - WCHAR *url; + IUriContainer *uri_container; HRESULT hres; if(This->mon) { @@ -76,6 +76,11 @@ void set_current_mon(HTMLWindow *This, IMoniker *mon) This->mon = NULL; } + if(This->uri) { + IUri_Release(This->uri); + This->uri = NULL; + } + if(This->url) { SysFreeString(This->url); This->url = NULL; @@ -87,12 +92,36 @@ void set_current_mon(HTMLWindow *This, IMoniker *mon) IMoniker_AddRef(mon); This->mon = mon; - hres = IMoniker_GetDisplayName(mon, NULL, NULL, &url); + hres = IMoniker_QueryInterface(mon, &IID_IUriContainer, (void**)&uri_container); if(SUCCEEDED(hres)) { - This->url = SysAllocString(url); - CoTaskMemFree(url); - }else { - WARN("GetDisplayName failed: %08x\n", hres); + hres = IUriContainer_GetIUri(uri_container, &This->uri); + IUriContainer_Release(uri_container); + if(hres != S_OK) { + WARN("GetIUri failed: %08x\n", hres); + This->uri = NULL; + } + } + + if(!This->uri) { + WCHAR *url; + + hres = IMoniker_GetDisplayName(mon, NULL, NULL, &url); + if(SUCCEEDED(hres)) { + hres = CreateUri(url, 0, 0, &This->uri); + if(FAILED(hres)) { + WARN("CrateUri failed: %08x\n", hres); + This->url = SysAllocString(url); + } + CoTaskMemFree(url); + }else { + WARN("GetDisplayName failed: %08x\n", hres); + } + } + + if(!This->url && This->uri) { + hres = IUri_GetDisplayUri(This->uri, &This->url); + if(FAILED(hres)) + WARN("GetDisplayUri failed: %08x\n", hres); } set_script_mode(This, use_gecko_script(This) ? SCRIPTMODE_GECKO : SCRIPTMODE_ACTIVESCRIPT);

1 0

Jacek Caban : mshtml: Use IUri in use_gecko_script.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 1190c8cbd6b10237f229da4d1fcc7624aac455c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1190c8cbd6b10237f229da4d1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 10 14:35:50 2011 +0100 mshtml: Use IUri in use_gecko_script. --- dlls/mshtml/persist.c | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 2ad108d..ef80f8d 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -32,6 +32,9 @@ #include "shlguid.h" #include "idispids.h" +#define NO_SHLWAPI_REG +#include "shlwapi.h" + #include "wine/debug.h" #include "mshtml_private.h" @@ -50,11 +53,9 @@ typedef struct { static BOOL use_gecko_script(HTMLWindow *window) { - DWORD zone; + DWORD zone, scheme; HRESULT hres; - static const WCHAR aboutW[] = {'a','b','o','u','t',':'}; - hres = IInternetSecurityManager_MapUrlToZone(window->secmgr, window->url, &zone, 0); if(FAILED(hres)) { WARN("Could not map %s to zone: %08x\n", debugstr_w(window->url), hres); @@ -62,8 +63,11 @@ static BOOL use_gecko_script(HTMLWindow *window) } TRACE("zone %d\n", zone); - return zone != URLZONE_LOCAL_MACHINE && zone != URLZONE_TRUSTED - && strncmpiW(aboutW, window->url, sizeof(aboutW)/sizeof(WCHAR)); + if(zone == URLZONE_LOCAL_MACHINE || zone == URLZONE_TRUSTED || !window->uri) + return FALSE; + + hres = IUri_GetScheme(window->uri, &scheme); + return FAILED(hres) || scheme != URL_SCHEME_ABOUT; } void set_current_mon(HTMLWindow *This, IMoniker *mon)

1 0

Frédéric Delanoy : dxdiag: Avoid dead increment ( clang).
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: b9e828df0a6146c6b469c49a112a59fd3d56dd29 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b9e828df0a6146c6b469c49a1… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Nov 10 02:35:06 2011 +0100 dxdiag: Avoid dead increment (clang). --- programs/dxdiag/output.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/programs/dxdiag/output.c b/programs/dxdiag/output.c index 8470f50..7fb9a4c 100644 --- a/programs/dxdiag/output.c +++ b/programs/dxdiag/output.c @@ -109,9 +109,7 @@ static BOOL output_text_field(HANDLE hFile, const char *field_name, DWORD field_ ptr += sprintf(ptr, sprintf_fmt, field_name); ptr += WideCharToMultiByte(CP_ACP, 0, value, value_lenW, ptr, value_lenA, NULL, NULL); - memcpy(ptr, crlf, sizeof(crlf)); - ptr += sizeof(crlf); return WriteFile(hFile, output_buffer, total_len, NULL, NULL); }

1 0

Michael Stefaniuc : include: Drop "l" modifiers from numeric constants in winternl.h.
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 5337ad066f3d09f86ee88c120d87080c96e3d902 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5337ad066f3d09f86ee88c120… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Nov 10 01:39:59 2011 +0100 include: Drop "l" modifiers from numeric constants in winternl.h. --- include/winternl.h | 78 ++++++++++++++++++++++++++-------------------------- 1 files changed, 39 insertions(+), 39 deletions(-) diff --git a/include/winternl.h b/include/winternl.h index cba5171..d8dd177 100644 --- a/include/winternl.h +++ b/include/winternl.h @@ -1604,14 +1604,14 @@ typedef struct _RTL_HANDLE_TABLE #define LOGONID_CURRENT ((ULONG)-1) -#define OBJ_INHERIT 0x00000002L -#define OBJ_PERMANENT 0x00000010L -#define OBJ_EXCLUSIVE 0x00000020L -#define OBJ_CASE_INSENSITIVE 0x00000040L -#define OBJ_OPENIF 0x00000080L -#define OBJ_OPENLINK 0x00000100L -#define OBJ_KERNEL_HANDLE 0x00000200L -#define OBJ_VALID_ATTRIBUTES 0x000003F2L +#define OBJ_INHERIT 0x00000002 +#define OBJ_PERMANENT 0x00000010 +#define OBJ_EXCLUSIVE 0x00000020 +#define OBJ_CASE_INSENSITIVE 0x00000040 +#define OBJ_OPENIF 0x00000080 +#define OBJ_OPENLINK 0x00000100 +#define OBJ_KERNEL_HANDLE 0x00000200 +#define OBJ_VALID_ATTRIBUTES 0x000003F2 #define SERVERNAME_CURRENT ((HANDLE)NULL) @@ -1629,37 +1629,37 @@ typedef void (NTAPI *RTL_WAITORTIMERCALLBACKFUNC)(PVOID,BOOLEAN); /* FIXME: not #define DPFLTR_MASK 0x8000000 /* Well-known LUID values */ -#define SE_MIN_WELL_KNOWN_PRIVILEGE 2L -#define SE_CREATE_TOKEN_PRIVILEGE 2L -#define SE_ASSIGNPRIMARYTOKEN_PRIVILEGE 3L -#define SE_LOCK_MEMORY_PRIVILEGE 4L -#define SE_INCREASE_QUOTA_PRIVILEGE 5L -#define SE_UNSOLICITED_INPUT_PRIVILEGE 6L /* obsolete */ -#define SE_MACHINE_ACCOUNT_PRIVILEGE 6L -#define SE_TCB_PRIVILEGE 7L -#define SE_SECURITY_PRIVILEGE 8L -#define SE_TAKE_OWNERSHIP_PRIVILEGE 9L -#define SE_LOAD_DRIVER_PRIVILEGE 10L -#define SE_SYSTEM_PROFILE_PRIVILEGE 11L -#define SE_SYSTEMTIME_PRIVILEGE 12L -#define SE_PROF_SINGLE_PROCESS_PRIVILEGE 13L -#define SE_INC_BASE_PRIORITY_PRIVILEGE 14L -#define SE_CREATE_PAGEFILE_PRIVILEGE 15L -#define SE_CREATE_PERMANENT_PRIVILEGE 16L -#define SE_BACKUP_PRIVILEGE 17L -#define SE_RESTORE_PRIVILEGE 18L -#define SE_SHUTDOWN_PRIVILEGE 19L -#define SE_DEBUG_PRIVILEGE 20L -#define SE_AUDIT_PRIVILEGE 21L -#define SE_SYSTEM_ENVIRONMENT_PRIVILEGE 22L -#define SE_CHANGE_NOTIFY_PRIVILEGE 23L -#define SE_REMOTE_SHUTDOWN_PRIVILEGE 24L -#define SE_UNDOCK_PRIVILEGE 25L -#define SE_SYNC_AGENT_PRIVILEGE 26L -#define SE_ENABLE_DELEGATION_PRIVILEGE 27L -#define SE_MANAGE_VOLUME_PRIVILEGE 28L -#define SE_IMPERSONATE_PRIVILEGE 29L -#define SE_CREATE_GLOBAL_PRIVILEGE 30L +#define SE_MIN_WELL_KNOWN_PRIVILEGE 2 +#define SE_CREATE_TOKEN_PRIVILEGE 2 +#define SE_ASSIGNPRIMARYTOKEN_PRIVILEGE 3 +#define SE_LOCK_MEMORY_PRIVILEGE 4 +#define SE_INCREASE_QUOTA_PRIVILEGE 5 +#define SE_UNSOLICITED_INPUT_PRIVILEGE 6 /* obsolete */ +#define SE_MACHINE_ACCOUNT_PRIVILEGE 6 +#define SE_TCB_PRIVILEGE 7 +#define SE_SECURITY_PRIVILEGE 8 +#define SE_TAKE_OWNERSHIP_PRIVILEGE 9 +#define SE_LOAD_DRIVER_PRIVILEGE 10 +#define SE_SYSTEM_PROFILE_PRIVILEGE 11 +#define SE_SYSTEMTIME_PRIVILEGE 12 +#define SE_PROF_SINGLE_PROCESS_PRIVILEGE 13 +#define SE_INC_BASE_PRIORITY_PRIVILEGE 14 +#define SE_CREATE_PAGEFILE_PRIVILEGE 15 +#define SE_CREATE_PERMANENT_PRIVILEGE 16 +#define SE_BACKUP_PRIVILEGE 17 +#define SE_RESTORE_PRIVILEGE 18 +#define SE_SHUTDOWN_PRIVILEGE 19 +#define SE_DEBUG_PRIVILEGE 20 +#define SE_AUDIT_PRIVILEGE 21 +#define SE_SYSTEM_ENVIRONMENT_PRIVILEGE 22 +#define SE_CHANGE_NOTIFY_PRIVILEGE 23 +#define SE_REMOTE_SHUTDOWN_PRIVILEGE 24 +#define SE_UNDOCK_PRIVILEGE 25 +#define SE_SYNC_AGENT_PRIVILEGE 26 +#define SE_ENABLE_DELEGATION_PRIVILEGE 27 +#define SE_MANAGE_VOLUME_PRIVILEGE 28 +#define SE_IMPERSONATE_PRIVILEGE 29 +#define SE_CREATE_GLOBAL_PRIVILEGE 30 #define SE_MAX_WELL_KNOWN_PRIVILEGE SE_CREATE_GLOBAL_PRIVILEGE /* NtGlobalFlag bits */

1 0

Michael Stefaniuc : include: Make "long" numeric constants LP64/ LLP64 proof (shlwapi.h).
by Alexandre Julliard Nov. 14, 2011

Nov. 14, 2011

Module: wine Branch: master Commit: 3e1ee5b8b76b68a60f604733d70ef35dc069e28e URL: http://source.winehq.org/git/wine.git/?a=commit;h=3e1ee5b8b76b68a60f604733d… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Nov 10 01:44:04 2011 +0100 include: Make "long" numeric constants LP64/LLP64 proof (shlwapi.h). --- dlls/shlwapi/string.c | 4 ++-- include/shlwapi.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/shlwapi/string.c b/dlls/shlwapi/string.c index 9578565..45b8d21 100644 --- a/dlls/shlwapi/string.c +++ b/dlls/shlwapi/string.c @@ -867,7 +867,7 @@ BOOL WINAPI StrToIntExA(LPCSTR lpszStr, DWORD dwFlags, LPINT lpiRet) } if (dwFlags > STIF_SUPPORT_HEX) { - WARN("Unknown flags (%08lX)!\n", dwFlags & ~STIF_SUPPORT_HEX); + WARN("Unknown flags (%08X)!\n", dwFlags & ~STIF_SUPPORT_HEX); } /* Skip leading space, '+', '-' */ @@ -937,7 +937,7 @@ BOOL WINAPI StrToIntExW(LPCWSTR lpszStr, DWORD dwFlags, LPINT lpiRet) } if (dwFlags > STIF_SUPPORT_HEX) { - WARN("Unknown flags (%08lX)!\n", dwFlags & ~STIF_SUPPORT_HEX); + WARN("Unknown flags (%08X)!\n", dwFlags & ~STIF_SUPPORT_HEX); } /* Skip leading space, '+', '-' */ diff --git a/include/shlwapi.h b/include/shlwapi.h index bec8b3a..2ebcdc9 100644 --- a/include/shlwapi.h +++ b/include/shlwapi.h @@ -747,8 +747,8 @@ HRESULT WINAPI ParseURLW(LPCWSTR pszUrl, PARSEDURLW *ppu); #ifndef NO_SHLWAPI_STRFCNS /* StrToIntEx flags */ -#define STIF_DEFAULT 0x0L -#define STIF_SUPPORT_HEX 0x1L +#define STIF_DEFAULT __MSABI_LONG(0x0) +#define STIF_SUPPORT_HEX __MSABI_LONG(0x1) BOOL WINAPI ChrCmpIA (WORD,WORD); BOOL WINAPI ChrCmpIW (WCHAR,WCHAR);

1 0