April 2011 - Wine-Commits - list.winehq.org

Dylan Smith : d3dxof: Add missing checks for remaining bytes during parsing .
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 555fe78766028c8c6cbdcf47135af94c45be38f7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=555fe78766028c8c6cbdcf471… Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Wed Apr 20 16:20:01 2011 -0400 d3dxof: Add missing checks for remaining bytes during parsing. --- dlls/d3dxof/parsing.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index 0acb7d6..038486a 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -337,7 +337,7 @@ static BOOL is_guid(parse_buffer* buf) DWORD tab[10]; int ret; - if (*buf->buffer != '<') + if (buf->rem_bytes < 38 || *buf->buffer != '<') return FALSE; tmp[0] = '<'; while (*(buf->buffer+pos) != '>') @@ -385,7 +385,7 @@ static BOOL is_name(parse_buffer* buf) DWORD pos = 0; char c; BOOL error = 0; - while (!is_separator(c = *(buf->buffer+pos))) + while (pos < buf->rem_bytes && !is_separator(c = *(buf->buffer+pos))) { if (!(((c >= 'a') && (c <= 'z')) || ((c >= 'A') && (c <= 'Z')) || ((c >= '0') && (c <= '9')) || (c == '_') || (c == '-'))) error = 1; @@ -416,7 +416,7 @@ static BOOL is_float(parse_buffer* buf) float decimal; BOOL dot = 0; - while (!is_separator(c = *(buf->buffer+pos))) + while (pos < buf->rem_bytes && !is_separator(c = *(buf->buffer+pos))) { if (!((!pos && (c == '-')) || ((c >= '0') && (c <= '9')) || (!dot && (c == '.')))) return FALSE; @@ -445,7 +445,7 @@ static BOOL is_integer(parse_buffer* buf) char c; DWORD integer; - while (!is_separator(c = *(buf->buffer+pos))) + while (pos < buf->rem_bytes && !is_separator(c = *(buf->buffer+pos))) { if (!((c >= '0') && (c <= '9'))) return FALSE; @@ -475,7 +475,7 @@ static BOOL is_string(parse_buffer* buf) if (*buf->buffer != '"') return FALSE; - while (!is_operator(c = *(buf->buffer+pos+1)) && (pos < 99)) + while (pos < buf->rem_bytes && !is_operator(c = *(buf->buffer+pos+1)) && (pos < 99)) { if (c == '"') {

1 0

Vincent Povirk : windowscodecs: Handle broken TIFF files without a RowsPerStrip tag.
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: a08aa5391ec2674c341cfbbae318218b605af9ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=a08aa5391ec2674c341cfbbae… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 21 01:17:07 2011 -0500 windowscodecs: Handle broken TIFF files without a RowsPerStrip tag. --- dlls/windowscodecs/tiffformat.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/tiffformat.c b/dlls/windowscodecs/tiffformat.c index 5bce3ad..88dbc79 100644 --- a/dlls/windowscodecs/tiffformat.c +++ b/dlls/windowscodecs/tiffformat.c @@ -462,8 +462,11 @@ static HRESULT tiff_get_decode_info(TIFF *tiff, tiff_decode_info *decode_info) } else { - FIXME("missing RowsPerStrip value\n"); - return E_FAIL; + /* Some broken TIFF files have a single strip and lack the RowsPerStrip tag */ + decode_info->tile_height = decode_info->height; + decode_info->tile_width = decode_info->width; + decode_info->tile_stride = ((decode_info->bpp * decode_info->tile_width + 7)/8); + decode_info->tile_size = decode_info->tile_height * decode_info->tile_stride; } decode_info->resolution_unit = 0;

1 0

Nicolas Le Cam : dxdiagn/tests: Initialize a variable and reduce its scope (valgrind).
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 66b11a00b5b8ab9b1e126e61ae136af0c0bef450 URL: http://source.winehq.org/git/wine.git/?a=commit;h=66b11a00b5b8ab9b1e126e61a… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Thu Apr 21 02:50:54 2011 +0200 dxdiagn/tests: Initialize a variable and reduce its scope (valgrind). --- dlls/dxdiagn/tests/container.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/dxdiagn/tests/container.c b/dlls/dxdiagn/tests/container.c index 6de80e7..c7bd2bb 100644 --- a/dlls/dxdiagn/tests/container.c +++ b/dlls/dxdiagn/tests/container.c @@ -840,7 +840,6 @@ static void test_DxDiag_SystemInfo(void) HRESULT hr; IDxDiagContainer *child = NULL; - VARIANT var; if (!create_root_IDxDiagContainer()) { @@ -854,6 +853,9 @@ static void test_DxDiag_SystemInfo(void) if (hr == S_OK) { int i; + VARIANT var; + + VariantInit(&var); /* Examine the variant types of obtained property values. */ for (i = 0; i < sizeof(property_tests)/sizeof(property_tests[0]); i++)

1 0

Henri Verbeet : ddraw: Destroy the ddraw surface after the wined3d texture is destroyed.
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 03b388609d0f9aef1eb657ed6b8320682204b39b URL: http://source.winehq.org/git/wine.git/?a=commit;h=03b388609d0f9aef1eb657ed6… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 20 22:09:27 2011 +0200 ddraw: Destroy the ddraw surface after the wined3d texture is destroyed. --- dlls/ddraw/surface.c | 34 ++++++++++++++++++++++++++-------- 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 16b831a..84082c5 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -180,10 +180,13 @@ static ULONG WINAPI ddraw_surface7_AddRef(IDirectDrawSurface7 *iface) TRACE("%p increasing refcount to %u.\n", This, refCount); - if (refCount == 1 && This->WineD3DSurface) + if (refCount == 1) { EnterCriticalSection(&ddraw_cs); - IWineD3DSurface_AddRef(This->WineD3DSurface); + if (This->WineD3DSurface) + IWineD3DSurface_AddRef(This->WineD3DSurface); + if (This->wined3d_texture) + wined3d_texture_incref(This->wined3d_texture); LeaveCriticalSection(&ddraw_cs); } @@ -256,9 +259,7 @@ static void ddraw_surface_cleanup(IDirectDrawSurfaceImpl *surface) TRACE("surface %p.\n", surface); - if (surface->wined3d_texture) /* If it's a texture, destroy the wined3d texture. */ - wined3d_texture_decref(surface->wined3d_texture); - else if (surface->wined3d_swapchain) + if (surface->wined3d_swapchain) { IDirectDrawImpl *ddraw = surface->ddraw; @@ -388,7 +389,10 @@ static ULONG WINAPI ddraw_surface7_Release(IDirectDrawSurface7 *iface) LeaveCriticalSection(&ddraw_cs); return ref; } - ddraw_surface_cleanup(This); + if (This->wined3d_texture) /* If it's a texture, destroy the wined3d texture. */ + wined3d_texture_decref(This->wined3d_texture); + else + ddraw_surface_cleanup(This); LeaveCriticalSection(&ddraw_cs); } @@ -3491,6 +3495,20 @@ const struct wined3d_parent_ops ddraw_surface_wined3d_parent_ops = ddraw_surface_wined3d_object_destroyed, }; +static void STDMETHODCALLTYPE ddraw_texture_wined3d_object_destroyed(void *parent) +{ + IDirectDrawSurfaceImpl *surface = parent; + + TRACE("surface %p.\n", surface); + + ddraw_surface_cleanup(surface); +} + +static const struct wined3d_parent_ops ddraw_texture_wined3d_parent_ops = +{ + ddraw_texture_wined3d_object_destroyed, +}; + HRESULT ddraw_surface_create_texture(IDirectDrawSurfaceImpl *surface) { const DDSURFACEDESC2 *desc = &surface->surface_desc; @@ -3513,10 +3531,10 @@ HRESULT ddraw_surface_create_texture(IDirectDrawSurfaceImpl *surface) format = PixelFormat_DD2WineD3D(&surface->surface_desc.u4.ddpfPixelFormat); if (desc->ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP) return IWineD3DDevice_CreateCubeTexture(surface->ddraw->wineD3DDevice, desc->dwWidth, - levels, 0, format, pool, surface, &ddraw_null_wined3d_parent_ops, &surface->wined3d_texture); + levels, 0, format, pool, surface, &ddraw_texture_wined3d_parent_ops, &surface->wined3d_texture); else return IWineD3DDevice_CreateTexture(surface->ddraw->wineD3DDevice, desc->dwWidth, desc->dwHeight, - levels, 0, format, pool, surface, &ddraw_null_wined3d_parent_ops, &surface->wined3d_texture); + levels, 0, format, pool, surface, &ddraw_texture_wined3d_parent_ops, &surface->wined3d_texture); } HRESULT ddraw_surface_init(IDirectDrawSurfaceImpl *surface, IDirectDrawImpl *ddraw,

1 0

Henri Verbeet : wined3d: Get rid of the mipmap hint code.
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: f6e4f4a1221f98dd07a6bda98edf433913d35597 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6e4f4a1221f98dd07a6bda98… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 20 22:09:23 2011 +0200 wined3d: Get rid of the mipmap hint code. Mipmap hint isn't a texture parameter, but a global hint. This never worked, it just causes GL errors. --- dlls/wined3d/texture.c | 35 +---------------------------------- 1 files changed, 1 insertions(+), 34 deletions(-) diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c index fcd341d..cb2c41d 100644 --- a/dlls/wined3d/texture.c +++ b/dlls/wined3d/texture.c @@ -544,7 +544,7 @@ DWORD CDECL wined3d_texture_get_level_count(const struct wined3d_texture *textur HRESULT CDECL wined3d_texture_set_autogen_filter_type(struct wined3d_texture *texture, WINED3DTEXTUREFILTERTYPE filter_type) { - TRACE("texture %p, filter_type %s.\n", texture, debug_d3dtexturefiltertype(filter_type)); + FIXME("texture %p, filter_type %s stub!\n", texture, debug_d3dtexturefiltertype(filter_type)); if (!(texture->resource.usage & WINED3DUSAGE_AUTOGENMIPMAP)) { @@ -552,39 +552,6 @@ HRESULT CDECL wined3d_texture_set_autogen_filter_type(struct wined3d_texture *te return WINED3DERR_INVALIDCALL; } - if (texture->filter_type != filter_type) - { - GLenum target = texture->target; - struct wined3d_context *context; - - context = context_acquire(texture->resource.device, NULL); - - ENTER_GL(); - glBindTexture(target, texture->texture_rgb.name); - checkGLcall("glBindTexture"); - switch (filter_type) - { - case WINED3DTEXF_NONE: - case WINED3DTEXF_POINT: - glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_FASTEST); - checkGLcall("glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_FASTEST)"); - break; - - case WINED3DTEXF_LINEAR: - glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST); - checkGLcall("glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST)"); - break; - - default: - WARN("Unexpected filter type %#x, setting to GL_NICEST.\n", filter_type); - glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST); - checkGLcall("glTexParameteri(target, GL_GENERATE_MIPMAP_HINT_SGIS, GL_NICEST)"); - break; - } - LEAVE_GL(); - - context_release(context); - } texture->filter_type = filter_type; return WINED3D_OK;

1 0

Rico Schüller : d3dx9: Implement ID3DXBaseEffect:: GetParameterElement().
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: f296fe68fffab418c6ccf2e0e2851f03ab2974b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f296fe68fffab418c6ccf2e0e… Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Apr 20 21:55:43 2011 +0200 d3dx9: Implement ID3DXBaseEffect::GetParameterElement(). --- dlls/d3dx9_36/effect.c | 24 +++++++++++++++++++++++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 07ebd1f..67d0698 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -801,8 +801,30 @@ static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetParameterBySemantic(ID3DXBaseEff static D3DXHANDLE WINAPI ID3DXBaseEffectImpl_GetParameterElement(ID3DXBaseEffect *iface, D3DXHANDLE parameter, UINT index) { struct ID3DXBaseEffectImpl *This = impl_from_ID3DXBaseEffect(iface); + struct d3dx_parameter *param = is_valid_parameter(This, parameter); + + TRACE("iface %p, parameter %p, index %u\n", This, parameter, index); + + if (!param) param = get_parameter_by_name(This, NULL, parameter, FALSE); + + if (!param) + { + if (index < This->parameter_count) + { + TRACE("Returning parameter %p\n", This->parameter_handles[index]); + return This->parameter_handles[index]; + } + } + else + { + if (index < param->element_count) + { + TRACE("Returning parameter %p\n", param->member_handles[index]); + return param->member_handles[index]; + } + } - FIXME("iface %p, parameter %p, index %u stub\n", This, parameter, index); + WARN("Invalid argument specified\n"); return NULL; }

1 0

Henri Verbeet : ddraw: Add a separate function for surface cleanup.
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 25c0941e507244e8514517aefaf81df804137c72 URL: http://source.winehq.org/git/wine.git/?a=commit;h=25c0941e507244e8514517aef… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 20 22:09:24 2011 +0200 ddraw: Add a separate function for surface cleanup. --- dlls/ddraw/surface.c | 193 ++++++++++++++++++++++++------------------------- 1 files changed, 95 insertions(+), 98 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 40fd797..531e529 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -293,6 +293,100 @@ void ddraw_surface_destroy(IDirectDrawSurfaceImpl *This) HeapFree(GetProcessHeap(), 0, This); } +static void ddraw_surface_cleanup(IDirectDrawSurfaceImpl *surface) +{ + IDirectDrawSurfaceImpl *surf; + IUnknown *ifaceToRelease; + UINT i; + + TRACE("surface %p.\n", surface); + + if (surface->wined3d_texture) /* If it's a texture, destroy the wined3d texture. */ + wined3d_texture_decref(surface->wined3d_texture); + else if (surface->wined3d_swapchain) + { + IDirectDrawImpl *ddraw = surface->ddraw; + + /* If it's the render target, destroy the D3D device. */ + if (ddraw->d3d_initialized && surface == ddraw->d3d_target) + { + TRACE("Destroying the render target, uninitializing D3D.\n"); + + for (i = 0; i < ddraw->numConvertedDecls; ++i) + { + wined3d_vertex_declaration_decref(ddraw->decls[i].decl); + } + HeapFree(GetProcessHeap(), 0, ddraw->decls); + ddraw->numConvertedDecls = 0; + + if (FAILED(IWineD3DDevice_Uninit3D(ddraw->wineD3DDevice))) + { + ERR("Failed to uninit 3D.\n"); + } + else + { + /* Free the d3d window if one was created. */ + if (ddraw->d3d_window && ddraw->d3d_window != ddraw->dest_window) + { + TRACE("Destroying the hidden render window %p.\n", ddraw->d3d_window); + DestroyWindow(ddraw->d3d_window); + ddraw->d3d_window = 0; + } + } + + ddraw->d3d_initialized = FALSE; + ddraw->d3d_target = NULL; + } + else + { + IWineD3DDevice_UninitGDI(ddraw->wineD3DDevice); + } + + surface->wined3d_swapchain = NULL; + + /* Reset to the default surface implementation type. This is needed + * if applications use non render target surfaces and expect blits to + * work after destroying the render target. + * + * TODO: Recreate existing offscreen surfaces. */ + ddraw->ImplType = DefaultSurfaceType; + + TRACE("D3D unloaded.\n"); + } + + /* The refcount test shows that the palette is detached when the surface + * is destroyed. */ + IDirectDrawSurface7_SetPalette((IDirectDrawSurface7 *)surface, NULL); + + /* Loop through all complex attached surfaces and destroy them. + * + * Yet again, only the root can have more than one complexly attached + * surface, all the others have a total of one. */ + for (i = 0; i < MAX_COMPLEX_ATTACHED; ++i) + { + if (!surface->complex_array[i]) + break; + + surf = surface->complex_array[i]; + surface->complex_array[i] = NULL; + while (surf) + { + IDirectDrawSurfaceImpl *destroy = surf; + surf = surf->complex_array[0]; /* Iterate through the "tree" */ + ddraw_surface_destroy(destroy); /* Destroy it */ + } + } + + ifaceToRelease = surface->ifaceToRelease; + + /* Destroy the root surface. */ + ddraw_surface_destroy(surface); + + /* Reduce the ddraw refcount */ + if (ifaceToRelease) + IUnknown_Release(ifaceToRelease); +} + /***************************************************************************** * IDirectDrawSurface7::Release * @@ -331,12 +425,6 @@ static ULONG WINAPI ddraw_surface7_Release(IDirectDrawSurface7 *iface) if (ref == 0) { - - IDirectDrawSurfaceImpl *surf; - IDirectDrawImpl *ddraw; - IUnknown *ifaceToRelease = This->ifaceToRelease; - UINT i; - /* Complex attached surfaces are destroyed implicitly when the root is released */ EnterCriticalSection(&ddraw_cs); if(!This->is_complex_root) @@ -345,98 +433,7 @@ static ULONG WINAPI ddraw_surface7_Release(IDirectDrawSurface7 *iface) LeaveCriticalSection(&ddraw_cs); return ref; } - ddraw = This->ddraw; - - /* If it's a texture, destroy the WineD3DTexture. - * WineD3D will destroy the IParent interfaces - * of the sublevels, which destroys the WineD3DSurfaces. - * Set the surfaces to NULL to avoid destroying them again later - */ - if (This->wined3d_texture) - wined3d_texture_decref(This->wined3d_texture); - - /* If it's the RenderTarget, destroy the d3ddevice */ - else if (This->wined3d_swapchain) - { - if((ddraw->d3d_initialized) && (This == ddraw->d3d_target)) { - TRACE("(%p) Destroying the render target, uninitializing D3D\n", This); - - for (i = 0; i < ddraw->numConvertedDecls; ++i) - { - wined3d_vertex_declaration_decref(ddraw->decls[i].decl); - } - HeapFree(GetProcessHeap(), 0, ddraw->decls); - ddraw->numConvertedDecls = 0; - - if (FAILED(IWineD3DDevice_Uninit3D(ddraw->wineD3DDevice))) - { - /* Not good */ - ERR("(%p) Failed to uninit 3D\n", This); - } - else - { - /* Free the d3d window if one was created */ - if(ddraw->d3d_window != 0 && ddraw->d3d_window != ddraw->dest_window) - { - TRACE(" (%p) Destroying the hidden render window %p\n", This, ddraw->d3d_window); - DestroyWindow(ddraw->d3d_window); - ddraw->d3d_window = 0; - } - /* Unset the pointers */ - } - - This->wined3d_swapchain = NULL; /* Uninit3D releases the swapchain */ - ddraw->d3d_initialized = FALSE; - ddraw->d3d_target = NULL; - } - else - { - IWineD3DDevice_UninitGDI(ddraw->wineD3DDevice); - This->wined3d_swapchain = NULL; - } - - /* Reset to the default surface implementation type. This is needed if apps use - * non render target surfaces and expect blits to work after destroying the render - * target. - * - * TODO: Recreate existing offscreen surfaces - */ - ddraw->ImplType = DefaultSurfaceType; - - /* Write a trace because D3D unloading was the reason for many - * crashes during development. - */ - TRACE("(%p) D3D unloaded\n", This); - } - - /* The refcount test shows that the palette is detached when the surface is destroyed */ - IDirectDrawSurface7_SetPalette((IDirectDrawSurface7 *)This, NULL); - - /* Loop through all complex attached surfaces, - * and destroy them. - * - * Yet again, only the root can have more than one complexly attached surface, all the others - * have a total of one; - */ - for(i = 0; i < MAX_COMPLEX_ATTACHED; i++) - { - if(!This->complex_array[i]) break; - - surf = This->complex_array[i]; - This->complex_array[i] = NULL; - while(surf) - { - IDirectDrawSurfaceImpl *destroy = surf; - surf = surf->complex_array[0]; /* Iterate through the "tree" */ - ddraw_surface_destroy(destroy); /* Destroy it */ - } - } - - /* Destroy the root surface. */ - ddraw_surface_destroy(This); - - /* Reduce the ddraw refcount */ - if(ifaceToRelease) IUnknown_Release(ifaceToRelease); + ddraw_surface_cleanup(This); LeaveCriticalSection(&ddraw_cs); }

1 0

Henri Verbeet : ddraw: Release the wined3d surface first in ddraw_surface_destroy().
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: cbf78c5d4921192a7d5022f5bb2663b5833cff4e URL: http://source.winehq.org/git/wine.git/?a=commit;h=cbf78c5d4921192a7d5022f5b… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 20 22:09:25 2011 +0200 ddraw: Release the wined3d surface first in ddraw_surface_destroy(). --- dlls/ddraw/surface.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 531e529..0105848 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -244,6 +244,9 @@ void ddraw_surface_destroy(IDirectDrawSurfaceImpl *This) WARN("(%p): Destroying surface with refount %d\n", This, This->ref); } + if (This->WineD3DSurface) + IWineD3DSurface_Release(This->WineD3DSurface); + /* Check for attached surfaces and detach them */ if(This->first_attached != This) { @@ -276,10 +279,6 @@ void ddraw_surface_destroy(IDirectDrawSurfaceImpl *This) } } - /* Now destroy the surface. Wait: It could have been released if we are a texture */ - if(This->WineD3DSurface) - IWineD3DSurface_Release(This->WineD3DSurface); - /* Having a texture handle set implies that the device still exists */ if(This->Handle) {

1 0

Henri Verbeet : ddraw: Destroy the ddraw surface after the wined3d surface is destroyed.
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 6ff226f502c8a0fd4e3d9307e3070b6a960f756e URL: http://source.winehq.org/git/wine.git/?a=commit;h=6ff226f502c8a0fd4e3d9307e… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 20 22:09:26 2011 +0200 ddraw: Destroy the ddraw surface after the wined3d surface is destroyed. --- dlls/ddraw/ddraw.c | 2 +- dlls/ddraw/ddraw_private.h | 1 + dlls/ddraw/surface.c | 95 +++++++++++++++++++++++--------------------- 3 files changed, 52 insertions(+), 46 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index c2ea683..564f2f3 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -2548,7 +2548,7 @@ HRESULT WINAPI ddraw_recreate_surfaces_cb(IDirectDrawSurface7 *surf, DDSURFACEDE hr = IWineD3DDevice_CreateSurface(This->wineD3DDevice, wined3d_desc.width, wined3d_desc.height, wined3d_desc.format, TRUE, FALSE, surfImpl->mipmap_level, wined3d_desc.usage, wined3d_desc.pool, wined3d_desc.multisample_type, wined3d_desc.multisample_quality, This->ImplType, - parent, &ddraw_null_wined3d_parent_ops, &surfImpl->WineD3DSurface); + parent, &ddraw_surface_wined3d_parent_ops, &surfImpl->WineD3DSurface); if (FAILED(hr)) { surfImpl->WineD3DSurface = wineD3DSurface; diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index 988d127..e75e4bc 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -37,6 +37,7 @@ #include "wine/list.h" #include "wine/wined3d.h" +extern const struct wined3d_parent_ops ddraw_surface_wined3d_parent_ops DECLSPEC_HIDDEN; extern const struct wined3d_parent_ops ddraw_null_wined3d_parent_ops DECLSPEC_HIDDEN; /* Typdef the interfaces */ diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 0105848..16b831a 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -246,50 +246,6 @@ void ddraw_surface_destroy(IDirectDrawSurfaceImpl *This) if (This->WineD3DSurface) IWineD3DSurface_Release(This->WineD3DSurface); - - /* Check for attached surfaces and detach them */ - if(This->first_attached != This) - { - /* Well, this shouldn't happen: The surface being attached is addref()ed - * in AddAttachedSurface, so it shouldn't be released until DeleteAttachedSurface - * is called, because the refcount is held. It looks like the app released() - * it often enough to force this - */ - IDirectDrawSurface7 *root = (IDirectDrawSurface7 *)This->first_attached; - IDirectDrawSurface7 *detach = (IDirectDrawSurface7 *)This; - - FIXME("(%p) Freeing a surface that is attached to surface %p\n", This, This->first_attached); - - /* The refcount will drop to -1 here */ - if(IDirectDrawSurface7_DeleteAttachedSurface(root, 0, detach) != DD_OK) - { - ERR("(%p) DeleteAttachedSurface failed!\n", This); - } - } - - while(This->next_attached != NULL) - { - IDirectDrawSurface7 *root = (IDirectDrawSurface7 *)This; - IDirectDrawSurface7 *detach = (IDirectDrawSurface7 *)This->next_attached; - - if(IDirectDrawSurface7_DeleteAttachedSurface(root, 0, detach) != DD_OK) - { - ERR("(%p) DeleteAttachedSurface failed!\n", This); - assert(0); - } - } - - /* Having a texture handle set implies that the device still exists */ - if(This->Handle) - { - ddraw_free_handle(&This->ddraw->d3ddevice->handle_table, This->Handle - 1, DDRAW_HANDLE_SURFACE); - } - - /* Reduce the ddraw surface count */ - InterlockedDecrement(&This->ddraw->surfaces); - list_remove(&This->surface_list_entry); - - HeapFree(GetProcessHeap(), 0, This); } static void ddraw_surface_cleanup(IDirectDrawSurfaceImpl *surface) @@ -3486,6 +3442,55 @@ static const struct IDirect3DTextureVtbl d3d_texture1_vtbl = d3d_texture1_Unload, }; +static void STDMETHODCALLTYPE ddraw_surface_wined3d_object_destroyed(void *parent) +{ + IDirectDrawSurfaceImpl *surface = parent; + + TRACE("surface %p.\n", surface); + + /* Check for attached surfaces and detach them. */ + if (surface->first_attached != surface) + { + IDirectDrawSurface7 *root = (IDirectDrawSurface7 *)surface->first_attached; + IDirectDrawSurface7 *detach = (IDirectDrawSurface7 *)surface; + + /* Well, this shouldn't happen: The surface being attached is + * referenced in AddAttachedSurface(), so it shouldn't be released + * until DeleteAttachedSurface() is called, because the refcount is + * held. It looks like the application released it often enough to + * force this. */ + WARN("Surface is still attached to surface %p.\n", surface->first_attached); + + /* The refcount will drop to -1 here */ + if (FAILED(IDirectDrawSurface7_DeleteAttachedSurface(root, 0, detach))) + ERR("DeleteAttachedSurface failed.\n"); + } + + while (surface->next_attached) + { + IDirectDrawSurface7 *root = (IDirectDrawSurface7 *)surface; + IDirectDrawSurface7 *detach = (IDirectDrawSurface7 *)surface->next_attached; + + if (FAILED(IDirectDrawSurface7_DeleteAttachedSurface(root, 0, detach))) + ERR("DeleteAttachedSurface failed.\n"); + } + + /* Having a texture handle set implies that the device still exists. */ + if (surface->Handle) + ddraw_free_handle(&surface->ddraw->d3ddevice->handle_table, surface->Handle - 1, DDRAW_HANDLE_SURFACE); + + /* Reduce the ddraw surface count. */ + InterlockedDecrement(&surface->ddraw->surfaces); + list_remove(&surface->surface_list_entry); + + HeapFree(GetProcessHeap(), 0, surface); +} + +const struct wined3d_parent_ops ddraw_surface_wined3d_parent_ops = +{ + ddraw_surface_wined3d_object_destroyed, +}; + HRESULT ddraw_surface_create_texture(IDirectDrawSurfaceImpl *surface) { const DDSURFACEDESC2 *desc = &surface->surface_desc; @@ -3599,7 +3604,7 @@ HRESULT ddraw_surface_init(IDirectDrawSurfaceImpl *surface, IDirectDrawImpl *ddr hr = IWineD3DDevice_CreateSurface(ddraw->wineD3DDevice, desc->dwWidth, desc->dwHeight, format, TRUE /* Lockable */, FALSE /* Discard */, mip_level, usage, pool, WINED3DMULTISAMPLE_NONE, 0 /* MultiSampleQuality */, surface_type, surface, - &ddraw_null_wined3d_parent_ops, &surface->WineD3DSurface); + &ddraw_surface_wined3d_parent_ops, &surface->WineD3DSurface); if (FAILED(hr)) { WARN("Failed to create wined3d surface, hr %#x.\n", hr);

1 0

Rico Schüller : d3dx9: Implement ID3DXBaseEffect:: GetParameterDesc().
by Alexandre Julliard April 21, 2011

April 21, 2011

Module: wine Branch: master Commit: 1ae414bc649ce517ed47701f28a82048681d3b7f URL: http://source.winehq.org/git/wine.git/?a=commit;h=1ae414bc649ce517ed47701f2… Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Apr 20 21:55:41 2011 +0200 d3dx9: Implement ID3DXBaseEffect::GetParameterDesc(). --- dlls/d3dx9_36/effect.c | 25 +++++++++++++++++++++++-- 1 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 30f533f..07ebd1f 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -657,10 +657,31 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_GetDesc(ID3DXBaseEffect *iface, D3DXEF static HRESULT WINAPI ID3DXBaseEffectImpl_GetParameterDesc(ID3DXBaseEffect *iface, D3DXHANDLE parameter, D3DXPARAMETER_DESC *desc) { struct ID3DXBaseEffectImpl *This = impl_from_ID3DXBaseEffect(iface); + struct d3dx_parameter *param = is_valid_parameter(This, parameter); - FIXME("iface %p, parameter %p, desc %p stub\n", This, parameter, desc); + TRACE("iface %p, parameter %p, desc %p\n", This, parameter, desc); - return E_NOTIMPL; + if (!param) param = get_parameter_struct(iface->lpVtbl->GetParameterByName(iface, NULL, parameter)); + + if (!desc || !param) + { + WARN("Invalid argument specified.\n"); + return D3DERR_INVALIDCALL; + } + + desc->Name = param->name; + desc->Semantic = param->semantic; + desc->Class = param->class; + desc->Type = param->type; + desc->Rows = param->rows; + desc->Columns = param->columns; + desc->Elements = param->element_count; + desc->Annotations = param->annotation_count; + desc->StructMembers = param->member_count; + desc->Flags = param->flags; + desc->Bytes = param->bytes; + + return D3D_OK; } static HRESULT WINAPI ID3DXBaseEffectImpl_GetTechniqueDesc(ID3DXBaseEffect *iface, D3DXHANDLE technique, D3DXTECHNIQUE_DESC *desc)

1 0