May 2011 - Wine-Commits - list.winehq.org

Piotr Caban : msvcr90/tests: Don't check if msvcr90 functions exists.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 696ba80347a12fe6c15b349bd77e5822bf41c6e6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=696ba80347a12fe6c15b349bd… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:23:34 2011 +0200 msvcr90/tests: Don't check if msvcr90 functions exists. --- dlls/msvcr90/tests/msvcr90.c | 202 ++++++++++++------------------------------ 1 files changed, 57 insertions(+), 145 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=696ba80347a12fe6c15b3…

1 0

Alexandre Julliard : widl: Call marshalling routines directly also for user-marshalled types accessed through a ref pointer .
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 2099d9400188b320a6ae7bb1a69a14912fe4456b URL: http://source.winehq.org/git/wine.git/?a=commit;h=2099d9400188b320a6ae7bb1a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue May 24 23:10:48 2011 +0200 widl: Call marshalling routines directly also for user-marshalled types accessed through a ref pointer. --- tools/widl/typegen.c | 42 +++++++++++++++++++++++------------------- 1 files changed, 23 insertions(+), 19 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 324211e..687bf53 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -3536,6 +3536,7 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const enum pass pass, enum remoting_phase phase, const var_t *var) { int in_attr, out_attr, pointer_type; + const char *type_str = NULL; const type_t *type = var->type; unsigned int alignment, start_offset = type->typestring_offset; @@ -3785,8 +3786,6 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const print_phase_function(file, indent, "Pointer", local_var_prefix, phase, var, start_offset); break; case TGT_STRUCT: - { - const char *struct_type = NULL; switch (get_struct_fc(ref)) { case RPC_FC_STRUCT: @@ -3794,7 +3793,7 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const * pass and don't have any memory to free and so don't * need a freeing pass */ if (phase == PHASE_MARSHAL || phase == PHASE_UNMARSHAL) - struct_type = "SimpleStruct"; + type_str = "SimpleStruct"; else if (phase == PHASE_FREE && pass == PASS_RETURN) { print_file(file, indent, "if (%s%s)\n", local_var_prefix, var->name); @@ -3804,57 +3803,62 @@ static void write_remoting_arg(FILE *file, int indent, const var_t *func, const } break; case RPC_FC_PSTRUCT: - struct_type = "SimpleStruct"; + type_str = "SimpleStruct"; break; case RPC_FC_CSTRUCT: case RPC_FC_CPSTRUCT: - struct_type = "ConformantStruct"; + type_str = "ConformantStruct"; break; case RPC_FC_CVSTRUCT: - struct_type = "ConformantVaryingStruct"; + type_str = "ConformantVaryingStruct"; break; case RPC_FC_BOGUS_STRUCT: - struct_type = "ComplexStruct"; + type_str = "ComplexStruct"; break; default: error("write_remoting_arguments: Unsupported type: %s (0x%02x)\n", var->name, get_struct_fc(ref)); } - if (struct_type) + if (type_str) { if (phase == PHASE_FREE) - struct_type = "Pointer"; + type_str = "Pointer"; else start_offset = ref->typestring_offset; - print_phase_function(file, indent, struct_type, local_var_prefix, phase, var, start_offset); + print_phase_function(file, indent, type_str, local_var_prefix, phase, var, start_offset); } break; - } case TGT_UNION: - { - const char *union_type = NULL; if (phase == PHASE_FREE) - union_type = "Pointer"; + type_str = "Pointer"; else { if (type_get_type(ref) == TYPE_UNION) - union_type = "NonEncapsulatedUnion"; + type_str = "NonEncapsulatedUnion"; else if (type_get_type(ref) == TYPE_ENCAPSULATED_UNION) - union_type = "EncapsulatedUnion"; + type_str = "EncapsulatedUnion"; start_offset = ref->typestring_offset; } - print_phase_function(file, indent, union_type, local_var_prefix, + print_phase_function(file, indent, type_str, local_var_prefix, phase, var, start_offset); break; - } + case TGT_USER_TYPE: + if (phase != PHASE_FREE) + { + type_str = "UserMarshal"; + start_offset = ref->typestring_offset; + } + else type_str = "Pointer"; + + print_phase_function(file, indent, type_str, local_var_prefix, phase, var, start_offset); + break; case TGT_STRING: case TGT_POINTER: case TGT_ARRAY: case TGT_RANGE: case TGT_IFACE_POINTER: - case TGT_USER_TYPE: case TGT_CTXT_HANDLE: case TGT_CTXT_HANDLE_POINTER: print_phase_function(file, indent, "Pointer", local_var_prefix, phase, var, start_offset);

1 0

Alexandre Julliard : widl: Return the buffer size of the object pointed by a ref pointer for all types .
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 8f156e266ef0ac766fecadc7e82a2b215d4cf89c URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f156e266ef0ac766fecadc7e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue May 24 23:13:47 2011 +0200 widl: Return the buffer size of the object pointed by a ref pointer for all types. --- tools/widl/typegen.c | 25 +++---------------------- 1 files changed, 3 insertions(+), 22 deletions(-) diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c index 687bf53..f6bb2f9 100644 --- a/tools/widl/typegen.c +++ b/tools/widl/typegen.c @@ -3111,7 +3111,7 @@ static unsigned int get_required_buffer_size_type( const type_t *type, const char *name, const attr_list_t *attrs, int toplevel_param, unsigned int *alignment) { *alignment = 0; - switch (typegen_detect_type(type, NULL, TDT_IGNORE_STRINGS|TDT_IGNORE_RANGES)) + switch (typegen_detect_type(type, NULL, TDT_IGNORE_RANGES)) { case TGT_USER_TYPE: { @@ -3188,27 +3188,8 @@ static unsigned int get_required_buffer_size_type( if (get_pointer_fc(type, attrs, toplevel_param) == RPC_FC_RP) { const type_t *ref = type_pointer_get_ref(type); - switch (typegen_detect_type(ref, NULL, TDT_ALL_TYPES)) - { - case TGT_BASIC: - case TGT_ENUM: - case TGT_RANGE: - return get_required_buffer_size_type( ref, name, NULL, FALSE, alignment ); - case TGT_STRUCT: - if (get_struct_fc(ref) == RPC_FC_STRUCT) - return get_required_buffer_size_type( ref, name, NULL, FALSE, alignment ); - break; - case TGT_USER_TYPE: - case TGT_CTXT_HANDLE: - case TGT_CTXT_HANDLE_POINTER: - case TGT_STRING: - case TGT_POINTER: - case TGT_ARRAY: - case TGT_IFACE_POINTER: - case TGT_UNION: - case TGT_INVALID: - break; - } + if (is_string_type( attrs, ref )) break; + return get_required_buffer_size_type( ref, name, ref->attrs, FALSE, alignment ); } break;

1 0

Piotr Caban : msvcrt: Change the way how localtime/ gmtime buffer is stored in __thread_data.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 12229aeeb28b55add3356e3fe17924319f014a54 URL: http://source.winehq.org/git/wine.git/?a=commit;h=12229aeeb28b55add3356e3fe… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:22:54 2011 +0200 msvcrt: Change the way how localtime/gmtime buffer is stored in __thread_data. --- dlls/msvcrt/main.c | 1 + dlls/msvcrt/msvcrt.h | 2 +- dlls/msvcrt/time.c | 14 ++++++++++---- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dlls/msvcrt/main.c b/dlls/msvcrt/main.c index e6c21f5..902fb64 100644 --- a/dlls/msvcrt/main.c +++ b/dlls/msvcrt/main.c @@ -73,6 +73,7 @@ static inline void msvcrt_free_tls_mem(void) HeapFree(GetProcessHeap(),0,tls->wasctime_buffer); HeapFree(GetProcessHeap(),0,tls->strerror_buffer); HeapFree(GetProcessHeap(),0,tls->wcserror_buffer); + HeapFree(GetProcessHeap(),0,tls->time_buffer); free_locinfo(tls->locinfo); free_mbcinfo(tls->mbcinfo); } diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 9b8ac38..90056ba 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -172,7 +172,7 @@ struct __thread_data { void *unk2[4]; char *asctime_buffer; /* buffer for asctime */ MSVCRT_wchar_t *wasctime_buffer; /* buffer for wasctime */ - struct MSVCRT_tm time_buffer; /* buffer for localtime/gmtime */ + struct MSVCRT_tm *time_buffer; /* buffer for localtime/gmtime */ char *efcvt_buffer; /* buffer for ecvt/fcvt */ int unk3[2]; void *unk4[4]; diff --git a/dlls/msvcrt/time.c b/dlls/msvcrt/time.c index 9dc2a3e..0aa1e58 100644 --- a/dlls/msvcrt/time.c +++ b/dlls/msvcrt/time.c @@ -212,10 +212,13 @@ struct MSVCRT_tm* CDECL MSVCRT__localtime64(const MSVCRT___time64_t* secs) } data = msvcrt_get_thread_data(); - unix_tm_to_msvcrt( &data->time_buffer, tm ); + if(!data->time_buffer) + data->time_buffer = MSVCRT_malloc(sizeof(struct MSVCRT_tm)); + + unix_tm_to_msvcrt( data->time_buffer, tm ); _munlock(_TIME_LOCK); - return &data->time_buffer; + return data->time_buffer; } /********************************************************************* @@ -344,9 +347,12 @@ struct MSVCRT_tm* CDECL MSVCRT__gmtime64(const MSVCRT___time64_t *secs) { thread_data_t * const data = msvcrt_get_thread_data(); - if(MSVCRT__gmtime64_s(&data->time_buffer, secs)) + if(!data->time_buffer) + data->time_buffer = MSVCRT_malloc(sizeof(struct MSVCRT_tm)); + + if(MSVCRT__gmtime64_s(data->time_buffer, secs)) return NULL; - return &data->time_buffer; + return data->time_buffer; } /*********************************************************************

1 0

Piotr Caban : msvcrt: Use _create_locale instead of setlocale during initialization.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 11bfced55d7a480248b01d9a8cfed73f74e50280 URL: http://source.winehq.org/git/wine.git/?a=commit;h=11bfced55d7a480248b01d9a8… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:22:23 2011 +0200 msvcrt: Use _create_locale instead of setlocale during initialization. --- dlls/msvcrt/locale.c | 74 +++++++++++++++++++++++++------------------------- dlls/msvcrt/main.c | 2 +- dlls/msvcrt/msvcrt.h | 2 +- 3 files changed, 39 insertions(+), 39 deletions(-) diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index 7da61d8..002a38b 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -1079,43 +1079,6 @@ MSVCRT__locale_t MSVCRT__create_locale(int category, const char *locale) return loc; } -/* _configthreadlocale - not exported in native msvcrt */ -int CDECL _configthreadlocale(int type) -{ - thread_data_t *data = msvcrt_get_thread_data(); - int ret; - - if(!data) - return -1; - - ret = (data->locale ? MSVCRT__ENABLE_PER_THREAD_LOCALE : MSVCRT__DISABLE_PER_THREAD_LOCALE); - - if(type == MSVCRT__ENABLE_PER_THREAD_LOCALE) { - if(!data->locale) { - /* Copy current global locale */ - data->locale = MSVCRT__create_locale(MSVCRT_LC_ALL, MSVCRT_setlocale(MSVCRT_LC_ALL, NULL)); - if(!data->locale) - return -1; - } - - return ret; - } - - if(type == MSVCRT__DISABLE_PER_THREAD_LOCALE) { - if(data->locale) { - MSVCRT__free_locale(data->locale); - data->locale = NULL; - } - - return ret; - } - - if(!type) - return ret; - - return -1; -} - /********************************************************************* * setlocale (MSVCRT.@) */ @@ -1262,3 +1225,40 @@ char* CDECL MSVCRT_setlocale(int category, const char* locale) return cur->locinfo->lc_category[category].locale; } + +/* _configthreadlocale - not exported in native msvcrt */ +int CDECL _configthreadlocale(int type) +{ + thread_data_t *data = msvcrt_get_thread_data(); + int ret; + + if(!data) + return -1; + + ret = (data->locale ? MSVCRT__ENABLE_PER_THREAD_LOCALE : MSVCRT__DISABLE_PER_THREAD_LOCALE); + + if(type == MSVCRT__ENABLE_PER_THREAD_LOCALE) { + if(!data->locale) { + /* Copy current global locale */ + data->locale = MSVCRT__create_locale(MSVCRT_LC_ALL, MSVCRT_setlocale(MSVCRT_LC_ALL, NULL)); + if(!data->locale) + return -1; + } + + return ret; + } + + if(type == MSVCRT__DISABLE_PER_THREAD_LOCALE) { + if(data->locale) { + MSVCRT__free_locale(data->locale); + data->locale = NULL; + } + + return ret; + } + + if(!type) + return ret; + + return -1; +} diff --git a/dlls/msvcrt/main.c b/dlls/msvcrt/main.c index f1ef67b..54a0689 100644 --- a/dlls/msvcrt/main.c +++ b/dlls/msvcrt/main.c @@ -93,7 +93,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) if (!msvcrt_init_tls()) return FALSE; msvcrt_init_mt_locks(); - if(!MSVCRT_setlocale(0, "C")) { + if(!(MSVCRT_locale = MSVCRT__create_locale(0, "C"))) { msvcrt_free_mt_locks(); msvcrt_free_tls_mem(); return FALSE; diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 58fd0b7..49d4768 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -805,7 +805,6 @@ void __cdecl MSVCRT_abort(void); MSVCRT_ulong* __cdecl MSVCRT___doserrno(void); int* __cdecl MSVCRT__errno(void); char* __cdecl MSVCRT_getenv(const char*); -char* __cdecl MSVCRT_setlocale(int,const char*); int __cdecl MSVCRT_fclose(MSVCRT_FILE*); void __cdecl MSVCRT_terminate(void); MSVCRT_FILE* __cdecl MSVCRT__iob_func(void); @@ -877,6 +876,7 @@ typedef struct MSVCRT_localeinfo_struct #define MSVCRT__DISABLE_PER_THREAD_LOCALE 2 extern MSVCRT__locale_t MSVCRT_locale; +MSVCRT__locale_t MSVCRT__create_locale(int, const char*); MSVCRT__locale_t get_locale(void); void __cdecl MSVCRT__free_locale(MSVCRT__locale_t);

1 0

Piotr Caban : msvcrt: Close thread handle when _beginthread is used.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 2bcc9d452a19f2d11ec4b3e655a3c4456b02cc96 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bcc9d452a19f2d11ec4b3e65… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:22:02 2011 +0200 msvcrt: Close thread handle when _beginthread is used. --- dlls/msvcrt/main.c | 1 + dlls/msvcrt/msvcrt.h | 2 + dlls/msvcrt/thread.c | 59 ++++++++++++++++++++++++++++++++++--------------- 3 files changed, 44 insertions(+), 18 deletions(-) diff --git a/dlls/msvcrt/main.c b/dlls/msvcrt/main.c index cca6189..f1ef67b 100644 --- a/dlls/msvcrt/main.c +++ b/dlls/msvcrt/main.c @@ -66,6 +66,7 @@ static inline void msvcrt_free_tls_mem(void) thread_data_t *tls = TlsGetValue(msvcrt_tls_index); if (tls) { + CloseHandle(tls->handle); HeapFree(GetProcessHeap(),0,tls->efcvt_buffer); HeapFree(GetProcessHeap(),0,tls->asctime_buffer); HeapFree(GetProcessHeap(),0,tls->wasctime_buffer); diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 31fe719..8fc3b03 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -107,6 +107,8 @@ struct MSVCRT_tm { extern DWORD msvcrt_tls_index; struct __thread_data { + DWORD tid; + HANDLE handle; int thread_errno; MSVCRT_ulong thread_doserrno; unsigned int random_seed; /* seed for rand() */ diff --git a/dlls/msvcrt/thread.c b/dlls/msvcrt/thread.c index dc6edcd..2afb183 100644 --- a/dlls/msvcrt/thread.c +++ b/dlls/msvcrt/thread.c @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msvcrt); /********************************************************************/ typedef struct { + HANDLE is_ready, thread; MSVCRT__beginthread_start_routine_t start_address; void *arglist; } _beginthread_trampoline_t; @@ -44,6 +45,8 @@ thread_data_t *msvcrt_get_thread_data(void) if (!(ptr = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ptr) ))) _amsg_exit( _RT_THREAD ); if (!TlsSetValue( msvcrt_tls_index, ptr )) _amsg_exit( _RT_THREAD ); + ptr->tid = GetCurrentThreadId(); + ptr->handle = INVALID_HANDLE_VALUE; ptr->random_seed = 1; } SetLastError( err ); @@ -56,13 +59,19 @@ thread_data_t *msvcrt_get_thread_data(void) */ static DWORD CALLBACK _beginthread_trampoline(LPVOID arg) { - _beginthread_trampoline_t local_trampoline; + _beginthread_trampoline_t local_trampoline, *trampoline = arg; + thread_data_t *data = msvcrt_get_thread_data(); + + if(!DuplicateHandle(GetCurrentProcess(), GetCurrentThread(), GetCurrentProcess(), + &trampoline->thread, 0, TRUE, DUPLICATE_SAME_ACCESS)) { + trampoline->thread = NULL; + SetEvent(&trampoline->is_ready); + return 0; + } - /* Maybe it's just being paranoid, but freeing arg right - * away seems safer. - */ - memcpy(&local_trampoline,arg,sizeof(local_trampoline)); - MSVCRT_free(arg); + memcpy(&local_trampoline, trampoline, sizeof(local_trampoline)); + data->handle = local_trampoline.thread; + SetEvent(trampoline->is_ready); local_trampoline.start_address(local_trampoline.arglist); return 0; @@ -76,21 +85,35 @@ MSVCRT_uintptr_t CDECL _beginthread( unsigned int stack_size, /* [in] Stack size for new thread or 0 */ void *arglist) /* [in] Argument list to be passed to new thread or NULL */ { - _beginthread_trampoline_t* trampoline; + _beginthread_trampoline_t trampoline; + HANDLE thread; TRACE("(%p, %d, %p)\n", start_address, stack_size, arglist); - /* Allocate the trampoline here so that it is still valid when the thread - * starts... typically after this function has returned. - * _beginthread_trampoline is responsible for freeing the trampoline - */ - trampoline=MSVCRT_malloc(sizeof(*trampoline)); - trampoline->start_address = start_address; - trampoline->arglist = arglist; - - /* FIXME */ - return (MSVCRT_uintptr_t)CreateThread(NULL, stack_size, _beginthread_trampoline, - trampoline, 0, NULL); + trampoline.is_ready = CreateEventW(NULL, FALSE, FALSE, NULL); + if(!trampoline.is_ready) { + *MSVCRT__errno() = MSVCRT_EAGAIN; + return -1; + } + trampoline.start_address = start_address; + trampoline.arglist = arglist; + + thread = CreateThread(NULL, stack_size, _beginthread_trampoline, + &trampoline, 0, NULL); + if(!thread) { + *MSVCRT__errno() = MSVCRT_EAGAIN; + return -1; + } + CloseHandle(thread); + + WaitForSingleObject(trampoline.is_ready, INFINITE); + CloseHandle(trampoline.is_ready); + + if(!trampoline.thread) { + *MSVCRT__errno() = MSVCRT_EAGAIN; + return -1; + } + return (MSVCRT_uintptr_t)trampoline.thread; } /*********************************************************************

1 0

Piotr Caban : msvcrt: Added _get_unexpected implementation.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: e253e526fc1cb96fc6ff485bfa65f99239f9b872 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e253e526fc1cb96fc6ff485bf… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:23:43 2011 +0200 msvcrt: Added _get_unexpected implementation. --- dlls/msvcrt/cpp.c | 10 ++++++++++ dlls/msvcrt/msvcrt.spec | 2 +- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/msvcrt/cpp.c b/dlls/msvcrt/cpp.c index 6f6b5c6..d5c0c64 100644 --- a/dlls/msvcrt/cpp.c +++ b/dlls/msvcrt/cpp.c @@ -1049,6 +1049,16 @@ MSVCRT_unexpected_function CDECL MSVCRT_set_unexpected(MSVCRT_unexpected_functio } /****************************************************************** + * _get_unexpected (MSVCRT.@) + */ +MSVCRT_unexpected_function CDECL MSVCRT__get_unexpected(void) +{ + thread_data_t *data = msvcrt_get_thread_data(); + TRACE("returning %p\n", data->unexpected_handler); + return data->unexpected_handler; +} + +/****************************************************************** * ?_set_se_translator@@YAP6AXIPAU_EXCEPTION_POINTERS@@@ZP6AXI0(a)Z@Z (MSVCRT.@) */ MSVCRT__se_translator_function CDECL MSVCRT__set_se_translator(MSVCRT__se_translator_function func) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 7e00607..ac7b9e3 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -489,7 +489,7 @@ # stub _get_wpgmptr(ptr) @ cdecl _get_terminate() MSVCRT__get_terminate @ cdecl _get_tzname(ptr str long long) MSVCRT__get_tzname -@ stub _get_unexpected() +@ cdecl _get_unexpected() MSVCRT__get_unexpected @ cdecl _getch() @ cdecl _getche() @ cdecl _getcwd(str long)

1 0

Piotr Caban : msvcrt: Improved tmpnam/wtmpnam implementation.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: abb3db5c5780620c1c19a67094d8619e512298cd URL: http://source.winehq.org/git/wine.git/?a=commit;h=abb3db5c5780620c1c19a6709… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:23:13 2011 +0200 msvcrt: Improved tmpnam/wtmpnam implementation. --- dlls/msvcrt/file.c | 27 ++++++++++++++++++++------- dlls/msvcrt/msvcrt.h | 4 +++- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index d47a25a..7ee7b62 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -108,8 +108,6 @@ static int MSVCRT_umask = 0; /* INTERNAL: static data for tmpnam and _wtmpname functions */ static int tmpnam_unique; -static char MSVCRT_tmpname[MAX_PATH]; -static MSVCRT_wchar_t MSVCRT_wtmpname[MAX_PATH]; static const unsigned int EXE = 'e' << 16 | 'x' << 8 | 'e'; static const unsigned int BAT = 'b' << 16 | 'a' << 8 | 't'; @@ -3654,8 +3652,16 @@ char * CDECL MSVCRT_tmpnam(char *s) char tmpstr[16]; char *p; int count, size; - if (s == 0) - s = MSVCRT_tmpname; + + if (!s) { + thread_data_t *data = msvcrt_get_thread_data(); + + if(!data->tmpnam_buffer) + data->tmpnam_buffer = MSVCRT_malloc(MAX_PATH); + + s = data->tmpnam_buffer; + } + msvcrt_int_to_base32(GetCurrentProcessId(), tmpstr); p = s + sprintf(s, "\\s%s.", tmpstr); for (count = 0; count < MSVCRT_TMP_MAX; count++) @@ -3672,14 +3678,21 @@ char * CDECL MSVCRT_tmpnam(char *s) /********************************************************************* * _wtmpnam (MSVCRT.@) */ -MSVCRT_wchar_t * MSVCRT_wtmpnam(MSVCRT_wchar_t *s) +MSVCRT_wchar_t * CDECL MSVCRT_wtmpnam(MSVCRT_wchar_t *s) { static const MSVCRT_wchar_t format[] = {'\\','s','%','s','.',0}; MSVCRT_wchar_t tmpstr[16]; MSVCRT_wchar_t *p; int count, size; - if (s == 0) - s = MSVCRT_wtmpname; + if (!s) { + thread_data_t *data = msvcrt_get_thread_data(); + + if(!data->wtmpnam_buffer) + data->wtmpnam_buffer = MSVCRT_malloc(sizeof(MSVCRT_wchar_t[MAX_PATH])); + + s = data->wtmpnam_buffer; + } + msvcrt_int_to_base32_w(GetCurrentProcessId(), tmpstr); p = s + MSVCRT__snwprintf(s, MAX_PATH, format, tmpstr); for (count = 0; count < MSVCRT_TMP_MAX; count++) diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 90056ba..a0d3acb 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -169,7 +169,9 @@ struct __thread_data { unsigned char *mbstok_next; /* next ptr for mbstok() */ char *strerror_buffer; /* buffer for strerror */ MSVCRT_wchar_t *wcserror_buffer; /* buffer for wcserror */ - void *unk2[4]; + char *tmpnam_buffer; /* buffer for tmpname() */ + MSVCRT_wchar_t *wtmpnam_buffer; /* buffer for wtmpname() */ + void *unk2[2]; char *asctime_buffer; /* buffer for asctime */ MSVCRT_wchar_t *wasctime_buffer; /* buffer for wasctime */ struct MSVCRT_tm *time_buffer; /* buffer for localtime/gmtime */

1 0

Piotr Caban : msvcrt: Use get_locinfo instead of get_locale.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: 6991ac0331554fc91820212d448e884e8e034f10 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6991ac0331554fc91820212d4… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 24 17:22:32 2011 +0200 msvcrt: Use get_locinfo instead of get_locale. --- dlls/msvcrt/ctype.c | 44 +++++++++++++------- dlls/msvcrt/file.c | 2 +- dlls/msvcrt/locale.c | 12 +++++- dlls/msvcrt/mbcs.c | 107 +++++++++++++++++++++++++++---------------------- dlls/msvcrt/msvcrt.h | 2 +- dlls/msvcrt/printf.h | 55 +++++++++++++------------ dlls/msvcrt/scanf.h | 9 +++- dlls/msvcrt/string.c | 52 ++++++++++++++++-------- dlls/msvcrt/wcs.c | 22 ++++++---- 9 files changed, 182 insertions(+), 123 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6991ac0331554fc918202…

1 0

Alexandre Julliard : makefiles: Set the module name in stripped modules to the non-stripped name.
by Alexandre Julliard May 25, 2011

May 25, 2011

Module: wine Branch: master Commit: ee5a3216edc653b105e1220c16083068c19f9e1c URL: http://source.winehq.org/git/wine.git/?a=commit;h=ee5a3216edc653b105e1220c1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed May 25 10:24:57 2011 +0200 makefiles: Set the module name in stripped modules to the non-stripped name. --- Maketest.rules.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Maketest.rules.in b/Maketest.rules.in index d31522a..b60986c 100644 --- a/Maketest.rules.in +++ b/Maketest.rules.in @@ -33,7 +33,7 @@ $(MODULE) $(MODULE).so: $(OBJS) Makefile.in $(WINEGCC) $(APPMODE) $(OBJS) -o $@ $(LIBPORT) $(ALL_LIBS) $(WINETEST_EXE): $(OBJS) Makefile.in - $(WINEGCC) -s $(APPMODE) $(OBJS) -o $@ $(LIBPORT) $(ALL_LIBS) + $(WINEGCC) -s -Wb,-F,$(MODULE) $(APPMODE) $(OBJS) -o $@ $(LIBPORT) $(ALL_LIBS) $(WINETEST_RES): $(WINETEST_EXE) echo "$(MODULE) TESTRES \"$(WINETEST_EXE)\"" | $(LDPATH) $(WRC) $(RCFLAGS) -o $@

1 0