June 2011 - Wine-Commits - list.winehq.org

Marcus Meissner : msi: Fix some NULL dereferences (Coverity).
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: aec497b03d6ebd1246944d7a1fe463fba1502095 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aec497b03d6ebd1246944d7a1… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jun 11 11:33:08 2011 +0200 msi: Fix some NULL dereferences (Coverity). --- dlls/msi/font.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msi/font.c b/dlls/msi/font.c index aea5702..afc7ee6 100644 --- a/dlls/msi/font.c +++ b/dlls/msi/font.c @@ -216,13 +216,13 @@ static UINT ITERATE_RegisterFonts(MSIRECORD *row, LPVOID param) file = msi_get_loaded_file( package, filename ); if (!file) { - WARN("unable to find file %s\n", debugstr_w(file->File)); + WARN("unable to find file %s\n", debugstr_w(filename)); return ERROR_SUCCESS; } comp = msi_get_loaded_component( package, file->Component->Component ); if (!comp) { - WARN("unable to find component %s\n", debugstr_w(comp->Component)); + WARN("unable to find component %s\n", debugstr_w(file->Component->Component)); return ERROR_SUCCESS; } comp->Action = msi_get_component_action( package, comp ); @@ -301,13 +301,13 @@ static UINT ITERATE_UnregisterFonts( MSIRECORD *row, LPVOID param ) file = msi_get_loaded_file( package, filename ); if (!file) { - WARN("unable to find file %s\n", debugstr_w(file->File)); + WARN("unable to find file %s\n", debugstr_w(filename)); return ERROR_SUCCESS; } comp = msi_get_loaded_component( package, file->Component->Component ); if (!comp) { - WARN("unable to find component %s\n", debugstr_w(comp->Component)); + WARN("unable to find component %s\n", debugstr_w(file->Component->Component)); return ERROR_SUCCESS; } comp->Action = msi_get_component_action( package, comp );

1 0

André Hentschel : ws2_32/tests: Don' t read return value when we don't test for it.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: 3437591e71d0375aff5ab45ef2919040c79e89ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=3437591e71d0375aff5ab45ef… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 11 14:03:20 2011 +0200 ws2_32/tests: Don't read return value when we don't test for it. --- dlls/ws2_32/tests/sock.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 28d5db3..44539a8 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -520,7 +520,7 @@ static VOID WINAPI oob_server ( server_params *par ) ok ( atmark == 0, "oob_server (%x): not at the OOB mark: %i\n", id, atmark ); /* Receive the rest of the out-of-band data and check atmark state */ - n_recvd = do_synchronous_recv ( mem->sock[0].s, mem->sock[0].buf, n_expected, par->buflen ); + do_synchronous_recv ( mem->sock[0].s, mem->sock[0].buf, n_expected, par->buflen ); ioctlsocket ( mem->sock[0].s, SIOCATMARK, &atmark ); ok ( atmark == 0, "oob_server (%x): not at the OOB mark: %i\n", id, atmark );

1 0

Alexandre Julliard : makefiles: Add a more generic handling of makefile generation flags.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: e2db7946309fe7f2b43258cc8b838119f5baca25 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e2db7946309fe7f2b43258cc8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jun 12 11:41:43 2011 +0200 makefiles: Add a more generic handling of makefile generation flags. --- aclocal.m4 | 20 ++++++---- configure | 98 ++++++++++++++++++++++++++------------------------ configure.ac | 94 ++++++++++++++++++++++++------------------------ tools/make_makefiles | 46 +++++++++++++---------- 4 files changed, 136 insertions(+), 122 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e2db7946309fe7f2b4325…

1 0

Alexandre Julliard : makefiles: Use the generic install flags for the static libraries.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: a0b8fa9f97b115274d863e8c22bdb1b99b0ffb95 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0b8fa9f97b115274d863e8c2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jun 12 12:44:03 2011 +0200 makefiles: Use the generic install flags for the static libraries. --- aclocal.m4 | 15 +++++---------- configure | 15 +++++---------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index 6dd0361..18b920b 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -204,9 +204,10 @@ wine_fn_config_makefile () ac_dir=$[1] ac_enable=$[2] ac_flags=$[3] + ac_rules=$[4] AS_VAR_IF([$ac_enable],[no],[return 0]) - wine_fn_all_dir_rules $ac_dir Make.rules + wine_fn_all_dir_rules $ac_dir ${ac_rules:-Make.rules} wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ "all: $ac_dir .PHONY: $ac_dir @@ -241,15 +242,9 @@ wine_fn_config_lib () ac_name=$[1] ac_flags=$[2] ac_dir=dlls/$ac_name - wine_fn_all_dir_rules $ac_dir dlls/Makeimplib.rules - wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ -"all __builddeps__: $ac_dir -$ac_dir: $ac_dir/Makefile tools/widl tools/winebuild tools/winegcc include dummy - @cd $ac_dir && \$(MAKE) -install install-dev:: $ac_dir - @cd $ac_dir && \$(MAKE) install -uninstall:: $ac_dir/Makefile - @cd $ac_dir && \$(MAKE) uninstall" + wine_fn_config_makefile $ac_dir enable_$ac_name $ac_flags,install-dev dlls/Makeimplib.rules + wine_fn_append_rule ALL_MAKEFILE_DEPENDS "__builddeps__: $ac_dir" + wine_fn_append_rule ALL_MAKEFILE_DEPENDS "$ac_dir: tools/widl tools/winebuild tools/winegcc include" } wine_fn_config_dll () diff --git a/configure b/configure index e0afaa6..1bdae44 100755 --- a/configure +++ b/configure @@ -14569,11 +14569,12 @@ wine_fn_config_makefile () ac_dir=$1 ac_enable=$2 ac_flags=$3 + ac_rules=$4 if eval test \"x\$"$ac_enable"\" = x"no"; then : return 0 fi - wine_fn_all_dir_rules $ac_dir Make.rules + wine_fn_all_dir_rules $ac_dir ${ac_rules:-Make.rules} wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ "all: $ac_dir .PHONY: $ac_dir @@ -14608,15 +14609,9 @@ wine_fn_config_lib () ac_name=$1 ac_flags=$2 ac_dir=dlls/$ac_name - wine_fn_all_dir_rules $ac_dir dlls/Makeimplib.rules - wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ -"all __builddeps__: $ac_dir -$ac_dir: $ac_dir/Makefile tools/widl tools/winebuild tools/winegcc include dummy - @cd $ac_dir && \$(MAKE) -install install-dev:: $ac_dir - @cd $ac_dir && \$(MAKE) install -uninstall:: $ac_dir/Makefile - @cd $ac_dir && \$(MAKE) uninstall" + wine_fn_config_makefile $ac_dir enable_$ac_name $ac_flags,install-dev dlls/Makeimplib.rules + wine_fn_append_rule ALL_MAKEFILE_DEPENDS "__builddeps__: $ac_dir" + wine_fn_append_rule ALL_MAKEFILE_DEPENDS "$ac_dir: tools/widl tools/winebuild tools/winegcc include" } wine_fn_config_dll ()

1 0

Marcus Meissner : user32: Initialize all of msg (Coverity).
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: 891fcb20acedf15f61a285b442e2dcc5815c2c1a URL: http://source.winehq.org/git/wine.git/?a=commit;h=891fcb20acedf15f61a285b44… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jun 11 10:54:58 2011 +0200 user32: Initialize all of msg (Coverity). --- dlls/user32/tests/msg.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 62acf8a..8c23da2 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -13054,6 +13054,7 @@ static LRESULT CALLBACK KeyboardHookProc(int nCode, WPARAM wParam, LPARAM lParam { KBDLLHOOKSTRUCT *kdbhookstruct = (KBDLLHOOKSTRUCT*)lParam; + msg.hwnd = 0; msg.message = wParam; msg.flags = kbd_hook|wparam|lparam; msg.wParam = kdbhookstruct->vkCode;

1 0

André Hentschel : c2man: Initialise current comment info.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: b1d089baa3751ce5f59c080dc7eb5ebb191f899a URL: http://source.winehq.org/git/wine.git/?a=commit;h=b1d089baa3751ce5f59c080dc… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Jun 11 16:45:24 2011 +0200 c2man: Initialise current comment info. --- tools/c2man.pl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/c2man.pl b/tools/c2man.pl index 8030bc4..9c67488 100755 --- a/tools/c2man.pl +++ b/tools/c2man.pl @@ -420,6 +420,7 @@ sub process_source_file($) if ($parse_state == 4) # Reading in the function definition { # This file is used by the DLL - Make sure we get our contributors right + @{$spec_files{$comment->{DLL_NAME}}[0]->{CURRENT_EXTRA}} = (); push (@{$spec_files{$comment->{DLL_NAME}}[0]->{SOURCES}},$comment->{FILE}); push (@{$comment->{PROTOTYPE}},$_);

1 0

Alexandre Julliard : makefiles: Use generic flags to specify which directories need a make install.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: e492fcc833446f003e82f8172ba0f1bcc2cdf697 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e492fcc833446f003e82f8172… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jun 12 12:03:53 2011 +0200 makefiles: Use generic flags to specify which directories need a make install. --- aclocal.m4 | 26 ++++++++++++++++++++------ configure | 40 +++++++++++++++++++++++++++------------- configure.ac | 14 +++++++------- tools/make_makefiles | 5 +++++ 4 files changed, 59 insertions(+), 26 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index 86ba73b..781e627 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -211,15 +211,29 @@ wine_fn_config_makefile () "all: $ac_dir .PHONY: $ac_dir $ac_dir: $ac_dir/Makefile dummy - @cd $ac_dir && \$(MAKE) -install:: $ac_dir + @cd $ac_dir && \$(MAKE)" + + wine_fn_has_flag install-lib $ac_flags || wine_fn_has_flag install-dev $ac_flags || return + + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install:: $ac_dir @cd $ac_dir && \$(MAKE) install -install-lib:: $ac_dir - @cd $ac_dir && \$(MAKE) install-lib -install-dev:: $ac_dir - @cd $ac_dir && \$(MAKE) install-dev uninstall:: $ac_dir/Makefile @cd $ac_dir && \$(MAKE) uninstall" + + if wine_fn_has_flag install-lib $ac_flags + then + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install-lib:: $ac_dir + @cd $ac_dir && \$(MAKE) install-lib" + fi + + if wine_fn_has_flag install-dev $ac_flags + then + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install-dev:: $ac_dir + @cd $ac_dir && \$(MAKE) install-dev" + fi } wine_fn_config_lib () diff --git a/configure b/configure index 700069d..36692f7 100755 --- a/configure +++ b/configure @@ -14578,15 +14578,29 @@ fi "all: $ac_dir .PHONY: $ac_dir $ac_dir: $ac_dir/Makefile dummy - @cd $ac_dir && \$(MAKE) -install:: $ac_dir + @cd $ac_dir && \$(MAKE)" + + wine_fn_has_flag install-lib $ac_flags || wine_fn_has_flag install-dev $ac_flags || return + + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install:: $ac_dir @cd $ac_dir && \$(MAKE) install -install-lib:: $ac_dir - @cd $ac_dir && \$(MAKE) install-lib -install-dev:: $ac_dir - @cd $ac_dir && \$(MAKE) install-dev uninstall:: $ac_dir/Makefile @cd $ac_dir && \$(MAKE) uninstall" + + if wine_fn_has_flag install-lib $ac_flags + then + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install-lib:: $ac_dir + @cd $ac_dir && \$(MAKE) install-lib" + fi + + if wine_fn_has_flag install-dev $ac_flags + then + wine_fn_append_rule ALL_MAKEFILE_DEPENDS \ +"install-dev:: $ac_dir + @cd $ac_dir && \$(MAKE) install-dev" + fi } wine_fn_config_lib () @@ -15416,7 +15430,7 @@ wine_fn_config_dll winemapi enable_winemapi wine_fn_config_dll winemp3.acm enable_winemp3_acm wine_fn_config_dll winenas.drv enable_winenas_drv wine_fn_config_dll wineoss.drv enable_wineoss_drv -wine_fn_config_dll wineps.drv enable_wineps_drv +wine_fn_config_dll wineps.drv enable_wineps_drv install-lib wine_fn_config_dll wineps16.drv16 enable_win16 wine_fn_config_dll wineqtdecoder enable_wineqtdecoder wine_fn_config_dll winequartz.drv enable_winequartz_drv @@ -15463,12 +15477,12 @@ wine_fn_config_dll xinput9_1_0 enable_xinput9_1_0 wine_fn_config_dll xmllite enable_xmllite wine_fn_config_test dlls/xmllite/tests xmllite_test wine_fn_config_makefile documentation enable_documentation -wine_fn_config_makefile fonts enable_fonts -wine_fn_config_makefile include enable_include +wine_fn_config_makefile fonts enable_fonts install-lib +wine_fn_config_makefile include enable_include install-dev wine_fn_config_makefile libs/port enable_libs_port -wine_fn_config_makefile libs/wine enable_libs_wine +wine_fn_config_makefile libs/wine enable_libs_wine install-dev,install-lib wine_fn_config_makefile libs/wpp enable_libs_wpp -wine_fn_config_makefile loader enable_loader +wine_fn_config_makefile loader enable_loader install-lib wine_fn_config_program aspnet_regiis enable_aspnet_regiis install wine_fn_config_program attrib enable_attrib install wine_fn_config_program cabarc enable_cabarc install @@ -15544,8 +15558,8 @@ wine_fn_config_program write enable_write install,po wine_fn_config_program wscript enable_wscript install wine_fn_config_test programs/wscript/tests wscript.exe_test wine_fn_config_program xcopy enable_xcopy install,po -wine_fn_config_makefile server enable_server -wine_fn_config_tool tools +wine_fn_config_makefile server enable_server install-lib +wine_fn_config_tool tools install-dev,install-lib wine_fn_config_tool tools/widl wine_fn_config_tool tools/winebuild wine_fn_config_tool tools/winedump diff --git a/configure.ac b/configure.ac index 04166e1..81a32f5 100644 --- a/configure.ac +++ b/configure.ac @@ -2881,7 +2881,7 @@ WINE_CONFIG_DLL(winemapi) WINE_CONFIG_DLL(winemp3.acm) WINE_CONFIG_DLL(winenas.drv) WINE_CONFIG_DLL(wineoss.drv) -WINE_CONFIG_DLL(wineps.drv) +WINE_CONFIG_DLL(wineps.drv,,[install-lib]) WINE_CONFIG_DLL(wineps16.drv16,enable_win16) WINE_CONFIG_DLL(wineqtdecoder) WINE_CONFIG_DLL(winequartz.drv) @@ -2928,12 +2928,12 @@ WINE_CONFIG_DLL(xinput9_1_0) WINE_CONFIG_DLL(xmllite) WINE_CONFIG_TEST(dlls/xmllite/tests) WINE_CONFIG_MAKEFILE([documentation]) -WINE_CONFIG_MAKEFILE([fonts]) -WINE_CONFIG_MAKEFILE([include]) +WINE_CONFIG_MAKEFILE([fonts],,[install-lib]) +WINE_CONFIG_MAKEFILE([include],,[install-dev]) WINE_CONFIG_MAKEFILE([libs/port]) -WINE_CONFIG_MAKEFILE([libs/wine]) +WINE_CONFIG_MAKEFILE([libs/wine],,[install-dev,install-lib]) WINE_CONFIG_MAKEFILE([libs/wpp]) -WINE_CONFIG_MAKEFILE([loader]) +WINE_CONFIG_MAKEFILE([loader],,[install-lib]) WINE_CONFIG_PROGRAM(aspnet_regiis,,[install]) WINE_CONFIG_PROGRAM(attrib,,[install]) WINE_CONFIG_PROGRAM(cabarc,,[install]) @@ -3009,8 +3009,8 @@ WINE_CONFIG_PROGRAM(write,,[install,po]) WINE_CONFIG_PROGRAM(wscript,,[install]) WINE_CONFIG_TEST(programs/wscript/tests) WINE_CONFIG_PROGRAM(xcopy,,[install,po]) -WINE_CONFIG_MAKEFILE([server]) -WINE_CONFIG_TOOL(tools) +WINE_CONFIG_MAKEFILE([server],,[install-lib]) +WINE_CONFIG_TOOL(tools,[install-dev,install-lib]) WINE_CONFIG_TOOL(tools/widl) WINE_CONFIG_TOOL(tools/winebuild) WINE_CONFIG_TOOL(tools/winedump) diff --git a/tools/make_makefiles b/tools/make_makefiles index f662e2a..6d7cd36 100755 --- a/tools/make_makefiles +++ b/tools/make_makefiles @@ -327,6 +327,11 @@ sub parse_makefile($) push @{$make{"=flags"}}, "staticimplib" if $var eq "IMPLIB_SRCS"; next; } + if (/(install-lib|install-dev)\s*:/) + { + push @{$make{"=flags"}}, $1; + next; + } if (/^\s*(TOPSRCDIR|TOPOBJDIR|SRCDIR|VPATH)\s*=\s*(.*)/) { die "Variable $1 in $file.in is obsolete";

1 0

Marcus Meissner : wined3d: Don't just print a FIXME on error, handle it ( Coverity).
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: 2bcd4398182df76ea40ce84651d7b554f3660b9a URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bcd4398182df76ea40ce8465… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jun 11 18:05:02 2011 +0200 wined3d: Don't just print a FIXME on error, handle it (Coverity). --- dlls/wined3d/device.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 5bc5a08..30d5b95 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1872,12 +1872,13 @@ HRESULT CDECL wined3d_device_multiply_transform(struct wined3d_device *device, * below means it will be recorded in a state block change, but it * works regardless where it is recorded. * If this is found to be wrong, change to StateBlock. */ + if (state > HIGHEST_TRANSFORMSTATE) + { + WARN("Unhandled transform state %#x.\n", state); + return WINED3D_OK; + } - if (state <= HIGHEST_TRANSFORMSTATE) - mat = &device->updateStateBlock->state.transforms[state]; - else - FIXME("Unhandled transform state %#x.\n", state); - + mat = &device->updateStateBlock->state.transforms[state]; multiply_matrix(&temp, mat, matrix); /* Apply change via set transform - will reapply to eg. lights this way. */

1 0

Marcus Meissner : d3dx9_36: Moved param NULL a bit forward (Coverity).
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: 6c902b4201b8237195ef492dae2be70c70793612 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c902b4201b8237195ef492da… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jun 11 11:00:33 2011 +0200 d3dx9_36: Moved param NULL a bit forward (Coverity). --- dlls/d3dx9_36/effect.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index bbe21f0..ca88f76 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -1516,6 +1516,11 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_GetValue(ID3DXBaseEffect *iface, D3DXH TRACE("iface %p, parameter %p, data %p, bytes %u\n", This, parameter, data, bytes); if (!param) param = get_parameter_by_name(This, NULL, parameter); + if (!param) + { + WARN("Invalid parameter %p specified\n", parameter); + return D3DERR_INVALIDCALL; + } /* samplers don't touch data */ if (param->class == D3DXPC_OBJECT && (param->type == D3DXPT_SAMPLER @@ -1526,7 +1531,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_GetValue(ID3DXBaseEffect *iface, D3DXH return E_FAIL; } - if (data && param && param->bytes <= bytes) + if (data && param->bytes <= bytes) { TRACE("Type %s\n", debug_d3dxparameter_type(param->type));

1 0

Alexandre Julliard : urlmon: Fix some pointer cast warnings.
by Alexandre Julliard June 13, 2011

June 13, 2011

Module: wine Branch: master Commit: 59d76dd341e2ecf3fbea3a783555dc33ecc5accc URL: http://source.winehq.org/git/wine.git/?a=commit;h=59d76dd341e2ecf3fbea3a783… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jun 11 11:18:00 2011 +0200 urlmon: Fix some pointer cast warnings. --- dlls/urlmon/protocol.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/urlmon/protocol.c b/dlls/urlmon/protocol.c index 94801ae..5bd16dd 100644 --- a/dlls/urlmon/protocol.c +++ b/dlls/urlmon/protocol.c @@ -89,13 +89,13 @@ static void request_complete(Protocol *protocol, INTERNET_ASYNC_RESULT *ar) } if(protocol->flags & FLAG_FIRST_CONTINUE_COMPLETE) - data.pData = (LPVOID)BINDSTATUS_ENDDOWNLOADCOMPONENTS; + data.pData = UlongToPtr(BINDSTATUS_ENDDOWNLOADCOMPONENTS); else - data.pData = (LPVOID)BINDSTATUS_DOWNLOADINGDATA; + data.pData = UlongToPtr(BINDSTATUS_DOWNLOADINGDATA); }else { protocol->flags |= FLAG_ERROR; - data.pData = (LPVOID)ar->dwError; + data.pData = UlongToPtr(ar->dwError); } if (protocol->bindf & BINDF_FROMURLMON) @@ -294,7 +294,7 @@ HRESULT protocol_continue(Protocol *protocol, PROTOCOLDATA *data) return S_OK; } - is_start = data->pData == (LPVOID)BINDSTATUS_DOWNLOADINGDATA; + is_start = data->pData == UlongToPtr(BINDSTATUS_DOWNLOADINGDATA); if(!protocol->request) { WARN("Expected request to be non-NULL\n"); @@ -308,7 +308,7 @@ HRESULT protocol_continue(Protocol *protocol, PROTOCOLDATA *data) if(protocol->flags & FLAG_ERROR) { protocol->flags &= ~FLAG_ERROR; - protocol->vtbl->on_error(protocol, (DWORD)data->pData); + protocol->vtbl->on_error(protocol, PtrToUlong(data->pData)); return S_OK; } @@ -338,7 +338,7 @@ HRESULT protocol_continue(Protocol *protocol, PROTOCOLDATA *data) protocol->flags |= FLAG_FIRST_CONTINUE_COMPLETE; } - if(data->pData >= (LPVOID)BINDSTATUS_DOWNLOADINGDATA && !protocol->available_bytes) { + if(data->pData >= UlongToPtr(BINDSTATUS_DOWNLOADINGDATA) && !protocol->available_bytes) { BOOL res; /* InternetQueryDataAvailable may immediately fork and perform its asynchronous

1 0