August 2011 - Wine-Commits - list.winehq.org

Andrew Talbot : comctl32: void functions should not return a value.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 8a4b7f9f22ac74605384784b507b5c8f2a9e3274 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a4b7f9f22ac74605384784b5… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Aug 6 12:51:11 2011 +0100 comctl32: void functions should not return a value. --- dlls/comctl32/monthcal.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c index 27d2cf0..2ad4812 100644 --- a/dlls/comctl32/monthcal.c +++ b/dlls/comctl32/monthcal.c @@ -481,13 +481,13 @@ static inline void MONTHCAL_GetMonth(SYSTEMTIME *date, INT months) /* properly updates date to point on next month */ static inline void MONTHCAL_GetNextMonth(SYSTEMTIME *date) { - return MONTHCAL_GetMonth(date, 1); + MONTHCAL_GetMonth(date, 1); } /* properly updates date to point on prev month */ static inline void MONTHCAL_GetPrevMonth(SYSTEMTIME *date) { - return MONTHCAL_GetMonth(date, -1); + MONTHCAL_GetMonth(date, -1); } /* Returns full date for a first currently visible day */

1 0

Andrew Talbot : compobj.dll16: void functions should not return a value.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 268226b658e7120993c2fc6e8e8abf64f4c1c807 URL: http://source.winehq.org/git/wine.git/?a=commit;h=268226b658e7120993c2fc6e8… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Aug 6 12:51:13 2011 +0100 compobj.dll16: void functions should not return a value. --- dlls/compobj.dll16/compobj.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/compobj.dll16/compobj.c b/dlls/compobj.dll16/compobj.c index f4b5d5d..ed36564 100644 --- a/dlls/compobj.dll16/compobj.c +++ b/dlls/compobj.dll16/compobj.c @@ -306,7 +306,7 @@ void WINAPI CoUninitialize16(void) */ void WINAPI CoFreeUnusedLibraries16(void) { - return CoFreeUnusedLibraries(); + CoFreeUnusedLibraries(); } /***********************************************************************

1 0

Andrew Talbot : msvcrt: void functions should not return a value.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: fb3b28f0131690bd0a6f73a42a955c56ae9543f3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb3b28f0131690bd0a6f73a42… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Aug 6 12:51:16 2011 +0100 msvcrt: void functions should not return a value. --- dlls/msvcrt/exit.c | 2 +- dlls/msvcrt/time.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/exit.c b/dlls/msvcrt/exit.c index 6c6b55f..19b9fb4 100644 --- a/dlls/msvcrt/exit.c +++ b/dlls/msvcrt/exit.c @@ -139,7 +139,7 @@ static void DoMessageBox(const char *lead, const char *message) MSVCRT_mbstowcs(leadW, lead, 1024); MSVCRT_mbstowcs(messageW, message, 1024); - return DoMessageBoxW(leadW, messageW); + DoMessageBoxW(leadW, messageW); } /********************************************************************* diff --git a/dlls/msvcrt/time.c b/dlls/msvcrt/time.c index 5ff1467..bf87711 100644 --- a/dlls/msvcrt/time.c +++ b/dlls/msvcrt/time.c @@ -655,12 +655,12 @@ int CDECL MSVCRT__ftime32_s(struct MSVCRT___timeb32 *buf) #ifdef _WIN64 void CDECL MSVCRT__ftime(struct MSVCRT___timeb64 *buf) { - return MSVCRT__ftime64( buf ); + MSVCRT__ftime64( buf ); } #else void CDECL MSVCRT__ftime(struct MSVCRT___timeb32 *buf) { - return MSVCRT__ftime32( buf ); + MSVCRT__ftime32( buf ); } #endif

1 0

Jacek Caban : jscript: Don't copy more than needed in parse_identifier.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 39f4583ef9a18515e78cc5015a37240e30eefc13 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39f4583ef9a18515e78cc5015… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 5 17:23:25 2011 +0200 jscript: Don't copy more than needed in parse_identifier. --- dlls/jscript/lex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/lex.c b/dlls/jscript/lex.c index 6dfe937..157be5b 100644 --- a/dlls/jscript/lex.c +++ b/dlls/jscript/lex.c @@ -337,7 +337,7 @@ static int parse_identifier(parser_ctx_t *ctx, const WCHAR **ret) len = ctx->ptr-ptr; *ret = wstr = parser_alloc(ctx, (len+1)*sizeof(WCHAR)); - memcpy(wstr, ptr, (len+1)*sizeof(WCHAR)); + memcpy(wstr, ptr, len*sizeof(WCHAR)); wstr[len] = 0; /* FIXME: unescape */

1 0

Marcus Meissner : wineoss.drv: Print strerror of errno, not of -1 (Coverity ).
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 2de37f021475ad9579cc3d11450c34e83bdfc046 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2de37f021475ad9579cc3d114… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Aug 6 13:26:18 2011 +0200 wineoss.drv: Print strerror of errno, not of -1 (Coverity). --- dlls/wineoss.drv/mmdevdrv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wineoss.drv/mmdevdrv.c b/dlls/wineoss.drv/mmdevdrv.c index 6c10a53..1e69a22 100644 --- a/dlls/wineoss.drv/mmdevdrv.c +++ b/dlls/wineoss.drv/mmdevdrv.c @@ -250,7 +250,7 @@ static UINT get_default_index(EDataFlow flow, char **keys, UINT num) ai.dev = -1; if((err = ioctl(fd, SNDCTL_ENGINEINFO, &ai)) < 0){ - WARN("SNDCTL_ENGINEINFO failed: %d (%s)\n", err, strerror(err)); + WARN("SNDCTL_ENGINEINFO failed: %d (%s)\n", err, strerror(errno)); close(fd); return 0; }

1 0

Andrew Talbot : cabinet: void functions should not return a value.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 25ea53244353ba719db59a01fdd669488e88492f URL: http://source.winehq.org/git/wine.git/?a=commit;h=25ea53244353ba719db59a01f… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Aug 6 12:51:09 2011 +0100 cabinet: void functions should not return a value. --- dlls/cabinet/fci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c index 82d94ab..8ea7c26 100644 --- a/dlls/cabinet/fci.c +++ b/dlls/cabinet/fci.c @@ -917,7 +917,7 @@ static void *zalloc( void *opaque, unsigned int items, unsigned int size ) static void zfree( void *opaque, void *ptr ) { FCI_Int *fci = opaque; - return fci->free( ptr ); + fci->free( ptr ); } static cab_UWORD compress_MSZIP( FCI_Int *fci )

1 0

Marcus Meissner : d3dx9_36: Fixed memset of a -2 32bit value (Coverity).
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: 9ac18eabb9f4adb1d9806ef76360bdb714219b6f URL: http://source.winehq.org/git/wine.git/?a=commit;h=9ac18eabb9f4adb1d9806ef76… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Aug 6 13:13:28 2011 +0200 d3dx9_36: Fixed memset of a -2 32bit value (Coverity). --- dlls/d3dx9_36/tests/mesh.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c index 39c78e6..a68e9c5 100644 --- a/dlls/d3dx9_36/tests/mesh.c +++ b/dlls/d3dx9_36/tests/mesh.c @@ -5384,7 +5384,7 @@ static void test_convert_adjacency_to_point_reps(void) } /* Convert adjacency to point representation */ - memset(point_reps, -1, tc[i].num_vertices * sizeof(*point_reps)); + for (j = 0; j < tc[i].num_vertices; j++) point_reps[j] = -1; hr = mesh->lpVtbl->ConvertAdjacencyToPointReps(mesh, tc[i].adjacency, point_reps); ok(hr == D3D_OK, "ConvertAdjacencyToPointReps failed case %d. " "Got %x expected D3D_OK\n", i, hr); @@ -5921,7 +5921,8 @@ static void test_convert_point_reps_to_adjacency(void) } /* Convert point representation to adjacency*/ - memset(adjacency, -2, VERTS_PER_FACE * tc[i].num_faces * sizeof(*adjacency)); + for (j = 0; j < VERTS_PER_FACE * tc[i].num_faces; j++) adjacency[j] = -2; + hr = mesh->lpVtbl->ConvertPointRepsToAdjacency(mesh, tc[i].point_reps, adjacency); ok(hr == D3D_OK, "ConvertPointRepsToAdjacency failed case %d. " "Got %x expected D3D_OK\n", i, hr); @@ -5935,7 +5936,7 @@ static void test_convert_point_reps_to_adjacency(void) } /* NULL point representation is considered identity. */ - memset(adjacency, -2, VERTS_PER_FACE * tc[i].num_faces * sizeof(*adjacency)); + for (j = 0; j < VERTS_PER_FACE * tc[i].num_faces; j++) adjacency[j] = -2; hr = mesh_null_check->lpVtbl->ConvertPointRepsToAdjacency(mesh, NULL, adjacency); ok(hr == D3D_OK, "ConvertPointRepsToAdjacency NULL point_reps. " "Got %x expected D3D_OK\n", hr);

1 0

Marcus Meissner : net: LoadStringW incorrect size bytes vs characters.
by Alexandre Julliard Aug. 22, 2011

Aug. 22, 2011

Module: wine Branch: master Commit: a869964b31c98860297f8d7a3e7983ce5f41dd9b URL: http://source.winehq.org/git/wine.git/?a=commit;h=a869964b31c98860297f8d7a3… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Aug 6 13:09:17 2011 +0200 net: LoadStringW incorrect size bytes vs characters. --- programs/net/net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/net/net.c b/programs/net/net.c index 559ef5c..07369ab 100644 --- a/programs/net/net.c +++ b/programs/net/net.c @@ -59,7 +59,7 @@ static int output_string(int msg, ...) int len; va_list arguments; - LoadStringW(GetModuleHandleW(NULL), msg, fmt, sizeof(fmt)); + LoadStringW(GetModuleHandleW(NULL), msg, fmt, sizeof(fmt)/sizeof(fmt[0])); va_start(arguments, msg); len = vsprintfW(str, fmt, arguments); output_write(str, len);

1 0

Austin English : website: update Debian package maintainer info
by Jeremy Newman Aug. 15, 2011

Aug. 15, 2011

Module: website Branch: master Commit: c041eaa619e66893d43090fb11a210ab161dbc98 URL: http://source.winehq.org/git/website.git/?a=commit;h=c041eaa619e66893d43090… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Aug 11 11:49:12 2011 -0700 website: update Debian package maintainer info See http://www.winehq.org/pipermail/wine-devel/2011-July/091294.html -- -Austin --- templates/de/download.template | 2 +- templates/en/download.template | 2 +- templates/fr/download.template | 2 +- templates/he/download.template | 2 +- templates/pl/download.template | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/templates/de/download.template b/templates/de/download.template index 31fb089..6c76e9d 100644 --- a/templates/de/download.template +++ b/templates/de/download.template @@ -72,7 +72,7 @@ erbeten hat, dass sie die Wine-Website hosten. </td> <td> <a href="{$root}/download/debian">Debian</a> binär .debs für Debian Lenny, Squeeze und Sid</td> - <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a> <a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> + <td><a href="mailto:curan(a)debian.org">Kai Wasserbäch</a></td> </tr> <tr bgcolor="#ffffff"> diff --git a/templates/en/download.template b/templates/en/download.template index 449c63d..08a44d0 100644 --- a/templates/en/download.template +++ b/templates/en/download.template @@ -71,7 +71,7 @@ requested in exchange for hosting the Wine web site. </td> <td> <a href="{$root}/download/debian">Download Debian packages</a> - binary .debs for Debian Lenny, Squeeze and Sid</td> - <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a> <a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> + <td><a href="mailto:curan(a)debian.org">Kai Wasserbäch</a></td> </tr> <tr bgcolor="#ffffff"> diff --git a/templates/fr/download.template b/templates/fr/download.template index 4b1eded..7d1f609 100644 --- a/templates/fr/download.template +++ b/templates/fr/download.template @@ -76,7 +76,7 @@ center;">Voyez la </td> <td> <a href="{$root}/download/debian">Paquets Debian</a> - .deb binaires pour Debian Lenny, Squeeze et Sid</td> - <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a> <a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> + <td><a href="mailto:curan(a)debian.org">Kai Wasserbäch</a></td> </tr> <tr bgcolor="#ffffff"> diff --git a/templates/he/download.template b/templates/he/download.template index 38db84a..36d7f38 100644 --- a/templates/he/download.template +++ b/templates/he/download.template @@ -72,7 +72,7 @@ </td> <td> <a href="{$root}/download/deblenny">הורדת חבילות לדביאן</a> - קובצי .debבינריים לדביאן Lenny,&rlm; Squeeze ו־Sid</td> - <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a> <a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> + <td><a href="mailto:curan(a)debian.org">Kai Wasserbäch</a></td> </tr> <tr bgcolor="#ffffff"> diff --git a/templates/pl/download.template b/templates/pl/download.template index c8849c9..82e01de 100644 --- a/templates/pl/download.template +++ b/templates/pl/download.template @@ -70,7 +70,7 @@ </td> <td> <a href="{$root}/download/deblenny">Pobierz paczki dla Debian</a> - binarne paczki .deb dla Debian Lenny, Squeeze i Sid</td> - <td><a href="mailto:repository(a)lamaresh.net">Maurilio Genovese</a> <a href="mailto:ben.klein(a)lamaresh.net">Ben Klein</a></td> + <td><a href="mailto:curan(a)debian.org">Kai Wasserbäch</a></td> </tr> <tr bgcolor="#ffffff">

1 0

André Hentschel : Wine 1.3.26 freigegeben
by Jeremy Newman Aug. 8, 2011

Aug. 8, 2011

Module: website Branch: master Commit: 140ea16e60782fac13a1d9d7d9bc082bbacaa05c URL: http://source.winehq.org/git/website.git/?a=commit;h=140ea16e60782fac13a1d9… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Aug 5 22:19:49 2011 +0200 Wine 1.3.26 freigegeben --- news/de/2011080501.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/de/2011080501.xml b/news/de/2011080501.xml new file mode 100644 index 0000000..ac66617 --- /dev/null +++ b/news/de/2011080501.xml @@ -0,0 +1,18 @@ +<news> +<date>5. August 2011</date> +<title>Wine 1.3.26 freigegeben</title> +<body> + Die Entwicklungsversion 1.3.26 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/1.3.26">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Verschiedene Verbesserungen am eigenen Internet Explorer.</li> + <li>Unterstützung für Get/SetDIBits in der DIB Engine.</li> + <li>Unterstützung für Enhanced Metafiles im View Tool.</li> + <li>Viele Verbesserungen in WinHTTP.</li> + <li>Mehrere Fehlerbehebungen am COM Stubless Marshaller.</li> + <li>Verbesserter Mechanismus für DLL Registrierungen.</li> + <li>Verschiedene Fehlerbehebungen.</li> +</ul> +Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.3.26.tar.bz2">verfügbar</a>. +Binär-Downloads werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Download-Seiten</a> zur Verfügung. +</body></news>

1 0