September 2011 - Wine-Commits

Alexandre Julliard : ntdll: Fix protection flags for uninitialized sections .
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 33b0f0edffa0c8a06b4ee8831c92fdc373f83ece URL: http://source.winehq.org/git/wine.git/?a=commit;h=33b0f0edffa0c8a06b4ee8831… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 9 12:29:20 2011 +0200 ntdll: Fix protection flags for uninitialized sections. --- dlls/ntdll/virtual.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c index 6699de1..10fba17 100644 --- a/dlls/ntdll/virtual.c +++ b/dlls/ntdll/virtual.c @@ -1341,8 +1341,14 @@ static NTSTATUS map_image( HANDLE hmapping, int fd, char *base, SIZE_T total_siz size = ROUND_SIZE( sec->VirtualAddress, sec->SizeOfRawData ); if (sec->Characteristics & IMAGE_SCN_MEM_READ) vprot |= VPROT_READ; - if (sec->Characteristics & IMAGE_SCN_MEM_WRITE) vprot |= VPROT_READ | VPROT_WRITECOPY; if (sec->Characteristics & IMAGE_SCN_MEM_EXECUTE) vprot |= VPROT_EXEC; + if (sec->Characteristics & IMAGE_SCN_MEM_WRITE) + { + if (sec->Characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA) + vprot |= VPROT_READ | VPROT_WRITE; + else + vprot |= VPROT_READ | VPROT_WRITECOPY; + } /* Dumb game crack lets the AOEP point into a data section. Adjust. */ if ((nt->OptionalHeader.AddressOfEntryPoint >= sec->VirtualAddress) &&

1 0

Alexandre Julliard : user32/tests: Allow an approximate color match for the cursor contents.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 8d503428587e88e4e87770d89aa799927014b6dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d503428587e88e4e87770d89… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 8 23:52:02 2011 +0200 user32/tests: Allow an approximate color match for the cursor contents. --- dlls/user32/tests/cursoricon.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c index c874924..6e13fc0 100644 --- a/dlls/user32/tests/cursoricon.c +++ b/dlls/user32/tests/cursoricon.c @@ -1405,6 +1405,7 @@ static int check_cursor_data( HDC hdc, HCURSOR hCursor, void *data, int length) BITMAPINFO *info; ICONINFO iinfo; DWORD ret; + int i; ret = GetIconInfo( hCursor, &iinfo ); ok(ret, "GetIconInfo() failed\n"); @@ -1430,10 +1431,11 @@ static int check_cursor_data( HDC hdc, HCURSOR hCursor, void *data, int length) if (!image) goto cleanup; ret = GetDIBits( hdc, iinfo.hbmColor, 0, 32, image, info, DIB_RGB_COLORS ); ok(ret, "GetDIBits() failed\n"); - if (!ret) goto cleanup; - ret = (memcmp(image, data, length) == 0); - ok(ret, "Expected 0x%x, actually 0x%x (first 4 bytes only)\n", *(DWORD *)data, *(DWORD *)image); - + for (i = 0; ret && i < length / sizeof(COLORREF); i++) + { + ret = color_match( ((COLORREF *)data)[i], ((COLORREF *)image)[i] ); + ok(ret, "%04x: Expected 0x%x, actually 0x%x\n", i, ((COLORREF *)data)[i], ((COLORREF *)image)[i] ); + } cleanup: HeapFree( GetProcessHeap(), 0, image ); HeapFree( GetProcessHeap(), 0, info );

1 0

Alexandre Julliard : wineconsole: Avoid reentering WINECON_GrabChanges.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 4a1481152706aac10efc31aa9ab22eeef0020a81 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4a1481152706aac10efc31aa9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 8 22:27:41 2011 +0200 wineconsole: Avoid reentering WINECON_GrabChanges. --- programs/wineconsole/winecon_private.h | 1 + programs/wineconsole/wineconsole.c | 4 ++++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/programs/wineconsole/winecon_private.h b/programs/wineconsole/winecon_private.h index 951b45a..1daf581 100644 --- a/programs/wineconsole/winecon_private.h +++ b/programs/wineconsole/winecon_private.h @@ -61,6 +61,7 @@ struct inner_data { HWND hWnd; /* handle of 'user' window or NULL for 'curses' */ INT nCmdShow; /* argument of WinMain */ BOOL in_set_config; /* to handle re-entrant calls to WINECON_SetConfig */ + BOOL in_grab_changes;/* to handle re-entrant calls to WINECON_GrabChanges */ BOOL dying; /* to TRUE when we've been notified by server that child has died */ int (*fnMainLoop)(struct inner_data* data); diff --git a/programs/wineconsole/wineconsole.c b/programs/wineconsole/wineconsole.c index 56be619..70c7a83 100644 --- a/programs/wineconsole/wineconsole.c +++ b/programs/wineconsole/wineconsole.c @@ -205,6 +205,8 @@ void WINECON_GrabChanges(struct inner_data* data) int i, num, ev_found; HANDLE h; + if (data->in_grab_changes) return; + SERVER_START_REQ( get_console_renderer_events ) { wine_server_set_reply( req, evts, sizeof(evts) ); @@ -258,6 +260,7 @@ void WINECON_GrabChanges(struct inner_data* data) ev_found = i; } + data->in_grab_changes = TRUE; for (i = 0; i < num; i++) { switch (evts[i].event) @@ -355,6 +358,7 @@ void WINECON_GrabChanges(struct inner_data* data) WINE_FIXME("Unknown event type (%d)\n", evts[i].event); } } + data->in_grab_changes = FALSE; } /******************************************************************

1 0

Aric Stewart : usp10: Respect the presence or absence of the SSA_BREAK flag .
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: dd4dd261f5fa10b4fcc9f7f2b02c59dfe1b147e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd4dd261f5fa10b4fcc9f7f2b… Author: Aric Stewart <aric(a)codeweavers.com> Date: Thu Sep 8 12:50:03 2011 -0500 usp10: Respect the presence or absence of the SSA_BREAK flag. --- dlls/usp10/usp10.c | 17 +++++++++++++---- 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 873d10b..e2a1756 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -324,6 +324,7 @@ typedef struct { typedef struct { HDC hdc; + DWORD dwFlags; BOOL invalid; int clip_len; ScriptCache *sc; @@ -931,6 +932,7 @@ HRESULT WINAPI ScriptStringAnalyse(HDC hdc, const void *pString, int cString, /* FIXME: handle clipping */ analysis->clip_len = cString; analysis->hdc = hdc; + analysis->dwFlags = dwFlags; if (psState) sState = *psState; @@ -959,10 +961,16 @@ HRESULT WINAPI ScriptStringAnalyse(HDC hdc, const void *pString, int cString, } if (hr != S_OK) goto error; - if ((analysis->logattrs = heap_alloc(sizeof(SCRIPT_LOGATTR) * cString))) - ScriptBreak(pString, cString, (SCRIPT_STRING_ANALYSIS)analysis, analysis->logattrs); - else - goto error; + if (dwFlags & SSA_BREAK) + { + if ((analysis->logattrs = heap_alloc(sizeof(SCRIPT_LOGATTR) * cString))) + { + for (i = 0; i < analysis->numItems; i++) + ScriptBreak(&((LPWSTR)pString)[analysis->pItem[i].iCharPos], analysis->pItem[i+1].iCharPos - analysis->pItem[i].iCharPos, &analysis->pItem[i].a, &analysis->logattrs[analysis->pItem[i].iCharPos]); + } + else + goto error; + } if (!(analysis->glyphs = heap_alloc_zero(sizeof(StringGlyphs) * analysis->numItems))) goto error; @@ -2351,6 +2359,7 @@ const SCRIPT_LOGATTR * WINAPI ScriptString_pLogAttr(SCRIPT_STRING_ANALYSIS ssa) TRACE("(%p)\n", ssa); if (!analysis) return NULL; + if (!(analysis->dwFlags & SSA_BREAK)) return NULL; return analysis->logattrs; }

1 0

Alexandre Julliard : version: Check the Windows directory first in VerFindFileA/W.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 702941eae1c32d678bd078e117ff5b37c3e0929e URL: http://source.winehq.org/git/wine.git/?a=commit;h=702941eae1c32d678bd078e11… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 9 13:23:16 2011 +0200 version: Check the Windows directory first in VerFindFileA/W. --- dlls/version/tests/install.c | 4 +- dlls/version/version.c | 46 +++++++++++++++++++++++------------------ 2 files changed, 28 insertions(+), 22 deletions(-) diff --git a/dlls/version/tests/install.c b/dlls/version/tests/install.c index 6fc19bb..6faeaba 100644 --- a/dlls/version/tests/install.c +++ b/dlls/version/tests/install.c @@ -89,7 +89,7 @@ static void test_find_file(void) "got %d(%s) expected MAX_PATH\n", dwOut, outBuf); break; default: - todo_wine ok(0, "Got unexpected return value %x\n", ret); + ok(0, "Got unexpected return value %x\n", ret); } dwCur=MAX_PATH; @@ -111,7 +111,7 @@ static void test_find_file(void) "got %d(%s) expected MAX_PATH\n", dwOut, outBuf); break; default: - todo_wine ok(0, "Got unexpected return value %x\n", ret); + ok(0, "Got unexpected return value %x\n", ret); } } } diff --git a/dlls/version/version.c b/dlls/version/version.c index 8ea0209..f636c62 100644 --- a/dlls/version/version.c +++ b/dlls/version/version.c @@ -1101,7 +1101,7 @@ DWORD WINAPI VerFindFileA( const char *destDir; unsigned int curDirSizeReq; unsigned int destDirSizeReq; - char systemDir[MAX_PATH]; + char winDir[MAX_PATH], systemDir[MAX_PATH]; /* Print out debugging information */ TRACE("flags = %x filename=%s windir=%s appdir=%s curdirlen=%p(%u) destdirlen=%p(%u)\n", @@ -1132,17 +1132,20 @@ DWORD WINAPI VerFindFileA( } else /* not a shared file */ { - if(lpszAppDir) + destDir = lpszAppDir ? lpszAppDir : ""; + if(lpszFilename) { - destDir = lpszAppDir; - if(lpszFilename) + GetWindowsDirectoryA( winDir, MAX_PATH ); + if(testFileExistenceA(destDir, lpszFilename, FALSE)) curDir = destDir; + else if(testFileExistenceA(winDir, lpszFilename, FALSE)) + { + curDir = winDir; + retval |= VFF_CURNEDEST; + } + else if(testFileExistenceA(systemDir, lpszFilename, FALSE)) { - if(testFileExistenceA(destDir, lpszFilename, FALSE)) curDir = destDir; - else if(testFileExistenceA(systemDir, lpszFilename, FALSE)) - { - curDir = systemDir; - retval |= VFF_CURNEDEST; - } + curDir = systemDir; + retval |= VFF_CURNEDEST; } } } @@ -1195,7 +1198,7 @@ DWORD WINAPI VerFindFileW( DWORD flags,LPCWSTR lpszFilename,LPCWSTR lpszWinDir, const WCHAR *destDir; unsigned int curDirSizeReq; unsigned int destDirSizeReq; - WCHAR systemDir[MAX_PATH]; + WCHAR winDir[MAX_PATH], systemDir[MAX_PATH]; /* Print out debugging information */ TRACE("flags = %x filename=%s windir=%s appdir=%s curdirlen=%p(%u) destdirlen=%p(%u)\n", @@ -1226,17 +1229,20 @@ DWORD WINAPI VerFindFileW( DWORD flags,LPCWSTR lpszFilename,LPCWSTR lpszWinDir, } else /* not a shared file */ { - if(lpszAppDir) + destDir = lpszAppDir ? lpszAppDir : &emptyW; + if(lpszFilename) { - destDir = lpszAppDir; - if(lpszFilename) + GetWindowsDirectoryW( winDir, MAX_PATH ); + if(testFileExistenceW(destDir, lpszFilename, FALSE)) curDir = destDir; + else if(testFileExistenceW(winDir, lpszFilename, FALSE)) + { + curDir = winDir; + retval |= VFF_CURNEDEST; + } + else if(testFileExistenceW(systemDir, lpszFilename, FALSE)) { - if(testFileExistenceW(destDir, lpszFilename, FALSE)) curDir = destDir; - else if(testFileExistenceW(systemDir, lpszFilename, FALSE)) - { - curDir = systemDir; - retval |= VFF_CURNEDEST; - } + curDir = systemDir; + retval |= VFF_CURNEDEST; } } }

1 0

Juan Lang : crypt32: Test/correct CertGetNameString with NULL pvTypePara.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: e8b98b31451fdd358546d67d8e1e63ec9a833740 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e8b98b31451fdd358546d67d8… Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Sep 8 11:10:08 2011 -0700 crypt32: Test/correct CertGetNameString with NULL pvTypePara. --- dlls/crypt32/str.c | 18 ++++- dlls/crypt32/tests/str.c | 162 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 176 insertions(+), 4 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e8b98b31451fdd358546d…

1 0

Alexandre Julliard : wine.inf: Create a fake dll for the 32-bit iexplore on Wow64.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: c8d912376fb343521de84456ef4e60375eab0229 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c8d912376fb343521de84456e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 9 12:55:43 2011 +0200 wine.inf: Create a fake dll for the 32-bit iexplore on Wow64. --- tools/wine.inf.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/wine.inf.in b/tools/wine.inf.in index 3d91981..1113400 100644 --- a/tools/wine.inf.in +++ b/tools/wine.inf.in @@ -2535,7 +2535,6 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" 11,mui, 11,gecko\plugin,npmshtml.dll 11,wbem,mofcomp.exe -11,,iexplore.exe,- 11,,winetest.exe,- 12,,mountmgr.sys,- ; registration order matters for these @@ -2545,6 +2544,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" 11,,msxml4.dll 11,,msxml6.dll 11,,shdocvw.dll +16422,Internet Explorer,iexplore.exe 11,,* [FakeDlls]

1 0

Aric Stewart : usp10: Respect the presence or absence of the SSA_GLYPHS flag.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 7ae0b72e2fd5ec97d3d8fde61b4626ec76880ee1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ae0b72e2fd5ec97d3d8fde61… Author: Aric Stewart <aric(a)codeweavers.com> Date: Thu Sep 8 12:50:10 2011 -0500 usp10: Respect the presence or absence of the SSA_GLYPHS flag. --- dlls/usp10/usp10.c | 99 ++++++++++++++++++++++++++++++--------------------- 1 files changed, 58 insertions(+), 41 deletions(-) diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index e2a1756..9095fe3 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -972,45 +972,53 @@ HRESULT WINAPI ScriptStringAnalyse(HDC hdc, const void *pString, int cString, goto error; } - if (!(analysis->glyphs = heap_alloc_zero(sizeof(StringGlyphs) * analysis->numItems))) - goto error; - if (!(analysis->logical2visual = heap_alloc_zero(sizeof(int) * analysis->numItems))) goto error; if (!(BidiLevel = heap_alloc_zero(analysis->numItems))) goto error; - for (i = 0; i < analysis->numItems; i++) + if (dwFlags & SSA_GLYPHS) { - SCRIPT_CACHE *sc = (SCRIPT_CACHE *)&analysis->sc; - int cChar = analysis->pItem[i+1].iCharPos - analysis->pItem[i].iCharPos; - int numGlyphs = 1.5 * cChar + 16; - WORD *glyphs = heap_alloc_zero(sizeof(WORD) * numGlyphs); - WORD *pwLogClust = heap_alloc_zero(sizeof(WORD) * cChar); - int *piAdvance = heap_alloc_zero(sizeof(int) * numGlyphs); - SCRIPT_VISATTR *psva = heap_alloc_zero(sizeof(SCRIPT_VISATTR) * cChar); - GOFFSET *pGoffset = heap_alloc_zero(sizeof(GOFFSET) * numGlyphs); - ABC *abc = heap_alloc_zero(sizeof(ABC)); - int numGlyphsReturned; - - /* FIXME: non unicode strings */ - const WCHAR* pStr = (const WCHAR*)pString; - hr = ScriptShape(hdc, sc, &pStr[analysis->pItem[i].iCharPos], - cChar, numGlyphs, &analysis->pItem[i].a, - glyphs, pwLogClust, psva, &numGlyphsReturned); - hr = ScriptPlace(hdc, sc, glyphs, numGlyphsReturned, psva, &analysis->pItem[i].a, - piAdvance, pGoffset, abc); - - analysis->glyphs[i].numGlyphs = numGlyphsReturned; - analysis->glyphs[i].glyphs = glyphs; - analysis->glyphs[i].pwLogClust = pwLogClust; - analysis->glyphs[i].piAdvance = piAdvance; - analysis->glyphs[i].psva = psva; - analysis->glyphs[i].pGoffset = pGoffset; - analysis->glyphs[i].abc = abc; - analysis->glyphs[i].iMaxPosX= -1; - - BidiLevel[i] = analysis->pItem[i].a.s.uBidiLevel; + if (!(analysis->glyphs = heap_alloc_zero(sizeof(StringGlyphs) * analysis->numItems))) + goto error; + + for (i = 0; i < analysis->numItems; i++) + { + SCRIPT_CACHE *sc = (SCRIPT_CACHE *)&analysis->sc; + int cChar = analysis->pItem[i+1].iCharPos - analysis->pItem[i].iCharPos; + int numGlyphs = 1.5 * cChar + 16; + WORD *glyphs = heap_alloc_zero(sizeof(WORD) * numGlyphs); + WORD *pwLogClust = heap_alloc_zero(sizeof(WORD) * cChar); + int *piAdvance = heap_alloc_zero(sizeof(int) * numGlyphs); + SCRIPT_VISATTR *psva = heap_alloc_zero(sizeof(SCRIPT_VISATTR) * cChar); + GOFFSET *pGoffset = heap_alloc_zero(sizeof(GOFFSET) * numGlyphs); + ABC *abc = heap_alloc_zero(sizeof(ABC)); + int numGlyphsReturned; + + /* FIXME: non unicode strings */ + const WCHAR* pStr = (const WCHAR*)pString; + hr = ScriptShape(hdc, sc, &pStr[analysis->pItem[i].iCharPos], + cChar, numGlyphs, &analysis->pItem[i].a, + glyphs, pwLogClust, psva, &numGlyphsReturned); + hr = ScriptPlace(hdc, sc, glyphs, numGlyphsReturned, psva, &analysis->pItem[i].a, + piAdvance, pGoffset, abc); + + analysis->glyphs[i].numGlyphs = numGlyphsReturned; + analysis->glyphs[i].glyphs = glyphs; + analysis->glyphs[i].pwLogClust = pwLogClust; + analysis->glyphs[i].piAdvance = piAdvance; + analysis->glyphs[i].psva = psva; + analysis->glyphs[i].pGoffset = pGoffset; + analysis->glyphs[i].abc = abc; + analysis->glyphs[i].iMaxPosX= -1; + + BidiLevel[i] = analysis->pItem[i].a.s.uBidiLevel; + } + } + else + { + for (i = 0; i < analysis->numItems; i++) + BidiLevel[i] = analysis->pItem[i].a.s.uBidiLevel; } ScriptLayout(analysis->numItems, BidiLevel, NULL, analysis->logical2visual); @@ -1165,6 +1173,7 @@ HRESULT WINAPI ScriptStringOut(SCRIPT_STRING_ANALYSIS ssa, ssa, iX, iY, uOptions, prc, iMinSel, iMaxSel, fDisabled); if (!(analysis = ssa)) return E_INVALIDARG; + if (!(analysis->dwFlags & SSA_GLYPHS)) return E_INVALIDARG; for (item = 0; item < analysis->numItems; item++) { @@ -1201,6 +1210,7 @@ HRESULT WINAPI ScriptStringCPtoX(SCRIPT_STRING_ANALYSIS ssa, int icp, BOOL fTrai TRACE("(%p), %d, %d, (%p)\n", ssa, icp, fTrailing, pX); if (!ssa || !pX) return S_FALSE; + if (!(analysis->dwFlags & SSA_GLYPHS)) return S_FALSE; /* icp out of range */ if(icp < 0) @@ -1262,6 +1272,7 @@ HRESULT WINAPI ScriptStringXtoCP(SCRIPT_STRING_ANALYSIS ssa, int iX, int* piCh, TRACE("(%p), %d, (%p), (%p)\n", ssa, iX, piCh, piTrailing); if (!ssa || !piCh || !piTrailing) return S_FALSE; + if (!(analysis->dwFlags & SSA_GLYPHS)) return S_FALSE; /* out of range */ if(iX < 0) @@ -1348,17 +1359,20 @@ HRESULT WINAPI ScriptStringFree(SCRIPT_STRING_ANALYSIS *pssa) invalid = analysis->invalid; ScriptFreeCache((SCRIPT_CACHE *)&analysis->sc); - for (i = 0; i < analysis->numItems; i++) + if (analysis->glyphs) { - heap_free(analysis->glyphs[i].glyphs); - heap_free(analysis->glyphs[i].pwLogClust); - heap_free(analysis->glyphs[i].piAdvance); - heap_free(analysis->glyphs[i].psva); - heap_free(analysis->glyphs[i].pGoffset); - heap_free(analysis->glyphs[i].abc); + for (i = 0; i < analysis->numItems; i++) + { + heap_free(analysis->glyphs[i].glyphs); + heap_free(analysis->glyphs[i].pwLogClust); + heap_free(analysis->glyphs[i].piAdvance); + heap_free(analysis->glyphs[i].psva); + heap_free(analysis->glyphs[i].pGoffset); + heap_free(analysis->glyphs[i].abc); + } + heap_free(analysis->glyphs); } - heap_free(analysis->glyphs); heap_free(analysis->pItem); heap_free(analysis->logattrs); heap_free(analysis->sz); @@ -2271,6 +2285,7 @@ HRESULT WINAPI ScriptStringGetLogicalWidths(SCRIPT_STRING_ANALYSIS ssa, int *piD TRACE("%p, %p\n", ssa, piDx); if (!analysis) return S_FALSE; + if (!(analysis->dwFlags & SSA_GLYPHS)) return S_FALSE; for (i = 0; i < analysis->numItems; i++) { @@ -2326,6 +2341,7 @@ const SIZE * WINAPI ScriptString_pSize(SCRIPT_STRING_ANALYSIS ssa) TRACE("(%p)\n", ssa); if (!analysis) return NULL; + if (!(analysis->dwFlags & SSA_GLYPHS)) return NULL; if (!analysis->sz) { @@ -2407,6 +2423,7 @@ HRESULT WINAPI ScriptStringGetOrder(SCRIPT_STRING_ANALYSIS ssa, UINT *order) TRACE("(%p)\n", ssa); if (!analysis) return S_FALSE; + if (!(analysis->dwFlags & SSA_GLYPHS)) return S_FALSE; /* FIXME: handle RTL scripts */ for (i = 0, k = 0; i < analysis->numItems; i++)

1 0

Hans Leidekker : msi: Move the preview code to dialog.c.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 5783c2cfcbc65b3f5905090474a578e9c8cb0173 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5783c2cfcbc65b3f590509047… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Sep 9 11:00:24 2011 +0200 msi: Move the preview code to dialog.c. --- dlls/msi/Makefile.in | 1 - dlls/msi/dialog.c | 139 +++++++++++++++++++++++++++++++++++++- dlls/msi/msipriv.h | 1 - dlls/msi/preview.c | 184 -------------------------------------------------- 4 files changed, 138 insertions(+), 187 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=5783c2cfcbc65b3f59050…

1 0

Hans Leidekker : msi/tests: Fix some test messages.
by Alexandre Julliard Sept. 9, 2011

Sept. 9, 2011

Module: wine Branch: master Commit: 79e71d543f7e83e0cd06a2e19ed7d6465b88cd6e URL: http://source.winehq.org/git/wine.git/?a=commit;h=79e71d543f7e83e0cd06a2e19… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Fri Sep 9 10:59:54 2011 +0200 msi/tests: Fix some test messages. --- dlls/msi/tests/package.c | 34 +++++++++++++++++----------------- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index d240acf..04c3fe7 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -753,7 +753,7 @@ static MSIHANDLE create_package_db(void) ok( res == ERROR_SUCCESS , "Failed to commit database\n" ); res = set_summary_info(hdb); - ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", res); + ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", res); res = run_query( hdb, "CREATE TABLE `Directory` ( " @@ -2467,12 +2467,12 @@ static void test_formatrecord2(void) buffer[0] = 0; sz = sizeof buffer; r = MsiFormatRecord( hpkg, hrec, buffer, &sz ); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); r = MsiRecordSetString(hrec, 0, "[foo][1]"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); r = MsiRecordSetString(hrec, 1, "hoo"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 3, "size wrong\n"); @@ -2480,7 +2480,7 @@ static void test_formatrecord2(void) ok( r == ERROR_SUCCESS, "format failed\n"); r = MsiRecordSetString(hrec, 0, "x[~]x"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 3, "size wrong\n"); @@ -2488,9 +2488,9 @@ static void test_formatrecord2(void) ok( r == ERROR_SUCCESS, "format failed\n"); r = MsiRecordSetString(hrec, 0, "[foo.$%}][1]"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); r = MsiRecordSetString(hrec, 1, "hoo"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 3, "size wrong\n"); @@ -2498,7 +2498,7 @@ static void test_formatrecord2(void) ok( r == ERROR_SUCCESS, "format failed\n"); r = MsiRecordSetString(hrec, 0, "[\\[]"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 1, "size wrong\n"); @@ -2507,7 +2507,7 @@ static void test_formatrecord2(void) SetEnvironmentVariable("FOO", "BAR"); r = MsiRecordSetString(hrec, 0, "[%FOO]"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 3, "size wrong\n"); @@ -2515,9 +2515,9 @@ static void test_formatrecord2(void) ok( r == ERROR_SUCCESS, "format failed\n"); r = MsiRecordSetString(hrec, 0, "[[1]]"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); r = MsiRecordSetString(hrec, 1, "%FOO"); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); sz = sizeof buffer; r = MsiFormatRecord(hpkg, hrec, buffer, &sz); ok( sz == 3, "size wrong\n"); @@ -8442,13 +8442,13 @@ static void test_appsearch_reglocator(void) sprintf(path, "\"%s\\FileName1\" -option", CURR_DIR); res = RegSetValueExA(hklm, "value16", 0, REG_SZ, (const BYTE *)path, lstrlenA(path) + 1); - ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", res); + ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", res); space = (strchr(CURR_DIR, ' ')) ? TRUE : FALSE; sprintf(path, "%s\\FileName1 -option", CURR_DIR); res = RegSetValueExA(hklm, "value17", 0, REG_SZ, (const BYTE *)path, lstrlenA(path) + 1); - ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", res); + ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", res); hdb = create_package_db(); ok(hdb, "Expected a valid database handle\n"); @@ -9659,7 +9659,7 @@ static void test_featureparents(void) /* msidbFeatureAttributesFavorLocal:msidbComponentAttributesOptional */ r = add_component_entry( hdb, "'lepus', '', 'TARGETDIR', 2, '', 'lepus_file'" ); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); r = add_feature_components_entry( hdb, "'zodiac', 'leo'" ); ok( r == ERROR_SUCCESS, "cannot add feature components: %d\n", r ); @@ -10108,19 +10108,19 @@ static void test_installprops(void) size = MAX_PATH; r = MsiGetProperty(hpkg, "UserLanguageID", buf, &size); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); ok( !lstrcmpA(buf, path), "Expected \"%s\", got \"%s\"\n", path, buf); res = GetSystemMetrics(SM_CXSCREEN); size = MAX_PATH; r = MsiGetProperty(hpkg, "ScreenX", buf, &size); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); ok(atol(buf) == res, "Expected %d, got %ld\n", res, atol(buf)); res = GetSystemMetrics(SM_CYSCREEN); size = MAX_PATH; r = MsiGetProperty(hpkg, "ScreenY", buf, &size); - ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS< got %d\n", r); + ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", r); ok(atol(buf) == res, "Expected %d, got %ld\n", res, atol(buf)); if (pGetSystemInfo && pSHGetFolderPathA)

1 0