January 2012 - Wine-Commits

Jörg Höhle : winmm: Fix conversion to MMTIME, avoid floating point arithmetic.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 9ef4a0099c95abf458f22d29c73b8421a33546b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9ef4a0099c95abf458f22d29c… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Wed Jan 4 20:54:48 2012 +0100 winmm: Fix conversion to MMTIME, avoid floating point arithmetic. --- dlls/winmm/tests/wave.c | 8 ++++---- dlls/winmm/waveform.c | 27 ++++++++++----------------- 2 files changed, 14 insertions(+), 21 deletions(-) diff --git a/dlls/winmm/tests/wave.c b/dlls/winmm/tests/wave.c index 55bd8be..a7614a5 100644 --- a/dlls/winmm/tests/wave.c +++ b/dlls/winmm/tests/wave.c @@ -471,10 +471,10 @@ DWORD time_to_bytes(LPMMTIME mmtime, LPWAVEFORMATEX pwfx) else if (mmtime->wType == TIME_MS) return mmtime->u.ms * pwfx->nAvgBytesPerSec / 1000; else if (mmtime->wType == TIME_SMPTE) - return ((mmtime->u.smpte.hour * 60.0 * 60.0) + - (mmtime->u.smpte.min * 60.0) + - (mmtime->u.smpte.sec) + - (mmtime->u.smpte.frame / 30.0)) * pwfx->nAvgBytesPerSec; + return ((mmtime->u.smpte.hour * 60 * 60) + + (mmtime->u.smpte.min * 60) + + (mmtime->u.smpte.sec)) * pwfx->nAvgBytesPerSec + + mmtime->u.smpte.frame * pwfx->nAvgBytesPerSec / 30; trace("FIXME: time_to_bytes() type not supported\n"); return -1; diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index 041b63f..b940b4f 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -1723,32 +1723,25 @@ static MMRESULT WINMM_FramesToMMTime(MMTIME *time, UINT32 played_frames, time->u.sample = played_frames; return MMSYSERR_NOERROR; case TIME_MS: - time->u.ms = (DWORD)((played_frames / (double)sample_rate) * 1000); + time->u.ms = (UINT64)played_frames * 1000 / sample_rate; return MMSYSERR_NOERROR; case TIME_SMPTE: time->u.smpte.fps = 30; - if(played_frames >= sample_rate){ - time->u.smpte.sec = played_frames / (double)sample_rate; - time->u.smpte.min = time->u.smpte.sec / 60; - time->u.smpte.hour = time->u.smpte.min / 60; - time->u.smpte.sec %= 60; - time->u.smpte.min %= 60; - played_frames %= sample_rate; - }else{ - time->u.smpte.sec = 0; - time->u.smpte.min = 0; - time->u.smpte.hour = 0; - } - time->u.smpte.frame = (played_frames / (double)sample_rate) * 30; + played_frames += sample_rate / time->u.smpte.fps - 1; /* round up */ + time->u.smpte.frame = (played_frames % sample_rate) * time->u.smpte.fps / sample_rate; + played_frames /= sample_rate; /* yields seconds */ + time->u.smpte.sec = played_frames % 60; + played_frames /= 60; + time->u.smpte.min = played_frames % 60; + time->u.smpte.hour= played_frames / 60; return MMSYSERR_NOERROR; - case TIME_BYTES: default: time->wType = TIME_BYTES; + /* fall through */ + case TIME_BYTES: time->u.cb = played_frames * bytes_per_frame; return MMSYSERR_NOERROR; } - - return MMSYSERR_ERROR; } static LRESULT WINMM_GetPosition(HWAVE hwave, MMTIME *time)

1 0

Piotr Caban : msvcp60: Fix basic_string::rfind(char) implementation.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 806d72cfdc30f69575e17e32af251858e538a029 URL: http://source.winehq.org/git/wine.git/?a=commit;h=806d72cfdc30f69575e17e32a… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Jan 5 14:23:15 2012 +0100 msvcp60: Fix basic_string::rfind(char) implementation. --- dlls/msvcp60/string.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp60/string.c b/dlls/msvcp60/string.c index 3d9f994..056f915 100644 --- a/dlls/msvcp60/string.c +++ b/dlls/msvcp60/string.c @@ -899,7 +899,7 @@ DEFINE_THISCALL_WRAPPER(basic_string_char_rfind_ch, 12) MSVCP_size_t __thiscall basic_string_char_rfind_ch( const basic_string_char *this, char ch, MSVCP_size_t pos) { - return basic_string_char_find_cstr_substr(this, &ch, pos, 1); + return basic_string_char_rfind_cstr_substr(this, &ch, pos, 1); } /* ?rfind@?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QBEIPBDI(a)Z */ @@ -2594,7 +2594,7 @@ DEFINE_THISCALL_WRAPPER(basic_string_wchar_rfind_ch, 12) MSVCP_size_t __thiscall basic_string_wchar_rfind_ch( const basic_string_wchar *this, wchar_t ch, MSVCP_size_t pos) { - return basic_string_wchar_find_cstr_substr(this, &ch, pos, 1); + return basic_string_wchar_rfind_cstr_substr(this, &ch, pos, 1); } /* ?rfind@?$basic_string(a)GU?$char_traits(a)G@std@@V?$allocator(a)G@2@@std@@QBEIPBGI(a)Z */

1 0

Henri Verbeet : ddraw: Disallow clipped blits in ddraw_surface7_BltFast().
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 223b0736c0f6683c244c652d0857b774731f9bf2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=223b0736c0f6683c244c652d0… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 4 23:34:54 2012 +0100 ddraw: Disallow clipped blits in ddraw_surface7_BltFast(). --- dlls/ddraw/surface.c | 15 ++++++++++++++- dlls/ddraw/tests/ddraw1.c | 2 +- dlls/ddraw/tests/ddraw2.c | 2 +- dlls/ddraw/tests/ddraw4.c | 2 +- dlls/ddraw/tests/ddraw7.c | 2 +- 5 files changed, 18 insertions(+), 5 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 04e8c52..0b9248c 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -3869,7 +3869,20 @@ static HRESULT WINAPI ddraw_surface7_BltFast(IDirectDrawSurface7 *iface, DWORD d flags |= WINEDDBLT_DONOTWAIT; wined3d_mutex_lock(); - hr = ddraw_surface_blt_clipped(This, &dst_rect, src, rsrc, flags, NULL, WINED3DTEXF_POINT); + if (This->clipper) + { + wined3d_mutex_unlock(); + WARN("Destination surface has a clipper set, returning DDERR_BLTFASTCANTCLIP.\n"); + return DDERR_BLTFASTCANTCLIP; + } + + if (src->surface_desc.ddsCaps.dwCaps & DDSCAPS_FRONTBUFFER) + hr = ddraw_surface_update_frontbuffer(src, rsrc, TRUE); + if (SUCCEEDED(hr)) + hr = wined3d_surface_blt(This->wined3d_surface, &dst_rect, + src->wined3d_surface, rsrc, flags, NULL, WINED3DTEXF_POINT); + if (SUCCEEDED(hr) && (This->surface_desc.ddsCaps.dwCaps & DDSCAPS_FRONTBUFFER)) + hr = ddraw_surface_update_frontbuffer(This, &dst_rect, FALSE); wined3d_mutex_unlock(); switch(hr) diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c index fdfa11f..e700919 100644 --- a/dlls/ddraw/tests/ddraw1.c +++ b/dlls/ddraw/tests/ddraw1.c @@ -332,7 +332,7 @@ static void test_clipper_blt(void) } hr = IDirectDrawSurface_BltFast(dst_surface, 0, 0, src_surface, NULL, DDBLTFAST_WAIT); - todo_wine ok(hr == DDERR_BLTFASTCANTCLIP || broken(hr == E_NOTIMPL /* NT4 */), "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_BLTFASTCANTCLIP || broken(hr == E_NOTIMPL /* NT4 */), "Got unexpected hr %#x.\n", hr); IDirectDrawSurface_Release(dst_surface); IDirectDrawSurface_Release(src_surface); diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 7b046be..f99d480 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -339,7 +339,7 @@ static void test_clipper_blt(void) } hr = IDirectDrawSurface_BltFast(dst_surface, 0, 0, src_surface, NULL, DDBLTFAST_WAIT); - todo_wine ok(hr == DDERR_BLTFASTCANTCLIP || broken(hr == E_NOTIMPL /* NT4 */), "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_BLTFASTCANTCLIP || broken(hr == E_NOTIMPL /* NT4 */), "Got unexpected hr %#x.\n", hr); IDirectDrawSurface_Release(dst_surface); IDirectDrawSurface_Release(src_surface); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 26f5a0c..e2687fb 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -634,7 +634,7 @@ static void test_clipper_blt(void) } hr = IDirectDrawSurface4_BltFast(dst_surface, 0, 0, src_surface, NULL, DDBLTFAST_WAIT); - todo_wine ok(hr == DDERR_BLTFASTCANTCLIP, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_BLTFASTCANTCLIP, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface4_Release(dst_surface); IDirectDrawSurface4_Release(src_surface); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 9e5e564..3dcb007 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -627,7 +627,7 @@ static void test_clipper_blt(void) } hr = IDirectDrawSurface7_BltFast(dst_surface, 0, 0, src_surface, NULL, DDBLTFAST_WAIT); - todo_wine ok(hr == DDERR_BLTFASTCANTCLIP, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_BLTFASTCANTCLIP, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface7_Release(dst_surface); IDirectDrawSurface7_Release(src_surface);

1 0

Henri Verbeet : wined3d: Get rid of the WINED3DPATCHEDGESTYLE typedef.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: c77b414787de984c7088326786a96111b2495136 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c77b414787de984c708832678… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 4 23:34:56 2012 +0100 wined3d: Get rid of the WINED3DPATCHEDGESTYLE typedef. --- dlls/wined3d/state.c | 2 +- dlls/wined3d/stateblock.c | 2 +- include/wine/wined3d.h | 9 ++++----- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 3c5220e..1bcecfd 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -1826,7 +1826,7 @@ static void state_multisampmask(struct wined3d_context *context, const struct wi static void state_patchedgestyle(struct wined3d_context *context, const struct wined3d_state *state, DWORD state_id) { - if (state->render_states[WINED3D_RS_PATCHEDGESTYLE] != WINED3DPATCHEDGE_DISCRETE) + if (state->render_states[WINED3D_RS_PATCHEDGESTYLE] != WINED3D_PATCH_EDGE_DISCRETE) FIXME("WINED3D_RS_PATCHEDGESTYLE %#x not yet implemented.\n", state->render_states[WINED3D_RS_PATCHEDGESTYLE]); } diff --git a/dlls/wined3d/stateblock.c b/dlls/wined3d/stateblock.c index 1dd6b9c..d48464c 100644 --- a/dlls/wined3d/stateblock.c +++ b/dlls/wined3d/stateblock.c @@ -1197,7 +1197,7 @@ void stateblock_init_default_state(struct wined3d_stateblock *stateblock) state->render_states[WINED3D_RS_POINTSCALE_C] = tmpfloat.d; state->render_states[WINED3D_RS_MULTISAMPLEANTIALIAS] = TRUE; state->render_states[WINED3D_RS_MULTISAMPLEMASK] = 0xffffffff; - state->render_states[WINED3D_RS_PATCHEDGESTYLE] = WINED3DPATCHEDGE_DISCRETE; + state->render_states[WINED3D_RS_PATCHEDGESTYLE] = WINED3D_PATCH_EDGE_DISCRETE; tmpfloat.f = 1.0f; state->render_states[WINED3D_RS_PATCHSEGMENTS] = tmpfloat.d; state->render_states[WINED3D_RS_DEBUGMONITORTOKEN] = 0xbaadcafe; diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 254a839..6cc8a05 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -488,12 +488,11 @@ enum wined3d_material_color_source WINED3D_MCS_COLOR2 = 2, }; -typedef enum _WINED3DPATCHEDGESTYLE +enum wined3d_patch_edge_style { - WINED3DPATCHEDGE_DISCRETE = 0, - WINED3DPATCHEDGE_CONTINUOUS = 1, - WINED3DPATCHEDGE_FORCE_DWORD = 0x7fffffff -} WINED3DPATCHEDGESTYLE; + WINED3D_PATCH_EDGE_DISCRETE = 0, + WINED3D_PATCH_EDGE_CONTINUOUS = 1, +}; typedef enum _WINED3DBACKBUFFER_TYPE {

1 0

Piotr Caban : msvcp60: Added basic_string<unsigned short> implementation.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: f3df1d7cdca0ba3ed33f60bf7848c3b0fdf805b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f3df1d7cdca0ba3ed33f60bf7… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Jan 5 14:22:55 2012 +0100 msvcp60: Added basic_string<unsigned short> implementation. --- dlls/msvcp60/msvcp60.spec | 660 +++++++++--------- dlls/msvcp60/string.c | 1699 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 2027 insertions(+), 332 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f3df1d7cdca0ba3ed33f6…

1 0

Hans Leidekker : msi: Don' t crash on secondary root folders in msi_resolve_target_folder.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: de11a50b915bbfbb124404b3a309b6dd8e6da9be URL: http://source.winehq.org/git/wine.git/?a=commit;h=de11a50b915bbfbb124404b3a… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Jan 5 10:20:18 2012 +0100 msi: Don't crash on secondary root folders in msi_resolve_target_folder. --- dlls/msi/action.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 8505507..fb62339 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -2285,8 +2285,13 @@ void msi_resolve_target_folder( MSIPACKAGE *package, const WCHAR *name, BOOL loa } else if (!load_prop || !(path = msi_dup_property( package->db, folder->Directory ))) { - parent = msi_get_loaded_folder( package, folder->Parent ); - path = msi_build_directory_name( 3, parent->ResolvedTarget, folder->TargetDefault, NULL ); + if (folder->Parent && strcmpW( folder->Directory, folder->Parent )) + { + parent = msi_get_loaded_folder( package, folder->Parent ); + path = msi_build_directory_name( 3, parent->ResolvedTarget, folder->TargetDefault, NULL ); + } + else + path = msi_build_directory_name( 2, folder->TargetDefault, NULL ); } msi_clean_path( path ); if (folder->ResolvedTarget && !strcmpiW( path, folder->ResolvedTarget ))

1 0

Henri Verbeet : ddraw: Refuse to set a clip list if a clipper is already tracking a window.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 99e5e3ac0d3c8161968eaa781e8ecd6f1b9a9887 URL: http://source.winehq.org/git/wine.git/?a=commit;h=99e5e3ac0d3c8161968eaa781… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 4 23:34:53 2012 +0100 ddraw: Refuse to set a clip list if a clipper is already tracking a window. --- dlls/ddraw/clipper.c | 5 +++++ dlls/ddraw/tests/ddraw1.c | 2 +- dlls/ddraw/tests/ddraw2.c | 2 +- dlls/ddraw/tests/ddraw4.c | 2 +- dlls/ddraw/tests/ddraw7.c | 2 +- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/ddraw/clipper.c b/dlls/ddraw/clipper.c index c67a951..b3482e7 100644 --- a/dlls/ddraw/clipper.c +++ b/dlls/ddraw/clipper.c @@ -180,8 +180,13 @@ static HRESULT WINAPI ddraw_clipper_GetClipList(IDirectDrawClipper *iface, RECT *****************************************************************************/ static HRESULT WINAPI ddraw_clipper_SetClipList(IDirectDrawClipper *iface, RGNDATA *region, DWORD flags) { + struct ddraw_clipper *clipper = impl_from_IDirectDrawClipper(iface); + FIXME("iface %p, region %p, flags %#x stub!\n", iface, region, flags); + if (clipper->window) + return DDERR_CLIPPERISUSINGHWND; + return DD_OK; } diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c index e419e62..fdfa11f 100644 --- a/dlls/ddraw/tests/ddraw1.c +++ b/dlls/ddraw/tests/ddraw1.c @@ -248,7 +248,7 @@ static void test_clipper_blt(void) DeleteObject(r1); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); - todo_wine ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawClipper_SetHWnd(clipper, 0, NULL); ok(SUCCEEDED(hr), "Failed to set clipper window, hr %#x.\n", hr); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 5fb47c0..7b046be 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -255,7 +255,7 @@ static void test_clipper_blt(void) DeleteObject(r1); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); - todo_wine ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawClipper_SetHWnd(clipper, 0, NULL); ok(SUCCEEDED(hr), "Failed to set clipper window, hr %#x.\n", hr); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 134af22..26f5a0c 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -550,7 +550,7 @@ static void test_clipper_blt(void) DeleteObject(r1); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); - todo_wine ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawClipper_SetHWnd(clipper, 0, NULL); ok(SUCCEEDED(hr), "Failed to set clipper window, hr %#x.\n", hr); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 14477c1..9e5e564 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -543,7 +543,7 @@ static void test_clipper_blt(void) DeleteObject(r1); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0); - todo_wine ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_CLIPPERISUSINGHWND, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawClipper_SetHWnd(clipper, 0, NULL); ok(SUCCEEDED(hr), "Failed to set clipper window, hr %#x.\n", hr); hr = IDirectDrawClipper_SetClipList(clipper, rgn_data, 0);

1 0

Henri Verbeet : ddraw/tests: Add some clipper tests.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 3997457574a0e3f1c2fa095e230ab6d71211e892 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3997457574a0e3f1c2fa095e2… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Jan 4 23:34:52 2012 +0100 ddraw/tests: Add some clipper tests. --- dlls/ddraw/tests/ddraw1.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw2.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 866 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=3997457574a0e3f1c2fa0…

1 0

Dmitry Timoshkov : user32: Add an invalid window check to SetFocus.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: d09e973f7dd1e998fae548114f8b97c8b06cc1b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d09e973f7dd1e998fae548114… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Jan 5 17:58:06 2012 +0800 user32: Add an invalid window check to SetFocus. --- dlls/user32/focus.c | 5 +++++ dlls/user32/tests/msg.c | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/user32/focus.c b/dlls/user32/focus.c index 81169db..9fdae25 100644 --- a/dlls/user32/focus.c +++ b/dlls/user32/focus.c @@ -259,6 +259,11 @@ HWND WINAPI SetFocus( HWND hwnd ) { /* Check if we can set the focus to this window */ hwnd = WIN_GetFullHandle( hwnd ); + if (!IsWindow( hwnd )) + { + SetLastError( ERROR_INVALID_WINDOW_HANDLE ); + return 0; + } if (hwnd == previous) return previous; /* nothing to do */ for (;;) { diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index c14fc04..6fa4d10 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -13573,10 +13573,9 @@ static void test_SetFocus(void) SetLastError(0xdeadbeef); old_focus = SetFocus((HWND)0xdeadbeef); -todo_wine ok(GetLastError() == ERROR_INVALID_WINDOW_HANDLE, "expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); while (PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) DispatchMessage(&msg); - ok_sequence(WmEmptySeq, "SetFocus on an invalid window", TRUE); + ok_sequence(WmEmptySeq, "SetFocus on an invalid window", FALSE); ok(old_focus == 0, "expected old focus 0, got %p\n", old_focus); ok(GetActiveWindow() == parent, "expected active %p, got %p\n", parent, GetActiveWindow()); ok(GetFocus() == parent, "expected focus %p, got %p\n", parent, GetFocus());

1 0

Alexandre Julliard : gdi32: Draw rectangles in the order specified by the current arc direction.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Module: wine Branch: master Commit: 94ffc49e0284170472d1af82ca924f1e667bdfc8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=94ffc49e0284170472d1af82c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 5 15:29:22 2012 +0100 gdi32: Draw rectangles in the order specified by the current arc direction. --- dlls/gdi32/dibdrv/graphics.c | 21 ++++++++++++++++----- 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/dlls/gdi32/dibdrv/graphics.c b/dlls/gdi32/dibdrv/graphics.c index 1ba157b..bb14666 100644 --- a/dlls/gdi32/dibdrv/graphics.c +++ b/dlls/gdi32/dibdrv/graphics.c @@ -674,11 +674,22 @@ BOOL dibdrv_Rectangle( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) rect.bottom--; reset_dash_origin(pdev); - /* 4 pts going anti-clockwise starting from top-right */ - pts[0].x = pts[3].x = rect.right; - pts[0].y = pts[1].y = rect.top; - pts[1].x = pts[2].x = rect.left; - pts[2].y = pts[3].y = rect.bottom; + if (GetArcDirection( dev->hdc ) == AD_CLOCKWISE) + { + /* 4 pts going clockwise starting from bottom-right */ + pts[0].x = pts[3].x = rect.right; + pts[0].y = pts[1].y = rect.bottom; + pts[1].x = pts[2].x = rect.left; + pts[2].y = pts[3].y = rect.top; + } + else + { + /* 4 pts going anti-clockwise starting from top-right */ + pts[0].x = pts[3].x = rect.right; + pts[0].y = pts[1].y = rect.top; + pts[1].x = pts[2].x = rect.left; + pts[2].y = pts[3].y = rect.bottom; + } pdev->pen_lines(pdev, 4, pts, TRUE, outline);

1 0