October 2012 - Wine-Commits

Hans Leidekker : msi: Preserve strings with embedded nulls when copying from the string table to a record .
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 9588deb54c08ac1f9a858f700608476ab331afa9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9588deb54c08ac1f9a858f700… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 29 12:14:19 2012 +0100 msi: Preserve strings with embedded nulls when copying from the string table to a record. --- dlls/msi/msiquery.c | 7 +++---- dlls/msi/package.c | 2 +- dlls/msi/select.c | 5 +++-- dlls/msi/table.c | 9 +++++---- 4 files changed, 12 insertions(+), 11 deletions(-) diff --git a/dlls/msi/msiquery.c b/dlls/msi/msiquery.c index 4b826f8..451fddd 100644 --- a/dlls/msi/msiquery.c +++ b/dlls/msi/msiquery.c @@ -345,10 +345,9 @@ UINT msi_view_get_row(MSIDATABASE *db, MSIVIEW *view, UINT row, MSIRECORD **rec) if (type & MSITYPE_STRING) { - LPCWSTR sval; - - sval = msi_string_lookup(db->strings, ival, NULL); - MSI_RecordSetStringW(*rec, i, sval); + int len; + const WCHAR *sval = msi_string_lookup( db->strings, ival, &len ); + msi_record_set_string( *rec, i, sval, len ); } else { diff --git a/dlls/msi/package.c b/dlls/msi/package.c index a050b2e..6528b85 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -2181,7 +2181,7 @@ UINT msi_get_property( MSIDATABASE *db, LPCWSTR szName, } if (rc == ERROR_SUCCESS) - TRACE("returning %s for property %s\n", debugstr_w(szValueBuf), + TRACE("returning %s for property %s\n", debugstr_wn(szValueBuf, *pchValueBuf), debugstr_w(szName)); else if (rc == ERROR_MORE_DATA) TRACE("need %d sized buffer for %s\n", *pchValueBuf, diff --git a/dlls/msi/select.c b/dlls/msi/select.c index 982cf6a..ada4eed 100644 --- a/dlls/msi/select.c +++ b/dlls/msi/select.c @@ -276,8 +276,9 @@ static UINT msi_select_update(struct tagMSIVIEW *view, MSIRECORD *rec, UINT row) } else if (type & MSITYPE_STRING) { - str = MSI_RecordGetString(rec, i + 1); - r = MSI_RecordSetStringW(mod, col, str); + int len; + str = msi_record_get_string( rec, i + 1, &len ); + r = msi_record_set_string( mod, col, str, len ); } else { diff --git a/dlls/msi/table.c b/dlls/msi/table.c index 3276259..78c00b1 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -2340,12 +2340,13 @@ static MSIRECORD *msi_get_transform_record( const MSITABLEVIEW *tv, const string } else if( columns[i].type & MSITYPE_STRING ) { - LPCWSTR sval; + int len; + const WCHAR *sval; val = read_raw_int(rawdata, ofs, bytes_per_strref); - sval = msi_string_lookup( st, val, NULL ); - MSI_RecordSetStringW( rec, i+1, sval ); - TRACE(" field %d [%s]\n", i+1, debugstr_w(sval)); + sval = msi_string_lookup( st, val, &len ); + msi_record_set_string( rec, i+1, sval, len ); + TRACE(" field %d [%s]\n", i+1, debugstr_wn(sval, len)); ofs += bytes_per_strref; } else

1 0

Jacek Caban : urlmon.idl: Moved CopyBindInfo declaration to public header.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 413f60bf6991f7ea05c1848d5dddcfa232cbc01c URL: http://source.winehq.org/git/wine.git/?a=commit;h=413f60bf6991f7ea05c1848d5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Oct 26 17:38:18 2012 +0200 urlmon.idl: Moved CopyBindInfo declaration to public header. --- dlls/urlmon/urlmon_main.h | 2 -- include/urlmon.idl | 1 + 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/urlmon/urlmon_main.h b/dlls/urlmon/urlmon_main.h index 7260e94..4da7124 100644 --- a/dlls/urlmon/urlmon_main.h +++ b/dlls/urlmon/urlmon_main.h @@ -79,8 +79,6 @@ HRESULT bind_to_object(IMoniker*,IUri*,IBindCtx*,REFIID,void**ppv) DECLSPEC_HIDD HRESULT create_default_callback(IBindStatusCallback**) DECLSPEC_HIDDEN; HRESULT wrap_callback(IBindStatusCallback*,IBindStatusCallback**) DECLSPEC_HIDDEN; -HRESULT WINAPI CopyBindInfo(const BINDINFO *pcbiSrc, BINDINFO *pcbiDest) DECLSPEC_HIDDEN; - typedef struct ProtocolVtbl ProtocolVtbl; typedef struct { diff --git a/include/urlmon.idl b/include/urlmon.idl index e09b9ac..140852a 100644 --- a/include/urlmon.idl +++ b/include/urlmon.idl @@ -2080,6 +2080,7 @@ cpp_quote("HRESULT WINAPI RegisterFormatEnumerator(LPBC,IEnumFORMATETC*,DWORD);" cpp_quote("HRESULT WINAPI RevokeFormatEnumerator(LPBC,IEnumFORMATETC*);") cpp_quote("HRESULT WINAPI RevokeBindStatusCallback(LPBC,IBindStatusCallback*);") cpp_quote("HRESULT WINAPI CopyStgMedium(const STGMEDIUM*,STGMEDIUM*);") +cpp_quote("HRESULT WINAPI CopyBindInfo(const BINDINFO*,BINDINFO*);") cpp_quote("void WINAPI ReleaseBindInfo(BINDINFO*);") cpp_quote("HRESULT WINAPI UrlMkGetSessionOption(DWORD,LPVOID,DWORD,DWORD*,DWORD);") cpp_quote("HRESULT WINAPI UrlMkSetSessionOption(DWORD,LPVOID,DWORD,DWORD);")

1 0

Alexandre Julliard : user32: Don' t flush window surfaces while waiting for a sent message reply.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: b7582525a047018b08768e6672cc2c2f64fdcce5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b7582525a047018b08768e667… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Oct 29 11:18:06 2012 +0100 user32: Don't flush window surfaces while waiting for a sent message reply. --- dlls/user32/message.c | 6 ++++-- dlls/user32/winproc.c | 5 +---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index c1fe036..b934705 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -3682,8 +3682,8 @@ BOOL WINAPI DECLSPEC_HOTPATCH PeekMessageW( MSG *msg_out, HWND hwnd, UINT first, if (!peek_message( &msg, hwnd, first, last, flags, 0 )) { - if (flags & PM_NOYIELD) flush_window_surfaces( FALSE ); - else wow_handlers.wait_message( 0, NULL, 0, 0, 0 ); + flush_window_surfaces( !(flags & PM_NOYIELD) ); + if (!(flags & PM_NOYIELD)) wow_handlers.wait_message( 0, NULL, 0, 0, 0 ); return FALSE; } @@ -3739,6 +3739,7 @@ BOOL WINAPI DECLSPEC_HOTPATCH GetMessageW( MSG *msg, HWND hwnd, UINT first, UINT while (!peek_message( msg, hwnd, first, last, PM_REMOVE | (mask << 16), mask )) { + flush_window_surfaces( TRUE ); wow_handlers.wait_message( 1, &server_queue, INFINITE, mask, 0 ); } @@ -4071,6 +4072,7 @@ DWORD WINAPI MsgWaitForMultipleObjectsEx( DWORD count, CONST HANDLE *pHandles, for (i = 0; i < count; i++) handles[i] = pHandles[i]; handles[count] = get_server_queue_handle(); + flush_window_surfaces( TRUE ); return wow_handlers.wait_message( count+1, handles, timeout, mask, flags ); } diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index 33afbdd..3b13b82 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -1124,10 +1124,7 @@ static LRESULT WINAPI StaticWndProcW( HWND hwnd, UINT msg, WPARAM wParam, LPARAM static DWORD wait_message( DWORD count, CONST HANDLE *handles, DWORD timeout, DWORD mask, DWORD flags ) { - DWORD ret; - - flush_window_surfaces( TRUE ); - ret = USER_Driver->pMsgWaitForMultipleObjectsEx( count, handles, timeout, mask, flags ); + DWORD ret = USER_Driver->pMsgWaitForMultipleObjectsEx( count, handles, timeout, mask, flags ); if (ret == WAIT_TIMEOUT && !count && !timeout) NtYieldExecution(); return ret; }

1 0

Alexandre Julliard : winex11: Delay mapping a layered window until its attributes are set.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 3ad40bf64732cbef4ba199a45eefa12f4b491419 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3ad40bf64732cbef4ba199a45… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Oct 29 14:37:56 2012 +0100 winex11: Delay mapping a layered window until its attributes are set. --- dlls/winex11.drv/window.c | 21 ++++++++++++++++++++- dlls/winex11.drv/x11drv.h | 1 + 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 7819a54..1a9b27c 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -1500,6 +1500,7 @@ void CDECL X11DRV_SetWindowStyle( HWND hwnd, INT offset, STYLESTRUCT *style ) if (offset == GWL_EXSTYLE && (changed & WS_EX_LAYERED)) /* changing WS_EX_LAYERED resets attributes */ { + data->layered = FALSE; set_window_visual( data, &default_visual ); sync_window_opacity( data->display, data->whole_window, 0, 0, 0 ); if (data->surface) set_surface_color_key( data->surface, CLR_INVALID ); @@ -2187,10 +2188,13 @@ void CDECL X11DRV_WindowPosChanged( HWND hwnd, HWND insert_after, UINT swp_flags if (!data->mapped) { BOOL needs_icon = !data->icon_pixmap; + BOOL needs_map = TRUE; + /* layered windows are mapped only once their attributes are set */ + if (GetWindowLongW( hwnd, GWL_EXSTYLE ) & WS_EX_LAYERED) needs_map = data->layered; release_win_data( data ); if (needs_icon) fetch_icon_data( hwnd, 0, 0 ); - map_window( hwnd, new_style ); + if (needs_map) map_window( hwnd, new_style ); return; } else if ((swp_flags & SWP_STATECHANGED) && (!data->iconic != !(new_style & WS_MINIMIZE))) @@ -2336,6 +2340,20 @@ void CDECL X11DRV_SetLayeredWindowAttributes( HWND hwnd, COLORREF key, BYTE alph sync_window_opacity( data->display, data->whole_window, key, alpha, flags ); if (data->surface) set_surface_color_key( data->surface, (flags & LWA_COLORKEY) ? key : CLR_INVALID ); + + data->layered = TRUE; + if (!data->mapped) /* mapping is delayed until attributes are set */ + { + DWORD style = GetWindowLongW( data->hwnd, GWL_STYLE ); + + if ((style & WS_VISIBLE) && + ((style & WS_MINIMIZE) || is_window_rect_mapped( &data->window_rect ))) + { + release_win_data( data ); + map_window( hwnd, style ); + return; + } + } release_win_data( data ); } else @@ -2371,6 +2389,7 @@ BOOL CDECL X11DRV_UpdateLayeredWindow( HWND hwnd, const UPDATELAYEREDWINDOWINFO if (!(data = get_win_data( hwnd ))) return FALSE; + data->layered = TRUE; if (!data->embedded && argb_visual.visualid) set_window_visual( data, &argb_visual ); rect = *window_rect; diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h index 99f045f..5a34e75 100644 --- a/dlls/winex11.drv/x11drv.h +++ b/dlls/winex11.drv/x11drv.h @@ -558,6 +558,7 @@ struct x11drv_win_data BOOL iconic : 1; /* is window in iconic state? */ BOOL embedded : 1; /* is window an XEMBED client? */ BOOL shaped : 1; /* is window using a custom region shape? */ + BOOL layered : 1; /* is window layered and with valid attributes? */ int wm_state; /* current value of the WM_STATE property */ DWORD net_wm_state; /* bit mask of active x11drv_net_wm_state values */ Window embedder; /* window id of embedder */

1 0

Jacek Caban : vbscript: Added support for negative constants.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: a41ba1c3e83099ea6ecc30ce7b9e1ceddca27d82 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a41ba1c3e83099ea6ecc30ce7… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Oct 29 11:52:31 2012 +0100 vbscript: Added support for negative constants. --- dlls/vbscript/parser.y | 19 ++++++++++++++----- dlls/vbscript/tests/lang.vbs | 12 +++++++++++- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/dlls/vbscript/parser.y b/dlls/vbscript/parser.y index 8a2a9e3..45f9169 100644 --- a/dlls/vbscript/parser.y +++ b/dlls/vbscript/parser.y @@ -125,6 +125,7 @@ static const WCHAR propertyW[] = {'p','r','o','p','e','r','t','y',0}; %type <expression> Expression LiteralExpression PrimaryExpression EqualityExpression CallExpression %type <expression> ConcatExpression AdditiveExpression ModExpression IntdivExpression MultiplicativeExpression ExpExpression %type <expression> NotExpression UnaryExpression AndExpression OrExpression XorExpression EqvExpression +%type <expression> ConstExpression NumericLiteralExpression %type <member> MemberExpression %type <expression> Arguments_opt ArgumentList_opt Step_opt ExpressionList %type <bool> OptionExplicit_opt DoType @@ -218,7 +219,11 @@ ConstDeclList | ConstDecl ',' ConstDeclList { $1->next = $3; $$ = $1; } ConstDecl - : Identifier '=' LiteralExpression { $$ = new_const_decl(ctx, $1, $3); CHECK_ERROR; } + : Identifier '=' ConstExpression { $$ = new_const_decl(ctx, $1, $3); CHECK_ERROR; } + +ConstExpression + : LiteralExpression { $$ = $1; } + | '-' NumericLiteralExpression { $$ = new_unary_expression(ctx, EXPR_NEG, $2); CHECK_ERROR; } DoType : tWHILE { $$ = TRUE; } @@ -354,14 +359,18 @@ LiteralExpression : tTRUE { $$ = new_bool_expression(ctx, VARIANT_TRUE); CHECK_ERROR; } | tFALSE { $$ = new_bool_expression(ctx, VARIANT_FALSE); CHECK_ERROR; } | tString { $$ = new_string_expression(ctx, $1); CHECK_ERROR; } - | tShort { $$ = new_long_expression(ctx, EXPR_USHORT, $1); CHECK_ERROR; } - | '0' { $$ = new_long_expression(ctx, EXPR_USHORT, 0); CHECK_ERROR; } - | tLong { $$ = new_long_expression(ctx, EXPR_ULONG, $1); CHECK_ERROR; } - | tDouble { $$ = new_double_expression(ctx, $1); CHECK_ERROR; } + | NumericLiteralExpression { $$ = $1; } | tEMPTY { $$ = new_expression(ctx, EXPR_EMPTY, 0); CHECK_ERROR; } | tNULL { $$ = new_expression(ctx, EXPR_NULL, 0); CHECK_ERROR; } | tNOTHING { $$ = new_expression(ctx, EXPR_NOTHING, 0); CHECK_ERROR; } +NumericLiteralExpression + : tShort { $$ = new_long_expression(ctx, EXPR_USHORT, $1); CHECK_ERROR; } + | '0' { $$ = new_long_expression(ctx, EXPR_USHORT, 0); CHECK_ERROR; } + | tLong { $$ = new_long_expression(ctx, EXPR_ULONG, $1); CHECK_ERROR; } + | tDouble { $$ = new_double_expression(ctx, $1); CHECK_ERROR; } + + PrimaryExpression : '(' Expression ')' { $$ = new_unary_expression(ctx, EXPR_BRACKETS, $2); } | tME { $$ = new_expression(ctx, EXPR_ME, 0); CHECK_ERROR; } diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs index 76f4003..8cffc7f 100644 --- a/dlls/vbscript/tests/lang.vbs +++ b/dlls/vbscript/tests/lang.vbs @@ -912,9 +912,19 @@ Call obj.test(obj) Call ok(getVT(test) = "VT_DISPATCH", "getVT(test) = " & getVT(test)) Call ok(Me is Test, "Me is not Test") -Const c1 = 1, c2 = 2 +Const c1 = 1, c2 = 2, c3 = -3 Call ok(c1 = 1, "c1 = " & c1) Call ok(getVT(c1) = "VT_I2", "getVT(c1) = " & getVT(c1)) +Call ok(c3 = -3, "c3 = " & c3) +Call ok(getVT(c3) = "VT_I2", "getVT(c3) = " & getVT(c3)) + +Const cb = True, cs = "test", cnull = null +Call ok(cb, "cb = " & cb) +Call ok(getVT(cb) = "VT_BOOL", "getVT(cb) = " & getVT(cb)) +Call ok(cs = "test", "cs = " & cs) +Call ok(getVT(cs) = "VT_BSTR", "getVT(cs) = " & getVT(cs)) +Call ok(isNull(cnull), "cnull = " & cnull) +Call ok(getVT(cnull) = "VT_NULL", "getVT(cnull) = " & getVT(cnull)) if false then Const conststr = "str" Call ok(conststr = "str", "conststr = " & conststr)

1 0

Hans Leidekker : msi: Add more tests for embedded nulls in string property values.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 652863f4d59ac9cf434f708092217dd26eea4cb2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=652863f4d59ac9cf434f70809… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 29 12:12:27 2012 +0100 msi: Add more tests for embedded nulls in string property values. --- dlls/msi/tests/package.c | 54 ++++++++++++++++++++++++++++++++++++++------- 1 files changed, 45 insertions(+), 9 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 5d56afe..85f0d86 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -593,6 +593,17 @@ static UINT create_inilocator_table( MSIHANDLE hdb ) "PRIMARY KEY `Signature_`)" ); } +static UINT create_custom_action_table( MSIHANDLE hdb ) +{ + return run_query( hdb, + "CREATE TABLE `CustomAction` (" + "`Action` CHAR(72) NOT NULL, " + "`Type` SHORT NOT NULL, " + "`Source` CHAR(75), " + "`Target` CHAR(255) " + "PRIMARY KEY `Action`)" ); +} + #define make_add_entry(type, qtext) \ static UINT add##_##type##_##entry( MSIHANDLE hdb, const char *values ) \ { \ @@ -672,6 +683,10 @@ make_add_entry(inilocator, "(`Signature_`, `FileName`, `Section`, `Key`, `Field`, `Type`) " "VALUES( %s )") +make_add_entry(custom_action, + "INSERT INTO `CustomAction` " + "(`Action`, `Type`, `Source`, `Target`) VALUES( %s )") + static UINT add_reglocator_entry( MSIHANDLE hdb, const char *sig, UINT root, const char *path, const char *name, UINT type ) { @@ -2139,10 +2154,10 @@ static void test_props(void) DeleteFile(msifile); } -static BOOL find_prop_in_property(MSIHANDLE hdb, LPCSTR prop, LPCSTR val) +static BOOL find_prop_in_property(MSIHANDLE hdb, LPCSTR prop, LPCSTR val, int len) { MSIHANDLE hview, hrec; - BOOL found; + BOOL found = FALSE; CHAR buffer[MAX_PATH]; DWORD sz; UINT r; @@ -2152,7 +2167,8 @@ static BOOL find_prop_in_property(MSIHANDLE hdb, LPCSTR prop, LPCSTR val) r = MsiViewExecute(hview, 0); ok(r == ERROR_SUCCESS, "MsiViewExecute failed\n"); - found = FALSE; + if (len < 0) len = lstrlenA(val); + while (r == ERROR_SUCCESS && !found) { r = MsiViewFetch(hview, &hrec); @@ -2164,16 +2180,17 @@ static BOOL find_prop_in_property(MSIHANDLE hdb, LPCSTR prop, LPCSTR val) { sz = MAX_PATH; r = MsiRecordGetString(hrec, 2, buffer, &sz); - if (r == ERROR_SUCCESS && !lstrcmpA(buffer, val)) + if (r == ERROR_SUCCESS && !memcmp(buffer, val, len) && !buffer[len]) + { + ok(sz == len, "wrong size %u\n", sz); found = TRUE; + } } MsiCloseHandle(hrec); } - MsiViewClose(hview); MsiCloseHandle(hview); - return found; } @@ -2249,6 +2266,12 @@ static void test_property_table(void) r = add_property_entry(hdb, "'prop', 'val'"); ok(r == ERROR_SUCCESS, "cannot add property: %d\n", r); + r = create_custom_action_table(hdb); + ok(r == ERROR_SUCCESS, "cannot create CustomAction table: %d\n", r); + + r = add_custom_action_entry( hdb, "'EmbedNull', 51, 'prop2', '[~]np'" ); + ok( r == ERROR_SUCCESS, "cannot add custom action: %d\n", r); + r = package_from_db(hdb, &hpkg); ok(r == ERROR_SUCCESS, "failed to create package %u\n", r); @@ -2261,7 +2284,7 @@ static void test_property_table(void) hdb = MsiGetActiveDatabase(hpkg); - found = find_prop_in_property(hdb, "prop", "val"); + found = find_prop_in_property(hdb, "prop", "val", -1); ok(found, "prop should be in the _Property table\n"); r = add_property_entry(hdb, "'dantes', 'mercedes'"); @@ -2271,7 +2294,7 @@ static void test_property_table(void) r = do_query(hdb, query, &hrec); ok(r == ERROR_BAD_QUERY_SYNTAX, "Expected ERROR_BAD_QUERY_SYNTAX, got %d\n", r); - found = find_prop_in_property(hdb, "dantes", "mercedes"); + found = find_prop_in_property(hdb, "dantes", "mercedes", -1); ok(found == FALSE, "dantes should not be in the _Property table\n"); sz = MAX_PATH; @@ -2283,9 +2306,22 @@ static void test_property_table(void) r = MsiSetProperty(hpkg, "dantes", "mercedes"); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); - found = find_prop_in_property(hdb, "dantes", "mercedes"); + found = find_prop_in_property(hdb, "dantes", "mercedes", -1); ok(found == TRUE, "dantes should be in the _Property table\n"); + r = MsiDoAction( hpkg, "EmbedNull" ); + ok( r == ERROR_SUCCESS, "EmbedNull failed: %d\n", r); + + sz = MAX_PATH; + memset( buffer, 'a', sizeof(buffer) ); + r = MsiGetProperty( hpkg, "prop2", buffer, &sz ); + ok( r == ERROR_SUCCESS, "get property failed: %d\n", r); + todo_wine ok( !memcmp( buffer, "\0np", sizeof("\0np") ), "wrong value\n"); + todo_wine ok( sz == sizeof("\0np") - 1, "got %u\n", sz ); + + found = find_prop_in_property(hdb, "prop2", "\0np", 3); + todo_wine ok(found == TRUE, "prop2 should be in the _Property table\n"); + MsiCloseHandle(hdb); MsiCloseHandle(hpkg); DeleteFile(msifile);

1 0

Hans Leidekker : msi: Add support for storing strings with embedded nulls in the string table.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 6950ac1d1cbd842f1de0050585a0bbbe55fe1635 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6950ac1d1cbd842f1de005058… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 29 12:12:50 2012 +0100 msi: Add support for storing strings with embedded nulls in the string table. --- dlls/msi/msipriv.h | 4 +- dlls/msi/msiquery.c | 2 +- dlls/msi/storages.c | 2 +- dlls/msi/streams.c | 2 +- dlls/msi/string.c | 73 +++++++++++++++++++++++++++++++------------------- dlls/msi/table.c | 29 ++++++++++---------- dlls/msi/where.c | 4 +- 7 files changed, 66 insertions(+), 50 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6950ac1d1cbd842f1de00…

1 0

Hans Leidekker : msi: Get rid of MSI_RecordSetStringA.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 8d28cc0ac7e054311d31a188e158b6adcacbf263 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d28cc0ac7e054311d31a188e… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 29 12:13:29 2012 +0100 msi: Get rid of MSI_RecordSetStringA. --- dlls/msi/record.c | 34 ++++++++-------------------------- 1 files changed, 8 insertions(+), 26 deletions(-) diff --git a/dlls/msi/record.c b/dlls/msi/record.c index 3bf1ee5..263ea2c 100644 --- a/dlls/msi/record.c +++ b/dlls/msi/record.c @@ -574,45 +574,27 @@ UINT WINAPI MsiRecordDataSize(MSIHANDLE handle, UINT iField) return ret; } -static UINT MSI_RecordSetStringA( MSIRECORD *rec, UINT iField, LPCSTR szValue ) -{ - LPWSTR str; - - TRACE("%p %d %s\n", rec, iField, debugstr_a(szValue)); - - if( iField > rec->count ) - return ERROR_INVALID_FIELD; - - MSI_FreeField( &rec->fields[iField] ); - if( szValue && szValue[0] ) - { - str = strdupAtoW( szValue ); - rec->fields[iField].type = MSIFIELD_WSTR; - rec->fields[iField].u.szwVal = str; - } - else - { - rec->fields[iField].type = MSIFIELD_NULL; - rec->fields[iField].u.szwVal = NULL; - } - - return 0; -} - UINT WINAPI MsiRecordSetStringA( MSIHANDLE handle, UINT iField, LPCSTR szValue ) { + WCHAR *valueW = NULL; MSIRECORD *rec; UINT ret; TRACE("%d %d %s\n", handle, iField, debugstr_a(szValue)); + if (szValue && !(valueW = strdupAtoW( szValue ))) return ERROR_OUTOFMEMORY; + rec = msihandle2msiinfo( handle, MSIHANDLETYPE_RECORD ); if( !rec ) + { + msi_free( valueW ); return ERROR_INVALID_HANDLE; + } msiobj_lock( &rec->hdr ); - ret = MSI_RecordSetStringA( rec, iField, szValue ); + ret = MSI_RecordSetStringW( rec, iField, valueW ); msiobj_unlock( &rec->hdr ); msiobj_release( &rec->hdr ); + msi_free( valueW ); return ret; }

1 0

Hwang YunSong : po: Update Korean translation.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: 3370d09cb81de45d47f8e0a2de8b0e3db6068b92 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3370d09cb81de45d47f8e0a2d… Author: Hwang YunSong <hys545(a)dreamwiz.com> Date: Mon Oct 29 11:24:59 2012 +0900 po: Update Korean translation. --- po/ko.po | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/po/ko.po b/po/ko.po index 2e68b5d..e121a68 100644 --- a/po/ko.po +++ b/po/ko.po @@ -3441,7 +3441,7 @@ msgid "" "After disabling or enabling a device, the connected joysticks won't be " "updated here until you restart this applet." msgstr "" -"장치를 사용하거나 안사용하게 한 후에, 연결된 조이스틱은 애플랫을 다시 시작하" +"장치를 사용하거나 안사용하게 한 후에, 연결된 조이스틱은 애플릿을 다시 시작하" "기까지는 작동하지 않을 것입니다." #: joy.rc:47 @@ -10043,6 +10043,7 @@ msgstr "(예|아니오|모두)" msgid "" "Can't recognize '%1' as an internal or external command, or batch script.\n" msgstr "" +"'%1'을 내부나 외부 명령어,나 배치 스크립트로 인식할 수 없습니다.\n" #: dxdiag.rc:27 msgid "DirectX Diagnostic Tool"

1 0

Hans Leidekker : msi: Add a test for embedded nulls in string property values.
by Alexandre Julliard Oct. 29, 2012

Oct. 29, 2012

Module: wine Branch: master Commit: a1c4d2c97731644f4e6265fb71fe5c7b66b06147 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a1c4d2c97731644f4e6265fb7… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Mon Oct 29 12:11:55 2012 +0100 msi: Add a test for embedded nulls in string property values. --- dlls/msi/tests/format.c | 29 ++++++++++++++++++++++++++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/dlls/msi/tests/format.c b/dlls/msi/tests/format.c index 3ecfc66..d91241d 100644 --- a/dlls/msi/tests/format.c +++ b/dlls/msi/tests/format.c @@ -2530,6 +2530,9 @@ static void test_formatrecord_tables(void) r = add_custom_action_entry( hdb, "'EscapeIt3', 51, 'prop', '[abcd\\xefgh]'" ); ok( r == ERROR_SUCCESS, "cannot add custom action: %d\n", r); + r = add_custom_action_entry( hdb, "'EmbedNull', 51, 'prop', '[~]np'" ); + ok( r == ERROR_SUCCESS, "cannot add custom action: %d\n", r); + r = package_from_db( hdb, &hpkg ); if (r == ERROR_INSTALL_PACKAGE_REJECTED) { @@ -2661,7 +2664,7 @@ static void test_formatrecord_tables(void) /* custom action 51, escaped text 1 */ r = MsiDoAction( hpkg, "EscapeIt1" ); - ok( r == ERROR_SUCCESS, "EscapeIt failed: %d\n", r); + ok( r == ERROR_SUCCESS, "EscapeIt1 failed: %d\n", r); size = MAX_PATH; r = MsiGetProperty( hpkg, "prop", buf, &size ); @@ -2670,7 +2673,7 @@ static void test_formatrecord_tables(void) /* custom action 51, escaped text 2 */ r = MsiDoAction( hpkg, "EscapeIt2" ); - ok( r == ERROR_SUCCESS, "EscapeIt failed: %d\n", r); + ok( r == ERROR_SUCCESS, "EscapeIt2 failed: %d\n", r); size = MAX_PATH; r = MsiGetProperty( hpkg, "prop", buf, &size ); @@ -2679,13 +2682,33 @@ static void test_formatrecord_tables(void) /* custom action 51, escaped text 3 */ r = MsiDoAction( hpkg, "EscapeIt3" ); - ok( r == ERROR_SUCCESS, "EscapeIt failed: %d\n", r); + ok( r == ERROR_SUCCESS, "EscapeIt3 failed: %d\n", r); size = MAX_PATH; r = MsiGetProperty( hpkg, "prop", buf, &size ); ok( r == ERROR_SUCCESS, "get property failed: %d\n", r); ok( !lstrcmp( buf, "" ), "Expected '', got %s\n", buf); + /* custom action 51, embedded null */ + r = MsiDoAction( hpkg, "EmbedNull" ); + ok( r == ERROR_SUCCESS, "EmbedNull failed: %d\n", r); + + size = MAX_PATH; + memset( buf, 'a', sizeof(buf) ); + r = MsiGetProperty( hpkg, "prop", buf, &size ); + ok( r == ERROR_SUCCESS, "get property failed: %d\n", r); + todo_wine ok( !memcmp( buf, "\0np", sizeof("\0np") ), "wrong value\n"); + todo_wine ok( size == sizeof("\0np") - 1, "got %u\n", size ); + + r = MsiSetProperty( hpkg, "prop", "[~]np" ); + ok( r == ERROR_SUCCESS, "cannot set property: %d\n", r); + + size = MAX_PATH; + memset( buf, 'a', sizeof(buf) ); + r = MsiGetProperty( hpkg, "prop", buf, &size ); + ok( r == ERROR_SUCCESS, "get property failed: %d\n", r); + ok( !lstrcmp( buf, "[~]np" ), "Expected '[~]np', got %s\n", buf); + sprintf( expected, "1: %sI am a really long directory\\ ", root); /* component with INSTALLSTATE_LOCAL */

1 0