May 2012 - Wine-Commits - list.winehq.org

Henri Verbeet : wined3d: The wined3d object doesn't need a parent.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 92671487050dfe0d377eb0248b9d458e7156e3ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=92671487050dfe0d377eb0248… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 2 21:47:57 2012 +0200 wined3d: The wined3d object doesn't need a parent. --- dlls/d3d8/d3d8_main.c | 2 +- dlls/d3d9/d3d9_main.c | 2 +- dlls/ddraw/ddraw.c | 3 +-- dlls/dxgi/factory.c | 2 +- dlls/wined3d/directx.c | 10 +--------- dlls/wined3d/wined3d.spec | 3 +-- dlls/wined3d/wined3d_main.c | 4 ++-- dlls/wined3d/wined3d_private.h | 3 +-- include/wine/wined3d.h | 3 +-- 9 files changed, 10 insertions(+), 22 deletions(-) diff --git a/dlls/d3d8/d3d8_main.c b/dlls/d3d8/d3d8_main.c index 7e7da43..46f6a5c 100644 --- a/dlls/d3d8/d3d8_main.c +++ b/dlls/d3d8/d3d8_main.c @@ -45,7 +45,7 @@ IDirect3D8* WINAPI DECLSPEC_HOTPATCH Direct3DCreate8(UINT SDKVersion) { object->IDirect3D8_iface.lpVtbl = &Direct3D8_Vtbl; object->ref = 1; - object->WineD3D = wined3d_create(8, WINED3D_LEGACY_DEPTH_BIAS, &object->IDirect3D8_iface); + object->WineD3D = wined3d_create(8, WINED3D_LEGACY_DEPTH_BIAS); TRACE("Created Direct3D object @ %p, WineObj @ %p\n", object, object->WineD3D); diff --git a/dlls/d3d9/d3d9_main.c b/dlls/d3d9/d3d9_main.c index abb98f3..6eed9b7 100644 --- a/dlls/d3d9/d3d9_main.c +++ b/dlls/d3d9/d3d9_main.c @@ -40,7 +40,7 @@ IDirect3D9* WINAPI DECLSPEC_HOTPATCH Direct3DCreate9(UINT SDKVersion) { object->ref = 1; wined3d_mutex_lock(); - object->WineD3D = wined3d_create(9, 0, object); + object->WineD3D = wined3d_create(9, 0); wined3d_mutex_unlock(); TRACE("SDKVersion = %x, Created Direct3D object @ %p, WineObj @ %p\n", SDKVersion, object, object->WineD3D); diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 4da67ef..057e6e1 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -5559,8 +5559,7 @@ HRESULT ddraw_init(struct ddraw *ddraw, enum wined3d_device_type device_type) ddraw->orig_width = GetSystemMetrics(SM_CXSCREEN); ddraw->orig_height = GetSystemMetrics(SM_CYSCREEN); - ddraw->wined3d = wined3d_create(7, WINED3D_LEGACY_DEPTH_BIAS, - &ddraw->IDirectDraw7_iface); + ddraw->wined3d = wined3d_create(7, WINED3D_LEGACY_DEPTH_BIAS); if (!ddraw->wined3d) { WARN("Failed to create a wined3d object.\n"); diff --git a/dlls/dxgi/factory.c b/dlls/dxgi/factory.c index d898c08..045baf8 100644 --- a/dlls/dxgi/factory.c +++ b/dlls/dxgi/factory.c @@ -300,7 +300,7 @@ HRESULT dxgi_factory_init(struct dxgi_factory *factory) factory->refcount = 1; EnterCriticalSection(&dxgi_cs); - factory->wined3d = wined3d_create(10, 0, factory); + factory->wined3d = wined3d_create(10, 0); if (!factory->wined3d) { LeaveCriticalSection(&dxgi_cs); diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 3ae0945..9e3a86b 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -5031,13 +5031,6 @@ HRESULT CDECL wined3d_device_create(struct wined3d *wined3d, UINT adapter_idx, e return WINED3D_OK; } -void * CDECL wined3d_get_parent(const struct wined3d *wined3d) -{ - TRACE("wined3d %p.\n", wined3d); - - return wined3d->parent; -} - static void WINE_GLAPI invalid_func(const void *data) { ERR("Invalid vertex attribute function called\n"); @@ -5506,11 +5499,10 @@ const struct wined3d_parent_ops wined3d_null_parent_ops = }; /* Do not call while under the GL lock. */ -HRESULT wined3d_init(struct wined3d *wined3d, UINT version, DWORD flags, void *parent) +HRESULT wined3d_init(struct wined3d *wined3d, UINT version, DWORD flags) { wined3d->dxVersion = version; wined3d->ref = 1; - wined3d->parent = parent; wined3d->flags = flags; if (!InitAdapters(wined3d)) diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index f0821fb..679754f 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -6,7 +6,7 @@ @ cdecl wined3d_check_device_format_conversion(ptr long long long long) @ cdecl wined3d_check_device_multisample_type(ptr long long long long long ptr) @ cdecl wined3d_check_device_type(ptr long long long long long) -@ cdecl wined3d_create(long long ptr) +@ cdecl wined3d_create(long long) @ cdecl wined3d_decref(ptr) @ cdecl wined3d_enum_adapter_modes(ptr long long long ptr) @ cdecl wined3d_get_adapter_count(ptr) @@ -15,7 +15,6 @@ @ cdecl wined3d_get_adapter_mode_count(ptr long long) @ cdecl wined3d_get_adapter_monitor(ptr long) @ cdecl wined3d_get_device_caps(ptr long long ptr) -@ cdecl wined3d_get_parent(ptr) @ cdecl wined3d_incref(ptr) @ cdecl wined3d_register_software_device(ptr ptr) diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c index ad7a5fc..4e2226e 100644 --- a/dlls/wined3d/wined3d_main.c +++ b/dlls/wined3d/wined3d_main.c @@ -90,7 +90,7 @@ struct wined3d_settings wined3d_settings = }; /* Do not call while under the GL lock. */ -struct wined3d * CDECL wined3d_create(UINT version, DWORD flags, void *parent) +struct wined3d * CDECL wined3d_create(UINT version, DWORD flags) { struct wined3d *object; HRESULT hr; @@ -102,7 +102,7 @@ struct wined3d * CDECL wined3d_create(UINT version, DWORD flags, void *parent) return NULL; } - hr = wined3d_init(object, version, flags, parent); + hr = wined3d_init(object, version, flags); if (FAILED(hr)) { WARN("Failed to initialize wined3d object, hr %#x.\n", hr); diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 94da438..976c4f4 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1656,14 +1656,13 @@ void wined3d_get_draw_rect(const struct wined3d_state *state, RECT *rect) DECLSP struct wined3d { LONG ref; - void *parent; DWORD flags; UINT dxVersion; UINT adapter_count; struct wined3d_adapter adapters[1]; }; -HRESULT wined3d_init(struct wined3d *wined3d, UINT version, DWORD flags, void *parent) DECLSPEC_HIDDEN; +HRESULT wined3d_init(struct wined3d *wined3d, UINT version, DWORD flags) DECLSPEC_HIDDEN; BOOL wined3d_register_window(HWND window, struct wined3d_device *device) DECLSPEC_HIDDEN; void wined3d_unregister_window(HWND window) DECLSPEC_HIDDEN; diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 9f32a8f..2006c92 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2009,7 +2009,7 @@ HRESULT __cdecl wined3d_check_device_multisample_type(const struct wined3d *wine HRESULT __cdecl wined3d_check_device_type(const struct wined3d *wined3d, UINT adapter_idx, enum wined3d_device_type device_type, enum wined3d_format_id display_format_id, enum wined3d_format_id backbuffer_format_id, BOOL windowed); -struct wined3d * __cdecl wined3d_create(UINT dxVersion, DWORD flags, void *parent); +struct wined3d * __cdecl wined3d_create(UINT version, DWORD flags); ULONG __cdecl wined3d_decref(struct wined3d *wined3d); HRESULT __cdecl wined3d_enum_adapter_modes(const struct wined3d *wined3d, UINT adapter_idx, enum wined3d_format_id format_id, UINT mode_idx, struct wined3d_display_mode *mode); @@ -2023,7 +2023,6 @@ UINT __cdecl wined3d_get_adapter_mode_count(const struct wined3d *wined3d, HMONITOR __cdecl wined3d_get_adapter_monitor(const struct wined3d *wined3d, UINT adapter_idx); HRESULT __cdecl wined3d_get_device_caps(const struct wined3d *wined3d, UINT adapter_idx, enum wined3d_device_type device_type, WINED3DCAPS *caps); -void * __cdecl wined3d_get_parent(const struct wined3d *wined3d); ULONG __cdecl wined3d_incref(struct wined3d *wined3d); HRESULT __cdecl wined3d_register_software_device(struct wined3d *wined3d, void *init_function);

1 0

Henri Verbeet : ddraw: Get rid of the flag_info typedef.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 5b680d60238a571404ec9a52acb8bbb529124f4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=5b680d60238a571404ec9a52a… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 2 21:47:56 2012 +0200 ddraw: Get rid of the flag_info typedef. --- dlls/ddraw/ddraw_private.h | 6 +- dlls/ddraw/utils.c | 339 ++++++++++++++++++++++---------------------- 2 files changed, 173 insertions(+), 172 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=5b680d60238a571404ec9…

1 0

Henri Verbeet : d3d9: Properly retrieve an interface pointer in d3d9_texture_3d_UnlockBox().
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 6b9f151c9e1e206949087e3435cc6064b73e95a1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b9f151c9e1e206949087e343… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 2 21:47:55 2012 +0200 d3d9: Properly retrieve an interface pointer in d3d9_texture_3d_UnlockBox(). --- dlls/d3d9/texture.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/d3d9/texture.c b/dlls/d3d9/texture.c index 6544edc..f453f90 100644 --- a/dlls/d3d9/texture.c +++ b/dlls/d3d9/texture.c @@ -1207,6 +1207,7 @@ static HRESULT WINAPI d3d9_texture_3d_UnlockBox(IDirect3DVolumeTexture9 *iface, { struct d3d9_texture *texture = impl_from_IDirect3DVolumeTexture9(iface); struct wined3d_resource *sub_resource; + IDirect3DVolume9Impl *volume_impl; HRESULT hr; TRACE("iface %p, level %u.\n", iface, level); @@ -1215,7 +1216,10 @@ static HRESULT WINAPI d3d9_texture_3d_UnlockBox(IDirect3DVolumeTexture9 *iface, if (!(sub_resource = wined3d_texture_get_sub_resource(texture->wined3d_texture, level))) hr = D3DERR_INVALIDCALL; else - hr = IDirect3DVolume9_UnlockBox((IDirect3DVolume9 *)wined3d_resource_get_parent(sub_resource)); + { + volume_impl = wined3d_resource_get_parent(sub_resource); + hr = IDirect3DVolume9_UnlockBox(&volume_impl->IDirect3DVolume9_iface); + } wined3d_mutex_unlock(); return hr;

1 0

Austin English : kernel32: Only print a fixme once for FlushProcessWriteBuffers.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: b4432a6274dd4456acee3fc61cb980683f333657 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b4432a6274dd4456acee3fc61… Author: Austin English <austinenglish(a)gmail.com> Date: Wed May 2 17:00:36 2012 -0500 kernel32: Only print a fixme once for FlushProcessWriteBuffers. --- dlls/kernel32/process.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index dca8561..1edf9ea 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -3863,5 +3863,8 @@ BOOL WINAPI GetProcessDEPPolicy(HANDLE process, LPDWORD flags, PBOOL permanent) */ VOID WINAPI FlushProcessWriteBuffers(void) { - FIXME(": stub\n"); + static int once = 0; + + if (!once++) + FIXME(": stub\n"); }

1 0

Henri Verbeet : wined3d: Determine index buffer location based on vertex buffer locations.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 29893d81621b50e3acca1f2c34767867a9256ecb URL: http://source.winehq.org/git/wine.git/?a=commit;h=29893d81621b50e3acca1f2c3… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 2 21:47:58 2012 +0200 wined3d: Determine index buffer location based on vertex buffer locations. --- dlls/wined3d/device.c | 11 +++++++++++ dlls/wined3d/drawprim.c | 2 +- dlls/wined3d/state.c | 3 ++- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 0b0b600..c659e47 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -404,6 +404,7 @@ void device_update_stream_info(struct wined3d_device *device, const struct wined { struct wined3d_stream_info *stream_info = &device->strided_streams; const struct wined3d_state *state = &device->stateBlock->state; + DWORD prev_all_vbo = stream_info->all_vbo; if (device->up_strided) { @@ -445,6 +446,16 @@ void device_update_stream_info(struct wined3d_device *device, const struct wined device->useDrawStridedSlow = FALSE; } } + + if (state->index_buffer && !state->user_stream) + { + if (prev_all_vbo != stream_info->all_vbo) + device_invalidate_state(device, STATE_INDEXBUFFER); + if (stream_info->all_vbo) + wined3d_buffer_preload(state->index_buffer); + else + buffer_get_sysmem(state->index_buffer, gl_info); + } } static void device_preload_texture(const struct wined3d_state *state, unsigned int idx) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index 18b8f3f..2e30175 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -676,7 +676,7 @@ void drawPrimitive(struct wined3d_device *device, UINT index_count, UINT StartId if (!state->user_stream) { struct wined3d_buffer *index_buffer = state->index_buffer; - if (!index_buffer->buffer_object) + if (!index_buffer->buffer_object || !stream_info->all_vbo) idxData = index_buffer->resource.allocatedMemory; else idxData = NULL; diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 5e6c537..fc6fedc 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -4817,9 +4817,10 @@ static void scissorrect(struct wined3d_context *context, const struct wined3d_st static void indexbuffer(struct wined3d_context *context, const struct wined3d_state *state, DWORD state_id) { + const struct wined3d_stream_info *stream_info = &context->swapchain->device->strided_streams; const struct wined3d_gl_info *gl_info = context->gl_info; - if (state->user_stream || !state->index_buffer) + if (state->user_stream || !state->index_buffer || !stream_info->all_vbo) { GL_EXTCALL(glBindBufferARB(GL_ELEMENT_ARRAY_BUFFER_ARB, 0)); }

1 0

Vincent Povirk : mscoree: Change _CorDllMain fixme to a trace.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: b15a77463ad959df108f31a9e76486365675077f URL: http://source.winehq.org/git/wine.git/?a=commit;h=b15a77463ad959df108f31a9e… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed May 2 13:16:41 2012 -0500 mscoree: Change _CorDllMain fixme to a trace. --- dlls/mscoree/corruntimehost.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mscoree/corruntimehost.c b/dlls/mscoree/corruntimehost.c index 35815f0..ec68ea1 100644 --- a/dlls/mscoree/corruntimehost.c +++ b/dlls/mscoree/corruntimehost.c @@ -900,7 +900,7 @@ __int32 WINAPI _CorExeMain(void) BOOL WINAPI _CorDllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { - FIXME("(%p, %d, %p): stub\n", hinstDLL, fdwReason, lpvReserved); + TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); switch (fdwReason) {

1 0

Vincent Povirk : mscoree: Use the main HMODULE in _CorExeMain instead of loading a new exe.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: a824e8f659d5e21c82a9f1009b521715519ed88d URL: http://source.winehq.org/git/wine.git/?a=commit;h=a824e8f659d5e21c82a9f1009… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed May 2 13:04:36 2012 -0500 mscoree: Use the main HMODULE in _CorExeMain instead of loading a new exe. --- dlls/mscoree/corruntimehost.c | 22 ++++++++++++++++++---- dlls/mscoree/metahost.c | 2 ++ dlls/mscoree/mscoree_private.h | 2 ++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/dlls/mscoree/corruntimehost.c b/dlls/mscoree/corruntimehost.c index 31c02ea..35815f0 100644 --- a/dlls/mscoree/corruntimehost.c +++ b/dlls/mscoree/corruntimehost.c @@ -829,7 +829,9 @@ __int32 WINAPI _CorExeMain(void) int argc; char **argv; MonoDomain *domain; - MonoAssembly *assembly; + MonoImage *image; + MonoImageOpenStatus status; + MonoAssembly *assembly=NULL; WCHAR filename[MAX_PATH]; char *filenameA; ICLRRuntimeInfo *info; @@ -863,9 +865,21 @@ __int32 WINAPI _CorExeMain(void) if (SUCCEEDED(hr)) { - assembly = host->mono->mono_domain_assembly_open(domain, filenameA); + image = host->mono->mono_image_open_from_module_handle(GetModuleHandleW(NULL), + filenameA, 1, &status); - exit_code = host->mono->mono_jit_exec(domain, assembly, argc, argv); + if (image) + assembly = host->mono->mono_assembly_load_from(image, filenameA, &status); + + if (assembly) + { + exit_code = host->mono->mono_jit_exec(domain, assembly, argc, argv); + } + else + { + ERR("couldn't load %s, status=%d\n", debugstr_w(filename), status); + exit_code = -1; + } RuntimeHost_DeleteDomain(host, domain); } diff --git a/dlls/mscoree/metahost.c b/dlls/mscoree/metahost.c index 1296e37..2c3322a 100644 --- a/dlls/mscoree/metahost.c +++ b/dlls/mscoree/metahost.c @@ -165,12 +165,14 @@ static HRESULT load_mono(CLRRuntimeInfo *This, loaded_mono **result) } while (0); LOAD_MONO_FUNCTION(mono_assembly_get_image); + LOAD_MONO_FUNCTION(mono_assembly_load_from); LOAD_MONO_FUNCTION(mono_assembly_open); LOAD_MONO_FUNCTION(mono_config_parse); LOAD_MONO_FUNCTION(mono_class_from_mono_type); LOAD_MONO_FUNCTION(mono_class_from_name); LOAD_MONO_FUNCTION(mono_class_get_method_from_name); LOAD_MONO_FUNCTION(mono_domain_assembly_open); + LOAD_MONO_FUNCTION(mono_image_open_from_module_handle); LOAD_MONO_FUNCTION(mono_install_assembly_preload_hook); LOAD_MONO_FUNCTION(mono_jit_exec); LOAD_MONO_FUNCTION(mono_jit_init); diff --git a/dlls/mscoree/mscoree_private.h b/dlls/mscoree/mscoree_private.h index 12a1e56..357914f 100644 --- a/dlls/mscoree/mscoree_private.h +++ b/dlls/mscoree/mscoree_private.h @@ -147,6 +147,7 @@ struct loaded_mono BOOL is_shutdown; MonoImage* (CDECL *mono_assembly_get_image)(MonoAssembly *assembly); + MonoAssembly* (CDECL *mono_assembly_load_from)(MonoImage *image, const char *fname, MonoImageOpenStatus *status); MonoAssembly* (CDECL *mono_assembly_open)(const char *filename, MonoImageOpenStatus *status); MonoClass* (CDECL *mono_class_from_mono_type)(MonoType *type); MonoClass* (CDECL *mono_class_from_name)(MonoImage *image, const char* name_space, const char *name); @@ -154,6 +155,7 @@ struct loaded_mono void (CDECL *mono_config_parse)(const char *filename); MonoAssembly* (CDECL *mono_domain_assembly_open) (MonoDomain *domain, const char *name); void (CDECL *mono_free)(void *); + MonoImage* (CDECL *mono_image_open_from_module_handle)(HMODULE module_handle, char* fname, UINT has_entry_point, MonoImageOpenStatus* status); void (CDECL *mono_install_assembly_preload_hook)(MonoAssemblyPreLoadFunc func, void *user_data); int (CDECL *mono_jit_exec)(MonoDomain *domain, MonoAssembly *assembly, int argc, char *argv[]); MonoDomain* (CDECL *mono_jit_init)(const char *file);

1 0

Henri Verbeet : d3d9: Properly retrieve an interface pointer in d3d9_texture_3d_LockBox().
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 46a6f4c1a905191c9150b38210963b1a84bb050f URL: http://source.winehq.org/git/wine.git/?a=commit;h=46a6f4c1a905191c9150b3821… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed May 2 21:47:54 2012 +0200 d3d9: Properly retrieve an interface pointer in d3d9_texture_3d_LockBox(). --- dlls/d3d9/texture.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/d3d9/texture.c b/dlls/d3d9/texture.c index 8f83ef7..6544edc 100644 --- a/dlls/d3d9/texture.c +++ b/dlls/d3d9/texture.c @@ -1184,6 +1184,7 @@ static HRESULT WINAPI d3d9_texture_3d_LockBox(IDirect3DVolumeTexture9 *iface, { struct d3d9_texture *texture = impl_from_IDirect3DVolumeTexture9(iface); struct wined3d_resource *sub_resource; + IDirect3DVolume9Impl *volume_impl; HRESULT hr; TRACE("iface %p, level %u, locked_box %p, box %p, flags %#x.\n", @@ -1193,8 +1194,10 @@ static HRESULT WINAPI d3d9_texture_3d_LockBox(IDirect3DVolumeTexture9 *iface, if (!(sub_resource = wined3d_texture_get_sub_resource(texture->wined3d_texture, level))) hr = D3DERR_INVALIDCALL; else - hr = IDirect3DVolume9_LockBox((IDirect3DVolume9 *)wined3d_resource_get_parent(sub_resource), - locked_box, box, flags); + { + volume_impl = wined3d_resource_get_parent(sub_resource); + hr = IDirect3DVolume9_LockBox(&volume_impl->IDirect3DVolume9_iface, locked_box, box, flags); + } wined3d_mutex_unlock(); return hr;

1 0

Alexandre Julliard : wininet/tests: Add more optional COOKIE_SENT messages.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: 9ec1f7ba1b0577fc045e4f77bdc48113126175d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9ec1f7ba1b0577fc045e4f77b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu May 3 10:11:12 2012 +0200 wininet/tests: Add more optional COOKIE_SENT messages. --- dlls/wininet/tests/http.c | 25 ++++++++++--------------- 1 files changed, 10 insertions(+), 15 deletions(-) diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c index fddef12..4974c88 100644 --- a/dlls/wininet/tests/http.c +++ b/dlls/wininet/tests/http.c @@ -107,8 +107,7 @@ static DWORD req_error; #define TESTF_REDIRECT 0x01 #define TESTF_COMPRESSED 0x02 -#define TESTF_ALLOW_COOKIE 0x04 -#define TESTF_CHUNKED 0x08 +#define TESTF_CHUNKED 0x04 typedef struct { const char *url; @@ -128,7 +127,7 @@ static const test_data_t test_data[] = { "test.winehq.org", "/tests/data.php", "", - TESTF_CHUNKED|TESTF_ALLOW_COOKIE + TESTF_CHUNKED }, { "http://test.winehq.org/tests/redirect", @@ -144,7 +143,7 @@ static const test_data_t test_data[] = { "www.codeweavers.com", "", "Accept-Encoding: gzip, deflate", - TESTF_COMPRESSED|TESTF_ALLOW_COOKIE + TESTF_COMPRESSED }, { "http://test.winehq.org/tests/post.php", @@ -152,7 +151,7 @@ static const test_data_t test_data[] = { "test.winehq.org", "/tests/post.php", "Content-Type: application/x-www-form-urlencoded", - TESTF_ALLOW_COOKIE, + 0, "mode=Test", "mode => Test\n" } @@ -399,10 +398,8 @@ static void InternetReadFile_test(int flags, const test_data_t *test) CHECK_NOTIFIED(INTERNET_STATUS_HANDLE_CREATED); CHECK_NOT_NOTIFIED(INTERNET_STATUS_RESOLVING_NAME); CHECK_NOT_NOTIFIED(INTERNET_STATUS_NAME_RESOLVED); - if(test->flags & TESTF_ALLOW_COOKIE) { - SET_OPTIONAL(INTERNET_STATUS_COOKIE_SENT); - SET_OPTIONAL(INTERNET_STATUS_COOKIE_RECEIVED); - } + SET_OPTIONAL(INTERNET_STATUS_COOKIE_SENT); + SET_OPTIONAL(INTERNET_STATUS_COOKIE_RECEIVED); if (first_connection_to_test_url) { SET_EXPECT(INTERNET_STATUS_RESOLVING_NAME); @@ -456,10 +453,8 @@ static void InternetReadFile_test(int flags, const test_data_t *test) } HeapFree(GetProcessHeap(), 0, post_data); - if(test->flags & TESTF_ALLOW_COOKIE) { - CLEAR_NOTIFIED(INTERNET_STATUS_COOKIE_SENT); - CLEAR_NOTIFIED(INTERNET_STATUS_COOKIE_RECEIVED); - } + CLEAR_NOTIFIED(INTERNET_STATUS_COOKIE_SENT); + CLEAR_NOTIFIED(INTERNET_STATUS_COOKIE_RECEIVED); if (first_connection_to_test_url) { if (! proxy_active()) @@ -766,7 +761,7 @@ static void InternetReadFileExA_test(int flags) SET_EXPECT(INTERNET_STATUS_RESOLVING_NAME); SET_EXPECT(INTERNET_STATUS_NAME_RESOLVED); } - SET_OPTIONAL(INTERNET_STATUS_COOKIE_SENT); + SET_OPTIONAL2(INTERNET_STATUS_COOKIE_SENT, 2); SET_EXPECT(INTERNET_STATUS_CONNECTING_TO_SERVER); SET_EXPECT(INTERNET_STATUS_CONNECTED_TO_SERVER); SET_EXPECT2(INTERNET_STATUS_SENDING_REQUEST, 2); @@ -851,7 +846,7 @@ static void InternetReadFileExA_test(int flags) SET_EXPECT(INTERNET_STATUS_RESPONSE_RECEIVED); rc = InternetReadFileEx(hor, &inetbuffers, 0, 0xdeadcafe); ok(rc, "InternetReadFileEx failed with error %u\n", GetLastError()); - trace("read %i bytes\n", inetbuffers.dwBufferLength); + trace("read %i bytes\n", inetbuffers.dwBufferLength); todo_wine { CHECK_NOT_NOTIFIED(INTERNET_STATUS_RECEIVING_RESPONSE);

1 0

André Hentschel : winspool.drv: Support printer info level 8.
by Alexandre Julliard May 3, 2012

May 3, 2012

Module: wine Branch: master Commit: c9fdc565e5753bf363943b2b1c88486334b00576 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c9fdc565e5753bf363943b2b1… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed May 2 19:40:09 2012 +0200 winspool.drv: Support printer info level 8. --- dlls/winspool.drv/info.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 2f09855..297cf7a 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -3992,6 +3992,10 @@ BOOL WINAPI GetPrinterW(HANDLE hPrinter, DWORD Level, LPBYTE pPrinter, } + case 8: + /* 8 is the global default printer info and 9 already gets it instead of the per-user one */ + /* still, PRINTER_INFO_8W is the same as PRINTER_INFO_9W */ + /* fall through */ case 9: { PRINTER_INFO_9W *pi9 = (PRINTER_INFO_9W *)pPrinter;

1 0