July 2012 - Wine-Commits - list.winehq.org

Henri Verbeet : wined3d: Use the proper texture target in ffp_blit_p8_upload_palette().
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: f0fb19992580cc66a3fed9f9e0f5ca1c78d73dc0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f0fb19992580cc66a3fed9f9e… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Jul 17 11:40:37 2012 +0200 wined3d: Use the proper texture target in ffp_blit_p8_upload_palette(). --- dlls/wined3d/surface.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index c0b27ba..13c88f9 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -6333,12 +6333,18 @@ static void ffp_blit_p8_upload_palette(const struct wined3d_surface *surface, co { BYTE table[256][4]; BOOL colorkey_active = (surface->CKeyFlags & WINEDDSD_CKSRCBLT) ? TRUE : FALSE; + GLenum target; + + if (surface->container.type == WINED3D_CONTAINER_TEXTURE) + target = surface->container.u.texture->target; + else + target = surface->texture_target; d3dfmt_p8_init_palette(surface, table, colorkey_active); TRACE("Using GL_EXT_PALETTED_TEXTURE for 8-bit paletted texture support\n"); ENTER_GL(); - GL_EXTCALL(glColorTableEXT(surface->texture_target, GL_RGBA, 256, GL_RGBA, GL_UNSIGNED_BYTE, table)); + GL_EXTCALL(glColorTableEXT(target, GL_RGBA, 256, GL_RGBA, GL_UNSIGNED_BYTE, table)); LEAVE_GL(); }

1 0

Henri Verbeet : wined3d: Introduce a separate function for initializing various limits.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: e834c920ec09390a491848a3075eca8f35e3a253 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e834c920ec09390a491848a30… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Jul 17 11:40:38 2012 +0200 wined3d: Introduce a separate function for initializing various limits. --- dlls/wined3d/directx.c | 388 +++++++++++++++++++++++------------------------ 1 files changed, 190 insertions(+), 198 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e834c920ec09390a49184…

1 0

Daniel Jelinski : comctl32/treeview: Clean up mouse tracking code.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 7e56fd38d831ab9b565677f1a204a7f8b554633a URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e56fd38d831ab9b565677f1a… Author: Daniel Jelinski <djelinski1(a)gmail.com> Date: Fri Jul 13 19:53:40 2012 +0200 comctl32/treeview: Clean up mouse tracking code. --- dlls/comctl32/treeview.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c index 8c93f8c..9e28ee2 100644 --- a/dlls/comctl32/treeview.c +++ b/dlls/comctl32/treeview.c @@ -4043,8 +4043,6 @@ TREEVIEW_TrackMouse(const TREEVIEW_INFO *infoPtr, POINT pt) else if (msg.message >= WM_LBUTTONDOWN && msg.message <= WM_RBUTTONDBLCLK) { - if (msg.message == WM_RBUTTONUP) - TREEVIEW_RButtonUp(infoPtr, &pt); break; } @@ -4259,6 +4257,7 @@ TREEVIEW_RButtonDown(TREEVIEW_INFO *infoPtr, LPARAM lParam) } else { + TREEVIEW_RButtonUp(infoPtr, &ht.pt); SetFocus(infoPtr->hwnd); TREEVIEW_SendSimpleNotify(infoPtr, NM_RCLICK); }

1 0

Dmitry Timoshkov : gdiplus: Add support for converting RGB formats to 1bpp indexed.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: d104741a3c7a0893762e2dfe2e67cbbe9c4a3647 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d104741a3c7a0893762e2dfe2… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Jul 17 15:02:31 2012 +0900 gdiplus: Add support for converting RGB formats to 1bpp indexed. --- dlls/gdiplus/image.c | 22 ++++++++++++++++++++++ dlls/gdiplus/tests/image.c | 4 ---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 2e3c164..bfa0156 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -637,6 +637,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppGrayScale: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_16bppGrayScale, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_16bppGrayScale, setpixel_8bppIndexed); case PixelFormat16bppRGB555: @@ -664,6 +666,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppRGB555: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_16bppRGB555, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_16bppRGB555, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -691,6 +695,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppRGB565: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_16bppRGB565, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_16bppRGB565, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -718,6 +724,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppARGB1555: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_16bppARGB1555, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_16bppARGB1555, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -745,6 +753,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat24bppRGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_24bppRGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_24bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -772,6 +782,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppRGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_32bppRGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_32bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -799,6 +811,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppARGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_32bppARGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_32bppARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -825,6 +839,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppPARGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_32bppPARGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_32bppPARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -852,6 +868,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat48bppRGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_48bppRGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_48bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -879,6 +897,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat64bppARGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_64bppARGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_64bppARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: @@ -906,6 +926,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat64bppPARGB: switch (dst_format) { + case PixelFormat1bppIndexed: + convert_rgb_to_indexed(getpixel_64bppPARGB, setpixel_1bppIndexed); case PixelFormat8bppIndexed: convert_rgb_to_indexed(getpixel_64bppPARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c index da17b5d..7f89aec 100644 --- a/dlls/gdiplus/tests/image.c +++ b/dlls/gdiplus/tests/image.c @@ -3404,7 +3404,6 @@ static void test_bitmapbits(void) 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77, 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77 }; -#if 0 /* FIXME: these tests crash gdiplus in Wine */ static const BYTE pixels_1_77[64] = { 0xaa,0x77,0x77,0x77,0x77,0x77,0x77,0x77, @@ -3417,7 +3416,6 @@ static void test_bitmapbits(void) 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77 }; static const BYTE pixels_1[8] = {0xaa,0,0,0,0xaa,0,0,0}; -#endif static const struct test_data { PixelFormat format; @@ -3446,7 +3444,6 @@ static void test_bitmapbits(void) { PixelFormat8bppIndexed, 8, ImageLockModeRead|ImageLockModeUserInputBuf, 32, 64, pixels_8_77, pixels_24 }, { PixelFormat8bppIndexed, 8, ImageLockModeWrite|ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_00 }, { PixelFormat8bppIndexed, 8, ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_24 }, -#if 0 /* FIXME: these tests crash gdiplus in Wine */ /* 15 */ { PixelFormat1bppIndexed, 1, 0, 4, 8, pixels_1, pixels_24 }, { PixelFormat1bppIndexed, 1, ImageLockModeRead, 4, 8, pixels_1, pixels_24 }, @@ -3455,7 +3452,6 @@ static void test_bitmapbits(void) { PixelFormat1bppIndexed, 1, ImageLockModeRead|ImageLockModeUserInputBuf, 32, 64, pixels_1_77, pixels_24 }, { PixelFormat1bppIndexed, 1, ImageLockModeWrite|ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_00 }, { PixelFormat1bppIndexed, 1, ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_24 }, -#endif }; BYTE buf[64]; GpStatus status;

1 0

Dmitry Timoshkov : gdiplus: Add support for converting RGB formats to 8bpp indexed.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 2ed1aaa930654e3e4bbbbf13992cf6abbded6780 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ed1aaa930654e3e4bbbbf139… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Jul 17 15:01:51 2012 +0900 gdiplus: Add support for converting RGB formats to 8bpp indexed. --- dlls/gdiplus/image.c | 32 ++++++++++++++++++++++++++++++++ dlls/gdiplus/tests/image.c | 4 ++-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index d14fca0..2e3c164 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -541,6 +541,16 @@ GpStatus convert_pixels(INT width, INT height, return Ok; \ } while (0); +#define convert_rgb_to_indexed(getpixel_function, setpixel_function) do { \ + for (x=0; x<width; x++) \ + for (y=0; y<height; y++) { \ + BYTE r, g, b, a; \ + getpixel_function(&r, &g, &b, &a, src_bits+src_stride*y, x); \ + setpixel_function(r, g, b, a, dst_bits+dst_stride*y, x, palette); \ + } \ + return Ok; \ +} while (0); + switch (src_format) { case PixelFormat1bppIndexed: @@ -627,6 +637,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppGrayScale: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_16bppGrayScale, setpixel_8bppIndexed); case PixelFormat16bppRGB555: convert_rgb_to_rgb(getpixel_16bppGrayScale, setpixel_16bppRGB555); case PixelFormat16bppRGB565: @@ -652,6 +664,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppRGB555: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_16bppRGB555, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_16bppRGB555, setpixel_16bppGrayScale); case PixelFormat16bppRGB565: @@ -677,6 +691,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppRGB565: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_16bppRGB565, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_16bppRGB565, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -702,6 +718,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat16bppARGB1555: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_16bppARGB1555, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_16bppARGB1555, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -727,6 +745,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat24bppRGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_24bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_24bppRGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -752,6 +772,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppRGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_32bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_32bppRGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -777,6 +799,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppARGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_32bppARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_32bppARGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -801,6 +825,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat32bppPARGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_32bppPARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_32bppPARGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -826,6 +852,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat48bppRGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_48bppRGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_48bppRGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -851,6 +879,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat64bppARGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_64bppARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_64bppARGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: @@ -876,6 +906,8 @@ GpStatus convert_pixels(INT width, INT height, case PixelFormat64bppPARGB: switch (dst_format) { + case PixelFormat8bppIndexed: + convert_rgb_to_indexed(getpixel_64bppPARGB, setpixel_8bppIndexed); case PixelFormat16bppGrayScale: convert_rgb_to_rgb(getpixel_64bppPARGB, setpixel_16bppGrayScale); case PixelFormat16bppRGB555: diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c index 482dfd9..da17b5d 100644 --- a/dlls/gdiplus/tests/image.c +++ b/dlls/gdiplus/tests/image.c @@ -3388,7 +3388,6 @@ static void test_bitmapbits(void) 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77, 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77 }; -#if 0 /* FIXME: these tests crash gdiplus in Wine */ static const BYTE pixels_8[16] = { 0x01,0,0x01,0,0x01,0,0x01,0, @@ -3405,6 +3404,7 @@ static void test_bitmapbits(void) 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77, 0x77,0x77,0x77,0x77,0x77,0x77,0x77,0x77 }; +#if 0 /* FIXME: these tests crash gdiplus in Wine */ static const BYTE pixels_1_77[64] = { 0xaa,0x77,0x77,0x77,0x77,0x77,0x77,0x77, @@ -3438,7 +3438,6 @@ static void test_bitmapbits(void) { PixelFormat24bppRGB, 24, ImageLockModeRead|ImageLockModeUserInputBuf, 32, 64, pixels_24_77, pixels_24 }, { PixelFormat24bppRGB, 24, ImageLockModeWrite|ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_00 }, { PixelFormat24bppRGB, 24, ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_24 }, -#if 0 /* FIXME: these tests crash gdiplus in Wine */ /* 8 */ { PixelFormat8bppIndexed, 8, 0, 8, 16, pixels_8, pixels_24 }, { PixelFormat8bppIndexed, 8, ImageLockModeRead, 8, 16, pixels_8, pixels_24 }, @@ -3447,6 +3446,7 @@ static void test_bitmapbits(void) { PixelFormat8bppIndexed, 8, ImageLockModeRead|ImageLockModeUserInputBuf, 32, 64, pixels_8_77, pixels_24 }, { PixelFormat8bppIndexed, 8, ImageLockModeWrite|ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_00 }, { PixelFormat8bppIndexed, 8, ImageLockModeUserInputBuf, 32, 64, pixels_77, pixels_24 }, +#if 0 /* FIXME: these tests crash gdiplus in Wine */ /* 15 */ { PixelFormat1bppIndexed, 1, 0, 4, 8, pixels_1, pixels_24 }, { PixelFormat1bppIndexed, 1, ImageLockModeRead, 4, 8, pixels_1, pixels_24 },

1 0

Dmitry Timoshkov : gdiplus: Pass complete palette info to convert_pixels().
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 87f8e560c2fac142075fd17f1dd452eda68243cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=87f8e560c2fac142075fd17f1… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Jul 17 15:00:21 2012 +0900 gdiplus: Pass complete palette info to convert_pixels(). --- dlls/gdiplus/gdiplus_private.h | 2 +- dlls/gdiplus/graphics.c | 2 +- dlls/gdiplus/image.c | 10 ++++++---- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h index b7c808d..03942c0 100644 --- a/dlls/gdiplus/gdiplus_private.h +++ b/dlls/gdiplus/gdiplus_private.h @@ -120,7 +120,7 @@ extern void convert_32bppARGB_to_32bppPARGB(UINT width, UINT height, extern GpStatus convert_pixels(INT width, INT height, INT dst_stride, BYTE *dst_bits, PixelFormat dst_format, - INT src_stride, const BYTE *src_bits, PixelFormat src_format, ARGB *src_palette) DECLSPEC_HIDDEN; + INT src_stride, const BYTE *src_bits, PixelFormat src_format, ColorPalette *palette) DECLSPEC_HIDDEN; struct GpPen{ UINT style; diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 577824e..59dd77b 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -3274,7 +3274,7 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image convert_pixels(bitmap->width, bitmap->height, bitmap->width*4, temp_bits, dst_format, bitmap->stride, bitmap->bits, bitmap->format, - bitmap->image.palette ? bitmap->image.palette->Entries : NULL); + bitmap->image.palette); } else { diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 464de94..f9781ef 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -501,7 +501,8 @@ GpStatus WINGDIPAPI GdipBitmapSetPixel(GpBitmap* bitmap, INT x, INT y, GpStatus convert_pixels(INT width, INT height, INT dst_stride, BYTE *dst_bits, PixelFormat dst_format, - INT src_stride, const BYTE *src_bits, PixelFormat src_format, ARGB *src_palette) + INT src_stride, const BYTE *src_bits, PixelFormat src_format, + ColorPalette *palette) { INT x, y; @@ -518,9 +519,10 @@ GpStatus convert_pixels(INT width, INT height, for (x=0; x<width; x++) \ for (y=0; y<height; y++) { \ BYTE index; \ - BYTE *color; \ + ARGB argb; \ + BYTE *color = (BYTE *)&argb; \ getpixel_function(&index, src_bits+src_stride*y, x); \ - color = (BYTE*)(&src_palette[index]); \ + argb = (palette && index < palette->Count) ? palette->Entries[index] : 0; \ setpixel_function(color[2], color[1], color[0], color[3], dst_bits+dst_stride*y, x); \ } \ return Ok; \ @@ -1012,7 +1014,7 @@ GpStatus WINGDIPAPI GdipBitmapLockBits(GpBitmap* bitmap, GDIPCONST GpRect* rect, lockeddata->Stride, lockeddata->Scan0, format, bitmap->stride, bitmap->bits + bitmap->stride * act_rect.Y + PIXELFORMATBPP(bitmap->format) * act_rect.X / 8, - bitmap->format, bitmap->image.palette ? bitmap->image.palette->Entries : NULL); + bitmap->format, bitmap->image.palette); if (stat != Ok) {

1 0

Nicolas Le Cam : windowscodecs: Avoid using uninitialized value (LLVM/Clang ).
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 986b98160bfb9ef555c639bbac46ed00545923bc URL: http://source.winehq.org/git/wine.git/?a=commit;h=986b98160bfb9ef555c639bba… Author: Nicolas Le Cam <niko.lecam(a)gmail.com> Date: Sat Jul 14 16:14:41 2012 +0200 windowscodecs: Avoid using uninitialized value (LLVM/Clang). --- dlls/windowscodecs/bmpencode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/windowscodecs/bmpencode.c b/dlls/windowscodecs/bmpencode.c index d9931d6..dfef7f4 100644 --- a/dlls/windowscodecs/bmpencode.c +++ b/dlls/windowscodecs/bmpencode.c @@ -314,7 +314,7 @@ static HRESULT WINAPI BmpFrameEncode_WriteSource(IWICBitmapFrameEncode *iface, This->stride*(This->height-This->lineswritten), This->bits + This->stride*This->lineswritten); - This->lineswritten += rc.Height; + This->lineswritten += prc->Height; return S_OK; }

1 0

Lucas Zawacki : joy.cpl: Added force feedback direction control.
by Alexandre Julliard July 17, 2012

July 17, 2012

1 0

Nikolay Sivov : msxml3: Use single helper to test for handler presence.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 007ac83fc93d8b9efe4b75d49f86d41263ed8af7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=007ac83fc93d8b9efe4b75d49… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 17 09:58:36 2012 +0400 msxml3: Use single helper to test for handler presence. --- dlls/msxml3/saxreader.c | 52 ++++++++++++++++++---------------------------- 1 files changed, 20 insertions(+), 32 deletions(-) diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c index bdfdcab..87974bc 100644 --- a/dlls/msxml3/saxreader.c +++ b/dlls/msxml3/saxreader.c @@ -324,6 +324,12 @@ static inline saxlocator *impl_from_ISAXAttributes( ISAXAttributes *iface ) return CONTAINING_RECORD(iface, saxlocator, ISAXAttributes_iface); } +static inline int saxreader_has_handler(const saxlocator *locator, enum saxhandler_type type) +{ + return (locator->vbInterface && locator->saxreader->saxhandlers[type].vbhandler) || + (!locator->vbInterface && locator->saxreader->saxhandlers[type].handler); +} + /* property names */ static const WCHAR PropertyCharsetW[] = { 'c','h','a','r','s','e','t',0 @@ -394,24 +400,6 @@ static BOOL is_namespaces_enabled(const saxreader *reader) return (reader->version < MSXML4) || (reader->features & Namespaces); } -static inline int has_content_handler(const saxlocator *locator) -{ - return (locator->vbInterface && locator->saxreader->saxhandlers[SAXContentHandler].vbhandler) || - (!locator->vbInterface && locator->saxreader->saxhandlers[SAXContentHandler].handler); -} - -static inline int has_lexical_handler(const saxlocator *locator) -{ - return (locator->vbInterface && locator->saxreader->saxhandlers[SAXLexicalHandler].vbhandler) || - (!locator->vbInterface && locator->saxreader->saxhandlers[SAXLexicalHandler].handler); -} - -static inline int has_error_handler(const saxlocator *locator) -{ - return (locator->vbInterface && locator->saxreader->saxhandlers[SAXErrorHandler].vbhandler) || - (!locator->vbInterface && locator->saxreader->saxhandlers[SAXErrorHandler].handler); -} - static BSTR build_qname(BSTR prefix, BSTR local) { if (prefix && *prefix) @@ -639,7 +627,7 @@ static void format_error_message_from_id(saxlocator *This, HRESULT hr) xmlStopParser(This->pParserCtxt); This->ret = hr; - if(has_error_handler(This)) + if (saxreader_has_handler(This, SAXErrorHandler)) { WCHAR msg[1024]; if(!FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM, @@ -1323,7 +1311,7 @@ static void libxmlStartDocument(void *ctx) This->column++; } - if(has_content_handler(This)) + if (saxreader_has_handler(This, SAXContentHandler)) { if(This->vbInterface) hr = IVBSAXContentHandler_startDocument(handler->vbhandler); @@ -1353,7 +1341,7 @@ static void libxmlEndDocument(void *ctx) if(This->ret != S_OK) return; - if(has_content_handler(This)) + if (saxreader_has_handler(This, SAXContentHandler)) { if(This->vbInterface) hr = IVBSAXContentHandler_endDocument(handler->vbhandler); @@ -1395,7 +1383,7 @@ static void libxmlStartElementNS( { int i; - for (i = 0; i < nb_namespaces && has_content_handler(This); i++) + for (i = 0; i < nb_namespaces && saxreader_has_handler(This, SAXContentHandler); i++) { if (This->vbInterface) hr = IVBSAXContentHandler_startPrefixMapping( @@ -1420,7 +1408,7 @@ static void libxmlStartElementNS( uri = find_element_uri(This, URI); hr = SAXAttributes_populate(This, nb_namespaces, namespaces, nb_attributes, attributes); - if (hr == S_OK && has_content_handler(This)) + if (hr == S_OK && saxreader_has_handler(This, SAXContentHandler)) { BSTR local; @@ -1488,7 +1476,7 @@ static void libxmlEndElementNS( uri = find_element_uri(This, URI); element = pop_element_ns(This); - if (!has_content_handler(This)) + if (!saxreader_has_handler(This, SAXContentHandler)) { This->nb_attributes = 0; free_element_entry(element); @@ -1523,7 +1511,7 @@ static void libxmlEndElementNS( if (is_namespaces_enabled(This->saxreader)) { int i = -1; - while (iterate_endprefix_index(This, element, &i) && has_content_handler(This)) + while (iterate_endprefix_index(This, element, &i) && saxreader_has_handler(This, SAXContentHandler)) { if (This->vbInterface) hr = IVBSAXContentHandler_endPrefixMapping( @@ -1554,7 +1542,7 @@ static void libxmlCharacters( xmlChar *cur, *end; BOOL lastEvent = FALSE; - if(!(has_content_handler(This))) return; + if (!saxreader_has_handler(This, SAXContentHandler)) return; update_position(This, FALSE); cur = (xmlChar*)This->pParserCtxt->input->cur; @@ -1644,7 +1632,7 @@ static void libxmlSetDocumentLocator( struct saxcontenthandler_iface *handler = saxreader_get_contenthandler(This->saxreader); HRESULT hr = S_OK; - if(has_content_handler(This)) + if (saxreader_has_handler(This, SAXContentHandler)) { if(This->vbInterface) hr = IVBSAXContentHandler_putref_documentLocator(handler->vbhandler, @@ -1678,7 +1666,7 @@ static void libxmlComment(void *ctx, const xmlChar *value) for(; p>=This->pParserCtxt->input->base && *p!='\n' && *p!='\r'; p--) This->column++; - if (!has_lexical_handler(This)) return; + if (!saxreader_has_handler(This, SAXLexicalHandler)) return; bValue = pooled_bstr_from_xmlChar(&This->saxreader->pool, value); @@ -1717,7 +1705,7 @@ static void libxmlFatalError(void *ctx, const char *msg, ...) TRACE("fatal error for %p: %s\n", This, debugstr_w(error)); } - if(!has_error_handler(This)) + if (!saxreader_has_handler(This, SAXErrorHandler)) { xmlStopParser(This->pParserCtxt); This->ret = E_FAIL; @@ -1767,7 +1755,7 @@ static void libxmlCDataBlock(void *ctx, const xmlChar *value, int len) for(; beg>=This->pParserCtxt->input->base && *beg!='\n' && *beg!='\r'; beg--) This->column++; - if (has_lexical_handler(This)) + if (saxreader_has_handler(This, SAXLexicalHandler)) { if (This->vbInterface) hr = IVBSAXLexicalHandler_startCDATA(lexical->vbhandler); @@ -1801,7 +1789,7 @@ static void libxmlCDataBlock(void *ctx, const xmlChar *value, int len) if(change) *end = '\n'; - if (has_content_handler(This)) + if (saxreader_has_handler(This, SAXContentHandler)) { Chars = pooled_bstr_from_xmlCharN(&This->saxreader->pool, cur, end-cur+1); if (This->vbInterface) @@ -1820,7 +1808,7 @@ static void libxmlCDataBlock(void *ctx, const xmlChar *value, int len) cur = end; } - if (has_lexical_handler(This)) + if (saxreader_has_handler(This, SAXLexicalHandler)) { if (This->vbInterface) hr = IVBSAXLexicalHandler_endCDATA(lexical->vbhandler);

1 0

Nikolay Sivov : ole32: Use interface macros to call methods.
by Alexandre Julliard July 17, 2012

July 17, 2012

Module: wine Branch: master Commit: 88e6c8175b36ec4b2e06c003bf8e7da7e053b57c URL: http://source.winehq.org/git/wine.git/?a=commit;h=88e6c8175b36ec4b2e06c003b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 17 10:15:25 2012 +0400 ole32: Use interface macros to call methods. --- dlls/ole32/stg_stream.c | 2 +- dlls/ole32/storage32.c | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/ole32/stg_stream.c b/dlls/ole32/stg_stream.c index 6a39b94..1471162 100644 --- a/dlls/ole32/stg_stream.c +++ b/dlls/ole32/stg_stream.c @@ -657,7 +657,7 @@ static HRESULT WINAPI StgStreamImpl_Clone( seek_pos.QuadPart = This->currentPosition.QuadPart; - hres=StgStreamImpl_Seek (*ppstm, seek_pos, STREAM_SEEK_SET, NULL); + hres = IStream_Seek(*ppstm, seek_pos, STREAM_SEEK_SET, NULL); assert (SUCCEEDED(hres)); diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c index a1c925f..30d380b 100644 --- a/dlls/ole32/storage32.c +++ b/dlls/ole32/storage32.c @@ -2152,7 +2152,7 @@ static HRESULT deleteStreamContents( size.u.HighPart = 0; size.u.LowPart = 0; - hr = StorageBaseImpl_OpenStream(&parentStorage->IStorage_iface, + hr = IStorage_OpenStream(&parentStorage->IStorage_iface, entryDataToDelete.name, NULL, STGM_WRITE | STGM_SHARE_EXCLUSIVE, 0, &pis); if (hr!=S_OK) @@ -4798,14 +4798,10 @@ static void TransactedSnapshotImpl_Destroy( StorageBaseImpl *iface) { TransactedSnapshotImpl* This = (TransactedSnapshotImpl*) iface; - TransactedSnapshotImpl_Revert(&This->base.IStorage_iface); - + IStorage_Revert(&This->base.IStorage_iface); IStorage_Release(&This->transactedParent->IStorage_iface); - IStorage_Release(&This->scratch->IStorage_iface); - HeapFree(GetProcessHeap(), 0, This->entries); - HeapFree(GetProcessHeap(), 0, This); }

1 0