August 2012 - Wine-Commits - list.winehq.org

Francois Gouget : testbot: bin & web: Don' t hardcode the hostname of the WineTestBot web server.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: b00f81700d74d2e573b237546423822c5ddd92bd URL: http://source.winehq.org/git/tools.git/?a=commit;h=b00f81700d74d2e573b23754… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:51:35 2012 +0200 testbot: bin & web: Don't hardcode the hostname of the WineTestBot web server. --- testbot/bin/WineSendLog.pl | 2 +- testbot/lib/WineTestBot/CGI/PageBase.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl index 51f5312..34d8378 100755 --- a/testbot/bin/WineSendLog.pl +++ b/testbot/bin/WineSendLog.pl @@ -430,7 +430,7 @@ Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at EOF - print SENDMAIL "http://testbot.winehq.org/JobDetails.pl?Key=", + print SENDMAIL "http://$WebHostName/JobDetails.pl?Key=", $Job->GetKey(), "\n\n"; print SENDMAIL "Your paranoid android.\n\n"; diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm index ff0b528..141833f 100644 --- a/testbot/lib/WineTestBot/CGI/PageBase.pm +++ b/testbot/lib/WineTestBot/CGI/PageBase.pm @@ -231,7 +231,7 @@ ${ProjectName} Test Bot <li><a href='http://wiki.winehq.org'>Wiki</a></li> <li><a href='http://appdb.winehq.org/'>AppDB</a></li> <li><a href='http://bugs.winehq.org/'>Bugzilla</a></li> - <li class='s'><a href='http://testbot.winehq.org/'>TestBot</a></li> + <li class='s'><a href='http://${WebHostName}/'>TestBot</a></li> <li><a href='http://forums.winehq.org/'>Forums</a></li> </ul> </div>

1 0

Alexandre Julliard : git-notify: Update the address of the CIA bot.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: 371d8133814468cd5d0fcf2a87fca22404ea6018 URL: http://source.winehq.org/git/tools.git/?a=commit;h=371d8133814468cd5d0fcf2a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Aug 22 21:01:21 2012 +0200 git-notify: Update the address of the CIA bot. --- git-notify | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-notify b/git-notify index d79cfcc..9918117 100755 --- a/git-notify +++ b/git-notify @@ -42,7 +42,7 @@ sub get_repos_name(); my $mailer = "/usr/bin/mail"; # CIA notification address -my $cia_address = "cia\(a)cia.navi.cx"; +my $cia_address = "cia\(a)cia.vc"; # debug mode my $debug = 0;

1 0

Francois Gouget : testbot: lib: The Digest:: SHA package has superseded Digest::SHA1.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: f544bd4ca8406e4ae88b8bfc3bb70668e4982816 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f544bd4ca8406e4ae88b8bfc… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:50:18 2012 +0200 testbot: lib: The Digest::SHA package has superseded Digest::SHA1. --- testbot/lib/WineTestBot/Users.pm | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testbot/lib/WineTestBot/Users.pm b/testbot/lib/WineTestBot/Users.pm index 66a570c..32b0d3f 100644 --- a/testbot/lib/WineTestBot/Users.pm +++ b/testbot/lib/WineTestBot/Users.pm @@ -26,7 +26,7 @@ WineTestBot::Users - User collection package WineTestBot::User; -use Digest::SHA1 qw(sha1_hex); +use Digest::SHA qw(sha1_hex); use URI::Escape; use WineTestBot::Config; use WineTestBot::Roles;

1 0

Francois Gouget : testbot: Add copyright notices.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: 3afdeb390c2de845ddb6746868e7a50d7fdee9d8 URL: http://source.winehq.org/git/tools.git/?a=commit;h=3afdeb390c2de845ddb67468… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:49:57 2012 +0200 testbot: Add copyright notices. --- testbot/bin/BuildSingleTest.pl | 16 ++++++++++++++++ testbot/bin/CheckForWinetestUpdate.pl | 16 ++++++++++++++++ testbot/bin/PatchNotificationHandler.pl | 16 ++++++++++++++++ testbot/bin/Reconfig.pl | 16 ++++++++++++++++ testbot/bin/RetrievePatches.pl | 16 ++++++++++++++++ testbot/bin/RevertVM.pl | 16 ++++++++++++++++ testbot/bin/WineCvsHandler.pl | 16 ++++++++++++++++ testbot/bin/WinePatchesHandler.pl | 16 ++++++++++++++++ testbot/bin/WineRunBuild.pl | 16 ++++++++++++++++ testbot/bin/WineRunReconfig.pl | 16 ++++++++++++++++ testbot/bin/WineRunTask.pl | 16 ++++++++++++++++ testbot/lib/ObjectModel/DBIBackEnd.pm | 16 ++++++++++++++++ testbot/lib/startup.pl | 16 ++++++++++++++++ testbot/src/GenFixEnv/GenFixEnv.c | 20 +++++++++++++++++++- testbot/src/TestLauncher/TestLauncher.c | 20 +++++++++++++++++++- 15 files changed, 246 insertions(+), 2 deletions(-) Diff: http://source.winehq.org/git/tools.git/?a=commitdiff;h=3afdeb390c2de845ddb6…

1 0

Francois Gouget : testbot: lib: Remove an unused variable in Job:: ScheduleOnHost().
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: cb8e3fdbd11aafb7db1f84b5d7362bcc0089a4e9 URL: http://source.winehq.org/git/tools.git/?a=commit;h=cb8e3fdbd11aafb7db1f84b5… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:50:49 2012 +0200 testbot: lib: Remove an unused variable in Job::ScheduleOnHost(). --- testbot/lib/WineTestBot/Jobs.pm | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index ab3c5c6..0a9701e 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -366,7 +366,6 @@ sub ScheduleOnHost my @SortedJobs = sort CompareJobPriority @{$self->GetItems()}; my $DirtyIndex = 0; - my $RevertPriority; foreach my $Job (@SortedJobs) { my $Steps = $Job->Steps; @@ -387,8 +386,7 @@ sub ScheduleOnHost my $VM = $HostVMs->GetItem($Task->VM->GetKey()); if ($VM->Status eq "idle" && (! defined($MaxRunningVMs) || $RunningVMs < $MaxRunningVMs) && - $RevertingVMs == 0 && - (! defined($RevertPriority) || $Job->Priority <= $RevertPriority)) + $RevertingVMs == 0) { $VM->Status("running"); my ($ErrProperty, $ErrMessage) = $HostVMs->Save();

1 0

Francois Gouget : testbot: ddl: Add a missing comma.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: 3ea1e2c2289ddb8801b9d75f05d1319b2a107a73 URL: http://source.winehq.org/git/tools.git/?a=commit;h=3ea1e2c2289ddb8801b9d75f… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:46:11 2012 +0200 testbot: ddl: Add a missing comma. --- testbot/ddl/winetestbot.sql | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testbot/ddl/winetestbot.sql b/testbot/ddl/winetestbot.sql index a2b358b..0906c0e 100644 --- a/testbot/ddl/winetestbot.sql +++ b/testbot/ddl/winetestbot.sql @@ -63,7 +63,7 @@ CREATE TABLE Patches Id INT(7) NOT NULL, Received DATETIME NOT NULL, Disposition VARCHAR(40) NOT NULL, - AffectsTests ENUM('Y', 'N') NOT NULL + AffectsTests ENUM('Y', 'N') NOT NULL, FromName VARCHAR(40) NULL, FromEMail VARCHAR(40) NULL, Subject VARCHAR(120) NULL,

1 0

Francois Gouget : testbot: lib: Remove an unused import from UserRoles.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: e6eba69c02383bca3fcc4d4873d92603362696fd URL: http://source.winehq.org/git/tools.git/?a=commit;h=e6eba69c02383bca3fcc4d48… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:50:34 2012 +0200 testbot: lib: Remove an unused import from UserRoles. --- testbot/lib/WineTestBot/UserRoles.pm | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/testbot/lib/WineTestBot/UserRoles.pm b/testbot/lib/WineTestBot/UserRoles.pm index f7690de..478473e 100644 --- a/testbot/lib/WineTestBot/UserRoles.pm +++ b/testbot/lib/WineTestBot/UserRoles.pm @@ -60,7 +60,6 @@ sub CreateItem return WineTestBot::UserRole->new($self); } -use Data::Dumper; sub CreateUserRoles { my $User = shift;

1 0

Francois Gouget : testbot: Assorted spelling fixes.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: 5ec3208c3cd6f77729afb357222e7c106d3e7855 URL: http://source.winehq.org/git/tools.git/?a=commit;h=5ec3208c3cd6f77729afb357… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:49:09 2012 +0200 testbot: Assorted spelling fixes. --- testbot/lib/WineTestBot/Patches.pm | 2 +- testbot/lib/WineTestBot/Steps.pm | 2 +- testbot/src/TestLauncher/TestLauncher.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/testbot/lib/WineTestBot/Patches.pm b/testbot/lib/WineTestBot/Patches.pm index 12e03eb..49bfbf0 100644 --- a/testbot/lib/WineTestBot/Patches.pm +++ b/testbot/lib/WineTestBot/Patches.pm @@ -310,7 +310,7 @@ BEGIN $PropertyDescriptors[3] = CreateBasicPropertyDescriptor("FromName", "Author", !1, !1, "A", 40); $PropertyDescriptors[4] = - CreateBasicPropertyDescriptor("FromEMail", "Email address author", !1, !1, "A", 40); + CreateBasicPropertyDescriptor("FromEMail", "Author's email address", !1, !1, "A", 40); $PropertyDescriptors[5] = CreateBasicPropertyDescriptor("Subject", "Subject", !1, !1, "A", 120); $PropertyDescriptors[6] = diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm index 74dd059..74cfa79 100644 --- a/testbot/lib/WineTestBot/Steps.pm +++ b/testbot/lib/WineTestBot/Steps.pm @@ -116,7 +116,7 @@ BEGIN $PropertyDescriptors[6] = CreateBasicPropertyDescriptor("DebugLevel", "Debug level (WINETEST_DEBUG)", !1, 1, "N", 2); $PropertyDescriptors[7] = - CreateBasicPropertyDescriptor("ReportSuccessfulTests", "Report successfull tests (WINETEST_REPORT_SUCCESS)", !1, 1, "B", 1); + CreateBasicPropertyDescriptor("ReportSuccessfulTests", "Report successful tests (WINETEST_REPORT_SUCCESS)", !1, 1, "B", 1); $PropertyDescriptors[8] = CreateDetailrefPropertyDescriptor("Tasks", "Tasks", !1, !1, \&CreateTasks); } diff --git a/testbot/src/TestLauncher/TestLauncher.c b/testbot/src/TestLauncher/TestLauncher.c index f8323b4..802ba89 100644 --- a/testbot/src/TestLauncher/TestLauncher.c +++ b/testbot/src/TestLauncher/TestLauncher.c @@ -59,13 +59,13 @@ static BOOL DllPresent(char *DllName) * dismissed. * This can happen when running tests for a system DLL on a Windows version which does not include * that DLL. It messes up our testing because the child just hangs around until the timeout expires, - * taking up testing time and generating an timeout error. + * taking up testing time and generating a timeout error. * Since the message is produced by the child process before any application code is run, we can't * suppress it using SetErrorMode() or ProcessDefaultHardErrorMode. It is possible to suppress using * the registry value ErrorMode in HKEY_LOCAL_MACHINE\CurrentControlSet\Control\Windows but that has * a global effect. - * So instead we just dive into the executables import table, determine which modules are being - * imported and check if these are present. + * So instead we just dive into the executable's import table, determine which modules are being + * imported and check if they are present. */ static BOOL AllImportedDllsPresent(char *TestExeName) {

1 0

Francois Gouget : testbot: src: Don't use C++ comments in C code.
by Alexandre Julliard Aug. 27, 2012

Aug. 27, 2012

Module: tools Branch: master Commit: 8125759dda1266b5ff9f8eada57d54cc2a46b81a URL: http://source.winehq.org/git/tools.git/?a=commit;h=8125759dda1266b5ff9f8ead… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 27 11:49:32 2012 +0200 testbot: src: Don't use C++ comments in C code. --- testbot/src/GenFixEnv/GenFixEnv.c | 3 +-- testbot/src/TestLauncher/TestLauncher.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/testbot/src/GenFixEnv/GenFixEnv.c b/testbot/src/GenFixEnv/GenFixEnv.c index b904f0c..009c88c 100644 --- a/testbot/src/GenFixEnv/GenFixEnv.c +++ b/testbot/src/GenFixEnv/GenFixEnv.c @@ -1,5 +1,4 @@ -// GenFixEnv.cpp : Defines the entry point for the console application. -// +/* GenFixEnv.cpp : Defines the entry point for the console application. */ #include <stdio.h> #include <windows.h> diff --git a/testbot/src/TestLauncher/TestLauncher.c b/testbot/src/TestLauncher/TestLauncher.c index 802ba89..4190b40 100644 --- a/testbot/src/TestLauncher/TestLauncher.c +++ b/testbot/src/TestLauncher/TestLauncher.c @@ -1,5 +1,4 @@ -// TestLauncher.cpp : Defines the entry point for the console application. -// +/* TestLauncher.cpp : Defines the entry point for the console application. */ #include <stdio.h> #include <windows.h>

1 0

Kyle Auble : Redo links on main status page
by Jeremy Newman Aug. 27, 2012

Aug. 27, 2012

Module: website Branch: master Commit: 50365369e0d6060655d522a3848a7673d99aec68 URL: http://source.winehq.org/git/website.git/?a=commit;h=50365369e0d6060655d522… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Thu Aug 23 08:09:51 2012 -0700 Redo links on main status page I've redirected some of the links on the status page to pages on the wiki. The changelog I just deleted though since changes are already recorded in git for static pages and revision history for the wiki. --- templates/en/status.template | 9 ++------- templates/he/status.template | 9 ++------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/templates/en/status.template b/templates/en/status.template index 229db34..d740b16 100644 --- a/templates/en/status.template +++ b/templates/en/status.template @@ -65,20 +65,15 @@ Status of user interface elements. </dd> - <dt><a href="{$root}/status/porting">Porting Status</a></dt> + <dt><a href="http://wiki.winehq.org/WinePortingStatus">Porting Status</a></dt> <dd> Status of porting Wine to various compilers, OSes, architectures. </dd> - <dt><a href="{$root}/status/todo">Known To Do's</a></dt> + <dt><a href="http://wiki.winehq.org/TodoList">Known TO-DOs</a></dt> <dd> List of known issues. </dd> - - <dt><a href="{$root}/status/changelog">ChangeLog</a></dt> - <dd> - Have a look here to get a feeling about development progress. - </dd> </dl> </td></tr> </table> diff --git a/templates/he/status.template b/templates/he/status.template index dc4660c..42af425 100644 --- a/templates/he/status.template +++ b/templates/he/status.template @@ -64,20 +64,15 @@ מצב רכיבי מנשק המשתמש. </dd> - <dt><a href="{$root}/status/porting">מצב ההסבה</a></dt> + <dt><a href="http://wiki.winehq.org/WinePortingStatus">מצב ההסבה</a></dt> <dd> מצב הסבת Wine למגוון של מהדרים, מערכות הפעלה, ארכיטקטורות. </dd> - <dt><a href="{$root}/status/todo">נושאים לטיפול</a></dt> + <dt><a href="http://wiki.winehq.org/TodoList">נושאים לטיפול</a></dt> <dd> רשימה של נושאים לטיפול. </dd> - - <dt><a href="{$root}/status/changelog">יומן שינויים</a></dt> - <dd> - ניתן להביט להלן כדי לקבל תחושה על התקדמות הפיתוח. - </dd> </dl> </td></tr> </table>

1 0