August 2012 - Wine-Commits - list.winehq.org

Michael Stefaniuc : wintrust: Avoid a TRUE:FALSE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: a04900df68113cf026cd6833340fd55c9aba373c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a04900df68113cf026cd68333… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:23:34 2012 +0200 wintrust: Avoid a TRUE:FALSE conditional expression. --- dlls/wintrust/asn.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wintrust/asn.c b/dlls/wintrust/asn.c index 8659266..778123e 100644 --- a/dlls/wintrust/asn.c +++ b/dlls/wintrust/asn.c @@ -2342,7 +2342,7 @@ static BOOL WINAPI CRYPT_AsnDecodeBool(DWORD dwCertEncodingType, else { *pcbStructInfo = sizeof(BOOL); - *(BOOL *)pvStructInfo = pbEncoded[2] ? TRUE : FALSE; + *(BOOL *)pvStructInfo = pbEncoded[2] != 0; ret = TRUE; } TRACE("returning %d (%08x)\n", ret, GetLastError());

1 0

Michael Stefaniuc : winhlp32: Avoid TRUE:FALSE conditional expressions.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: 66696feedea5a250dec3134bcfb9117093f787e9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=66696feedea5a250dec3134bc… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:37:07 2012 +0200 winhlp32: Avoid TRUE:FALSE conditional expressions. --- programs/winhlp32/hlpfile.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/winhlp32/hlpfile.c b/programs/winhlp32/hlpfile.c index e5248a3..96c1e75 100644 --- a/programs/winhlp32/hlpfile.c +++ b/programs/winhlp32/hlpfile.c @@ -1873,9 +1873,9 @@ static BOOL HLPFILE_ReadFont(HLPFILE* hlpfile) hlpfile->fonts[i].LogFont.lfEscapement = 0; hlpfile->fonts[i].LogFont.lfOrientation = 0; hlpfile->fonts[i].LogFont.lfWeight = (flag & 1) ? 700 : 400; - hlpfile->fonts[i].LogFont.lfItalic = (flag & 2) ? TRUE : FALSE; - hlpfile->fonts[i].LogFont.lfUnderline = (flag & 4) ? TRUE : FALSE; - hlpfile->fonts[i].LogFont.lfStrikeOut = (flag & 8) ? TRUE : FALSE; + hlpfile->fonts[i].LogFont.lfItalic = (flag & 2) != 0; + hlpfile->fonts[i].LogFont.lfUnderline = (flag & 4) != 0; + hlpfile->fonts[i].LogFont.lfStrikeOut = (flag & 8) != 0; hlpfile->fonts[i].LogFont.lfCharSet = hlpfile->charset; hlpfile->fonts[i].LogFont.lfOutPrecision = OUT_DEFAULT_PRECIS; hlpfile->fonts[i].LogFont.lfClipPrecision = CLIP_DEFAULT_PRECIS;

1 0

Michael Stefaniuc : msi/tests: Avoid a TRUE:FALSE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: 5974e9d120fc6bf88fdfd7e4832db6d0ac6663d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5974e9d120fc6bf88fdfd7e48… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:10:59 2012 +0200 msi/tests: Avoid a TRUE:FALSE conditional expression. --- dlls/msi/tests/package.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 92a0f9a..5d56afe 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -4115,7 +4115,7 @@ static void test_appsearch_reglocator(void) (const BYTE *)path, lstrlenA(path) + 1); ok( res == ERROR_SUCCESS, "Expected ERROR_SUCCESS got %d\n", res); - space = (strchr(CURR_DIR, ' ')) ? TRUE : FALSE; + space = strchr(CURR_DIR, ' ') != NULL; sprintf(path, "%s\\FileName1 -option", CURR_DIR); res = RegSetValueExA(hklm, "value17", 0, REG_SZ, (const BYTE *)path, lstrlenA(path) + 1);

1 0

Michael Stefaniuc : wineps.drv: Drop a superfluous TRUE: FALSE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: c1223611af034b6553ee7caf3cf14f5bbd46838d URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1223611af034b6553ee7caf3… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:04:03 2012 +0200 wineps.drv: Drop a superfluous TRUE:FALSE conditional expression. --- dlls/wineps.drv/driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 9443c66..358f088 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -740,7 +740,7 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP /* Printer supports colour printing - 1 if yes, 0 if no (Win2k/XP only) */ case DC_COLORDEVICE: - ret = (pi->ppd->ColorDevice != CD_False) ? TRUE : FALSE; + ret = pi->ppd->ColorDevice != CD_False; break; /* Identification number of the printer manufacturer for use with ICM (Win9x only) */

1 0

Michael Stefaniuc : explorerframe/tests: Avoid a TRUE: FALSE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: 25b0efa5bbd44f91ff7eab810bb866e150888136 URL: http://source.winehq.org/git/wine.git/?a=commit;h=25b0efa5bbd44f91ff7eab810… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:04:59 2012 +0200 explorerframe/tests: Avoid a TRUE:FALSE conditional expression. --- dlls/explorerframe/tests/nstc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/explorerframe/tests/nstc.c b/dlls/explorerframe/tests/nstc.c index 3ea408f..59654ac 100644 --- a/dlls/explorerframe/tests/nstc.c +++ b/dlls/explorerframe/tests/nstc.c @@ -558,7 +558,7 @@ static BOOL subclass_treeview(INameSpaceTreeControl *pnstc) ok(oldproc != NULL, "Failed to subclass.\n"); } - return oldproc?TRUE:FALSE; + return oldproc != 0; } static UINT get_msg_count(struct msg_sequence **seq, int sequence_index, UINT message)

1 0

Michael Stefaniuc : riched20: Avoid a TRUE:FALSE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: c0cfc9a87ab96fd507018469b0586732f48d4b6a URL: http://source.winehq.org/git/wine.git/?a=commit;h=c0cfc9a87ab96fd507018469b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:15:13 2012 +0200 riched20: Avoid a TRUE:FALSE conditional expression. --- dlls/riched20/txthost.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/txthost.c b/dlls/riched20/txthost.c index bc96588..4b72d8b 100644 --- a/dlls/riched20/txthost.c +++ b/dlls/riched20/txthost.c @@ -141,8 +141,7 @@ DECLSPEC_HIDDEN BOOL WINAPI ITextHostImpl_TxSetScrollRange(ITextHost *iface, INT DECLSPEC_HIDDEN BOOL WINAPI ITextHostImpl_TxSetScrollPos(ITextHost *iface, INT fnBar, INT nPos, BOOL fRedraw) { ITextHostImpl *This = impl_from_ITextHost(iface); - int pos = SetScrollPos(This->hWnd, fnBar, nPos, fRedraw); - return (pos ? TRUE : FALSE); + return SetScrollPos(This->hWnd, fnBar, nPos, fRedraw) != 0; } DECLSPEC_HIDDEN void WINAPI ITextHostImpl_TxInvalidateRect(ITextHost *iface, LPCRECT prc, BOOL fMode)

1 0

Michael Stefaniuc : ws2_32: Avoid a FALSE:TRUE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: 6132ed66a61b05754ad6e40cd3af222506df5e25 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6132ed66a61b05754ad6e40cd… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:16:41 2012 +0200 ws2_32: Avoid a FALSE:TRUE conditional expression. --- dlls/ws2_32/socket.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 212733b..ca5d0e4 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -2544,7 +2544,7 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, } else { - *(BOOL *)optval = (lingval.l_onoff) ? FALSE : TRUE; + *(BOOL *)optval = !lingval.l_onoff; *optlen = sizeof(BOOL); }

1 0

Michael Stefaniuc : secur32: Avoid a FALSE:TRUE conditional expression.
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

Module: wine Branch: master Commit: 8fe8e2f967f4b6557e3701708b1b9b3a917127b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8fe8e2f967f4b6557e3701708… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 14 23:18:43 2012 +0200 secur32: Avoid a FALSE:TRUE conditional expression. --- dlls/secur32/secur32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/secur32/secur32.c b/dlls/secur32/secur32.c index 05221d4..c656dee 100644 --- a/dlls/secur32/secur32.c +++ b/dlls/secur32/secur32.c @@ -430,7 +430,7 @@ SecureProvider *SECUR32_addProvider(const SecurityFunctionTableA *fnTableA, ret->moduleName = moduleName ? SECUR32_strdupW(moduleName) : NULL; _makeFnTableA(&ret->fnTableA, fnTableA, fnTableW); _makeFnTableW(&ret->fnTableW, fnTableA, fnTableW); - ret->loaded = moduleName ? FALSE : TRUE; + ret->loaded = !moduleName; } else {

1 0

New commits on branch master
by Alexandre Julliard Aug. 15, 2012

Aug. 15, 2012

URL: http://source.winehq.org/git/tools.git/?a=commit;h=f29241a99e2da0986b65e918… Merge: 4a01b75 7908f15 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Aug 15 12:01:33 2012 +0200 Import the testbot git tree. URL: http://source.winehq.org/git/tools.git/?a=commit;h=7908f1535f30c09382025a90… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Wed Feb 16 13:12:11 2011 +0100 Add multi-app support to ObjectModel URL: http://source.winehq.org/git/tools.git/?a=commit;h=59db3cf846e4e1649d620042… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Jan 15 13:30:22 2011 +0100 Give better error message when patch that doesn't affect tests is submitted URL: http://source.winehq.org/git/tools.git/?a=commit;h=9d0607e0ea9a43b7cd599048… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Jan 15 12:49:58 2011 +0100 Fix typo URL: http://source.winehq.org/git/tools.git/?a=commit;h=3f39b48e2a77bf93f7fe13d4… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Jan 13 09:47:07 2011 +0100 Prevent 2 jobs from being started simultaneously on the same VM URL: http://source.winehq.org/git/tools.git/?a=commit;h=63ef63290a31ebd2e0ab5b77… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Jan 11 13:12:06 2011 +0100 Match timeout for single testset to that of winetest.exe URL: http://source.winehq.org/git/tools.git/?a=commit;h=04a67fce26fb2fed64777239… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Dec 27 23:23:23 2010 +0100 Add retrieve of test data files URL: http://source.winehq.org/git/tools.git/?a=commit;h=e56fab6aad0e5012a80e632c… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Dec 27 23:22:35 2010 +0100 Add APPDATA env var if not present URL: http://source.winehq.org/git/tools.git/?a=commit;h=36ff6f823cbf3b204100bac3… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Dec 27 16:52:59 2010 +0100 Add LOCALAPPDATA env var if it doesn't exist URL: http://source.winehq.org/git/tools.git/?a=commit;h=6959b2317c5cd12adb077eac… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Dec 21 16:22:59 2010 +0100 Use short paths for TEMP and TMP environment variables URL: http://source.winehq.org/git/tools.git/?a=commit;h=df80af338fc6a32756e169bb… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Dec 20 10:58:29 2010 +0100 Tweak daily winetest jobs URL: http://source.winehq.org/git/tools.git/?a=commit;h=da116812991e68e0de80d2c8… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Dec 19 17:04:34 2010 +0100 Make sure correct environment is set up before running tests URL: http://source.winehq.org/git/tools.git/?a=commit;h=f923b923fb32a37d61144ee4… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Dec 18 20:35:17 2010 +0100 Perform independent scheduling on hosts URL: http://source.winehq.org/git/tools.git/?a=commit;h=9b1ce8b99bc0f142d9096190… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 2 09:53:59 2010 +0100 Fix typo URL: http://source.winehq.org/git/tools.git/?a=commit;h=a903fce199d1c7c643106ca0… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 2 09:32:48 2010 +0100 Keep retired VMs powered down URL: http://source.winehq.org/git/tools.git/?a=commit;h=2ef78a1d7fcbbeb79f85fa97… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 2 09:19:29 2010 +0100 Add "retired" as type for VM URL: http://source.winehq.org/git/tools.git/?a=commit;h=a88142a623dc77d192350a3f… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Wed Dec 1 13:39:53 2010 +0100 Don't schedule patch tests on offline VMs URL: http://source.winehq.org/git/tools.git/?a=commit;h=222af6906b584cb2352ef093… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Wed Nov 24 09:56:20 2010 +0100 Include URL in winetest.exe reports URL: http://source.winehq.org/git/tools.git/?a=commit;h=9ada41712ef6fc827184256c… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Nov 21 16:47:40 2010 +0100 Fix updating of job status after cancel URL: http://source.winehq.org/git/tools.git/?a=commit;h=90756e2c97dc512d87dff2bc… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Nov 14 14:36:42 2010 +0100 To prevent the command window sticking around in "Finished - vixScript0" state, make sure the screen is clear. See http://support.microsoft.com/kb/122514 URL: http://source.winehq.org/git/tools.git/?a=commit;h=3cf658e2a39f70c15e8b43f4… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Nov 2 11:45:55 2010 +0100 Only rebuild import lib when there is an import lib to rebuild. Don't fail if there's a problem with rebuilding, if it is serious building the test executable will fail anyway. URL: http://source.winehq.org/git/tools.git/?a=commit;h=7fed1c7be3f6760b1b33b2fa… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Nov 2 10:02:38 2010 +0100 Check correct variable for failure URL: http://source.winehq.org/git/tools.git/?a=commit;h=cbe356c9c2500521b65d9ce6… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Nov 1 11:54:59 2010 +0100 Update handling of unhandled exceptions URL: http://source.winehq.org/git/tools.git/?a=commit;h=04781de33caf2bc85fc32ebd… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Nov 1 10:59:17 2010 +0100 Make config variables global URL: http://source.winehq.org/git/tools.git/?a=commit;h=0aa5f7e4caebe9493fbf63db… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 29 12:47:41 2010 +0200 Handle updates to configure/configure.ac URL: http://source.winehq.org/git/tools.git/?a=commit;h=c349a9663d3bc04dfdf75e61… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 29 11:55:42 2010 +0200 Give some feedback about patching URL: http://source.winehq.org/git/tools.git/?a=commit;h=f1e270f3fe772bc9a03857bd… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Oct 28 17:45:37 2010 +0200 Rebuild import lib when base DLL Makefile.in changes URL: http://source.winehq.org/git/tools.git/?a=commit;h=43f74fe4c3c9fde19a41b592… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Oct 17 12:20:36 2010 +0200 Use "git apply" instead of "patch" to apply patches, so file renames are processed too URL: http://source.winehq.org/git/tools.git/?a=commit;h=0f08f4d8e04a37436bf754d3… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 14:18:08 2010 +0200 If user didn't enter remarks, use cmd line for remarks URL: http://source.winehq.org/git/tools.git/?a=commit;h=2973e01a8dbcdd8a7d71a0c7… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 02:14:29 2010 +0200 By default, don't show live screenshots while the job is running URL: http://source.winehq.org/git/tools.git/?a=commit;h=b9fc1044ee8768c838a0e1f4… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 01:39:02 2010 +0200 Make number of failures slightly easier to read URL: http://source.winehq.org/git/tools.git/?a=commit;h=b313de1da53203758d89f8de… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 01:34:11 2010 +0200 Display number of failures for completed jobs URL: http://source.winehq.org/git/tools.git/?a=commit;h=0b31ba15ed2a0e90bd4f4fa3… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 00:58:38 2010 +0200 Add support for archiving jobs URL: http://source.winehq.org/git/tools.git/?a=commit;h=ac0c8cee859df4c3b3b4a6d0… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Oct 8 00:03:31 2010 +0200 Make job purge time configurable URL: http://source.winehq.org/git/tools.git/?a=commit;h=417f26f7ccc93bfd5fc5d97b… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Oct 3 22:18:41 2010 +0200 Forgot to update a config.status command URL: http://source.winehq.org/git/tools.git/?a=commit;h=8a416c86a779a94943105ff1… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Oct 2 15:28:19 2010 +0200 For reasons that are not totally clear to me, the web server process crashes when trying to connect to the ESX host to retrieve screenshots after upgrade to OpenSuSE 11.3. The crash happens somewhere in openssl/crypto code. Connecting/retrieving screenshots works fine from the engine. So instead of retrieving the screenshot directly from the web interface, go through the engine. URL: http://source.winehq.org/git/tools.git/?a=commit;h=eb32af2159a2a80e75a600fb… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Sep 25 12:49:54 2010 +0200 Update reconfig command line URL: http://source.winehq.org/git/tools.git/?a=commit;h=baa27cc8d850ee76930d4a50… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Sep 9 13:02:40 2010 +0200 Fix adding 64-bit step when patch is submitted URL: http://source.winehq.org/git/tools.git/?a=commit;h=38776bfd9148dc579e0c6fc3… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Aug 28 08:38:00 2010 -0700 Multi-project support URL: http://source.winehq.org/git/tools.git/?a=commit;h=df8b7ef60c60d0bf8f433ec0… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jul 18 20:36:22 2010 +0200 Textual changes URL: http://source.winehq.org/git/tools.git/?a=commit;h=45a0911b28d9001ef844567a… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jul 18 20:33:47 2010 +0200 Correct spelling URL: http://source.winehq.org/git/tools.git/?a=commit;h=4a5e2189b81a525a2d6a2f9f… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jul 18 20:30:44 2010 +0200 Recognize and handle .spec file changes URL: http://source.winehq.org/git/tools.git/?a=commit;h=e3fe5176653c197fce0a7695… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Apr 27 03:05:56 2010 -0700 Add LDAP support URL: http://source.winehq.org/git/tools.git/?a=commit;h=052437969953f8d0676d5c17… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Apr 24 21:54:13 2010 +0200 Send patch test results back to tracker URL: http://source.winehq.org/git/tools.git/?a=commit;h=6a8a3c72598dab84a14a487d… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Apr 24 20:27:41 2010 +0200 Retrieve patches from source.winehq.org instead of from wine-patches URL: http://source.winehq.org/git/tools.git/?a=commit;h=9adf9fb5a0e90dcc2df64393… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Apr 22 12:48:44 2010 +0200 Rebuild include dir if one of the .idl files changed URL: http://source.winehq.org/git/tools.git/?a=commit;h=4a9c89013ba4f82db1ea028b… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Apr 20 11:15:25 2010 +0200 Minimize number of jobs submitted URL: http://source.winehq.org/git/tools.git/?a=commit;h=38ffb34b0f1925fffa920a46… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Apr 19 10:01:08 2010 +0200 Need to drop the foreign key before we can drop the primary key URL: http://source.winehq.org/git/tools.git/?a=commit;h=d7a984379c4b0a0e8aaaaf76… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Apr 19 00:41:51 2010 +0200 Run intermediate tests too URL: http://source.winehq.org/git/tools.git/?a=commit;h=6d37da6e2852b703c952113e… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Apr 18 20:48:21 2010 +0200 Use author email address + max patch no as key to determine patch sets URL: http://source.winehq.org/git/tools.git/?a=commit;h=caaf64c78003206f56c746ae… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Apr 18 13:08:34 2010 +0200 When comparing logs, don't pay attention to error line numbers URL: http://source.winehq.org/git/tools.git/?a=commit;h=476efdab21e5dde0ba66234a… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Apr 17 23:42:09 2010 +0200 Add support for programs tests URL: http://source.winehq.org/git/tools.git/?a=commit;h=e275f98dd76b837e51a0be83… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Apr 17 13:12:47 2010 +0200 Fix typo URL: http://source.winehq.org/git/tools.git/?a=commit;h=28091a6ff36749baa67a8384… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Apr 17 13:11:49 2010 +0200 Remove TODO, create output files in bin directory URL: http://source.winehq.org/git/tools.git/?a=commit;h=2e9949304f74b7b111371f66… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Apr 16 12:02:15 2010 +0200 Skip whole test instead of failing it when not all required DLLs are present on the system. URL: http://source.winehq.org/git/tools.git/?a=commit;h=149b5a2d0c6818f57a5b5353… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Apr 13 02:02:52 2010 -0700 Move to testbot.winehq.org URL: http://source.winehq.org/git/tools.git/?a=commit;h=79c5852e3fcff3261de899af… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Apr 12 11:22:45 2010 -0700 Make web layout a bit more flexible URL: http://source.winehq.org/git/tools.git/?a=commit;h=0b6028f262103d237801f816… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Apr 11 23:22:21 2010 +0200 Phase 3 changed files URL: http://source.winehq.org/git/tools.git/?a=commit;h=45d05ff21b109fe01cdbf15f… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Apr 11 23:18:03 2010 +0200 Add phase 3: automatic testing of wine-patches submissions URL: http://source.winehq.org/git/tools.git/?a=commit;h=25b11e51b741962683753504… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Apr 6 14:44:50 2010 +0200 These days, config.status expects "--file" argument URL: http://source.winehq.org/git/tools.git/?a=commit;h=8d61765723658b40bab2b1df… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Apr 6 00:31:51 2010 +0200 Only need reconfig if <dll>/tests/Makefile.in changed, not if <dll>/Makefile.in changed. URL: http://source.winehq.org/git/tools.git/?a=commit;h=0b6cfc39e5c25eebfcc6cda1… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Mar 21 22:48:12 2010 +0100 Properly handle 64-char patch file names URL: http://source.winehq.org/git/tools.git/?a=commit;h=c3c75cf627cf9c95f3ee1abc… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Mar 21 15:57:35 2010 +0100 Let users cancel their own jobs URL: http://source.winehq.org/git/tools.git/?a=commit;h=6b57d99423eebc8164059ba9… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sat Mar 20 12:14:13 2010 +0100 Fix typo URL: http://source.winehq.org/git/tools.git/?a=commit;h=83aac9defd6ed05062f6ff44… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Fri Feb 12 10:53:32 2010 +0100 Change to new Wine build targets URL: http://source.winehq.org/git/tools.git/?a=commit;h=d48664c35c75896d50f4f806… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Tue Feb 9 16:32:36 2010 +0100 Add -m flag for submitting results to test.winehq.org URL: http://source.winehq.org/git/tools.git/?a=commit;h=815423dde15414f2754edde8… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Wed Jan 20 14:46:51 2010 +0100 Timeout while waiting for tools is not a fatal error URL: http://source.winehq.org/git/tools.git/?a=commit;h=4872b59d5598ca9136b44f69… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Wed Jan 20 14:30:24 2010 +0100 Rebuild Makefile if Makefile.in changed URL: http://source.winehq.org/git/tools.git/?a=commit;h=d13a5317f2b1bec4eebedb9b… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 12:47:37 2010 +0100 Only skip steps if build/reconfigure failed, not if a test task failed URL: http://source.winehq.org/git/tools.git/?a=commit;h=4e603ae16ec7f3a397cbbf13… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 12:39:05 2010 +0100 Wait for VMware Tools to become ready after reverting a VM URL: http://source.winehq.org/git/tools.git/?a=commit;h=ec708f8794d648c6e0ea3990… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 12:24:20 2010 +0100 Properly handle NULL VmxHost entries (for Workstation) URL: http://source.winehq.org/git/tools.git/?a=commit;h=0ab47258cf26a4fe554dac2f… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 12:19:19 2010 +0100 Show message on VM selection page if one or more VMs are offline URL: http://source.winehq.org/git/tools.git/?a=commit;h=e33ae2ebedae1d0604e918ce… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Mon Jan 18 12:11:23 2010 +0100 Don't use offline VMs URL: http://source.winehq.org/git/tools.git/?a=commit;h=74ad14a45858fff6c1ff56d4… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 00:59:17 2010 +0100 Add feedback page URL: http://source.winehq.org/git/tools.git/?a=commit;h=cbe72dc0a7d2db5d8cc542d2… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 18 00:57:27 2010 +0100 Make field on web page same length as database length URL: http://source.winehq.org/git/tools.git/?a=commit;h=8c165e0278286e4c6792296b… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jan 17 23:37:53 2010 +0100 Reset Jobs before doing a Schedule URL: http://source.winehq.org/git/tools.git/?a=commit;h=325f1d68de98cde8aac2cdf1… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jan 17 23:37:30 2010 +0100 Add support for VMs on multiple hosts URL: http://source.winehq.org/git/tools.git/?a=commit;h=04f6758d14e85aa422a45ded… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Jan 17 23:33:54 2010 +0100 Only count extra VMs in CountPoweredOnExtraVMs URL: http://source.winehq.org/git/tools.git/?a=commit;h=3843a35ee7311189e44e3f01… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Sun Jan 17 21:19:51 2010 +0100 Make tag prefix configurable URL: http://source.winehq.org/git/tools.git/?a=commit;h=2bb7d8317973e943d1ab5f01… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Sun Jan 17 21:09:32 2010 +0100 Maximize number of powered on VMs URL: http://source.winehq.org/git/tools.git/?a=commit;h=93d708967df8cff22faf25a8… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Thu Jan 7 15:01:34 2010 +0100 Fix running of scripts on Win9x/WinMe URL: http://source.winehq.org/git/tools.git/?a=commit;h=368d9ce5f6dbec2fdf9945a1… Author: Paul Vriens <paul.vriens.wine(a)gmail.com> Date: Thu Jan 7 11:49:06 2010 +0100 Allow selection of only extra VMs, without base VMs. URL: http://source.winehq.org/git/tools.git/?a=commit;h=699ca367462b912fab02c773… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 4 01:50:27 2010 +0100 TestExecutable is only required for patch jobs URL: http://source.winehq.org/git/tools.git/?a=commit;h=c1253afca929156058c6ecd1… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Mon Jan 4 00:32:21 2010 +0100 Close database connection before forking, otherwise the child process might close the connection at an unexpected moment. URL: http://source.winehq.org/git/tools.git/?a=commit;h=8d52a8abd046ac41525026c3… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 31 13:43:11 2009 +0100 All generated email traffic should have RobotEMail as its sender address URL: http://source.winehq.org/git/tools.git/?a=commit;h=320db9bf51b9b217a4663d25… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 31 13:39:54 2009 +0100 Add reconfiguration of Wine build VM when git is updated URL: http://source.winehq.org/git/tools.git/?a=commit;h=22f131ded8a6515281b62fb5… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 31 10:31:21 2009 +0100 Add some info about setting up the build VM URL: http://source.winehq.org/git/tools.git/?a=commit;h=fa4028e5af67bfc8d1fe2fa1… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Thu Dec 31 10:28:46 2009 +0100 Add handling of patch files in addition to executables URL: http://source.winehq.org/git/tools.git/?a=commit;h=7150888159f22e269cda17ee… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Tue Dec 22 14:24:01 2009 +0100 Handle error messages containing single quotes URL: http://source.winehq.org/git/tools.git/?a=commit;h=4af645d8ba6b96e7b5a29173… Author: Andre Hentschel <nerv(a)dawncrow.de> Date: Mon Dec 21 15:54:54 2009 +0100 Warn when name of uploaded file doesn't end in .exe URL: http://source.winehq.org/git/tools.git/?a=commit;h=f5c64713bf28b25ecb09dbff… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Dec 20 23:02:07 2009 +0100 Add possibility to set WINETEST_DEBUG and WINETEST_REPORT_SUCCESS env vars URL: http://source.winehq.org/git/tools.git/?a=commit;h=8d67b6049cc0a07c5318fc0d… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Dec 20 14:49:36 2009 +0100 Attempt to display times in users own timezone URL: http://source.winehq.org/git/tools.git/?a=commit;h=52b982d0dfe2a10af15405d5… Author: Ge van Geldorp <ggeldorp(a)vmware.com> Date: Sun Dec 20 09:50:58 2009 +0100 Git maintenance URL: http://source.winehq.org/git/tools.git/?a=commit;h=71972ce67b5c7e61de703733… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Sat Dec 19 21:30:44 2009 +0000 Show warning message if job is submitted without command line arg git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)25 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f56d3aa809108580149a3c3a… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Sat Dec 19 21:06:00 2009 +0000 Run winetest64-latest.exe on 64-bit machines git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)24 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f06ccbd0d6800646228a8e72… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Sat Dec 19 16:35:33 2009 +0000 Only send logs when job completes, not for individual tasks git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)23 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=cbcb1268889e817a39f71598… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Sat Dec 19 15:27:48 2009 +0000 Paul Vriens: fix revert for Workstation VMs. git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)22 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f0286783831bef5cf61ce9cf… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Fri Dec 18 15:26:12 2009 +0000 Send notification email on job completion git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)21 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=caa9fb9c5d668589862cd9fb… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Fri Dec 18 15:25:49 2009 +0000 Don't close file that's not open git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)20 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=7ecccdf08ea53f57c23b089f… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Fri Dec 18 15:25:35 2009 +0000 Add RobotEMail setting git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)19 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=4852169f17229f6bc88e1ed6… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Fri Dec 18 15:25:07 2009 +0000 Fix problem for Paul git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)18 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=a27956d4377403cd27ce8d20… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Thu Dec 17 17:25:36 2009 +0000 Summary line can contain "1 failure", so make the "s" optional git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)17 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=5050f1aa6c7eb0b66a00271d… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Thu Dec 17 15:01:06 2009 +0000 Improve test failure reporting and log display git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)16 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=f27205882396d4b54f5c5163… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Wed Dec 16 12:13:44 2009 +0000 Add update script git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)15 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=886358f2349e57dea24ad0e3… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Wed Dec 16 11:54:02 2009 +0000 Make display of live screenshot dependent on task status, not on VM status git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)14 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=28d44ab9be94cc8598c797af… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Wed Dec 16 11:47:18 2009 +0000 Add Janitor script git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)13 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=6b9132a4a93b62be4a6fb66f… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Wed Dec 16 11:47:05 2009 +0000 Delete detail records before deleting master record git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)12 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=37ddbb6a70f72b0386edfdfe… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Wed Dec 16 10:26:31 2009 +0000 Revert VMs in the proper order git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)11 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=45459f3423fa9b3f2e4b7f13… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 15 15:06:41 2009 +0000 Keep non-base VMs powered off, only power them on just before they execute a task git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)10 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=ec525ea44eed522c4d8c0296… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 15 15:06:14 2009 +0000 Only revert 1 VM at a time git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)9 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=af4b28b030f8fde0e2f5ffdb… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 15 11:30:37 2009 +0000 Sort users alphabetically git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)8 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=1382c4a6caae473caaf9445f… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 15 11:29:55 2009 +0000 Check correct 16/32 bit radiobutton git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)7 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=05249bdc8c1dc21c56ec23fc… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 15 11:08:32 2009 +0000 Remove MemSize property from VM git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)6 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=ed1def53c30a76157f0065f3… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Sun Dec 13 23:50:22 2009 +0000 Improve configurability by splitting out some stuff to a local config file git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)5 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=a6d0b29fe394334152e774b0… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Thu Dec 3 11:26:49 2009 +0000 Simple install instructions git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)4 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=584d5150214e527aed89e14b… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Tue Dec 1 15:01:25 2009 +0000 msi:install takes about 2 min (winetest.exe max) when running on 3 VMs simultaneously, so let's be safe and run on 2 max git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)3 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=13c3b5937f44e90ead863da4… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Mon Nov 30 09:31:28 2009 +0000 Initial check-in git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)2 e58c499e-dd92-11de-a1ee-cffa2974b925 URL: http://source.winehq.org/git/tools.git/?a=commit;h=8f935f24acfbb27f943cb325… Author: ggeldorp <ggeldorp(a)e58c499e-dd92-11de-a1ee-cffa2974b925> Date: Mon Nov 30 09:30:49 2009 +0000 Create standard svn repo layout git-svn-id: svn+ssh://v1.vmlan/srv/svn/repos_winetestbot/trunk(a)1 e58c499e-dd92-11de-a1ee-cffa2974b925

1 0

Jacek Caban : rpcrt4: Added prepare_async_request helper.
by Alexandre Julliard Aug. 14, 2012

Aug. 14, 2012

Module: wine Branch: master Commit: cba1cfc645bd605ed06422f630211cd8de4b0fd7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cba1cfc645bd605ed06422f63… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Aug 14 13:35:06 2012 +0200 rpcrt4: Added prepare_async_request helper. --- dlls/rpcrt4/rpc_transport.c | 19 +++++++++++-------- 1 files changed, 11 insertions(+), 8 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index f873f71..501e5cc 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -1870,6 +1870,12 @@ static ULONG RpcHttpAsyncData_Release(RpcHttpAsyncData *data) return refs; } +static void prepare_async_request(RpcHttpAsyncData *async_data) +{ + ResetEvent(async_data->completion_event); + RpcHttpAsyncData_AddRef(async_data); +} + typedef struct _RpcConnection_http { RpcConnection common; @@ -2165,8 +2171,7 @@ static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsync DWORD bytes_read, bytes_written; /* prepare in pipe */ - ResetEvent(async_data->completion_event); - RpcHttpAsyncData_AddRef(async_data); + prepare_async_request(async_data); ret = HttpSendRequestW(in_request, NULL, 0, NULL, 0); if (!ret) { @@ -2189,8 +2194,7 @@ static RPC_STATUS rpcrt4_http_prepare_in_pipe(HINTERNET in_request, RpcHttpAsync buffers_in.dwStructSize = sizeof(buffers_in); /* FIXME: get this from the registry */ buffers_in.dwBufferTotal = 1024 * 1024 * 1024; /* 1Gb */ - ResetEvent(async_data->completion_event); - RpcHttpAsyncData_AddRef(async_data); + prepare_async_request(async_data); ret = HttpSendRequestExW(in_request, &buffers_in, NULL, 0, 0); if (!ret) { @@ -2279,8 +2283,7 @@ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, RpcPktHdr pkt_from_server; ULONG field1, field3; - ResetEvent(async_data->completion_event); - RpcHttpAsyncData_AddRef(async_data); + prepare_async_request(async_data); ret = HttpSendRequestW(out_request, NULL, 0, NULL, 0); if (!ret) { @@ -2301,8 +2304,8 @@ static RPC_STATUS rpcrt4_http_prepare_out_pipe(HINTERNET out_request, hdr = RPCRT4_BuildHttpConnectHeader(0, TRUE, connection_uuid, out_pipe_uuid, NULL); if (!hdr) return RPC_S_OUT_OF_RESOURCES; - ResetEvent(async_data->completion_event); - RpcHttpAsyncData_AddRef(async_data); + + prepare_async_request(async_data); ret = HttpSendRequestW(out_request, NULL, 0, hdr, hdr->common.frag_len); if (!ret) {

1 0