September 2012 - Wine-Commits

Alexandre Julliard : Import of upstream bugzilla release 4.0.8.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

1 0

Alexandre Julliard : Merge branch 'upstream'.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: bugzilla Branch: master Commit: 480ff98127eb5a268b7d1fb17bc543856aaafed5 URL: http://source.winehq.org/git/bugzilla.git/?a=commit;h=480ff98127eb5a268b7d1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Sep 19 23:46:06 2012 +0200 Merge branch 'upstream'. ---

1 0

Alexandre Julliard : Import of upstream bugzilla release 4.0.8.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

1 0

Piotr Caban : wininet: Added support for leaked urlcache entries handling.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: b7010348cfc53674913733b72033ee16a6868f99 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b7010348cfc53674913733b72… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Sep 19 15:30:03 2012 +0200 wininet: Added support for leaked urlcache entries handling. --- dlls/wininet/urlcache.c | 170 ++++++++++++++++++++++++++++++----------------- 1 files changed, 109 insertions(+), 61 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index 04ecd80..3a028b5 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -82,6 +82,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(wininet); #define PENDING_DELETE_CACHE_ENTRY 0x00400000 +#define CACHE_HEADER_DATA_ROOT_LEAK_OFFSET 0x16 + #define DWORD_SIG(a,b,c,d) (a | (b << 8) | (c << 16) | (d << 24)) #define URL_SIGNATURE DWORD_SIG('U','R','L',' ') #define REDR_SIGNATURE DWORD_SIG('R','E','D','R') @@ -752,44 +754,6 @@ static BOOL URLCacheContainer_UnlockIndex(URLCACHECONTAINER * pContainer, LPURLC return UnmapViewOfFile(pHeader); } -/*********************************************************************** - * URLCacheContainer_CleanIndex (Internal) - * - * This function is meant to make place in index file by removing old - * entries and resizing the file. - * - * CAUTION: file view may get mapped to new memory - * TODO: implement entries cleaning - * - * RETURNS - * ERROR_SUCCESS when new memory is available - * error code otherwise - */ -static DWORD URLCacheContainer_CleanIndex(URLCACHECONTAINER *container, URLCACHE_HEADER **file_view) -{ - URLCACHE_HEADER *header = *file_view; - DWORD ret; - - FIXME("(%s %s) semi-stub\n", debugstr_w(container->cache_prefix), debugstr_w(container->path)); - - if(header->dwFileSize >= ALLOCATION_TABLE_SIZE*8*BLOCKSIZE + ENTRY_START_OFFSET) { - WARN("index file has maximal size\n"); - return ERROR_NOT_ENOUGH_MEMORY; - } - - URLCacheContainer_CloseIndex(container); - ret = URLCacheContainer_OpenIndex(container, header->dwIndexCapacityInBlocks*2); - if(ret != ERROR_SUCCESS) - return ret; - header = MapViewOfFile(container->hMapping, FILE_MAP_WRITE, 0, 0, 0); - if(!header) - return GetLastError(); - - UnmapViewOfFile(*file_view); - *file_view = header; - return ERROR_SUCCESS; -} - #ifndef CHAR_BIT #define CHAR_BIT (8 * sizeof(CHAR)) #endif @@ -996,6 +960,107 @@ static BOOL URLCache_LocalFileNameToPathA( return FALSE; } +/*********************************************************************** + * URLCache_DeleteFile (Internal) + */ +static DWORD URLCache_DeleteFile(const URLCACHECONTAINER *container, + URLCACHE_HEADER *header, URL_CACHEFILE_ENTRY *url_entry) +{ + WCHAR path[MAX_PATH]; + LONG path_size = sizeof(path); + DWORD err; + + if(!url_entry->dwOffsetLocalName) + goto succ; + + if(!URLCache_LocalFileNameToPathW(container, header, + (LPCSTR)url_entry+url_entry->dwOffsetLocalName, + url_entry->CacheDir, path, &path_size)) + goto succ; + + err = (DeleteFileW(path) ? ERROR_SUCCESS : GetLastError()); + if(err == ERROR_ACCESS_DENIED || err == ERROR_SHARING_VIOLATION) + return err; + +succ: + if (url_entry->CacheDir < header->DirectoryCount) + { + if (header->directory_data[url_entry->CacheDir].dwNumFiles) + header->directory_data[url_entry->CacheDir].dwNumFiles--; + } + if (url_entry->CacheEntryType & STICKY_CACHE_ENTRY) + { + if (url_entry->size.QuadPart < header->ExemptUsage.QuadPart) + header->ExemptUsage.QuadPart -= url_entry->size.QuadPart; + else + header->ExemptUsage.QuadPart = 0; + } + else + { + if (url_entry->size.QuadPart < header->CacheUsage.QuadPart) + header->CacheUsage.QuadPart -= url_entry->size.QuadPart; + else + header->CacheUsage.QuadPart = 0; + } + + return ERROR_SUCCESS; +} + +/*********************************************************************** + * URLCacheContainer_CleanIndex (Internal) + * + * This function is meant to make place in index file by removing leaked + * files entries and resizing the file. + * + * CAUTION: file view may get mapped to new memory + * + * RETURNS + * ERROR_SUCCESS when new memory is available + * error code otherwise + */ +static DWORD URLCacheContainer_CleanIndex(URLCACHECONTAINER *container, URLCACHE_HEADER **file_view) +{ + URLCACHE_HEADER *header = *file_view; + DWORD ret; + DWORD *leak_off; + BOOL freed = FALSE; + + TRACE("(%s %s)\n", debugstr_w(container->cache_prefix), debugstr_w(container->path)); + + leak_off = &(*file_view)->options[CACHE_HEADER_DATA_ROOT_LEAK_OFFSET]; + while(*leak_off) { + URL_CACHEFILE_ENTRY *url_entry = (URL_CACHEFILE_ENTRY*)((LPBYTE)(*file_view) + *leak_off); + + if(SUCCEEDED(URLCache_DeleteFile(container, *file_view, url_entry))) { + *leak_off = url_entry->dwExemptDelta; + URLCache_DeleteEntry(*file_view, &url_entry->CacheFileEntry); + freed = TRUE; + }else { + leak_off = &url_entry->dwExemptDelta; + } + } + + if(freed) + return ERROR_SUCCESS; + + if(header->dwFileSize >= ALLOCATION_TABLE_SIZE*8*BLOCKSIZE + ENTRY_START_OFFSET) { + WARN("index file has maximal size\n"); + return ERROR_NOT_ENOUGH_MEMORY; + } + + URLCacheContainer_CloseIndex(container); + ret = URLCacheContainer_OpenIndex(container, header->dwIndexCapacityInBlocks*2); + if(ret != ERROR_SUCCESS) + return ret; + header = MapViewOfFile(container->hMapping, FILE_MAP_WRITE, 0, 0, 0); + if(!header) + return GetLastError(); + + UnmapViewOfFile(*file_view); + *file_view = header; + return ERROR_SUCCESS; +} + /* Just like DosDateTimeToFileTime, except that it also maps the special * case of a DOS date/time of (0,0) to a filetime of (0,0). */ @@ -2218,8 +2283,6 @@ static BOOL DeleteUrlCacheEntryInternal(const URLCACHECONTAINER * pContainer, { CACHEFILE_ENTRY * pEntry; URL_CACHEFILE_ENTRY * pUrlEntry; - WCHAR path[MAX_PATH]; - LONG path_size = sizeof(path); pEntry = (CACHEFILE_ENTRY *)((LPBYTE)pHeader + pHashEntry->dwOffsetEntry); if (pEntry->dwSignature != URL_SIGNATURE) @@ -2239,33 +2302,18 @@ static BOOL DeleteUrlCacheEntryInternal(const URLCACHECONTAINER * pContainer, return FALSE; } - if (pUrlEntry->CacheDir < pHeader->DirectoryCount) + if(!URLCache_DeleteFile(pContainer, pHeader, pUrlEntry)) { - if (pHeader->directory_data[pUrlEntry->CacheDir].dwNumFiles) - pHeader->directory_data[pUrlEntry->CacheDir].dwNumFiles--; - } - if (pUrlEntry->CacheEntryType & STICKY_CACHE_ENTRY) - { - if (pUrlEntry->size.QuadPart < pHeader->ExemptUsage.QuadPart) - pHeader->ExemptUsage.QuadPart -= pUrlEntry->size.QuadPart; - else - pHeader->ExemptUsage.QuadPart = 0; + URLCache_DeleteEntry(pHeader, pEntry); } else { - if (pUrlEntry->size.QuadPart < pHeader->CacheUsage.QuadPart) - pHeader->CacheUsage.QuadPart -= pUrlEntry->size.QuadPart; - else - pHeader->CacheUsage.QuadPart = 0; - } - - if (pUrlEntry->dwOffsetLocalName && URLCache_LocalFileNameToPathW(pContainer, pHeader, - (LPCSTR)pUrlEntry+pUrlEntry->dwOffsetLocalName, pUrlEntry->CacheDir, path, &path_size)) - { - DeleteFileW(path); + /* Add entry to leaked files list */ + pUrlEntry->CacheFileEntry.dwSignature = LEAK_SIGNATURE; + pUrlEntry->dwExemptDelta = pHeader->options[CACHE_HEADER_DATA_ROOT_LEAK_OFFSET]; + pHeader->options[CACHE_HEADER_DATA_ROOT_LEAK_OFFSET] = pHashEntry->dwOffsetEntry; } - URLCache_DeleteEntry(pHeader, pEntry); URLCache_DeleteEntryFromHash(pHashEntry); return TRUE; }

1 0

Piotr Caban : wininet: Don' t delete files that were modified after adding to cache.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: e3a2e3a1c992477d61d643a92093e722f4876838 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e3a2e3a1c992477d61d643a92… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Sep 19 15:30:25 2012 +0200 wininet: Don't delete files that were modified after adding to cache. --- dlls/wininet/urlcache.c | 62 +++++++++++++++++++++------------------------- 1 files changed, 28 insertions(+), 34 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index 3a028b5..379288a 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -127,8 +127,8 @@ typedef struct _URL_CACHEFILE_ENTRY WORD wLastSyncTime; /* last sync time in dos format */ DWORD dwHitRate; /* see INTERNET_CACHE_ENTRY_INFO::dwHitRate */ DWORD dwUseCount; /* see INTERNET_CACHE_ENTRY_INFO::dwUseCount */ - WORD wUnknownDate; /* usually same as wLastSyncDate */ - WORD wUnknownTime; /* usually same as wLastSyncTime */ + WORD LastWriteDate; + WORD LastWriteTime; DWORD dwUnknown7; /* usually zero */ DWORD dwUnknown8; /* usually zero */ /* packing to dword align start of next field */ @@ -960,15 +960,29 @@ static BOOL URLCache_LocalFileNameToPathA( return FALSE; } +/* Just like FileTimeToDosDateTime, except that it also maps the special + * case of a filetime of (0,0) to a DOS date/time of (0,0). + */ +static void URLCache_FileTimeToDosDateTime(const FILETIME *ft, WORD *fatdate, + WORD *fattime) +{ + if (!ft->dwLowDateTime && !ft->dwHighDateTime) + *fatdate = *fattime = 0; + else + FileTimeToDosDateTime(ft, fatdate, fattime); +} + /*********************************************************************** * URLCache_DeleteFile (Internal) */ static DWORD URLCache_DeleteFile(const URLCACHECONTAINER *container, URLCACHE_HEADER *header, URL_CACHEFILE_ENTRY *url_entry) { + WIN32_FILE_ATTRIBUTE_DATA attr; WCHAR path[MAX_PATH]; LONG path_size = sizeof(path); DWORD err; + WORD date, time; if(!url_entry->dwOffsetLocalName) goto succ; @@ -978,6 +992,12 @@ static DWORD URLCache_DeleteFile(const URLCACHECONTAINER *container, url_entry->CacheDir, path, &path_size)) goto succ; + if(!GetFileAttributesExW(path, GetFileExInfoStandard, &attr)) + goto succ; + URLCache_FileTimeToDosDateTime(&attr.ftLastWriteTime, &date, &time); + if(date != url_entry->LastWriteDate || time != url_entry->LastWriteTime) + goto succ; + err = (DeleteFileW(path) ? ERROR_SUCCESS : GetLastError()); if(err == ERROR_ACCESS_DENIED || err == ERROR_SHARING_VIOLATION) return err; @@ -1203,18 +1223,6 @@ static DWORD URLCache_CopyEntry( return ERROR_SUCCESS; } -/* Just like FileTimeToDosDateTime, except that it also maps the special - * case of a filetime of (0,0) to a DOS date/time of (0,0). - */ -static void URLCache_FileTimeToDosDateTime(const FILETIME *ft, WORD *fatdate, - WORD *fattime) -{ - if (!ft->dwLowDateTime && !ft->dwHighDateTime) - *fatdate = *fattime = 0; - else - FileTimeToDosDateTime(ft, fatdate, fattime); -} - /*********************************************************************** * URLCache_SetEntryInfo (Internal) * @@ -2741,6 +2749,7 @@ static BOOL CommitUrlCacheEntryInternal( DWORD dwOffsetLocalFileName = 0; DWORD dwOffsetHeader = 0; DWORD dwOffsetFileExtension = 0; + WIN32_FILE_ATTRIBUTE_DATA file_attr; LARGE_INTEGER file_size; BYTE cDirectory = 0; char achFile[MAX_PATH]; @@ -2768,28 +2777,14 @@ static BOOL CommitUrlCacheEntryInternal( if (lpszOriginalUrl) WARN(": lpszOriginalUrl ignored\n"); - file_size.QuadPart = 0; + memset(&file_attr, 0, sizeof(file_attr)); if (lpszLocalFileName) { - HANDLE hFile; - - hFile = CreateFileW(lpszLocalFileName, FILE_READ_ATTRIBUTES, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, 0, NULL); - if (hFile == INVALID_HANDLE_VALUE) - { - ERR("couldn't open file %s (error is %d)\n", debugstr_w(lpszLocalFileName), GetLastError()); + if(!GetFileAttributesExW(lpszLocalFileName, GetFileExInfoStandard, &file_attr)) return FALSE; - } - - /* Get file size */ - if (!GetFileSizeEx(hFile, &file_size)) - { - ERR("couldn't get file size (error is %d)\n", GetLastError()); - CloseHandle(hFile); - return FALSE; - } - - CloseHandle(hFile); } + file_size.u.LowPart = file_attr.nFileSizeLow; + file_size.u.HighPart = file_attr.nFileSizeHigh; error = URLCacheContainers_FindContainerW(lpszUrlName, &pContainer); if (error != ERROR_SUCCESS) @@ -2931,8 +2926,7 @@ static BOOL CommitUrlCacheEntryInternal( pUrlEntry->LastModifiedTime = LastModifiedTime; URLCache_FileTimeToDosDateTime(&pUrlEntry->LastAccessTime, &pUrlEntry->wLastSyncDate, &pUrlEntry->wLastSyncTime); URLCache_FileTimeToDosDateTime(&ExpireTime, &pUrlEntry->wExpiredDate, &pUrlEntry->wExpiredTime); - pUrlEntry->wUnknownDate = pUrlEntry->wLastSyncDate; - pUrlEntry->wUnknownTime = pUrlEntry->wLastSyncTime; + URLCache_FileTimeToDosDateTime(&file_attr.ftLastWriteTime, &pUrlEntry->LastWriteDate, &pUrlEntry->LastWriteTime); /*** Unknowns ***/ pUrlEntry->dwUnknown1 = 0;

1 0

Piotr Caban : wininet: Define more fields in urlcache header structure.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: dba38b1ab437e42f3cd50146a92d19872c83db14 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dba38b1ab437e42f3cd50146a… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Sep 19 15:29:44 2012 +0200 wininet: Define more fields in urlcache header structure. --- dlls/wininet/urlcache.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index 04ffd90..04ecd80 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -62,6 +62,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wininet); #define ENTRY_START_OFFSET 0x4000 #define DIR_LENGTH 8 +#define MAX_DIR_NO 0x20 #define BLOCKSIZE 128 #define HASHTABLE_SIZE 448 #define HASHTABLE_NUM_ENTRIES 64 /* this needs to be power of 2, that divides HASHTABLE_SIZE */ @@ -167,8 +168,10 @@ typedef struct _URLCACHE_HEADER ULARGE_INTEGER CacheLimit; ULARGE_INTEGER CacheUsage; ULARGE_INTEGER ExemptUsage; - DWORD DirectoryCount; /* number of directory_data's */ - DIRECTORY_DATA directory_data[1]; /* first directory entry */ + DWORD DirectoryCount; + DIRECTORY_DATA directory_data[MAX_DIR_NO]; + DWORD options[0x21]; + BYTE allocation_table[ALLOCATION_TABLE_SIZE]; } URLCACHE_HEADER, *LPURLCACHE_HEADER; typedef const URLCACHE_HEADER *LPCURLCACHE_HEADER; @@ -850,7 +853,6 @@ static inline void URLCache_Allocation_BlockAllocate(BYTE * AllocationTable, DWO */ static DWORD URLCache_FindFirstFreeEntry(URLCACHE_HEADER * pHeader, DWORD dwBlocksNeeded, CACHEFILE_ENTRY ** ppEntry) { - LPBYTE AllocationTable = (LPBYTE)pHeader + ALLOCATION_TABLE_OFFSET; DWORD dwBlockNumber; DWORD dwFreeCounter; for (dwBlockNumber = 0; dwBlockNumber < pHeader->dwIndexCapacityInBlocks; dwBlockNumber++) @@ -858,7 +860,7 @@ static DWORD URLCache_FindFirstFreeEntry(URLCACHE_HEADER * pHeader, DWORD dwBloc for (dwFreeCounter = 0; dwFreeCounter < dwBlocksNeeded && dwFreeCounter + dwBlockNumber < pHeader->dwIndexCapacityInBlocks && - URLCache_Allocation_BlockIsFree(AllocationTable, dwBlockNumber + dwFreeCounter); + URLCache_Allocation_BlockIsFree(pHeader->allocation_table, dwBlockNumber + dwFreeCounter); dwFreeCounter++) TRACE("Found free block at no. %d (0x%x)\n", dwBlockNumber, ENTRY_START_OFFSET + dwBlockNumber * BLOCKSIZE); @@ -867,7 +869,7 @@ static DWORD URLCache_FindFirstFreeEntry(URLCACHE_HEADER * pHeader, DWORD dwBloc DWORD index; TRACE("Found free blocks starting at no. %d (0x%x)\n", dwBlockNumber, ENTRY_START_OFFSET + dwBlockNumber * BLOCKSIZE); for (index = 0; index < dwBlocksNeeded; index++) - URLCache_Allocation_BlockAllocate(AllocationTable, dwBlockNumber + index); + URLCache_Allocation_BlockAllocate(pHeader->allocation_table, dwBlockNumber + index); *ppEntry = (CACHEFILE_ENTRY *)((LPBYTE)pHeader + ENTRY_START_OFFSET + dwBlockNumber * BLOCKSIZE); for (index = 0; index < dwBlocksNeeded * BLOCKSIZE / sizeof(DWORD); index++) ((DWORD*)*ppEntry)[index] = 0xdeadbeef; @@ -893,12 +895,11 @@ static BOOL URLCache_DeleteEntry(LPURLCACHE_HEADER pHeader, CACHEFILE_ENTRY * pE { DWORD dwStartBlock; DWORD dwBlock; - BYTE * AllocationTable = (LPBYTE)pHeader + ALLOCATION_TABLE_OFFSET; /* update allocation table */ dwStartBlock = ((DWORD)((BYTE *)pEntry - (BYTE *)pHeader) - ENTRY_START_OFFSET) / BLOCKSIZE; for (dwBlock = dwStartBlock; dwBlock < dwStartBlock + pEntry->dwBlocksUsed; dwBlock++) - URLCache_Allocation_BlockFree(AllocationTable, dwBlock); + URLCache_Allocation_BlockFree(pHeader->allocation_table, dwBlock); return TRUE; }

1 0

Henri Verbeet : d3d10core: Replace a FIXME with a TRACE in d3d10_device_CreateSamplerState().
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: 843db2c3643000cab3fc2f9a3167a8c130fb6112 URL: http://source.winehq.org/git/wine.git/?a=commit;h=843db2c3643000cab3fc2f9a3… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 18 22:13:55 2012 +0200 d3d10core: Replace a FIXME with a TRACE in d3d10_device_CreateSamplerState(). --- dlls/d3d10core/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3d10core/device.c b/dlls/d3d10core/device.c index 1e54db2..b6c29f4 100644 --- a/dlls/d3d10core/device.c +++ b/dlls/d3d10core/device.c @@ -1091,7 +1091,7 @@ static HRESULT STDMETHODCALLTYPE d3d10_device_CreateSamplerState(ID3D10Device *i struct d3d10_sampler_state *object; HRESULT hr; - FIXME("iface %p, desc %p, sampler_state %p.\n", iface, desc, sampler_state); + TRACE("iface %p, desc %p, sampler_state %p.\n", iface, desc, sampler_state); object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); if (!object)

1 0

Alexandre Julliard : winex11: Add window data structure locking to the ConfigureNotify event handler.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: 24c0abfd40a977ae82bc8af9330d28f192e4e295 URL: http://source.winehq.org/git/wine.git/?a=commit;h=24c0abfd40a977ae82bc8af93… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Sep 19 13:13:23 2012 +0200 winex11: Add window data structure locking to the ConfigureNotify event handler. --- dlls/winex11.drv/event.c | 19 ++++++++++++++----- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c index 5b50978..d58919c 100644 --- a/dlls/winex11.drv/event.c +++ b/dlls/winex11.drv/event.c @@ -993,17 +993,17 @@ void X11DRV_ConfigureNotify( HWND hwnd, XEvent *xev ) int cx, cy, x = event->x, y = event->y; if (!hwnd) return; - if (!(data = X11DRV_get_win_data( hwnd ))) return; - if (!data->mapped || data->iconic) return; - if (data->whole_window && !data->managed) return; + if (!(data = get_win_data( hwnd ))) return; + if (!data->mapped || data->iconic) goto done; + if (data->whole_window && !data->managed) goto done; /* ignore synthetic events on foreign windows */ - if (event->send_event && !data->whole_window) return; + if (event->send_event && !data->whole_window) goto done; if (data->configure_serial && (long)(data->configure_serial - event->serial) > 0) { TRACE( "win %p/%lx event %d,%d,%dx%d ignoring old serial %lu/%lu\n", hwnd, data->whole_window, event->x, event->y, event->width, event->height, event->serial, data->configure_serial ); - return; + goto done; } /* Get geometry */ @@ -1059,6 +1059,7 @@ void X11DRV_ConfigureNotify( HWND hwnd, XEvent *xev ) if (!IsZoomed( data->hwnd )) { TRACE( "win %p/%lx is maximized\n", data->hwnd, data->whole_window ); + release_win_data( data ); SendMessageW( data->hwnd, WM_SYSCOMMAND, SC_MAXIMIZE, 0 ); return; } @@ -1068,13 +1069,21 @@ void X11DRV_ConfigureNotify( HWND hwnd, XEvent *xev ) if (IsZoomed( data->hwnd )) { TRACE( "window %p/%lx is no longer maximized\n", data->hwnd, data->whole_window ); + release_win_data( data ); SendMessageW( data->hwnd, WM_SYSCOMMAND, SC_RESTORE, 0 ); return; } } if ((flags & (SWP_NOSIZE | SWP_NOMOVE)) != (SWP_NOSIZE | SWP_NOMOVE)) + { + release_win_data( data ); SetWindowPos( hwnd, 0, x, y, cx, cy, flags ); + return; + } + +done: + release_win_data( data ); }

1 0

Henri Verbeet : wined3d: wined3d_device_get_sampler_state() never fails.
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: 62670c7ba530ee894f8c1d8f58e3e5405d77b8f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=62670c7ba530ee894f8c1d8f5… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 18 22:13:58 2012 +0200 wined3d: wined3d_device_get_sampler_state() never fails. --- dlls/d3d8/device.c | 4 ++-- dlls/d3d9/device.c | 5 ++--- dlls/ddraw/device.c | 29 ++++++++--------------------- dlls/wined3d/device.c | 15 ++++++--------- dlls/wined3d/wined3d.spec | 2 +- include/wine/wined3d.h | 4 ++-- 6 files changed, 21 insertions(+), 38 deletions(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 2b7e7c0..5e21a38 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -1785,7 +1785,7 @@ static HRESULT WINAPI d3d8_device_GetTextureStageState(IDirect3DDevice8 *iface, { struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); const struct tss_lookup *l; - HRESULT hr; + HRESULT hr = D3D_OK; TRACE("iface %p, stage %u, state %#x, value %p.\n", iface, stage, Type, value); @@ -1799,7 +1799,7 @@ static HRESULT WINAPI d3d8_device_GetTextureStageState(IDirect3DDevice8 *iface, wined3d_mutex_lock(); if (l->sampler_state) - hr = wined3d_device_get_sampler_state(device->wined3d_device, stage, l->state, value); + *value = wined3d_device_get_sampler_state(device->wined3d_device, stage, l->state); else hr = wined3d_device_get_texture_stage_state(device->wined3d_device, stage, l->state, value); wined3d_mutex_unlock(); diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index ea90e1a..2662f4e 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -1794,15 +1794,14 @@ static HRESULT WINAPI d3d9_device_GetSamplerState(IDirect3DDevice9Ex *iface, DWORD sampler, D3DSAMPLERSTATETYPE state, DWORD *value) { struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); - HRESULT hr; TRACE("iface %p, sampler %u, state %#x, value %p.\n", iface, sampler, state, value); wined3d_mutex_lock(); - hr = wined3d_device_get_sampler_state(device->wined3d_device, sampler, state, value); + *value = wined3d_device_get_sampler_state(device->wined3d_device, sampler, state); wined3d_mutex_unlock(); - return hr; + return D3D_OK; } static HRESULT WINAPI DECLSPEC_HOTPATCH d3d9_device_SetSamplerState(IDirect3DDevice9Ex *iface, diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index 908efa3..20b2510 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -2217,7 +2217,7 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, D3DRENDERSTATETYPE state, DWORD *value) { struct d3d_device *device = impl_from_IDirect3DDevice7(iface); - HRESULT hr; + HRESULT hr = D3D_OK; TRACE("iface %p, state %#x, value %p.\n", iface, state, value); @@ -2231,8 +2231,7 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, { enum wined3d_texture_filter_type tex_mag; - hr = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_MAG_FILTER, &tex_mag); - + tex_mag = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_MAG_FILTER); switch (tex_mag) { case WINED3D_TEXF_POINT: @@ -2253,16 +2252,8 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, enum wined3d_texture_filter_type tex_min; enum wined3d_texture_filter_type tex_mip; - hr = wined3d_device_get_sampler_state(device->wined3d_device, - 0, WINED3D_SAMP_MIN_FILTER, &tex_min); - if (FAILED(hr)) - { - wined3d_mutex_unlock(); - return hr; - } - hr = wined3d_device_get_sampler_state(device->wined3d_device, - 0, WINED3D_SAMP_MIP_FILTER, &tex_mip); - + tex_min = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_MIN_FILTER); + tex_mip = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_MIP_FILTER); switch (tex_min) { case WINED3D_TEXF_POINT: @@ -2311,12 +2302,10 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, case D3DRENDERSTATE_TEXTUREADDRESS: case D3DRENDERSTATE_TEXTUREADDRESSU: - hr = wined3d_device_get_sampler_state(device->wined3d_device, - 0, WINED3D_SAMP_ADDRESS_U, value); + *value = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_ADDRESS_U); break; case D3DRENDERSTATE_TEXTUREADDRESSV: - hr = wined3d_device_get_sampler_state(device->wined3d_device, - 0, WINED3D_SAMP_ADDRESS_V, value); + *value = wined3d_device_get_sampler_state(device->wined3d_device, 0, WINED3D_SAMP_ADDRESS_V); break; case D3DRENDERSTATE_BORDERCOLOR: @@ -2332,7 +2321,6 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, case D3DRENDERSTATE_ZBIAS: *value = wined3d_device_get_render_state(device->wined3d_device, WINED3D_RS_DEPTHBIAS); - hr = D3D_OK; break; default: @@ -2344,7 +2332,6 @@ static HRESULT d3d_device7_GetRenderState(IDirect3DDevice7 *iface, break; } *value = wined3d_device_get_render_state(device->wined3d_device, state); - hr = D3D_OK; } wined3d_mutex_unlock(); @@ -4584,8 +4571,8 @@ static HRESULT d3d_device7_GetTextureStageState(IDirect3DDevice7 *iface, DWORD stage, D3DTEXTURESTAGESTATETYPE state, DWORD *value) { struct d3d_device *device = impl_from_IDirect3DDevice7(iface); - HRESULT hr; const struct tss_lookup *l; + HRESULT hr = D3D_OK; TRACE("iface %p, stage %u, state %#x, value %p.\n", iface, stage, state, value); @@ -4605,7 +4592,7 @@ static HRESULT d3d_device7_GetTextureStageState(IDirect3DDevice7 *iface, if (l->sampler_state) { - hr = wined3d_device_get_sampler_state(device->wined3d_device, stage, l->state, value); + *value = wined3d_device_get_sampler_state(device->wined3d_device, stage, l->state); switch (state) { diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 596206c..69518b4 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2363,11 +2363,11 @@ void CDECL wined3d_device_set_sampler_state(struct wined3d_device *device, device_invalidate_state(device, STATE_SAMPLER(sampler_idx)); } -HRESULT CDECL wined3d_device_get_sampler_state(const struct wined3d_device *device, - UINT sampler_idx, enum wined3d_sampler_state state, DWORD *value) +DWORD CDECL wined3d_device_get_sampler_state(const struct wined3d_device *device, + UINT sampler_idx, enum wined3d_sampler_state state) { - TRACE("device %p, sampler_idx %u, state %s, value %p.\n", - device, sampler_idx, debug_d3dsamplerstate(state), value); + TRACE("device %p, sampler_idx %u, state %s.\n", + device, sampler_idx, debug_d3dsamplerstate(state)); if (sampler_idx >= WINED3DVERTEXTEXTURESAMPLER0 && sampler_idx <= WINED3DVERTEXTEXTURESAMPLER3) sampler_idx -= (WINED3DVERTEXTEXTURESAMPLER0 - MAX_FRAGMENT_SAMPLERS); @@ -2376,13 +2376,10 @@ HRESULT CDECL wined3d_device_get_sampler_state(const struct wined3d_device *devi / sizeof(*device->stateBlock->state.sampler_states)) { WARN("Invalid sampler %u.\n", sampler_idx); - return WINED3D_OK; /* Windows accepts overflowing this array ... we do not. */ + return 0; /* Windows accepts overflowing this array ... we do not. */ } - *value = device->stateBlock->state.sampler_states[sampler_idx][state]; - TRACE("Returning %#x.\n", *value); - - return WINED3D_OK; + return device->stateBlock->state.sampler_states[sampler_idx][state]; } HRESULT CDECL wined3d_device_set_scissor_rect(struct wined3d_device *device, const RECT *rect) diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index 7aea714..c50dd29 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -77,7 +77,7 @@ @ cdecl wined3d_device_get_raster_status(ptr long ptr) @ cdecl wined3d_device_get_render_state(ptr long) @ cdecl wined3d_device_get_render_target(ptr long ptr) -@ cdecl wined3d_device_get_sampler_state(ptr long long ptr) +@ cdecl wined3d_device_get_sampler_state(ptr long long) @ cdecl wined3d_device_get_scissor_rect(ptr ptr) @ cdecl wined3d_device_get_software_vertex_processing(ptr) @ cdecl wined3d_device_get_stream_source(ptr long ptr ptr ptr) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 57b6a1b..b44cc42 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2145,8 +2145,8 @@ HRESULT __cdecl wined3d_device_get_raster_status(const struct wined3d_device *de DWORD __cdecl wined3d_device_get_render_state(const struct wined3d_device *device, enum wined3d_render_state state); HRESULT __cdecl wined3d_device_get_render_target(const struct wined3d_device *device, UINT render_target_idx, struct wined3d_surface **render_target); -HRESULT __cdecl wined3d_device_get_sampler_state(const struct wined3d_device *device, - UINT sampler_idx, enum wined3d_sampler_state state, DWORD *value); +DWORD __cdecl wined3d_device_get_sampler_state(const struct wined3d_device *device, + UINT sampler_idx, enum wined3d_sampler_state state); HRESULT __cdecl wined3d_device_get_scissor_rect(const struct wined3d_device *device, RECT *rect); BOOL __cdecl wined3d_device_get_software_vertex_processing(const struct wined3d_device *device); HRESULT __cdecl wined3d_device_get_stream_source(const struct wined3d_device *device,

1 0

Henri Verbeet : d3d10: Use debugstr_a() on variable names in parse_fx10_object().
by Alexandre Julliard Sept. 19, 2012

Sept. 19, 2012

Module: wine Branch: master Commit: b0795aafd33aa0e1f4493bc682cb8ec04c8eb79f URL: http://source.winehq.org/git/wine.git/?a=commit;h=b0795aafd33aa0e1f4493bc68… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Sep 18 22:13:56 2012 +0200 d3d10: Use debugstr_a() on variable names in parse_fx10_object(). --- dlls/d3d10/effect.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3d10/effect.c b/dlls/d3d10/effect.c index 6d1337b..e2a4744 100644 --- a/dlls/d3d10/effect.c +++ b/dlls/d3d10/effect.c @@ -1297,7 +1297,7 @@ static HRESULT parse_fx10_object(struct d3d10_effect_object *o, const char **ptr case D3D10_EOO_PARSED_OBJECT: /* This is a local object, we've parsed in parse_fx10_local_object. */ - TRACE("Shader = %s.\n", data + offset); + TRACE("Variable name %s.\n", debugstr_a(data + offset)); o->data = e->lpVtbl->GetVariableByName(e, data + offset); hr = S_OK; @@ -1308,7 +1308,7 @@ static HRESULT parse_fx10_object(struct d3d10_effect_object *o, const char **ptr data_ptr = data + offset; read_dword(&data_ptr, &offset); read_dword(&data_ptr, &o->index); - TRACE("Shader = %s[%u].\n", data + offset, o->index); + TRACE("Variable name %s[%u].\n", debugstr_a(data + offset), o->index); o->data = e->lpVtbl->GetVariableByName(e, data + offset); hr = S_OK;

1 0