September 2012 - Wine-Commits

Rico Schüller : d3dx9: Move transpose matrix into set_matrix().
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 5b06a2d113bb096bdf1d04bb06f184b115ef7dff URL: http://source.winehq.org/git/wine.git/?a=commit;h=5b06a2d113bb096bdf1d04bb0… Author: Rico Schüller <kgbricola(a)web.de> Date: Fri Sep 14 10:56:20 2012 +0200 d3dx9: Move transpose matrix into set_matrix(). --- dlls/d3dx9_36/effect.c | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index a063358..0a70128 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -886,7 +886,7 @@ static void get_matrix(struct d3dx_parameter *param, D3DXMATRIX *matrix) } } -static void set_matrix(struct d3dx_parameter *param, CONST D3DXMATRIX *matrix) +static void set_matrix(struct d3dx_parameter *param, const D3DXMATRIX *matrix, BOOL transpose) { UINT i, k; @@ -894,7 +894,8 @@ static void set_matrix(struct d3dx_parameter *param, CONST D3DXMATRIX *matrix) { for (k = 0; k < param->columns; ++k) { - set_number((FLOAT *)param->data + i * param->columns + k, param->type, &matrix->u.m[i][k], D3DXPT_FLOAT); + set_number((FLOAT *)param->data + i * param->columns + k, param->type, + transpose ? &matrix->u.m[k][i] : &matrix->u.m[i][k], D3DXPT_FLOAT); } } } @@ -2178,7 +2179,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrix(ID3DXBaseEffect *iface, D3DX switch (param->class) { case D3DXPC_MATRIX_ROWS: - set_matrix(param, matrix); + set_matrix(param, matrix, FALSE); return D3D_OK; case D3DXPC_SCALAR: @@ -2250,7 +2251,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixArray(ID3DXBaseEffect *iface, case D3DXPC_MATRIX_ROWS: for (i = 0; i < count; ++i) { - set_matrix(get_parameter_struct(param->member_handles[i]), &matrix[i]); + set_matrix(get_parameter_struct(param->member_handles[i]), &matrix[i], FALSE); } return D3D_OK; @@ -2328,7 +2329,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixPointerArray(ID3DXBaseEffect case D3DXPC_MATRIX_ROWS: for (i = 0; i < count; ++i) { - set_matrix(get_parameter_struct(param->member_handles[i]), matrix[i]); + set_matrix(get_parameter_struct(param->member_handles[i]), matrix[i], FALSE); } return D3D_OK; @@ -2392,7 +2393,6 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTranspose(ID3DXBaseEffect *if { struct ID3DXBaseEffectImpl *This = impl_from_ID3DXBaseEffect(iface); struct d3dx_parameter *param = get_valid_parameter(This, parameter); - D3DXMATRIX m; TRACE("iface %p, parameter %p, matrix %p\n", This, parameter, matrix); @@ -2403,7 +2403,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTranspose(ID3DXBaseEffect *if switch (param->class) { case D3DXPC_MATRIX_ROWS: - set_matrix(param, D3DXMatrixTranspose(&m, matrix)); + set_matrix(param, matrix, TRUE); return D3D_OK; case D3DXPC_SCALAR: @@ -2466,7 +2466,6 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTransposeArray(ID3DXBaseEffec { struct ID3DXBaseEffectImpl *This = impl_from_ID3DXBaseEffect(iface); struct d3dx_parameter *param = get_valid_parameter(This, parameter); - D3DXMATRIX m; TRACE("iface %p, parameter %p, matrix %p, count %u\n", This, parameter, matrix, count); @@ -2481,7 +2480,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTransposeArray(ID3DXBaseEffec case D3DXPC_MATRIX_ROWS: for (i = 0; i < count; ++i) { - set_matrix(get_parameter_struct(param->member_handles[i]), D3DXMatrixTranspose(&m, &matrix[i])); + set_matrix(get_parameter_struct(param->member_handles[i]), &matrix[i], TRUE); } return D3D_OK; @@ -2550,7 +2549,6 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTransposePointerArray(ID3DXBa { struct ID3DXBaseEffectImpl *This = impl_from_ID3DXBaseEffect(iface); struct d3dx_parameter *param = get_valid_parameter(This, parameter); - D3DXMATRIX m; TRACE("iface %p, parameter %p, matrix %p, count %u\n", This, parameter, matrix, count); @@ -2563,7 +2561,7 @@ static HRESULT WINAPI ID3DXBaseEffectImpl_SetMatrixTransposePointerArray(ID3DXBa case D3DXPC_MATRIX_ROWS: for (i = 0; i < count; ++i) { - set_matrix(get_parameter_struct(param->member_handles[i]), D3DXMatrixTranspose(&m, matrix[i])); + set_matrix(get_parameter_struct(param->member_handles[i]), matrix[i], TRUE); } return D3D_OK;

1 0

Dmitry Timoshkov : windowscodecs: Add a bunch of tests for GIF Application Extension metadata reader.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 32a5a11b5e201c19ad6c482d22dac0832998e389 URL: http://source.winehq.org/git/wine.git/?a=commit;h=32a5a11b5e201c19ad6c482d2… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Sep 14 15:05:05 2012 +0900 windowscodecs: Add a bunch of tests for GIF Application Extension metadata reader. --- dlls/windowscodecs/tests/metadata.c | 73 +++++++++++++++++++++++++++++++++++ include/wincodecsdk.idl | 3 + 2 files changed, 76 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/tests/metadata.c b/dlls/windowscodecs/tests/metadata.c index 11db5cb..45ff717 100644 --- a/dlls/windowscodecs/tests/metadata.c +++ b/dlls/windowscodecs/tests/metadata.c @@ -1486,6 +1486,78 @@ static void test_metadata_GCE(void) IStream_Release(stream); } +static void test_metadata_APE(void) +{ + static const WCHAR APE_name[] = {'A','p','p','l','i','c','a','t','i','o','n',' ','E','x','t','e','n','s','i','o','n',' ','R','e','a','d','e','r',0}; + static const char APE_data[] = { 0x21,0xff,0x0b,'H','e','l','l','o',' ','W','o','r','l','d', + /*sub-block*/1,0x11, + /*sub-block*/2,0x22,0x33, + /*sub-block*/4,0x44,0x55,0x66,0x77, + /*terminator*/0 }; + static const struct test_data td[2] = + { + { VT_UI1|VT_VECTOR, 0, 11, { 'H','e','l','l','o',' ','W','o','r','l','d' }, NULL, { 'A','p','p','l','i','c','a','t','i','o','n',0 } }, + { VT_UI1|VT_VECTOR, 0, 10, { 1,0x11,2,0x22,0x33,4,0x44,0x55,0x66,0x77 }, NULL, { 'D','a','t','a',0 } } + }; + HRESULT hr; + IStream *stream; + IWICPersistStream *persist; + IWICMetadataReader *reader; + IWICMetadataHandlerInfo *info; + WCHAR name[64]; + UINT count, dummy; + GUID format; + CLSID id; + + hr = CoCreateInstance(&CLSID_WICAPEMetadataReader, NULL, CLSCTX_INPROC_SERVER, + &IID_IWICMetadataReader, (void **)&reader); +todo_wine + ok(hr == S_OK || broken(hr == E_NOINTERFACE || hr == REGDB_E_CLASSNOTREG) /* before Win7 */, + "CoCreateInstance error %#x\n", hr); + + stream = create_stream(APE_data, sizeof(APE_data)); + + if (SUCCEEDED(hr)) + { + hr = IUnknown_QueryInterface(reader, &IID_IWICPersistStream, (void **)&persist); + ok(hr == S_OK, "QueryInterface error %#x\n", hr); + + hr = IWICPersistStream_Load(persist, stream); + ok(hr == S_OK, "Load error %#x\n", hr); + + IWICPersistStream_Release(persist); + } + + if (SUCCEEDED(hr)) + { + hr = IWICMetadataReader_GetCount(reader, &count); + ok(hr == S_OK, "GetCount error %#x\n", hr); + ok(count == sizeof(td)/sizeof(td[0]), "unexpected count %u\n", count); + + compare_metadata(reader, td, count); + + hr = IWICMetadataReader_GetMetadataFormat(reader, &format); + ok(hr == S_OK, "GetMetadataFormat error %#x\n", hr); + ok(IsEqualGUID(&format, &GUID_MetadataFormatAPE), "wrong format %s\n", debugstr_guid(&format)); + + hr = IWICMetadataReader_GetMetadataHandlerInfo(reader, &info); + ok(hr == S_OK, "GetMetadataHandlerInfo error %#x\n", hr); + + hr = IWICMetadataHandlerInfo_GetCLSID(info, &id); + ok(hr == S_OK, "GetCLSID error %#x\n", hr); + ok(IsEqualGUID(&id, &CLSID_WICAPEMetadataReader), "wrong CLSID %s\n", debugstr_guid(&id)); + + hr = IWICMetadataHandlerInfo_GetFriendlyName(info, 64, name, &dummy); + ok(hr == S_OK, "GetFriendlyName error %#x\n", hr); + ok(lstrcmpW(name, APE_name) == 0, "wrong APE reader name %s\n", wine_dbgstr_w(name)); + + IWICMetadataHandlerInfo_Release(info); + IWICMetadataReader_Release(reader); + } + + IStream_Release(stream); +} + START_TEST(metadata) { CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); @@ -1500,6 +1572,7 @@ START_TEST(metadata) test_metadata_LSD(); test_metadata_IMD(); test_metadata_GCE(); + test_metadata_APE(); CoUninitialize(); } diff --git a/include/wincodecsdk.idl b/include/wincodecsdk.idl index 2a5b389..31333c5 100644 --- a/include/wincodecsdk.idl +++ b/include/wincodecsdk.idl @@ -46,6 +46,7 @@ cpp_quote("DEFINE_GUID(GUID_MetadataFormatXMPStruct, 0x22383cf1,0xed17,0x4e2e,0x cpp_quote("DEFINE_GUID(GUID_MetadataFormatIMD, 0xbd2bb086,0x4d52,0x48dd,0x96,0x77,0xdb,0x48,0x3e,0x85,0xae,0x8f);") cpp_quote("DEFINE_GUID(GUID_MetadataFormatLSD, 0xe256031e,0x6299,0x4929,0xb9,0x8d,0x5a,0xc8,0x84,0xaf,0xba,0x92);") cpp_quote("DEFINE_GUID(GUID_MetadataFormatGCE, 0x2a25cad8,0xdeeb,0x4c69,0xa7,0x88,0x0e,0xc2,0x26,0x6d,0xca,0xfd);") +cpp_quote("DEFINE_GUID(GUID_MetadataFormatAPE, 0x2e043dc2,0xc967,0x4e05,0x87,0x5e,0x61,0x8b,0xf6,0x7e,0x85,0xc3);") cpp_quote("DEFINE_GUID(CLSID_WICUnknownMetadataReader, 0x699745c2,0x5066,0x4b82,0xa8,0xe3,0xd4,0x04,0x78,0xdb,0xec,0x8c);") cpp_quote("DEFINE_GUID(CLSID_WICUnknownMetadataWriter, 0xa09cca86,0x27ba,0x4f39,0x90,0x53,0x12,0x1f,0xa4,0xdc,0x08,0xfc);") @@ -63,6 +64,8 @@ cpp_quote("DEFINE_GUID(CLSID_WICIMDMetadataReader, 0x7447a267,0x0015,0x42c8,0xa8 cpp_quote("DEFINE_GUID(CLSID_WICIMDMetadataWriter, 0x8c89071f,0x452e,0x4e95,0x96,0x82,0x9d,0x10,0x24,0x62,0x71,0x72);") cpp_quote("DEFINE_GUID(CLSID_WICGCEMetadataReader, 0xb92e345d,0xf52d,0x41f3,0xb5,0x62,0x08,0x1b,0xc7,0x72,0xe3,0xb9);") cpp_quote("DEFINE_GUID(CLSID_WICGCEMetadataWriter, 0xaf95dc76,0x16b2,0x47f4,0xb3,0xea,0x3c,0x31,0x79,0x66,0x93,0xe7);") +cpp_quote("DEFINE_GUID(CLSID_WICAPEMetadataReader, 0x1767b93a,0xb021,0x44ea,0x92,0x0f,0x86,0x3c,0x11,0xf4,0xf7,0x68);") +cpp_quote("DEFINE_GUID(CLSID_WICAPEMetadataWriter, 0xbd6edfca,0x2890,0x482f,0xb2,0x33,0x8d,0x73,0x39,0xa1,0xcf,0x8d);") typedef struct WICMetadataPattern { ULARGE_INTEGER Position;

1 0

Charles Davis : d3dxof: Don't release a garbage object pointer (Clang).
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: b8243b01b5461a029fde50a6dd5a15a5178836eb URL: http://source.winehq.org/git/wine.git/?a=commit;h=b8243b01b5461a029fde50a6d… Author: Charles Davis <cdavis5x(a)gmail.com> Date: Thu Sep 13 23:35:20 2012 -0600 d3dxof: Don't release a garbage object pointer (Clang). --- dlls/d3dxof/d3dxof.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3dxof/d3dxof.c b/dlls/d3dxof/d3dxof.c index 3ba92e2..02ed593 100644 --- a/dlls/d3dxof/d3dxof.c +++ b/dlls/d3dxof/d3dxof.c @@ -999,8 +999,8 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetNextDataObject(IDirectXFileE /* Check if there are templates defined before the object */ if (!parse_templates(&This->buf)) { - hr = DXFILEERR_BADVALUE; - goto error; + *ppDataObj = NULL; + return DXFILEERR_BADVALUE; } if (!This->buf.rem_bytes)

1 0

Alexandre Julliard : ddraw/tests: Allow the clip region to contain multiple rectangles.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 83cfd54f8509008a298623fa4cd4e45acf6b7927 URL: http://source.winehq.org/git/wine.git/?a=commit;h=83cfd54f8509008a298623fa4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 13 23:35:18 2012 +0200 ddraw/tests: Allow the clip region to contain multiple rectangles. --- dlls/ddraw/tests/ddraw4.c | 10 ++-------- dlls/ddraw/tests/ddraw7.c | 10 ++-------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 0bf0eea..a8332c7 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -665,7 +665,7 @@ static void test_coop_level_create_device_window(void) static void test_clipper_blt(void) { IDirectDrawSurface4 *src_surface, *dst_surface; - RECT client_rect, src_rect, *rect; + RECT client_rect, src_rect; IDirectDrawClipper *clipper; DDSURFACEDESC2 surface_desc; unsigned int i, j, x, y; @@ -731,18 +731,12 @@ static void test_clipper_blt(void) ok(SUCCEEDED(hr), "Failed to get clip list, hr %#x.\n", hr); ok(rgn_data->rdh.dwSize == sizeof(rgn_data->rdh), "Got unexpected structure size %#x.\n", rgn_data->rdh.dwSize); ok(rgn_data->rdh.iType == RDH_RECTANGLES, "Got unexpected type %#x.\n", rgn_data->rdh.iType); - ok(rgn_data->rdh.nCount == 1, "Got unexpected count %u.\n", rgn_data->rdh.nCount); - ok(rgn_data->rdh.nRgnSize == 16, "Got unexpected region size %u.\n", rgn_data->rdh.nRgnSize); + ok(rgn_data->rdh.nCount >= 1, "Got unexpected count %u.\n", rgn_data->rdh.nCount); ok(EqualRect(&rgn_data->rdh.rcBound, &client_rect), "Got unexpected bounding rect {%d, %d, %d, %d}, expected {%d, %d, %d, %d}.\n", rgn_data->rdh.rcBound.left, rgn_data->rdh.rcBound.top, rgn_data->rdh.rcBound.right, rgn_data->rdh.rcBound.bottom, client_rect.left, client_rect.top, client_rect.right, client_rect.bottom); - rect = (RECT *)&rgn_data->Buffer[0]; - ok(EqualRect(rect, &client_rect), - "Got unexpected clip rect {%d, %d, %d, %d}, expected {%d, %d, %d, %d}.\n", - rect->left, rect->top, rect->right, rect->bottom, - client_rect.left, client_rect.top, client_rect.right, client_rect.bottom); HeapFree(GetProcessHeap(), 0, rgn_data); r1 = CreateRectRgn(0, 0, 320, 240); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 4152f6b..37592f7 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -617,7 +617,7 @@ static void test_coop_level_create_device_window(void) static void test_clipper_blt(void) { IDirectDrawSurface7 *src_surface, *dst_surface; - RECT client_rect, src_rect, *rect; + RECT client_rect, src_rect; IDirectDrawClipper *clipper; DDSURFACEDESC2 surface_desc; unsigned int i, j, x, y; @@ -683,18 +683,12 @@ static void test_clipper_blt(void) ok(SUCCEEDED(hr), "Failed to get clip list, hr %#x.\n", hr); ok(rgn_data->rdh.dwSize == sizeof(rgn_data->rdh), "Got unexpected structure size %#x.\n", rgn_data->rdh.dwSize); ok(rgn_data->rdh.iType == RDH_RECTANGLES, "Got unexpected type %#x.\n", rgn_data->rdh.iType); - ok(rgn_data->rdh.nCount == 1, "Got unexpected count %u.\n", rgn_data->rdh.nCount); - ok(rgn_data->rdh.nRgnSize == 16, "Got unexpected region size %u.\n", rgn_data->rdh.nRgnSize); + ok(rgn_data->rdh.nCount >= 1, "Got unexpected count %u.\n", rgn_data->rdh.nCount); ok(EqualRect(&rgn_data->rdh.rcBound, &client_rect), "Got unexpected bounding rect {%d, %d, %d, %d}, expected {%d, %d, %d, %d}.\n", rgn_data->rdh.rcBound.left, rgn_data->rdh.rcBound.top, rgn_data->rdh.rcBound.right, rgn_data->rdh.rcBound.bottom, client_rect.left, client_rect.top, client_rect.right, client_rect.bottom); - rect = (RECT *)&rgn_data->Buffer[0]; - ok(EqualRect(rect, &client_rect), - "Got unexpected clip rect {%d, %d, %d, %d}, expected {%d, %d, %d, %d}.\n", - rect->left, rect->top, rect->right, rect->bottom, - client_rect.left, client_rect.top, client_rect.right, client_rect.bottom); HeapFree(GetProcessHeap(), 0, rgn_data); r1 = CreateRectRgn(0, 0, 320, 240);

1 0

Vincent Povirk : propsys: Add tests for PropVariantCompareEx.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 8191af07d83b190c791bb5d43e1c3b9791e9e657 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8191af07d83b190c791bb5d43… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Sep 13 15:21:15 2012 -0500 propsys: Add tests for PropVariantCompareEx. --- dlls/propsys/tests/propsys.c | 118 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 118 insertions(+), 0 deletions(-) diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c index 9641d05..92a6668 100644 --- a/dlls/propsys/tests/propsys.c +++ b/dlls/propsys/tests/propsys.c @@ -633,6 +633,123 @@ static void test_PropVariantToGUID(void) PropVariantClear(&propvar); } +static void test_PropVariantCompare(void) +{ + PROPVARIANT empty, null, emptyarray, i2_0, i2_2, i4_large, i4_largeneg, i4_2, str_2, str_02, str_b; + INT res; + static const WCHAR str_2W[] = {'2', 0}; + static const WCHAR str_02W[] = {'0', '2', 0}; + static const WCHAR str_bW[] = {'b', 0}; + SAFEARRAY emptysafearray; + + PropVariantInit(&empty); + PropVariantInit(&null); + PropVariantInit(&emptyarray); + PropVariantInit(&i2_0); + PropVariantInit(&i2_2); + PropVariantInit(&i4_large); + PropVariantInit(&i4_largeneg); + PropVariantInit(&i4_2); + PropVariantInit(&str_2); + PropVariantInit(&str_b); + + empty.vt = VT_EMPTY; + null.vt = VT_NULL; + emptyarray.vt = VT_ARRAY | VT_I4; + emptyarray.u.parray = &emptysafearray; + emptysafearray.cDims = 1; + emptysafearray.fFeatures = FADF_FIXEDSIZE; + emptysafearray.cbElements = 4; + emptysafearray.cLocks = 0; + emptysafearray.pvData = NULL; + emptysafearray.rgsabound[0].cElements = 0; + emptysafearray.rgsabound[0].lLbound = 0; + i2_0.vt = VT_I2; + i2_0.u.iVal = 0; + i2_2.vt = VT_I2; + i2_2.u.iVal = 2; + i4_large.vt = VT_I4; + i4_large.u.lVal = 65536; + i4_largeneg.vt = VT_I4; + i4_largeneg.u.lVal = -65536; + i4_2.vt = VT_I4; + i4_2.u.lVal = 2; + str_2.vt = VT_BSTR; + str_2.u.bstrVal = SysAllocString(str_2W); + str_02.vt = VT_BSTR; + str_02.u.bstrVal = SysAllocString(str_02W); + str_b.vt = VT_BSTR; + str_b.u.bstrVal = SysAllocString(str_bW); + + res = PropVariantCompareEx(&empty, &empty, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&empty, &null, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&null, &emptyarray, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&null, &i2_0, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_0, &null, 0, 0); + todo_wine ok(res == 1, "res=%i\n", res); + + res = PropVariantCompareEx(&null, &i2_0, 0, PVCF_TREATEMPTYASGREATERTHAN); + todo_wine ok(res == 1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_0, &null, 0, PVCF_TREATEMPTYASGREATERTHAN); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_2, &i2_0, 0, 0); + todo_wine ok(res == 1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_0, &i2_2, 0, 0); + ok(res == -1, "res=%i\n", res); + + /* Always return -1 if second value cannot be converted to first type */ + res = PropVariantCompareEx(&i2_0, &i4_large, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_0, &i4_largeneg, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i4_large, &i2_0, 0, 0); + todo_wine ok(res == 1, "res=%i\n", res); + + res = PropVariantCompareEx(&i4_largeneg, &i2_0, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_2, &i4_2, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_2, &str_2, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&i2_2, &str_02, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&str_2, &i2_2, 0, 0); + todo_wine ok(res == 0, "res=%i\n", res); + + res = PropVariantCompareEx(&str_02, &i2_2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&str_02, &str_2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&str_02, &str_b, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&i4_large, &str_b, 0, 0); + todo_wine ok(res == -5 /* ??? */, "res=%i\n", res); + + SysFreeString(str_2.u.bstrVal); + SysFreeString(str_02.u.bstrVal); + SysFreeString(str_b.u.bstrVal); +} + START_TEST(propsys) { test_PSStringFromPropertyKey(); @@ -641,4 +758,5 @@ START_TEST(propsys) test_InitPropVariantFromGUIDAsString(); test_InitPropVariantFromBuffer(); test_PropVariantToGUID(); + test_PropVariantCompare(); }

1 0

Vincent Povirk : propsys: Use integer conversion functions in PropVariantCompareEx.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 60dae84bc69ad357c803718170b0099a536a681b URL: http://source.winehq.org/git/wine.git/?a=commit;h=60dae84bc69ad357c80371817… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Sep 13 17:16:26 2012 -0500 propsys: Use integer conversion functions in PropVariantCompareEx. --- dlls/propsys/propvar.c | 72 ++++++++++++++++++++++++++++++++++++++++++ dlls/propsys/tests/propsys.c | 4 +- 2 files changed, 74 insertions(+), 2 deletions(-) diff --git a/dlls/propsys/propvar.c b/dlls/propsys/propvar.c index 28100a0..69b2e60 100644 --- a/dlls/propsys/propvar.c +++ b/dlls/propsys/propvar.c @@ -215,9 +215,81 @@ HRESULT WINAPI PropVariantToUInt64(REFPROPVARIANT propvarIn, ULONGLONG *ret) HRESULT WINAPI PropVariantChangeType(PROPVARIANT *ppropvarDest, REFPROPVARIANT propvarSrc, PROPVAR_CHANGE_FLAGS flags, VARTYPE vt) { + HRESULT hr; + FIXME("(%p, %p, %d, %d, %d): semi-stub!\n", ppropvarDest, propvarSrc, propvarSrc->vt, flags, vt); + switch (vt) + { + case VT_I2: + { + SHORT res; + hr = PropVariantToInt16(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_I2; + ppropvarDest->u.iVal = res; + } + return hr; + } + case VT_UI2: + { + USHORT res; + hr = PropVariantToUInt16(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_UI2; + ppropvarDest->u.uiVal = res; + } + return hr; + } + case VT_I4: + { + LONG res; + hr = PropVariantToInt32(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_I4; + ppropvarDest->u.lVal = res; + } + return hr; + } + case VT_UI4: + { + ULONG res; + hr = PropVariantToUInt32(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_UI4; + ppropvarDest->u.ulVal = res; + } + return hr; + } + case VT_I8: + { + LONGLONG res; + hr = PropVariantToInt64(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_I8; + ppropvarDest->u.hVal.QuadPart = res; + } + return hr; + } + case VT_UI8: + { + ULONGLONG res; + hr = PropVariantToUInt64(propvarSrc, &res); + if (SUCCEEDED(hr)) + { + ppropvarDest->vt = VT_UI8; + ppropvarDest->u.uhVal.QuadPart = res; + } + return hr; + } + } + switch (propvarSrc->vt) { case VT_FILETIME: diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c index c9df1c9..a18d6b1 100644 --- a/dlls/propsys/tests/propsys.c +++ b/dlls/propsys/tests/propsys.c @@ -716,13 +716,13 @@ static void test_PropVariantCompare(void) ok(res == -1, "res=%i\n", res); res = PropVariantCompareEx(&i4_large, &i2_0, 0, 0); - todo_wine ok(res == 1, "res=%i\n", res); + ok(res == 1, "res=%i\n", res); res = PropVariantCompareEx(&i4_largeneg, &i2_0, 0, 0); ok(res == -1, "res=%i\n", res); res = PropVariantCompareEx(&i2_2, &i4_2, 0, 0); - todo_wine ok(res == 0, "res=%i\n", res); + ok(res == 0, "res=%i\n", res); res = PropVariantCompareEx(&i2_2, &str_2, 0, 0); todo_wine ok(res == 0, "res=%i\n", res);

1 0

Vincent Povirk : propsys: Implement prop variant integer conversions with tests.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: c66b5ac4c3db0b6c4b43711db25d4d85b925dfeb URL: http://source.winehq.org/git/wine.git/?a=commit;h=c66b5ac4c3db0b6c4b43711db… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Sep 13 16:10:35 2012 -0500 propsys: Implement prop variant integer conversions with tests. --- dlls/propsys/propsys.spec | 12 ++-- dlls/propsys/propvar.c | 141 ++++++++++++++++++++++++++++++++++++++++++ dlls/propsys/tests/propsys.c | 126 +++++++++++++++++++++++++++++++++++++ include/propvarutil.h | 6 ++ 4 files changed, 279 insertions(+), 6 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c66b5ac4c3db0b6c4b437…

1 0

Vincent Povirk : propsys: Add basic implementation of PropVariantCompareEx.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 6d52262e5683ec89df6c4dc39d471bcc9a6ace88 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d52262e5683ec89df6c4dc39… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Sep 13 15:54:39 2012 -0500 propsys: Add basic implementation of PropVariantCompareEx. --- dlls/propsys/propvar.c | 97 +++++++++++++++++++++++++++++++++++++++++- dlls/propsys/tests/propsys.c | 15 ++++--- 2 files changed, 104 insertions(+), 8 deletions(-) diff --git a/dlls/propsys/propvar.c b/dlls/propsys/propvar.c index 0877801..bbfe8ca 100644 --- a/dlls/propsys/propvar.c +++ b/dlls/propsys/propvar.c @@ -284,10 +284,103 @@ HRESULT WINAPI VariantToGUID(const VARIANT *pvar, GUID *guid) } } +static int isemptyornull(const PROPVARIANT *propvar) +{ + if (propvar->vt == VT_EMPTY || propvar->vt == VT_NULL) + return 1; + if ((propvar->vt & VT_ARRAY) == VT_ARRAY) + { + int i; + for (i=0; i<propvar->u.parray->cDims; i++) + { + if (propvar->u.parray->rgsabound[i].cElements != 0) + break; + } + return i == propvar->u.parray->cDims; + } + /* FIXME: vectors, byrefs, errors? */ + return 0; +} + INT WINAPI PropVariantCompareEx(REFPROPVARIANT propvar1, REFPROPVARIANT propvar2, PROPVAR_COMPARE_UNIT unit, PROPVAR_COMPARE_FLAGS flags) { - FIXME("%p,%p,%x,%x\n", propvar1, propvar2, unit, flags); + const PROPVARIANT *propvar2_converted; + PROPVARIANT propvar2_static; + HRESULT hr; + INT res=-1; + + TRACE("%p,%p,%x,%x\n", propvar1, propvar2, unit, flags); + + if (isemptyornull(propvar1)) + { + if (isemptyornull(propvar2)) + return 0; + return (flags & PVCF_TREATEMPTYASGREATERTHAN) ? 1 : -1; + } + + if (isemptyornull(propvar2)) + return (flags & PVCF_TREATEMPTYASGREATERTHAN) ? -1 : 1; + + if (propvar1->vt != propvar2->vt) + { + hr = PropVariantChangeType(&propvar2_static, propvar2, 0, propvar1->vt); + + if (FAILED(hr)) + return -1; + + propvar2_converted = &propvar2_static; + } + else + propvar2_converted = propvar2; + +#define CMP_INT_VALUE(var) do { \ + if (propvar1->u.var > propvar2_converted->u.var) \ + res = 1; \ + else if (propvar1->u.var < propvar2_converted->u.var) \ + res = -1; \ + else \ + res = 0; \ + } while (0) + + switch (propvar1->vt) + { + case VT_I1: + CMP_INT_VALUE(cVal); + break; + case VT_UI1: + CMP_INT_VALUE(bVal); + break; + case VT_I2: + CMP_INT_VALUE(iVal); + break; + case VT_UI2: + CMP_INT_VALUE(uiVal); + break; + case VT_I4: + CMP_INT_VALUE(lVal); + break; + case VT_UI4: + CMP_INT_VALUE(uiVal); + break; + case VT_I8: + CMP_INT_VALUE(hVal.QuadPart); + break; + case VT_UI8: + CMP_INT_VALUE(uhVal.QuadPart); + break; + case VT_BSTR: + /* FIXME: Use string flags. */ + res = lstrcmpW(propvar1->u.bstrVal, propvar2->u.bstrVal); + break; + default: + FIXME("vartype %d not handled\n", propvar1->vt); + res = -1; + break; + } + + if (propvar2_converted == &propvar2_static) + PropVariantClear(&propvar2_static); - return -1; + return res; } diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c index 92a6668..789eee8 100644 --- a/dlls/propsys/tests/propsys.c +++ b/dlls/propsys/tests/propsys.c @@ -682,28 +682,28 @@ static void test_PropVariantCompare(void) str_b.u.bstrVal = SysAllocString(str_bW); res = PropVariantCompareEx(&empty, &empty, 0, 0); - todo_wine ok(res == 0, "res=%i\n", res); + ok(res == 0, "res=%i\n", res); res = PropVariantCompareEx(&empty, &null, 0, 0); - todo_wine ok(res == 0, "res=%i\n", res); + ok(res == 0, "res=%i\n", res); res = PropVariantCompareEx(&null, &emptyarray, 0, 0); - todo_wine ok(res == 0, "res=%i\n", res); + ok(res == 0, "res=%i\n", res); res = PropVariantCompareEx(&null, &i2_0, 0, 0); ok(res == -1, "res=%i\n", res); res = PropVariantCompareEx(&i2_0, &null, 0, 0); - todo_wine ok(res == 1, "res=%i\n", res); + ok(res == 1, "res=%i\n", res); res = PropVariantCompareEx(&null, &i2_0, 0, PVCF_TREATEMPTYASGREATERTHAN); - todo_wine ok(res == 1, "res=%i\n", res); + ok(res == 1, "res=%i\n", res); res = PropVariantCompareEx(&i2_0, &null, 0, PVCF_TREATEMPTYASGREATERTHAN); ok(res == -1, "res=%i\n", res); res = PropVariantCompareEx(&i2_2, &i2_0, 0, 0); - todo_wine ok(res == 1, "res=%i\n", res); + ok(res == 1, "res=%i\n", res); res = PropVariantCompareEx(&i2_0, &i2_2, 0, 0); ok(res == -1, "res=%i\n", res); @@ -742,6 +742,9 @@ static void test_PropVariantCompare(void) res = PropVariantCompareEx(&str_02, &str_b, 0, 0); ok(res == -1, "res=%i\n", res); + res = PropVariantCompareEx(&str_2, &str_02, 0, 0); + ok(res == 1, "res=%i\n", res); + res = PropVariantCompareEx(&i4_large, &str_b, 0, 0); todo_wine ok(res == -5 /* ??? */, "res=%i\n", res);

1 0

Vincent Povirk : propsys: Stub PropVariantCompareEx.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: 52d1db190884445bf7d1078ddb43b4a4e8c06c93 URL: http://source.winehq.org/git/wine.git/?a=commit;h=52d1db190884445bf7d1078dd… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Sep 13 14:33:11 2012 -0500 propsys: Stub PropVariantCompareEx. --- dlls/propsys/propsys.spec | 2 +- dlls/propsys/propvar.c | 8 ++++++++ include/propvarutil.h | 27 +++++++++++++++++++++++++++ 3 files changed, 36 insertions(+), 1 deletions(-) diff --git a/dlls/propsys/propsys.spec b/dlls/propsys/propsys.spec index 64d116c..fefc5f0 100644 --- a/dlls/propsys/propsys.spec +++ b/dlls/propsys/propsys.spec @@ -94,7 +94,7 @@ @ stdcall PSStringFromPropertyKey(ptr ptr long) @ stdcall PSUnregisterPropertySchema(wstr) @ stdcall PropVariantChangeType(ptr ptr long long) -@ stub PropVariantCompareEx +@ stdcall PropVariantCompareEx(ptr ptr long long) @ stub PropVariantGetBooleanElem @ stub PropVariantGetDoubleElem @ stub PropVariantGetElementCount diff --git a/dlls/propsys/propvar.c b/dlls/propsys/propvar.c index 4ea01d9..0877801 100644 --- a/dlls/propsys/propvar.c +++ b/dlls/propsys/propvar.c @@ -283,3 +283,11 @@ HRESULT WINAPI VariantToGUID(const VARIANT *pvar, GUID *guid) return E_NOTIMPL; } } + +INT WINAPI PropVariantCompareEx(REFPROPVARIANT propvar1, REFPROPVARIANT propvar2, + PROPVAR_COMPARE_UNIT unit, PROPVAR_COMPARE_FLAGS flags) +{ + FIXME("%p,%p,%x,%x\n", propvar1, propvar2, unit, flags); + + return -1; +} diff --git a/include/propvarutil.h b/include/propvarutil.h index 96265a5..94a80b4 100644 --- a/include/propvarutil.h +++ b/include/propvarutil.h @@ -34,6 +34,31 @@ enum tagPROPVAR_CHANGE_FLAGS typedef int PROPVAR_CHANGE_FLAGS; +enum tagPROPVAR_COMPARE_UNIT +{ + PVCU_DEFAULT = 0x00000000, + PVCU_SECOND = 0x00000001, + PVCU_MINUTE = 0x00000002, + PVCU_HOUR = 0x00000003, + PVCU_DAY = 0x00000004, + PVCU_MONTH = 0x00000005, + PVCU_YEAR = 0x00000006, +}; + +typedef int PROPVAR_COMPARE_UNIT; + +enum tagPROPVAR_COMPARE_FLAGS +{ + PVCF_DEFAULT = 0x00000000, + PVCF_TREATEMPTYASGREATERTHAN = 0x00000001, + PVCF_USESTRCMP = 0x00000002, + PVCF_USESTRCMPC = 0x00000004, + PVCF_USESTRCMPI = 0x00000008, + PVCF_USESTRCMPIC = 0x00000010, +}; + +typedef int PROPVAR_COMPARE_FLAGS; + HRESULT WINAPI PropVariantChangeType(PROPVARIANT *ppropvarDest, REFPROPVARIANT propvarSrc, PROPVAR_CHANGE_FLAGS flags, VARTYPE vt); HRESULT WINAPI InitPropVariantFromGUIDAsString(REFGUID guid, PROPVARIANT *ppropvar); @@ -42,6 +67,8 @@ HRESULT WINAPI InitPropVariantFromBuffer(const VOID *pv, UINT cb, PROPVARIANT *p HRESULT WINAPI InitVariantFromBuffer(const VOID *pv, UINT cb, VARIANT *pvar); HRESULT WINAPI PropVariantToGUID(const PROPVARIANT *ppropvar, GUID *guid); HRESULT WINAPI VariantToGUID(const VARIANT *pvar, GUID *guid); +INT WINAPI PropVariantCompareEx(REFPROPVARIANT propvar1, REFPROPVARIANT propvar2, + PROPVAR_COMPARE_UNIT uint, PROPVAR_COMPARE_FLAGS flags); #ifdef __cplusplus

1 0

Alexandre Julliard : mountmgr: Support udisks2 versions that store the uuid as an array.
by Alexandre Julliard Sept. 14, 2012

Sept. 14, 2012

Module: wine Branch: master Commit: ed8d665f8c04ee70fdc8bb76967d2ad3526bc691 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ed8d665f8c04ee70fdc8bb769… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Sep 13 22:37:00 2012 +0200 mountmgr: Support udisks2 versions that store the uuid as an array. --- dlls/mountmgr.sys/dbus.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/mountmgr.sys/dbus.c b/dlls/mountmgr.sys/dbus.c index ea0341a..0384c29 100644 --- a/dlls/mountmgr.sys/dbus.c +++ b/dlls/mountmgr.sys/dbus.c @@ -446,8 +446,11 @@ static void udisks2_add_device( const char *udi, DBusMessageIter *dict, DBusMess } else if (!strcmp( name, "IdUUID" )) { - char *uuid_str; - p_dbus_message_iter_get_basic( &variant, &uuid_str ); + const char *uuid_str; + if (p_dbus_message_iter_get_arg_type( &variant ) == DBUS_TYPE_ARRAY) + uuid_str = udisks2_string_from_array( &variant ); + else + p_dbus_message_iter_get_basic( &variant, &uuid_str ); guid_ptr = parse_uuid( &guid, uuid_str ); } }

1 0