January 2013 - Wine-Commits

Stefan Dösinger : ddraw/tests: Add viewport handling tests.
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Module: wine Branch: master Commit: ab8276fe9142244d15d146e25ecea0d319313b8e URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab8276fe9142244d15d146e25… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Jan 26 13:39:49 2013 +0100 ddraw/tests: Add viewport handling tests. --- dlls/ddraw/tests/ddraw1.c | 51 +++++++++++++++--- dlls/ddraw/tests/ddraw2.c | 109 ++++++++++++++++++++++++++++++++++++++- dlls/ddraw/tests/ddraw4.c | 123 +++++++++++++++++++++++++++++++++++++++------ 3 files changed, 256 insertions(+), 27 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=ab8276fe9142244d15d14…

1 0

Stefan Dösinger : ddraw: Don' t check for NULL in GetCurrentViewport.
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Module: wine Branch: master Commit: 57ab0363f5252f7d3238d3602762410fc32dde1c URL: http://source.winehq.org/git/wine.git/?a=commit;h=57ab0363f5252f7d3238d3602… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Jan 26 13:39:48 2013 +0100 ddraw: Don't check for NULL in GetCurrentViewport. --- dlls/ddraw/device.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index eca9d69..6659735 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -1786,9 +1786,6 @@ static HRESULT WINAPI d3d_device3_GetCurrentViewport(IDirect3DDevice3 *iface, ID TRACE("iface %p, viewport %p.\n", iface, viewport); - if (!viewport) - return DDERR_INVALIDPARAMS; - wined3d_mutex_lock(); if (!device->current_viewport) {

1 0

Stefan Dösinger : ddraw: Unset the viewport if the current vp is deleted.
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Module: wine Branch: master Commit: 06ff1c710e3984f9aabbdeae3e066de1befce3d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=06ff1c710e3984f9aabbdeae3… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Jan 26 13:39:47 2013 +0100 ddraw: Unset the viewport if the current vp is deleted. --- dlls/ddraw/device.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index ace6a12..eca9d69 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -833,6 +833,13 @@ static HRESULT WINAPI d3d_device3_DeleteViewport(IDirect3DDevice3 *iface, IDirec return DDERR_INVALIDPARAMS; } + if (device->current_viewport == vp) + { + TRACE("Deleting current viewport, unsetting and releasing\n"); + IDirect3DViewport3_Release(viewport); + device->current_viewport = NULL; + } + vp->active_device = NULL; list_remove(&vp->entry);

1 0

Stefan Dösinger : ddraw: Check for NULL pointers in DeleteViewport.
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Module: wine Branch: master Commit: 8e6e420a9d3fe292f019a2f215941ca7836887f8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8e6e420a9d3fe292f019a2f21… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Jan 26 13:39:44 2013 +0100 ddraw: Check for NULL pointers in DeleteViewport. --- dlls/ddraw/device.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index 8b4e1e4..92828aa 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -817,6 +817,12 @@ static HRESULT WINAPI d3d_device3_DeleteViewport(IDirect3DDevice3 *iface, IDirec TRACE("iface %p, viewport %p.\n", iface, viewport); + if (!vp) + { + WARN("NULL viewport, returning DDERR_INVALIDPARAMS\n"); + return DDERR_INVALIDPARAMS; + } + wined3d_mutex_lock(); if (vp->active_device != device) @@ -841,7 +847,8 @@ static HRESULT WINAPI d3d_device2_DeleteViewport(IDirect3DDevice2 *iface, IDirec TRACE("iface %p, viewport %p.\n", iface, viewport); - return d3d_device3_DeleteViewport(&device->IDirect3DDevice3_iface, &vp->IDirect3DViewport3_iface); + return d3d_device3_DeleteViewport(&device->IDirect3DDevice3_iface, + vp ? &vp->IDirect3DViewport3_iface : NULL); } static HRESULT WINAPI d3d_device1_DeleteViewport(IDirect3DDevice *iface, IDirect3DViewport *viewport) @@ -851,7 +858,8 @@ static HRESULT WINAPI d3d_device1_DeleteViewport(IDirect3DDevice *iface, IDirect TRACE("iface %p, viewport %p.\n", iface, viewport); - return d3d_device3_DeleteViewport(&device->IDirect3DDevice3_iface, &vp->IDirect3DViewport3_iface); + return d3d_device3_DeleteViewport(&device->IDirect3DDevice3_iface, + vp ? &vp->IDirect3DViewport3_iface : NULL); } /*****************************************************************************

1 0

Stefan Dösinger : ddraw: Delete viewports when destroying the device.
by Alexandre Julliard Jan. 29, 2013

Jan. 29, 2013

Module: wine Branch: master Commit: b822c259fd223a9def37b8799730548a38397a60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b822c259fd223a9def37b8799… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Sat Jan 26 13:39:43 2013 +0100 ddraw: Delete viewports when destroying the device. --- dlls/ddraw/device.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c index c604c6a..8b4e1e4 100644 --- a/dlls/ddraw/device.c +++ b/dlls/ddraw/device.c @@ -233,6 +233,7 @@ static ULONG WINAPI d3d_device_inner_Release(IUnknown *iface) if (!ref) { DWORD i; + struct list *vp_entry, *vp_entry2; wined3d_mutex_lock(); @@ -304,6 +305,12 @@ static ULONG WINAPI d3d_device_inner_Release(IUnknown *iface) ddraw_handle_table_destroy(&This->handle_table); + LIST_FOR_EACH_SAFE(vp_entry, vp_entry2, &This->viewport_list) + { + struct d3d_viewport *vp = LIST_ENTRY(vp_entry, struct d3d_viewport, entry); + IDirect3DDevice3_DeleteViewport(&This->IDirect3DDevice3_iface, &vp->IDirect3DViewport3_iface); + } + TRACE("Releasing target %p.\n", This->target); /* Release the render target. */ if (This->version != 1)

1 0

Jacek Caban : wininet: Moved WORKREQ_HTTPREADFILEEX out of WORKREQUEST.
by Alexandre Julliard Jan. 28, 2013

Jan. 28, 2013

Module: wine Branch: master Commit: 023abdacdbab39936c2dc57fb1b560dcb4961e8a URL: http://source.winehq.org/git/wine.git/?a=commit;h=023abdacdbab39936c2dc57fb… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jan 28 11:23:58 2013 +0100 wininet: Moved WORKREQ_HTTPREADFILEEX out of WORKREQUEST. --- dlls/wininet/http.c | 28 +++++++++++++++++----------- dlls/wininet/internet.h | 8 -------- 2 files changed, 17 insertions(+), 19 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index a3ca123..5ec4089 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -2877,16 +2877,22 @@ static DWORD HTTPREQ_ReadFile(object_header_t *hdr, void *buffer, DWORD size, DW return res; } -static void AsyncReadFileExProc(WORKREQUEST *workRequest) +typedef struct { + task_header_t hdr; + void *buf; + DWORD size; + DWORD *ret_read; +} read_file_ex_task_t; + +static void AsyncReadFileExProc(task_header_t *hdr) { - struct WORKREQ_HTTPREADFILEEX const *data = &workRequest->u.HttpReadFileEx; - http_request_t *req = (http_request_t*)workRequest->hdr; + read_file_ex_task_t *task = (read_file_ex_task_t*)hdr; + http_request_t *req = (http_request_t*)task->hdr.hdr; DWORD res; - TRACE("INTERNETREADFILEEXW %p\n", workRequest->hdr); - - res = HTTPREQ_Read(req, data->buf, data->size, data->ret_read, TRUE); + TRACE("INTERNETREADFILEEXW %p\n", task->hdr.hdr); + res = HTTPREQ_Read(req, task->buf, task->size, task->ret_read, TRUE); send_request_complete(req, res == ERROR_SUCCESS, res); } @@ -2904,7 +2910,7 @@ static DWORD HTTPREQ_ReadFileEx(object_header_t *hdr, void *buf, DWORD size, DWO if (hdr->dwFlags & INTERNET_FLAG_ASYNC) { - WORKREQUEST *task; + read_file_ex_task_t *task; if (TryEnterCriticalSection( &req->read_section )) { @@ -2918,11 +2924,11 @@ static DWORD HTTPREQ_ReadFileEx(object_header_t *hdr, void *buf, DWORD size, DWO } task = alloc_async_task(&req->hdr, AsyncReadFileExProc, sizeof(*task)); - task->u.HttpReadFileEx.buf = buf; - task->u.HttpReadFileEx.size = size; - task->u.HttpReadFileEx.ret_read = ret_read; + task->buf = buf; + task->size = size; + task->ret_read = ret_read; - INTERNET_AsyncCall(task); + INTERNET_AsyncCall(&task->hdr); return ERROR_IO_PENDING; } diff --git a/dlls/wininet/internet.h b/dlls/wininet/internet.h index 4b39070..a9c52e0 100644 --- a/dlls/wininet/internet.h +++ b/dlls/wininet/internet.h @@ -441,13 +441,6 @@ struct WORKREQ_SENDCALLBACK DWORD dwStatusInfoLength; }; -struct WORKREQ_HTTPREADFILEEX -{ - void *buf; - DWORD size; - DWORD *ret_read; -}; - typedef struct WORKREQ task_header_t; typedef void (*async_task_proc_t)(task_header_t*); @@ -470,7 +463,6 @@ typedef struct WORKREQ struct WORKREQ_FTPFINDNEXTW FtpFindNextW; struct WORKREQ_HTTPENDREQUESTW HttpEndRequestW; struct WORKREQ_SENDCALLBACK SendCallback; - struct WORKREQ_HTTPREADFILEEX HttpReadFileEx; } u; } WORKREQUEST, *LPWORKREQUEST;

1 0

Alexandre Julliard : ntdll: Use a monotonic time counter to implement NtQueryPerformanceCounter.
by Alexandre Julliard Jan. 28, 2013

Jan. 28, 2013

Module: wine Branch: master Commit: 25598513dc98fd27d91c0f7c4460b733155c6bf1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=25598513dc98fd27d91c0f7c4… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jan 25 17:27:52 2013 +0100 ntdll: Use a monotonic time counter to implement NtQueryPerformanceCounter. --- configure | 64 ++++++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 7 +++++ dlls/ntdll/Makefile.in | 2 +- dlls/ntdll/time.c | 40 +++++++++++++++++------------ include/config.h.in | 3 ++ 5 files changed, 98 insertions(+), 18 deletions(-) diff --git a/configure b/configure index ccd0283..2e7c008 100755 --- a/configure +++ b/configure @@ -628,6 +628,7 @@ PORCFLAGS LINGUAS ALL_TEST_RESOURCES LDAPLIBS +LIBRT LIBPOLL LIBDL EXTRA_BINARIES @@ -13524,6 +13525,69 @@ fi done +ac_save_LIBS=$LIBS +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing clock_gettime" >&5 +$as_echo_n "checking for library containing clock_gettime... " >&6; } +if ${ac_cv_search_clock_gettime+:} false; then : + $as_echo_n "(cached) " >&6 +else + ac_func_search_save_LIBS=$LIBS +cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ + +/* Override any GCC internal prototype to avoid an error. + Use char because int might match the return type of a GCC + builtin and then its argument prototype would still apply. */ +#ifdef __cplusplus +extern "C" +#endif +char clock_gettime (); +int +main () +{ +return clock_gettime (); + ; + return 0; +} +_ACEOF +for ac_lib in '' rt; do + if test -z "$ac_lib"; then + ac_res="none required" + else + ac_res=-l$ac_lib + LIBS="-l$ac_lib $ac_func_search_save_LIBS" + fi + if ac_fn_c_try_link "$LINENO"; then : + ac_cv_search_clock_gettime=$ac_res +fi +rm -f core conftest.err conftest.$ac_objext \ + conftest$ac_exeext + if ${ac_cv_search_clock_gettime+:} false; then : + break +fi +done +if ${ac_cv_search_clock_gettime+:} false; then : + +else + ac_cv_search_clock_gettime=no +fi +rm conftest.$ac_ext +LIBS=$ac_func_search_save_LIBS +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_search_clock_gettime" >&5 +$as_echo "$ac_cv_search_clock_gettime" >&6; } +ac_res=$ac_cv_search_clock_gettime +if test "$ac_res" != no; then : + test "$ac_res" = "none required" || LIBS="$ac_res $LIBS" + +$as_echo "#define HAVE_CLOCK_GETTIME 1" >>confdefs.h + + test "$ac_res" = "none required" || LIBRT="$ac_res" + +fi + +LIBS=$ac_save_LIBS + LDAPLIBS="" if test "$ac_cv_header_ldap_h" = "yes" -a "$ac_cv_header_lber_h" = "yes" diff --git a/configure.ac b/configure.ac index dde896f..c93cd08 100644 --- a/configure.ac +++ b/configure.ac @@ -2080,6 +2080,13 @@ AC_CHECK_FUNCS(\ socketpair \ ) +dnl Check for clock_gettime which may be in -lrt +ac_save_LIBS=$LIBS +AC_SEARCH_LIBS(clock_gettime, rt, + [AC_DEFINE(HAVE_CLOCK_GETTIME, 1, [Define to 1 if you have the `clock_gettime' function.]) + test "$ac_res" = "none required" || AC_SUBST(LIBRT,"$ac_res")]) +LIBS=$ac_save_LIBS + dnl **** Check for OpenLDAP *** AC_SUBST(LDAPLIBS,"") if test "$ac_cv_header_ldap_h" = "yes" -a "$ac_cv_header_lber_h" = "yes" diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in index cd4fe0a..c961f70 100644 --- a/dlls/ntdll/Makefile.in +++ b/dlls/ntdll/Makefile.in @@ -2,7 +2,7 @@ EXTRADEFS = -D_NTSYSTEM_ MODULE = ntdll.dll IMPORTLIB = ntdll IMPORTS = winecrt0 -EXTRALIBS = @IOKITLIB@ @LIBPTHREAD@ +EXTRALIBS = @IOKITLIB@ @LIBRT@ @LIBPTHREAD@ EXTRADLLFLAGS = -nodefaultlibs -Wl,--image-base,0x7bc00000 C_SRCS = \ diff --git a/dlls/ntdll/time.c b/dlls/ntdll/time.c index a8b1376..b9d3f03 100644 --- a/dlls/ntdll/time.c +++ b/dlls/ntdll/time.c @@ -85,8 +85,6 @@ static RTL_CRITICAL_SECTION TIME_tz_section = { &critsect_debug, -1, 0, 0, 0, 0 /* 1601 to 1980 is 379 years plus 91 leap days */ #define SECS_1601_TO_1980 ((379 * 365 + 91) * (ULONGLONG)SECSPERDAY) #define TICKS_1601_TO_1980 (SECS_1601_TO_1980 * TICKSPERSEC) -/* max ticks that can be represented as Unix time */ -#define TICKS_1601_TO_UNIX_MAX ((SECS_1601_TO_1970 + INT_MAX) * TICKSPERSEC) static const int MonthLengths[2][MONSPERYEAR] = @@ -100,6 +98,25 @@ static inline int IsLeapYear(int Year) return Year % 4 == 0 && (Year % 100 != 0 || Year % 400 == 0) ? 1 : 0; } +/* return a monotonic time counter, in Win32 ticks */ +static ULONGLONG monotonic_counter(void) +{ + struct timeval now; + +#ifdef HAVE_CLOCK_GETTIME + struct timespec ts; +#ifdef CLOCK_MONOTONIC_RAW + if (!clock_gettime( CLOCK_MONOTONIC_RAW, &ts )) + return ts.tv_sec * (ULONGLONG)TICKSPERSEC + ts.tv_nsec / 100; +#endif + if (!clock_gettime( CLOCK_MONOTONIC, &ts )) + return ts.tv_sec * (ULONGLONG)TICKSPERSEC + ts.tv_nsec / 100; +#endif + + gettimeofday( &now, 0 ); + return now.tv_sec * (ULONGLONG)TICKSPERSEC + now.tv_usec * 10 + TICKS_1601_TO_1970 - server_start_time; +} + /****************************************************************************** * RtlTimeToTimeFields [NTDLL.@] * @@ -450,24 +467,13 @@ NTSTATUS WINAPI NtQuerySystemTime( PLARGE_INTEGER Time ) /****************************************************************************** * NtQueryPerformanceCounter [NTDLL.@] - * - * Note: Windows uses a timer clocked at a multiple of 1193182 Hz. There is a - * good number of applications that crash when the returned frequency is either - * lower or higher than what Windows gives. Also too high counter values are - * reported to give problems. */ -NTSTATUS WINAPI NtQueryPerformanceCounter( PLARGE_INTEGER Counter, PLARGE_INTEGER Frequency ) +NTSTATUS WINAPI NtQueryPerformanceCounter( LARGE_INTEGER *counter, LARGE_INTEGER *frequency ) { - LARGE_INTEGER now; - - if (!Counter) return STATUS_ACCESS_VIOLATION; + if (!counter) return STATUS_ACCESS_VIOLATION; - /* convert a counter that increments at a rate of 10 MHz - * to one of 1.193182 MHz, with some care for arithmetic - * overflow and good accuracy (21/176 = 0.11931818) */ - NtQuerySystemTime( &now ); - Counter->QuadPart = ((now.QuadPart - server_start_time) * 21) / 176; - if (Frequency) Frequency->QuadPart = 1193182; + counter->QuadPart = monotonic_counter(); + if (frequency) frequency->QuadPart = TICKSPERSEC; return STATUS_SUCCESS; } diff --git a/include/config.h.in b/include/config.h.in index 9a7d109..1a5652c 100644 --- a/include/config.h.in +++ b/include/config.h.in @@ -55,6 +55,9 @@ /* Define to 1 if you have the `chsize' function. */ #undef HAVE_CHSIZE +/* Define to 1 if you have the `clock_gettime' function. */ +#undef HAVE_CLOCK_GETTIME + /* Define to 1 if you have the <CL/cl.h> header file. */ #undef HAVE_CL_CL_H

1 0

Gerald Pfeifer : winex11: Push down variable attrib down in create_gl_drawable.
by Alexandre Julliard Jan. 28, 2013

Jan. 28, 2013

Module: wine Branch: master Commit: e835f034fb1eb59ec6fe16e8ff05feccc2a656bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=e835f034fb1eb59ec6fe16e8f… Author: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sat Jan 26 02:07:13 2013 +0100 winex11: Push down variable attrib down in create_gl_drawable. --- dlls/winex11.drv/opengl.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index dded333..ee62402 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -1222,8 +1222,6 @@ static void free_gl_drawable( struct gl_drawable *gl ) */ static BOOL create_gl_drawable( HWND hwnd, HWND parent, struct gl_drawable *gl ) { - XSetWindowAttributes attrib; - gl->drawable = 0; if (GetAncestor( hwnd, GA_PARENT ) == GetDesktopWindow()) /* top-level window */ @@ -1241,6 +1239,7 @@ static BOOL create_gl_drawable( HWND hwnd, HWND parent, struct gl_drawable *gl ) else if(usexcomposite) { static Window dummy_parent; + XSetWindowAttributes attrib; attrib.override_redirect = True; if (!dummy_parent)

1 0

Jacek Caban : wininet: Moved WORKREQ_INTERNETOPENURLW out of WORKREQUEST.
by Alexandre Julliard Jan. 28, 2013

Jan. 28, 2013

Module: wine Branch: master Commit: df749512579d4810c89516fc5028dd2323b9883d URL: http://source.winehq.org/git/wine.git/?a=commit;h=df749512579d4810c89516fc5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jan 28 11:23:45 2013 +0100 wininet: Moved WORKREQ_INTERNETOPENURLW out of WORKREQUEST. --- dlls/wininet/internet.c | 42 ++++++++++++++++++++++++------------------ dlls/wininet/internet.h | 11 ----------- 2 files changed, 24 insertions(+), 29 deletions(-) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 1db1d32..dff24d9 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -3497,17 +3497,25 @@ static HINTERNET INTERNET_InternetOpenUrlW(appinfo_t *hIC, LPCWSTR lpszUrl, * RETURNS * handle of connection or NULL on failure */ -static void AsyncInternetOpenUrlProc(WORKREQUEST *workRequest) +typedef struct { + task_header_t hdr; + WCHAR *url; + WCHAR *headers; + DWORD headers_len; + DWORD flags; + DWORD_PTR context; +} open_url_task_t; + +static void AsyncInternetOpenUrlProc(task_header_t *hdr) { - struct WORKREQ_INTERNETOPENURLW const *req = &workRequest->u.InternetOpenUrlW; - appinfo_t *hIC = (appinfo_t*) workRequest->hdr; + open_url_task_t *task = (open_url_task_t*)hdr; - TRACE("%p\n", hIC); + TRACE("%p\n", task->hdr.hdr); - INTERNET_InternetOpenUrlW(hIC, req->lpszUrl, - req->lpszHeaders, req->dwHeadersLength, req->dwFlags, req->dwContext); - heap_free(req->lpszUrl); - heap_free(req->lpszHeaders); + INTERNET_InternetOpenUrlW((appinfo_t*)task->hdr.hdr, task->url, task->headers, + task->headers_len, task->flags, task->context); + heap_free(task->url); + heap_free(task->headers); } HINTERNET WINAPI InternetOpenUrlW(HINTERNET hInternet, LPCWSTR lpszUrl, @@ -3536,19 +3544,17 @@ HINTERNET WINAPI InternetOpenUrlW(HINTERNET hInternet, LPCWSTR lpszUrl, } if (hIC->hdr.dwFlags & INTERNET_FLAG_ASYNC) { - WORKREQUEST *task; - struct WORKREQ_INTERNETOPENURLW *req; + open_url_task_t *task; task = alloc_async_task(&hIC->hdr, AsyncInternetOpenUrlProc, sizeof(*task)); - req = &task->u.InternetOpenUrlW; - req->lpszUrl = heap_strdupW(lpszUrl); - req->lpszHeaders = heap_strdupW(lpszHeaders); - req->dwHeadersLength = dwHeadersLength; - req->dwFlags = dwFlags; - req->dwContext = dwContext; + task->url = heap_strdupW(lpszUrl); + task->headers = heap_strdupW(lpszHeaders); + task->headers_len = dwHeadersLength; + task->flags = dwFlags; + task->context = dwContext; - INTERNET_AsyncCall(task); - SetLastError(ERROR_IO_PENDING); + INTERNET_AsyncCall(&task->hdr); + SetLastError(ERROR_IO_PENDING); } else { ret = INTERNET_InternetOpenUrlW(hIC, lpszUrl, lpszHeaders, dwHeadersLength, dwFlags, dwContext); } diff --git a/dlls/wininet/internet.h b/dlls/wininet/internet.h index 9e66dad..4b39070 100644 --- a/dlls/wininet/internet.h +++ b/dlls/wininet/internet.h @@ -441,16 +441,6 @@ struct WORKREQ_SENDCALLBACK DWORD dwStatusInfoLength; }; -struct WORKREQ_INTERNETOPENURLW -{ - HINTERNET hInternet; - LPWSTR lpszUrl; - LPWSTR lpszHeaders; - DWORD dwHeadersLength; - DWORD dwFlags; - DWORD_PTR dwContext; -}; - struct WORKREQ_HTTPREADFILEEX { void *buf; @@ -480,7 +470,6 @@ typedef struct WORKREQ struct WORKREQ_FTPFINDNEXTW FtpFindNextW; struct WORKREQ_HTTPENDREQUESTW HttpEndRequestW; struct WORKREQ_SENDCALLBACK SendCallback; - struct WORKREQ_INTERNETOPENURLW InternetOpenUrlW; struct WORKREQ_HTTPREADFILEEX HttpReadFileEx; } u; } WORKREQUEST, *LPWORKREQUEST;

1 0

Jacek Caban : wininet: Moved WORKREQUEST allocation to INTERNET_AsyncCall callers.
by Alexandre Julliard Jan. 28, 2013

Jan. 28, 2013

Module: wine Branch: master Commit: 63e6a4b2e102841006fd376e5ee198a415597a49 URL: http://source.winehq.org/git/wine.git/?a=commit;h=63e6a4b2e102841006fd376e5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Jan 28 11:23:03 2013 +0100 wininet: Moved WORKREQUEST allocation to INTERNET_AsyncCall callers. --- dlls/wininet/ftp.c | 108 ++++++++++++++++++++-------------------------- dlls/wininet/http.c | 57 ++++++++++--------------- dlls/wininet/internet.c | 46 ++++++++++---------- dlls/wininet/internet.h | 8 +++- dlls/wininet/utility.c | 9 ++-- 5 files changed, 102 insertions(+), 126 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=63e6a4b2e102841006fd3…

1 0