November 2013 - Wine-Commits

Rico Schüller : d3dx9/tests: Fix variable names.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: c1a0fbd146d868bcd3286b3cdd29f514b6e239e0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1a0fbd146d868bcd3286b3cd… Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Nov 10 20:08:24 2013 +0100 d3dx9/tests: Fix variable names. --- dlls/d3dx9_36/tests/shader.c | 54 +++++++++++++++++++++--------------------- 1 files changed, 27 insertions(+), 27 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c1a0fbd146d868bcd3286…

1 0

Qian Hong : server: Fixed winstation object leak in open_input_desktop.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: ca4b3f0f73605082a77a427b2d94a1e23bc47ca3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ca4b3f0f73605082a77a427b2… Author: Qian Hong <qhong(a)codeweavers.com> Date: Sat Nov 9 17:17:11 2013 +0800 server: Fixed winstation object leak in open_input_desktop. --- server/winstation.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/server/winstation.c b/server/winstation.c index 2eaffb0..08389bb 100644 --- a/server/winstation.c +++ b/server/winstation.c @@ -563,6 +563,7 @@ DECL_HANDLER(open_input_desktop) if (!(winstation->flags & WSF_VISIBLE)) { set_error( STATUS_ILLEGAL_FUNCTION ); + release_object( winstation ); return; }

1 0

André Hentschel : dinput8/tests: Enable compilation with -D__WINESRC__.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: 7ddb8e25bbe1d4c1a36272c0b4c4bd9adcca5900 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ddb8e25bbe1d4c1a36272c0b… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Nov 8 20:49:48 2013 +0100 dinput8/tests: Enable compilation with -D__WINESRC__. --- dlls/dinput8/tests/Makefile.in | 1 - dlls/dinput8/tests/device.c | 54 ++++++++++++++------------------------- dlls/dinput8/tests/dinput.c | 10 +++--- 3 files changed, 25 insertions(+), 40 deletions(-) diff --git a/dlls/dinput8/tests/Makefile.in b/dlls/dinput8/tests/Makefile.in index 9770842..fe87118 100644 --- a/dlls/dinput8/tests/Makefile.in +++ b/dlls/dinput8/tests/Makefile.in @@ -1,6 +1,5 @@ TESTDLL = dinput8.dll IMPORTS = dinput8 ole32 user32 advapi32 -EXTRADEFS = -U__WINESRC__ -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -DWIDL_C_INLINE_WRAPPERS C_SRCS = \ device.c \ diff --git a/dlls/dinput8/tests/device.c b/dlls/dinput8/tests/device.c index c211594..53afdf3 100644 --- a/dlls/dinput8/tests/device.c +++ b/dlls/dinput8/tests/device.c @@ -27,10 +27,10 @@ #include "dinput.h" struct enum_data { - LPDIRECTINPUT8 pDI; - LPDIACTIONFORMAT lpdiaf; - LPDIRECTINPUTDEVICE8 keyboard; - LPDIRECTINPUTDEVICE8 mouse; + IDirectInput8A *pDI; + DIACTIONFORMATA *lpdiaf; + IDirectInputDevice8A *keyboard; + IDirectInputDevice8A *mouse; const char* username; int ndevices; }; @@ -46,7 +46,7 @@ enum { DITEST_YAXIS }; -static DIACTION actionMapping[]= +static DIACTIONA actionMapping[]= { /* axis */ { 0, 0x01008A01 /* DIAXIS_DRIVINGR_STEER */ , 0, { "Steer" } }, @@ -60,12 +60,7 @@ static DIACTION actionMapping[]= { 4, DIMOUSE_YAXIS, 0, { "Y Axis" } } }; -static void test_device_input( - LPDIRECTINPUTDEVICE8 lpdid, - DWORD event_type, - DWORD event, - DWORD expected -) +static void test_device_input(IDirectInputDevice8A *lpdid, DWORD event_type, DWORD event, DWORD expected) { HRESULT hr; DIDEVICEOBJECTDATA obj_data; @@ -115,16 +110,11 @@ static void test_device_input( ok(hr == DI_OK && data_size == 1, "GetDeviceData() failed: %08x cnt:%d\n", hr, data_size); } -static void test_build_action_map( - LPDIRECTINPUTDEVICE8 lpdid, - LPDIACTIONFORMAT lpdiaf, - int action_index, - DWORD expected_type, - DWORD expected_inst -) +static void test_build_action_map(IDirectInputDevice8A *lpdid, DIACTIONFORMATA *lpdiaf, + int action_index, DWORD expected_type, DWORD expected_inst) { HRESULT hr; - DIACTION *actions; + DIACTIONA *actions; DWORD instance, type, how; GUID assigned_to; DIDEVICEINSTANCEA ddi; @@ -147,12 +137,8 @@ static void test_build_action_map( ok (IsEqualGUID(&assigned_to, &ddi.guidInstance), "Action and device GUID do not match action=%d\n", action_index); } -static BOOL CALLBACK enumeration_callback( - LPCDIDEVICEINSTANCE lpddi, - LPDIRECTINPUTDEVICE8 lpdid, - DWORD dwFlags, - DWORD dwRemaining, - LPVOID pvRef) +static BOOL CALLBACK enumeration_callback(const DIDEVICEINSTANCEA *lpddi, IDirectInputDevice8A *lpdid, + DWORD dwFlags, DWORD dwRemaining, LPVOID pvRef) { HRESULT hr; DIPROPDWORD dp; @@ -266,9 +252,9 @@ static BOOL CALLBACK enumeration_callback( static void test_action_mapping(void) { HRESULT hr; - HINSTANCE hinst = GetModuleHandle(NULL); - LPDIRECTINPUT8 pDI = NULL; - DIACTIONFORMAT af; + HINSTANCE hinst = GetModuleHandleA(NULL); + IDirectInput8A *pDI = NULL; + DIACTIONFORMATA af; struct enum_data data = {pDI, &af, NULL, NULL, NULL, 0}; hr = CoCreateInstance(&CLSID_DirectInput8, 0, CLSCTX_INPROC_SERVER, &IID_IDirectInput8A, (LPVOID*)&pDI); @@ -293,7 +279,7 @@ static void test_action_mapping(void) memset (&af, 0, sizeof(af)); af.dwSize = sizeof(af); - af.dwActionSize = sizeof(DIACTION); + af.dwActionSize = sizeof(DIACTIONA); af.dwDataSize = 4 * sizeof(actionMapping) / sizeof(actionMapping[0]); af.dwNumActions = sizeof(actionMapping) / sizeof(actionMapping[0]); af.rgoAction = actionMapping; @@ -345,15 +331,15 @@ static void test_action_mapping(void) static void test_save_settings(void) { HRESULT hr; - HINSTANCE hinst = GetModuleHandle(NULL); - LPDIRECTINPUT8 pDI = NULL; - DIACTIONFORMAT af; + HINSTANCE hinst = GetModuleHandleA(NULL); + IDirectInput8A *pDI = NULL; + DIACTIONFORMATA af; IDirectInputDevice8A *pKey; static const GUID mapping_guid = { 0xcafecafe, 0x2, 0x3, { 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa, 0xb } }; static const GUID other_guid = { 0xcafe, 0xcafe, 0x3, { 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa, 0xb } }; - static DIACTION actions[] = { + static DIACTIONA actions[] = { { 0, DIKEYBOARD_A , 0, { "Blam" } }, { 1, DIKEYBOARD_B , 0, { "Kapow"} } }; @@ -392,7 +378,7 @@ static void test_save_settings(void) memset (&af, 0, sizeof(af)); af.dwSize = sizeof(af); - af.dwActionSize = sizeof(DIACTION); + af.dwActionSize = sizeof(DIACTIONA); af.dwDataSize = 4 * sizeof(actions) / sizeof(actions[0]); af.dwNumActions = sizeof(actions) / sizeof(actions[0]); af.rgoAction = actions; diff --git a/dlls/dinput8/tests/dinput.c b/dlls/dinput8/tests/dinput.c index 2a23194..57f5505 100644 --- a/dlls/dinput8/tests/dinput.c +++ b/dlls/dinput8/tests/dinput.c @@ -436,11 +436,11 @@ struct enum_semantics_test unsigned int device_count; BOOL mouse; BOOL keyboard; - LPDIACTIONFORMAT lpdiaf; + DIACTIONFORMATA *lpdiaf; const char* username; }; -static DIACTION actionMapping[]= +static DIACTIONA actionMapping[]= { /* axis */ { 0, 0x01008A01 /* DIAXIS_DRIVINGR_STEER */, 0, { "Steer" } }, @@ -454,7 +454,7 @@ static DIACTION actionMapping[]= { 4, DIMOUSE_YAXIS, 0, { "Y Axis" } } }; -static BOOL CALLBACK enum_semantics_callback(LPCDIDEVICEINSTANCE lpddi, IDirectInputDevice8A *lpdid, DWORD dwFlags, DWORD dwRemaining, void *context) +static BOOL CALLBACK enum_semantics_callback(const DIDEVICEINSTANCEA *lpddi, IDirectInputDevice8A *lpdid, DWORD dwFlags, DWORD dwRemaining, void *context) { struct enum_semantics_test *data = context; @@ -469,7 +469,7 @@ static BOOL CALLBACK enum_semantics_callback(LPCDIDEVICEINSTANCE lpddi, IDirectI return DIENUM_CONTINUE; } -static BOOL CALLBACK set_action_map_callback(LPCDIDEVICEINSTANCE lpddi, IDirectInputDevice8A *lpdid, DWORD dwFlags, DWORD dwRemaining, void *context) +static BOOL CALLBACK set_action_map_callback(const DIDEVICEINSTANCEA *lpddi, IDirectInputDevice8A *lpdid, DWORD dwFlags, DWORD dwRemaining, void *context) { HRESULT hr; struct enum_semantics_test *data = context; @@ -503,7 +503,7 @@ static void test_EnumDevicesBySemantics(void) memset (&diaf, 0, sizeof(diaf)); diaf.dwSize = sizeof(diaf); - diaf.dwActionSize = sizeof(DIACTION); + diaf.dwActionSize = sizeof(DIACTIONA); diaf.dwNumActions = sizeof(actionMapping) / sizeof(actionMapping[0]); diaf.dwDataSize = 4 * diaf.dwNumActions; diaf.rgoAction = actionMapping;

1 0

Francois Gouget : shlwapi/tests: Make test_SHCreateStreamOnFileEx_CopyTo() static.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: daf3c95d045509eee2019b9ce57102ae76861f9b URL: http://source.winehq.org/git/wine.git/?a=commit;h=daf3c95d045509eee2019b9ce… Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Nov 8 19:41:17 2013 +0100 shlwapi/tests: Make test_SHCreateStreamOnFileEx_CopyTo() static. --- dlls/shlwapi/tests/istream.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shlwapi/tests/istream.c b/dlls/shlwapi/tests/istream.c index 9ea3def..4421a78 100644 --- a/dlls/shlwapi/tests/istream.c +++ b/dlls/shlwapi/tests/istream.c @@ -655,7 +655,7 @@ static void test_SHCreateStreamOnFileEx(DWORD mode, DWORD stgm) } -void test_SHCreateStreamOnFileEx_CopyTo(void) +static void test_SHCreateStreamOnFileEx_CopyTo(void) { HRESULT ret; IStream *src, *dst;

1 0

Alexandre Julliard : makefiles: Merge the relpath functionality into makedep.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: 067d3f0ddbbf651fba68557d3cec9a194bf8e91b URL: http://source.winehq.org/git/wine.git/?a=commit;h=067d3f0ddbbf651fba68557d3… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Nov 8 21:11:59 2013 +0100 makefiles: Merge the relpath functionality into makedep. --- .gitignore | 1 - Make.vars.in | 1 - configure | 12 +++--- configure.ac | 12 +++--- libs/wine/Makefile.in | 13 ++----- tools/Makefile.in | 7 +--- tools/makedep.c | 77 ++++++++++++++++++++++++++++++++++++++++--- tools/relpath.c | 86 ------------------------------------------------- 8 files changed, 88 insertions(+), 121 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=067d3f0ddbbf651fba685…

1 0

Alexandre Julliard : makefiles: Add a makedep pragma to mark source files that are parts of the import library .
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: fe946f253ad8ef8ec2400aaf1d71799ca2a99567 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fe946f253ad8ef8ec2400aaf1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Nov 11 11:23:38 2013 +0100 makefiles: Add a makedep pragma to mark source files that are parts of the import library. --- Make.rules.in | 11 +---------- dlls/dinput/data_formats.c | 4 ++++ tools/make_makefiles | 25 +++++++++++++++++++------ tools/makedep.c | 9 +++++++++ 4 files changed, 33 insertions(+), 16 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index ffa6cc3..d9c9827 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -32,16 +32,7 @@ ALLCROSSCFLAGS = $(INCLUDES) $(DEFS) -DWINE_CROSSTEST $(CPPFLAGS) $(CFLAGS) # Implicit rules -.SUFFIXES: .ok .man.in .man .cross.o .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp - -.c.o: - $(CC) -c $(ALLCFLAGS) -o $@ $< - -.m.o: - $(CC) -c $(ALLCFLAGS) -o $@ $< - -.c.cross.o: - $(CROSSCC) -c $(INCLUDES) $(DEFS) -DWINE_CROSSTEST $(CPPFLAGS) $(CFLAGS) -o $@ $< +.SUFFIXES: .ok .man.in .man .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp .c.ok: $(RUNTEST) $(RUNTESTFLAGS) $< && touch $@ diff --git a/dlls/dinput/data_formats.c b/dlls/dinput/data_formats.c index 1f25556..5fac7b7 100644 --- a/dlls/dinput/data_formats.c +++ b/dlls/dinput/data_formats.c @@ -16,6 +16,10 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#if 0 +#pragma makedep implib +#endif + #include <stdarg.h> #include "windef.h" diff --git a/tools/make_makefiles b/tools/make_makefiles index 048dfe3..b61d403 100755 --- a/tools/make_makefiles +++ b/tools/make_makefiles @@ -335,9 +335,7 @@ sub parse_makefile($) my $var = $1; my @list = split(/\s+/, $2); $make{$var} = \@list; - ${$make{"=flags"}}{"mc"} = 1 if $var eq "MC_SRCS"; - ${$make{"=flags"}}{"staticimplib"} = 1 if $var eq "IMPLIB_SRCS"; - ${$make{"=flags"}}{"clean"} = 1 if $var =~ /IDL_[CHIPRS]_SRCS|IDL_TLB_SRCS|PROGRAMS/; + ${$make{"=flags"}}{"clean"} = 1 if $var eq "PROGRAMS"; next; } if (/(install-lib|install-dev|clean)\s*:/) @@ -427,12 +425,20 @@ sub assign_sources_to_makefiles(@) } else { - if ($name =~ /\.c$/) { push @{${$make}{"=C_SRCS"}}, $name; } - elsif ($name =~ /\.m$/) { push @{${$make}{"=OBJC_SRCS"}}, $name; } + if ($name =~ /\.m$/) { push @{${$make}{"=OBJC_SRCS"}}, $name; } elsif ($name =~ /\.l$/) { push @{${$make}{"=LEX_SRCS"}}, $name; } elsif ($name =~ /\.y$/) { push @{${$make}{"=BISON_SRCS"}}, $name; } - elsif ($name =~ /\.mc$/) { push @{${$make}{"=MC_SRCS"}}, $name; } elsif ($name =~ /\.svg$/) { push @{${$make}{"=SVG_SRCS"}}, $name; } + elsif ($name =~ /\.c$/) + { + my %flags = get_makedep_flags( $file ); + if (defined $flags{"implib"}) + { + push @{${$make}{"=IMPLIB_SRCS"}}, $name; + ${${$make}{"=flags"}}{"staticimplib"} = 1; + } + push @{${$make}{"=C_SRCS"}}, $name; + } elsif ($name =~ /\.rc$/) { my %flags = get_makedep_flags( $file ); @@ -443,6 +449,11 @@ sub assign_sources_to_makefiles(@) } push @{${$make}{"=RC_SRCS"}}, $name; } + elsif ($name =~ /\.mc$/) + { + push @{${$make}{"=MC_SRCS"}}, $name; + ${${$make}{"=flags"}}{"mc"} = 1; + } elsif ($name =~ /\.idl$/) { my %flags = get_makedep_flags( $file ); @@ -453,6 +464,7 @@ sub assign_sources_to_makefiles(@) push @{${$make}{"=IDL_R_SRCS"}}, $name if defined $flags{"register"}; push @{${$make}{"=IDL_S_SRCS"}}, $name if defined $flags{"server"}; push @{${$make}{"=IDL_TLB_SRCS"}}, $name if defined $flags{"typelib"}; + ${${$make}{"=flags"}}{"clean"} = 1; } } } @@ -567,6 +579,7 @@ sub update_makefiles(@) replace_makefile_variable( $file, "IDL_S_SRCS" ); replace_makefile_variable( $file, "IDL_TLB_SRCS" ); replace_makefile_variable( $file, "XTEMPLATE_SRCS" ); + replace_makefile_variable( $file, "IMPLIB_SRCS" ); replace_makefile_variable( $file, "SRCDIR_INCLUDES" ); } diff --git a/tools/makedep.c b/tools/makedep.c index aef0f3e..945ba26 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -59,6 +59,7 @@ struct incl_file #define FLAG_IDL_TYPELIB 0x0040 /* generates a typelib (.tlb) file */ #define FLAG_IDL_HEADER 0x0080 /* generates a header (.h) file */ #define FLAG_RC_PO 0x0100 /* rc file contains translations */ +#define FLAG_C_IMPLIB 0x0200 /* file is part of an import library */ static const struct { @@ -747,6 +748,7 @@ static void parse_pragma_directive( struct incl_file *source, char *str ) { if (!strcmp( flag, "po" )) source->flags |= FLAG_RC_PO; } + else if (!strcmp( flag, "implib" )) source->flags |= FLAG_C_IMPLIB; } } @@ -1232,8 +1234,15 @@ static void output_sources(void) else output( "\t$(CC) -c $(ALLCFLAGS) -o $@ %s\n", source->filename ); } + if (source->flags & FLAG_C_IMPLIB) + { + strarray_add( &clean_files, strmake( "%s.cross.o", obj )); + output( "%s.cross.o: %s\n", obj, source->filename ); + output( "\t$(CROSSCC) -c $(ALLCROSSCFLAGS) -o $@ %s\n", source->filename ); + } LIST_FOR_EACH_ENTRY( ext, &object_extensions, struct object_extension, entry ) column += output( "%s.%s ", obj, ext->extension ); + if (source->flags & FLAG_C_IMPLIB) column += output( "%s.cross.o", obj ); column += output( ":" ); } free( obj );

1 0

Alexandre Julliard : makefiles: Remove the no longer needed EXTRASUBDIRS variables.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: 456c8f435a39b2f1e2323f01628e5b1627ab30b7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=456c8f435a39b2f1e2323f016… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Nov 9 20:41:49 2013 +0100 makefiles: Remove the no longer needed EXTRASUBDIRS variables. --- Make.rules.in | 8 +----- Makefile.in | 7 ------ aclocal.m4 | 9 +++---- configure | 44 ++++++++++++++++-------------------------- configure.ac | 13 +++++++---- dlls/gdi32/Makefile.in | 5 ---- dlls/kernel32/Makefile.in | 2 - dlls/user32/Makefile.in | 2 - dlls/wineps.drv/Makefile.in | 2 - include/Makefile.in | 6 ----- tools/Makefile.in | 2 - tools/make_makefiles | 20 +----------------- 12 files changed, 33 insertions(+), 87 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=456c8f435a39b2f1e2323…

1 0

Frédéric Delanoy : comctl32: Use BOOL type where appropriate.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: 5dfe1b0cfea7a85b3b059a49253dfec02db657e8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5dfe1b0cfea7a85b3b059a492… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sat Nov 9 11:03:39 2013 +0100 comctl32: Use BOOL type where appropriate. --- dlls/comctl32/toolbar.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index f6ddb42..0c9714d 100644 --- a/dlls/comctl32/toolbar.c +++ b/dlls/comctl32/toolbar.c @@ -94,8 +94,8 @@ typedef struct INT idCommand; BYTE fsState; BYTE fsStyle; - BYTE bHot; - BYTE bDropDownPressed; + BOOL bHot; + BOOL bDropDownPressed; DWORD_PTR dwData; INT_PTR iString; INT nRow;

1 0

Alexandre Julliard : makefiles: Output clean rules for generated files from makedep.
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: 31eb8be66195d5a1c69e26a4eadeeb057538d44d URL: http://source.winehq.org/git/wine.git/?a=commit;h=31eb8be66195d5a1c69e26a4e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Nov 9 18:57:00 2013 +0100 makefiles: Output clean rules for generated files from makedep. --- Make.rules.in | 8 +----- aclocal.m4 | 3 +- configure | 3 +- tools/makedep.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++----- 4 files changed, 65 insertions(+), 15 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=31eb8be66195d5a1c69e2…

1 0

Marcus Meissner : quartz: Use FreeLibrary instead of CloseHandle (Coverity) .
by Alexandre Julliard Nov. 11, 2013

Nov. 11, 2013

Module: wine Branch: master Commit: b745d8692b690dd7ec4f5f1ca1deff6116e7694a URL: http://source.winehq.org/git/wine.git/?a=commit;h=b745d8692b690dd7ec4f5f1ca… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Fri Nov 8 23:00:52 2013 +0100 quartz: Use FreeLibrary instead of CloseHandle (Coverity). --- dlls/quartz/vmr9.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index 2dc12a6..cd1e139 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -838,7 +838,7 @@ static ULONG WINAPI VMR9Inner_Release(IUnknown * iface) { TRACE("Destroying\n"); BaseControlWindow_Destroy(&This->baseControlWindow); - CloseHandle(This->hD3d9); + FreeLibrary(This->hD3d9); if (This->allocator) IVMRSurfaceAllocatorEx9_Release(This->allocator); @@ -2308,7 +2308,7 @@ static HRESULT vmr_create(IUnknown *outer_unk, LPVOID *ppv, const CLSID *clsid) fail: BaseRendererImpl_Release(&pVMR->renderer.filter.IBaseFilter_iface); - CloseHandle(pVMR->hD3d9); + FreeLibrary(pVMR->hD3d9); CoTaskMemFree(pVMR); return hr; }

1 0