February 2013 - Wine-Commits

Alexandre Julliard : user32/tests: Define the required Windows version before including anything.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 3369c532028e2b8f156f16480d5be7639bc70cdd URL: http://source.winehq.org/git/wine.git/?a=commit;h=3369c532028e2b8f156f16480… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Feb 18 12:31:50 2013 +0100 user32/tests: Define the required Windows version before including anything. --- dlls/user32/tests/dialog.c | 4 ++-- dlls/user32/tests/sysparams.c | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/dlls/user32/tests/dialog.c b/dlls/user32/tests/dialog.c index 0ebab4c..145b20f 100644 --- a/dlls/user32/tests/dialog.c +++ b/dlls/user32/tests/dialog.c @@ -29,12 +29,12 @@ * normally be met. */ +#define WINVER 0x0600 /* For NONCLIENTMETRICS with padding */ + #include <assert.h> #include <stdio.h> #include <stdarg.h> -#define WINVER 0x0600 /* For NONCLIENTMETRICS with padding */ - #include "wine/test.h" #include "windef.h" #include "winbase.h" diff --git a/dlls/user32/tests/sysparams.c b/dlls/user32/tests/sysparams.c index ad43cb7..d4704fa 100644 --- a/dlls/user32/tests/sysparams.c +++ b/dlls/user32/tests/sysparams.c @@ -17,16 +17,15 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define _WIN32_WINNT 0x0600 /* For SPI_GETMOUSEHOVERWIDTH and more */ +#define _WIN32_IE 0x0700 +#define WINVER 0x0600 /* For COLOR_MENUBAR, NONCLIENTMETRICS with padding */ + #include <assert.h> #include <stdlib.h> #include <stdarg.h> #include <stdio.h> -#undef _WIN32_WINNT -#define _WIN32_WINNT 0x0600 /* For SPI_GETMOUSEHOVERWIDTH and more */ -#define _WIN32_IE 0x0700 -#define WINVER 0x0600 /* For COLOR_MENUBAR, NONCLIENTMETRICS with padding */ - #include "wine/test.h" #include "windef.h" #include "winbase.h"

1 0

Dmitry Timoshkov : gdiplus: Avoid a devision by zero when a being added segment length is 0.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 22a7458a3f5fdd060bc6ae9c26e5b98adcd6bc44 URL: http://source.winehq.org/git/wine.git/?a=commit;h=22a7458a3f5fdd060bc6ae9c2… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 18 17:32:12 2013 +0800 gdiplus: Avoid a devision by zero when a being added segment length is 0. This sometimes happens after GdipAddPathLine + GdipWidenPath. --- dlls/gdiplus/graphicspath.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/graphicspath.c b/dlls/gdiplus/graphicspath.c index 1fbebba..f4d1a4b 100644 --- a/dlls/gdiplus/graphicspath.c +++ b/dlls/gdiplus/graphicspath.c @@ -1702,6 +1702,13 @@ static void add_bevel_point(const GpPointF *endpoint, const GpPointF *nextpoint, REAL distance = pen->width/2.0; REAL bevel_dx, bevel_dy; + if (segment_length == 0.0) + { + *last_point = add_path_list_node(*last_point, endpoint->X, + endpoint->Y, PathPointTypeLine); + return; + } + if (right_side) { bevel_dx = -distance * segment_dy / segment_length;

1 0

Dmitry Timoshkov : gdiplus: Forward GdipDrawLineI to GdipDrawLine.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 7cccd36c9ab047cfbbfc17daa224f6344b49abb9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7cccd36c9ab047cfbbfc17daa… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 18 11:37:40 2013 +0800 gdiplus: Forward GdipDrawLineI to GdipDrawLine. --- dlls/gdiplus/graphics.c | 29 +---------------------------- 1 files changed, 1 insertions(+), 28 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 667ead3..bc8b7da 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -3539,36 +3539,9 @@ GpStatus WINGDIPAPI GdipDrawLine(GpGraphics *graphics, GpPen *pen, REAL x1, GpStatus WINGDIPAPI GdipDrawLineI(GpGraphics *graphics, GpPen *pen, INT x1, INT y1, INT x2, INT y2) { - INT save_state; - GpPointF pt[2]; - GpStatus retval; - TRACE("(%p, %p, %d, %d, %d, %d)\n", graphics, pen, x1, y1, x2, y2); - if(!pen || !graphics) - return InvalidParameter; - - if(graphics->busy) - return ObjectBusy; - - if (!graphics->hdc) - { - FIXME("graphics object has no HDC\n"); - return Ok; - } - - pt[0].X = (REAL)x1; - pt[0].Y = (REAL)y1; - pt[1].X = (REAL)x2; - pt[1].Y = (REAL)y2; - - save_state = prepare_dc(graphics, pen); - - retval = draw_polyline(graphics, pen, pt, 2, TRUE); - - restore_dc(graphics, save_state); - - return retval; + return GdipDrawLine(graphics, pen, (REAL)x1, (REAL)y1, (REAL)x2, (REAL)y2); } GpStatus WINGDIPAPI GdipDrawLines(GpGraphics *graphics, GpPen *pen, GDIPCONST

1 0

Ken Thomases : include/wingdi.h: Add definitions for DEVMODE display fixed output flags and values.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: ef2b8a1e8e6afb3525991befc98cd2e9db251193 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ef2b8a1e8e6afb3525991befc… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:38 2013 -0600 include/wingdi.h: Add definitions for DEVMODE display fixed output flags and values. --- include/wingdi.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/wingdi.h b/include/wingdi.h index ca98b3e..408a1b1 100644 --- a/include/wingdi.h +++ b/include/wingdi.h @@ -3027,6 +3027,7 @@ DECL_WINELIB_TYPE_AW(LPDEVMODE) #define DM_DITHERTYPE __MSABI_LONG(0x04000000) #define DM_PANNINGWIDTH __MSABI_LONG(0x08000000) #define DM_PANNINGHEIGHT __MSABI_LONG(0x10000000) +#define DM_DISPLAYFIXEDOUTPUT __MSABI_LONG(0x20000000) #define DM_GRAYSCALE 1 #define DM_INTERLACED 2 @@ -3224,6 +3225,10 @@ DECL_WINELIB_TYPE_AW(LPDEVMODE) #define DMDO_180 2 #define DMDO_270 3 +#define DMDFO_DEFAULT 0 +#define DMDFO_STRETCH 1 +#define DMDFO_CENTER 2 + typedef struct { INT cbSize;

1 0

Ken Thomases : winemac: Use only on-screen windows for Cocoa parent ( Win32 owner) and ordering sibling.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 3799acb3ac8968353c3d8b2ce23f0834c970a098 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3799acb3ac8968353c3d8b2ce… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:23 2013 -0600 winemac: Use only on-screen windows for Cocoa parent (Win32 owner) and ordering sibling. --- dlls/winemac.drv/window.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 7a7eda7..65f7955 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -303,10 +303,12 @@ static void release_win_data(struct macdrv_win_data *data) * * Return the Mac window associated with the full area of a window */ -static macdrv_window macdrv_get_cocoa_window(HWND hwnd) +static macdrv_window macdrv_get_cocoa_window(HWND hwnd, BOOL require_on_screen) { struct macdrv_win_data *data = get_win_data(hwnd); - macdrv_window ret = data ? data->cocoa_window : NULL; + macdrv_window ret = NULL; + if (data && (data->on_screen || !require_on_screen)) + ret = data->cocoa_window; release_win_data(data); return ret; } @@ -330,7 +332,7 @@ static void set_cocoa_window_properties(struct macdrv_win_data *data) ex_style = GetWindowLongW(data->hwnd, GWL_EXSTYLE); owner = GetWindow(data->hwnd, GW_OWNER); - owner_win = macdrv_get_cocoa_window(owner); + owner_win = macdrv_get_cocoa_window(owner, TRUE); macdrv_set_cocoa_parent_window(data->cocoa_window, owner_win); get_cocoa_window_features(data, style, ex_style, &wf); @@ -698,14 +700,14 @@ static void sync_window_position(struct macdrv_win_data *data, UINT swp_flags) /* find window that this one must be after */ HWND prev = GetWindow(data->hwnd, GW_HWNDPREV); while (prev && !((GetWindowLongW(prev, GWL_STYLE) & WS_VISIBLE) && - (prev_window = macdrv_get_cocoa_window(prev)))) + (prev_window = macdrv_get_cocoa_window(prev, TRUE)))) prev = GetWindow(prev, GW_HWNDPREV); if (!prev_window) { /* find window that this one must be before */ next = GetWindow(data->hwnd, GW_HWNDNEXT); while (next && !((GetWindowLongW(next, GWL_STYLE) & WS_VISIBLE) && - (next_window = macdrv_get_cocoa_window(next)))) + (next_window = macdrv_get_cocoa_window(next, TRUE)))) next = GetWindow(next, GW_HWNDNEXT); } @@ -988,7 +990,7 @@ void CDECL macdrv_SetWindowText(HWND hwnd, LPCWSTR text) TRACE("%p, %s\n", hwnd, debugstr_w(text)); - if ((win = macdrv_get_cocoa_window(hwnd))) + if ((win = macdrv_get_cocoa_window(hwnd, FALSE))) macdrv_set_cocoa_window_title(win, text, strlenW(text)); }

1 0

Ken Thomases : winemac: Don't set Cocoa window frame to be zero-sized.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: d74e90080ab1b8820d15b84ab3dce6fe9b4c0568 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d74e90080ab1b8820d15b84ab… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:19 2013 -0600 winemac: Don't set Cocoa window frame to be zero-sized. --- dlls/winemac.drv/cocoa_window.m | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 2247d32..d8ea9ed 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -429,14 +429,17 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) [self doOrderOut]; } - oldFrame = [self frame]; - frame = [self frameRectForContentRect:contentRect]; - if (!NSEqualRects(frame, oldFrame)) + if (!NSIsEmptyRect(contentRect)) { - if (NSEqualSizes(frame.size, oldFrame.size)) - [self setFrameOrigin:frame.origin]; - else - [self setFrame:frame display:YES]; + oldFrame = [self frame]; + frame = [self frameRectForContentRect:contentRect]; + if (!NSEqualRects(frame, oldFrame)) + { + if (NSEqualSizes(frame.size, oldFrame.size)) + [self setFrameOrigin:frame.origin]; + else + [self setFrame:frame display:YES]; + } } if (on_screen)

1 0

Andrew Talbot : msi: Avoid signed-unsigned integer comparisons.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 40f3a9fa590b1e4ab785509bb389efbe4f59e964 URL: http://source.winehq.org/git/wine.git/?a=commit;h=40f3a9fa590b1e4ab785509bb… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Feb 16 21:09:17 2013 +0000 msi: Avoid signed-unsigned integer comparisons. --- dlls/msi/package.c | 8 +++++--- dlls/msi/suminfo.c | 2 +- dlls/msi/where.c | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/msi/package.c b/dlls/msi/package.c index 385000c..bcda102 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -154,7 +154,6 @@ void msi_free_action_script( MSIPACKAGE *package, UINT script ) static void free_package_structures( MSIPACKAGE *package ) { - INT i; struct list *item, *cursor; LIST_FOR_EACH_SAFE( item, cursor, &package->features ) @@ -283,11 +282,14 @@ static void free_package_structures( MSIPACKAGE *package ) if (package->script) { + INT i; + UINT j; + for (i = 0; i < SCRIPT_MAX; i++) msi_free_action_script( package, i ); - for (i = 0; i < package->script->UniqueActionsCount; i++) - msi_free( package->script->UniqueActions[i] ); + for (j = 0; j < package->script->UniqueActionsCount; j++) + msi_free( package->script->UniqueActions[j] ); msi_free( package->script->UniqueActions ); msi_free( package->script ); diff --git a/dlls/msi/suminfo.c b/dlls/msi/suminfo.c index e0c99b8..363f683 100644 --- a/dlls/msi/suminfo.c +++ b/dlls/msi/suminfo.c @@ -922,7 +922,7 @@ static UINT parse_prop( LPCWSTR prop, LPCWSTR value, UINT *pid, INT *int_value, UINT msi_add_suminfo( MSIDATABASE *db, LPWSTR **records, int num_records, int num_columns ) { UINT r = ERROR_FUNCTION_FAILED; - DWORD i, j; + int i, j; MSISUMMARYINFO *si; si = MSI_GetSummaryInformationW( db->storage, num_records * (num_columns / 2) ); diff --git a/dlls/msi/where.c b/dlls/msi/where.c index 10c4b37..e3bc9b7 100644 --- a/dlls/msi/where.c +++ b/dlls/msi/where.c @@ -770,7 +770,7 @@ static UINT WHERE_execute( struct tagMSIVIEW *view, MSIRECORD *record ) JOINTABLE *table = wv->tables; UINT *rows; JOINTABLE **ordered_tables; - int i = 0; + UINT i = 0; TRACE("%p %p\n", wv, record); @@ -1052,7 +1052,7 @@ static UINT WHERE_sort(struct tagMSIVIEW *view, column_info *columns) column_info *column = columns; MSIORDERINFO *orderinfo; UINT r, count = 0; - int i; + UINT i; TRACE("%p %p\n", view, columns);

1 0

Alexandre Julliard : gdi32/tests: Define the required Windows version before including anything.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: eaf78eadf08b5057b0aeff0e76e71e1c3566b354 URL: http://source.winehq.org/git/wine.git/?a=commit;h=eaf78eadf08b5057b0aeff0e7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Feb 18 12:31:40 2013 +0100 gdi32/tests: Define the required Windows version before including anything. --- dlls/gdi32/tests/dc.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/tests/dc.c b/dlls/gdi32/tests/dc.c index e47a091..5f19370 100644 --- a/dlls/gdi32/tests/dc.c +++ b/dlls/gdi32/tests/dc.c @@ -20,13 +20,13 @@ */ -#include <assert.h> -#include <stdio.h> - #define WINVER 0x0501 /* request latest DEVMODE */ #define NONAMELESSSTRUCT #define NONAMELESSUNION +#include <assert.h> +#include <stdio.h> + #include "wine/test.h" #include "winbase.h" #include "wingdi.h"

1 0

Dmitry Timoshkov : gdiplus: Forward GdipDrawLinesI to GdipDrawLines.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 8ec2354b32ac2d807c453ad9620869afadd96184 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8ec2354b32ac2d807c453ad96… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 18 11:38:06 2013 +0800 gdiplus: Forward GdipDrawLinesI to GdipDrawLines. --- dlls/gdiplus/graphics.c | 21 ++------------------- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index bc8b7da..b9aa912 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -3576,25 +3576,12 @@ GpStatus WINGDIPAPI GdipDrawLines(GpGraphics *graphics, GpPen *pen, GDIPCONST GpStatus WINGDIPAPI GdipDrawLinesI(GpGraphics *graphics, GpPen *pen, GDIPCONST GpPoint *points, INT count) { - INT save_state; GpStatus retval; - GpPointF *ptf = NULL; + GpPointF *ptf; int i; TRACE("(%p, %p, %p, %d)\n", graphics, pen, points, count); - if(!pen || !graphics || (count < 2)) - return InvalidParameter; - - if(graphics->busy) - return ObjectBusy; - - if (!graphics->hdc) - { - FIXME("graphics object has no HDC\n"); - return Ok; - } - ptf = GdipAlloc(count * sizeof(GpPointF)); if(!ptf) return OutOfMemory; @@ -3603,11 +3590,7 @@ GpStatus WINGDIPAPI GdipDrawLinesI(GpGraphics *graphics, GpPen *pen, GDIPCONST ptf[i].Y = (REAL) points[i].Y; } - save_state = prepare_dc(graphics, pen); - - retval = draw_polyline(graphics, pen, ptf, count, TRUE); - - restore_dc(graphics, save_state); + retval = GdipDrawLines(graphics, pen, ptf, count); GdipFree(ptf); return retval;

1 0

Dmitry Timoshkov : gdiplus: Forward GdipDrawLine to GdipDrawLines.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 0ed65a2d3aee55851eb7ebe3d57c66f330a22ddb URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ed65a2d3aee55851eb7ebe3d… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 18 11:37:19 2013 +0800 gdiplus: Forward GdipDrawLine to GdipDrawLines. --- dlls/gdiplus/graphics.c | 23 +---------------------- 1 files changed, 1 insertions(+), 22 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 659c46b..667ead3 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -3525,36 +3525,15 @@ GpStatus WINGDIPAPI GdipDrawImageRectI(GpGraphics *graphics, GpImage *image, GpStatus WINGDIPAPI GdipDrawLine(GpGraphics *graphics, GpPen *pen, REAL x1, REAL y1, REAL x2, REAL y2) { - INT save_state; GpPointF pt[2]; - GpStatus retval; TRACE("(%p, %p, %.2f, %.2f, %.2f, %.2f)\n", graphics, pen, x1, y1, x2, y2); - if(!pen || !graphics) - return InvalidParameter; - - if(graphics->busy) - return ObjectBusy; - - if (!graphics->hdc) - { - FIXME("graphics object has no HDC\n"); - return Ok; - } - pt[0].X = x1; pt[0].Y = y1; pt[1].X = x2; pt[1].Y = y2; - - save_state = prepare_dc(graphics, pen); - - retval = draw_polyline(graphics, pen, pt, 2, TRUE); - - restore_dc(graphics, save_state); - - return retval; + return GdipDrawLines(graphics, pen, pt, 2); } GpStatus WINGDIPAPI GdipDrawLineI(GpGraphics *graphics, GpPen *pen, INT x1,

1 0

Andrew Talbot : msvcp90: Avoid signed-unsigned integer comparisons.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 51a79287c0dd7327e55796e26ed6fe10f8ea3f80 URL: http://source.winehq.org/git/wine.git/?a=commit;h=51a79287c0dd7327e55796e26… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Feb 16 21:09:21 2013 +0000 msvcp90: Avoid signed-unsigned integer comparisons. --- dlls/msvcp90/ios.c | 2 +- dlls/msvcp90/misc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp90/ios.c b/dlls/msvcp90/ios.c index eab867b..87ad06e 100644 --- a/dlls/msvcp90/ios.c +++ b/dlls/msvcp90/ios.c @@ -2533,7 +2533,7 @@ FILE* __cdecl _Fiopen_wchar(const wchar_t *name, int mode, int prot) }; int real_mode = mode & ~(OPENMODE_ate|OPENMODE__Nocreate|OPENMODE__Noreplace|OPENMODE_binary); - int mode_idx; + unsigned int mode_idx; FILE *f = NULL; TRACE("(%s %d %d)\n", debugstr_w(name), mode, prot); diff --git a/dlls/msvcp90/misc.c b/dlls/msvcp90/misc.c index 8b3df21..bacf26c 100644 --- a/dlls/msvcp90/misc.c +++ b/dlls/msvcp90/misc.c @@ -195,7 +195,7 @@ unsigned short __cdecl wctype(const char *property) { "upper", _UPPER }, { "xdigit", _HEX } }; - int i; + unsigned int i; for(i=0; i<sizeof(properties)/sizeof(properties[0]); i++) if(!strcmp(property, properties[i].name))

1 0

Alexandre Julliard : rpcrt4/tests: Define the required Windows version before including anything.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 38e8f6d83f78e18a3bf9529c7af8ee629730d16c URL: http://source.winehq.org/git/wine.git/?a=commit;h=38e8f6d83f78e18a3bf9529c7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Feb 18 12:31:58 2013 +0100 rpcrt4/tests: Define the required Windows version before including anything. --- dlls/rpcrt4/tests/ndr_marshall.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c index ac3bacc..cc3e1d3 100644 --- a/dlls/rpcrt4/tests/ndr_marshall.c +++ b/dlls/rpcrt4/tests/ndr_marshall.c @@ -18,12 +18,12 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include <stdarg.h> - #define _WIN32_WINNT 0x0500 #define NTDDI_WIN2K 0x05000000 #define NTDDI_VERSION NTDDI_WIN2K /* for some MIDL_STUB_MESSAGE fields */ +#include <stdarg.h> + #include "wine/test.h" #include <windef.h> #include <winbase.h>

1 0

Dmitry Timoshkov : include/gdiplusenums.h: Add FlatnessDefault definition.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 9bcd1cdd3141dbfaa47432f92a309c4109080ad8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9bcd1cdd3141dbfaa47432f92… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Feb 18 17:31:48 2013 +0800 include/gdiplusenums.h: Add FlatnessDefault definition. --- include/gdiplusenums.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h index d0fc11b..c730a0c 100644 --- a/include/gdiplusenums.h +++ b/include/gdiplusenums.h @@ -704,6 +704,8 @@ enum EmfPlusRecordType { EmfPlusRecordTypeMin = EmfPlusRecordTypeHeader }; +#define FlatnessDefault 0.25f + #ifndef __cplusplus typedef enum Unit Unit;

1 0

Ken Thomases : winemac: Implement ChangeDisplaySettingsEx().
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: d26a6bf45120865e696c1f68e59f8c60f7eb0716 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d26a6bf45120865e696c1f68e… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:49 2013 -0600 winemac: Implement ChangeDisplaySettingsEx(). --- dlls/winemac.drv/cocoa_app.h | 3 + dlls/winemac.drv/cocoa_app.m | 167 +++++++++++++++++++++++++- dlls/winemac.drv/cocoa_window.h | 2 + dlls/winemac.drv/cocoa_window.m | 11 ++- dlls/winemac.drv/display.c | 241 ++++++++++++++++++++++++++++++++++++- dlls/winemac.drv/macdrv_cocoa.h | 5 + dlls/winemac.drv/winemac.drv.spec | 1 + 7 files changed, 422 insertions(+), 8 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d26a6bf45120865e696c1…

1 0

Ken Thomases : winemac: Implement EnumDisplaySettingsEx().
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 4f4ac0cafcf0a1db61939bd146d8f6d077b3be7b URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f4ac0cafcf0a1db61939bd14… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:42 2013 -0600 winemac: Implement EnumDisplaySettingsEx(). --- dlls/winemac.drv/display.c | 221 +++++++++++++++++++++++++++++++++++++ dlls/winemac.drv/winemac.drv.spec | 1 + 2 files changed, 222 insertions(+), 0 deletions(-) diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c index 2a96631..afa0646 100644 --- a/dlls/winemac.drv/display.c +++ b/dlls/winemac.drv/display.c @@ -23,10 +23,22 @@ #include "macdrv.h" #include "winuser.h" +#include "winreg.h" WINE_DEFAULT_DEBUG_CHANNEL(display); +static CFArrayRef modes; +static CRITICAL_SECTION modes_section; +static CRITICAL_SECTION_DEBUG critsect_debug = +{ + 0, 0, &modes_section, + { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, + 0, 0, { (DWORD_PTR)(__FILE__ ": modes_section") } +}; +static CRITICAL_SECTION modes_section = { &critsect_debug, -1, 0, 0, 0, 0 }; + + static inline HMONITOR display_id_to_monitor(CGDirectDisplayID display_id) { return (HMONITOR)(UINT_PTR)display_id; @@ -38,6 +50,73 @@ static inline CGDirectDisplayID monitor_to_display_id(HMONITOR handle) } +static BOOL get_display_device_reg_key(char *key, unsigned len) +{ + static const char display_device_guid_prop[] = "__wine_display_device_guid"; + static const char video_path[] = "System\\CurrentControlSet\\Control\\Video\\{"; + static const char display0[] = "}\\0000"; + ATOM guid_atom; + + assert(len >= sizeof(video_path) + sizeof(display0) + 40); + + guid_atom = HandleToULong(GetPropA(GetDesktopWindow(), display_device_guid_prop)); + if (!guid_atom) return FALSE; + + memcpy(key, video_path, sizeof(video_path)); + + if (!GlobalGetAtomNameA(guid_atom, key + strlen(key), 40)) + return FALSE; + + strcat(key, display0); + + TRACE("display device key %s\n", wine_dbgstr_a(key)); + return TRUE; +} + + +static BOOL read_registry_settings(DEVMODEW *dm) +{ + char wine_mac_reg_key[128]; + HKEY hkey; + DWORD type, size; + BOOL ret = TRUE; + + dm->dmFields = 0; + + if (!get_display_device_reg_key(wine_mac_reg_key, sizeof(wine_mac_reg_key))) + return FALSE; + + if (RegOpenKeyExA(HKEY_CURRENT_CONFIG, wine_mac_reg_key, 0, KEY_READ, &hkey)) + return FALSE; + +#define query_value(name, data) \ + size = sizeof(DWORD); \ + if (RegQueryValueExA(hkey, name, 0, &type, (LPBYTE)(data), &size) || \ + type != REG_DWORD || size != sizeof(DWORD)) \ + ret = FALSE + + query_value("DefaultSettings.BitsPerPel", &dm->dmBitsPerPel); + dm->dmFields |= DM_BITSPERPEL; + query_value("DefaultSettings.XResolution", &dm->dmPelsWidth); + dm->dmFields |= DM_PELSWIDTH; + query_value("DefaultSettings.YResolution", &dm->dmPelsHeight); + dm->dmFields |= DM_PELSHEIGHT; + query_value("DefaultSettings.VRefresh", &dm->dmDisplayFrequency); + dm->dmFields |= DM_DISPLAYFREQUENCY; + query_value("DefaultSettings.Flags", &dm->dmDisplayFlags); + dm->dmFields |= DM_DISPLAYFLAGS; + query_value("DefaultSettings.XPanning", &dm->dmPosition.x); + query_value("DefaultSettings.YPanning", &dm->dmPosition.y); + query_value("DefaultSettings.Orientation", &dm->dmDisplayOrientation); + query_value("DefaultSettings.FixedOutput", &dm->dmDisplayFixedOutput); + +#undef query_value + + RegCloseKey(hkey); + return ret; +} + + static int display_mode_bits_per_pixel(CGDisplayModeRef display_mode) { CFStringRef pixel_encoding; @@ -144,6 +223,148 @@ BOOL CDECL macdrv_EnumDisplayMonitors(HDC hdc, LPRECT rect, MONITORENUMPROC proc /*********************************************************************** + * EnumDisplaySettingsEx (MACDRV.@) + * + */ +BOOL CDECL macdrv_EnumDisplaySettingsEx(LPCWSTR devname, DWORD mode, + LPDEVMODEW devmode, DWORD flags) +{ + static const WCHAR dev_name[CCHDEVICENAME] = + { 'W','i','n','e',' ','M','a','c',' ','d','r','i','v','e','r',0 }; + struct macdrv_display *displays = NULL; + int num_displays; + CGDisplayModeRef display_mode; + double rotation; + uint32_t io_flags; + + TRACE("%s, %u, %p + %hu, %08x\n", debugstr_w(devname), mode, devmode, devmode->dmSize, flags); + + memcpy(devmode->dmDeviceName, dev_name, sizeof(dev_name)); + devmode->dmSpecVersion = DM_SPECVERSION; + devmode->dmDriverVersion = DM_SPECVERSION; + devmode->dmSize = FIELD_OFFSET(DEVMODEW, dmICMMethod); + devmode->dmDriverExtra = 0; + memset(&devmode->dmFields, 0, devmode->dmSize - FIELD_OFFSET(DEVMODEW, dmFields)); + + if (mode == ENUM_REGISTRY_SETTINGS) + { + TRACE("mode %d (registry) -- getting default mode\n", mode); + return read_registry_settings(devmode); + } + + if (macdrv_get_displays(&displays, &num_displays)) + goto failed; + + if (mode == ENUM_CURRENT_SETTINGS) + { + TRACE("mode %d (current) -- getting current mode\n", mode); + display_mode = CGDisplayCopyDisplayMode(displays[0].displayID); + } + else + { + EnterCriticalSection(&modes_section); + + if (mode == 0 || !modes) + { + if (modes) CFRelease(modes); + modes = CGDisplayCopyAllDisplayModes(displays[0].displayID, NULL); + } + + display_mode = NULL; + if (modes) + { + if (flags & EDS_RAWMODE) + { + if (mode < CFArrayGetCount(modes)) + display_mode = (CGDisplayModeRef)CFRetain(CFArrayGetValueAtIndex(modes, mode)); + } + else + { + DWORD count, i, safe_modes = 0; + count = CFArrayGetCount(modes); + for (i = 0; i < count; i++) + { + CGDisplayModeRef candidate = (CGDisplayModeRef)CFArrayGetValueAtIndex(modes, i); + io_flags = CGDisplayModeGetIOFlags(candidate); + if ((io_flags & kDisplayModeValidFlag) && + (io_flags & kDisplayModeSafeFlag)) + { + safe_modes++; + if (safe_modes > mode) + { + display_mode = (CGDisplayModeRef)CFRetain(candidate); + break; + } + } + } + } + } + + LeaveCriticalSection(&modes_section); + } + + if (!display_mode) + goto failed; + + /* We currently only report modes for the primary display, so it's at (0, 0). */ + devmode->dmPosition.x = 0; + devmode->dmPosition.y = 0; + devmode->dmFields |= DM_POSITION; + + rotation = CGDisplayRotation(displays[0].displayID); + devmode->dmDisplayOrientation = ((int)((rotation / 90) + 0.5)) % 4; + devmode->dmFields |= DM_DISPLAYORIENTATION; + + io_flags = CGDisplayModeGetIOFlags(display_mode); + if (io_flags & kDisplayModeStretchedFlag) + devmode->dmDisplayFixedOutput = DMDFO_STRETCH; + else + devmode->dmDisplayFixedOutput = DMDFO_CENTER; + devmode->dmFields |= DM_DISPLAYFIXEDOUTPUT; + + devmode->dmBitsPerPel = display_mode_bits_per_pixel(display_mode); + if (devmode->dmBitsPerPel) + devmode->dmFields |= DM_BITSPERPEL; + + devmode->dmPelsWidth = CGDisplayModeGetWidth(display_mode); + devmode->dmPelsHeight = CGDisplayModeGetHeight(display_mode); + devmode->dmFields |= DM_PELSWIDTH | DM_PELSHEIGHT; + + devmode->dmDisplayFlags = 0; + if (io_flags & kDisplayModeInterlacedFlag) + devmode->dmDisplayFlags |= DM_INTERLACED; + devmode->dmFields |= DM_DISPLAYFLAGS; + + devmode->dmDisplayFrequency = CGDisplayModeGetRefreshRate(display_mode); + if (!devmode->dmDisplayFrequency) + devmode->dmDisplayFrequency = 60; + devmode->dmFields |= DM_DISPLAYFREQUENCY; + + CFRelease(display_mode); + macdrv_free_displays(displays); + + TRACE("mode %d -- %dx%dx%dbpp @%d Hz", mode, + devmode->dmPelsWidth, devmode->dmPelsHeight, devmode->dmBitsPerPel, + devmode->dmDisplayFrequency); + if (devmode->dmDisplayOrientation) + TRACE(" rotated %u degrees", devmode->dmDisplayOrientation * 90); + if (devmode->dmDisplayFixedOutput == DMDFO_STRETCH) + TRACE(" stretched"); + if (devmode->dmDisplayFlags & DM_INTERLACED) + TRACE(" interlaced"); + TRACE("\n"); + + return TRUE; + +failed: + TRACE("mode %d -- not present\n", mode); + if (displays) macdrv_free_displays(displays); + SetLastError(ERROR_NO_MORE_FILES); + return FALSE; +} + + +/*********************************************************************** * GetMonitorInfo (MACDRV.@) */ BOOL CDECL macdrv_GetMonitorInfo(HMONITOR monitor, LPMONITORINFO info) diff --git a/dlls/winemac.drv/winemac.drv.spec b/dlls/winemac.drv/winemac.drv.spec index 57b1e5a..d841283 100644 --- a/dlls/winemac.drv/winemac.drv.spec +++ b/dlls/winemac.drv/winemac.drv.spec @@ -10,6 +10,7 @@ @ cdecl CreateWindow(long) macdrv_CreateWindow @ cdecl DestroyWindow(long) macdrv_DestroyWindow @ cdecl EnumDisplayMonitors(long ptr ptr long) macdrv_EnumDisplayMonitors +@ cdecl EnumDisplaySettingsEx(ptr long ptr long) macdrv_EnumDisplaySettingsEx @ cdecl GetKeyboardLayout(long) macdrv_GetKeyboardLayout @ cdecl GetKeyboardLayoutName(ptr) macdrv_GetKeyboardLayoutName @ cdecl GetKeyNameText(long ptr long) macdrv_GetKeyNameText

1 0

Ken Thomases : winemac: Implement DISPLAYS_CHANGED event for when display configuration has changed .
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: bc75a9baffd889deef00a2acfdb19ae4bdce29ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=bc75a9baffd889deef00a2acf… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:34 2013 -0600 winemac: Implement DISPLAYS_CHANGED event for when display configuration has changed. --- dlls/winemac.drv/cocoa_app.m | 15 +++++++++ dlls/winemac.drv/display.c | 65 ++++++++++++++++++++++++++++++++++++++- dlls/winemac.drv/event.c | 5 +++ dlls/winemac.drv/gdi.c | 10 +++++- dlls/winemac.drv/macdrv.h | 6 +++ dlls/winemac.drv/macdrv_cocoa.h | 1 + dlls/winemac.drv/window.c | 33 ++++++++++++++++++++ 7 files changed, 133 insertions(+), 2 deletions(-) diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m index 2651cfc..479b4d0 100644 --- a/dlls/winemac.drv/cocoa_app.m +++ b/dlls/winemac.drv/cocoa_app.m @@ -312,6 +312,20 @@ int macdrv_err_on; } } + - (void) sendDisplaysChanged + { + macdrv_event event; + WineEventQueue* queue; + + event.type = DISPLAYS_CHANGED; + event.window = NULL; + + [eventQueuesLock lock]; + for (queue in eventQueues) + [queue postEvent:&event]; + [eventQueuesLock unlock]; + } + /* * ---------- NSApplication method overrides ---------- @@ -340,6 +354,7 @@ int macdrv_err_on; - (void)applicationDidChangeScreenParameters:(NSNotification *)notification { primaryScreenHeightValid = FALSE; + [self sendDisplaysChanged]; } - (void)applicationDidResignActive:(NSNotification *)notification diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c index a1bea38..2a96631 100644 --- a/dlls/winemac.drv/display.c +++ b/dlls/winemac.drv/display.c @@ -2,7 +2,7 @@ * MACDRV display settings * * Copyright 2003 Alexander James Pasadyn - * Copyright 2011, 2012 Ken Thomases for CodeWeavers Inc. + * Copyright 2011, 2012, 2013 Ken Thomases for CodeWeavers Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -38,6 +38,42 @@ static inline CGDirectDisplayID monitor_to_display_id(HMONITOR handle) } +static int display_mode_bits_per_pixel(CGDisplayModeRef display_mode) +{ + CFStringRef pixel_encoding; + int bits_per_pixel = 0; + + pixel_encoding = CGDisplayModeCopyPixelEncoding(display_mode); + if (pixel_encoding) + { + if (CFEqual(pixel_encoding, CFSTR(kIO32BitFloatPixels))) + bits_per_pixel = 128; + else if (CFEqual(pixel_encoding, CFSTR(kIO16BitFloatPixels))) + bits_per_pixel = 64; + else if (CFEqual(pixel_encoding, CFSTR(kIO64BitDirectPixels))) + bits_per_pixel = 64; + else if (CFEqual(pixel_encoding, CFSTR(kIO30BitDirectPixels))) + bits_per_pixel = 30; + else if (CFEqual(pixel_encoding, CFSTR(IO32BitDirectPixels))) + bits_per_pixel = 32; + else if (CFEqual(pixel_encoding, CFSTR(IO16BitDirectPixels))) + bits_per_pixel = 16; + else if (CFEqual(pixel_encoding, CFSTR(IO8BitIndexedPixels))) + bits_per_pixel = 8; + else if (CFEqual(pixel_encoding, CFSTR(IO4BitIndexedPixels))) + bits_per_pixel = 4; + else if (CFEqual(pixel_encoding, CFSTR(IO2BitIndexedPixels))) + bits_per_pixel = 2; + else if (CFEqual(pixel_encoding, CFSTR(IO1BitIndexedPixels))) + bits_per_pixel = 1; + + CFRelease(pixel_encoding); + } + + return bits_per_pixel; +} + + /*********************************************************************** * EnumDisplayMonitors (MACDRV.@) */ @@ -156,3 +192,30 @@ BOOL CDECL macdrv_GetMonitorInfo(HMONITOR monitor, LPMONITORINFO info) macdrv_free_displays(displays); return (i < num_displays); } + + +/*********************************************************************** + * macdrv_displays_changed + * + * Handler for DISPLAYS_CHANGED events. + */ +void macdrv_displays_changed(const macdrv_event *event) +{ + HWND hwnd = GetDesktopWindow(); + + /* A system display change will get delivered to all GUI-attached threads, + so the desktop-window-owning thread will get it and all others should + ignore it. */ + if (GetWindowThreadProcessId(hwnd, NULL) == GetCurrentThreadId()) + { + CGDirectDisplayID mainDisplay = CGMainDisplayID(); + CGDisplayModeRef mode = CGDisplayCopyDisplayMode(mainDisplay); + size_t width = CGDisplayModeGetWidth(mode); + size_t height = CGDisplayModeGetHeight(mode); + int mode_bpp = display_mode_bits_per_pixel(mode); + + CGDisplayModeRelease(mode); + SendMessageW(hwnd, WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, + MAKELPARAM(width, height)); + } +} diff --git a/dlls/winemac.drv/event.c b/dlls/winemac.drv/event.c index f03fef4..b9131f7 100644 --- a/dlls/winemac.drv/event.c +++ b/dlls/winemac.drv/event.c @@ -33,6 +33,7 @@ static const char *dbgstr_event(int type) { static const char * const event_names[] = { "APP_DEACTIVATED", + "DISPLAYS_CHANGED", "KEY_PRESS", "KEY_RELEASE", "KEYBOARD_CHANGED", @@ -84,6 +85,7 @@ static macdrv_event_mask get_event_mask(DWORD mask) if (mask & QS_POSTMESSAGE) { event_mask |= event_mask_for_type(APP_DEACTIVATED); + event_mask |= event_mask_for_type(DISPLAYS_CHANGED); event_mask |= event_mask_for_type(WINDOW_CLOSE_REQUESTED); event_mask |= event_mask_for_type(WINDOW_DID_MINIMIZE); event_mask |= event_mask_for_type(WINDOW_DID_UNMINIMIZE); @@ -116,6 +118,9 @@ void macdrv_handle_event(macdrv_event *event) case APP_DEACTIVATED: macdrv_app_deactivated(); break; + case DISPLAYS_CHANGED: + macdrv_displays_changed(event); + break; case KEY_PRESS: case KEY_RELEASE: macdrv_key_event(hwnd, event); diff --git a/dlls/winemac.drv/gdi.c b/dlls/winemac.drv/gdi.c index 333cb0c..6ded900 100644 --- a/dlls/winemac.drv/gdi.c +++ b/dlls/winemac.drv/gdi.c @@ -2,7 +2,7 @@ * Mac graphics driver initialisation functions * * Copyright 1996 Alexandre Julliard - * Copyright 2011, 2012 Ken Thomases for CodeWeavers, Inc. + * Copyright 2011, 2012, 2013 Ken Thomases for CodeWeavers, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -200,6 +200,14 @@ static void device_init(void) } +void macdrv_reset_device_metrics(void) +{ + EnterCriticalSection(&device_data_section); + device_data_valid = FALSE; + LeaveCriticalSection(&device_data_section); +} + + static MACDRV_PDEVICE *create_mac_physdev(void) { MACDRV_PDEVICE *physDev; diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h index 8c4ce54..113cda1 100644 --- a/dlls/winemac.drv/macdrv.h +++ b/dlls/winemac.drv/macdrv.h @@ -68,6 +68,7 @@ static inline const char *wine_dbgstr_cgrect(CGRect cgrect) */ extern CGRect macdrv_get_desktop_rect(void) DECLSPEC_HIDDEN; +extern void macdrv_reset_device_metrics(void) DECLSPEC_HIDDEN; /************************************************************************** @@ -78,6 +79,9 @@ extern CGRect macdrv_get_desktop_rect(void) DECLSPEC_HIDDEN; enum macdrv_window_messages { WM_MACDRV_SET_WIN_REGION = 0x80001000, + WM_MACDRV_UPDATE_DESKTOP_RECT, + WM_MACDRV_RESET_DEVICE_METRICS, + WM_MACDRV_DISPLAYCHANGE, }; struct macdrv_thread_data @@ -142,4 +146,6 @@ extern void macdrv_compute_keyboard_layout(struct macdrv_thread_data *thread_dat extern void macdrv_keyboard_changed(const macdrv_event *event) DECLSPEC_HIDDEN; extern void macdrv_key_event(HWND hwnd, const macdrv_event *event) DECLSPEC_HIDDEN; +extern void macdrv_displays_changed(const macdrv_event *event) DECLSPEC_HIDDEN; + #endif /* __WINE_MACDRV_H */ diff --git a/dlls/winemac.drv/macdrv_cocoa.h b/dlls/winemac.drv/macdrv_cocoa.h index 23f0edf..5ffd7c7 100644 --- a/dlls/winemac.drv/macdrv_cocoa.h +++ b/dlls/winemac.drv/macdrv_cocoa.h @@ -126,6 +126,7 @@ extern void macdrv_free_displays(struct macdrv_display* displays) DECLSPEC_HIDDE /* event */ enum { APP_DEACTIVATED, + DISPLAYS_CHANGED, KEY_PRESS, KEY_RELEASE, KEYBOARD_CHANGED, diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c index 65f7955..c7513f0 100644 --- a/dlls/winemac.drv/window.c +++ b/dlls/winemac.drv/window.c @@ -1192,6 +1192,39 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) release_win_data(data); } return 0; + case WM_MACDRV_UPDATE_DESKTOP_RECT: + if (hwnd == GetDesktopWindow()) + { + CGRect new_desktop_rect; + RECT current_desktop_rect; + + macdrv_reset_device_metrics(); + new_desktop_rect = macdrv_get_desktop_rect(); + if (!GetWindowRect(hwnd, &current_desktop_rect) || + !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) + { + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, + SMTO_ABORTIFHUNG, 2000, NULL); + SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), + CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), + SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, + SMTO_ABORTIFHUNG, 2000, NULL); + } + } + return 0; + case WM_MACDRV_RESET_DEVICE_METRICS: + macdrv_reset_device_metrics(); + return 0; + case WM_MACDRV_DISPLAYCHANGE: + if ((data = get_win_data(hwnd))) + { + if (data->cocoa_window && data->on_screen) + sync_window_position(data, SWP_NOZORDER | SWP_NOACTIVATE); + release_win_data(data); + } + SendMessageW(hwnd, WM_DISPLAYCHANGE, wp, lp); + return 0; } FIXME("unrecognized window msg %x hwnd %p wp %lx lp %lx\n", msg, hwnd, wp, lp);

1 0

Ken Thomases : winemac: Implement support for full-screen windows.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: be6af9a169cac983a0b51531097899cfd7312bb8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=be6af9a169cac983a0b515310… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:30 2013 -0600 winemac: Implement support for full-screen windows. --- dlls/winemac.drv/cocoa_app.m | 23 ++++++- dlls/winemac.drv/cocoa_window.h | 4 + dlls/winemac.drv/cocoa_window.m | 139 +++++++++++++++++++++++++++++++++++++-- 3 files changed, 159 insertions(+), 7 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=be6af9a169cac983a0b51…

1 0

Ken Thomases : winemac: Track Cocoa windows in a z-ordered list.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: ba86e67792c7056580ce7fefe64d9671ea4f1334 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ba86e67792c7056580ce7fefe… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:27 2013 -0600 winemac: Track Cocoa windows in a z-ordered list. --- dlls/winemac.drv/cocoa_app.h | 7 ++++ dlls/winemac.drv/cocoa_app.m | 64 ++++++++++++++++++++++++++++++++++++++- dlls/winemac.drv/cocoa_window.m | 39 +++++++++++++++++++++++ 3 files changed, 109 insertions(+), 1 deletions(-) diff --git a/dlls/winemac.drv/cocoa_app.h b/dlls/winemac.drv/cocoa_app.h index 1166087..f215b11 100644 --- a/dlls/winemac.drv/cocoa_app.h +++ b/dlls/winemac.drv/cocoa_app.h @@ -46,10 +46,13 @@ CGFloat primaryScreenHeight; BOOL primaryScreenHeightValid; + + NSMutableArray* orderedWineWindows; } @property (nonatomic) CGEventSourceKeyboardType keyboardType; @property (readonly, copy, nonatomic) NSEvent* lastFlagsChanged; +(a)property (readonly, nonatomic) NSArray* orderedWineWindows; - (void) transformProcessToForeground; @@ -63,6 +66,10 @@ - (void) keyboardSelectionDidChange; + - (void) wineWindow:(WineWindow*)window + ordered:(NSWindowOrderingMode)order + relativeTo:(WineWindow*)otherWindow; + @end void OnMainThread(dispatch_block_t block); diff --git a/dlls/winemac.drv/cocoa_app.m b/dlls/winemac.drv/cocoa_app.m index ae2353b..d26682e 100644 --- a/dlls/winemac.drv/cocoa_app.m +++ b/dlls/winemac.drv/cocoa_app.m @@ -38,6 +38,7 @@ int macdrv_err_on; @implementation WineApplication @synthesize keyboardType, lastFlagsChanged; + @synthesize orderedWineWindows; - (id) init { @@ -48,8 +49,9 @@ int macdrv_err_on; eventQueuesLock = [[NSLock alloc] init]; keyWindows = [[NSMutableArray alloc] init]; + orderedWineWindows = [[NSMutableArray alloc] init]; - if (!eventQueues || !eventQueuesLock || !keyWindows) + if (!eventQueues || !eventQueuesLock || !keyWindows || !orderedWineWindows) { [self release]; return nil; @@ -60,6 +62,7 @@ int macdrv_err_on; - (void) dealloc { + [orderedWineWindows release]; [keyWindows release]; [eventQueues release]; [eventQueuesLock release]; @@ -251,6 +254,64 @@ int macdrv_err_on; return point; } + - (void) wineWindow:(WineWindow*)window + ordered:(NSWindowOrderingMode)order + relativeTo:(WineWindow*)otherWindow + { + NSUInteger index; + + switch (order) + { + case NSWindowAbove: + [window retain]; + [orderedWineWindows removeObjectIdenticalTo:window]; + if (otherWindow) + { + index = [orderedWineWindows indexOfObjectIdenticalTo:otherWindow]; + if (index == NSNotFound) + index = 0; + } + else + { + index = 0; + for (otherWindow in orderedWineWindows) + { + if ([otherWindow level] <= [window level]) + break; + index++; + } + } + [orderedWineWindows insertObject:window atIndex:index]; + [window release]; + break; + case NSWindowBelow: + [window retain]; + [orderedWineWindows removeObjectIdenticalTo:window]; + if (otherWindow) + { + index = [orderedWineWindows indexOfObjectIdenticalTo:otherWindow]; + if (index == NSNotFound) + index = [orderedWineWindows count]; + } + else + { + index = 0; + for (otherWindow in orderedWineWindows) + { + if ([otherWindow level] < [window level]) + break; + index++; + } + } + [orderedWineWindows insertObject:window atIndex:index]; + [window release]; + break; + case NSWindowOut: + default: + break; + } + } + /* * ---------- NSApplication method overrides ---------- @@ -307,6 +368,7 @@ int macdrv_err_on; usingBlock:^(NSNotification *note){ NSWindow* window = [note object]; [keyWindows removeObjectIdenticalTo:window]; + [orderedWineWindows removeObjectIdenticalTo:window]; }]; [nc addObserver:self diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index d8ea9ed..b3ccb92 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -380,12 +380,19 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) [NSApp transformProcessToForeground]; if (prev) + { [self orderWindow:NSWindowBelow relativeTo:[prev windowNumber]]; + [NSApp wineWindow:self ordered:NSWindowBelow relativeTo:prev]; + } else + { [self orderWindow:NSWindowAbove relativeTo:[next windowNumber]]; + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:next]; + } if (latentParentWindow) { [latentParentWindow addChildWindow:self ordered:NSWindowAbove]; + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:latentParentWindow]; self.latentParentWindow = nil; } @@ -407,6 +414,7 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) [latentParentWindow removeChildWindow:self]; forceNextMouseMoveAbsolute = TRUE; [self orderOut:nil]; + [NSApp wineWindow:self ordered:NSWindowOut relativeTo:nil]; [NSApp removeWindowsItem:self]; } @@ -467,7 +475,10 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) [[self parentWindow] removeChildWindow:self]; self.latentParentWindow = nil; if ([self isVisible] && parent) + { [parent addChildWindow:self ordered:NSWindowAbove]; + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:parent]; + } else self.latentParentWindow = parent; } @@ -556,12 +567,14 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) } [self orderFront:nil]; + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:nil]; causing_becomeKeyWindow = TRUE; [self makeKeyWindow]; causing_becomeKeyWindow = FALSE; if (latentParentWindow) { [latentParentWindow addChildWindow:self ordered:NSWindowAbove]; + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:latentParentWindow]; self.latentParentWindow = nil; } if (![self isExcludedFromWindowsMenu]) @@ -700,6 +713,9 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) { if ([event type] == NSLeftMouseDown) { + NSWindowButton windowButton; + BOOL broughtWindowForward = TRUE; + /* Since our windows generally claim they can't be made key, clicks in their title bars are swallowed by the theme frame stuff. So, we hook directly into the event stream and assume that any click @@ -707,6 +723,27 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) accept. */ if (![self isKeyWindow] && !self.disabled && !self.noActivate) [NSApp windowGotFocus:self]; + + /* Any left-click on our window anyplace other than the close or + minimize buttons will bring it forward. */ + for (windowButton = NSWindowCloseButton; + windowButton <= NSWindowMiniaturizeButton; + windowButton++) + { + NSButton* button = [[event window] standardWindowButton:windowButton]; + if (button) + { + NSPoint point = [button convertPoint:[event locationInWindow] fromView:nil]; + if ([button mouse:point inRect:[button bounds]]) + { + broughtWindowForward = FALSE; + break; + } + } + } + + if (broughtWindowForward) + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:nil]; } [super sendEvent:event]; @@ -908,6 +945,8 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) } ignore_windowDeminiaturize = FALSE; + + [NSApp wineWindow:self ordered:NSWindowAbove relativeTo:nil]; } - (void)windowDidMove:(NSNotification *)notification

1 0

Piotr Caban : msvcp90: Prefer builtin version.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: cfec148b8baeb86ee9d775f9cf527b80e043f5a4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cfec148b8baeb86ee9d775f9c… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Feb 18 10:26:17 2013 +0100 msvcp90: Prefer builtin version. --- dlls/msvcp90/msvcp90_main.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp90/msvcp90_main.c b/dlls/msvcp90/msvcp90_main.c index cb6377f..7a7aafe 100644 --- a/dlls/msvcp90/msvcp90_main.c +++ b/dlls/msvcp90/msvcp90_main.c @@ -84,8 +84,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) switch (fdwReason) { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ case DLL_PROCESS_ATTACH: init_cxx_funcs(); init_lockit();

1 0

Ken Thomases : winemac: Discard old frame changed events when setting frame for off-screen windows , too.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 47352930d8a7caa74d658b8267f3a4add317cd4a URL: http://source.winehq.org/git/wine.git/?a=commit;h=47352930d8a7caa74d658b826… Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Feb 17 19:28:16 2013 -0600 winemac: Discard old frame changed events when setting frame for off-screen windows, too. --- dlls/winemac.drv/cocoa_window.m | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/dlls/winemac.drv/cocoa_window.m b/dlls/winemac.drv/cocoa_window.m index 4371110..2247d32 100644 --- a/dlls/winemac.drv/cocoa_window.m +++ b/dlls/winemac.drv/cocoa_window.m @@ -445,6 +445,14 @@ static inline void fix_generic_modifiers_by_device(NSUInteger* modifiers) event. The back end will ignore it if nothing actually changed. */ [self windowDidResize:nil]; } + else + { + /* The back end is establishing a new window size and position. It's + not interested in any stale events regarding those that may be sitting + in the queue. */ + [queue discardEventsMatchingMask:event_mask_for_type(WINDOW_FRAME_CHANGED) + forWindow:self]; + } return on_screen; }

1 0

Carlo Bramini : windowsx.h: Fix HANDLE_WM_DISPLAYCHANGE macro.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 8fa295ed879b08ee42945b65abb8cee25def6af4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8fa295ed879b08ee42945b65a… Author: Carlo Bramini <carlo.bramix(a)libero.it> Date: Sun Feb 17 12:13:10 2013 +0100 windowsx.h: Fix HANDLE_WM_DISPLAYCHANGE macro. --- include/windowsx.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/windowsx.h b/include/windowsx.h index 0f84622..fa27b49 100644 --- a/include/windowsx.h +++ b/include/windowsx.h @@ -1321,7 +1321,7 @@ extern "C" { /* void Cls_OnDisplayChange(HWND hwnd, UINT bitsPerPixel, UINT cxScreen, UINT cyScreen) */ #define HANDLE_WM_DISPLAYCHANGE(hwnd, wParam, lParam, fn) \ - ((fn)((hwnd), (UINT)(wParam), (UINT)LOWORD(lParam), (UINT)HIWORD(wParam)), 0L) + ((fn)((hwnd), (UINT)(wParam), (UINT)LOWORD(lParam), (UINT)HIWORD(lParam)), 0L) #define FORWARD_WM_DISPLAYCHANGE(hwnd, bitsPerPixel, cxScreen, cyScreen, fn) \ (void)(fn)((hwnd), WM_DISPLAYCHANGE, (WPARAM)(UINT)(bitsPerPixel), (LPARAM)MAKELPARAM((UINT)(cxScreen), (UINT)(cyScreen)))

1 0

Andrew Talbot : mshtml: Avoid signed-unsigned integer comparisons.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: a9200aa99d369fe50d84005aeb51131bee7afa87 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9200aa99d369fe50d84005ae… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Feb 16 21:09:13 2013 +0000 mshtml: Avoid signed-unsigned integer comparisons. --- dlls/mshtml/htmlbody.c | 3 ++- dlls/mshtml/htmlevent.c | 13 ++++++++----- dlls/mshtml/main.c | 2 +- dlls/mshtml/nsio.c | 2 +- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c index e427fc0..f02264e 100644 --- a/dlls/mshtml/htmlbody.c +++ b/dlls/mshtml/htmlbody.c @@ -127,7 +127,8 @@ static int loose_hex_to_rgb(const WCHAR *hex) static HRESULT nscolor_to_str(LPCWSTR color, BSTR *ret) { - int i, rgb = -1; + unsigned int i; + int rgb = -1; static const WCHAR formatW[] = {'#','%','0','2','x','%','0','2','x','%','0','2','x',0}; diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 98e592d..ea0201f 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -929,7 +929,6 @@ static void call_event_handlers(HTMLDocumentNode *doc, HTMLEventObj *event_obj, const BOOL cancelable = event_info[eid].flags & EVENT_CANCELABLE; handler_vector_t *handler_vector = NULL; VARIANT v; - int i; HRESULT hres; if(event_target) @@ -966,6 +965,7 @@ static void call_event_handlers(HTMLDocumentNode *doc, HTMLEventObj *event_obj, if(handler_vector && handler_vector->handler_cnt) { VARIANTARG arg; DISPPARAMS dp = {&arg, NULL, 1, 0}; + int i; V_VT(&arg) = VT_DISPATCH; V_DISPATCH(&arg) = (IDispatch*)event_obj; @@ -1009,16 +1009,18 @@ static void call_event_handlers(HTMLDocumentNode *doc, HTMLEventObj *event_obj, for(cp = cp_container->cp_list; cp; cp = cp->next) { if(cp->sinks_size && is_cp_event(cp->data, event_info[eid].dispid)) { + unsigned int i; + for(i=0; doc->nsevent_listener && i < cp->sinks_size; i++) { if(!cp->sinks[i].disp) continue; V_VT(&v) = VT_EMPTY; - TRACE("cp %s [%d] >>>\n", debugstr_w(event_info[eid].name), i); + TRACE("cp %s [%u] >>>\n", debugstr_w(event_info[eid].name), i); hres = call_cp_func(cp->sinks[i].disp, event_info[eid].dispid, &v); if(hres == S_OK) { - TRACE("cp %s [%d] <<<\n", debugstr_w(event_info[eid].name), i); + TRACE("cp %s [%u] <<<\n", debugstr_w(event_info[eid].name), i); if(cancelable) { if(V_VT(&v) == VT_BOOL) { @@ -1030,7 +1032,7 @@ static void call_event_handlers(HTMLDocumentNode *doc, HTMLEventObj *event_obj, } VariantClear(&v); }else { - WARN("cp %s [%d] <<< %08x\n", debugstr_w(event_info[eid].name), i, hres); + WARN("cp %s [%u] <<< %08x\n", debugstr_w(event_info[eid].name), i, hres); } } @@ -1558,7 +1560,8 @@ HRESULT doc_init_events(HTMLDocumentNode *doc) void release_event_target(event_target_t *event_target) { - int i, j; + int i; + unsigned int j; for(i=0; i < EVENTID_LAST; i++) { if(event_target->event_table[i]) { diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c index 8468f5c..503d738 100644 --- a/dlls/mshtml/main.c +++ b/dlls/mshtml/main.c @@ -67,7 +67,7 @@ static void thread_detach(void) static void free_strings(void) { - int i; + unsigned int i; for(i = 0; i < sizeof(status_strings)/sizeof(*status_strings); i++) heap_free(status_strings[i]); } diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 96191f7..1e8f1bb 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -3229,7 +3229,7 @@ static nsresult NSAPI nsIOService_GetProtocolFlags(nsIIOService *iface, const ch static BOOL is_gecko_special_uri(const char *spec) { static const char *special_schemes[] = {"chrome:", "jar:", "moz-safe-about", "resource:", "javascript:", "wyciwyg:"}; - int i; + unsigned int i; for(i=0; i < sizeof(special_schemes)/sizeof(*special_schemes); i++) { if(!strncasecmp(spec, special_schemes[i], strlen(special_schemes[i])))

1 0

Marcus Meissner : ole32: Free *ppszProgID on error path (Coverity).
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 2dbb23c8109e5c82dfe4221a9b95c8c3d586d384 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2dbb23c8109e5c82dfe4221a9… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Feb 16 17:46:04 2013 +0100 ole32: Free *ppszProgID on error path (Coverity). --- dlls/ole32/compobj.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index dc2a02b..17bd7a1 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -2033,8 +2033,11 @@ HRESULT WINAPI ProgIDFromCLSID(REFCLSID clsid, LPOLESTR *ppszProgID) *ppszProgID = CoTaskMemAlloc(progidlen * sizeof(WCHAR)); if (*ppszProgID) { - if (RegQueryValueW(hkey, NULL, *ppszProgID, &progidlen)) + if (RegQueryValueW(hkey, NULL, *ppszProgID, &progidlen)) { ret = REGDB_E_CLASSNOTREG; + CoTaskMemFree(*ppszProgID); + *ppszProgID = NULL; + } } else ret = E_OUTOFMEMORY;

1 0

Marcus Meissner : kernel32: Use the correct pointer size in atl thunk ( Coverity).
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: fc179497bdb7cf852f2dfd3cd89e681b15511a7c URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc179497bdb7cf852f2dfd3cd… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Feb 16 17:45:31 2013 +0100 kernel32: Use the correct pointer size in atl thunk (Coverity). --- dlls/ntdll/signal_i386.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/signal_i386.c b/dlls/ntdll/signal_i386.c index 05ede34..0344a29 100644 --- a/dlls/ntdll/signal_i386.c +++ b/dlls/ntdll/signal_i386.c @@ -1569,7 +1569,7 @@ static BOOL check_atl_thunk( EXCEPTION_RECORD *rec, CONTEXT *context ) const struct atl_thunk *thunk = (const struct atl_thunk *)rec->ExceptionInformation[1]; BOOL ret = FALSE; - if (!virtual_is_valid_code_address( thunk, sizeof(thunk) )) return FALSE; + if (!virtual_is_valid_code_address( thunk, sizeof(*thunk) )) return FALSE; __TRY {

1 0

Piotr Caban : msvcr90: Prefer builtin version.
by Alexandre Julliard Feb. 18, 2013

Feb. 18, 2013

Module: wine Branch: master Commit: 5d88f780dd4bbbde0ff27075b58321d7347f6d4b URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d88f780dd4bbbde0ff27075b… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Feb 18 10:26:01 2013 +0100 msvcr90: Prefer builtin version. --- dlls/msvcr90/msvcr90.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/msvcr90/msvcr90.c b/dlls/msvcr90/msvcr90.c index 79475e8..de6d86e 100644 --- a/dlls/msvcr90/msvcr90.c +++ b/dlls/msvcr90/msvcr90.c @@ -31,9 +31,6 @@ BOOL WINAPI DllMain(HINSTANCE hdll, DWORD reason, LPVOID reserved) { switch (reason) { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ - case DLL_PROCESS_ATTACH: DisableThreadLibraryCalls(hdll); _set_printf_count_output(0);

1 0