May 2013 - Wine-Commits - list.winehq.org

Nikolay Sivov : comctl32: Use selected image for listbox/ editbox for selected item only.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 4625c399c6d4127196d3578a7b27ef68bcd417af URL: http://source.winehq.org/git/wine.git/?a=commit;h=4625c399c6d4127196d3578a7… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue May 14 10:48:13 2013 +0400 comctl32: Use selected image for listbox/editbox for selected item only. --- dlls/comctl32/comboex.c | 34 ++++++++++++++-------------------- 1 files changed, 14 insertions(+), 20 deletions(-) diff --git a/dlls/comctl32/comboex.c b/dlls/comctl32/comboex.c index 0f3ed4a..cc6115a 100644 --- a/dlls/comctl32/comboex.c +++ b/dlls/comctl32/comboex.c @@ -1316,7 +1316,7 @@ static LRESULT COMBOEX_DrawItem (COMBOEX_INFO *infoPtr, DRAWITEMSTRUCT const *di UINT xbase, x, y; INT len; COLORREF nbkc, ntxc, bkc, txc; - int drawimage, drawstate, xioff; + int drawimage, drawstate, xioff, selected; TRACE("DRAWITEMSTRUCT: CtlType=0x%08x CtlID=0x%08x\n", dis->CtlType, dis->CtlID); @@ -1417,36 +1417,30 @@ static LRESULT COMBOEX_DrawItem (COMBOEX_INFO *infoPtr, DRAWITEMSTRUCT const *di drawimage = -2; drawstate = ILD_NORMAL; + selected = infoPtr->selected == dis->itemID; + if (item->mask & CBEIF_IMAGE) drawimage = item->iImage; + if (item->mask & CBEIF_SELECTEDIMAGE && selected) + drawimage = item->iSelectedImage; if (dis->itemState & ODS_COMBOEXLBOX) { /* drawing listbox entry */ - if (dis->itemState & ODS_SELECTED) { - if (item->mask & CBEIF_SELECTEDIMAGE) - drawimage = item->iSelectedImage; + if (dis->itemState & ODS_SELECTED) drawstate = ILD_SELECTED; - } } else { /* drawing combo/edit entry */ if (IsWindowVisible(infoPtr->hwndEdit)) { /* if we have an edit control, the slave the * selection state to the Edit focus state */ - if (infoPtr->flags & WCBE_EDITFOCUSED) { - if (item->mask & CBEIF_SELECTEDIMAGE) - drawimage = item->iSelectedImage; + if (infoPtr->flags & WCBE_EDITFOCUSED) drawstate = ILD_SELECTED; - } - } else { + } else /* if we don't have an edit control, use * the requested state. */ - if (dis->itemState & ODS_SELECTED) { - if (item->mask & CBEIF_SELECTEDIMAGE) - drawimage = item->iSelectedImage; + if (dis->itemState & ODS_SELECTED) drawstate = ILD_SELECTED; - } - } } if (infoPtr->himl && !(infoPtr->dwExtStyle & CBES_EX_NOEDITIMAGEINDENT)) { @@ -1469,17 +1463,17 @@ static LRESULT COMBOEX_DrawItem (COMBOEX_INFO *infoPtr, DRAWITEMSTRUCT const *di if (drawimage == I_IMAGECALLBACK) { NMCOMBOBOXEXW nmce; ZeroMemory(&nmce, sizeof(nmce)); - nmce.ceItem.mask = (drawstate == ILD_NORMAL) ? CBEIF_IMAGE : CBEIF_SELECTEDIMAGE; + nmce.ceItem.mask = selected ? CBEIF_SELECTEDIMAGE : CBEIF_IMAGE; nmce.ceItem.lParam = item->lParam; nmce.ceItem.iItem = dis->itemID; COMBOEX_NotifyItem(infoPtr, CBEN_GETDISPINFOW, &nmce); - if (drawstate == ILD_NORMAL) { + if (!selected) { if (nmce.ceItem.mask & CBEIF_DI_SETITEM) item->iImage = nmce.ceItem.iImage; drawimage = nmce.ceItem.iImage; - } else if (drawstate == ILD_SELECTED) { + } else { if (nmce.ceItem.mask & CBEIF_DI_SETITEM) item->iSelectedImage = nmce.ceItem.iSelectedImage; - drawimage = nmce.ceItem.iSelectedImage; - } else ERR("Bad draw state = %d\n", drawstate); + drawimage = nmce.ceItem.iSelectedImage; + } } if (overlay == I_IMAGECALLBACK) {

1 0

Alexandre Julliard : ieframe: Don' t bother to unregister classes at process exit.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 79fe2daafb261939bda89e617991eb851dd779bf URL: http://source.winehq.org/git/wine.git/?a=commit;h=79fe2daafb261939bda89e617… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue May 14 11:15:32 2013 +0200 ieframe: Don't bother to unregister classes at process exit. --- dlls/ieframe/ieframe_main.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/ieframe/ieframe_main.c b/dlls/ieframe/ieframe_main.c index 7c0b37b..ffba1d7 100644 --- a/dlls/ieframe/ieframe_main.c +++ b/dlls/ieframe/ieframe_main.c @@ -218,6 +218,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) DisableThreadLibraryCalls(ieframe_instance); break; case DLL_PROCESS_DETACH: + if (lpv) break; unregister_iewindow_class(); release_typelib(); }

1 0

Alexandre Julliard : riched20: Don' t bother to unregister classes at process exit.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 85f882856053cbc5e51a1e94ed39146bc47700ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=85f882856053cbc5e51a1e94e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue May 14 11:19:48 2013 +0200 riched20: Don't bother to unregister classes at process exit. --- dlls/riched20/editor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 1b4788c..f54458e 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -2843,6 +2843,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) break; case DLL_PROCESS_DETACH: + if (lpvReserved) break; UnregisterClassW(RICHEDIT_CLASS20W, 0); UnregisterClassW(MSFTEDIT_CLASS, 0); UnregisterClassA(RICHEDIT_CLASS20A, 0); @@ -2853,7 +2854,6 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) UnregisterClassW(REComboBox20W, 0); LookupCleanup(); HeapDestroy (me_heap); - me_heap = NULL; break; } return TRUE;

1 0

Stefan Dösinger : wined3d: Don' t access the stateblock from shader_arb_load_constants_internal.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 5d138799ea5e901a51ac266a69c44d0bd6c22686 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5d138799ea5e901a51ac266a6… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue May 14 17:38:16 2013 +0200 wined3d: Don't access the stateblock from shader_arb_load_constants_internal. --- dlls/wined3d/arb_program_shader.c | 27 +++++++++++++-------------- 1 files changed, 13 insertions(+), 14 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 6756927..a7dc253 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -650,24 +650,20 @@ static void shader_arb_select(const struct wined3d_context *context, enum wined3 * worry about the Integers or Booleans */ /* Context activation is done by the caller (state handler). */ -static void shader_arb_load_constants_internal(const struct wined3d_context *context, +static void shader_arb_load_constants_internal(struct shader_arb_priv *priv, + const struct wined3d_context *context, const struct wined3d_state *state, BOOL usePixelShader, BOOL useVertexShader, BOOL from_shader_select) { - struct wined3d_device *device = context->swapchain->device; - const struct wined3d_stateblock *stateblock = device->stateBlock; - const struct wined3d_state *state = &stateblock->state; - const struct wined3d_gl_info *gl_info = context->gl_info; const struct wined3d_d3d_info *d3d_info = context->d3d_info; - struct shader_arb_priv *priv = device->shader_priv; + const struct wined3d_gl_info *gl_info = context->gl_info; if (!from_shader_select) { const struct wined3d_shader *vshader = state->vertex_shader, *pshader = state->pixel_shader; if (vshader - && (stateblock->changed.vertexShaderConstantsB & vshader->reg_maps.boolean_constants + && (vshader->reg_maps.boolean_constants || (!gl_info->supported[NV_VERTEX_PROGRAM2_OPTION] - && (stateblock->changed.vertexShaderConstantsI - & vshader->reg_maps.integer_constants & ~vshader->reg_maps.local_int_consts)))) + && (vshader->reg_maps.integer_constants & ~vshader->reg_maps.local_int_consts)))) { TRACE("bool/integer vertex shader constants potentially modified, forcing shader reselection.\n"); shader_arb_select(context, @@ -675,10 +671,9 @@ static void shader_arb_load_constants_internal(const struct wined3d_context *con usePixelShader ? WINED3D_SHADER_MODE_SHADER : WINED3D_SHADER_MODE_FFP); } else if (pshader - && (stateblock->changed.pixelShaderConstantsB & pshader->reg_maps.boolean_constants + && (pshader->reg_maps.boolean_constants || (!gl_info->supported[NV_FRAGMENT_PROGRAM_OPTION] - && (stateblock->changed.pixelShaderConstantsI - & pshader->reg_maps.integer_constants & ~pshader->reg_maps.local_int_consts)))) + && (pshader->reg_maps.integer_constants & ~pshader->reg_maps.local_int_consts)))) { TRACE("bool/integer pixel shader constants potentially modified, forcing shader reselection.\n"); shader_arb_select(context, @@ -726,7 +721,11 @@ static void shader_arb_load_constants_internal(const struct wined3d_context *con static void shader_arb_load_constants(const struct wined3d_context *context, BOOL ps, BOOL vs) { - shader_arb_load_constants_internal(context, ps, vs, FALSE); + struct wined3d_device *device = context->swapchain->device; + const struct wined3d_stateblock *stateblock = device->stateBlock; + const struct wined3d_state *state = &stateblock->state; + + shader_arb_load_constants_internal(device->shader_priv, context, state, ps, vs, FALSE); } static void shader_arb_update_float_vertex_constants(struct wined3d_device *device, UINT start, UINT count) @@ -4654,7 +4653,7 @@ static void shader_arb_select(const struct wined3d_context *context, enum wined3 priv->pshader_const_dirty[i] = 1; } /* Also takes care of loading local constants */ - shader_arb_load_constants_internal(context, TRUE, FALSE, TRUE); + shader_arb_load_constants_internal(device->shader_priv, context, state, TRUE, FALSE, TRUE); } else {

1 0

Stefan Dösinger : wined3d: Pass the state and private data to shader_select.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 6fce4d45474d1d933d04264b12869bd9a6a485b6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6fce4d45474d1d933d04264b1… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue May 14 17:38:19 2013 +0200 wined3d: Pass the state and private data to shader_select. --- dlls/wined3d/arb_program_shader.c | 25 ++++++++++--------------- dlls/wined3d/context.c | 4 +--- dlls/wined3d/glsl_shader.c | 28 +++++++++++++--------------- dlls/wined3d/shader.c | 11 +++++------ dlls/wined3d/wined3d_private.h | 10 ++-------- 5 files changed, 31 insertions(+), 47 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6fce4d45474d1d933d042…

1 0

Stefan Dösinger : wined3d: Disable the fixed function vertex pipeline when ARB vertex programs are used .
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 71723ad086c6f49b6bc367e86d3dc2944f6f13a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=71723ad086c6f49b6bc367e86… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue May 14 17:38:20 2013 +0200 wined3d: Disable the fixed function vertex pipeline when ARB vertex programs are used. --- dlls/wined3d/arb_program_shader.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index bfade73..ccd8ee3 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -4701,6 +4701,8 @@ static void shader_arb_select(void *shader_priv, const struct wined3d_context *c GL_EXTCALL(glBindProgramARB(GL_VERTEX_PROGRAM_ARB, priv->current_vprogram_id)); checkGLcall("glBindProgramARB(GL_VERTEX_PROGRAM_ARB, priv->current_vprogram_id);"); + priv->vertex_pipe->vp_enable(gl_info, FALSE); + /* Enable OpenGL vertex programs */ gl_info->gl_ops.gl.p_glEnable(GL_VERTEX_PROGRAM_ARB); checkGLcall("glEnable(GL_VERTEX_PROGRAM_ARB);");

1 0

Stefan Dösinger : wined3d: Add a separate function for disabling shaders.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 47f385adf0f8c764600740c6e19746556a9ed84b URL: http://source.winehq.org/git/wine.git/?a=commit;h=47f385adf0f8c764600740c6e… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue May 14 17:38:18 2013 +0200 wined3d: Add a separate function for disabling shaders. --- dlls/wined3d/arb_program_shader.c | 41 ++++++++++++++++++++++++++++++++++-- dlls/wined3d/context.c | 4 +- dlls/wined3d/glsl_shader.c | 29 ++++++++++++++++++++++--- dlls/wined3d/shader.c | 14 +++++++++++- dlls/wined3d/wined3d_private.h | 2 +- 5 files changed, 79 insertions(+), 11 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=47f385adf0f8c76460074…

1 0

Stefan Dösinger : wined3d: Explicitly pass the state to shader_load_constants.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: 036a62a245b39ccb294bd5ce4635563314ac34d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=036a62a245b39ccb294bd5ce4… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue May 14 17:38:17 2013 +0200 wined3d: Explicitly pass the state to shader_load_constants. --- dlls/wined3d/arb_program_shader.c | 10 +++++----- dlls/wined3d/context.c | 3 ++- dlls/wined3d/glsl_shader.c | 21 +++++++++------------ dlls/wined3d/shader.c | 3 ++- dlls/wined3d/wined3d_private.h | 4 +++- 5 files changed, 21 insertions(+), 20 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index a7dc253..d7959cf 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -719,13 +719,13 @@ static void shader_arb_load_constants_internal(struct shader_arb_priv *priv, } } -static void shader_arb_load_constants(const struct wined3d_context *context, BOOL ps, BOOL vs) +static void shader_arb_load_constants(void *shader_priv, const struct wined3d_context *context, + const struct wined3d_state *state) { - struct wined3d_device *device = context->swapchain->device; - const struct wined3d_stateblock *stateblock = device->stateBlock; - const struct wined3d_state *state = &stateblock->state; + BOOL vs = use_vs(state); + BOOL ps = use_ps(state); - shader_arb_load_constants_internal(device->shader_priv, context, state, ps, vs, FALSE); + shader_arb_load_constants_internal(shader_priv, context, state, ps, vs, FALSE); } static void shader_arb_update_float_vertex_constants(struct wined3d_device *device, UINT start, UINT count) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 6d30f1c..3cfdb04 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -2411,7 +2411,8 @@ BOOL context_apply_draw_state(struct wined3d_context *context, struct wined3d_de if (context->load_constants) { - device->shader_backend->shader_load_constants(context, use_ps(state), use_vs(state)); + device->shader_backend->shader_load_constants(device->shader_priv, + context, state); context->load_constants = 0; } diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 16054ed..674f263 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -725,14 +725,11 @@ static void shader_glsl_load_np2fixup_constants(void *shader_priv, } /* Context activation is done by the caller (state handler). */ -static void shader_glsl_load_constants(const struct wined3d_context *context, - BOOL usePixelShader, BOOL useVertexShader) +static void shader_glsl_load_constants(void *shader_priv, const struct wined3d_context *context, + const struct wined3d_state *state) { const struct wined3d_gl_info *gl_info = context->gl_info; - struct wined3d_device *device = context->swapchain->device; - struct wined3d_stateblock *stateBlock = device->stateBlock; - const struct wined3d_state *state = &stateBlock->state; - struct shader_glsl_priv *priv = device->shader_priv; + struct shader_glsl_priv *priv = shader_priv; float position_fixup[4]; GLhandleARB programId; @@ -747,7 +744,7 @@ static void shader_glsl_load_constants(const struct wined3d_context *context, programId = prog->programId; constant_version = prog->constant_version; - if (useVertexShader) + if (use_vs(state)) { const struct wined3d_shader *vshader = state->vertex_shader; @@ -757,11 +754,11 @@ static void shader_glsl_load_constants(const struct wined3d_context *context, /* Load DirectX 9 integer constants/uniforms for vertex shader */ shader_glsl_load_constantsI(vshader, gl_info, prog->vs.uniform_i_locations, state->vs_consts_i, - stateBlock->changed.vertexShaderConstantsI & vshader->reg_maps.integer_constants); + vshader->reg_maps.integer_constants); /* Load DirectX 9 boolean constants/uniforms for vertex shader */ shader_glsl_load_constantsB(vshader, gl_info, programId, state->vs_consts_b, - stateBlock->changed.vertexShaderConstantsB & vshader->reg_maps.boolean_constants); + vshader->reg_maps.boolean_constants); /* Upload the position fixup params */ shader_get_position_fixup(context, state, position_fixup); @@ -769,7 +766,7 @@ static void shader_glsl_load_constants(const struct wined3d_context *context, checkGLcall("glUniform4fvARB"); } - if (usePixelShader) + if (use_ps(state)) { const struct wined3d_shader *pshader = state->pixel_shader; @@ -779,11 +776,11 @@ static void shader_glsl_load_constants(const struct wined3d_context *context, /* Load DirectX 9 integer constants/uniforms for pixel shader */ shader_glsl_load_constantsI(pshader, gl_info, prog->ps.uniform_i_locations, state->ps_consts_i, - stateBlock->changed.pixelShaderConstantsI & pshader->reg_maps.integer_constants); + pshader->reg_maps.integer_constants); /* Load DirectX 9 boolean constants/uniforms for pixel shader */ shader_glsl_load_constantsB(pshader, gl_info, programId, state->ps_consts_b, - stateBlock->changed.pixelShaderConstantsB & pshader->reg_maps.boolean_constants); + pshader->reg_maps.boolean_constants); /* Upload the environment bump map matrix if needed. The needsbumpmat * member specifies the texture stage to load the matrix from. It diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index d9528d2..515caed 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1509,7 +1509,8 @@ static void shader_none_select_depth_blt(void *shader_priv, const struct wined3d static void shader_none_deselect_depth_blt(void *shader_priv, const struct wined3d_gl_info *gl_info) {} static void shader_none_update_float_vertex_constants(struct wined3d_device *device, UINT start, UINT count) {} static void shader_none_update_float_pixel_constants(struct wined3d_device *device, UINT start, UINT count) {} -static void shader_none_load_constants(const struct wined3d_context *context, BOOL usePS, BOOL useVS) {} +static void shader_none_load_constants(void *shader_priv, const struct wined3d_context *context, + const struct wined3d_state *state) {} static void shader_none_load_np2fixup_constants(void *shader_priv, const struct wined3d_gl_info *gl_info, const struct wined3d_state *state) {} static void shader_none_destroy(struct wined3d_shader *shader) {} diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index abf44c9..9af9e79 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -5,6 +5,7 @@ * Copyright 2002-2003 Raphael Junqueira * Copyright 2002-2003, 2004 Jason Edmeades * Copyright 2005 Oliver Stieber + * Copyright 2006-2011, 2013 Stefan Dösinger for CodeWeavers * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -806,7 +807,8 @@ struct wined3d_shader_backend_ops void (*shader_deselect_depth_blt)(void *shader_priv, const struct wined3d_gl_info *gl_info); void (*shader_update_float_vertex_constants)(struct wined3d_device *device, UINT start, UINT count); void (*shader_update_float_pixel_constants)(struct wined3d_device *device, UINT start, UINT count); - void (*shader_load_constants)(const struct wined3d_context *context, BOOL usePS, BOOL useVS); + void (*shader_load_constants)(void *shader_priv, const struct wined3d_context *context, + const struct wined3d_state *state); void (*shader_load_np2fixup_constants)(void *shader_priv, const struct wined3d_gl_info *gl_info, const struct wined3d_state *state); void (*shader_destroy)(struct wined3d_shader *shader);

1 0

Hans Leidekker : wmiutils: Accept namespaces without a leading slash.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: d816192eccbe48b26a345e3887aeb8b19da3aa8f URL: http://source.winehq.org/git/wine.git/?a=commit;h=d816192eccbe48b26a345e388… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue May 14 14:01:08 2013 +0200 wmiutils: Accept namespaces without a leading slash. --- dlls/wmiutils/path.c | 17 +++++++++++++++++ dlls/wmiutils/tests/path.c | 15 ++++++++++++++- 2 files changed, 31 insertions(+), 1 deletions(-) diff --git a/dlls/wmiutils/path.c b/dlls/wmiutils/path.c index dcade46..988d2e6 100644 --- a/dlls/wmiutils/path.c +++ b/dlls/wmiutils/path.c @@ -420,6 +420,11 @@ static HRESULT parse_text( struct path *path, ULONG mode, const WCHAR *text ) path->flags |= WBEMPATH_INFO_PATH_HAD_SERVER; } p = q; + if (*q && *q != '\\' && *q != '/' && *q != ':') + { + path->num_namespaces = 1; + q++; + } while (*q && *q != ':') { if (*q == '\\' || *q == '/') path->num_namespaces++; @@ -432,6 +437,18 @@ static HRESULT parse_text( struct path *path, ULONG mode, const WCHAR *text ) i = 0; q = p; + if (*q && *q != '\\' && *q != '/' && *q != ':') + { + p = q; + while (*p && *p != '\\' && *p != '/' && *p != ':') p++; + len = p - q; + if (!(path->namespaces[i] = heap_alloc( (len + 1) * sizeof(WCHAR) ))) goto done; + memcpy( path->namespaces[i], q, len * sizeof(WCHAR) ); + path->namespaces[i][len] = 0; + path->len_namespaces[i] = len; + q = p; + i++; + } while (*q && *q != ':') { if (*q == '\\' || *q == '/') diff --git a/dlls/wmiutils/tests/path.c b/dlls/wmiutils/tests/path.c index 935ee52..54c0e9a 100644 --- a/dlls/wmiutils/tests/path.c +++ b/dlls/wmiutils/tests/path.c @@ -122,7 +122,8 @@ static void test_IWbemPath_SetText(void) { path8, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS + 1, S_OK }, { path9, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK }, { path10, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, WBEM_E_INVALID_PARAMETER, 1 }, - { path11, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK } + { path11, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK }, + { path15, WBEMPATH_CREATE_ACCEPT_ALL, S_OK } }; IWbemPath *path; HRESULT hr; @@ -167,6 +168,8 @@ static void test_IWbemPath_GetText(void) static const WCHAR expected2W[] = {'W','i','n','3','2','_','L','o','g','i','c','a','l','D','i','s','k','.', 'D','e','v','i','c','e','I','d','=','"','C',':','"',0}; + static const WCHAR expected3W[] = + {'\\','\\','.','\\','r','o','o','t','\\','c','i','m','v','2',0}; WCHAR buf[128]; ULONG len, count; IWbemPath *path; @@ -306,6 +309,16 @@ static void test_IWbemPath_GetText(void) ok( !lstrcmpW( buf, expected2W ), "unexpected buffer contents %s\n", wine_dbgstr_w(buf) ); ok( len == lstrlenW( expected2W ) + 1, "unexpected length %u\n", len ); + hr = IWbemPath_SetText( path, WBEMPATH_CREATE_ACCEPT_ALL, path15 ); + ok( hr == S_OK, "got %08x\n", hr ); + + len = sizeof(buf)/sizeof(buf[0]); + memset( buf, 0x55, sizeof(buf) ); + hr = IWbemPath_GetText( path, WBEMPATH_GET_SERVER_TOO, &len, buf ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( !lstrcmpW( buf, expected3W ), "unexpected buffer contents %s\n", wine_dbgstr_w(buf) ); + ok( len == lstrlenW( expected3W ) + 1, "unexpected length %u\n", len ); + hr = IWbemPath_SetText( path, WBEMPATH_CREATE_ACCEPT_ALL, path18 ); ok( hr == S_OK, "got %08x\n", hr );

1 0

Alistair Leslie-Hughes : oledb32: Implement DataConvert DBTYPE_BYTES-> DBTYPE_BYTES.
by Alexandre Julliard May 14, 2013

May 14, 2013

Module: wine Branch: master Commit: c476d1785e3aece8eccb611b3086f0d7064599bd URL: http://source.winehq.org/git/wine.git/?a=commit;h=c476d1785e3aece8eccb611b3… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Apr 18 11:22:47 2013 +1000 oledb32: Implement DataConvert DBTYPE_BYTES->DBTYPE_BYTES. --- dlls/oledb32/convert.c | 20 ++++++++++++++++++++ dlls/oledb32/tests/convert.c | 24 ++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 0 deletions(-) diff --git a/dlls/oledb32/convert.c b/dlls/oledb32/convert.c index 65a2bf6..1f50202 100644 --- a/dlls/oledb32/convert.c +++ b/dlls/oledb32/convert.c @@ -794,6 +794,26 @@ static HRESULT WINAPI convert_DataConvert(IDataConvert* iface, } break; } + case DBTYPE_BYTES: + { + BYTE *d = dst; + + switch(src_type) + { + case DBTYPE_BYTES: + if( src_len > dst_max_len) + *dst_status = DBSTATUS_S_TRUNCATED; + else + *dst_status = DBSTATUS_S_OK; + + *dst_len = src_len; + memcpy(d, src, min(src_len, dst_max_len)); + + return S_OK; + default: FIXME("Unimplemented conversion %04x -> DBTYPE_BYTES\n", src_type); return E_NOTIMPL; + } + break; + } default: FIXME("Unimplemented conversion %04x -> %04x\n", src_type, dst_type); diff --git a/dlls/oledb32/tests/convert.c b/dlls/oledb32/tests/convert.c index 64562b1..b4331b1 100644 --- a/dlls/oledb32/tests/convert.c +++ b/dlls/oledb32/tests/convert.c @@ -2424,6 +2424,29 @@ static void test_getconversionsize(void) } +static void test_converttobytes(void) +{ + DBLENGTH dst_len; + HRESULT hr; + BYTE byte_src[] = {0, 1, 2, 4, 5}; + BYTE dst[10] = {0}; + DBSTATUS dst_status; + + dst_len = 0; + hr = IDataConvert_DataConvert(convert, DBTYPE_BYTES, DBTYPE_BYTES, sizeof(byte_src), &dst_len, byte_src, &dst, sizeof(dst), 0, &dst_status, 0, 0, 0); + ok(hr == S_OK, "got %08x\n", hr); + ok(dst_status == DBSTATUS_S_OK, "got %08x\n", dst_status); + ok(dst_len == sizeof(byte_src), "got %ld\n", dst_len); + ok(!memcmp(byte_src, dst, dst_len ), "bytes differ\n"); + + dst_len = 0; + hr = IDataConvert_DataConvert(convert, DBTYPE_BYTES, DBTYPE_BYTES, sizeof(byte_src), &dst_len, byte_src, &dst, 2, 0, &dst_status, 0, 0, 0); + ok(hr == S_OK, "got %08x\n", hr); + ok(dst_status == DBSTATUS_S_TRUNCATED, "got %08x\n", dst_status); + ok(dst_len == sizeof(byte_src), "got %ld\n", dst_len); + ok(!memcmp(byte_src, dst, 2 ), "bytes differ\n"); +} + static void test_converttovar(void) { static WCHAR strW[] = {'t','e','s','t',0}; @@ -2559,6 +2582,7 @@ START_TEST(convert) test_converttocy(); test_converttoui8(); test_converttovar(); + test_converttobytes(); test_getconversionsize(); IDataConvert_Release(convert);

1 0