January 2014 - Wine-Commits

Andrey Gusev : d3dcompiler: Correct filename string.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 7ad3b863dc8d2b73a69b3290cbe3c44db357fcd6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ad3b863dc8d2b73a69b3290c… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Mon Jan 6 16:19:28 2014 +0200 d3dcompiler: Correct filename string. --- dlls/d3dcompiler_33/version.rc | 2 +- dlls/d3dcompiler_34/version.rc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3dcompiler_33/version.rc b/dlls/d3dcompiler_33/version.rc index 11d0618..880a0b5 100644 --- a/dlls/d3dcompiler_33/version.rc +++ b/dlls/d3dcompiler_33/version.rc @@ -18,7 +18,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DCompiler" -#define WINE_FILENAME_STR "d3dcompiler_1.dll" +#define WINE_FILENAME_STR "d3dcompiler_33.dll" #define WINE_FILEVERSION 9,18,904,15 #define WINE_FILEVERSION_STR "9.18.904.0015" #define WINE_PRODUCTVERSION 9,18,904,15 diff --git a/dlls/d3dcompiler_34/version.rc b/dlls/d3dcompiler_34/version.rc index 8e89a96..b4f9788 100644 --- a/dlls/d3dcompiler_34/version.rc +++ b/dlls/d3dcompiler_34/version.rc @@ -18,7 +18,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DCompiler" -#define WINE_FILENAME_STR "d3dcompiler_1.dll" +#define WINE_FILENAME_STR "d3dcompiler_34.dll" #define WINE_FILEVERSION 9,19,949,46 #define WINE_FILEVERSION_STR "9.19.949.0046" #define WINE_PRODUCTVERSION 9,19,949,46

1 0

Nikolay Sivov : scrrun: Added stub NewEnum support for IFileCollection.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 0920a3296ee68d07276d83b0db1f4865af102102 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0920a3296ee68d07276d83b0d… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 7 03:24:41 2014 +0400 scrrun: Added stub NewEnum support for IFileCollection. --- dlls/scrrun/filesystem.c | 87 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 85 insertions(+), 2 deletions(-) diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c index c61020d..94d894f 100644 --- a/dlls/scrrun/filesystem.c +++ b/dlls/scrrun/filesystem.c @@ -47,6 +47,10 @@ struct enumdata { HANDLE find; BSTR path; } foldercoll; + struct + { + IFileCollection *coll; + } filecoll; } u; }; @@ -592,6 +596,80 @@ static HRESULT create_foldercoll_enum(struct foldercollection *collection, IUnkn return S_OK; } +static ULONG WINAPI filecoll_enumvariant_Release(IEnumVARIANT *iface) +{ + struct enumvariant *This = impl_from_IEnumVARIANT(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p)->(%d)\n", This, ref); + + if (!ref) + { + IFileCollection_Release(This->data.u.filecoll.coll); + heap_free(This); + } + + return ref; +} + +static HRESULT WINAPI filecoll_enumvariant_Next(IEnumVARIANT *iface, ULONG celt, VARIANT *var, ULONG *fetched) +{ + struct enumvariant *This = impl_from_IEnumVARIANT(iface); + FIXME("(%p)->(%d %p %p): stub\n", This, celt, var, fetched); + return E_NOTIMPL; +} + +static HRESULT WINAPI filecoll_enumvariant_Skip(IEnumVARIANT *iface, ULONG celt) +{ + struct enumvariant *This = impl_from_IEnumVARIANT(iface); + FIXME("(%p)->(%d): stub\n", This, celt); + return E_NOTIMPL; +} + +static HRESULT WINAPI filecoll_enumvariant_Reset(IEnumVARIANT *iface) +{ + struct enumvariant *This = impl_from_IEnumVARIANT(iface); + FIXME("(%p): stub\n", This); + return E_NOTIMPL; +} + +static HRESULT WINAPI filecoll_enumvariant_Clone(IEnumVARIANT *iface, IEnumVARIANT **pclone) +{ + struct enumvariant *This = impl_from_IEnumVARIANT(iface); + FIXME("(%p)->(%p): stub\n", This, pclone); + return E_NOTIMPL; +} + +static const IEnumVARIANTVtbl filecollenumvariantvtbl = { + enumvariant_QueryInterface, + enumvariant_AddRef, + filecoll_enumvariant_Release, + filecoll_enumvariant_Next, + filecoll_enumvariant_Skip, + filecoll_enumvariant_Reset, + filecoll_enumvariant_Clone +}; + +static HRESULT create_filecoll_enum(struct filecollection *collection, IUnknown **newenum) +{ + struct enumvariant *This; + + *newenum = NULL; + + This = heap_alloc(sizeof(*This)); + if (!This) return E_OUTOFMEMORY; + + This->IEnumVARIANT_iface.lpVtbl = &filecollenumvariantvtbl; + This->ref = 1; + + This->data.u.filecoll.coll = &collection->IFileCollection_iface; + IFileCollection_AddRef(This->data.u.filecoll.coll); + + *newenum = (IUnknown*)&This->IEnumVARIANT_iface; + + return S_OK; +} + static HRESULT WINAPI foldercoll_QueryInterface(IFolderCollection *iface, REFIID riid, void **obj) { struct foldercollection *This = impl_from_IFolderCollection(iface); @@ -899,8 +977,13 @@ static HRESULT WINAPI filecoll_get_Item(IFileCollection *iface, VARIANT Key, IFi static HRESULT WINAPI filecoll_get__NewEnum(IFileCollection *iface, IUnknown **ppenum) { struct filecollection *This = impl_from_IFileCollection(iface); - FIXME("(%p)->(%p)\n", This, ppenum); - return E_NOTIMPL; + + TRACE("(%p)->(%p)\n", This, ppenum); + + if(!ppenum) + return E_POINTER; + + return create_filecoll_enum(This, ppenum); } static HRESULT WINAPI filecoll_get_Count(IFileCollection *iface, LONG *count)

1 0

Nikolay Sivov : scrrun: Implement Name() property for File.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 3ee9f2407b8fede4ddcfbf455660488b2ae856e0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3ee9f2407b8fede4ddcfbf455… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 7 03:25:48 2014 +0400 scrrun: Implement Name() property for File. --- dlls/scrrun/filesystem.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c index a2562ef..1c0c6c3 100644 --- a/dlls/scrrun/filesystem.c +++ b/dlls/scrrun/filesystem.c @@ -1559,11 +1559,29 @@ static HRESULT WINAPI file_get_Path(IFile *iface, BSTR *pbstrPath) return E_NOTIMPL; } -static HRESULT WINAPI file_get_Name(IFile *iface, BSTR *pbstrName) +static HRESULT WINAPI file_get_Name(IFile *iface, BSTR *name) { struct file *This = impl_from_IFile(iface); - FIXME("(%p)->(%p)\n", This, pbstrName); - return E_NOTIMPL; + WCHAR *ptr; + + TRACE("(%p)->(%p)\n", This, name); + + if(!name) + return E_POINTER; + + *name = NULL; + + ptr = strrchrW(This->path, '\\'); + if (ptr) + { + *name = SysAllocString(ptr+1); + TRACE("%s\n", debugstr_w(*name)); + if (!*name) return E_OUTOFMEMORY; + } + else + return E_FAIL; + + return S_OK; } static HRESULT WINAPI file_put_Name(IFile *iface, BSTR pbstrName)

1 0

Michael Stefaniuc : dmime: Remove duplicated "IDirectMusicSegment8" from the method names.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: c236bddcef0a6f12bb2d4202ebb4a0576f1300ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=c236bddcef0a6f12bb2d4202e… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jan 7 10:37:48 2014 +0100 dmime: Remove duplicated "IDirectMusicSegment8" from the method names. --- dlls/dmime/segment.c | 190 +++++++++++++++++++++++++++++++++----------------- 1 file changed, 126 insertions(+), 64 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c236bddcef0a6f12bb2d4…

1 0

Andrey Gusev : d3dx9_xx: Correct filename string.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 4ec773a0991cc6bacb7e57999ecb531f46db21f6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4ec773a0991cc6bacb7e57999… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Mon Jan 6 16:21:02 2014 +0200 d3dx9_xx: Correct filename string. --- dlls/d3dx9_24/version.rc | 2 +- dlls/d3dx9_25/version.rc | 2 +- dlls/d3dx9_26/version.rc | 2 +- dlls/d3dx9_27/version.rc | 2 +- dlls/d3dx9_28/version.rc | 2 +- dlls/d3dx9_29/version.rc | 2 +- dlls/d3dx9_30/version.rc | 2 +- dlls/d3dx9_31/version.rc | 2 +- dlls/d3dx9_32/version.rc | 2 +- dlls/d3dx9_33/version.rc | 2 +- dlls/d3dx9_34/version.rc | 2 +- dlls/d3dx9_35/version.rc | 2 +- dlls/d3dx9_36/version.rc | 2 +- dlls/d3dx9_37/version.rc | 2 +- dlls/d3dx9_38/version.rc | 2 +- dlls/d3dx9_39/version.rc | 2 +- dlls/d3dx9_40/version.rc | 2 +- dlls/d3dx9_41/version.rc | 2 +- dlls/d3dx9_42/version.rc | 2 +- dlls/d3dx9_43/version.rc | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/dlls/d3dx9_24/version.rc b/dlls/d3dx9_24/version.rc index 8deff20..80a48cb 100644 --- a/dlls/d3dx9_24/version.rc +++ b/dlls/d3dx9_24/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_24.dll" #define WINE_FILEVERSION 9,5,132,0 #define WINE_FILEVERSION_STR "9.5.132.0" #define WINE_PRODUCTVERSION 9,5,132,0 diff --git a/dlls/d3dx9_25/version.rc b/dlls/d3dx9_25/version.rc index 922770c..6f89654 100644 --- a/dlls/d3dx9_25/version.rc +++ b/dlls/d3dx9_25/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_25.dll" #define WINE_FILEVERSION 9,6,168,0 #define WINE_FILEVERSION_STR "9.6.168.0" #define WINE_PRODUCTVERSION 9,6,168,0 diff --git a/dlls/d3dx9_26/version.rc b/dlls/d3dx9_26/version.rc index 56edd13..0497ee5 100644 --- a/dlls/d3dx9_26/version.rc +++ b/dlls/d3dx9_26/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_26.dll" #define WINE_FILEVERSION 9,7,239,0 #define WINE_FILEVERSION_STR "9.7.239.0" #define WINE_PRODUCTVERSION 9,7,239,0 diff --git a/dlls/d3dx9_27/version.rc b/dlls/d3dx9_27/version.rc index 82be05e..0ecef4b 100644 --- a/dlls/d3dx9_27/version.rc +++ b/dlls/d3dx9_27/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_27.dll" #define WINE_FILEVERSION 9,8,299,0 #define WINE_FILEVERSION_STR "9.8.299.0" #define WINE_PRODUCTVERSION 9,8,299,0 diff --git a/dlls/d3dx9_28/version.rc b/dlls/d3dx9_28/version.rc index 0f61f70..67f9e55 100644 --- a/dlls/d3dx9_28/version.rc +++ b/dlls/d3dx9_28/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_28.dll" #define WINE_FILEVERSION 9,10,455,0 #define WINE_FILEVERSION_STR "9.10.455.0" #define WINE_PRODUCTVERSION 9,10,455,0 diff --git a/dlls/d3dx9_29/version.rc b/dlls/d3dx9_29/version.rc index f6f7b13..8fcd63d 100644 --- a/dlls/d3dx9_29/version.rc +++ b/dlls/d3dx9_29/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_29.dll" #define WINE_FILEVERSION 9,11,519,0 #define WINE_FILEVERSION_STR "9.11.519.0" #define WINE_PRODUCTVERSION 9,11,519,0 diff --git a/dlls/d3dx9_30/version.rc b/dlls/d3dx9_30/version.rc index b10286e..575cbfe 100644 --- a/dlls/d3dx9_30/version.rc +++ b/dlls/d3dx9_30/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_30.dll" #define WINE_FILEVERSION 9,12,589,0 #define WINE_FILEVERSION_STR "9.12.589.0" #define WINE_PRODUCTVERSION 9,12,589,0 diff --git a/dlls/d3dx9_31/version.rc b/dlls/d3dx9_31/version.rc index eb97454..b9d5432 100644 --- a/dlls/d3dx9_31/version.rc +++ b/dlls/d3dx9_31/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_31.dll" #define WINE_FILEVERSION 9,15,779,0 #define WINE_FILEVERSION_STR "9.15.779.0" #define WINE_PRODUCTVERSION 9,15,779,0 diff --git a/dlls/d3dx9_32/version.rc b/dlls/d3dx9_32/version.rc index 330f8be..ca1ebde 100644 --- a/dlls/d3dx9_32/version.rc +++ b/dlls/d3dx9_32/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_32.dll" #define WINE_FILEVERSION 9,16,843,0 #define WINE_FILEVERSION_STR "9.16.843.0" #define WINE_PRODUCTVERSION 9,16,843,0 diff --git a/dlls/d3dx9_33/version.rc b/dlls/d3dx9_33/version.rc index 06eba53..2de5aa0 100644 --- a/dlls/d3dx9_33/version.rc +++ b/dlls/d3dx9_33/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_33.dll" #define WINE_FILEVERSION 9,18,904,15 #define WINE_FILEVERSION_STR "9.18.904.15" #define WINE_PRODUCTVERSION 9,18,904,15 diff --git a/dlls/d3dx9_34/version.rc b/dlls/d3dx9_34/version.rc index 5045d8f..f5385d1 100644 --- a/dlls/d3dx9_34/version.rc +++ b/dlls/d3dx9_34/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_34.dll" #define WINE_FILEVERSION 9,19,949,46 #define WINE_FILEVERSION_STR "9.19.949.46" #define WINE_PRODUCTVERSION 9,19,949,46 diff --git a/dlls/d3dx9_35/version.rc b/dlls/d3dx9_35/version.rc index 6ffaafb..8a6f11f 100644 --- a/dlls/d3dx9_35/version.rc +++ b/dlls/d3dx9_35/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_35.dll" #define WINE_FILEVERSION 9,19,949,1104 #define WINE_FILEVERSION_STR "9.19.949.1104" #define WINE_PRODUCTVERSION 9,19,949,1104 diff --git a/dlls/d3dx9_36/version.rc b/dlls/d3dx9_36/version.rc index 8ca195d..38c2942 100644 --- a/dlls/d3dx9_36/version.rc +++ b/dlls/d3dx9_36/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_36.dll" #define WINE_FILEVERSION 9,19,949,2111 #define WINE_FILEVERSION_STR "9.19.949.2111" #define WINE_PRODUCTVERSION 9,19,949,2111 diff --git a/dlls/d3dx9_37/version.rc b/dlls/d3dx9_37/version.rc index aeb99d2..996388e 100644 --- a/dlls/d3dx9_37/version.rc +++ b/dlls/d3dx9_37/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_37.dll" #define WINE_FILEVERSION 9,22,949,2248 #define WINE_FILEVERSION_STR "9.22.949.2248" #define WINE_PRODUCTVERSION 9,22,949,2248 diff --git a/dlls/d3dx9_38/version.rc b/dlls/d3dx9_38/version.rc index a8fdca8..5c33e25 100644 --- a/dlls/d3dx9_38/version.rc +++ b/dlls/d3dx9_38/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_38.dll" #define WINE_FILEVERSION 9,23,949,2378 #define WINE_FILEVERSION_STR "9.23.949.2378" #define WINE_PRODUCTVERSION 9,23,949,2378 diff --git a/dlls/d3dx9_39/version.rc b/dlls/d3dx9_39/version.rc index 234dcb9..d33fc41 100644 --- a/dlls/d3dx9_39/version.rc +++ b/dlls/d3dx9_39/version.rc @@ -17,7 +17,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_39.dll" #define WINE_FILEVERSION 9,24,949,2307 #define WINE_FILEVERSION_STR "9.24.949.2307" #define WINE_PRODUCTVERSION 9,24,949,2307 diff --git a/dlls/d3dx9_40/version.rc b/dlls/d3dx9_40/version.rc index f951079..79894fd 100644 --- a/dlls/d3dx9_40/version.rc +++ b/dlls/d3dx9_40/version.rc @@ -18,7 +18,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_40.dll" #define WINE_FILEVERSION 9,24,950,2656 #define WINE_FILEVERSION_STR "9.24.950.2656" #define WINE_PRODUCTVERSION 9,24,950,2656 diff --git a/dlls/d3dx9_41/version.rc b/dlls/d3dx9_41/version.rc index 6db7842..2419a7d 100644 --- a/dlls/d3dx9_41/version.rc +++ b/dlls/d3dx9_41/version.rc @@ -18,7 +18,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_41.dll" #define WINE_FILEVERSION 9,26,952,2844 #define WINE_FILEVERSION_STR "9.26.952.2844" #define WINE_PRODUCTVERSION 9,26,952,2844 diff --git a/dlls/d3dx9_42/version.rc b/dlls/d3dx9_42/version.rc index 5733eb9..16afffc 100644 --- a/dlls/d3dx9_42/version.rc +++ b/dlls/d3dx9_42/version.rc @@ -19,7 +19,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_42.dll" #define WINE_FILEVERSION 9,27,952,3001 #define WINE_FILEVERSION_STR "9.27.952.3001" #define WINE_PRODUCTVERSION 9,27,952,3001 diff --git a/dlls/d3dx9_43/version.rc b/dlls/d3dx9_43/version.rc index 865caac..7220bd2 100644 --- a/dlls/d3dx9_43/version.rc +++ b/dlls/d3dx9_43/version.rc @@ -18,7 +18,7 @@ */ #define WINE_FILEDESCRIPTION_STR "Wine D3DX9" -#define WINE_FILENAME_STR "d3dx9.dll" +#define WINE_FILENAME_STR "d3dx9_43.dll" #define WINE_FILEVERSION 9,29,952,3111 #define WINE_FILEVERSION_STR "9.29.952.3111" #define WINE_PRODUCTVERSION 9,29,952,3111

1 0

Nikolay Sivov : scrrun: Implement Next() for file collection.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 308f1144ac6ffd64d08d2a72ce6b4090617d9082 URL: http://source.winehq.org/git/wine.git/?a=commit;h=308f1144ac6ffd64d08d2a72c… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 7 03:25:02 2014 +0400 scrrun: Implement Next() for file collection. --- dlls/scrrun/filesystem.c | 99 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 95 insertions(+), 4 deletions(-) diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c index 94d894f..eb75a1f 100644 --- a/dlls/scrrun/filesystem.c +++ b/dlls/scrrun/filesystem.c @@ -50,6 +50,8 @@ struct enumdata { struct { IFileCollection *coll; + HANDLE find; + BSTR path; } filecoll; } u; }; @@ -70,6 +72,7 @@ struct foldercollection { struct filecollection { IFileCollection IFileCollection_iface; LONG ref; + BSTR path; }; struct folder { @@ -142,6 +145,7 @@ static inline HRESULT create_error(DWORD err) } static HRESULT create_folder(const WCHAR*, IFolder**); +static HRESULT create_file(BSTR, IFile**); static inline BOOL is_dir_data(const WIN32_FIND_DATAW *data) { @@ -153,6 +157,11 @@ static inline BOOL is_dir_data(const WIN32_FIND_DATAW *data) strcmpW(data->cFileName, dotW); } +static inline BOOL is_file_data(const WIN32_FIND_DATAW *data) +{ + return !(data->dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY); +} + static BSTR get_full_path(BSTR path, const WIN32_FIND_DATAW *data) { int len = SysStringLen(path); @@ -606,6 +615,7 @@ static ULONG WINAPI filecoll_enumvariant_Release(IEnumVARIANT *iface) if (!ref) { IFileCollection_Release(This->data.u.filecoll.coll); + SysFreeString(This->data.u.filecoll.path); heap_free(This); } @@ -615,8 +625,74 @@ static ULONG WINAPI filecoll_enumvariant_Release(IEnumVARIANT *iface) static HRESULT WINAPI filecoll_enumvariant_Next(IEnumVARIANT *iface, ULONG celt, VARIANT *var, ULONG *fetched) { struct enumvariant *This = impl_from_IEnumVARIANT(iface); - FIXME("(%p)->(%d %p %p): stub\n", This, celt, var, fetched); - return E_NOTIMPL; + HANDLE handle = This->data.u.filecoll.find; + WIN32_FIND_DATAW data; + ULONG count = 0; + + TRACE("(%p)->(%d %p %p)\n", This, celt, var, fetched); + + if (fetched) + *fetched = 0; + + if (!handle) + { + static const WCHAR allW[] = {'*',0}; + WCHAR pathW[MAX_PATH]; + BSTR parent = This->data.u.filecoll.path; + int len; + + strcpyW(pathW, parent); + len = SysStringLen(parent); + if (parent[len-1] != '\\') + strcatW(pathW, bsW); + strcatW(pathW, allW); + handle = FindFirstFileW(pathW, &data); + if (handle == INVALID_HANDLE_VALUE) + return S_FALSE; + + while (1) + { + if (is_file_data(&data)) + break; + else + if (!FindNextFileW(handle, &data)) + { + FindClose(handle); + return S_FALSE; + } + } + + This->data.u.filecoll.find = handle; + } + + do + { + if (count >= celt) break; + + if (is_file_data(&data)) + { + IFile *file; + HRESULT hr; + BSTR str; + + str = get_full_path(This->data.u.filecoll.path, &data); + hr = create_file(str, &file); + SysFreeString(str); + if (FAILED(hr)) return hr; + + V_VT(&var[count]) = VT_DISPATCH; + V_DISPATCH(&var[count]) = (IDispatch*)file; + count++; + } + } while (FindNextFileW(handle, &data)); + + if (count < celt) + return S_FALSE; + + if (fetched) + *fetched = count; + + return S_OK; } static HRESULT WINAPI filecoll_enumvariant_Skip(IEnumVARIANT *iface, ULONG celt) @@ -661,6 +737,12 @@ static HRESULT create_filecoll_enum(struct filecollection *collection, IUnknown This->IEnumVARIANT_iface.lpVtbl = &filecollenumvariantvtbl; This->ref = 1; + This->data.u.filecoll.path = SysAllocString(collection->path); + if (!This->data.u.filecoll.path) + { + heap_free(This); + return E_OUTOFMEMORY; + } This->data.u.filecoll.coll = &collection->IFileCollection_iface; IFileCollection_AddRef(This->data.u.filecoll.coll); @@ -903,7 +985,10 @@ static ULONG WINAPI filecoll_Release(IFileCollection *iface) TRACE("(%p)->(%d)\n", This, ref); if (!ref) + { + SysFreeString(This->path); heap_free(This); + } return ref; } @@ -1006,7 +1091,7 @@ static const IFileCollectionVtbl filecollectionvtbl = { filecoll_get_Count }; -static HRESULT create_filecoll(IFileCollection **files) +static HRESULT create_filecoll(BSTR path, IFileCollection **files) { struct filecollection *This; @@ -1017,6 +1102,12 @@ static HRESULT create_filecoll(IFileCollection **files) This->IFileCollection_iface.lpVtbl = &filecollectionvtbl; This->ref = 1; + This->path = SysAllocString(path); + if (!This->path) + { + heap_free(This); + return E_OUTOFMEMORY; + } *files = &This->IFileCollection_iface; return S_OK; @@ -1290,7 +1381,7 @@ static HRESULT WINAPI folder_get_Files(IFolder *iface, IFileCollection **files) if(!files) return E_POINTER; - return create_filecoll(files); + return create_filecoll(This->path, files); } static HRESULT WINAPI folder_CreateTextFile(IFolder *iface, BSTR filename, VARIANT_BOOL overwrite,

1 0

Frédéric Delanoy : xmllite/tests: Use BOOL type where appropriate.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: e5b689b71e73b7774438df1786e23aff80262055 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e5b689b71e73b7774438df178… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jan 7 00:14:38 2014 +0100 xmllite/tests: Use BOOL type where appropriate. --- dlls/xmllite/tests/reader.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 658bb10..0888a7e 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -89,11 +89,11 @@ static IStream *create_stream_on_data(const char *data, int size) } static void ok_pos_(IXmlReader *reader, int line, int pos, int line_broken, - int pos_broken, int todo, int _line_) + int pos_broken, BOOL todo, int _line_) { UINT l, p; HRESULT hr; - int broken_state; + BOOL broken_state; hr = IXmlReader_GetLineNumber(reader, &l); ok_(__FILE__, _line_)(hr == S_OK, "Expected S_OK, got %08x\n", hr); @@ -101,7 +101,7 @@ static void ok_pos_(IXmlReader *reader, int line, int pos, int line_broken, ok_(__FILE__, _line_)(hr == S_OK, "Expected S_OK, got %08x\n", hr); if (line_broken == -1 && pos_broken == -1) - broken_state = 0; + broken_state = FALSE; else broken_state = broken((line_broken == -1 ? line : line_broken) == l && (pos_broken == -1 ? pos : pos_broken) == p); @@ -151,7 +151,7 @@ static const IID *empty_seq[] = { static input_iids_t input_iids; -static void ok_iids_(const input_iids_t *iids, const IID **expected, const IID **exp_broken, int todo, int line) +static void ok_iids_(const input_iids_t *iids, const IID **expected, const IID **exp_broken, BOOL todo, int line) { int i = 0, size = 0; @@ -242,18 +242,18 @@ static const char *type_to_str(XmlNodeType type) } static void test_read_state_(IXmlReader *reader, XmlReadState expected, - XmlReadState exp_broken, int todo, int line) + XmlReadState exp_broken, BOOL todo, int line) { XmlReadState state; HRESULT hr; - int broken_state; + BOOL broken_state; state = -1; /* invalid value */ hr = IXmlReader_GetProperty(reader, XmlReaderProperty_ReadState, (LONG_PTR*)&state); ok_(__FILE__, line)(hr == S_OK, "Expected S_OK, got %08x\n", hr); if (exp_broken == -1) - broken_state = 0; + broken_state = FALSE; else broken_state = broken(exp_broken == state); @@ -642,7 +642,7 @@ static void test_reader_state(void) ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); /* attempt to read on closed reader */ - test_read_state(reader, XmlReadState_Closed, -1, 0); + test_read_state(reader, XmlReadState_Closed, -1, FALSE); if (0) { /* newer versions crash here, probably cause no input was set */ @@ -699,7 +699,7 @@ static void test_read_xmldeclaration(void) "Expected XmlNodeType_XmlDeclaration, got %s\n", type_to_str(type)); /* new version 1.2.x and 1.3.x properly update position for <?xml ?> */ ok_pos(reader, 1, 3, -1, 55, TRUE); - test_read_state(reader, XmlReadState_Interactive, -1, 0); + test_read_state(reader, XmlReadState_Interactive, -1, FALSE); hr = IXmlReader_GetValue(reader, &val, NULL); ok(hr == S_OK, "got %08x\n", hr); @@ -770,7 +770,7 @@ struct test_entry { const char *value; HRESULT hr; HRESULT hr_broken; /* this is set to older version results */ - int todo : 1; + BOOL todo; }; static struct test_entry comment_tests[] = { @@ -1338,8 +1338,8 @@ static void test_readvaluechunk(void) static struct test_entry cdata_tests[] = { { "<a><![CDATA[ ]]data ]]></a>", "", " ]]data ", S_OK }, { "<a><![CDATA[<![CDATA[ data ]]]]></a>", "", "<![CDATA[ data ]]", S_OK }, - { "<a><![CDATA[\n \r\n \n\n ]]></a>", "", "\n \n \n\n ", S_OK, S_OK, 1 }, - { "<a><![CDATA[\r \r\r\n \n\n ]]></a>", "", "\n \n\n \n\n ", S_OK, S_OK, 1 }, + { "<a><![CDATA[\n \r\n \n\n ]]></a>", "", "\n \n \n\n ", S_OK, S_OK, TRUE }, + { "<a><![CDATA[\r \r\r\n \n\n ]]></a>", "", "\n \n\n \n\n ", S_OK, S_OK, TRUE }, { "<a><![CDATA[\r\r \n\r \r \n\n ]]></a>", "", "\n\n \n\n \n \n\n ", S_OK }, { NULL } };

1 0

Michael Stefaniuc : dmime: Don' t use an IDirectMusicSegment8 method implementation directly.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 770feca7ac05a1189dfdeb64b702790d18a5076e URL: http://source.winehq.org/git/wine.git/?a=commit;h=770feca7ac05a1189dfdeb64b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Jan 7 10:33:21 2014 +0100 dmime: Don't use an IDirectMusicSegment8 method implementation directly. --- dlls/dmime/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/dmime/segment.c b/dlls/dmime/segment.c index 36766db..22218b5 100644 --- a/dlls/dmime/segment.c +++ b/dlls/dmime/segment.c @@ -813,7 +813,8 @@ static HRESULT IDirectMusicSegment8Impl_IPersistStream_LoadTrack (LPPERSISTSTREA /* release all loading-related stuff */ IPersistStream_Release (pPersistStream); - hr = IDirectMusicSegment8Impl_IDirectMusicSegment8_InsertTrack ((LPDIRECTMUSICSEGMENT8)&This->SegmentVtbl, *ppTrack, pTrack_hdr->dwGroup); /* at dsPosition */ + hr = IDirectMusicSegment8_InsertTrack((LPDIRECTMUSICSEGMENT8)&This->SegmentVtbl, *ppTrack, + pTrack_hdr->dwGroup); /* at dsPosition */ if (FAILED(hr)) { ERR(": could not insert track\n"); return hr;

1 0

Alexandre Julliard : makefiles: Expand define arguments directly into the generated rules.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 1a74fdbcee3530f4b66590e5f0eebf947ebc9e67 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1a74fdbcee3530f4b66590e5f… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 7 10:56:15 2014 +0100 makefiles: Expand define arguments directly into the generated rules. --- Make.rules.in | 9 ++++----- tools/makedep.c | 22 ++++++++++++++++++---- 2 files changed, 22 insertions(+), 9 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 6966144..7e6a09d 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -11,15 +11,14 @@ # First some useful definitions -DEFS = -D__WINESRC__ $(EXTRADEFS) -ALLCFLAGS = $(DEFS) $(EXTRACFLAGS) $(CPPFLAGS) $(CFLAGS) $(MODCFLAGS) -IDLFLAGS = $(DEFS) $(EXTRAIDLFLAGS) -RCFLAGS = --nostdinc $(PORCFLAGS) $(DEFS) +ALLCFLAGS = $(EXTRACFLAGS) $(CPPFLAGS) $(CFLAGS) $(MODCFLAGS) +IDLFLAGS = $(EXTRAIDLFLAGS) +RCFLAGS = --nostdinc $(PORCFLAGS) OBJS = $(C_SRCS:.c=.o) $(BISON_SRCS:.y=.tab.o) $(LEX_SRCS:.l=.yy.o) $(OBJC_SRCS:.m=.o) \ $(RC_SRCS:.rc=.res) $(MC_SRCS:.mc=.res) $(EXTRA_OBJS) -ALLCROSSCFLAGS = $(DEFS) -DWINE_CROSSTEST $(CPPFLAGS) $(CFLAGS) +ALLCROSSCFLAGS = $(CPPFLAGS) $(CFLAGS) # Rules for dependencies diff --git a/tools/makedep.c b/tools/makedep.c index 28f60fd..4d38613 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -92,6 +92,7 @@ struct strarray static const struct strarray empty_strarray; static struct strarray include_args; +static struct strarray define_args; static struct strarray make_vars; static struct strarray cmdline_vars; @@ -1475,9 +1476,10 @@ static struct strarray output_sources(void) { output( "%s.res: $(WRC) $(ALL_MO_FILES) %s\n", obj, sourcedep ); output( "\t$(WRC) -o $@ %s", source->filename ); - output_filenames( includes ); if (is_win16) output_filename( "-m16" ); else output_filenames( targetflags ); + output_filenames( includes ); + output_filenames( define_args ); output_filename( "$(RCFLAGS)" ); output( "\n" ); output( "%s.res rsrc.pot:", obj ); @@ -1487,9 +1489,10 @@ static struct strarray output_sources(void) { output( "%s.res: $(WRC) %s\n", obj, sourcedep ); output( "\t$(WRC) -o $@ %s", source->filename ); - output_filenames( includes ); if (is_win16) output_filename( "-m16" ); else output_filenames( targetflags ); + output_filenames( includes ); + output_filenames( define_args ); output_filename( "$(RCFLAGS)" ); output( "\n" ); output( "%s.res:", obj ); @@ -1524,8 +1527,9 @@ static struct strarray output_sources(void) output_filenames( targets ); output( ": $(WIDL)\n" ); output( "\t$(WIDL) -o $@ %s", source->filename ); - output_filenames( includes ); output_filenames( targetflags ); + output_filenames( includes ); + output_filenames( define_args ); output_filename( "$(IDLFLAGS)" ); output( "\n" ); output_filenames( targets ); @@ -1602,6 +1606,7 @@ static struct strarray output_sources(void) output( "%s.o: %s\n", obj, sourcedep ); output( "\t$(CC) -c -o $@ %s", source->filename ); output_filenames( includes ); + output_filenames( define_args ); if (module || staticlib || testdll) output_filenames( dllflags ); output_filename( "$(ALLCFLAGS)" ); output( "\n" ); @@ -1611,6 +1616,8 @@ static struct strarray output_sources(void) output( "%s.cross.o: %s\n", obj, sourcedep ); output( "\t$(CROSSCC) -c -o $@ %s", source->filename ); output_filenames( includes ); + output_filenames( define_args ); + output_filename( "-DWINE_CROSSTEST" ); output_filename( "$(ALLCROSSCFLAGS)" ); output( "\n" ); } @@ -1642,9 +1649,10 @@ static struct strarray output_sources(void) output_filenames( po_files ); output( "\n" ); output( "\t$(WRC) -O pot -o $@" ); - output_filenames( includes ); if (is_win16) output_filename( "-m16" ); else output_filenames( targetflags ); + output_filenames( includes ); + output_filenames( define_args ); output_filename( "$(RCFLAGS)" ); output_filenames( po_files ); output( "\n" ); @@ -2090,10 +2098,16 @@ static void update_makefile( const char *path ) parent_dir = get_expanded_make_variable( "PARENTSRC" ); include_args = empty_strarray; + define_args = empty_strarray; + strarray_add( &define_args, "-D__WINESRC__" ); + value = get_expanded_make_var_array( "EXTRAINCL" ); for (i = 0; i < value.count; i++) if (!strncmp( value.str[i], "-I", 2 )) strarray_add_uniq( &include_args, value.str[i] ); + else + strarray_add_uniq( &define_args, value.str[i] ); + strarray_addall( &define_args, get_expanded_make_var_array( "EXTRADEFS" )); init_paths();

1 0

Bruno Jesus : ws2_32/tests: Show that the last WSACleanup must destroy sockets.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: a1e22940069b050e376944c66d4a1030184c67e6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a1e22940069b050e376944c66… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Mon Jan 6 20:58:56 2014 -0200 ws2_32/tests: Show that the last WSACleanup must destroy sockets. --- dlls/ws2_32/tests/sock.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 9a90454..86a829e 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -1027,6 +1027,8 @@ static void test_WithWSAStartup(void) WORD version = MAKEWORD( 2, 2 ); INT res; LPVOID ptr; + SOCKET src, dst; + DWORD error; res = WSAStartup( version, &data ); ok(res == 0, "WSAStartup() failed unexpectedly: %d\n", res); @@ -1034,6 +1036,31 @@ static void test_WithWSAStartup(void) ptr = gethostbyname("localhost"); ok(ptr != NULL, "gethostbyname() failed unexpectedly: %d\n", WSAGetLastError()); + ok(!tcp_socketpair(&src, &dst), "creating socket pair failed\n"); + + res = send(src, "TEST", 4, 0); + ok(res == 4, "send failed with error %d\n", WSAGetLastError()); + + WSACleanup(); + + res = WSAStartup( version, &data ); + ok(res == 0, "WSAStartup() failed unexpectedly: %d\n", res); + + /* show that sockets are destroyed automatically after WSACleanup */ + todo_wine { + SetLastError(0xdeadbeef); + res = send(src, "TEST", 4, 0); + error = WSAGetLastError(); + ok(res == SOCKET_ERROR, "send should have failed\n"); + ok(error == WSAENOTSOCK, "expected 10038, got %d\n", error); + + SetLastError(0xdeadbeef); + res = closesocket(dst); + error = WSAGetLastError(); + ok(res == SOCKET_ERROR, "closesocket should have failed\n"); + ok(error == WSAENOTSOCK, "expected 10038, got %d\n", error); + } + WSACleanup(); }

1 0

Alexandre Julliard : mountmgr.sys: Use the correct variable for the include paths.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 15b40f62cc7027495bcccf7429fcdcc6076b6de5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=15b40f62cc7027495bcccf742… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 7 11:33:57 2014 +0100 mountmgr.sys: Use the correct variable for the include paths. --- dlls/mountmgr.sys/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mountmgr.sys/Makefile.in b/dlls/mountmgr.sys/Makefile.in index e1c4bbb..36895e3 100644 --- a/dlls/mountmgr.sys/Makefile.in +++ b/dlls/mountmgr.sys/Makefile.in @@ -2,7 +2,7 @@ MODULE = mountmgr.sys IMPORTS = uuid advapi32 ntoskrnl.exe DELAYIMPORTS = user32 EXTRADLLFLAGS = -Wb,--subsystem,native -EXTRADEFS = @DBUS_CFLAGS@ @HAL_CFLAGS@ +EXTRAINCL = @DBUS_CFLAGS@ @HAL_CFLAGS@ EXTRALIBS = @DISKARBITRATIONLIB@ C_SRCS = \

1 0

Alexandre Julliard : makefiles: Always create dependencies from the top-level directory.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 3dfcec768d93d3b332ff2402066e808c52f08c13 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3dfcec768d93d3b332ff24020… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 7 11:36:12 2014 +0100 makefiles: Always create dependencies from the top-level directory. --- Make.rules.in | 7 ------- tools/makedep.c | 8 ++++++++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 7e6a09d..947419e 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -20,13 +20,6 @@ OBJS = $(C_SRCS:.c=.o) $(BISON_SRCS:.y=.tab.o) $(LEX_SRCS:.l=.yy.o) $(OBJC_SRCS: ALLCROSSCFLAGS = $(CPPFLAGS) $(CFLAGS) -# Rules for dependencies - -depend: dummy - $(MAKEDEP) -M . - -.PHONY: depend - # Rules for cleaning clean:: diff --git a/tools/makedep.c b/tools/makedep.c index 7f8e518..20b1064 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -1944,6 +1944,7 @@ static struct strarray output_sources(void) output( "\t$(RM)" ); output_filenames( clean_files ); output( "\n" ); + strarray_add( &phony_targets, "clean" ); } if (subdirs.count) @@ -1953,6 +1954,13 @@ static struct strarray output_sources(void) output( "\t$(MKDIR_P) -m 755 $@\n" ); } + if (top_obj_dir) + { + output( "depend:\n" ); + output( "\t(a)cd %s && $(MAKE) %s/depend\n", top_obj_dir, base_dir ); + strarray_add( &phony_targets, "depend" ); + } + if (phony_targets.count) { output( ".PHONY:" );

1 0

Alexandre Julliard : makefiles: Allow define arguments to be specific to a single file.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 0d533cf0bd566310e3906b7b93e155999bfc5c0f URL: http://source.winehq.org/git/wine.git/?a=commit;h=0d533cf0bd566310e3906b7b9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 7 12:20:25 2014 +0100 makefiles: Allow define arguments to be specific to a single file. --- dlls/actxprxy/Makefile.in | 3 ++- dlls/appwiz.cpl/Makefile.in | 3 ++- dlls/dispex/Makefile.in | 3 ++- dlls/msdaps/Makefile.in | 3 ++- dlls/ole32/Makefile.in | 4 +++- dlls/oleaut32/Makefile.in | 4 +++- dlls/qmgrprxy/Makefile.in | 3 ++- dlls/quartz/Makefile.in | 3 ++- dlls/sti/Makefile.in | 3 ++- dlls/urlmon/Makefile.in | 6 ++++-- dlls/windowscodecs/Makefile.in | 3 ++- libs/wine/Makefile.in | 18 ++++++++++-------- tools/makedep.c | 8 ++++++++ tools/widl/Makefile.in | 2 +- tools/winegcc/Makefile.in | 18 +++++++++--------- tools/wrc/Makefile.in | 3 ++- 16 files changed, 56 insertions(+), 31 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=0d533cf0bd566310e3906…

1 0

Bruno Jesus : ws2_32/tests: Add some FIONREAD tests.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 7e4d075ec1859f5fadcad4a39a261237f1d8eb03 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e4d075ec1859f5fadcad4a39… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Mon Jan 6 20:58:54 2014 -0200 ws2_32/tests: Add some FIONREAD tests. --- dlls/ws2_32/tests/sock.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 54b0840..9a90454 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -3859,7 +3859,7 @@ static void test_addr_to_print(void) static void test_ioctlsocket(void) { - SOCKET sock; + SOCKET sock, src, dst; struct tcp_keepalive kalive; int ret, optval; static const LONG cmds[] = {FIONBIO, FIONREAD, SIOCATMARK}; @@ -3943,6 +3943,32 @@ static void test_ioctlsocket(void) ok(ret == 0 || broken(ret == SOCKET_ERROR), "WSAIoctl failed unexpectedly\n"); closesocket(sock); + + if (tcp_socketpair(&src, &dst) != 0) + { + ok(0, "creating socket pair failed, skipping test\n"); + return; + } + + /* test FIONREAD on TCP sockets */ + optval = 0xdeadbeef; + ret = WSAIoctl(dst, FIONREAD, NULL, 0, &optval, sizeof(optval), &arg, NULL, NULL); + ok(ret == 0, "WSAIoctl failed unexpectedly with error %d\n", WSAGetLastError()); + ok(optval == 0, "FIONREAD should have returned 0 bytes, got %d instead\n", optval); + + optval = 0xdeadbeef; + ok(send(src, "TEST", 4, 0) == 4, "failed to send test data\n"); + Sleep(100); + ret = WSAIoctl(dst, FIONREAD, NULL, 0, &optval, sizeof(optval), &arg, NULL, NULL); + ok(ret == 0, "WSAIoctl failed unexpectedly with error %d\n", WSAGetLastError()); + ok(optval == 4, "FIONREAD should have returned 4 bytes, got %d instead\n", optval); + + closesocket(dst); + optval = 0xdeadbeef; + ret = WSAIoctl(dst, FIONREAD, NULL, 0, &optval, sizeof(optval), &arg, NULL, NULL); + ok(ret == SOCKET_ERROR, "WSAIoctl succeeded unexpectedly\n"); + ok(optval == 0xdeadbeef, "FIONREAD should not have changed last error, got %d instead\n", optval); + closesocket(src); } static BOOL drain_pause = FALSE;

1 0

André Hentschel : kernel32/tests: Add missing last errors for win8.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 29907a28629d1b67afc5b97288aa926a0b56011e URL: http://source.winehq.org/git/wine.git/?a=commit;h=29907a28629d1b67afc5b9728… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Jan 7 00:36:15 2014 +0100 kernel32/tests: Add missing last errors for win8. --- dlls/kernel32/tests/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c index 7c43663..b38bb30 100644 --- a/dlls/kernel32/tests/console.c +++ b/dlls/kernel32/tests/console.c @@ -1401,7 +1401,7 @@ static void test_WriteConsoleInputA(HANDLE input_handle) {INVALID_HANDLE_VALUE, NULL, 0, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, {INVALID_HANDLE_VALUE, NULL, 0, &count, 0, ERROR_INVALID_HANDLE}, {INVALID_HANDLE_VALUE, NULL, 1, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, - {INVALID_HANDLE_VALUE, NULL, 1, &count, 0xdeadbeef, ERROR_INVALID_ACCESS}, + {INVALID_HANDLE_VALUE, NULL, 1, &count, 0xdeadbeef, ERROR_INVALID_HANDLE, ERROR_INVALID_ACCESS}, {INVALID_HANDLE_VALUE, &event, 0, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, {INVALID_HANDLE_VALUE, &event, 0, &count, 0, ERROR_INVALID_HANDLE}, {INVALID_HANDLE_VALUE, &event, 1, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, @@ -1645,7 +1645,7 @@ static void test_WriteConsoleInputW(HANDLE input_handle) {INVALID_HANDLE_VALUE, NULL, 0, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, {INVALID_HANDLE_VALUE, NULL, 0, &count, 0, ERROR_INVALID_HANDLE}, {INVALID_HANDLE_VALUE, NULL, 1, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, - {INVALID_HANDLE_VALUE, NULL, 1, &count, 0xdeadbeef, ERROR_INVALID_ACCESS}, + {INVALID_HANDLE_VALUE, NULL, 1, &count, 0xdeadbeef, ERROR_INVALID_HANDLE, ERROR_INVALID_ACCESS}, {INVALID_HANDLE_VALUE, &event, 0, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1}, {INVALID_HANDLE_VALUE, &event, 0, &count, 0, ERROR_INVALID_HANDLE}, {INVALID_HANDLE_VALUE, &event, 1, NULL, 0xdeadbeef, ERROR_INVALID_ACCESS, 0, 1},

1 0

Nikolay Sivov : scrrun: Implement Reset() for file collection.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 6dbc8195a0e4ae5fcb9751437e400e6473c0c2d1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6dbc8195a0e4ae5fcb9751437… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 7 03:25:20 2014 +0400 scrrun: Implement Reset() for file collection. --- dlls/scrrun/filesystem.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/scrrun/filesystem.c b/dlls/scrrun/filesystem.c index eb75a1f..a2562ef 100644 --- a/dlls/scrrun/filesystem.c +++ b/dlls/scrrun/filesystem.c @@ -705,8 +705,13 @@ static HRESULT WINAPI filecoll_enumvariant_Skip(IEnumVARIANT *iface, ULONG celt) static HRESULT WINAPI filecoll_enumvariant_Reset(IEnumVARIANT *iface) { struct enumvariant *This = impl_from_IEnumVARIANT(iface); - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + + TRACE("(%p)\n", This); + + FindClose(This->data.u.filecoll.find); + This->data.u.filecoll.find = NULL; + + return S_OK; } static HRESULT WINAPI filecoll_enumvariant_Clone(IEnumVARIANT *iface, IEnumVARIANT **pclone)

1 0

Frédéric Delanoy : wmiutils/tests: Use BOOL type where appropriate.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: 50629d7ca9e31589f2ad726a7fd7f29cea848a77 URL: http://source.winehq.org/git/wine.git/?a=commit;h=50629d7ca9e31589f2ad726a7… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jan 7 00:14:37 2014 +0100 wmiutils/tests: Use BOOL type where appropriate. --- dlls/wmiutils/tests/path.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/wmiutils/tests/path.c b/dlls/wmiutils/tests/path.c index ffc3d46..56bebb3 100644 --- a/dlls/wmiutils/tests/path.c +++ b/dlls/wmiutils/tests/path.c @@ -94,7 +94,7 @@ static void test_IWbemPath_SetText(void) const WCHAR *path; ULONG mode; HRESULT ret; - int todo; + BOOL todo; } test[] = { { path1, 0, WBEM_E_INVALID_PARAMETER }, @@ -113,15 +113,15 @@ static void test_IWbemPath_SetText(void) { path7, WBEMPATH_CREATE_ACCEPT_RELATIVE, S_OK }, { path7, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK }, { path7, WBEMPATH_CREATE_ACCEPT_ALL, S_OK }, - { path7, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS, WBEM_E_INVALID_PARAMETER, 1 }, + { path7, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS, WBEM_E_INVALID_PARAMETER, TRUE }, { path7, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS + 1, S_OK }, { path8, WBEMPATH_CREATE_ACCEPT_RELATIVE, S_OK }, - { path8, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, WBEM_E_INVALID_PARAMETER, 1 }, + { path8, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, WBEM_E_INVALID_PARAMETER, TRUE }, { path8, WBEMPATH_CREATE_ACCEPT_ALL, S_OK }, - { path8, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS, WBEM_E_INVALID_PARAMETER, 1 }, + { path8, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS, WBEM_E_INVALID_PARAMETER, TRUE }, { path8, WBEMPATH_TREAT_SINGLE_IDENT_AS_NS + 1, S_OK }, { path9, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK }, - { path10, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, WBEM_E_INVALID_PARAMETER, 1 }, + { path10, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, WBEM_E_INVALID_PARAMETER, TRUE }, { path11, WBEMPATH_CREATE_ACCEPT_ABSOLUTE, S_OK }, { path15, WBEMPATH_CREATE_ACCEPT_ALL, S_OK } };

1 0

Frédéric Delanoy : wbemprox/tests: Use BOOL type where appropriate.
by Alexandre Julliard Jan. 7, 2014

Jan. 7, 2014

Module: wine Branch: master Commit: aa0eceb554a35e7d53ffe4e0c8acd6a580246750 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa0eceb554a35e7d53ffe4e0c… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Jan 7 00:14:36 2014 +0100 wbemprox/tests: Use BOOL type where appropriate. --- dlls/wbemprox/tests/services.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/wbemprox/tests/services.c b/dlls/wbemprox/tests/services.c index 7f8a7a2..b36748e 100644 --- a/dlls/wbemprox/tests/services.c +++ b/dlls/wbemprox/tests/services.c @@ -115,7 +115,7 @@ static void test_IWbemLocator(void) { const WCHAR *path; HRESULT result; - int todo; + BOOL todo; HRESULT result_broken; } test[] = @@ -124,10 +124,10 @@ static void test_IWbemLocator(void) { path1W, WBEM_E_INVALID_NAMESPACE }, { path2W, WBEM_E_INVALID_NAMESPACE }, { path3W, WBEM_E_INVALID_NAMESPACE }, - { path4W, WBEM_E_INVALID_NAMESPACE, 0, WBEM_E_INVALID_PARAMETER }, + { path4W, WBEM_E_INVALID_NAMESPACE, FALSE, WBEM_E_INVALID_PARAMETER }, { path5W, WBEM_E_INVALID_NAMESPACE }, - { path6W, 0x800706ba, 1 }, - { path7W, 0x800706ba, 1 }, + { path6W, 0x800706ba, TRUE }, + { path7W, 0x800706ba, TRUE }, { path8W, WBEM_E_INVALID_NAMESPACE }, { path9W, S_OK }, { path10W, WBEM_E_INVALID_PARAMETER },

1 0

Piotr Caban : msvcr90: Add _is_exception_typeof implementation.
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: 32858d1811c0b939e348f1ca3de91581ef574d65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=32858d1811c0b939e348f1ca3… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon Jan 6 17:54:26 2014 +0100 msvcr90: Add _is_exception_typeof implementation. --- dlls/msvcr100/msvcr100.spec | 4 +- dlls/msvcr110/msvcr110.spec | 4 +- dlls/msvcr80/msvcr80.spec | 4 +- dlls/msvcr90/msvcr90.spec | 4 +- dlls/msvcr90/tests/msvcr90.c | 119 +++++++++++++++++++++++++++++++++++++++++- dlls/msvcrt/cpp.c | 85 ++++++++++++++++++++++++++++++ dlls/msvcrt/msvcrt.spec | 1 + 7 files changed, 212 insertions(+), 9 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=32858d1811c0b939e348f…

1 0

Jactry Zeng : riched20: Use CP_UNICODE instead of 1200.
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: 51936be04dc9245d17051f6e5b6b247cfa5aa466 URL: http://source.winehq.org/git/wine.git/?a=commit;h=51936be04dc9245d17051f6e5… Author: Jactry Zeng <jactry92(a)gmail.com> Date: Sun Jan 5 19:10:58 2014 +0800 riched20: Use CP_UNICODE instead of 1200. --- dlls/riched20/editor.c | 8 ++++---- dlls/riched20/editor.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 66dec2d..119061f 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -1968,7 +1968,7 @@ static int ME_GetTextEx(ME_TextEditor *editor, GETTEXTEX *ex, LPARAM pText) ME_SetCursorToStart(editor, &start); nChars = INT_MAX; } - if (ex->codepage == 1200) + if (ex->codepage == CP_UNICODE) { return ME_GetTextW(editor, (LPWSTR)pText, ex->cb / sizeof(WCHAR) - 1, &start, nChars, ex->flags & GT_USECRLF); @@ -3338,7 +3338,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, * we know it isn't unicode. */ bRtf = (lParam && (!strncmp((char *)lParam, "{\\rtf", 5) || !strncmp((char *)lParam, "{\\urtf", 6))); - bUnicode = !bRtf && pStruct->codepage == 1200; + bUnicode = !bRtf && pStruct->codepage == CP_UNICODE; TRACE("EM_SETTEXTEX - %s, flags %d, cp %d\n", bUnicode ? debugstr_w((LPCWSTR)lParam) : debugstr_a((LPCSTR)lParam), @@ -3691,7 +3691,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, /* CR/LF conversion required in 2.0 mode, verbatim in 1.0 mode */ how.flags = GTL_CLOSE | (editor->bEmulateVersion10 ? 0 : GTL_USECRLF) | GTL_NUMCHARS; - how.codepage = unicode ? 1200 : CP_ACP; + how.codepage = unicode ? CP_UNICODE : CP_ACP; return ME_GetTextLengthEx(editor, &how); } case EM_GETTEXTLENGTHEX: @@ -3701,7 +3701,7 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, GETTEXTEX ex; ex.cb = wParam * (unicode ? sizeof(WCHAR) : sizeof(CHAR)); ex.flags = GT_USECRLF; - ex.codepage = unicode ? 1200 : CP_ACP; + ex.codepage = unicode ? CP_UNICODE : CP_ACP; ex.lpDefaultChar = NULL; ex.lpUsedDefChar = NULL; return ME_GetTextEx(editor, &ex, lParam); diff --git a/dlls/riched20/editor.h b/dlls/riched20/editor.h index 2f2dc96..40bf04c 100644 --- a/dlls/riched20/editor.h +++ b/dlls/riched20/editor.h @@ -108,6 +108,8 @@ int ME_CallWordBreakProc(ME_TextEditor *editor, WCHAR *str, INT len, INT start, void ME_StrDeleteV(ME_String *s, int nVChar, int nChars) DECLSPEC_HIDDEN; BOOL ME_InsertString(ME_String *s, int ofs, const WCHAR *insert, int len) DECLSPEC_HIDDEN; +#define CP_UNICODE 1200 + /* smart helpers for A<->W conversions, they reserve/free memory and call MultiByte<->WideChar functions */ LPWSTR ME_ToUnicode(BOOL unicode, LPVOID psz, INT *len) DECLSPEC_HIDDEN; void ME_EndToUnicode(BOOL unicode, LPVOID psz) DECLSPEC_HIDDEN;

1 0

Marcus Meissner : ws2_32: handle error return from get_sock_fd (Coverity).
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: 54dc91547d79f0b76a11672f41648e81f331efcc URL: http://source.winehq.org/git/wine.git/?a=commit;h=54dc91547d79f0b76a11672f4… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jan 4 17:49:40 2014 +0100 ws2_32: handle error return from get_sock_fd (Coverity). --- dlls/ws2_32/socket.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index b027d7a..a855285 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1178,6 +1178,8 @@ static int set_ipx_packettype(int sock, int ptype) int fd = get_sock_fd( sock, 0, NULL ), ret = 0; TRACE("trying to set IPX_PTYPE: %d (fd: %d)\n", ptype, fd); + if (fd == -1) return SOCKET_ERROR; + /* We try to set the ipx type on ipx socket level. */ #ifdef SOL_IPX if(setsockopt(fd, SOL_IPX, IPX_TYPE, &ptype, sizeof(ptype)) == -1)

1 0

Stefan Dösinger : d3dx9_36: Improve error handling in remap_faces_for_attrsort.
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: 86e88f51b88f99514d1a00f9ee60c0a60232c7b1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=86e88f51b88f99514d1a00f9e… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Jan 3 14:17:18 2014 +0100 d3dx9_36: Improve error handling in remap_faces_for_attrsort. --- dlls/d3dx9_36/mesh.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index 133f14d..b713079 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -1615,12 +1615,17 @@ static HRESULT remap_faces_for_attrsort(struct d3dx9_mesh *This, const DWORD *in DWORD **sorted_attrib_ptr_buffer = NULL; DWORD i; - *face_remap = HeapAlloc(GetProcessHeap(), 0, This->numfaces * sizeof(**face_remap)); sorted_attrib_ptr_buffer = HeapAlloc(GetProcessHeap(), 0, This->numfaces * sizeof(*sorted_attrib_ptr_buffer)); - if (!*face_remap || !sorted_attrib_ptr_buffer) { + if (!sorted_attrib_ptr_buffer) + return E_OUTOFMEMORY; + + *face_remap = HeapAlloc(GetProcessHeap(), 0, This->numfaces * sizeof(**face_remap)); + if (!*face_remap) + { HeapFree(GetProcessHeap(), 0, sorted_attrib_ptr_buffer); return E_OUTOFMEMORY; } + for (i = 0; i < This->numfaces; i++) sorted_attrib_ptr_buffer[i] = &attrib_buffer[i]; qsort(sorted_attrib_ptr_buffer, This->numfaces, sizeof(*sorted_attrib_ptr_buffer),

1 0

Stefan Dösinger : d3dx9_36: Don' t make the input parameter to remap_faces_for_attrsort const.
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: 303a5f05f71d0250f02acff8bb9635006c850c04 URL: http://source.winehq.org/git/wine.git/?a=commit;h=303a5f05f71d0250f02acff8b… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Jan 3 14:17:17 2014 +0100 d3dx9_36: Don't make the input parameter to remap_faces_for_attrsort const. --- dlls/d3dx9_36/mesh.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/mesh.c b/dlls/d3dx9_36/mesh.c index aa20119..133f14d 100644 --- a/dlls/d3dx9_36/mesh.c +++ b/dlls/d3dx9_36/mesh.c @@ -1610,9 +1610,9 @@ static int attrib_entry_compare(const DWORD **a, const DWORD **b) /* Create face_remap, a new attribute buffer for attribute sort optimization. */ static HRESULT remap_faces_for_attrsort(struct d3dx9_mesh *This, const DWORD *indices, - const DWORD *attrib_buffer, DWORD **sorted_attrib_buffer, DWORD **face_remap) + DWORD *attrib_buffer, DWORD **sorted_attrib_buffer, DWORD **face_remap) { - const DWORD **sorted_attrib_ptr_buffer = NULL; + DWORD **sorted_attrib_ptr_buffer = NULL; DWORD i; *face_remap = HeapAlloc(GetProcessHeap(), 0, This->numfaces * sizeof(**face_remap));

1 0

Stefan Dösinger : d3dx9_36: Cast UINTs to FLOATs in d3dx9_line_Begin.
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: b054fe94ee0bc34652b147e1b42228cfb5f056a0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b054fe94ee0bc34652b147e1b… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Jan 3 14:17:20 2014 +0100 d3dx9_36: Cast UINTs to FLOATs in d3dx9_line_Begin. --- dlls/d3dx9_36/line.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/line.c b/dlls/d3dx9_36/line.c index 0b3e88f..5de44f4 100644 --- a/dlls/d3dx9_36/line.c +++ b/dlls/d3dx9_36/line.c @@ -113,7 +113,7 @@ static HRESULT WINAPI d3dx9_line_Begin(ID3DXLine *iface) goto failed; D3DXMatrixIdentity(&identity); - D3DXMatrixOrthoOffCenterLH(&projection, 0.0, vp.Width, vp.Height, 0.0, 0.0, 1.0); + D3DXMatrixOrthoOffCenterLH(&projection, 0.0, (FLOAT)vp.Width, (FLOAT)vp.Height, 0.0, 0.0, 1.0); if (FAILED(IDirect3DDevice9_SetTransform(line->device, D3DTS_WORLD, &identity))) goto failed;

1 0

Marcus Meissner : msvcp90: Return on error (Coverity).
by Alexandre Julliard Jan. 6, 2014

Jan. 6, 2014

Module: wine Branch: master Commit: eddc91f6e7b2e5f417603100d781acba48f0a713 URL: http://source.winehq.org/git/wine.git/?a=commit;h=eddc91f6e7b2e5f417603100d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Jan 4 18:48:42 2014 +0100 msvcp90: Return on error (Coverity). --- dlls/msvcp90/locale.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index b37ead4..5a5e39c 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -9704,6 +9704,7 @@ size_t __cdecl mbsrtowcs(wchar_t *dst, const char **pstr, size_t n, mbstate_t *s { *_errno() = EINVAL; _invalid_parameter( NULL, NULL, NULL, 0, 0 ); + return -1; } src = *pstr; if (!state) state = &local_state; @@ -9747,6 +9748,7 @@ size_t __cdecl wcsrtombs(char *dst, const wchar_t **pstr, size_t n, mbstate_t *s { *_errno() = EINVAL; _invalid_parameter( NULL, NULL, NULL, 0, 0 ); + return -1; } src = *pstr;

1 0