January 2014 - Wine-Commits

Alexandre Julliard : configure: Use AS_VAR_IF to test variables where appropriate.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 2a741324fea748efd8f9b734bda0d030d54c2755 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2a741324fea748efd8f9b734b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 30 12:22:08 2014 +0100 configure: Use AS_VAR_IF to test variables where appropriate. --- aclocal.m4 | 47 +++---- configure | 436 ++++++++++++++++++++++++++++++------------------------------ 2 files changed, 240 insertions(+), 243 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2a741324fea748efd8f9b…

1 0

Alexandre Julliard : configure: Trace the results of pkg-config checks to the config.log file.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: cebed408c74779d5659d0043a02edd1014a2d114 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cebed408c74779d5659d0043a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 30 11:42:38 2014 +0100 configure: Trace the results of pkg-config checks to the config.log file. --- aclocal.m4 | 2 ++ configure | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/aclocal.m4 b/aclocal.m4 index c582890..1a3715a 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -99,6 +99,8 @@ AS_IF([test -n "$ac_libs"],[], [ac_libs=`$PKG_CONFIG --libs [$2] 2>/dev/null`]) m4_ifval([$5],[test "$cross_compiling" = yes || ac_libs=[$]{ac_libs:-[$5]}]) m4_ifval([$3],[ac_libs=[$]{ac_libs:-"$3"}]) +AS_ECHO(["$as_me:${as_lineno-$LINENO}: $2 cflags: $ac_cflags"]) >&AS_MESSAGE_LOG_FD +AS_ECHO(["$as_me:${as_lineno-$LINENO}: $2 libs: $ac_libs"]) >&AS_MESSAGE_LOG_FD ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $ac_cflags" $6 diff --git a/configure b/configure index 1fc40e7..8c0fd16 100755 --- a/configure +++ b/configure @@ -10475,6 +10475,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || XML2_LIBS=${XML2_LIBS:-`xml2-config --libs 2>/dev/null`} XML2_LIBS=${XML2_LIBS:-"-lxml2"} +$as_echo "$as_me:${as_lineno-$LINENO}: libxml-2.0 cflags: $XML2_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libxml-2.0 libs: $XML2_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $XML2_CFLAGS" for ac_header in libxml/parser.h libxml/xmlsave.h libxml/SAX2.h @@ -10787,6 +10789,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || XSLT_LIBS=${XSLT_LIBS:-`xslt-config --libs 2>/dev/null`} XSLT_LIBS=${XSLT_LIBS:-"-lxml2"} +$as_echo "$as_me:${as_lineno-$LINENO}: libxslt cflags: $XSLT_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libxslt libs: $XSLT_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $XSLT_CFLAGS" for ac_header in libxslt/pattern.h libxslt/transform.h @@ -10892,6 +10896,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: dbus-1 cflags: $DBUS_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: dbus-1 libs: $DBUS_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $DBUS_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "dbus/dbus.h" "ac_cv_header_dbus_dbus_h" "$ac_includes_default" @@ -10984,6 +10990,8 @@ elif test -n "$PKG_CONFIG"; then : fi HAL_LIBS=${HAL_LIBS:-"-ldbus-1"} +$as_echo "$as_me:${as_lineno-$LINENO}: hal cflags: $HAL_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: hal libs: $HAL_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $HAL_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "hal/libhal.h" "ac_cv_header_hal_libhal_h" "$ac_includes_default" @@ -11076,6 +11084,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: gnutls cflags: $GNUTLS_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: gnutls libs: $GNUTLS_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $GNUTLS_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "gnutls/gnutls.h" "ac_cv_header_gnutls_gnutls_h" "$ac_includes_default" @@ -11317,6 +11327,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || SANE_LIBS=${SANE_LIBS:-`sane-config --ldflags 2>/dev/null`} +$as_echo "$as_me:${as_lineno-$LINENO}: libsane cflags: $SANE_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libsane libs: $SANE_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $SANE_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "sane/sane.h" "ac_cv_header_sane_sane_h" "$ac_includes_default" @@ -11473,6 +11485,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || GPHOTO2_LIBS=${GPHOTO2_LIBS:-`gphoto2-config --libs 2>/dev/null`} GPHOTO2_LIBS=${GPHOTO2_LIBS:-"-lgphoto2"} +$as_echo "$as_me:${as_lineno-$LINENO}: libgphoto2 cflags: $GPHOTO2_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libgphoto2 libs: $GPHOTO2_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $GPHOTO2_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "gphoto2-camera.h" "ac_cv_header_gphoto2_camera_h" "$ac_includes_default" @@ -11543,6 +11557,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || GPHOTO2_PORT_LIBS=${GPHOTO2_PORT_LIBS:-`gphoto2-port-config --libs 2>/dev/null`} GPHOTO2_PORT_LIBS=${GPHOTO2_PORT_LIBS:-"-lgphoto2_port"} +$as_echo "$as_me:${as_lineno-$LINENO}: libgphoto2_port cflags: $GPHOTO2_PORT_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libgphoto2_port libs: $GPHOTO2_PORT_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $GPHOTO2_PORT_CFLAGS" ac_fn_c_check_header_mongrel "$LINENO" "gphoto2-port.h" "ac_cv_header_gphoto2_port_h" "$ac_includes_default" @@ -11670,6 +11686,8 @@ elif test -n "$PKG_CONFIG"; then : fi LCMS2_LIBS=${LCMS2_LIBS:-"-llcms2"} +$as_echo "$as_me:${as_lineno-$LINENO}: lcms2 cflags: $LCMS2_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: lcms2 libs: $LCMS2_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $LCMS2_CFLAGS" for ac_header in lcms2.h @@ -11763,6 +11781,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || FREETYPE_LIBS=${FREETYPE_LIBS:-`(freetype-config --libs || freetype2-config --libs) 2>/dev/null`} FREETYPE_LIBS=${FREETYPE_LIBS:-"-lfreetype"} +$as_echo "$as_me:${as_lineno-$LINENO}: freetype2 cflags: $FREETYPE_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: freetype2 libs: $FREETYPE_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $FREETYPE_CFLAGS" for ac_header in ft2build.h @@ -12050,6 +12070,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: gstreamer-app-0.10 cflags: $GSTREAMER_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: gstreamer-app-0.10 libs: $GSTREAMER_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $GSTREAMER_CFLAGS" ac_gst_incl="" @@ -12300,6 +12322,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: capi20 cflags: $CAPI20_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: capi20 libs: $CAPI20_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $CAPI20_CFLAGS" for ac_header in capi20.h linux/capi.h @@ -12484,6 +12508,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || FONTCONFIG_LIBS=${FONTCONFIG_LIBS:-$X_LIBS} +$as_echo "$as_me:${as_lineno-$LINENO}: fontconfig cflags: $FONTCONFIG_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: fontconfig libs: $FONTCONFIG_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $FONTCONFIG_CFLAGS" for ac_header in fontconfig/fontconfig.h @@ -12650,6 +12676,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: libjpeg cflags: $JPEG_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libjpeg libs: $JPEG_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $JPEG_CFLAGS" for ac_header in jpeglib.h @@ -12751,6 +12779,8 @@ elif test -n "$PKG_CONFIG"; then : fi test "$cross_compiling" = yes || PNG_LIBS=${PNG_LIBS:-$X_LIBS} +$as_echo "$as_me:${as_lineno-$LINENO}: libpng cflags: $PNG_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libpng libs: $PNG_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $PNG_CFLAGS" for ac_header in png.h @@ -12868,6 +12898,8 @@ elif test -n "$PKG_CONFIG"; then : fi +$as_echo "$as_me:${as_lineno-$LINENO}: libtiff cflags: $TIFF_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libtiff libs: $TIFF_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $TIFF_CFLAGS" for ac_header in tiffio.h @@ -12967,6 +12999,8 @@ elif test -n "$PKG_CONFIG"; then : fi MPG123_LIBS=${MPG123_LIBS:-"-lmpg123"} +$as_echo "$as_me:${as_lineno-$LINENO}: libmpg123 cflags: $MPG123_CFLAGS" >&5 +$as_echo "$as_me:${as_lineno-$LINENO}: libmpg123 libs: $MPG123_LIBS" >&5 ac_save_CPPFLAGS=$CPPFLAGS CPPFLAGS="$CPPFLAGS $MPG123_CFLAGS" for ac_header in mpg123.h

1 0

Alexandre Julliard : configure: Add a pkg-config check for fontconfig.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: db2be9dc0b40480f5420e3ab261b1b6c07b53607 URL: http://source.winehq.org/git/wine.git/?a=commit;h=db2be9dc0b40480f5420e3ab2… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 30 11:39:48 2014 +0100 configure: Add a pkg-config check for fontconfig. --- configure | 104 ++++++++++++++++-------------------------------- configure.ac | 27 +++++-------- dlls/gdi32/Makefile.in | 2 +- 3 files changed, 45 insertions(+), 88 deletions(-) diff --git a/configure b/configure index 0934c87..1fc40e7 100755 --- a/configure +++ b/configure @@ -645,7 +645,8 @@ PNG_LIBS PNG_CFLAGS JPEG_LIBS JPEG_CFLAGS -FONTCONFIGINCL +FONTCONFIG_LIBS +FONTCONFIG_CFLAGS CUPSINCL CAPI20_LIBS CAPI20_CFLAGS @@ -1385,6 +1386,8 @@ GSTREAMER_CFLAGS GSTREAMER_LIBS CAPI20_CFLAGS CAPI20_LIBS +FONTCONFIG_CFLAGS +FONTCONFIG_LIBS JPEG_CFLAGS JPEG_LIBS PNG_CFLAGS @@ -2116,6 +2119,10 @@ Some influential environment variables: CAPI20_CFLAGS C compiler flags for capi20, overriding pkg-config CAPI20_LIBS Linker flags for capi20, overriding pkg-config + FONTCONFIG_CFLAGS + C compiler flags for fontconfig, overriding pkg-config + FONTCONFIG_LIBS + Linker flags for fontconfig, overriding pkg-config JPEG_CFLAGS C compiler flags for libjpeg, overriding pkg-config JPEG_LIBS Linker flags for libjpeg, overriding pkg-config PNG_CFLAGS C compiler flags for libpng, overriding pkg-config @@ -5902,8 +5909,6 @@ OPENGL_LIBS="" -test "x$with_fontconfig" != "xno" || ac_cv_header_fontconfig_fontconfig_h=no - # Check whether --enable-largefile was given. if test "${enable_largefile+set}" = set; then : enableval=$enable_largefile; @@ -6402,7 +6407,6 @@ for ac_header in \ elf.h \ float.h \ fnmatch.h \ - fontconfig/fontconfig.h \ getopt.h \ gettext-po.h \ grp.h \ @@ -12465,67 +12469,24 @@ This is an error since --with-cups was requested." "$LINENO" 5 ;; esac fi -if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" +if test "x$with_fontconfig" != "xno" then - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -lfontconfig" >&5 -$as_echo_n "checking for -lfontconfig... " >&6; } -if ${ac_cv_lib_soname_fontconfig+:} false; then : - $as_echo_n "(cached) " >&6 -else - ac_check_soname_save_LIBS=$LIBS -LIBS="-lfontconfig $LIBS" - cat confdefs.h - <<_ACEOF >conftest.$ac_ext -/* end confdefs.h. */ + if test -n "$FONTCONFIG_CFLAGS"; then : -/* Override any GCC internal prototype to avoid an error. - Use char because int might match the return type of a GCC - builtin and then its argument prototype would still apply. */ -#ifdef __cplusplus -extern "C" -#endif -char FcInit (); -int -main () -{ -return FcInit (); - ; - return 0; -} -_ACEOF -if ac_fn_c_try_link "$LINENO"; then : - case "$LIBEXT" in - dll) ac_cv_lib_soname_fontconfig=`$ac_cv_path_LDD conftest.exe | grep "fontconfig" | sed -e "s/dll.*/dll/"';2,$d'` ;; - dylib) ac_cv_lib_soname_fontconfig=`otool -L conftest$ac_exeext | grep "libfontconfig\\.[0-9A-Za-z.]*dylib" | sed -e "s/^.*\/$libfontconfig\.[0-9A-Za-z.]*dylib$.*$/\1/"';2,$d'` ;; - *) ac_cv_lib_soname_fontconfig=`$READELF -d conftest$ac_exeext | grep "NEEDED.*libfontconfig\\.$LIBEXT" | sed -e "s/^.*\\[\$libfontconfig\\.$LIBEXT[^ ]*\$\\].*$/\1/"';2,$d'` - if test "x$ac_cv_lib_soname_fontconfig" = x; then : - ac_cv_lib_soname_fontconfig=`$LDD conftest$ac_exeext | grep "libfontconfig\\.$LIBEXT" | sed -e "s/^.*$libfontconfig\.$LIBEXT[^ ]*$.*$/\1/"';2,$d'` -fi ;; - esac -fi -rm -f core conftest.err conftest.$ac_objext \ - conftest$ac_exeext conftest.$ac_ext - LIBS=$ac_check_soname_save_LIBS +elif test -n "$PKG_CONFIG"; then : + FONTCONFIG_CFLAGS=`$PKG_CONFIG --cflags fontconfig 2>/dev/null` fi -if test "x$ac_cv_lib_soname_fontconfig" = "x"; then : - { $as_echo "$as_me:${as_lineno-$LINENO}: result: not found" >&5 -$as_echo "not found" >&6; } - -else - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_soname_fontconfig" >&5 -$as_echo "$ac_cv_lib_soname_fontconfig" >&6; } - -cat >>confdefs.h <<_ACEOF -#define SONAME_LIBFONTCONFIG "$ac_cv_lib_soname_fontconfig" -_ACEOF - +test "$cross_compiling" = yes || FONTCONFIG_CFLAGS=${FONTCONFIG_CFLAGS:-$X_CFLAGS} +if test -n "$FONTCONFIG_LIBS"; then : +elif test -n "$PKG_CONFIG"; then : + FONTCONFIG_LIBS=`$PKG_CONFIG --libs fontconfig 2>/dev/null` fi -elif test -n "$X_CFLAGS" -a "x$with_fontconfig" != "xno" -then - ac_save_CPPFLAGS="$CPPFLAGS" - CPPFLAGS="$CPPFLAGS $X_CFLAGS" - $as_unset ac_cv_header_fontconfig_fontconfig_h - for ac_header in fontconfig/fontconfig.h +test "$cross_compiling" = yes || FONTCONFIG_LIBS=${FONTCONFIG_LIBS:-$X_LIBS} + +ac_save_CPPFLAGS=$CPPFLAGS +CPPFLAGS="$CPPFLAGS $FONTCONFIG_CFLAGS" +for ac_header in fontconfig/fontconfig.h do : ac_fn_c_check_header_mongrel "$LINENO" "fontconfig/fontconfig.h" "ac_cv_header_fontconfig_fontconfig_h" "$ac_includes_default" if test "x$ac_cv_header_fontconfig_fontconfig_h" = xyes; then : @@ -12537,18 +12498,15 @@ fi done - CPPFLAGS="$ac_save_CPPFLAGS" - if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" - then - FONTCONFIGINCL="$X_CFLAGS" - - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -lfontconfig" >&5 + if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" + then + { $as_echo "$as_me:${as_lineno-$LINENO}: checking for -lfontconfig" >&5 $as_echo_n "checking for -lfontconfig... " >&6; } if ${ac_cv_lib_soname_fontconfig+:} false; then : $as_echo_n "(cached) " >&6 else ac_check_soname_save_LIBS=$LIBS -LIBS="-lfontconfig $X_LIBS $LIBS" +LIBS="-lfontconfig $FONTCONFIG_LIBS $LIBS" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ @@ -12584,7 +12542,7 @@ fi if test "x$ac_cv_lib_soname_fontconfig" = "x"; then : { $as_echo "$as_me:${as_lineno-$LINENO}: result: not found" >&5 $as_echo "not found" >&6; } - + FONTCONFIG_CFLAGS="" else { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_lib_soname_fontconfig" >&5 $as_echo "$ac_cv_lib_soname_fontconfig" >&6; } @@ -12595,7 +12553,13 @@ _ACEOF fi - fi + else + FONTCONFIG_CFLAGS="" + fi +CPPFLAGS=$ac_save_CPPFLAGS +test -z "$FONTCONFIG_CFLAGS" || FONTCONFIG_CFLAGS=`echo " $FONTCONFIG_CFLAGS" | sed 's/ -I$[^/]$/ -I\$(top_builddir)\/\1/g'` +test -z "$FONTCONFIG_LIBS" || FONTCONFIG_LIBS=`echo " $FONTCONFIG_LIBS" | sed 's/ -L$[^/]$/ -L\$(top_builddir)\/\1/g'` + fi if test "x$ac_cv_lib_soname_fontconfig" = "x"; then : case "x$with_fontconfig" in @@ -16492,6 +16456,8 @@ GSTREAMER_CFLAGS = $GSTREAMER_CFLAGS GSTREAMER_LIBS = $GSTREAMER_LIBS CAPI20_CFLAGS = $CAPI20_CFLAGS CAPI20_LIBS = $CAPI20_LIBS +FONTCONFIG_CFLAGS = $FONTCONFIG_CFLAGS +FONTCONFIG_LIBS = $FONTCONFIG_LIBS JPEG_CFLAGS = $JPEG_CFLAGS JPEG_LIBS = $JPEG_LIBS PNG_CFLAGS = $PNG_CFLAGS diff --git a/configure.ac b/configure.ac index f9f3e07..39b4c51 100644 --- a/configure.ac +++ b/configure.ac @@ -373,8 +373,6 @@ AC_SUBST(OPENGL_LIBS,"") dnl **** Check for header files **** -test "x$with_fontconfig" != "xno" || ac_cv_header_fontconfig_fontconfig_h=no - AC_SYS_LARGEFILE() AC_CHECK_HEADERS(\ @@ -407,7 +405,6 @@ AC_CHECK_HEADERS(\ elf.h \ float.h \ fnmatch.h \ - fontconfig/fontconfig.h \ getopt.h \ gettext-po.h \ grp.h \ @@ -1616,22 +1613,16 @@ WINE_NOTICE_WITH(cups,[test "x$ac_cv_lib_soname_cups" = "x"], [libcups ${notice_platform}development files not found, CUPS won't be supported.]) dnl **** Check for fontconfig **** -if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" -then - WINE_CHECK_SONAME(fontconfig,FcInit) -elif test -n "$X_CFLAGS" -a "x$with_fontconfig" != "xno" +if test "x$with_fontconfig" != "xno" then - dnl fontconfig is in the X directory on Mac OS X - ac_save_CPPFLAGS="$CPPFLAGS" - CPPFLAGS="$CPPFLAGS $X_CFLAGS" - $as_unset ac_cv_header_fontconfig_fontconfig_h - AC_CHECK_HEADERS([fontconfig/fontconfig.h]) - CPPFLAGS="$ac_save_CPPFLAGS" - if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" - then - AC_SUBST(FONTCONFIGINCL,"$X_CFLAGS") - WINE_CHECK_SONAME(fontconfig,FcInit,,,[$X_LIBS]) - fi + WINE_PACKAGE_FLAGS(FONTCONFIG,[fontconfig],,[$X_CFLAGS],[$X_LIBS], + [AC_CHECK_HEADERS([fontconfig/fontconfig.h]) + if test "$ac_cv_header_fontconfig_fontconfig_h" = "yes" + then + WINE_CHECK_SONAME(fontconfig,FcInit,,[FONTCONFIG_CFLAGS=""],[$FONTCONFIG_LIBS]) + else + FONTCONFIG_CFLAGS="" + fi]) fi WINE_NOTICE_WITH(fontconfig,[test "x$ac_cv_lib_soname_fontconfig" = "x"], [fontconfig ${notice_platform}development files not found, fontconfig won't be supported.]) diff --git a/dlls/gdi32/Makefile.in b/dlls/gdi32/Makefile.in index da31559..1b66302 100644 --- a/dlls/gdi32/Makefile.in +++ b/dlls/gdi32/Makefile.in @@ -2,7 +2,7 @@ EXTRADEFS = -D_GDI32_ MODULE = gdi32.dll IMPORTLIB = gdi32 IMPORTS = advapi32 -EXTRAINCL = $(FREETYPE_CFLAGS) @FONTCONFIGINCL@ +EXTRAINCL = $(FREETYPE_CFLAGS) $(FONTCONFIG_CFLAGS) EXTRALIBS = @CARBONLIB@ @APPKITLIB@ DELAYIMPORTS = usp10

1 0

André Hentschel : gdi32: Use boolean return values in boolean functions.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 540d1459f98f72d945167932507ffaa35cb83b4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=540d1459f98f72d9451679325… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Jan 28 00:04:18 2014 +0100 gdi32: Use boolean return values in boolean functions. --- dlls/gdi32/enhmfdrv/dc.c | 14 +++++++------- dlls/gdi32/enhmfdrv/objects.c | 2 +- dlls/gdi32/font.c | 4 ++-- dlls/gdi32/gdiobj.c | 8 ++++---- dlls/gdi32/mfdrv/objects.c | 2 +- dlls/gdi32/palette.c | 4 ++-- 6 files changed, 17 insertions(+), 17 deletions(-) diff --git a/dlls/gdi32/enhmfdrv/dc.c b/dlls/gdi32/enhmfdrv/dc.c index 389dc38..cbf3f5c 100644 --- a/dlls/gdi32/enhmfdrv/dc.c +++ b/dlls/gdi32/enhmfdrv/dc.c @@ -262,7 +262,7 @@ BOOL EMFDRV_SetWindowExtEx( PHYSDEV dev, INT cx, INT cy, SIZE *size ) emr.szlExtent.cx = cx; emr.szlExtent.cy = cy; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pSetWindowExtEx( next, cx, cy, size ); } @@ -276,7 +276,7 @@ BOOL EMFDRV_SetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) emr.ptlOrigin.x = x; emr.ptlOrigin.y = y; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pSetViewportOrgEx( next, x, y, pt ); } @@ -290,7 +290,7 @@ BOOL EMFDRV_SetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) emr.ptlOrigin.x = x; emr.ptlOrigin.y = y; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pSetWindowOrgEx( next, x, y, pt ); } @@ -306,7 +306,7 @@ BOOL EMFDRV_ScaleViewportExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT emr.yNum = yNum; emr.yDenom = yDenom; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pScaleViewportExtEx( next, xNum, xDenom, yNum, yDenom, size ); } @@ -322,7 +322,7 @@ BOOL EMFDRV_ScaleWindowExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT y emr.yNum = yNum; emr.yDenom = yDenom; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pScaleWindowExtEx( next, xNum, xDenom, yNum, yDenom, size ); } @@ -376,7 +376,7 @@ BOOL EMFDRV_OffsetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) emr.ptlOrigin.x = prev.x + x; emr.ptlOrigin.y = prev.y + y; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pOffsetViewportOrgEx( next, x, y, pt ); } @@ -393,7 +393,7 @@ BOOL EMFDRV_OffsetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) emr.ptlOrigin.x = prev.x + x; emr.ptlOrigin.y = prev.y + y; - if (!EMFDRV_WriteRecord( dev, &emr.emr )) return 0; + if (!EMFDRV_WriteRecord( dev, &emr.emr )) return FALSE; return next->funcs->pOffsetWindowOrgEx( next, x, y, pt ); } diff --git a/dlls/gdi32/enhmfdrv/objects.c b/dlls/gdi32/enhmfdrv/objects.c index 60414a3..ee2abd7 100644 --- a/dlls/gdi32/enhmfdrv/objects.c +++ b/dlls/gdi32/enhmfdrv/objects.c @@ -243,7 +243,7 @@ static BOOL EMFDRV_CreateFontIndirect(PHYSDEV dev, HFONT hFont ) EMREXTCREATEFONTINDIRECTW emr; int i; - if (!GetObjectW( hFont, sizeof(emr.elfw.elfLogFont), &emr.elfw.elfLogFont )) return 0; + if (!GetObjectW( hFont, sizeof(emr.elfw.elfLogFont), &emr.elfw.elfLogFont )) return FALSE; emr.emr.iType = EMR_EXTCREATEFONTINDIRECTW; emr.emr.nSize = (sizeof(emr) + 3) / 4 * 4; diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 0dfd5b1..66072af 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -3378,7 +3378,7 @@ BOOL WINAPI GetCharWidthFloatA(HDC hdc, UINT iFirstChar, UINT iLastChar, PFLOAT pxBuffer) { FIXME("%p, %u, %u, %p: stub!\n", hdc, iFirstChar, iLastChar, pxBuffer); - return 0; + return FALSE; } /************************************************************************* @@ -3388,7 +3388,7 @@ BOOL WINAPI GetCharWidthFloatW(HDC hdc, UINT iFirstChar, UINT iLastChar, PFLOAT pxBuffer) { FIXME("%p, %u, %u, %p: stub!\n", hdc, iFirstChar, iLastChar, pxBuffer); - return 0; + return FALSE; } diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c index de64474..a255a4c 100644 --- a/dlls/gdi32/gdiobj.c +++ b/dlls/gdi32/gdiobj.c @@ -1325,8 +1325,8 @@ DWORD WINAPI GdiSetBatchLimit( DWORD limit ) */ BOOL WINAPI GetColorAdjustment(HDC hdc, LPCOLORADJUSTMENT lpca) { - FIXME("stub\n"); - return 0; + FIXME("stub\n"); + return FALSE; } /******************************************************************* @@ -1355,6 +1355,6 @@ BOOL WINAPI GdiComment(HDC hdc, UINT cbSize, const BYTE *lpData) */ BOOL WINAPI SetColorAdjustment(HDC hdc, const COLORADJUSTMENT* lpca) { - FIXME("stub\n"); - return 0; + FIXME("stub\n"); + return FALSE; } diff --git a/dlls/gdi32/mfdrv/objects.c b/dlls/gdi32/mfdrv/objects.c index 697644d..e0275dd 100644 --- a/dlls/gdi32/mfdrv/objects.c +++ b/dlls/gdi32/mfdrv/objects.c @@ -104,7 +104,7 @@ BOOL MFDRV_DeleteObject( PHYSDEV dev, HGDIOBJ obj ) index = MFDRV_FindObject(dev, obj); if( index < 0 ) - return 0; + return FALSE; mr.rdSize = sizeof mr / 2; mr.rdFunction = META_DELETEOBJECT; diff --git a/dlls/gdi32/palette.c b/dlls/gdi32/palette.c index fb27f4f..d850d0f 100644 --- a/dlls/gdi32/palette.c +++ b/dlls/gdi32/palette.c @@ -703,7 +703,7 @@ BOOL WINAPI UpdateColors( HMODULE mod; int size = GetDeviceCaps( hDC, SIZEPALETTE ); - if (!size) return 0; + if (!size) return FALSE; mod = GetModuleHandleA("user32.dll"); if (mod) @@ -723,7 +723,7 @@ BOOL WINAPI UpdateColors( } } } - return 0x666; + return TRUE; } /*********************************************************************

1 0

André Hentschel : kernel32: Use boolean return values in boolean functions.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 8439cc9da49cb0784705e246974e347a7056de5d URL: http://source.winehq.org/git/wine.git/?a=commit;h=8439cc9da49cb0784705e2469… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Jan 28 00:07:17 2014 +0100 kernel32: Use boolean return values in boolean functions. --- dlls/kernel32/process.c | 2 +- dlls/kernel32/resource.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index ca21e09..bf113d6 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -3544,7 +3544,7 @@ BOOL WINAPI QueryFullProcessImageNameW(HANDLE hProcess, DWORD dwFlags, LPWSTR lp if (ntlen + 1 > *pdwSize) { SetLastError(ERROR_INSUFFICIENT_BUFFER); - return 0; + return FALSE; } *pdwSize = ntlen; diff --git a/dlls/kernel32/resource.c b/dlls/kernel32/resource.c index a9491e0..e829f28 100644 --- a/dlls/kernel32/resource.c +++ b/dlls/kernel32/resource.c @@ -572,7 +572,7 @@ LPVOID WINAPI LockResource( HGLOBAL handle ) */ BOOL WINAPI FreeResource( HGLOBAL handle ) { - return 0; + return FALSE; }

1 0

Alexandre Julliard : configure: Merge the X_LIBS and XLIB variables.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 754b65062ebc3c6905bdc6b94ac653c24fc50244 URL: http://source.winehq.org/git/wine.git/?a=commit;h=754b65062ebc3c6905bdc6b94… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 30 11:47:20 2014 +0100 configure: Merge the X_LIBS and XLIB variables. --- configure | 42 +++++++++++++++++++---------------------- configure.ac | 43 ++++++++++++++++++------------------------ dlls/glu32/Makefile.in | 2 +- dlls/winex11.drv/Makefile.in | 2 +- 4 files changed, 39 insertions(+), 50 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=754b65062ebc3c6905bdc…

1 0

André Hentschel : msvcp90: Use boolean return values in boolean functions.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 63faf29c2aaf0706f487e206edd5a036ad841652 URL: http://source.winehq.org/git/wine.git/?a=commit;h=63faf29c2aaf0706f487e206e… Author: André Hentschel <nerv(a)dawncrow.de> Date: Tue Jan 28 00:08:10 2014 +0100 msvcp90: Use boolean return values in boolean functions. --- dlls/msvcp90/math.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/msvcp90/math.c b/dlls/msvcp90/math.c index f804ac9..11d3c75 100644 --- a/dlls/msvcp90/math.c +++ b/dlls/msvcp90/math.c @@ -462,7 +462,7 @@ __int64 __cdecl std_numeric_limits_int64_denorm_min(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_denorm_min(void) { return 0; } /* ?denorm_min@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::denorm_min(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_denorm_min(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_denorm_min(void) { return FALSE; } /* ?denorm_min@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::denorm_min(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_denorm_min(void) { return 0; } @@ -510,7 +510,7 @@ __int64 __cdecl std_numeric_limits_int64_epsilon(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_epsilon(void) { return 0; } /* ?epsilon@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::epsilon(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_epsilon(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_epsilon(void) { return FALSE; } /* ?epsilon@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::epsilon(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_epsilon(void) { return 0; } @@ -558,7 +558,7 @@ __int64 __cdecl std_numeric_limits_int64_infinity(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_infinity(void) { return 0; } /* ?infinity@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::infinity(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_infinity(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_infinity(void) { return FALSE; } /* ?infinity@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::infinity(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_infinity(void) { return 0; } @@ -606,7 +606,7 @@ __int64 __cdecl std_numeric_limits_int64_max(void) { return I64_MAX; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_max(void) { return UI64_MAX; } /* ?max@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::max(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_max(void) { return 1; } +BOOLEAN __cdecl std_numeric_limits_bool_max(void) { return TRUE; } /* ?max@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::max(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_max(void) { return USHRT_MAX; } @@ -654,7 +654,7 @@ __int64 __cdecl std_numeric_limits_int64_min(void) { return I64_MIN; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_min(void) { return 0; } /* ?min@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::min(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_min(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_min(void) { return FALSE; } /* ?min@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::min(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_min(void) { return 0; } @@ -702,7 +702,7 @@ __int64 __cdecl std_numeric_limits_int64_quiet_NaN(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_quiet_NaN(void) { return 0; } /* ?quiet_NaN@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::quiet_NaN(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_quiet_NaN(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_quiet_NaN(void) { return FALSE; } /* ?quiet_NaN@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::quiet_NaN(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_quiet_NaN(void) { return 0; } @@ -750,7 +750,7 @@ __int64 __cdecl std_numeric_limits_int64_round_error(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_round_error(void) { return 0; } /* ?round_error@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::round_error(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_round_error(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_round_error(void) { return FALSE; } /* ?round_error@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::round_error(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_round_error(void) { return 0; } @@ -798,7 +798,7 @@ __int64 __cdecl std_numeric_limits_int64_signaling_NaN(void) { return 0; } unsigned __int64 __cdecl std_numeric_limits_unsigned_int64_signaling_NaN(void) { return 0; } /* ?signaling_NaN@?$numeric_limits(a)_N@std@@SA_NXZ -> public: static bool __cdecl std::numeric_limits<bool>::signaling_NaN(void) */ -BOOLEAN __cdecl std_numeric_limits_bool_signaling_NaN(void) { return 0; } +BOOLEAN __cdecl std_numeric_limits_bool_signaling_NaN(void) { return FALSE; } /* ?signaling_NaN@?$numeric_limits(a)_W@std@@SA_WXZ -> public: static wchar_t __cdecl std::numeric_limits<wchar_t>::signaling_NaN(void) */ WCHAR __cdecl std_numeric_limits_wchar_t_signaling_NaN(void) { return 0; }

1 0

Michael Stefaniuc : dmband/tests: Use the standard COM tests for DirectMusicBandTrack.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: e2ced54e2b4e3d277bfcb96b93774d086b753f86 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e2ced54e2b4e3d277bfcb96b9… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Jan 30 00:54:41 2014 +0100 dmband/tests: Use the standard COM tests for DirectMusicBandTrack. --- dlls/dmband/tests/dmband.c | 75 ++++++++++++++++++++++++++++---------------- 1 file changed, 48 insertions(+), 27 deletions(-) diff --git a/dlls/dmband/tests/dmband.c b/dlls/dmband/tests/dmband.c index 0594c3e..60dbaca 100644 --- a/dlls/dmband/tests/dmband.c +++ b/dlls/dmband/tests/dmband.c @@ -94,35 +94,56 @@ static void test_COM(void) while (IDirectMusicBand_Release(dmb)); } -static void test_dmband(void) +static void test_COM_bandtrack(void) { - IUnknown *unknown = NULL; - IDirectMusicTrack *track = NULL; - IPersistStream *stream = NULL; - IPersistStream *private = NULL; + IDirectMusicTrack *dmbt = (IDirectMusicTrack*)0xdeadbeef; + IPersistStream *ps; + IUnknown *private; + IUnknown *unk; + ULONG refcount; HRESULT hr; - hr = CoCreateInstance(&CLSID_DirectMusicBandTrack, NULL, CLSCTX_INPROC_SERVER, &IID_IUnknown, (LPVOID*)&unknown); - ok(hr == S_OK, "CoCreateInstance returned: %x\n", hr); - hr = IUnknown_QueryInterface(unknown, &IID_IDirectMusicTrack, (LPVOID*)&track); - ok(hr == S_OK, "QueryInterface returned: %x\n", hr); - todo_wine ok((LPVOID)track == (LPVOID)unknown, "Interface are not the same %p != %p\n", stream, private); - hr = IUnknown_QueryInterface(unknown, &IID_IPersistStream, (LPVOID*)&stream); - ok(hr == S_OK, "QueryInterface returned: %x\n", hr); - /* Query private interface */ - hr = IUnknown_QueryInterface(unknown, &IID_IDirectMusicBandTrackPrivate, (LPVOID*)&private); - todo_wine ok(hr == S_OK, "QueryInterface returned: %x\n", hr); - - trace("Interfaces: unknown = %p, track = %p, stream = %p, private = %p\n", unknown, track, stream, private); - - if (private) - IPersistStream_Release(private); - if (stream) - IPersistStream_Release(stream); - if (track) - IDirectMusicTrack_Release(track); - if (unknown) - IUnknown_Release(unknown); + /* COM aggregation */ + hr = CoCreateInstance(&CLSID_DirectMusicBandTrack, (IUnknown*)&dmbt, CLSCTX_INPROC_SERVER, + &IID_IUnknown, (void**)&dmbt); + ok(hr == CLASS_E_NOAGGREGATION, + "DirectMusicBandTrack create failed: %08x, expected CLASS_E_NOAGGREGATION\n", hr); + ok(!dmbt, "dmbt = %p\n", dmbt); + + /* Invalid RIID */ + hr = CoCreateInstance(&CLSID_DirectMusicBandTrack, NULL, CLSCTX_INPROC_SERVER, + &IID_IDirectMusicObject, (void**)&dmbt); + ok(hr == E_NOINTERFACE, "DirectMusicBandTrack create failed: %08x, expected E_NOINTERFACE\n", hr); + + /* Same refcount for all DirectMusicBandTrack interfaces */ + hr = CoCreateInstance(&CLSID_DirectMusicBandTrack, NULL, CLSCTX_INPROC_SERVER, + &IID_IDirectMusicTrack, (void**)&dmbt); + ok(hr == S_OK, "DirectMusicBandTrack create failed: %08x, expected S_OK\n", hr); + refcount = IDirectMusicTrack_AddRef(dmbt); + ok(refcount == 2, "refcount == %u, expected 2\n", refcount); + + hr = IDirectMusicTrack_QueryInterface(dmbt, &IID_IPersistStream, (void**)&ps); + ok(hr == S_OK, "QueryInterface for IID_IPersistStream failed: %08x\n", hr); + refcount = IPersistStream_AddRef(ps); + ok(refcount == 4, "refcount == %u, expected 4\n", refcount); + refcount = IPersistStream_Release(ps); + + hr = IDirectMusicTrack_QueryInterface(dmbt, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "QueryInterface for IID_IUnknown failed: %08x\n", hr); + refcount = IUnknown_AddRef(unk); + ok(refcount == 5, "refcount == %u, expected 5\n", refcount); + refcount = IUnknown_Release(unk); + + hr = IDirectMusicTrack_QueryInterface(dmbt, &IID_IDirectMusicBandTrackPrivate, + (void**)&private); + todo_wine ok(hr == S_OK, "QueryInterface for IID_IDirectMusicBandTrackPrivate failed: %08x\n", hr); + if (hr == S_OK) { + refcount = IUnknown_AddRef(private); + ok(refcount == 6, "refcount == %u, expected 6\n", refcount); + refcount = IUnknown_Release(private); + } + + while (IDirectMusicTrack_Release(dmbt)); } START_TEST(dmband) @@ -137,7 +158,7 @@ START_TEST(dmband) } test_COM(); - test_dmband(); + test_COM_bandtrack(); CoUninitialize(); }

1 0

Michael Stefaniuc : dmband: COM cleanup for IDirectMusicBand.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: 868ad7dc723e339ab59fbf5430fa08fc17062bf1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=868ad7dc723e339ab59fbf543… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Jan 30 01:04:58 2014 +0100 dmband: COM cleanup for IDirectMusicBand. --- dlls/dmband/band.c | 23 ++++++++++++++--------- dlls/dmband/dmband_private.h | 2 +- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c index 74cd98c..a985977 100644 --- a/dlls/dmband/band.c +++ b/dlls/dmband/band.c @@ -26,6 +26,11 @@ WINE_DECLARE_DEBUG_CHANNEL(dmfile); /***************************************************************************** * IDirectMusicBandImpl implementation */ +static inline IDirectMusicBandImpl *impl_from_IDirectMusicBand(IDirectMusicBand *iface) +{ + return CONTAINING_RECORD(iface, IDirectMusicBandImpl, IDirectMusicBand_iface); +} + /* IDirectMusicBandImpl IUnknown part: */ static HRESULT WINAPI IDirectMusicBandImpl_IUnknown_QueryInterface (LPUNKNOWN iface, REFIID riid, LPVOID *ppobj) { ICOM_THIS_MULTI(IDirectMusicBandImpl, UnknownVtbl, iface); @@ -36,7 +41,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IUnknown_QueryInterface (LPUNKNOWN if IUnknown_AddRef (iface); return S_OK; } else if (IsEqualIID (riid, &IID_IDirectMusicBand)) { - *ppobj = &This->BandVtbl; + *ppobj = &This->IDirectMusicBand_iface; IUnknown_AddRef (iface); return S_OK; } else if (IsEqualIID (riid, &IID_IDirectMusicObject)) { @@ -89,26 +94,26 @@ static const IUnknownVtbl DirectMusicBand_Unknown_Vtbl = { static HRESULT WINAPI IDirectMusicBandImpl_QueryInterface(IDirectMusicBand *iface, REFIID riid, void **ppobj) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); return IUnknown_QueryInterface ((LPUNKNOWN)&This->UnknownVtbl, riid, ppobj); } static ULONG WINAPI IDirectMusicBandImpl_AddRef(IDirectMusicBand *iface) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); return IUnknown_AddRef ((LPUNKNOWN)&This->UnknownVtbl); } static ULONG WINAPI IDirectMusicBandImpl_Release(IDirectMusicBand *iface) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); return IUnknown_Release ((LPUNKNOWN)&This->UnknownVtbl); } static HRESULT WINAPI IDirectMusicBandImpl_CreateSegment(IDirectMusicBand *iface, IDirectMusicSegment **ppSegment) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); FIXME("(%p, %p): stub\n", This, ppSegment); return S_OK; } @@ -116,7 +121,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_CreateSegment(IDirectMusicBand *iface static HRESULT WINAPI IDirectMusicBandImpl_Download(IDirectMusicBand *iface, IDirectMusicPerformance *pPerformance) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); FIXME("(%p, %p): stub\n", This, pPerformance); return S_OK; } @@ -124,12 +129,12 @@ static HRESULT WINAPI IDirectMusicBandImpl_Download(IDirectMusicBand *iface, static HRESULT WINAPI IDirectMusicBandImpl_Unload(IDirectMusicBand *iface, IDirectMusicPerformance *pPerformance) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, BandVtbl, iface); + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); FIXME("(%p, %p): stub\n", This, pPerformance); return S_OK; } -static const IDirectMusicBandVtbl DirectMusicBand_Band_Vtbl = { +static const IDirectMusicBandVtbl dmband_vtbl = { IDirectMusicBandImpl_QueryInterface, IDirectMusicBandImpl_AddRef, IDirectMusicBandImpl_Release, @@ -707,7 +712,7 @@ HRESULT WINAPI create_dmband(REFIID lpcGUID, void **ppobj) return E_OUTOFMEMORY; } obj->UnknownVtbl = &DirectMusicBand_Unknown_Vtbl; - obj->BandVtbl = &DirectMusicBand_Band_Vtbl; + obj->IDirectMusicBand_iface.lpVtbl = &dmband_vtbl; obj->ObjectVtbl = &DirectMusicBand_Object_Vtbl; obj->PersistStreamVtbl = &DirectMusicBand_PersistStream_Vtbl; obj->pDesc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(DMUS_OBJECTDESC)); diff --git a/dlls/dmband/dmband_private.h b/dlls/dmband/dmband_private.h index b69e967..8dc0b12 100644 --- a/dlls/dmband/dmband_private.h +++ b/dlls/dmband/dmband_private.h @@ -88,7 +88,7 @@ typedef struct _DMUS_PRIVATE_BAND { struct IDirectMusicBandImpl { /* IUnknown fields */ const IUnknownVtbl *UnknownVtbl; - const IDirectMusicBandVtbl *BandVtbl; + IDirectMusicBand IDirectMusicBand_iface; const IDirectMusicObjectVtbl *ObjectVtbl; const IPersistStreamVtbl *PersistStreamVtbl; LONG ref;

1 0

Michael Stefaniuc : dmband: Remove the extraneous IUnknown from DirectMusicBand.
by Alexandre Julliard Jan. 30, 2014

Jan. 30, 2014

Module: wine Branch: master Commit: c1b3b58eac830c83200def7642dac0180e261822 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1b3b58eac830c83200def764… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Jan 30 01:06:43 2014 +0100 dmband: Remove the extraneous IUnknown from DirectMusicBand. Also lock/unlock the module only on creation/destruction of the object. --- dlls/dmband/band.c | 122 +++++++++++++++++------------------------- dlls/dmband/dmband_private.h | 2 - 2 files changed, 49 insertions(+), 75 deletions(-) diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c index a985977..97e7c30 100644 --- a/dlls/dmband/band.c +++ b/dlls/dmband/band.c @@ -31,83 +31,55 @@ static inline IDirectMusicBandImpl *impl_from_IDirectMusicBand(IDirectMusicBand return CONTAINING_RECORD(iface, IDirectMusicBandImpl, IDirectMusicBand_iface); } -/* IDirectMusicBandImpl IUnknown part: */ -static HRESULT WINAPI IDirectMusicBandImpl_IUnknown_QueryInterface (LPUNKNOWN iface, REFIID riid, LPVOID *ppobj) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, UnknownVtbl, iface); - - TRACE("(%p, %s, %p)\n", This, debugstr_dmguid(riid), ppobj); - if (IsEqualIID (riid, &IID_IUnknown)) { - *ppobj = &This->UnknownVtbl; - IUnknown_AddRef (iface); - return S_OK; - } else if (IsEqualIID (riid, &IID_IDirectMusicBand)) { - *ppobj = &This->IDirectMusicBand_iface; - IUnknown_AddRef (iface); - return S_OK; - } else if (IsEqualIID (riid, &IID_IDirectMusicObject)) { - *ppobj = &This->ObjectVtbl; - IUnknown_AddRef (iface); - return S_OK; - } else if (IsEqualIID (riid, &IID_IPersistStream)) { - *ppobj = &This->PersistStreamVtbl; - IUnknown_AddRef (iface); - return S_OK; - } - - WARN("(%p, %s, %p): not found\n", This, debugstr_dmguid(riid), ppobj); - return E_NOINTERFACE; -} - -static ULONG WINAPI IDirectMusicBandImpl_IUnknown_AddRef (LPUNKNOWN iface) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, UnknownVtbl, iface); - ULONG ref = InterlockedIncrement(&This->ref); - - TRACE("(%p) : AddRef from %d\n", This, ref - 1); - - DMBAND_LockModule(); - - return ref; -} - -static ULONG WINAPI IDirectMusicBandImpl_IUnknown_Release (LPUNKNOWN iface) { - ICOM_THIS_MULTI(IDirectMusicBandImpl, UnknownVtbl, iface); - ULONG ref = InterlockedDecrement(&This->ref); - - TRACE("(%p) : ReleaseRef to %d\n", This, ref); +/* DirectMusicBandImpl IDirectMusicBand part: */ +static HRESULT WINAPI IDirectMusicBandImpl_QueryInterface(IDirectMusicBand *iface, REFIID riid, + void **ret_iface) +{ + IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); - if (ref == 0) { - HeapFree(GetProcessHeap(), 0, This); - } + TRACE("(%p, %s, %p)\n", This, debugstr_dmguid(riid), ret_iface); - DMBAND_UnlockModule(); - - return ref; -} + *ret_iface = NULL; -static const IUnknownVtbl DirectMusicBand_Unknown_Vtbl = { - IDirectMusicBandImpl_IUnknown_QueryInterface, - IDirectMusicBandImpl_IUnknown_AddRef, - IDirectMusicBandImpl_IUnknown_Release -}; + if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IDirectMusicBand)) + *ret_iface = iface; + else if (IsEqualIID(riid, &IID_IDirectMusicObject)) + *ret_iface = &This->ObjectVtbl; + else if (IsEqualIID(riid, &IID_IPersistStream)) + *ret_iface = &This->PersistStreamVtbl; + else { + WARN("(%p, %s, %p): not found\n", This, debugstr_dmguid(riid), ret_iface); + return E_NOINTERFACE; + } -/* IDirectMusicBandImpl IDirectMusicBand part: */ -static HRESULT WINAPI IDirectMusicBandImpl_QueryInterface(IDirectMusicBand *iface, REFIID riid, - void **ppobj) -{ - IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); - return IUnknown_QueryInterface ((LPUNKNOWN)&This->UnknownVtbl, riid, ppobj); + IDirectMusicBand_AddRef((IUnknown*)*ret_iface); + return S_OK; } static ULONG WINAPI IDirectMusicBandImpl_AddRef(IDirectMusicBand *iface) { IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); - return IUnknown_AddRef ((LPUNKNOWN)&This->UnknownVtbl); + LONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + return ref; } static ULONG WINAPI IDirectMusicBandImpl_Release(IDirectMusicBand *iface) { IDirectMusicBandImpl *This = impl_from_IDirectMusicBand(iface); - return IUnknown_Release ((LPUNKNOWN)&This->UnknownVtbl); + LONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) ref=%d\n", This, ref); + + if (!ref) { + HeapFree(GetProcessHeap(), 0, This->pDesc); + HeapFree(GetProcessHeap(), 0, This); + DMBAND_UnlockModule(); + } + + return ref; } static HRESULT WINAPI IDirectMusicBandImpl_CreateSegment(IDirectMusicBand *iface, @@ -146,17 +118,17 @@ static const IDirectMusicBandVtbl dmband_vtbl = { /* IDirectMusicBandImpl IDirectMusicObject part: */ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_QueryInterface (LPDIRECTMUSICOBJECT iface, REFIID riid, LPVOID *ppobj) { ICOM_THIS_MULTI(IDirectMusicBandImpl, ObjectVtbl, iface); - return IUnknown_QueryInterface ((LPUNKNOWN)&This->UnknownVtbl, riid, ppobj); + return IDirectMusicBand_QueryInterface(&This->IDirectMusicBand_iface, riid, ppobj); } static ULONG WINAPI IDirectMusicBandImpl_IDirectMusicObject_AddRef (LPDIRECTMUSICOBJECT iface) { ICOM_THIS_MULTI(IDirectMusicBandImpl, ObjectVtbl, iface); - return IUnknown_AddRef ((LPUNKNOWN)&This->UnknownVtbl); + return IDirectMusicBand_AddRef(&This->IDirectMusicBand_iface); } static ULONG WINAPI IDirectMusicBandImpl_IDirectMusicObject_Release (LPDIRECTMUSICOBJECT iface) { ICOM_THIS_MULTI(IDirectMusicBandImpl, ObjectVtbl, iface); - return IUnknown_Release ((LPUNKNOWN)&This->UnknownVtbl); + return IDirectMusicBand_Release(&This->IDirectMusicBand_iface); } static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_GetDescriptor (LPDIRECTMUSICOBJECT iface, LPDMUS_OBJECTDESC pDesc) { @@ -360,17 +332,17 @@ static const IDirectMusicObjectVtbl DirectMusicBand_Object_Vtbl = { /* IDirectMusicBandImpl IPersistStream part: */ static HRESULT WINAPI IDirectMusicBandImpl_IPersistStream_QueryInterface (LPPERSISTSTREAM iface, REFIID riid, LPVOID *ppobj) { ICOM_THIS_MULTI(IDirectMusicBandImpl, PersistStreamVtbl, iface); - return IUnknown_QueryInterface ((LPUNKNOWN)&This->UnknownVtbl, riid, ppobj); + return IDirectMusicBand_QueryInterface(&This->IDirectMusicBand_iface, riid, ppobj); } static ULONG WINAPI IDirectMusicBandImpl_IPersistStream_AddRef (LPPERSISTSTREAM iface) { ICOM_THIS_MULTI(IDirectMusicBandImpl, PersistStreamVtbl, iface); - return IUnknown_AddRef ((LPUNKNOWN)&This->UnknownVtbl); + return IDirectMusicBand_AddRef(&This->IDirectMusicBand_iface); } static ULONG WINAPI IDirectMusicBandImpl_IPersistStream_Release (LPPERSISTSTREAM iface) { ICOM_THIS_MULTI(IDirectMusicBandImpl, PersistStreamVtbl, iface); - return IUnknown_Release ((LPUNKNOWN)&This->UnknownVtbl); + return IDirectMusicBand_Release(&This->IDirectMusicBand_iface); } static HRESULT WINAPI IDirectMusicBandImpl_IPersistStream_GetClassID (LPPERSISTSTREAM iface, CLSID* pClassID) { @@ -705,13 +677,13 @@ static const IPersistStreamVtbl DirectMusicBand_PersistStream_Vtbl = { HRESULT WINAPI create_dmband(REFIID lpcGUID, void **ppobj) { IDirectMusicBandImpl* obj; - + HRESULT hr; + obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicBandImpl)); if (NULL == obj) { *ppobj = NULL; return E_OUTOFMEMORY; } - obj->UnknownVtbl = &DirectMusicBand_Unknown_Vtbl; obj->IDirectMusicBand_iface.lpVtbl = &dmband_vtbl; obj->ObjectVtbl = &DirectMusicBand_Object_Vtbl; obj->PersistStreamVtbl = &DirectMusicBand_PersistStream_Vtbl; @@ -719,8 +691,12 @@ HRESULT WINAPI create_dmband(REFIID lpcGUID, void **ppobj) DM_STRUCT_INIT(obj->pDesc); obj->pDesc->dwValidData |= DMUS_OBJ_CLASS; obj->pDesc->guidClass = CLSID_DirectMusicBand; - obj->ref = 0; /* will be inited by QueryInterface */ + obj->ref = 1; list_init (&obj->Instruments); - return IDirectMusicBandImpl_IUnknown_QueryInterface ((LPUNKNOWN)&obj->UnknownVtbl, lpcGUID, ppobj); + DMBAND_LockModule(); + hr = IDirectMusicBand_QueryInterface(&obj->IDirectMusicBand_iface, lpcGUID, ppobj); + IDirectMusicBand_Release(&obj->IDirectMusicBand_iface); + + return hr; } diff --git a/dlls/dmband/dmband_private.h b/dlls/dmband/dmband_private.h index 8dc0b12..6be6ae8 100644 --- a/dlls/dmband/dmband_private.h +++ b/dlls/dmband/dmband_private.h @@ -86,8 +86,6 @@ typedef struct _DMUS_PRIVATE_BAND { * IDirectMusicBandImpl implementation structure */ struct IDirectMusicBandImpl { - /* IUnknown fields */ - const IUnknownVtbl *UnknownVtbl; IDirectMusicBand IDirectMusicBand_iface; const IDirectMusicObjectVtbl *ObjectVtbl; const IPersistStreamVtbl *PersistStreamVtbl;

1 0