November 2014 - Wine-Commits

André Hentschel : winecfg: Remove unused strings ( Clang).
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: aa59d5b7bc3059d18e34149388bfb67c37da7495 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa59d5b7bc3059d18e3414938… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Nov 21 20:58:39 2014 +0100 winecfg: Remove unused strings (Clang). --- programs/winecfg/x11drvdlg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/programs/winecfg/x11drvdlg.c b/programs/winecfg/x11drvdlg.c index 8d914ad..809068e 100644 --- a/programs/winecfg/x11drvdlg.c +++ b/programs/winecfg/x11drvdlg.c @@ -51,8 +51,6 @@ static const WCHAR defaultW[] = {'D','e','f','a','u','l','t',0}; static const WCHAR explorerW[] = {'E','x','p','l','o','r','e','r',0}; static const WCHAR explorer_desktopsW[] = {'E','x','p','l','o','r','e','r','\\', 'D','e','s','k','t','o','p','s',0}; -static const WCHAR x11_driverW[] = {'X','1','1',' ','D','r','i','v','e','r',0}; -static const WCHAR default_resW[] = {'8','0','0','x','6','0','0',0}; static BOOL updating_ui;

1 0

André Hentschel : crypt32/tests: Comment out an unused struct (Clang).
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: 86c1d068f2903eb60d897d53419ea1b1ec462cb1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=86c1d068f2903eb60d897d534… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Nov 21 20:59:11 2014 +0100 crypt32/tests: Comment out an unused struct (Clang). --- dlls/crypt32/tests/base64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/crypt32/tests/base64.c b/dlls/crypt32/tests/base64.c index 8f19515..c6073aa 100644 --- a/dlls/crypt32/tests/base64.c +++ b/dlls/crypt32/tests/base64.c @@ -57,7 +57,7 @@ struct BinTests static const BYTE toEncode1[] = { 0 }; static const BYTE toEncode2[] = { 1,2 }; -static const BYTE toEncode3[] = { 1,2,3 }; +/* static const BYTE toEncode3[] = { 1,2,3 }; */ static const BYTE toEncode4[] = "abcdefghijlkmnopqrstuvwxyz01234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ01234567890" "abcdefghijlkmnopqrstuvwxyz01234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ01234567890"

1 0

Stefan Dösinger : d3d8: Only one fullscreen swapchain is allowed.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: dd8bf9c87d298a05e3b6fbbcfa5e52b2b3f8e7f4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dd8bf9c87d298a05e3b6fbbcf… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Nov 25 10:16:55 2014 +0100 d3d8: Only one fullscreen swapchain is allowed. --- dlls/d3d8/device.c | 25 +++++++++++++++++++++++++ dlls/d3d8/tests/device.c | 38 +++++++++++++++++++++++++++++++++++++- 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index dd0b9ee..4c17e7c 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -557,11 +557,36 @@ static HRESULT WINAPI d3d8_device_CreateAdditionalSwapChain(IDirect3DDevice8 *if struct d3d8_device *device = impl_from_IDirect3DDevice8(iface); struct wined3d_swapchain_desc desc; struct d3d8_swapchain *object; + UINT i, count; HRESULT hr; TRACE("iface %p, present_parameters %p, swapchain %p.\n", iface, present_parameters, swapchain); + if (!present_parameters->Windowed) + { + WARN("Trying to create an additional fullscreen swapchain, returning D3DERR_INVALIDCALL.\n"); + return D3DERR_INVALIDCALL; + } + + wined3d_mutex_lock(); + count = wined3d_device_get_swapchain_count(device->wined3d_device); + for (i = 0; i < count; ++i) + { + struct wined3d_swapchain *wined3d_swapchain; + + wined3d_swapchain = wined3d_device_get_swapchain(device->wined3d_device, i); + wined3d_swapchain_get_desc(wined3d_swapchain, &desc); + + if (!desc.windowed) + { + wined3d_mutex_unlock(); + WARN("Trying to create an additional swapchain in fullscreen mode, returning D3DERR_INVALIDCALL.\n"); + return D3DERR_INVALIDCALL; + } + } + wined3d_mutex_unlock(); + wined3d_swapchain_desc_from_present_parameters(&desc, present_parameters); if (SUCCEEDED(hr = d3d8_swapchain_create(device, &desc, &object))) *swapchain = &object->IDirect3DSwapChain8_iface; diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 2733664..c8f9713 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -262,12 +262,16 @@ static void test_swapchain(void) IDirect3DDevice8 *device; IDirect3D8 *d3d; ULONG refcount; - HWND window; + HWND window, window2; HRESULT hr; + struct device_desc device_desc; window = CreateWindowA("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, 0, 0, 640, 480, NULL, NULL, NULL, NULL); ok(!!window, "Failed to create a window.\n"); + window2 = CreateWindowA("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, + 0, 0, 640, 480, NULL, NULL, NULL, NULL); + ok(!!window2, "Failed to create a window.\n"); d3d = Direct3DCreate8(D3D_SDK_VERSION); ok(!!d3d, "Failed to create a D3D object.\n"); if (!(device = create_device(d3d, window, NULL))) @@ -356,10 +360,42 @@ static void test_swapchain(void) IDirect3DSwapChain8_Release(swapchain3); IDirect3DSwapChain8_Release(swapchain2); IDirect3DSwapChain8_Release(swapchain1); + + d3dpp.Windowed = FALSE; + d3dpp.hDeviceWindow = window; + d3dpp.BackBufferCount = 1; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + + device_desc.width = registry_mode.dmPelsWidth; + device_desc.height = registry_mode.dmPelsHeight; + device_desc.device_window = window; + device_desc.flags = CREATE_DEVICE_FULLSCREEN; + hr = reset_device(device, &device_desc); + ok(SUCCEEDED(hr), "Failed to reset device, hr %#x.\n", hr); + + d3dpp.hDeviceWindow = window; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.Windowed = TRUE; + d3dpp.hDeviceWindow = window; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice8_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + refcount = IDirect3DDevice8_Release(device); ok(!refcount, "Device has %u references left.\n", refcount); cleanup: IDirect3D8_Release(d3d); + DestroyWindow(window2); DestroyWindow(window); }

1 0

Stefan Dösinger : d3d9: Only one fullscreen swapchain is allowed.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: 8b6a7a9c02d048949cf4b0e9b72494213d55ead2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b6a7a9c02d048949cf4b0e9b… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Nov 25 10:16:54 2014 +0100 d3d9: Only one fullscreen swapchain is allowed. --- dlls/d3d9/device.c | 25 +++++++++++++++++++++++++ dlls/d3d9/tests/device.c | 38 +++++++++++++++++++++++++++++++++++++- 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index ca902a2..67a5629 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -503,11 +503,36 @@ static HRESULT WINAPI DECLSPEC_HOTPATCH d3d9_device_CreateAdditionalSwapChain(ID struct d3d9_device *device = impl_from_IDirect3DDevice9Ex(iface); struct wined3d_swapchain_desc desc; struct d3d9_swapchain *object; + UINT i, count; HRESULT hr; TRACE("iface %p, present_parameters %p, swapchain %p.\n", iface, present_parameters, swapchain); + if (!present_parameters->Windowed) + { + WARN("Trying to create an additional fullscreen swapchain, returning D3DERR_INVALIDCALL.\n"); + return D3DERR_INVALIDCALL; + } + + wined3d_mutex_lock(); + count = wined3d_device_get_swapchain_count(device->wined3d_device); + for (i = 0; i < count; ++i) + { + struct wined3d_swapchain *wined3d_swapchain; + + wined3d_swapchain = wined3d_device_get_swapchain(device->wined3d_device, i); + wined3d_swapchain_get_desc(wined3d_swapchain, &desc); + + if (!desc.windowed) + { + wined3d_mutex_unlock(); + WARN("Trying to create an additional swapchain in fullscreen mode, returning D3DERR_INVALIDCALL.\n"); + return D3DERR_INVALIDCALL; + } + } + wined3d_mutex_unlock(); + wined3d_swapchain_desc_from_present_parameters(&desc, present_parameters); if (SUCCEEDED(hr = d3d9_swapchain_create(device, &desc, &object))) *swapchain = (IDirect3DSwapChain9 *)&object->IDirect3DSwapChain9Ex_iface; diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 35dad62..061846b 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -1058,12 +1058,16 @@ static void test_swapchain(void) IDirect3DDevice9 *device; IDirect3D9 *d3d; ULONG refcount; - HWND window; + HWND window, window2; HRESULT hr; + struct device_desc device_desc; window = CreateWindowA("d3d9_test_wc", "d3d9_test", WS_OVERLAPPEDWINDOW, 0, 0, 640, 480, NULL, NULL, NULL, NULL); ok(!!window, "Failed to create a window.\n"); + window2 = CreateWindowA("d3d9_test_wc", "d3d9_test", WS_OVERLAPPEDWINDOW, + 0, 0, 640, 480, NULL, NULL, NULL, NULL); + ok(!!window2, "Failed to create a window.\n"); d3d = Direct3DCreate9(D3D_SDK_VERSION); ok(!!d3d, "Failed to create a D3D object.\n"); if (!(device = create_device(d3d, window, NULL))) @@ -1176,10 +1180,42 @@ static void test_swapchain(void) IDirect3DSwapChain9_Release(swapchain3); IDirect3DSwapChain9_Release(swapchain2); IDirect3DSwapChain9_Release(swapchain1); + + d3dpp.Windowed = FALSE; + d3dpp.hDeviceWindow = window; + d3dpp.BackBufferCount = 1; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + + device_desc.width = registry_mode.dmPelsWidth; + device_desc.height = registry_mode.dmPelsHeight; + device_desc.device_window = window; + device_desc.flags = CREATE_DEVICE_FULLSCREEN; + hr = reset_device(device, &device_desc); + ok(SUCCEEDED(hr), "Failed to reset device, hr %#x.\n", hr); + + d3dpp.hDeviceWindow = window; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.Windowed = TRUE; + d3dpp.hDeviceWindow = window; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + d3dpp.hDeviceWindow = window2; + hr = IDirect3DDevice9_CreateAdditionalSwapChain(device, &d3dpp, &swapchain1); + ok(hr == D3DERR_INVALIDCALL, "Got unexpected hr %#x\n", hr); + refcount = IDirect3DDevice9_Release(device); ok(!refcount, "Device has %u references left.\n", refcount); cleanup: IDirect3D9_Release(d3d); + DestroyWindow(window2); DestroyWindow(window); }

1 0

Jacek Caban : mshtml: Added IHTMLTxtRange::setEndPoint implementation.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: 20b3aa62440a123aad1233c8598e9161a0b7ea8b URL: http://source.winehq.org/git/wine.git/?a=commit;h=20b3aa62440a123aad1233c85… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Nov 24 18:47:41 2014 +0100 mshtml: Added IHTMLTxtRange::setEndPoint implementation. --- dlls/mshtml/tests/dom.c | 75 ++++++++++++++++++++++++++++++++++++++++--------- dlls/mshtml/txtrange.c | 70 +++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 129 insertions(+), 16 deletions(-) diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index 2d526fc..8a47207 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -4901,6 +4901,30 @@ static IHTMLTxtRange *test_create_body_range(IHTMLDocument2 *doc) return range; } +#define range_duplicate(a) _range_duplicate(__LINE__,a) +static IHTMLTxtRange *_range_duplicate(unsigned line, IHTMLTxtRange *range) +{ + IHTMLTxtRange *ret; + HRESULT hres; + + hres = IHTMLTxtRange_duplicate(range, &ret); + ok_(__FILE__,line)(hres == S_OK, "duplicate failed: %08x\n", hres); + + return ret; +} + +#define test_range_set_end_point(a,b,c,d) _test_range_set_end_point(__LINE__,a,b,c,d) +static void _test_range_set_end_point(unsigned line, IHTMLTxtRange *range, const char *how, + IHTMLTxtRange *ref_range, HRESULT exhres) +{ + BSTR str = a2bstr(how); + HRESULT hres; + + hres = IHTMLTxtRange_setEndPoint(range, str, ref_range); + ok_(__FILE__,line)(hres == exhres, "setEndPoint failed: %08x, expected %08x\n", hres, exhres); + SysFreeString(str); +} + static void test_txtrange(IHTMLDocument2 *doc) { IHTMLTxtRange *body_range, *range, *range2; @@ -4915,11 +4939,9 @@ static void test_txtrange(IHTMLDocument2 *doc) test_range_text(body_range, "test abc 123\r\nit's text"); - hres = IHTMLTxtRange_duplicate(body_range, &range); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); + range = range_duplicate(body_range); + range2 = range_duplicate(body_range); - hres = IHTMLTxtRange_duplicate(body_range, &range2); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); test_range_isequal(range, range2, VARIANT_TRUE); test_range_text(range, "test abc 123\r\nit's text"); @@ -4959,8 +4981,7 @@ static void test_txtrange(IHTMLDocument2 *doc) IHTMLTxtRange_Release(range); - hres = IHTMLTxtRange_duplicate(body_range, &range); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); + range = range_duplicate(body_range); test_range_text(range, "test abc 123\r\nit's text"); test_range_move(range, characterW, 3, 3); @@ -4978,8 +4999,7 @@ static void test_txtrange(IHTMLDocument2 *doc) IHTMLTxtRange_Release(range); - hres = IHTMLTxtRange_duplicate(body_range, &range); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); + range = range_duplicate(body_range); test_range_move(range, wordW, 1, 1); test_range_moveend(range, characterW, 2, 2); @@ -5005,8 +5025,7 @@ static void test_txtrange(IHTMLDocument2 *doc) IHTMLTxtRange_Release(range); - hres = IHTMLTxtRange_duplicate(body_range, &range); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); + range = range_duplicate(body_range); test_range_move(range, wordW, 2, 2); test_range_moveend(range, characterW, 2, 2); @@ -5030,8 +5049,7 @@ static void test_txtrange(IHTMLDocument2 *doc) IHTMLTxtRange_Release(range); - hres = IHTMLTxtRange_duplicate(body_range, &range); - ok(hres == S_OK, "duplicate failed: %08x\n", hres); + range = range_duplicate(body_range); test_range_collapse(range, TRUE); test_range_expand(range, wordW, VARIANT_TRUE, "test "); @@ -5054,7 +5072,6 @@ static void test_txtrange(IHTMLDocument2 *doc) test_range_text(range, NULL); IHTMLTxtRange_Release(range); - IHTMLTxtRange_Release(body_range); hres = IHTMLDocument2_get_selection(doc, &selection); ok(hres == S_OK, "IHTMLDocument2_get_selection failed: %08x\n", hres); @@ -5116,9 +5133,39 @@ static void test_txtrange(IHTMLDocument2 *doc) test_range_text(range, "abc \r\npaste\r\nxyz abc 123\r\nit's text"); - IHTMLElement_Release(body); + test_range_move(range, wordW, 2, 2); + test_range_collapse(range, VARIANT_TRUE); + test_range_moveend(range, characterW, 5, 5); + test_range_text(range, "paste"); + + range2 = range_duplicate(range); + + test_range_set_end_point(range, "starttostart", body_range, S_OK); + test_range_text(range, "abc \r\npaste"); + + test_range_set_end_point(range, "endtoend", body_range, S_OK); + test_range_text(range, "abc \r\npaste\r\nxyz abc 123\r\nit's text"); + + test_range_set_end_point(range, "starttoend", range2, S_OK); + test_range_text(range, "\r\nxyz abc 123\r\nit's text"); + + test_range_set_end_point(range, "starttostart", body_range, S_OK); + test_range_set_end_point(range, "endtostart", range2, S_OK); + test_range_text(range, "abc "); + + test_range_set_end_point(range, "starttoend", body_range, S_OK); + test_range_text(range, "paste\r\nxyz abc 123\r\nit's text"); + + test_range_set_end_point(range, "EndToStart", body_range, S_OK); + test_range_text(range, "abc "); + + test_range_set_end_point(range, "xxx", body_range, E_INVALIDARG); IHTMLTxtRange_Release(range); + IHTMLTxtRange_Release(range2); + IHTMLTxtRange_Release(body_range); + IHTMLElement_Release(body); + } static void test_txtrange2(IHTMLDocument2 *doc) diff --git a/dlls/mshtml/txtrange.c b/dlls/mshtml/txtrange.c index 43c9f1a..0dd3aae 100644 --- a/dlls/mshtml/txtrange.c +++ b/dlls/mshtml/txtrange.c @@ -1627,8 +1627,74 @@ static HRESULT WINAPI HTMLTxtRange_setEndPoint(IHTMLTxtRange *iface, BSTR how, IHTMLTxtRange *SourceRange) { HTMLTxtRange *This = impl_from_IHTMLTxtRange(iface); - FIXME("(%p)->(%s %p)\n", This, debugstr_w(how), SourceRange); - return E_NOTIMPL; + HTMLTxtRange *src_range; + nsIDOMNode *ref_node; + INT32 ref_offset; + BOOL set_start; + int how_type; + INT16 cmp; + nsresult nsres; + + TRACE("(%p)->(%s %p)\n", This, debugstr_w(how), SourceRange); + + how_type = string_to_nscmptype(how); + if(how_type == -1) + return E_INVALIDARG; + + src_range = get_range_object(This->doc, SourceRange); + if(!src_range) + return E_FAIL; + + switch(how_type) { + case NS_START_TO_START: + case NS_END_TO_START: + nsres = nsIDOMRange_GetStartContainer(src_range->nsrange, &ref_node); + assert(nsres == NS_OK); + + nsres = nsIDOMRange_GetStartOffset(src_range->nsrange, &ref_offset); + assert(nsres == NS_OK); + + set_start = how_type == NS_START_TO_START; + break; + case NS_END_TO_END: + case NS_START_TO_END: + nsres = nsIDOMRange_GetEndContainer(src_range->nsrange, &ref_node); + assert(nsres == NS_OK); + + nsres = nsIDOMRange_GetEndOffset(src_range->nsrange, &ref_offset); + assert(nsres == NS_OK); + + set_start = how_type == NS_START_TO_END; + break; + DEFAULT_UNREACHABLE; + } + + nsres = nsIDOMRange_ComparePoint(This->nsrange, ref_node, ref_offset, &cmp); + assert(nsres == NS_OK); + + if(set_start) { + if(cmp <= 0) { + nsres = nsIDOMRange_SetStart(This->nsrange, ref_node, ref_offset); + }else { + nsres = nsIDOMRange_Collapse(This->nsrange, FALSE); + assert(nsres == NS_OK); + + nsres = nsIDOMRange_SetEnd(This->nsrange, ref_node, ref_offset); + } + }else { + if(cmp >= 0) { + nsres = nsIDOMRange_SetEnd(This->nsrange, ref_node, ref_offset); + }else { + nsres = nsIDOMRange_Collapse(This->nsrange, TRUE); + assert(nsres == NS_OK); + + nsres = nsIDOMRange_SetStart(This->nsrange, ref_node, ref_offset); + } + } + assert(nsres == NS_OK); + + nsIDOMNode_Release(ref_node); + return S_OK; } static HRESULT WINAPI HTMLTxtRange_compareEndPoints(IHTMLTxtRange *iface, BSTR how,

1 0

Jacek Caban : mshtml: Added IHTMLDocument2::execCommand implementation.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: a0d1d8cd27a4f5d2212f9524cc56be935c5d0483 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0d1d8cd27a4f5d2212f9524c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Nov 24 13:03:30 2014 +0100 mshtml: Added IHTMLDocument2::execCommand implementation. --- dlls/mshtml/htmldoc.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++-- dlls/mshtml/tests/dom.c | 18 +++++++++++++++ 2 files changed, 75 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 60ee739..c760c36 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -31,6 +31,7 @@ #include "ole2.h" #include "perhist.h" #include "mshtmdid.h" +#include "mshtmcid.h" #include "wine/debug.h" @@ -1095,6 +1096,40 @@ static HRESULT WINAPI HTMLDocument_clear(IHTMLDocument2 *iface) return S_OK; } +static const WCHAR insertorderedlistW[] = + {'i','n','s','e','r','t','o','r','d','e','r','e','d','l','i','s','t',0}; +static const WCHAR insertunorderedlistW[] = + {'i','n','s','e','r','t','u','n','o','r','d','e','r','e','d','l','i','s','t',0}; +static const WCHAR outdentW[] = + {'o','u','t','d','e','n','t',0}; +static const WCHAR respectvisibilityindesignW[] = + {'r','e','s','p','e','c','t','v','i','s','i','b','i','l','i','t','y','i','n','d','e','s','i','g','n',0}; + +static const struct { + const WCHAR *name; + OLECMDID id; +}command_names[] = { + {insertorderedlistW, IDM_ORDERLIST}, + {insertunorderedlistW, IDM_UNORDERLIST}, + {outdentW, IDM_OUTDENT}, + {respectvisibilityindesignW, IDM_RESPECTVISIBILITY_INDESIGN} +}; + +static BOOL cmdid_from_string(const WCHAR *str, OLECMDID *cmdid) +{ + int i; + + for(i = 0; i < sizeof(command_names)/sizeof(*command_names); i++) { + if(!strcmpiW(command_names[i].name, str)) { + *cmdid = command_names[i].id; + return TRUE; + } + } + + FIXME("Unknown command %s\n", debugstr_w(str)); + return FALSE; +} + static HRESULT WINAPI HTMLDocument_queryCommandSupported(IHTMLDocument2 *iface, BSTR cmdID, VARIANT_BOOL *pfRet) { @@ -1147,8 +1182,28 @@ static HRESULT WINAPI HTMLDocument_execCommand(IHTMLDocument2 *iface, BSTR cmdID VARIANT_BOOL showUI, VARIANT value, VARIANT_BOOL *pfRet) { HTMLDocument *This = impl_from_IHTMLDocument2(iface); - FIXME("(%p)->(%s %x %s %p)\n", This, debugstr_w(cmdID), showUI, debugstr_variant(&value), pfRet); - return E_NOTIMPL; + OLECMDID cmdid; + VARIANT ret; + HRESULT hres; + + TRACE("(%p)->(%s %x %s %p)\n", This, debugstr_w(cmdID), showUI, debugstr_variant(&value), pfRet); + + if(!cmdid_from_string(cmdID, &cmdid)) + return OLECMDERR_E_NOTSUPPORTED; + + V_VT(&ret) = VT_EMPTY; + hres = IOleCommandTarget_Exec(&This->IOleCommandTarget_iface, &CGID_MSHTML, cmdid, + showUI ? 0 : OLECMDEXECOPT_DONTPROMPTUSER, &value, &ret); + if(FAILED(hres)) + return hres; + + if(V_VT(&ret) != VT_EMPTY) { + FIXME("Handle ret %s\n", debugstr_variant(&ret)); + VariantClear(&ret); + } + + *pfRet = VARIANT_TRUE; + return S_OK; } static HRESULT WINAPI HTMLDocument_execCommandShowHelp(IHTMLDocument2 *iface, BSTR cmdID, diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index a919b3d..2d526fc 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -6005,8 +6005,10 @@ static void test_defaults(IHTMLDocument2 *doc) IHTMLElement2 *elem2; IHTMLElement *elem; IHTMLStyle *style; + VARIANT v; BSTR str; LONG l; + VARIANT_BOOL b; HRESULT hres; IHTMLElementCollection *collection; @@ -6129,6 +6131,22 @@ static void test_defaults(IHTMLDocument2 *doc) hres = IHTMLElement_QueryInterface(elem, &IID_IHTMLFiltersCollection, (void**)&body); ok(hres == E_NOINTERFACE, "got interface IHTMLFiltersCollection\n"); + str = a2bstr("xxx"); + b = 100; + V_VT(&v) = VT_EMPTY; + hres = IHTMLDocument2_execCommand(doc, str, FALSE, v, &b); + ok(hres == OLECMDERR_E_NOTSUPPORTED || hres == E_INVALIDARG, + "execCommand failed: %08x, expected OLECMDERR_E_NOTSUPPORTED or E_INVALIDARG\n", hres); + SysFreeString(str); + + str = a2bstr("respectvisibilityindesign"); + b = 100; + V_VT(&v) = VT_BOOL; + V_BOOL(&v) = VARIANT_TRUE; + hres = IHTMLDocument2_execCommand(doc, str, FALSE, v, &b); + ok(hres == S_OK, "execCommand failed: %08x, expected DRAGDROP_E_NOTREGISTERED\n", hres); + SysFreeString(str); + test_default_selection(doc); test_doc_title(doc, ""); test_dom_implementation(doc);

1 0

Jacek Caban : mshtml: Improved IDM_RESPECTVISIBILITY_INDESIGN stub.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: d90016ffed93d1e2e8937329f807300c843e4f9e URL: http://source.winehq.org/git/wine.git/?a=commit;h=d90016ffed93d1e2e8937329f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Nov 24 13:03:24 2014 +0100 mshtml: Improved IDM_RESPECTVISIBILITY_INDESIGN stub. --- dlls/mshtml/olecmd.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index 082777c..eea3aa2 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -615,8 +615,13 @@ static HRESULT exec_baselinefont3(HTMLDocument *This, DWORD cmdexecopt, VARIANT static HRESULT exec_respectvisibility_indesign(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, VARIANT *out) { - FIXME("(%p)->(%08x %p %p)\n", This, cmdexecopt, in, out); - return E_NOTIMPL; + TRACE("(%p)->(%x %s %p)\n", This, cmdexecopt, debugstr_variant(in), out); + + /* This is turned on by default in Gecko. */ + if(!in || V_VT(in) != VT_BOOL || !V_BOOL(in)) + FIXME("Unsupported argument %s\n", debugstr_variant(in)); + + return S_OK; } static HRESULT query_enabled_stub(HTMLDocument *This, OLECMD *cmd)

1 0

Jacek Caban : mshtml/tests: Fixed some test failures.
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: 53d2778f97f865da6978b87d13ce74936f5064ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=53d2778f97f865da6978b87d1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 25 13:22:44 2014 +0100 mshtml/tests: Fixed some test failures. --- dlls/mshtml/tests/htmldoc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index 84b8806..ace3128 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -2988,6 +2988,9 @@ static HRESULT WINAPI OleCommandTarget_Exec(IOleCommandTarget *iface, const GUID case 144: /* TODO */ case 178: case 179: + case 180: + case 181: + case 182: return E_NOTIMPL; default:

1 0

Stefan Dösinger : d3d8/tests: Fix test_cursor().
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: 4e8da470f850245a1b2bbac850b8ee59e135c560 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4e8da470f850245a1b2bbac85… Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Nov 21 18:32:30 2014 +0100 d3d8/tests: Fix test_cursor(). --- dlls/d3d8/tests/device.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index c8f9713..99fe70a 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -759,6 +759,7 @@ static void test_cursor(void) HCURSOR cur; HWND window; HRESULT hr; + BOOL ret; pGetCursorInfo = (void *)GetProcAddress(user32_handle, "GetCursorInfo"); if (!pGetCursorInfo) @@ -767,14 +768,19 @@ static void test_cursor(void) return; } + window = CreateWindowA("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW | WS_VISIBLE, + 0, 0, 640, 480, NULL, NULL, NULL, NULL); + ok(!!window, "Failed to create a window.\n"); + + ret = SetCursorPos(50, 50); + ok(ret, "Failed to set cursor position.\n"); + flush_events(); + memset(&info, 0, sizeof(info)); info.cbSize = sizeof(info); ok(pGetCursorInfo(&info), "GetCursorInfo failed\n"); cur = info.hCursor; - window = CreateWindowA("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, - 0, 0, 640, 480, NULL, NULL, NULL, NULL); - ok(!!window, "Failed to create a window.\n"); d3d = Direct3DCreate8(D3D_SDK_VERSION); ok(!!d3d, "Failed to create a D3D object.\n"); if (!(device = create_device(d3d, window, NULL))) @@ -817,12 +823,11 @@ static void test_cursor(void) hr = IDirect3DDevice8_ShowCursor(device, TRUE); ok(hr == TRUE, "IDirect3DDevice8_ShowCursor returned %#08x\n", hr); - /* GDI cursor unchanged */ memset(&info, 0, sizeof(info)); info.cbSize = sizeof(info); ok(pGetCursorInfo(&info), "GetCursorInfo failed\n"); ok(info.flags & CURSOR_SHOWING, "The gdi cursor is hidden (%08x)\n", info.flags); - ok(info.hCursor == cur, "The cursor handle is %p\n", info.hCursor); /* unchanged */ + ok(info.hCursor != cur, "The cursor handle is %p\n", info.hCursor); refcount = IDirect3DDevice8_Release(device); ok(!refcount, "Device has %u references left.\n", refcount);

1 0

André Hentschel : jscript: Remove unused code (Clang) .
by Alexandre Julliard Nov. 25, 2014

Nov. 25, 2014

Module: wine Branch: master Commit: dec5bbbec4eb502b6893fb7d97cb1a2faffd0a2c URL: http://source.winehq.org/git/wine.git/?a=commit;h=dec5bbbec4eb502b6893fb7d9… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Nov 21 20:58:38 2014 +0100 jscript: Remove unused code (Clang). --- dlls/jscript/engine.c | 5 ----- dlls/jscript/jsregexp.c | 2 -- 2 files changed, 7 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 9c6acb3..de60755 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -398,11 +398,6 @@ static HRESULT disp_get_id(script_ctx_t *ctx, IDispatch *disp, const WCHAR *name return hres; } -static inline BOOL var_is_null(const VARIANT *v) -{ - return V_VT(v) == VT_NULL || (V_VT(v) == VT_DISPATCH && !V_DISPATCH(v)); -} - static HRESULT disp_cmp(IDispatch *disp1, IDispatch *disp2, BOOL *ret) { IObjectIdentity *identity; diff --git a/dlls/jscript/jsregexp.c b/dlls/jscript/jsregexp.c index d6602f4..c39e3a1 100644 --- a/dlls/jscript/jsregexp.c +++ b/dlls/jscript/jsregexp.c @@ -58,8 +58,6 @@ static const WCHAR idx7W[] = {'$','7',0}; static const WCHAR idx8W[] = {'$','8',0}; static const WCHAR idx9W[] = {'$','9',0}; -static const WCHAR emptyW[] = {0}; - static inline RegExpInstance *regexp_from_vdisp(vdisp_t *vdisp) { return (RegExpInstance*)vdisp->u.jsdisp;

1 0